X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=actions%2Fprofilesettings.php;h=14c725ff91364ea4f87abcf9cc20301b431e6636;hb=661202be3e28eeffeacb8cbfbec88a7352bcce55;hp=ad4bb968ffb0a9deb5f3f12415a988f2a3ad1734;hpb=721d6f94c72816e802b813c132d39fc7ef08c680;p=quix0rs-gnu-social.git diff --git a/actions/profilesettings.php b/actions/profilesettings.php index ad4bb968ff..14c725ff91 100644 --- a/actions/profilesettings.php +++ b/actions/profilesettings.php @@ -24,38 +24,48 @@ require_once(INSTALLDIR.'/lib/settingsaction.php'); class ProfilesettingsAction extends SettingsAction { function get_instructions() { - return _t('You can update your personal profile info here '. + return _('You can update your personal profile info here '. 'so people know more about you.'); } function show_form($msg=NULL, $success=false) { $user = common_current_user(); $profile = $user->getProfile(); - $this->form_header(_t('Profile settings'), $msg, $success); + $this->form_header(_('Profile settings'), $msg, $success); common_element_start('form', array('method' => 'post', 'id' => 'profilesettings', 'action' => common_local_url('profilesettings'))); + common_hidden('token', common_session_token()); # too much common patterns here... abstractable? - common_input('nickname', _t('Nickname'), + common_input('nickname', _('Nickname'), ($this->arg('nickname')) ? $this->arg('nickname') : $profile->nickname, - _t('1-64 lowercase letters or numbers, no punctuation or spaces')); - common_input('fullname', _t('Full name'), + _('1-64 lowercase letters or numbers, no punctuation or spaces')); + common_input('fullname', _('Full name'), ($this->arg('fullname')) ? $this->arg('fullname') : $profile->fullname); - common_input('email', _t('Email address'), - ($this->arg('email')) ? $this->arg('email') : $user->email, - _t('Used only for updates, announcements, and password recovery')); - common_input('homepage', _t('Homepage'), + common_input('homepage', _('Homepage'), ($this->arg('homepage')) ? $this->arg('homepage') : $profile->homepage, - _t('URL of your homepage, blog, or profile on another site')); - common_textarea('bio', _t('Bio'), + _('URL of your homepage, blog, or profile on another site')); + common_textarea('bio', _('Bio'), ($this->arg('bio')) ? $this->arg('bio') : $profile->bio, - _t('Describe yourself and your interests in 140 chars')); - common_input('location', _t('Location'), + _('Describe yourself and your interests in 140 chars')); + common_input('location', _('Location'), ($this->arg('location')) ? $this->arg('location') : $profile->location, - _t('Where you are, like "City, State (or Region), Country"')); - common_submit('submit', _t('Save')); + _('Where you are, like "City, State (or Region), Country"')); + + $language = common_language(); + common_dropdown('language', _('Language'), get_nice_language_list(), _('Preferred language'), TRUE, $language); + $timezone = common_timezone(); + $timezones = array(); + foreach(DateTimeZone::listIdentifiers() as $k => $v) { + $timezones[$v] = $v; + } + common_dropdown('timezone', _('Timezone'), $timezones, _('What timezone are you normally in?'), TRUE, $timezone); + + common_checkbox('autosubscribe', _('Automatically subscribe to whoever subscribes to me (best for non-humans)'), + ($this->arg('autosubscribe')) ? $this->boolean('autosubscribe') : $user->autosubscribe); + common_submit('submit', _('Save')); common_element_end('form'); common_show_footer(); } @@ -64,94 +74,102 @@ class ProfilesettingsAction extends SettingsAction { $nickname = $this->trimmed('nickname'); $fullname = $this->trimmed('fullname'); - $email = $this->trimmed('email'); $homepage = $this->trimmed('homepage'); $bio = $this->trimmed('bio'); $location = $this->trimmed('location'); + $autosubscribe = $this->boolean('autosubscribe'); + $language = $this->trimmed('language'); + $timezone = $this->trimmed('timezone'); - # Some validation + # CSRF protection - if ($email && !Validate::email($email, true)) { - $this->show_form(_t('Not a valid email address.')); + $token = $this->trimmed('token'); + if (!$token || $token != common_session_token()) { + $this->show_form(_('There was a problem with your session token. Try again, please.')); return; - } else if (!Validate::string($nickname, array('min_length' => 1, - 'max_length' => 64, - 'format' => VALIDATE_NUM . VALIDATE_ALPHA_LOWER))) { - $this->show_form(_t('Nickname must have only letters and numbers and no spaces.')); + } + + # Some validation + + if (!Validate::string($nickname, array('min_length' => 1, + 'max_length' => 64, + 'format' => VALIDATE_NUM . VALIDATE_ALPHA_LOWER))) { + $this->show_form(_('Nickname must have only lowercase letters and numbers and no spaces.')); return; } else if (!User::allowed_nickname($nickname)) { - $this->show_form(_t('Not a valid nickname.')); + $this->show_form(_('Not a valid nickname.')); return; } else if (!is_null($homepage) && (strlen($homepage) > 0) && !Validate::uri($homepage, array('allowed_schemes' => array('http', 'https')))) { - $this->show_form(_t('Homepage is not a valid URL.')); + $this->show_form(_('Homepage is not a valid URL.')); return; } else if (!is_null($fullname) && strlen($fullname) > 255) { - $this->show_form(_t('Fullname is too long (max 255 chars).')); + $this->show_form(_('Full name is too long (max 255 chars).')); return; } else if (!is_null($bio) && strlen($bio) > 140) { - $this->show_form(_t('Bio is too long (max 140 chars).')); + $this->show_form(_('Bio is too long (max 140 chars).')); return; } else if (!is_null($location) && strlen($location) > 255) { - $this->show_form(_t('Location is too long (max 255 chars).')); + $this->show_form(_('Location is too long (max 255 chars).')); return; - } else if ($this->nickname_exists($nickname)) { - $this->show_form(_t('Nickname already exists.')); + } else if (is_null($timezone) || !in_array($timezone, DateTimeZone::listIdentifiers())) { + $this->show_form(_('Timezone not selected.')); return; - } else if ($this->email_exists($email)) { - $this->show_form(_t('Email address already exists.')); + } else if ($this->nickname_exists($nickname)) { + $this->show_form(_('Nickname already in use. Try another one.')); return; + } else if (!is_null($language) && strlen($language) > 50) { + $this->show_form(_('Language is too long (max 50 chars).')); } $user = common_current_user(); $user->query('BEGIN'); - if ($user->nickname != $nickname) { + if ($user->nickname != $nickname || + $user->language != $language || + $user->timezone != $timezone) { common_debug('Updating user nickname from ' . $user->nickname . ' to ' . $nickname, __FILE__); + common_debug('Updating user language from ' . $user->language . ' to ' . $language, + __FILE__); + common_debug('Updating user timezone from ' . $user->timezone . ' to ' . $timezone, + __FILE__); $original = clone($user); $user->nickname = $nickname; + $user->language = $language; + $user->timezone = $timezone; $result = $user->updateKeys($original); if ($result === FALSE) { common_log_db_error($user, 'UPDATE', __FILE__); - common_server_error(_t('Couldnt update user.')); + common_server_error(_('Couldn\'t update user.')); return; + } else { + # Re-initialize language environment if it changed + common_init_language(); } } - if ($user->email != $email) { + # XXX: XOR - common_debug('Updating user email from ' . $user->email . ' to ' . $email, - __FILE__); - - # We don't update email directly; it gets done by confirmemail + if ($user->autosubscribe ^ $autosubscribe) { - $confirm = new Confirm_address(); + $original = clone($user); - $confirm->code = common_confirmation_code(128); - $confirm->user_id = $user->id; - $confirm->address = $email; - $confirm->address_type = 'email'; + $user->autosubscribe = $autosubscribe; - $result = $confirm->insert(); + $result = $user->update($original); - if (!$result) { - common_log_db_error($confirm, 'INSERT', __FILE__); - common_server_error(_t('Couldnt confirm email.')); - return FALSE; + if ($result === FALSE) { + common_log_db_error($user, 'UPDATE', __FILE__); + common_server_error(_('Couldn\'t update user for autosubscribe.')); + return; } - - # XXX: try not to do this in the middle of a transaction - - mail_confirm_address($confirm->code, - $profile->nickname, - $email); } $profile = $user->getProfile(); @@ -172,7 +190,7 @@ class ProfilesettingsAction extends SettingsAction { if (!$result) { common_log_db_error($profile, 'UPDATE', __FILE__); - common_server_error(_t('Couldnt save profile.')); + common_server_error(_('Couldn\'t save profile.')); return; } @@ -180,7 +198,7 @@ class ProfilesettingsAction extends SettingsAction { common_broadcast_profile($profile); - $this->show_form(_t('Settings saved.'), TRUE); + $this->show_form(_('Settings saved.'), TRUE); } function nickname_exists($nickname) { @@ -192,14 +210,4 @@ class ProfilesettingsAction extends SettingsAction { return $other->id != $user->id; } } - - function email_exists($email) { - $user = common_current_user(); - $other = User::staticGet('email', $email); - if (!$other) { - return false; - } else { - return $other->id != $user->id; - } - } }