X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=actions%2Fprofilesettings.php;h=a5682b23bd7049fa0dbadea25eb801212a8992c1;hb=e468474fe85f9b5f53663b798ed7b6d1c0cb4ea8;hp=fc06c5a188212c8a7d63009b7cb45ab0cac81729;hpb=2080f52cb1dd08b01b6af3bffc726b1db673f7f5;p=quix0rs-gnu-social.git diff --git a/actions/profilesettings.php b/actions/profilesettings.php index fc06c5a188..a5682b23bd 100644 --- a/actions/profilesettings.php +++ b/actions/profilesettings.php @@ -1,18 +1,18 @@ . */ @@ -22,76 +22,142 @@ if (!defined('LACONICA')) { exit(1); } require_once(INSTALLDIR.'/lib/settingsaction.php'); class ProfilesettingsAction extends SettingsAction { - + function show_form($msg=NULL, $success=false) { $user = common_current_user(); $profile = $user->getProfile(); - common_show_header(_t('Profile settings')); - $this->settings_menu(); - $this->message($msg, $success); + common_show_header(_t('Profile settings'), NULL, NULL, array($this, 'settings_menu')); + + if ($msg) { + $this->message($msg, $success); + } else { + common_element('div', 'instructions', + _t('You can update your personal profile info here '. + 'so people know more about you. ')); + } common_element_start('form', array('method' => 'POST', 'id' => 'profilesettings', - 'action' => + 'action' => common_local_url('profilesettings'))); # too much common patterns here... abstractable? - common_input('nickname', _t('Nickname'), - ($this->arg('nickname')) ? $this->arg('nickname') : $profile->nickname); + common_input('nickname', _t('Nickname'), + ($this->arg('nickname')) ? $this->arg('nickname') : $profile->nickname, + _t('1-64 lowercase letters or numbers, no punctuation or spaces')); common_input('fullname', _t('Full name'), ($this->arg('fullname')) ? $this->arg('fullname') : $profile->fullname); common_input('email', _t('Email address'), - ($this->arg('email')) ? $this->arg('email') : $user->email); + ($this->arg('email')) ? $this->arg('email') : $user->email, + _t('Used only for updates, announcements, and password recovery')); common_input('homepage', _t('Homepage'), - ($this->arg('homepage')) ? $this->arg('homepage') : $profile->homepage); - common_input('bio', _t('Bio'), - ($this->arg('bio')) ? $this->arg('bio') : $profile->bio); + ($this->arg('homepage')) ? $this->arg('homepage') : $profile->homepage, + _t('URL of your homepage, blog, or profile on another site')); + common_textarea('bio', _t('Bio'), + ($this->arg('bio')) ? $this->arg('bio') : $profile->bio, + _t('Describe yourself and your interests in 140 chars')); common_input('location', _t('Location'), - ($this->arg('location')) ? $this->arg('location') : $profile->location); - common_element('input', array('name' => 'submit', - 'type' => 'submit', - 'id' => 'submit', - 'value' => _t('Save'))); + ($this->arg('location')) ? $this->arg('location') : $profile->location, + _t('Where you are, like "City, State (or Region), Country"')); + common_submit('submit', _t('Save')); common_element_end('form'); common_show_footer(); } - + function handle_post() { - $nickname = $this->arg('nickname'); - $fullname = $this->arg('fullname'); - $email = $this->arg('email'); - $homepage = $this->arg('homepage'); - $bio = $this->arg('bio'); - $location = $this->arg('location'); + + $nickname = $this->trimmed('nickname'); + $fullname = $this->trimmed('fullname'); + $email = $this->trimmed('email'); + $homepage = $this->trimmed('homepage'); + $bio = $this->trimmed('bio'); + $location = $this->trimmed('location'); + # Some validation + + if (!Validate::email($email, true)) { + $this->show_form(_t('Not a valid email address.')); + return; + } else if (!Validate::string($nickname, array('min_length' => 1, + 'max_length' => 64, + 'format' => VALIDATE_NUM . VALIDATE_ALPHA_LOWER))) { + $this->show_form(_t('Nickname must have only letters and numbers and no spaces.')); + return; + } else if (!is_null($homepage) && (strlen($homepage) > 0) && + !Validate::uri($homepage, array('allowed_schemes' => array('http', 'https')))) { + $this->show_form(_t('Homepage is not a valid URL.')); + return; + } else if (!is_null($fullname) && strlen($fullname) > 255) { + $this->show_form(_t('Fullname is too long (max 255 chars).')); + return; + } else if (!is_null($bio) && strlen($bio) > 140) { + $this->show_form(_t('Bio is too long (max 140 chars).')); + return; + } else if (!is_null($location) && strlen($location) > 255) { + $this->show_form(_t('Location is too long (max 255 chars).')); + return; + } else if ($this->nickname_exists($nickname)) { + $this->show_form(_t('Nickname already exists.')); + return; + } else if ($this->email_exists($email)) { + $this->show_form(_t('Email address already exists.')); + return; + } + $user = common_current_user(); assert(!is_null($user)); # should already be checked - - # FIXME: scrub input + # FIXME: transaction! $original = clone($user); + + $user->nickname = $nickname; + $user->email = $email; + + common_debug('Updating, nickname ="'.$user->nickname.'" and email ="'.$user->email.'"'); + common_debug('Original, nickname ="'.$original->nickname.'" and email ="'.$original->email.'"'); - $user->nickname = $this->arg('nickname'); - $user->email = $this->arg('email'); - - if (!$user->update($original)) { + if (FALSE === $user->update($original)) { common_server_error(_t('Couldnt update user.')); return; } $profile = $user->getProfile(); + $orig_profile = clone($profile); + $profile->nickname = $user->nickname; - $profile->fullname = $this->arg('fullname'); - $profile->homepage = $this->arg('homepage'); - $profile->bio = $this->arg('bio'); - $profile->location = $this->arg('location'); + $profile->fullname = $fullname; + $profile->homepage = $homepage; + $profile->bio = $bio; + $profile->location = $location; $profile->profileurl = common_profile_url($nickname); - - if (!$profile->update()) { + + if (FALSE === $profile->update($orig_profile)) { common_server_error(_t('Couldnt save profile.')); return; } + + common_broadcast_profile($profile); $this->show_form(_t('Settings saved.'), TRUE); } + + function nickname_exists($nickname) { + $user = common_current_user(); + $other = User::staticGet('nickname', $nickname); + if (!$other) { + return false; + } else { + return $other->id != $user->id; + } + } + + function email_exists($email) { + $user = common_current_user(); + $other = User::staticGet('email', $email); + if (!$other) { + return false; + } else { + return $other->id != $user->id; + } + } } \ No newline at end of file