X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=classes%2FSession.php;h=79a69a96ea3dc11b1f93672890f1687f2e263fa0;hb=505cd382f3d0d37f3d9581a907877e644b5118fd;hp=5c48e4aa90bae9f80bf0eafb0998b44f05439c6f;hpb=7af94dc12562b8114f0f823dc8438234125022da;p=quix0rs-gnu-social.git

diff --git a/classes/Session.php b/classes/Session.php
index 5c48e4aa90..79a69a96ea 100644
--- a/classes/Session.php
+++ b/classes/Session.php
@@ -2,8 +2,8 @@
 /**
  * Table Definition for session
  *
- * Laconica - a distributed open-source microblogging tool
- * Copyright (C) 2009, Control Yourself, Inc.
+ * StatusNet - the distributed open-source microblogging tool
+ * Copyright (C) 2009, StatusNet, Inc.
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU Affero General Public License as published by
@@ -19,7 +19,7 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-if (!defined('LACONICA')) { exit(1); }
+if (!defined('STATUSNET') && !defined('LACONICA')) { exit(1); }
 
 require_once INSTALLDIR.'/classes/Memcached_DataObject.php';
 
@@ -42,7 +42,9 @@ class Session extends Memcached_DataObject
 
     static function logdeb($msg)
     {
-        common_debug("Session: " . $msg);
+        if (common_config('sessions', 'debug')) {
+            common_debug("Session: " . $msg);
+        }
     }
 
     static function open($save_path, $session_name)
@@ -83,9 +85,18 @@ class Session extends Memcached_DataObject
 
             return $session->insert();
         } else {
-            $session->session_data = $session_data;
+            if (strcmp($session->session_data, $session_data) == 0) {
+                self::logdeb("Not writing session '$id'; unchanged");
+                return true;
+            } else {
+                self::logdeb("Session '$id' data changed; updating");
+
+                $orig = clone($session);
+
+                $session->session_data = $session_data;
 
-            return $session->update();
+                return $session->update($orig);
+            }
         }
     }
 
@@ -104,16 +115,26 @@ class Session extends Memcached_DataObject
     {
         self::logdeb("garbage collection (maxlifetime = $maxlifetime)");
 
-        $epoch = time() - $maxlifetime;
+        $epoch = common_sql_date(time() - $maxlifetime);
 
-        $qry = 'DELETE FROM session ' .
-          'WHERE modified < "'.$epoch.'"';
+        $ids = array();
 
         $session = new Session();
+        $session->whereAdd('modified < "'.$epoch.'"');
+        $session->selectAdd();
+        $session->selectAdd('id');
 
-        $result = $session->query($qry);
+        $session->find();
 
-        self::logdeb("garbage collection result = $result");
+        while ($session->fetch()) {
+            $ids[] = $session->id;
+        }
+
+        $session->free();
+
+        foreach ($ids as $id) {
+            self::destroy($id);
+        }
     }
 
     static function setSaveHandler()