X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=facebook%2Ffacebook.php;h=f2e965c422ea54baeb48937c8c24a998b1287f2d;hb=18784a484b04b5f74e6d4dca516b2dc20cffe953;hp=9c079a26f1ea7f6f181fa97386d243b73351494c;hpb=267c64d41b5ad48a8274407e383dca3c25d034ed;p=friendica-addons.git diff --git a/facebook/facebook.php b/facebook/facebook.php index 9c079a26..f2e965c4 100644 --- a/facebook/facebook.php +++ b/facebook/facebook.php @@ -3,7 +3,8 @@ * Name: Facebook Connector * Version: 1.3 * Author: Mike Macgirvin - * Tobias Hößl + * Author: Tobias Hößl + * Status: Unsupported */ /** @@ -12,15 +13,15 @@ * Detailed instructions how to use this plugin can be found at * https://github.com/friendica/friendica/wiki/How-to:-Friendica%E2%80%99s-Facebook-connector * - * Vidoes and embeds will not be posted if there is no other content. Links - * and images will be converted to a format suitable for the Facebook API and - * long posts truncated - with a link to view the full post. + * Vidoes and embeds will not be posted if there is no other content. Links + * and images will be converted to a format suitable for the Facebook API and + * long posts truncated - with a link to view the full post. * * Facebook contacts will not be able to view private photos, as they are not able to - * authenticate to your site to establish identity. We will address this + * authenticate to your site to establish identity. We will address this * in a future release. */ - + /** TODO * - Implement a method for the administrator to delete all configuration data the plugin has created, * e.g. the app_access_token @@ -79,38 +80,38 @@ function facebook_init(&$a) { if (x($_REQUEST, "realtime_cb") && x($_REQUEST, "realtime_cb")) { logger("facebook_init: Facebook Real-Time callback called", LOGGER_DEBUG); - + if (x($_REQUEST, "hub_verify_token")) { // this is the verification callback while registering for real time updates - + $verify_token = get_config('facebook', 'cb_verify_token'); if ($verify_token != $_REQUEST["hub_verify_token"]) { logger('facebook_init: Wrong Facebook Callback Verifier - expected ' . $verify_token . ', got ' . $_REQUEST["hub_verify_token"]); return; } - + if (x($_REQUEST, "hub_challenge")) { logger('facebook_init: Answering Challenge: ' . $_REQUEST["hub_challenge"], LOGGER_DATA); echo $_REQUEST["hub_challenge"]; die(); } } - + require_once('include/items.php'); - + // this is a status update $content = file_get_contents("php://input"); if (is_numeric($content)) $content = file_get_contents("php://input"); $js = json_decode($content); logger(print_r($js, true), LOGGER_DATA); - + if (!isset($js->object) || $js->object != "user" || !isset($js->entry)) { logger('facebook_init: Could not parse Real-Time Update data', LOGGER_DEBUG); return; } - + $affected_users = array("feed" => array(), "friends" => array()); - + foreach ($js->entry as $entry) { $fbuser = $entry->uid; foreach ($entry->changed_fields as $field) { @@ -119,20 +120,20 @@ function facebook_init(&$a) { continue; } if (in_array($fbuser, $affected_users[$field])) continue; - + $r = q("SELECT `uid` FROM `pconfig` WHERE `cat` = 'facebook' AND `k` = 'self_id' AND `v` = '%s' LIMIT 1", dbesc($fbuser)); if(! count($r)) continue; $uid = $r[0]['uid']; - + $access_token = get_pconfig($uid,'facebook','access_token'); if(! $access_token) return; - + switch ($field) { case "feed": logger('facebook_init: FB-User ' . $fbuser . ' / feed', LOGGER_DEBUG); - + if(! get_pconfig($uid,'facebook','no_wall')) { $private_wall = intval(get_pconfig($uid,'facebook','private_wall')); $s = fetch_url('https://graph.facebook.com/me/feed?access_token=' . $access_token); @@ -146,11 +147,11 @@ function facebook_init(&$a) { } } } - + break; case "friends": logger('facebook_init: FB-User ' . $fbuser . ' / friends', LOGGER_DEBUG); - + fb_get_friends($uid, false); set_pconfig($uid,'facebook','friend_check',time()); break; @@ -162,10 +163,11 @@ function facebook_init(&$a) { } } - if($a->argc != 2) return; + $nick = $a->argv[1]; + if(strlen($nick)) $r = q("SELECT `uid` FROM `user` WHERE `nickname` = '%s' LIMIT 1", dbesc($nick) @@ -188,7 +190,7 @@ function facebook_init(&$a) { $x = fetch_url('https://graph.facebook.com/oauth/access_token?client_id=' . $appid . '&client_secret=' . $appsecret . '&redirect_uri=' - . urlencode($a->get_baseurl() . '/facebook/' . $nick) + . urlencode($a->get_baseurl() . '/facebook/' . $nick) . '&code=' . $auth_code); logger('facebook_init: returned access token: ' . $x, LOGGER_DATA); @@ -258,7 +260,7 @@ function fb_get_friends_sync_parsecontact($uid, $contact) { $contact->link = 'http://facebook.com/profile.php?id=' . $contact->id; // If its a page then set the first name from the username - if (!$contact->first_name and $contact->username) + if (!$contact->first_name && $contact->username) $contact->first_name = $contact->username; // check if we already have a contact @@ -270,9 +272,13 @@ function fb_get_friends_sync_parsecontact($uid, $contact) { if(count($r)) { + // update profile photos once every two weeks as we have no notification of when they change. + + $update_photo = (($r[0]['avatar-date'] < datetime_convert('','','now -14 days')) ? true : false); + // check that we have all the photos, this has been known to fail on occasion - if((! $r[0]['photo']) || (! $r[0]['thumb']) || (! $r[0]['micro'])) { + if((! $r[0]['photo']) || (! $r[0]['thumb']) || (! $r[0]['micro']) || ($update_photo)) { require_once("Photo.php"); $photos = import_profile_photo('https://graph.facebook.com/' . $contact->id . '/picture', $uid, $r[0]['id']); @@ -283,7 +289,7 @@ function fb_get_friends_sync_parsecontact($uid, $contact) { `name-date` = '%s', `uri-date` = '%s', `avatar-date` = '%s' - WHERE `id` = %d LIMIT 1 + WHERE `id` = %d ", dbesc($photos[0]), dbesc($photos[1]), @@ -312,7 +318,7 @@ function fb_get_friends_sync_parsecontact($uid, $contact) { dbesc($contact->id), dbesc('facebook ' . $contact->id), dbesc($contact->name), - dbesc(($contact->nickname) ? $contact->nickname : strtolower($contact->first_name)), + dbesc(($contact->nickname) ? $contact->nickname : mb_convert_case($contact->first_name, MB_CASE_LOWER, "UTF-8")), dbesc('https://graph.facebook.com/' . $contact->id . '/picture'), dbesc(NETWORK_FACEBOOK), intval(CONTACT_IS_FRIEND), @@ -332,6 +338,14 @@ function fb_get_friends_sync_parsecontact($uid, $contact) { $contact_id = $r[0]['id']; + $g = q("select def_gid from user where uid = %d limit 1", + intval($uid) + ); + if($g && intval($g[0]['def_gid'])) { + require_once('include/group.php'); + group_add_member($uid,'',$contact_id,$g[0]['def_gid']); + } + require_once("Photo.php"); $photos = import_profile_photo($r[0]['photo'],$uid,$contact_id); @@ -342,7 +356,7 @@ function fb_get_friends_sync_parsecontact($uid, $contact) { `name-date` = '%s', `uri-date` = '%s', `avatar-date` = '%s' - WHERE `id` = %d LIMIT 1 + WHERE `id` = %d ", dbesc($photos[0]), dbesc($photos[1]), @@ -369,10 +383,12 @@ function fb_get_friends_sync_full($uid, $access_token, $persons) { if($s) { $results = json_decode($s); logger('fb_get_friends: info: ' . print_r($results,true), LOGGER_DATA); - foreach ($results as $contact) { - if ($contact->code != 200) logger('fb_get_friends: not found: ' . print_r($contact,true), LOGGER_DEBUG); - else fb_get_friends_sync_parsecontact($uid, json_decode($contact->body)); - } + if(count($results)) { + foreach ($results as $contact) { + if ($contact->code != 200) logger('fb_get_friends: not found: ' . print_r($contact,true), LOGGER_DEBUG); + else fb_get_friends_sync_parsecontact($uid, json_decode($contact->body)); + } + } } } } @@ -396,6 +412,7 @@ function fb_get_friends($uid, $fullsync = true) { $access_token = get_pconfig($uid,'facebook','access_token'); $no_linking = get_pconfig($uid,'facebook','no_linking'); + if($no_linking) return; @@ -403,7 +420,7 @@ function fb_get_friends($uid, $fullsync = true) { return; $s = fetch_url('https://graph.facebook.com/me/friends?access_token=' . $access_token); if($s) { - logger('facebook: fb_get_friends: ' . $s, LOGGER_DATA); + logger('facebook: fb_gwet_friends: ' . $s, LOGGER_DATA); $j = json_decode($s); logger('facebook: fb_get_friends: json: ' . print_r($j,true), LOGGER_DATA); if(! $j->data) @@ -420,7 +437,7 @@ function fb_get_friends($uid, $fullsync = true) { } // This is the POST method to the facebook settings page -// Content is posted to Facebook in the function facebook_post_hook() +// Content is posted to Facebook in the function facebook_post_hook() /** * @param App $a @@ -430,6 +447,10 @@ function facebook_post(&$a) { $uid = local_user(); if($uid){ + + $fb_limited = get_config('facebook','crestrict'); + + $value = ((x($_POST,'post_by_default')) ? intval($_POST['post_by_default']) : 0); set_pconfig($uid,'facebook','post_by_default', $value); @@ -440,12 +461,18 @@ function facebook_post(&$a) { $private_wall = ((x($_POST,'facebook_private_wall')) ? intval($_POST['facebook_private_wall']) : 0); set_pconfig($uid,'facebook','private_wall',$private_wall); - + set_pconfig($uid,'facebook','blocked_apps',escape_tags(trim($_POST['blocked_apps']))); $linkvalue = ((x($_POST,'facebook_linking')) ? intval($_POST['facebook_linking']) : 0); - set_pconfig($uid,'facebook','no_linking', (($linkvalue) ? 0 : 1)); + + if($fb_limited) { + if($linkvalue == 0) + set_pconfig($uid,'facebook','no_linking', 1); + } + else + set_pconfig($uid,'facebook','no_linking', (($linkvalue) ? 0 : 1)); // FB linkage was allowed but has just been turned off - remove all FB contacts and posts @@ -468,9 +495,9 @@ function facebook_post(&$a) { } info( t('Settings updated.') . EOL); - } + } - return; + return; } // Facebook settings form @@ -486,6 +513,13 @@ function facebook_content(&$a) { return ''; } + + if(! service_class_allows(local_user(),'facebook_connect')) { + notice( t('Permission denied.') . EOL); + return upgrade_bool_message(); + } + + if($a->argc > 1 && $a->argv[1] === 'remove') { del_pconfig(local_user(),'facebook','post'); info( t('Facebook disabled') . EOL); @@ -496,8 +530,11 @@ function facebook_content(&$a) { info( t('Updating contacts') . EOL); } + + $fb_limited = get_config('facebook','restrict'); + $o = ''; - + $fb_installed = false; if (get_pconfig(local_user(),'facebook','post')) { $access_token = get_pconfig(local_user(),'facebook','access_token'); @@ -509,7 +546,7 @@ function facebook_content(&$a) { } } } - + $appid = get_config('facebook','appid'); if(! $appid) { @@ -522,10 +559,10 @@ function facebook_content(&$a) { $o .= '

' . t('Facebook Connect') . '

'; - if(! $fb_installed) { + if(! $fb_installed) { $o .= ''; } @@ -537,10 +574,10 @@ function facebook_content(&$a) { $o .= ''; - + $o .= '
'; $o .= '
'; $post_by_default = get_pconfig(local_user(),'facebook','post_by_default'); @@ -549,6 +586,15 @@ function facebook_content(&$a) { $no_linking = get_pconfig(local_user(),'facebook','no_linking'); $checked = (($no_linking) ? '' : ' checked="checked" '); + if($fb_limited) { + if($no_linking) { + $o .= EOL . '' . t('Facebook friend linking has been disabled on this site. The following settings will have no effect.') . '' . EOL; + $checked .= " disabled "; + } + else { + $o .= EOL . '' . t('Facebook friend linking has been disabled on this site. If you disable it, you will be unable to re-enable it.') . '' . EOL; + } + } $o .= '' . ' ' . t('Link all your Facebook friends and conversations on this website') . EOL ; $o .= '

' . t('Facebook conversations consist of your profile wall and your friend stream.'); @@ -572,7 +618,7 @@ function facebook_content(&$a) { $o .= '

'; $o .= '
'; - $o .= '
'; + $o .= ''; } return $o; @@ -587,14 +633,14 @@ function facebook_content(&$a) { function facebook_cron($a,$b) { $last = get_config('facebook','last_poll'); - + $poll_interval = intval(get_config('facebook','poll_interval')); if(! $poll_interval) $poll_interval = FACEBOOK_DEFAULT_POLL_INTERVAL; if($last) { $next = $last + ($poll_interval * 60); - if($next > time()) + if($next > time()) return; } @@ -603,7 +649,7 @@ function facebook_cron($a,$b) { // Find the FB users on this site and randomize in case one of them // uses an obscene amount of memory. It may kill this queue run - // but hopefully we'll get a few others through on each run. + // but hopefully we'll get a few others through on each run. $r = q("SELECT * FROM `pconfig` WHERE `cat` = 'facebook' AND `k` = 'post' AND `v` = '1' ORDER BY RAND() "); if(count($r)) { @@ -622,7 +668,7 @@ function facebook_cron($a,$b) { // check for new friends once a day $last_friend_check = get_pconfig($rr['uid'],'facebook','friend_check'); - if($last_friend_check) + if($last_friend_check) $next_friend_check = $last_friend_check + 86400; else $next_friend_check = 0; @@ -633,14 +679,14 @@ function facebook_cron($a,$b) { fb_consume_all($rr['uid']); } } - + if (get_config('facebook', 'realtime_active') == 1) { if (!facebook_check_realtime_active()) { - + logger('facebook_cron: Facebook is not sending Real-Time Updates any more, although it is supposed to. Trying to fix it...', LOGGER_NORMAL); facebook_subscription_add_users(); - - if (facebook_check_realtime_active()) + + if (facebook_check_realtime_active()) logger('facebook_cron: Successful', LOGGER_NORMAL); else { logger('facebook_cron: Failed', LOGGER_NORMAL); @@ -659,7 +705,7 @@ function facebook_cron($a,$b) { . 'Content-type: text/plain; charset=UTF-8' . "\n" . 'Content-transfer-encoding: 8bit' ); - + set_config('facebook', 'realtime_err_mailsent', 1); } } @@ -668,7 +714,7 @@ function facebook_cron($a,$b) { del_config('facebook', 'realtime_first_err'); } } - + set_config('facebook','last_poll', time()); } @@ -696,19 +742,19 @@ function facebook_plugin_admin(&$a, &$o){ $o = ''; - + $o .= '

' . t('Facebook API Key') . '

'; - + $appid = get_config('facebook', 'appid' ); $appsecret = get_config('facebook', 'appsecret' ); $poll_interval = get_config('facebook', 'poll_interval' ); $sync_comments = get_config('facebook', 'sync_comments' ); if (!$poll_interval) $poll_interval = FACEBOOK_DEFAULT_POLL_INTERVAL; - + $ret1 = q("SELECT `v` FROM `config` WHERE `cat` = 'facebook' AND `k` = 'appid' LIMIT 1"); $ret2 = q("SELECT `v` FROM `config` WHERE `cat` = 'facebook' AND `k` = 'appsecret' LIMIT 1"); if ((count($ret1) > 0 && $ret1[0]['v'] != $appid) || (count($ret2) > 0 && $ret2[0]['v'] != $appsecret)) $o .= t('Error: it appears that you have specified the App-ID and -Secret in your .htconfig.php file. As long as they are specified there, they cannot be set using this form.

'); - + $working_connection = false; if ($appid && $appsecret) { $subs = facebook_subscriptions_get(); @@ -716,18 +762,18 @@ function facebook_plugin_admin(&$a, &$o){ elseif (is_array($subs)) { $o .= t('The given API Key seems to work correctly.') . '
'; $working_connection = true; - } else $o .= t('The correctness of the API Key could not be detected. Somthing strange\'s going on.') . '
'; + } else $o .= t('The correctness of the API Key could not be detected. Something strange\'s going on.') . '
'; } - + $o .= '
'; $o .= '
'; $o .= '
'; $o .= '
'; $o .= ''; - + if ($working_connection) { $o .= '

' . t('Real-Time Updates') . '

'; - + $activated = facebook_check_realtime_active(); if ($activated) { $o .= t('Real-Time Updates are activated.') . '

'; @@ -744,7 +790,7 @@ function facebook_plugin_admin(&$a, &$o){ function facebook_plugin_admin_post(&$a){ check_form_security_token_redirectOnErr('/admin/plugins/facebook', 'fbsave'); - + if (x($_REQUEST,'fb_save_keys')) { set_config('facebook', 'appid', $_REQUEST['appid']); set_config('facebook', 'appsecret', $_REQUEST['appsecret']); @@ -775,8 +821,8 @@ function facebook_jot_nets(&$a,&$b) { if(intval($fb_post) == 1) { $fb_defpost = get_pconfig(local_user(),'facebook','post_by_default'); $selected = ((intval($fb_defpost) == 1) ? ' checked="checked" ' : ''); - $b .= '
' - . t('Post to Facebook') . '
'; + $b .= '
' + . t('Post to Facebook') . '
'; } } @@ -831,10 +877,10 @@ function facebook_post_hook(&$a,&$b) { return; // only accept comments from the item owner. Other contacts are unknown to FB. - + if(! link_compare($b['author-link'], $a->get_baseurl() . '/profile/' . $u[0]['nickname'])) return; - + logger('facebook reply id=' . $reply); } @@ -852,7 +898,7 @@ function facebook_post_hook(&$a,&$b) { $allow_str = dbesc(implode(', ',$recipients)); if($allow_str) { - $r = q("SELECT `notify` FROM `contact` WHERE `id` IN ( $allow_str ) AND `network` = 'face'"); + $r = q("SELECT `notify` FROM `contact` WHERE `id` IN ( $allow_str ) AND `network` = 'face'"); if(count($r)) foreach($r as $rr) $allow_arr[] = $rr['notify']; @@ -860,7 +906,7 @@ function facebook_post_hook(&$a,&$b) { $deny_str = dbesc(implode(', ',$deny)); if($deny_str) { - $r = q("SELECT `notify` FROM `contact` WHERE `id` IN ( $deny_str ) AND `network` = 'face'"); + $r = q("SELECT `notify` FROM `contact` WHERE `id` IN ( $deny_str ) AND `network` = 'face'"); if(count($r)) foreach($r as $rr) $deny_arr[] = $rr['notify']; @@ -870,8 +916,8 @@ function facebook_post_hook(&$a,&$b) { // One or more FB folks were denied access but nobody on FB was specifically allowed access. // This might cause the post to be open to public on Facebook, but only to selected members - // on another network. Since this could potentially leak a post to somebody who was denied, - // we will skip posting it to Facebook with a slightly vague but relevant message that will + // on another network. Since this could potentially leak a post to somebody who was denied, + // we will skip posting it to Facebook with a slightly vague but relevant message that will // hopefully lead somebody to this code comment for a better explanation of what went wrong. notice( t('Post to Facebook cancelled because of multi-network access permission conflict.') . EOL); @@ -886,7 +932,7 @@ function facebook_post_hook(&$a,&$b) { } if($b['verb'] == ACTIVITY_LIKE) - $likes = true; + $likes = true; $appid = get_config('facebook', 'appid' ); @@ -899,14 +945,14 @@ function facebook_post_hook(&$a,&$b) { $fb_token = get_pconfig($b['uid'],'facebook','access_token'); - // post to facebook if it's a public post and we've ticked the 'post to Facebook' box, + // post to facebook if it's a public post and we've ticked the 'post to Facebook' box, // or it's a private message with facebook participants - // or it's a reply or likes action to an existing facebook post + // or it's a reply or likes action to an existing facebook post if($fb_token && ($toplevel || $b['private'] || $reply)) { logger('facebook: able to post'); require_once('library/facebook.php'); - require_once('include/bbcode.php'); + require_once('include/bbcode.php'); $msg = $b['body']; @@ -933,7 +979,7 @@ function facebook_post_hook(&$a,&$b) { } } - // strip tag links to avoid link clutter, this really should be + // strip tag links to avoid link clutter, this really should be // configurable because we're losing information $msg = preg_replace("/\#\[url=(.*?)\](.*?)\[\/url\]/is",'#$2',$msg); @@ -962,6 +1008,10 @@ function facebook_post_hook(&$a,&$b) { if(preg_match("/\[img\](.*?)\[\/img\]/is",$b['body'],$matches)) $image = $matches[1]; + // When saved into the database the content is sent through htmlspecialchars + // That means that we have to decode all image-urls + $image = htmlspecialchars_decode($image); + // Checking for a bookmark element $body = $b['body']; if (strpos($body, "[bookmark") !== false) { @@ -981,7 +1031,7 @@ function facebook_post_hook(&$a,&$b) { } // At first convert the text to html - $html = bbcode($body); + $html = bbcode($body, false, false); // Then convert it to plain text $msg = trim($b['title']." \n\n".html2plain($html, 0, true)); @@ -1045,13 +1095,13 @@ function facebook_post_hook(&$a,&$b) { // Fallback - if message is empty if(!strlen($msg)) - $msg = $link; + $msg = $linkname; if(!strlen($msg)) - $msg = $image; + $msg = $link; if(!strlen($msg)) - $msg = $linkname; + $msg = $image; // If there is nothing to post then exit if(!strlen($msg)) @@ -1059,23 +1109,27 @@ function facebook_post_hook(&$a,&$b) { logger('Facebook post: msg=' . $msg, LOGGER_DATA); - if($likes) { + if($likes) { $postvars = array('access_token' => $fb_token); } else { + // message, picture, link, name, caption, description, source, place, tags $postvars = array( - 'access_token' => $fb_token, + 'access_token' => $fb_token, 'message' => $msg ); - if(isset($image)) { + if(trim($image) != "") { $postvars['picture'] = $image; - //$postvars['type'] = "photo"; } - if(isset($link)) { + if(trim($link) != "") { $postvars['link'] = $link; - //$postvars['type'] = "link"; + + // The following doesn't work - why? + if ((stristr($link,'youtube')) || (stristr($link,'youtu.be')) || (stristr($link,'vimeo'))) { + $postvars['source'] = $link; + } } - if(isset($linkname)) + if(trim($linkname) != "") $postvars['name'] = $linkname; } @@ -1091,15 +1145,15 @@ function facebook_post_hook(&$a,&$b) { if($reply) { $url = 'https://graph.facebook.com/' . $reply . '/' . (($likes) ? 'likes' : 'comments'); - } else if (($link != "") or ($image != "") or ($b['title'] == '') or (strlen($msg) < 500)) { + } else if (($link != "") || ($image != "") || ($b['title'] == '') || (strlen($msg) < 500)) { $url = 'https://graph.facebook.com/me/feed'; if($b['plink']) $postvars['actions'] = '{"name": "' . t('View on Friendica') . '", "link": "' . $b['plink'] . '"}'; } else { // if its only a message and a subject and the message is larger than 500 characters then post it as note $postvars = array( - 'access_token' => $fb_token, - 'message' => bbcode($b['body']), + 'access_token' => $fb_token, + 'message' => bbcode($b['body'], false, false), 'subject' => $b['title'], ); $url = 'https://graph.facebook.com/me/notes'; @@ -1117,7 +1171,7 @@ function facebook_post_hook(&$a,&$b) { $retj = json_decode($x); if($retj->id) { - q("UPDATE `item` SET `extid` = '%s' WHERE `id` = %d LIMIT 1", + q("UPDATE `item` SET `extid` = '%s' WHERE `id` = %d", dbesc('fb::' . $retj->id), intval($b['id']) ); @@ -1129,14 +1183,14 @@ function facebook_post_hook(&$a,&$b) { add_to_queue($a->contact,NETWORK_FACEBOOK,$s); notice( t('Facebook post failed. Queued for retry.') . EOL); } - + if (isset($retj->error) && $retj->error->type == "OAuthException" && $retj->error->code == 190) { logger('Facebook session has expired due to changed password.', LOGGER_DEBUG); - + $last_notification = get_pconfig($b['uid'], 'facebook', 'session_expired_mailsent'); if (!$last_notification || $last_notification < (time() - FACEBOOK_SESSION_ERR_NOTIFICATION_INTERVAL)) { require_once('include/enotify.php'); - + $r = q("SELECT * FROM `user` WHERE `uid` = %d LIMIT 1", intval($b['uid']) ); notification(array( 'uid' => $b['uid'], @@ -1149,7 +1203,7 @@ function facebook_post_hook(&$a,&$b) { 'source_link' => $a->config["system"]["url"], 'source_photo' => $a->config["system"]["url"] . '/images/person-80.jpg', )); - + set_pconfig($b['uid'], 'facebook', 'session_expired_mailsent', time()); } else logger('Facebook: No notification, as the last one was sent on ' . $last_notification, LOGGER_DEBUG); } @@ -1190,8 +1244,12 @@ function facebook_post_local(&$a,&$b) { $fb_enable = (($fb_post && x($_REQUEST,'facebook_enable')) ? intval($_REQUEST['facebook_enable']) : 0); // if API is used, default to the chosen settings - if($_REQUEST['api_source'] && intval(get_pconfig(local_user(),'facebook','post_by_default'))) - $fb_enable = 1; + // but allow a specific override + + if($_REQUEST['api_source'] && intval(get_pconfig(local_user(),'facebook','post_by_default'))) { + if(! x($_REQUEST,'facebook_enable')) + $fb_enable = 1; + } if(! $fb_enable) return; @@ -1223,7 +1281,7 @@ function fb_queue_hook(&$a,&$b) { logger('facebook_queue: run'); - $r = q("SELECT `user`.* FROM `user` LEFT JOIN `contact` on `contact`.`uid` = `user`.`uid` + $r = q("SELECT `user`.* FROM `user` LEFT JOIN `contact` on `contact`.`uid` = `user`.`uid` WHERE `contact`.`self` = 1 AND `contact`.`id` = %d LIMIT 1", intval($x['cid']) ); @@ -1249,11 +1307,11 @@ function fb_queue_hook(&$a,&$b) { $retj = json_decode($j); if($retj->id) { - q("UPDATE `item` SET `extid` = '%s' WHERE `id` = %d LIMIT 1", + q("UPDATE `item` SET `extid` = '%s' WHERE `id` = %d", dbesc('fb::' . $retj->id), intval($item) ); - logger('facebook_queue: success: ' . $j); + logger('facebook_queue: success: ' . $j); remove_queue_item($x['id']); } else { @@ -1321,7 +1379,7 @@ function fb_consume_all($uid) { $access_token = get_pconfig($uid,'facebook','access_token'); if(! $access_token) return; - + if(! get_pconfig($uid,'facebook','no_wall')) { $private_wall = intval(get_pconfig($uid,'facebook','private_wall')); $s = fetch_url('https://graph.facebook.com/me/feed?access_token=' . $access_token); @@ -1687,7 +1745,7 @@ function fb_consume_stream($uid,$j,$wall = false) { } } } - + if($found_blocked) { logger('facebook: blocking application: ' . $datarray['app']); continue; @@ -1702,19 +1760,19 @@ function fb_consume_stream($uid,$j,$wall = false) { $datarray['body'] = (isset($entry->message) ? escape_tags($entry->message) : ''); - if(isset($entry->name) and isset($entry->link)) + if(isset($entry->name) && isset($entry->link)) $datarray['body'] .= "\n\n[bookmark=".$entry->link."]".$entry->name."[/bookmark]"; elseif (isset($entry->name)) $datarray['body'] .= "\n\n[b]" . $entry->name."[/b]"; if(isset($entry->caption)) { - if(!isset($entry->name) and isset($entry->link)) + if(!isset($entry->name) && isset($entry->link)) $datarray['body'] .= "\n\n[bookmark=".$entry->link."]".$entry->caption."[/bookmark]"; else $datarray['body'] .= "[i]" . $entry->caption."[/i]\n"; } - if(!isset($entry->caption) and !isset($entry->name)) { + if(!isset($entry->caption) && !isset($entry->name)) { if (isset($entry->link)) $datarray['body'] .= "\n[url]".$entry->link."[/url]\n"; else @@ -1733,10 +1791,10 @@ function fb_consume_stream($uid,$j,$wall = false) { $datarray['body'] .= "\n[quote]".$quote."[/quote]"; // Only import the picture when the message is no video - // oembed display a picture of the video as well + // oembed display a picture of the video as well if ($entry->type != "video") { if(isset($entry->picture) && isset($entry->link)) { - $datarray['body'] .= "\n" . '[url=' . $entry->link . '][img]'.$entry->picture.'[/img][/url]'; + $datarray['body'] .= "\n" . '[url=' . $entry->link . '][img]'.$entry->picture.'[/img][/url]'; } else { if(isset($entry->picture)) @@ -1747,7 +1805,7 @@ function fb_consume_stream($uid,$j,$wall = false) { } } - if (($datarray['app'] == "Events") and isset($entry->actions)) + if (($datarray['app'] == "Events") && isset($entry->actions)) foreach ($entry->actions as $action) if ($action->name == "View") $datarray['body'] .= " [url=".$action->link."]".$entry->story."[/url]"; @@ -1757,7 +1815,7 @@ function fb_consume_stream($uid,$j,$wall = false) { // $datarray['body'] = $entry->story; // Adding the "story" text to see if there are useful data in it (testing) - //if (($datarray['app'] != "Events") and $entry->story) + //if (($datarray['app'] != "Events") && $entry->story) // $datarray['body'] .= "\n".$entry->story; if(trim($datarray['body']) == '') { @@ -1772,17 +1830,17 @@ function fb_consume_stream($uid,$j,$wall = false) { if (isset($entry->actions)) foreach ($entry->actions as $action) - if (($action->name != "Comment") and ($action->name != "Like")) + if (($action->name != "Comment") && ($action->name != "Like")) $datarray['body'] .= "[url=".$action->link."]".$action->name."[/url]   "; $datarray['body'] = trim($datarray['body']); - //if(($datarray['body'] != '') and ($uid == 1)) + //if(($datarray['body'] != '') && ($uid == 1)) // $datarray['body'] .= "[noparse]".print_r($entry, true)."[/noparse]"; if (isset($entry->place)) { - if ($entry->place->name or $entry->place->location->street or - $entry->place->location->city or $entry->place->location->Denmark) { + if ($entry->place->name || $entry->place->location->street || + $entry->place->location->city || $entry->place->location->Denmark) { $datarray['coord'] = ''; if ($entry->place->name) $datarray['coord'] .= $entry->place->name; @@ -1792,7 +1850,7 @@ function fb_consume_stream($uid,$j,$wall = false) { $datarray['coord'] .= " ".$entry->place->location->city; if ($entry->place->location->country) $datarray['coord'] .= " ".$entry->place->location->country; - } else if ($entry->place->location->latitude and $entry->place->location->longitude) + } else if ($entry->place->location->latitude && $entry->place->location->longitude) $datarray['coord'] = substr($entry->place->location->latitude, 0, 8) .' '.substr($entry->place->location->longitude, 0, 8); } @@ -1873,28 +1931,28 @@ function fb_consume_stream($uid,$j,$wall = false) { * @return bool|string */ function fb_get_app_access_token() { - + $acc_token = get_config('facebook','app_access_token'); - + if ($acc_token !== false) return $acc_token; - + $appid = get_config('facebook','appid'); $appsecret = get_config('facebook', 'appsecret'); - + if ($appid === false || $appsecret === false) { logger('fb_get_app_access_token: appid and/or appsecret not set', LOGGER_DEBUG); return false; } logger('https://graph.facebook.com/oauth/access_token?client_id=' . $appid . '&client_secret=' . $appsecret . '&grant_type=client_credentials', LOGGER_DATA); $x = fetch_url('https://graph.facebook.com/oauth/access_token?client_id=' . $appid . '&client_secret=' . $appsecret . '&grant_type=client_credentials'); - + if(strpos($x,'access_token=') !== false) { logger('fb_get_app_access_token: returned access token: ' . $x, LOGGER_DATA); - + $token = str_replace('access_token=', '', $x); if(strpos($token,'&') !== false) $token = substr($token,0,strpos($token,'&')); - + if ($token == "") { logger('fb_get_app_access_token: empty token: ' . $x, LOGGER_DEBUG); return false; @@ -1910,10 +1968,10 @@ function fb_get_app_access_token() { function facebook_subscription_del_users() { $a = get_app(); $access_token = fb_get_app_access_token(); - + $url = "https://graph.facebook.com/" . get_config('facebook', 'appid' ) . "/subscriptions?access_token=" . $access_token; facebook_delete_url($url); - + if (!facebook_check_realtime_active()) del_config('facebook', 'realtime_active'); } @@ -1923,15 +1981,15 @@ function facebook_subscription_del_users() { function facebook_subscription_add_users($second_try = false) { $a = get_app(); $access_token = fb_get_app_access_token(); - + $url = "https://graph.facebook.com/" . get_config('facebook', 'appid' ) . "/subscriptions?access_token=" . $access_token; - + list($usec, $sec) = explode(" ", microtime()); $verify_token = sha1($usec . $sec . rand(0, 999999999)); set_config('facebook', 'cb_verify_token', $verify_token); - + $cb = $a->get_baseurl() . '/facebook/?realtime_cb=1'; - + $j = post_url($url,array( "object" => "user", "fields" => "feed,friends", @@ -1939,7 +1997,7 @@ function facebook_subscription_add_users($second_try = false) { "verify_token" => $verify_token, )); del_config('facebook', 'cb_verify_token'); - + if ($j) { $x = json_decode($j); logger("Facebook reponse: " . $j, LOGGER_DATA); @@ -1960,10 +2018,10 @@ function facebook_subscription_add_users($second_try = false) { * @return null|array */ function facebook_subscriptions_get() { - + $access_token = fb_get_app_access_token(); if (!$access_token) return null; - + $url = "https://graph.facebook.com/" . get_config('facebook', 'appid' ) . "/subscriptions?access_token=" . $access_token; $j = fetch_url($url); $ret = null; @@ -2001,7 +2059,7 @@ if(! function_exists('facebook_delete_url')) { function facebook_delete_url($url,$headers = null, &$redirects = 0, $timeout = 0) { $a = get_app(); $ch = curl_init($url); - if(($redirects > 8) || (! $ch)) + if(($redirects > 8) || (! $ch)) return false; curl_setopt($ch, CURLOPT_HEADER, true);