X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=fbpost%2Ffbpost.php;h=3e6e6e0e84d69b7400376e4c09dca579c05abced;hb=18784a484b04b5f74e6d4dca516b2dc20cffe953;hp=579fb148c1f25b718d84ac462f4ec3c7e3122a16;hpb=087871cd8d27ce6ea1472db0e0da5e84f47ec5bf;p=friendica-addons.git diff --git a/fbpost/fbpost.php b/fbpost/fbpost.php index 579fb148..3e6e6e0e 100644 --- a/fbpost/fbpost.php +++ b/fbpost/fbpost.php @@ -4,6 +4,7 @@ * Version: 1.3 * Author: Mike Macgirvin * Author: Tobias Hößl + * Status: Unsupported * */ @@ -248,9 +249,10 @@ function fbpost_content(&$a) { $o .= '
'; //read_stream,publish_stream,manage_pages,photo_upload,user_groups,offline_access + //export_stream,read_stream,publish_stream,manage_pages,photo_upload,user_groups,publish_actions,user_friends,share_item,video_upload,status_update - $o .= '' . t('Install Facebook Post connector for this account.') . ''; + $o .= '' . t('Install Facebook Post connector for this account.') . ''; $o .= '
'; } @@ -261,8 +263,10 @@ function fbpost_content(&$a) { $o .= '
'; - $o .= '' . t('Re-authenticate [This is necessary whenever your Facebook password is changed.]') . ''; + //export_stream,read_stream,publish_stream,manage_pages,photo_upload,user_groups,publish_actions,user_friends,share_item,video_upload,status_update + + $o .= '' . t('Re-authenticate [This is necessary whenever your Facebook password is changed.]') . ''; $o .= '
'; $o .= '
'; @@ -408,7 +412,7 @@ function fbpost_jot_nets(&$a,&$b) { if(intval($fb_post) == 1) { $fb_defpost = get_pconfig(local_user(),'facebook','post_by_default'); $selected = ((intval($fb_defpost) == 1) ? ' checked="checked" ' : ''); - $b .= '
' + $b .= '
' . t('Post to Facebook') . '
'; } } @@ -428,7 +432,10 @@ function fbpost_post_hook(&$a,&$b) { logger('fbpost_post_hook: Facebook post first check successful', LOGGER_DEBUG); // if post comes from facebook don't send it back - if(($b['app'] == "Facebook") AND ($b['verb'] != ACTIVITY_LIKE)) + if($b['extid'] == NETWORK_FACEBOOK) + return; + + if(($b['app'] == "Facebook") && ($b['verb'] != ACTIVITY_LIKE)) return; logger('fbpost_post_hook: Facebook post accepted', LOGGER_DEBUG); @@ -466,7 +473,7 @@ function fbpost_post_hook(&$a,&$b) { // A reply to a toplevel post is only allowed for "real" facebook posts if(count($r) && substr($r[0]['uri'],0,4) === 'fb::') $reply = substr($r[0]['uri'],4); - elseif(count($r) && (substr($r[0]['extid'],0,4) === 'fb::') AND ($r[0]['id'] != $r[0]['parent'])) + elseif(count($r) && (substr($r[0]['extid'],0,4) === 'fb::') && ($r[0]['id'] != $r[0]['parent'])) $reply = substr($r[0]['extid'],4); else return; @@ -518,8 +525,8 @@ function fbpost_post_hook(&$a,&$b) { // One or more FB folks were denied access but nobody on FB was specifically allowed access. // This might cause the post to be open to public on Facebook, but only to selected members - // on another network. Since this could potentially leak a post to somebody who was denied, - // we will skip posting it to Facebook with a slightly vague but relevant message that will + // on another network. Since this could potentially leak a post to somebody who was denied, + // we will skip posting it to Facebook with a slightly vague but relevant message that will // hopefully lead somebody to this code comment for a better explanation of what went wrong. notice( t('Post to Facebook cancelled because of multi-network access permission conflict.') . EOL); @@ -640,14 +647,14 @@ function fbpost_post_hook(&$a,&$b) { $post_to_page = get_pconfig($b['uid'],'facebook','post_to_page'); $page_access_token = get_pconfig($b['uid'],'facebook','page_access_token'); - if ((intval($post_to_page) != 0) and ($page_access_token != "")) + if ((intval($post_to_page) != 0) && ($page_access_token != "")) $target = $post_to_page; else $target = "me"; if($reply) { $url = 'https://graph.facebook.com/' . $reply . '/' . (($likes) ? 'likes' : 'comments'); - } else if (($video != "") or (($image == "") and ($link != ""))) { + } else if (($video != "") || (($image == "") && ($link != ""))) { // If it is a link to a video or a link without a preview picture then post it as a link if ($video != "") $link = $video; @@ -660,7 +667,7 @@ function fbpost_post_hook(&$a,&$b) { $postvars['message'] = $msg; $url = 'https://graph.facebook.com/'.$target.'/links'; - } else if (($link == "") and ($image != "")) { + } else if (($link == "") && ($image != "")) { // If it is only an image without a page link then post this image as a photo $postvars = array( 'access_token' => $fb_token, @@ -670,10 +677,10 @@ function fbpost_post_hook(&$a,&$b) { $postvars['message'] = $msg; $url = 'https://graph.facebook.com/'.$target.'/photos'; - //} else if (($link != "") or ($image != "") or ($b['title'] == '') or (strlen($msg) < 500)) { + //} else if (($link != "") || ($image != "") || ($b['title'] == '') || (strlen($msg) < 500)) { } else { $url = 'https://graph.facebook.com/'.$target.'/feed'; - if (!get_pconfig($b['uid'],'facebook','suppress_view_on_friendica') and $b['plink']) + if (!get_pconfig($b['uid'],'facebook','suppress_view_on_friendica') && $b['plink']) $postvars['actions'] = '{"name": "' . t('View on Friendica') . '", "link": "' . $b['plink'] . '"}'; } /* } else { @@ -687,7 +694,7 @@ function fbpost_post_hook(&$a,&$b) { } */ // Post to page? - if (!$reply and ($target != "me") and $page_access_token) + if (!$reply && ($target != "me") && $page_access_token) $postvars['access_token'] = $page_access_token; logger('fbpost_post_hook: post to ' . $url); @@ -714,7 +721,7 @@ function fbpost_post_hook(&$a,&$b) { // If it is a special kind of failure the post was receiced // Although facebook said it wasn't received ... - if (!$likes AND (($retj->error->type != "OAuthException") OR ($retj->error->code != 2)) AND ($x <> "")) { + if (!$likes && (($retj->error->type != "OAuthException") || ($retj->error->code != 2)) && ($x <> "")) { $r = q("SELECT `id` FROM `contact` WHERE `uid` = %d AND `self`", intval($b['uid'])); if (count($r)) $a->contact = $r[0]["id"]; @@ -823,7 +830,7 @@ function fbpost_queue_hook(&$a,&$b) { logger('fbpost_queue_hook: run'); - $r = q("SELECT `user`.* FROM `user` LEFT JOIN `contact` on `contact`.`uid` = `user`.`uid` + $r = q("SELECT `user`.* FROM `user` LEFT JOIN `contact` on `contact`.`uid` = `user`.`uid` WHERE `contact`.`self` = 1 AND `contact`.`id` = %d LIMIT 1", intval($x['cid']) ); @@ -866,7 +873,7 @@ function fbpost_queue_hook(&$a,&$b) { // If it is a special kind of failure the post was receiced // Although facebook said it wasn't received ... $ret = json_decode($j); - if (($ret->error->type != "OAuthException") OR ($ret->error->code != 2) AND ($j <> "")) + if (($ret->error->type != "OAuthException") || ($ret->error->code != 2) && ($j <> "")) update_queue_time($x['id']); else logger('fbpost_queue_hook: Not requeued, since it seems to be received'); @@ -967,17 +974,36 @@ function fbpost_cron($a,$b) { set_config('facebook','last_poll', time()); } +function fbpost_cleanpicture($url) { + require_once("include/Photo.php"); + + $urldata = parse_url($url); + if (isset($urldata["query"])) { + parse_str($urldata["query"], $querydata); + if (isset($querydata["url"]) && (get_photo_info($querydata["url"]))) + return($querydata["url"]); + } + return($url); +} + function fbpost_fetchwall($a, $uid) { require_once("include/oembed.php"); - require_once('mod/item.php'); + require_once("include/network.php"); + require_once("include/items.php"); + require_once("mod/item.php"); + require_once("include/bbcode.php"); $access_token = get_pconfig($uid,'facebook','access_token'); $post_to_page = get_pconfig($uid,'facebook','post_to_page'); + $mirror_page = get_pconfig($uid,'facebook','mirror_page'); $lastcreated = get_pconfig($uid,'facebook','last_created'); if ((int)$post_to_page == 0) $post_to_page = "me"; + if ((int)$mirror_page != 0) + $post_to_page = $mirror_page; + $url = "https://graph.facebook.com/".$post_to_page."/feed?access_token=".$access_token; $first_time = ($lastcreated == ""); @@ -1003,13 +1029,17 @@ function fbpost_fetchwall($a, $uid) { if ($item->application->id == get_config('facebook','appid')) continue; - if(isset($item->privacy) && ($item->privacy->value !== 'EVERYONE') && ($item->privacy->value !== '')) + if(isset($item->privacy) && ($item->privacy->value !== 'EVERYONE') && ((int)$mirror_page == 0)) + continue; + elseif(isset($item->privacy) && ($item->privacy->value !== 'EVERYONE') && ($item->privacy->value !== '')) + continue; + elseif(!isset($item->privacy)) continue; - if (($post_to_page != $item->from->id) AND ((int)$post_to_page != 0)) + if (($post_to_page != $item->from->id) && ((int)$post_to_page != 0)) continue; - if (!strstr($item->id, $item->from->id."_") AND isset($item->to) AND ((int)$post_to_page == 0)) + if (!strstr($item->id, $item->from->id."_") && isset($item->to) && ((int)$post_to_page == 0)) continue; $_SESSION["authenticated"] = true; @@ -1019,87 +1049,110 @@ function fbpost_fetchwall($a, $uid) { $_REQUEST["type"] = "wall"; $_REQUEST["api_source"] = true; $_REQUEST["profile_uid"] = $uid; - $_REQUEST["source"] = "Facebook"; + //$_REQUEST["source"] = "Facebook"; + $_REQUEST["source"] = $item->application->name; + $_REQUEST["extid"] = NETWORK_FACEBOOK; $_REQUEST["title"] = ""; $_REQUEST["body"] = (isset($item->message) ? escape_tags($item->message) : ''); + $pagedata = array(); $content = ""; - $type = ""; + $pagedata["type"] = ""; - if(isset($item->name) and isset($item->link)) { + if(isset($item->name) && isset($item->link)) { + $item->link = original_url($item->link); $oembed_data = oembed_fetch_url($item->link); - $type = $oembed_data->type; + $pagedata["type"] = $oembed_data->type; + $pagedata["url"] = $item->link; + $pagedata["title"] = $item->name; $content = "[bookmark=".$item->link."]".$item->name."[/bookmark]"; + + // If a link is not only attached but also added in the body, look if it can be removed in the body. + $removedlink = trim(str_replace($item->link, "", $_REQUEST["body"])); + + if (($removedlink == "") || strstr($_REQUEST["body"], $removedlink)) + $_REQUEST["body"] = $removedlink; + } elseif (isset($item->name)) $content .= "[b]".$item->name."[/b]"; - $quote = ""; - if(isset($item->description) and ($item->type != "photo")) - $quote = $item->description; + $pagedata["text"] = ""; + if(isset($item->description) && ($item->type != "photo")) + $pagedata["text"] = $item->description; - if(isset($item->caption) and ($item->type == "photo")) - $quote = $item->caption; + if(isset($item->caption) && ($item->type == "photo")) + $pagedata["text"] = $item->caption; // Only import the picture when the message is no video // oembed display a picture of the video as well //if ($item->type != "video") { - //if (($item->type != "video") and ($item->type != "photo")) { - if (($type == "") OR ($type == "link")) { + //if (($item->type != "video") && ($item->type != "photo")) { + if (($pagedata["type"] == "") || ($pagedata["type"] == "link")) { - $type = $item->type; + $pagedata["type"] = $item->type; if (isset($item->picture)) - $picture = $item->picture; + $pagedata["images"][0]["src"] = $item->picture; - if (($type == "photo") AND isset($item->object_id)) { + if (($pagedata["type"] == "photo") && isset($item->object_id)) { logger('fbpost_fetchwall: fetching fbid '.$item->object_id, LOGGER_DEBUG); $url = "https://graph.facebook.com/".$item->object_id."?access_token=".$access_token; $feed = fetch_url($url); $data = json_decode($feed); if (isset($data->images)) { - $picture = $data->images[0]->source; - logger('fbpost_fetchwall: got fbid image '.$preview, LOGGER_DEBUG); + $pagedata["images"][0]["src"] = $data->images[0]->source; + logger('got fbid image from images for '.$item->object_id, LOGGER_DEBUG); + } elseif (isset($data->source)) { + $pagedata["images"][0]["src"] = $data->source; + logger('got fbid image from source for '.$item->object_id, LOGGER_DEBUG); + } elseif (isset($data->picture)) { + $pagedata["images"][0]["src"] = $data->picture; + logger('got fbid image from picture for '.$item->object_id, LOGGER_DEBUG); } } - if(($picture != "") && isset($item->link)) - $content .= "\n".'[url='.$item->link.'][img]'.$picture.'[/img][/url]'; - else { - if ($picture != "") - $content .= "\n".'[img]'.$picture.'[/img]'; + if(trim($_REQUEST["body"].$content.$pagedata["text"]) == '') { + logger('facebook: empty body 1 '.$item->id.' '.print_r($item, true)); + continue; + } + + $pagedata["images"][0]["src"] = fbpost_cleanpicture($pagedata["images"][0]["src"]); + + if(($pagedata["images"][0]["src"] != "") && isset($item->link)) { + $item->link = original_url($item->link); + $pagedata["url"] = $item->link; + $content .= "\n".'[url='.$item->link.'][img]'.$pagedata["images"][0]["src"].'[/img][/url]'; + } else { + if ($pagedata["images"][0]["src"] != "") + $content .= "\n".'[img]'.$pagedata["images"][0]["src"].'[/img]'; // if just a link, it may be a wall photo - check if(isset($item->link)) $content .= fbpost_get_photo($uid,$item->link); } } - if(trim($_REQUEST["body"].$content.$quote) == '') { - logger('facebook: empty body '.$item->id.' '.print_r($item, true)); + if(trim($_REQUEST["body"].$content.$pagedata["text"]) == '') { + logger('facebook: empty body 2 '.$item->id.' '.print_r($item, true)); continue; } - if ($content) - $_REQUEST["body"] .= "\n"; - - if ($type) - $_REQUEST["body"] .= "[class=type-".$type."]"; + if ($pagedata["type"] != "") + $_REQUEST["body"] .= add_page_info_data($pagedata); + else { + if ($content) + $_REQUEST["body"] .= "\n".trim($content); - if ($content) - $_REQUEST["body"] .= trim($content); + if ($pagedata["text"]) + $_REQUEST["body"] .= "\n[quote]".$pagedata["text"]."[/quote]"; - if ($quote) - $_REQUEST["body"] .= "\n[quote]".$quote."[/quote]"; - - if ($type) - $_REQUEST["body"] .= "[/class]"; - - $_REQUEST["body"] = trim($_REQUEST["body"]); + $_REQUEST["body"] = trim($_REQUEST["body"]); + } if (isset($item->place)) { - if ($item->place->name or $item->place->location->street or - $item->place->location->city or $item->place->location->country) { + if ($item->place->name || $item->place->location->street || + $item->place->location->city || $item->place->location->country) { $_REQUEST["location"] = ''; if ($item->place->name) $_REQUEST["location"] .= $item->place->name; @@ -1112,11 +1165,22 @@ function fbpost_fetchwall($a, $uid) { $_REQUEST["location"] = trim($_REQUEST["location"]); } - if ($item->place->location->latitude and $item->place->location->longitude) + if ($item->place->location->latitude && $item->place->location->longitude) $_REQUEST["coord"] = substr($item->place->location->latitude, 0, 8) .' '.substr($item->place->location->longitude, 0, 8); } + if(trim($_REQUEST["body"]) == '') { + logger('facebook: empty body 3 '.$item->id.' '.print_r($item, true)); + continue; + } + + if(trim(strip_tags(bbcode($_REQUEST["body"], false, false))) == '') { + logger('facebook: empty body 4 '.$item->id.' '.print_r($item, true)); + continue; + } + + //print_r($_REQUEST); logger('facebook: posting for user '.$uid); item_post($a); @@ -1146,7 +1210,7 @@ function fbpost_get_photo($uid,$link) { function fpost_cleanpicture($image) { - if ((strpos($image, ".fbcdn.net/") OR strpos($image, "/fbcdn-photos-")) and (substr($image, -6) == "_s.jpg")) + if ((strpos($image, ".fbcdn.net/") || strpos($image, "/fbcdn-photos-")) && (substr($image, -6) == "_s.jpg")) $image = substr($image, 0, -6)."_n.jpg"; $queryvar = fbpost_parse_query($image);