X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=inc%2Fextensions-functions.php;h=8d981e3e24580047b42e35c56ab4758012a16840;hb=93dc3d5b067c15568b01bcda1550018b38d1cdd9;hp=001aee7e1dc14b8fc9cbb7c2ba23d99f7938679a;hpb=d92a340159ca45047eafc111fcac64933a7babeb;p=mailer.git diff --git a/inc/extensions-functions.php b/inc/extensions-functions.php index 001aee7e1d..8d981e3e24 100644 --- a/inc/extensions-functions.php +++ b/inc/extensions-functions.php @@ -18,6 +18,7 @@ * svn:keywords Date Revision" (autoprobset!) at least!!!!!! * * -------------------------------------------------------------------- * * Copyright (c) 2003 - 2009 by Roland Haeder * + * Copyright (c) 2009, 2010 by Mailer Developer Team * * For more information visit: http://www.mxchange.org * * * * This program is free software; you can redistribute it and/or modify * @@ -43,29 +44,51 @@ if (!defined('__SECURITY')) { // Load the extension and maybe found language and function files. function loadExtension ($ext_name, $ext_mode = 'init', $ext_ver = '', $dry_run = false) { - // Set current extension name - setCurrentExtensionName($ext_name); + // If this happens twice, we need the bug report from you, except for updates/tests + if ((isset($GLOBALS['loaded_extension'][$ext_name][$ext_mode])) && (!in_array($ext_mode, array('update', 'test')))) { + debug_report_bug(__FUNCTION__ . '() is called twice: ext_name=' . $ext_name . ', ext_mode='. $ext_mode . ',ext_sqls=' . print_r(getExtensionSqls(), true) . ', ext_register_running=' . print_r($GLOBALS['ext_register_running'], true) . ', ext_running_updates=' . print_r($GLOBALS['ext_running_updates'], true)); + } // END - if - // Set current extension version - setCurrentExtensionVersion($ext_ver); + // Make sure this situation can only happen once + $GLOBALS['loaded_extension'][$ext_name][$ext_mode] = true; // Set extension mode setExtensionMode($ext_mode); + // Set current extension name + setCurrentExtensionName($ext_name); + + if (!empty($ext_ver)) { + // Set current extension version + setCurrentExtensionVersion($ext_ver); + } else { + // Set it to 0.0 + setCurrentExtensionVersion('0.0'); + + // In all but test-mode we need these messages to debug! Please report all (together, e.g.) + if ($ext_mode != 'test') { + // Log empty versions not in test-mode, but maybe it is fine... + logDebugMessage(__FUNCTION__, __LINE__, 'Extension version is empty, setting to 0.0. ext_name=' . $ext_name . ', ext_mode=' . $ext_mode . ', dry_run=' . intval($dry_run)); + } // END - if + } + // Set dry-run enableExtensionDryRun($dry_run); // Init array initIncludePool('extension'); - // Init EXT_UPDATE_DEPENDS - initExtensionUpdateDependencies(); + // Init EXT_UPDATE_DEPENDS if not yet done + if (!isExtensionUpdateDependenciesInitialized()) { + // Init here... + initExtensionUpdateDependencies(); + } // END - if // Init current extension name list initExtensionSqls(); // Is the extension already loaded? - //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, "Loading extension {$ext_name}, mode=".getExtensionMode().", ver=".getCurrentExtensionVersion().""); + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'Loading extension ' . $ext_name . ', mode=' . getExtensionMode() . ', ver=' . getCurrentExtensionVersion()); if ((isset($GLOBALS['ext_loaded']['ext'][$ext_name])) && (getExtensionMode() == 'init')) { // Debug message logDebugMessage(__FUNCTION__, __LINE__, sprintf("Extension %s already loaded.", $ext_name)); @@ -117,10 +140,10 @@ function loadExtension ($ext_name, $ext_mode = 'init', $ext_ver = '', $dry_run = setExtensionAlwaysActive('N'); // Extension update notes - setExtensionUpdateNotes(''); + // @TODO Do we still need this? setExtensionUpdateNotes(''); // Include the extension file - //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, "Extension loaded."); + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'Extension loaded.'); loadExtensionInclude(); // Is this extension deprecated? @@ -145,6 +168,7 @@ function loadExtension ($ext_name, $ext_mode = 'init', $ext_ver = '', $dry_run = // Registeres an extension and possible update depencies function registerExtension ($ext_name, $task_id, $dry_run = false, $logout = true) { // Set current extension name + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'ext_name=' . $ext_name . ',task_id=' . $task_id . ',dry_run=' . intval($dry_run) . ',logout=' . intval($logout) . ' - ENTERED!'); setCurrentExtensionName($ext_name); // Enable dry-run @@ -153,24 +177,27 @@ function registerExtension ($ext_name, $task_id, $dry_run = false, $logout = tru // By default all extensions are in productive phase enableExtensionProductive(); - //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, "currName=".getCurrentExtensionName()." - ENTERED!"); // This shall never do a non-admin user or if the extension is active (already installed) if ((!isAdmin()) || (isExtensionInstalled($ext_name))) { + // Abort here with 'false' return false; } // END - if - // When this extension is already in install/update phase, all is fine - if (isExtensionRegisterRunning($ext_name)) { - // Then abort here which is fine - //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, "currName=".getCurrentExtensionName()." - ALREADY!"); + // When this extension is already in registration/update phase, all is fine + if ((isExtensionRegistrationRunning($ext_name)) || (isExtensionUpdateRunning($ext_name))) { + // Then abort here with 'true' becaus it is fine + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'currName=' . getCurrentExtensionName() . ' - ALREADY!'); return true; } // END - if // This registration is running addExtensionRunningRegistration($ext_name); - // Init EXT_UPDATE_DEPENDS - initExtensionUpdateDependencies(); + // Init EXT_UPDATE_DEPENDS if not yet done + if (!isExtensionUpdateDependenciesInitialized()) { + // Init here... + initExtensionUpdateDependencies(); + } // END - if // Is the task id zero? Then we need to auto-fix it here if ($task_id == '0') { @@ -180,7 +207,7 @@ function registerExtension ($ext_name, $task_id, $dry_run = false, $logout = tru // Still zero and not in dry-run? if (($task_id == '0') && (!getExtensionDryRun())) { // Then request a bug report - debug_report_bug(sprintf("%s: task_id is still zero after determineExtensionTaskId(%s)", + debug_report_bug(__FUNCTION__, __LINE__, sprintf("%s: task_id is still zero after determineExtensionTaskId(%s)", __FUNCTION__, getCurrentExtensionName() )); @@ -200,16 +227,16 @@ function registerExtension ($ext_name, $task_id, $dry_run = false, $logout = tru setExtensionReportsFailure(false); // Does this extension exists? - //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, "currName=".getCurrentExtensionName().""); + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'currName=' . getCurrentExtensionName()); if (loadExtension(getCurrentExtensionName(), 'register', '', getExtensionDryRun())) { // Set current extension name again setCurrentExtensionName($ext_name); // And run possible updates - //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, "".getCurrentExtensionName()); + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'currentExtension=' . getCurrentExtensionName()); $history = getExtensionVersionHistory(); foreach ($history as $ver) { - //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, "ext_name=".getCurrentExtensionName().", ext_ver={$ver}"); + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'ext_name=' . getCurrentExtensionName() . ', ext_ver=' . $ver); // Load extension in update mode loadExtension(getCurrentExtensionName(), 'update', $ver, getExtensionDryRun()); @@ -225,8 +252,9 @@ function registerExtension ($ext_name, $task_id, $dry_run = false, $logout = tru // Increment here to avoid endless loop incrementExtensionUpdateIterator(); - // Check for required file - if ((!isExtensionInstalled($ext_update)) && (loadExtension($ext_update, 'register', '', getExtensionDryRun()))) { + // Check if extension is not installed and not already in registration procedure and if loading it wents finally fine... + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'ext_name=' . $ext_name . ',isExtensionRegistrationRunning(' . $ext_update . ')=' . intval(isExtensionRegistrationRunning($ext_update))); + if ((!isExtensionInstalled($ext_update)) && (!isExtensionRegistrationRunning($ext_update)) && (loadExtension($ext_update, 'test', '', getExtensionDryRun()))) { // Set current extension name again setCurrentExtensionName($ext_name); @@ -245,16 +273,17 @@ function registerExtension ($ext_name, $task_id, $dry_run = false, $logout = tru // Entry found? if ($task > 0) { // Try to register the extension - //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, "currName=".getCurrentExtensionName().":ext_update=".$ext_update.",taskId=".$task.""); + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'currName=' . getCurrentExtensionName() . ':ext_update=' . $ext_update . ',taskId=' . $task); $test = registerExtension($ext_update, $task, getExtensionDryRun(), false); // Reset extension name setCurrentExtensionName($ext_name); - //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, "currName=".getCurrentExtensionName()); print getCurrentExtensionName().':
'.print_r($test);
+						//* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'currName=' . getCurrentExtensionName());
+						//* DEBUG: */ print getCurrentExtensionName().':
' . print_r($test, true) . '
'; } // END - if } elseif ($ext_ver != getCurrentExtensionVersion()) { // Ok, update this extension now - //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'currName='.getCurrentExtensionName().',currVer='.getCurrentExtensionVersion().''); + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'currName=' . getCurrentExtensionName() . ',currVer=' . getCurrentExtensionVersion()); $GLOBALS['ext_backup_name'][$ext_update][$ext_ver] = getCurrentExtensionName(); $GLOBALS['ext_backup_ver'][$ext_update][$ext_ver] = getCurrentExtensionVersion(); updateExtension($ext_update, $ext_ver, getExtensionDryRun()); @@ -262,7 +291,7 @@ function registerExtension ($ext_name, $task_id, $dry_run = false, $logout = tru setCurrentExtensionVersion($GLOBALS['ext_backup_ver'][$ext_update][$ext_ver]); unset($GLOBALS['ext_backup_name'][$ext_update][$ext_ver]); unset($GLOBALS['ext_backup_ver'][$ext_update][$ext_ver]); - //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'currName='.getCurrentExtensionName().',currVer='.getCurrentExtensionVersion().''); + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'currName=' . getCurrentExtensionName() . ',currVer=' . getCurrentExtensionVersion()); // All okay! $test = true; @@ -281,7 +310,7 @@ function registerExtension ($ext_name, $task_id, $dry_run = false, $logout = tru } // END - for // Is there no update? - if (countExtensionUpdateDependencies(getCurrentExtensionName()) == '0') { + if (countExtensionUpdateDependencies(getCurrentExtensionName()) == 0) { // Then test is passed! $test = true; } // END - if @@ -290,15 +319,17 @@ function registerExtension ($ext_name, $task_id, $dry_run = false, $logout = tru setExtensionMode('register'); // Remains true if extension registration reports no failures - //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, "currName=".getCurrentExtensionName()); print getCurrentExtensionName().':
'.print_r($test, true).'
'; + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'currName=' . getCurrentExtensionName()); + //* DEBUG: */ print getCurrentExtensionName().':
' . print_r($test, true) . '
'; $test = (($test === true) && (getExtensionReportsFailure() === false)); - //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, "currName=".getCurrentExtensionName()); print getCurrentExtensionName().':
'.print_r($test, true).'
'; + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'currName=' . getCurrentExtensionName()); + //* DEBUG: */ print getCurrentExtensionName().':
' . print_r($test, true) . '
'; // Does everthing before wents ok? if ($test === true) { // "Dry-run-mode" activated? if ((getExtensionDryRun() === false) && (!isExtensionOnRemovalList())) { - //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, "ext_name=".getCurrentExtensionName()); + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'ext_name=' . getCurrentExtensionName()); // Init SQLs and transfer ext->generic initSqls(); setSqlsArray(getExtensionSqls()); @@ -307,15 +338,26 @@ function registerExtension ($ext_name, $task_id, $dry_run = false, $logout = tru runFilterChain('pre_extension_installed', array('dry_run' => getExtensionDryRun())); // Register extension - //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, "insert=".getCurrentExtensionName().'/'.getCurrentExtensionVersion()." - INSERT!"); + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'insert=' . getCurrentExtensionName() . '/' . getCurrentExtensionVersion() . ' - INSERT!'); if (isExtensionInstalledAndNewer('sql_patches', '0.0.6')) { + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'ext_name=' . getCurrentExtensionName() . ',always_active=' . getExtensionAlwaysActive() . ', ext_ver=' . getCurrentExtensionVersion() . 'ext_css=' . getExtensionHasCss()); // New way, with CSS SQL_QUERY_ESC("INSERT INTO `{?_MYSQL_PREFIX?}_extensions` (`ext_name`, `ext_active`, `ext_version`,`ext_has_css`) VALUES ('%s','%s','%s','%s')", - array(getCurrentExtensionName(), getExtensionAlwaysActive(), getCurrentExtensionVersion(), getExtensionHasCss()), __FUNCTION__, __LINE__); + array( + getCurrentExtensionName(), + getExtensionAlwaysActive(), + getCurrentExtensionVersion(), + getExtensionHasCss() + ), __FUNCTION__, __LINE__); } else { + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'ext_name=' . getCurrentExtensionName() . ',always_active=' . getExtensionAlwaysActive() . ', ext_ver=' . getCurrentExtensionVersion()); // Old way, no CSS SQL_QUERY_ESC("INSERT INTO `{?_MYSQL_PREFIX?}_extensions` (`ext_name`, `ext_active`, `ext_version`) VALUES ('%s','%s','%s')", - array(getCurrentExtensionName(), getExtensionAlwaysActive(), getCurrentExtensionVersion()), __FUNCTION__, __LINE__); + array( + getCurrentExtensionName(), + getExtensionAlwaysActive(), + getCurrentExtensionVersion() + ), __FUNCTION__, __LINE__); } // Remove cache file(s) if extension is active @@ -325,8 +367,9 @@ function registerExtension ($ext_name, $task_id, $dry_run = false, $logout = tru 'task_id' => $task_id )); - // Remove all SQL commands - unsetSqls(); + // Re-init queries and notes + initExtensionSqls(true); + initExtensionNotes(); // Mark it as installed $GLOBALS['ext_is_installed'][getCurrentExtensionName()] = true; @@ -337,28 +380,29 @@ function registerExtension ($ext_name, $task_id, $dry_run = false, $logout = tru // In "dry-run" mode return array with all SQL commands $ret = getExtensionSqls(); - // Remove all SQL commands - unsetSqls(); + // Re-init queries and notes + initExtensionSqls(true); + initExtensionNotes(); } else { // Extension has been removed for updates, so all is fine! $ret = true; } } else { // No, an error occurs while registering extension :-( - //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, "".getCurrentExtensionName()); + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'currentExtension=' . getCurrentExtensionName()); $ret = false; } } elseif (($task_id > 0) && (getCurrentExtensionName() != '')) { - //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, "currName=".getCurrentExtensionName().""); + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'currName=' . getCurrentExtensionName()); // Remove task from system when id and extension's name is valid SQL_QUERY_ESC("DELETE LOW_PRIORITY FROM `{?_MYSQL_PREFIX?}_task_system` WHERE `id`=%s AND `status`='NEW' LIMIT 1", array(bigintval($task_id)), __FUNCTION__, __LINE__); } // Is this the sql_patches? - //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, ':'.getCurrentExtensionName()."/".getExtensionMode().""); + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'currentExtension=' . getCurrentExtensionName() . '/' . getExtensionMode()); if ((getCurrentExtensionName() == 'sql_patches') && ((getExtensionMode() == 'register') || (getExtensionMode() == 'remove')) && (!getExtensionDryRun()) && ($test)) { - //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, ": LOAD!"); + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'currentExtension=' . getCurrentExtensionName() . ': LOAD!'); if ($logout === true) { // Then redirect to logout redirectToUrl('modules.php?module=admin&logout=1&' . getExtensionMode() . '=sql_patches'); @@ -370,7 +414,7 @@ function registerExtension ($ext_name, $task_id, $dry_run = false, $logout = tru } // END - if // Return status code - //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, "currName=".getCurrentExtensionName()." - LEFT!"); + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'currName=' . getCurrentExtensionName() . ',ext_name=' . $ext_name . ' - EXIT!'); //* DEBUG: */ print getCurrentExtensionName().':
'.print_r($ret, true).'
'; return $ret; } @@ -388,7 +432,10 @@ function doExtensionSqls ($ext_id, $load_mode) { setCurrentExtensionName($ext_name); // Init EXT_UPDATE_DEPENDS - initExtensionUpdateDependencies(); + if (!isExtensionUpdateDependenciesInitialized()) { + // Init here... + initExtensionUpdateDependencies(); + } // END - if // Init array initExtensionSqls(); @@ -490,7 +537,7 @@ function isExtensionActive ($ext_name) { incrementStatsEntry('cache_hits'); } elseif (isset($GLOBALS['ext_loaded'][$ext_name])) { // @TODO Extension is loaded, what next? - app_die(__FUNCTION__, __LINE__, 'LOADED:' . $ext_name); + debug_report_bug(__FUNCTION__, __LINE__, 'LOADED:' . $ext_name); } elseif (($ext_name == 'cache') || (!isExtensionInstalled('cache'))) { //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, "DB! ext_name={$ext_name}"); // Load from database @@ -557,7 +604,7 @@ function getExtensionVersion ($ext_name, $force = false) { $data = SQL_FETCHARRAY($result); } elseif (isDebugModeEnabled()) { // Not found, please report all - debug_report_bug(sprintf(": Cannot find extension %s in database!", $ext_name)); + debug_report_bug(__FUNCTION__, __LINE__, sprintf(": Cannot find extension %s in database!", $ext_name)); } // Free result @@ -570,7 +617,7 @@ function getExtensionVersion ($ext_name, $force = false) { // Extension version should not be invalid if (($data['ext_version'] == 'false') && ($force === false)) { // Please report this trouble - debug_report_bug(sprintf("Extension %s has empty version!", $ext_name)); + debug_report_bug(__FUNCTION__, __LINE__, sprintf("Extension %s has empty version!", $ext_name)); } // END - if // Return result @@ -640,6 +687,9 @@ function updateExtension ($ext_name, $ext_ver, $dry_run = false) { } // END - if } // END - foreach + // Set extension version here + setCurrentExtensionVersion($ext_ver); + // Set name back setCurrentExtensionName($ext_name); } // END - if @@ -889,7 +939,7 @@ function isExtensionOlder ($ext_name, $ext_ver) { // Creates a new task for updated extension function createExtensionUpdateTask ($adminId, $ext_name, $ext_ver, $notes) { // Create subject line - $subject = '[UPDATE-' . $ext_name . '-' . $ext_ver . ':] {--ADMIN_UPDATE_EXT_SUBJ--}'; + $subject = '[UPDATE-' . $ext_name . '-' . $ext_ver . ':] {--ADMIN_UPDATE_EXTENSION_SUBJ--}'; // Is the extension there? if (isExtensionInstalled($ext_name)) { @@ -900,7 +950,7 @@ function createExtensionUpdateTask ($adminId, $ext_name, $ext_ver, $notes) { } // END - if } else { // Extension not there! :-( - debug_report_bug(sprintf("Extension %s not found but should be updated?", $ext_name)); + debug_report_bug(__FUNCTION__, __LINE__, sprintf("Extension %s not found but should be updated?", $ext_name)); } } @@ -909,7 +959,7 @@ function createNewExtensionTask ($adminId, $subject, $ext) { // Not installed and do we have created a task for the admin? if ((determineTaskIdBySubject($subject) == '0') && (!isExtensionInstalled($ext))) { // Set default message if ext-foo is missing - $message = getMaskedMessage('ADMIN_EXT_TEXT_FILE_MISSING', $ext); + $message = getMaskedMessage('ADMIN_EXTENSION_TEXT_FILE_MISSING', $ext); // Template file $tpl = sprintf("%stemplates/%s/html/ext/ext_%s.tpl", @@ -938,9 +988,9 @@ function createExtensionDeactivationTask ($ext) { $subject = sprintf("[%s:] %s", $ext, getMessage('TASK_SUBJ_EXTENSION_DEACTIVATED')); // Not installed and do we have created a task for the admin? - if ((determineTaskIdBySubject($subject) == '0') && (getExtensionVersion($ext) != '')) { + if ((determineTaskIdBySubject($subject) == '0') && (isExtensionInstalled($ext))) { // Task not created so add it - createNewTask($subject, SQL_ESCAPE(loadTemplate('task_ext_deactivated', true, $ext)), 'EXTENSION_DEACTIVATION'); + createNewTask($subject, SQL_ESCAPE(loadTemplate('task_EXTENSION_deactivated', true, $ext)), 'EXTENSION_DEACTIVATION'); } // END - if } @@ -960,11 +1010,11 @@ function ifModuleHasMenu ($mod, $forceDb = false) { // Check cache and count hit $ret = ($GLOBALS['cache_array']['extension']['ext_menu'][$mod] == 'Y'); incrementStatsEntry('cache_hits'); - } elseif ($mod == 'admin') { - // Admin module has always a menu! - $ret = true; + } else { + // Admin/guest/member/sponsor modules have always a menu! + $ret = in_array($mod, array('admin', 'index', 'login', 'sponsor')); } - } elseif ((isExtensionInstalled('sql_patches')) && (getExtensionVersion('sql_patches') >= '0.3.6') && ((!isExtensionActive('cache')) || ($forceDb === true))) { + } elseif ((isExtensionInstalledAndNewer('sql_patches', '0.3.6')) && ((!isExtensionActive('cache')) || ($forceDb === true))) { // Check database for entry $result = SQL_QUERY_ESC("SELECT `has_menu` FROM `{?_MYSQL_PREFIX?}_mod_reg` WHERE `module`='%s' LIMIT 1", array($mod), __FUNCTION__, __LINE__); @@ -984,8 +1034,11 @@ function ifModuleHasMenu ($mod, $forceDb = false) { // Free memory SQL_FREERESULT($result); } elseif (!isExtensionInstalled('sql_patches')) { - // No sql_patches installed, so maybe in admin area or no admin registered? - $ret = (((isAdmin()) || (!isAdminRegistered())) && ($mod == 'admin')); // Then there is a menu! + // No sql_patches installed, so maybe in admin/guest/member/sponsor area or no admin registered? + $ret = in_array($mod, array('admin', 'index', 'login', 'sponsor')); // Then there is a menu! + } else { + // Unsupported state! + logDebugMessage(__FUNCTION__, __LINE__, 'This should never be reached.'); } // Return status @@ -1044,7 +1097,7 @@ function addExtensionNotes ($ver) { // Is do we have verbose output enabled? if ((!isExtensionActive('sql_patches')) || (getConfig('verbose_sql') == 'Y')) { // Update notes found? - if (getExtensionUpdateNotes($ver) != '') { + if (isExtensionUpdateNoteSet($ver)) { // Update notes found $content = array( 'ver' => $ver, @@ -1068,7 +1121,7 @@ function addExtensionNotes ($ver) { } // Load template - $out = loadTemplate('admin_ext_notes', true, $content); + $out = loadTemplate('admin_EXTENSION_notes', true, $content); } // END - if // Add the notes @@ -1118,6 +1171,11 @@ function getExtensionAlwaysActive () { return $GLOBALS['ext_always_active'][getCurrentExtensionName()]; } +// Checks wether the current extension is always active +function isExtensionAlwaysActive () { + return (getExtensionAlwaysActive() == 'Y'); +} + // Setter for EXT_VERSION flag function setThisExtensionVersion ($version) { $GLOBALS['ext_version'][getCurrentExtensionName()] = (string) $version; @@ -1140,57 +1198,113 @@ function isExtensionDeprecated () { // Setter for EXT_UPDATE_DEPENDS flag function addExtensionUpdateDependency ($updateDepends) { + //* DEBUG */ logDebugMessage(__FUNCTION__, __LINE__, 'currName=' . getCurrentExtensionName() . '/' . $updateDepends . ' - ENTERED!'); // Is the update depency empty? (NEED TO BE FIXED!) if (empty($updateDepends)) { // Please report this bug! - debug_report_bug('updateDepends is left empty!'); + debug_report_bug(__FUNCTION__, __LINE__, 'updateDepends is empty: currentExtension=' . getCurrentExtensionName()); } // END - if // Is it not yet added? - if (!in_array($updateDepends, $GLOBALS['ext_running_updates'])) { - //* DEBUG */ logDebugMessage(__FUNCTION__, __LINE__, "currName=".getCurrentExtensionName().'/'.$updateDepends); - // Add it to the list of extension update depencies map - $GLOBALS['ext_update_depends'][getCurrentExtensionName()][] = (string) $updateDepends; - - // Remember it in the list of running updates - $GLOBALS['ext_running_updates'][] = $updateDepends; + /* DEBUG: + if ((isset($updateDepends, $GLOBALS['ext_running_updates'][getCurrentExtensionName()])) && (in_array($updateDepends, getExtensionUpdatesRunning()))) { + // Double-adding isn't fine, too + debug_report_bug(__FUNCTION__ . '() called twice: updateDepends=' . $updateDepends . ',currentExtension=' . getCurrentExtensionName()); } // END - if + */ + + // Add it to the list of extension update depencies map + $GLOBALS['ext_update_depends'][getCurrentExtensionName()][] = (string) $updateDepends; + + // Remember it in the list of running updates + $GLOBALS['ext_running_updates'][getCurrentExtensionName()][] = $updateDepends; + //* DEBUG */ logDebugMessage(__FUNCTION__, __LINE__, 'currName=' . getCurrentExtensionName() . '/' . $updateDepends . ' - EXIT!'); +} + +// Getter for running updates +function getExtensionUpdatesRunning () { + return $GLOBALS['ext_running_updates'][getCurrentExtensionName()]; } // Checks wether the given extension registration is in progress -function isExtensionRegisterRunning ($ext_name) { - return ((isset($GLOBALS['ext_register_running'])) && (in_array($ext_name, $GLOBALS['ext_register_running']))); +function isExtensionRegistrationRunning ($ext_name) { + // Simply check it + $isRunning = ((isset($GLOBALS['ext_register_running'])) && (in_array($ext_name, $GLOBALS['ext_register_running']))); + + // Return it + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'ext_name=' . $ext_name . ', isRunning=' . intval($isRunning)); + return $isRunning; } // Init EXT_UPDATE_DEPENDS flag function initExtensionUpdateDependencies () { - //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, "currName=".getCurrentExtensionName()); + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'currName=' . getCurrentExtensionName() . ' - ENTERED!'); // Init update depency map automatically if not found - if (!isExtensionUpdateDependenciesInitialized()) { - //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, "currName=".getCurrentExtensionName()." - INIT!"); - $GLOBALS['ext_update_depends'][getCurrentExtensionName()] = array(); + if (isExtensionUpdateDependenciesInitialized()) { + // We need these bug reports as well... + debug_report_bug(__FUNCTION__ . '() is called twice: currName=' . getCurrentExtensionName()); } // END - if + $GLOBALS['ext_update_depends'][getCurrentExtensionName()] = array(); + // Init running updates array initExtensionRuningUpdates(); + + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'currName=' . getCurrentExtensionName() . ' - EXIT!'); } // Adds an extension as "registration in progress" function addExtensionRunningRegistration ($ext_name) { // Is it running? - if (!isExtensionRegisterRunning($ext_name)) { - // Then add it! - $GLOBALS['ext_register_running'][] = $ext_name; + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'Registration in progress: ext_name=' . $ext_name . ' - ENTERED!'); + if (isExtensionRegistrationRunning($ext_name)) { + // This is really bad and should not be quietly ignored + debug_report_bug(__FUNCTION__ . '() already called! ext_name=' . $ext_name); } // END - if + + // Then add it! + $GLOBALS['ext_register_running'][] = $ext_name; + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'Registration in progress: ext_name=' . $ext_name . ' - EXIT!'); } // Checks wether EXT_UPDATE_DEPENDS is initialized function isExtensionUpdateDependenciesInitialized () { - //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, "currName=".getCurrentExtensionName()); + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'currName=' . getCurrentExtensionName()); return (isset($GLOBALS['ext_update_depends'][getCurrentExtensionName()])); } +// Checks wether an update is already running for given extension +function isExtensionUpdateRunning ($ext_name) { + // Current and given extensions means whole array + if ($ext_name == getCurrentExtensionName()) { + // Default is not found + $isRunning = false; + + // Walk through whole array + foreach ($GLOBALS['ext_running_updates'] as $ext1=>$depends) { + // Is it found? + if (($ext1 == $ext_name) || ($isRunning === true)) { + // Found! + logDebugMessage(__FUNCTION__, __LINE__, 'ext1=' . $ext1 . ',ext_name=' . $ext_name . ',isRunning=' . intval($isRunning)); + $isRunning = true; + break; + } // END - if + } // END - foreach + + // Return result + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'currentExtension=' . getCurrentExtensionName() . ',ext_name=' . $ext_name . ', isRunning=' . intval($isRunning)); + return $isRunning; + } // END - if + + // Simply check it + $isRunning = ((isExtensionUpdateDependenciesInitialized()) && (in_array($ext_name, getExtensionRunningUpdates()))); + + // Return it + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'currentExtension=' . getCurrentExtensionName() . ',ext_name=' . $ext_name . ', isRunning=' . intval($isRunning)); + return $isRunning; +} + // Initializes the list of running updates function initExtensionRuningUpdates () { // Auto-init ext_running_updates @@ -1277,7 +1391,8 @@ function getExtensionVersionHistory () { // Setter for EXT_UPDATE_NOTES function setExtensionUpdateNotes ($updateNotes, $ver='') { - //* DEBUG: */ print __FUNCTION__.':'.getCurrentExtensionName().'/'.getCurrentExtensionVersion().'/'.$ver.'='.$updateNotes.'
'; + // . '/' . getCurrentExtensionVersion() + //* DEBUG: */ debug_report_bug(__FUNCTION__.':' . getCurrentExtensionName() . '/' . getExtensionMode() . '/' . $ver . '=' . $updateNotes); if (empty($ver)) { $GLOBALS['ext_update_notes'][getCurrentExtensionName()][getCurrentExtensionVersion()] = (string) $updateNotes; } else { @@ -1290,6 +1405,11 @@ function getExtensionUpdateNotes ($ver) { return $GLOBALS['ext_update_notes'][getCurrentExtensionName()][$ver]; } +// Checks if ext_update_notes is set +function isExtensionUpdateNoteSet ($ver) { + return isset($GLOBALS['ext_update_notes'][getCurrentExtensionName()][$ver]); +} + // Init extension notice function initExtensionNotes () { $GLOBALS['ext_notes'][getCurrentExtensionName()] = ''; @@ -1307,24 +1427,28 @@ function getExtensionNotes () { // Setter for current extension name function setCurrentExtensionName ($ext_name) { - $GLOBALS['curr_ext_name'] = (string) trim($ext_name); + $GLOBALS['curr_EXTENSION_name'] = (string) trim($ext_name); } // Getter for current extension name function getCurrentExtensionName () { - if (isset($GLOBALS['curr_ext_name'])) { - return $GLOBALS['curr_ext_name']; + if (isset($GLOBALS['curr_EXTENSION_name'])) { + return $GLOBALS['curr_EXTENSION_name']; } // END - if // Not set! - debug_report_bug(__FUNCTION__.": curr_ext_name not initialized. Please execute initExtensionSqls() before calling this function."); + debug_report_bug(__FUNCTION__.": curr_EXTENSION_name not initialized. Please execute initExtensionSqls() before calling this function."); } // Init SQLs array for current extension -function initExtensionSqls () { - // Auto-init the array now... - if (!isset($GLOBALS['ext_sqls'][getCurrentExtensionName()])) { +function initExtensionSqls ($force = false) { + // Auto-init the array or if forced + if ((!isset($GLOBALS['ext_sqls'][getCurrentExtensionName()])) || ($force === true)) { + // Set the array $GLOBALS['ext_sqls'][getCurrentExtensionName()] = array(); + + // Initialize the generic array + initSqls(); } // END - if } @@ -1339,7 +1463,7 @@ function getExtensionSqls () { // Output debug backtrace if not found (SHOULD NOT HAPPEN!) if (!isset($GLOBALS['ext_sqls'][getCurrentExtensionName()])) { // Not found, should not happen - debug_report_bug(sprintf("ext_sqls is empty, current extension: %s", + debug_report_bug(__FUNCTION__, __LINE__, sprintf("ext_sqls is empty, current extension: %s", getCurrentExtensionName() )); } // END - if @@ -1402,7 +1526,7 @@ function FILTER_INIT_EXTENSIONS () { foreach ($GLOBALS['cache_array']['extension']['ext_name'] as $key => $ext_name) { // Load it //* DEBUG */ print __FUNCTION__.': '.$ext_name.' - START
'; - loadExtension($ext_name, 'init'); + loadExtension($ext_name, 'init', getExtensionVersion($ext_name)); //* DEBUG */ print __FUNCTION__.': '.$ext_name.' - END
'; } // END - foreach //* DEBUG */ print __FUNCTION__.': CACHE - END!
'; @@ -1433,21 +1557,24 @@ function getExtensionDryRun () { // Setter for current extension version function setCurrentExtensionVersion ($ext_ver) { - if (empty($ext_ver)) { - // 0.0 is okay here - $GLOBALS['ext_current_version'] = '0.0'; - } else { - // Add version - $GLOBALS['ext_current_version'] = (string) $ext_ver; - } + // ext_ver should never be empty in other modes than 'test' + if ((empty($ext_ver)) && (getExtensionMode() != 'test')) { + // Please report all these messages + debug_report_bug(__FUNCTION__, __LINE__, 'ext_ver is empty. Current extension name: ' . getCurrentExtensionName() . ', mode=' . getExtensionMode()); + } // END - if + + // Add version + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'ext_name=' . getCurrentExtensionName() . ', ext_ver[' . gettype($ext_ver) . ']=' . $ext_ver); + $GLOBALS['ext_current_version'][getCurrentExtensionName()] = (string) $ext_ver; } // Getter for current extension version function getCurrentExtensionVersion () { - return $GLOBALS['ext_current_version']; + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'ext_name=' . getCurrentExtensionName() . ', ext_ver=' . $GLOBALS['ext_current_version'][getCurrentExtensionName()]); + return $GLOBALS['ext_current_version'][getCurrentExtensionName()]; } -// Remove the extension from global cache array +// Remove the extension from cache array function removeExtensionFromArray () { // "Cache" this name $ext_name = getCurrentExtensionName(); @@ -1530,7 +1657,7 @@ function loadExtensionInclude () { // Is it readable? if (!isExtensionIncludeReadable()) { // Not readable - debug_report_bug('Extension ' . getCurrentExtensionName() . ' should be loaded, but is not readable.'); + debug_report_bug(__FUNCTION__, __LINE__, 'Extension ' . getCurrentExtensionName() . ' should be loaded, but is not readable.'); } // END - if // Generate INC name