X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=inc%2Ffunctions.php;h=0f96686c20698392812a06755c7db34096dde385;hb=97702d59eb179b54690f9ccc18df66cd981ab0df;hp=8ebb9136698b4824fcb3334260f20ab491c4452c;hpb=51987bfef4e13f3a35643d1bf80a1a1d7e6aee0a;p=mailer.git

diff --git a/inc/functions.php b/inc/functions.php
index 8ebb913669..0f96686c20 100644
--- a/inc/functions.php
+++ b/inc/functions.php
@@ -295,7 +295,7 @@ function generateDateTime ($time, $mode = '0') {
 				default:
 					logDebugMessage(__FUNCTION__, __LINE__, sprintf("Invalid date mode %s detected.", $mode));
 					break;
-			}
+			} // END - switch
 			break;
 
 		default: // Default is the US date / time format!
@@ -594,26 +594,26 @@ function redirectToUrl ($url, $allowSpider = true) {
  *                                                                      *
  ************************************************************************/
 function array_pk_sort (&$array, $a_sort, $primary_key = '0', $order = -1, $nums = false) {
-	$dummy = $array;
+	$temporaryArray = $array;
 	while ($primary_key < count($a_sort)) {
-		foreach ($dummy[$a_sort[$primary_key]] as $key => $value) {
-			foreach ($dummy[$a_sort[$primary_key]] as $key2 => $value2) {
+		foreach ($temporaryArray[$a_sort[$primary_key]] as $key => $value) {
+			foreach ($temporaryArray[$a_sort[$primary_key]] as $key2 => $value2) {
 				$match = false;
 				if ($nums === false) {
 					// Sort byte-by-byte (also numbers will be interpreted as chars! E.g.: "9" > "10")
-					if (($key != $key2) && (strcmp(strtolower($dummy[$a_sort[$primary_key]][$key]), strtolower($dummy[$a_sort[$primary_key]][$key2])) == $order)) $match = true;
+					if (($key != $key2) && (strcmp(strtolower($temporaryArray[$a_sort[$primary_key]][$key]), strtolower($temporaryArray[$a_sort[$primary_key]][$key2])) == $order)) $match = true;
 				} elseif ($key != $key2) {
 					// Sort numbers (E.g.: 9 < 10)
-					if (($dummy[$a_sort[$primary_key]][$key] < $dummy[$a_sort[$primary_key]][$key2]) && ($order == -1)) $match = true;
-					if (($dummy[$a_sort[$primary_key]][$key] > $dummy[$a_sort[$primary_key]][$key2]) && ($order == 1))  $match = true;
+					if (($temporaryArray[$a_sort[$primary_key]][$key] < $temporaryArray[$a_sort[$primary_key]][$key2]) && ($order == -1)) $match = true;
+					if (($temporaryArray[$a_sort[$primary_key]][$key] > $temporaryArray[$a_sort[$primary_key]][$key2]) && ($order == 1))  $match = true;
 				}
 
 				if ($match) {
 					// We have found two different values, so let's sort whole array
-					foreach ($dummy as $sort_key => $sort_val) {
-						$t                       = $dummy[$sort_key][$key];
-						$dummy[$sort_key][$key]  = $dummy[$sort_key][$key2];
-						$dummy[$sort_key][$key2] = $t;
+					foreach ($temporaryArray as $sort_key => $sort_val) {
+						$t                       = $temporaryArray[$sort_key][$key];
+						$temporaryArray[$sort_key][$key]  = $temporaryArray[$sort_key][$key2];
+						$temporaryArray[$sort_key][$key2] = $t;
 						unset($t);
 					} // END - foreach
 				} // END - if
@@ -625,7 +625,7 @@ function array_pk_sort (&$array, $a_sort, $primary_key = '0', $order = -1, $nums
 	} // END - while
 
 	// Write back sorted array
-	$array = $dummy;
+	$array = $temporaryArray;
 }
 
 
@@ -676,7 +676,7 @@ function generateRandomCode ($length, $code, $userid, $extraData = '') {
 	}
 
 	// Create number from hash
-	$rcode = hexdec(substr($saltedHash, 8, 9)) / abs(getRandNo() - $a + sqrt(getConfig('_ADD'))) / pi();
+	$rcode = hexdec(substr($saltedHash, getSaltLength(), 9)) / abs(getRandNo() - $a + sqrt(getConfig('_ADD'))) / pi();
 
 	// At least 10 numbers shall be secure enought!
 	if (isExtensionActive('other')) {
@@ -689,8 +689,8 @@ function generateRandomCode ($length, $code, $userid, $extraData = '') {
 		$len = 10;
 	} // END - if
 
-	// Cut off requested counts of number
-	$return = substr(str_replace('.', '', $rcode), 0, $len);
+	// Cut off requested counts of number, but skip first digit (which is mostly a zero)
+	$return = substr($rcode, (strpos($rcode, '.') + 1), $len);
 
 	// Done building code
 	return $return;
@@ -1465,7 +1465,7 @@ function handleExtraValues ($filterFunction, $value, $extraValue) {
 }
 
 // Converts timestamp selections into a timestamp
-function convertSelectionsToEpocheTime (array &$postData, array &$DATA, &$id, &$skip) {
+function convertSelectionsToEpocheTime (array &$postData, array &$content, &$id, &$skip) {
 	// Init test variable
 	$skip  = false;
 	$test2 = '';
@@ -1480,7 +1480,7 @@ function convertSelectionsToEpocheTime (array &$postData, array &$DATA, &$id, &$
 		if ((isset($postData[$test.'_ye'])) && (isset($postData[$test.'_mo'])) && (isset($postData[$test.'_we'])) && (isset($postData[$test.'_da'])) && (isset($postData[$test.'_ho'])) && (isset($postData[$test.'_mi'])) && (isset($postData[$test.'_se'])) && ($test != $test2)) {
 			// Generate timestamp
 			$postData[$test] = createEpocheTimeFromSelections($test, $postData);
-			$DATA[] = sprintf("`%s`='%s'", $test, $postData[$test]);
+			$content[] = sprintf("`%s`='%s'", $test, $postData[$test]);
 			$GLOBALS['skip_config'][$test] = true;
 
 			// Remove data from array
@@ -1690,7 +1690,7 @@ function determineReferalId () {
 	}
 
 	// Set cookie when default refid > 0
-	if (!isSessionVariableSet('refid') || (!isValidUserId(getReferalId())) || ((!isValidUserId(getSession('refid'))) && (isExtensionInstalledAndNewer('sql_patches', '0.1.2')) && (isValidUserId(getDefRefid())))) {
+	if ((!isSessionVariableSet('refid')) || (!isValidUserId(getReferalId())) || ((!isValidUserId(getSession('refid'))) && (isExtensionInstalledAndNewer('sql_patches', '0.1.2')) && (isValidUserId(getDefRefid())))) {
 		// Default is not found
 		$found = false;
 
@@ -1721,11 +1721,12 @@ function determineReferalId () {
 		// Set cookie
 		//* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'Saving refid to session (' . getReferalId() . ') #1');
 		setSession('refid', getReferalId());
-	} elseif (!isReferalIdValid()) {
+	} elseif ((!isReferalIdValid()) || (!fetchUserData(getReferalId()))) {
 		// Not valid!
 		//* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'Not valid referal id (' . getReferalId() . '), setting NULL in session');
+		setReferalId(NULL);
 		setSession('refid', NULL);
-	} elseif ((!isSessionVariableSet('refid')) && (isValidUserId(getReferalId()))) {
+	} else {
 		// Set it from GLOBALS array in session
 		//* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'Saving refid to session (' . getReferalId() . ') #2');
 		setSession('refid', getReferalId());
@@ -2251,7 +2252,7 @@ function generateAdminMailLinks ($mailType, $mailId) {
 	// Is the mail type supported?
 	if (!empty($table)) {
 		// Query for the mail
-		$result = SQL_QUERY_ESC("SELECT `id`, `%s` AS `mail_status` FROM `{?_MYSQL_PREFIX?}_%s` WHERE `id`=%s LIMIT 1",
+		$result = SQL_QUERY_ESC("SELECT `id`,`%s` AS `mail_status` FROM `{?_MYSQL_PREFIX?}_%s` WHERE `id`=%s LIMIT 1",
 			array(
 				$statusColumn,
 				$table,