X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=inc%2Flibs%2Fsurfbar_functions.php;h=30baabbc708c55935d605b0259540f2e50f8b9ad;hb=bb3d322203724ae9026368c8da7bda02da01940e;hp=cab4fb587d36df2bdb09be7877a42b8916cf5df0;hpb=594c7972b8abcf8086547d43e30aa8c26fb54ac4;p=mailer.git

diff --git a/inc/libs/surfbar_functions.php b/inc/libs/surfbar_functions.php
index cab4fb587d..30baabbc70 100644
--- a/inc/libs/surfbar_functions.php
+++ b/inc/libs/surfbar_functions.php
@@ -10,7 +10,12 @@
  * -------------------------------------------------------------------- *
  * Kurzbeschreibung  : Funktionen fuer die Surfbar                      *
  * -------------------------------------------------------------------- *
- *                                                                      *
+ * $Revision::                                                        $ *
+ * $Date::                                                            $ *
+ * $Tag:: 0.2.1-FINAL                                                 $ *
+ * $Author::                                                          $ *
+ * Needs to be in all Files and every File needs "svn propset           *
+ * svn:keywords Date Revision" (autoprobset!) at least!!!!!!            *
  * -------------------------------------------------------------------- *
  * Copyright (c) 2003 - 2008 by Roland Haeder                           *
  * For more information visit: http://www.mxchange.org                  *
@@ -33,7 +38,7 @@
 
 // Some security stuff...
 if (!defined('__SECURITY')) {
-	$INC = substr(dirname(__FILE__), 0, strpos(dirname(__FILE__), "/inc") + 4) . "/security.php";
+	$INC = substr(dirname(__FILE__), 0, strpos(dirname(__FILE__), '/inc') + 4) . '/security.php';
 	require($INC);
 }
 
@@ -153,10 +158,10 @@ function SURFBAR_MEMBER_ADD_URL ($url, $limit) {
 	} elseif (!VALIDATE_URL($url)) {
 		// URL invalid
 		return false;
-	} elseif (SURFBAR_LOOKUP_BY_URL($url, $GLOBALS['userid'])) {
+	} elseif (SURFBAR_LOOKUP_BY_URL($url, getUserId())) {
 		// URL already found in surfbar!
 		return false;
-	} elseif (!SURFBAR_IF_USER_BOOK_MORE_URLS($GLOBALS['userid'])) {
+	} elseif (!SURFBAR_IF_USER_BOOK_MORE_URLS(getUserId())) {
 		// No more allowed!
 		return false;
 	} elseif ("".($limit + 0)."" != "".$limit."") {
@@ -165,7 +170,7 @@ function SURFBAR_MEMBER_ADD_URL ($url, $limit) {
 	}
 
 	// Register the new URL
-	return SURFBAR_REGISTER_URL($url, $GLOBALS['userid'], "PENDING", "reg", array('limit' => $limit));
+	return SURFBAR_REGISTER_URL($url, getUserId(), "PENDING", "reg", array('limit' => $limit));
 }
 // Create list of actions depending on status for the user
 function SURFBAR_MEMBER_ACTIONS ($urlId, $status) {
@@ -243,7 +248,7 @@ function SURFBAR_MEMBER_DO_FORM ($formData, $URLs) {
 	} else {
 		// Log invalid request
 		DEBUG_LOG(__FUNCTION__, __LINE__, " action={$formData['action']},id={$formData['id']},function={$functionName}");
-		addFatalMessage("Invalid member action! action=%s,id=%s,function=%s", array($formData['action'], $formData['id'], $functionName));
+		addFatalMessage(__FUNCTION__, __LINE__, "Invalid member action! action=%s,id=%s,function=%s", array($formData['action'], $formData['id'], $functionName));
 	}
 
 	// Return status
@@ -253,7 +258,7 @@ function SURFBAR_MEMBER_DO_FORM ($formData, $URLs) {
 function SURFBAR_VALIDATE_MEMBER_ACTION_STATUS ($action, $status) {
 	// Search for the requested action/status combination in database
 	$result = SQL_QUERY_ESC("SELECT new_status FROM `{!_MYSQL_PREFIX!}_surfbar_actions` WHERE `action`='%s' AND `status`='%s' LIMIT 1",
-		array($action, $status), __FILE__, __LINE__);
+		array($action, $status), __FUNCTION__, __LINE__);
 
 	// Is the entry there?
 	$isValid = (SQL_NUMROWS($result) == 1);
@@ -353,15 +358,15 @@ function SURFBAR_MEMBER_DISPLAY_ACTION_FORM ($action, $urlData) {
 	// Include fields only for action 'edit'
 	if ($action == "edit") {
 		// Default is not limited
-		$urlData['limited_yes'] = "";
-		$urlData['limited_no']  = " checked=\"checked\"";
+		$urlData['limited_yes'] = '';
+		$urlData['limited_no']  = ' chkecked="checked"';
 		$urlData['limited']     = "false";
 
 		// Is this URL limited?
 		if ($urlData['views_max'] > 0) {
 			// Then rewrite form data
-			$urlData['limited_yes'] = " checked=\"checked\"";
-			$urlData['limited_no']  = "";
+			$urlData['limited_yes'] = ' chkecked="checked"';
+			$urlData['limited_no']  = '';
 			$urlData['limited']     = "true";
 		} // END - if
 	} // END - if
@@ -378,7 +383,7 @@ function SURFBAR_MEMBER_EXECUTE_ACTION ($action, $urlData) {
 	$executed = false;
 
 	// Is limitation "no" and "limit" is > 0?
-	if ((isset($urlData[$action]['limited'])) && ($urlData[$action]['limited'] == "N") && ((isset($urlData[$action]['limit'])) && ($urlData[$action]['limit'] > 0)) || (!isset($urlData[$action]['limit']))) {
+	if ((isset($urlData[$action]['limited'])) && ($urlData[$action]['limited'] == 'N') && ((isset($urlData[$action]['limit'])) && ($urlData[$action]['limit'] > 0)) || (!isset($urlData[$action]['limit']))) {
 		// Set it to unlimited
 		$urlData[$action]['limit'] = 0;
 	} // END - if
@@ -401,7 +406,7 @@ function SURFBAR_MEMBER_EXECUTE_ACTION ($action, $urlData) {
 		} // END - if
 	} else {
 		// Not found!
-		addFatalMessage(MEMBER_SURFBAR_EXECUTE_ACTION_404, $functionName);
+		addFatalMessage(__FUNCTION__, __LINE__, getMessage('MEMBER_SURFBAR_EXECUTE_ACTION_404'), $functionName);
 	}
 
 	// Return status
@@ -421,7 +426,7 @@ function SURFBAR_MEMBER_EXECUTE_EDIT_ACTION ($urlData) {
 	//if (($urlData['views_allowed'] != $urlData['edit']['limit']) || ($url1 != $url2)) {
 		// Run the query
 		SQL_QUERY_ESC("UPDATE `{!_MYSQL_PREFIX!}_surfbar_urls` SET url='%s', views_allowed=%s, views_max=%s WHERE id=%s AND `status`='%s' LIMIT 1",
-			array($urlData['url'], $urlData['edit']['limit'], $urlData['edit']['limit'], $urlData['id'], $urlData['status']), __FILE__, __LINE__);
+			array($urlData['url'], $urlData['edit']['limit'], $urlData['edit']['limit'], $urlData['id'], $urlData['status']), __FUNCTION__, __LINE__);
 
 		// All fine
 		$status = true;
@@ -492,7 +497,7 @@ function SURFBAR_HANDLE_LOW_POINTS () {
 
 			// Update last notified
 			SQL_QUERY_ESC("UPDATE `{!_MYSQL_PREFIX!}_user_data` SET surfbar_low_notified=NOW() WHERE userid=%s LIMIT 1",
-				array($uid), __FILE__, __LINE__);
+				array($uid), __FUNCTION__, __LINE__);
 		} // END - if
 	} // END - foreach
 }
@@ -514,19 +519,17 @@ function SURFBAR_LOOKUP_BY_URL ($url, $uid) {
 
 // Load URL data by given search term and column
 function SURFBAR_GET_URL_DATA ($searchTerm, $column="id", $order="id", $sort="ASC", $group="id", $add="") {
-	global $lastUrlData;
-
 	// By default nothing is found
-	$lastUrlData = array();
+	$GLOBALS['last_url_data'] = array();
 
 	// Is the column an id number?
-	if (($column == "id") || ($column == "userid")) {
+	if (($column == "id") || ($column == 'userid')) {
 		// Extra secure input
 		$searchTerm = bigintval($searchTerm);
 	} // END - if
 
 	// If the column is "id" there can be only one entry
-	$limit = "";
+	$limit = '';
 	if ($column == "id") {
 		$limit = "LIMIT 1";
 	} // END - if
@@ -537,7 +540,7 @@ FROM `{!_MYSQL_PREFIX!}_surfbar_urls`
 WHERE %s='%s'".$add."
 ORDER BY %s %s
 %s",
-		array($column, $searchTerm, $order, $sort, $limit), __FILE__, __LINE__);
+		array($column, $searchTerm, $order, $sort, $limit), __FUNCTION__, __LINE__);
 
 	// Is there at least one record?
 	if (SQL_NUMROWS($result) > 0) {
@@ -546,10 +549,10 @@ ORDER BY %s %s
 			// Shall we group these results?
 			if ($group == "id") {
 				// Add the row by id as index
-				$lastUrlData[$dataRow['id']] = $dataRow;
+				$GLOBALS['last_url_data'][$dataRow['id']] = $dataRow;
 			} else {
 				// Group entries
-				$lastUrlData[$dataRow[$group]][$dataRow['id']] = $dataRow;
+				$GLOBALS['last_url_data'][$dataRow[$group]][$dataRow['id']] = $dataRow;
 			}
 		} // END - while
 	} // END - if
@@ -558,7 +561,7 @@ ORDER BY %s %s
 	SQL_FREERESULT($result);
 
 	// Return the result
-	return $lastUrlData;
+	return $GLOBALS['last_url_data'];
 }
 
 // Registers an URL with the surfbar. You should have called SURFBAR_LOOKUP_BY_URL() first!
@@ -591,7 +594,7 @@ function SURFBAR_REGISTER_URL ($url, $uid, $status="PENDING", $addMode="reg", $e
 	$content['limit'] = SURFBAR_TRANSLATE_LIMIT($content['limit']);
 
 	// If in reg-mode we notify admin
-	if (($addMode == "reg") || (getConfig('surfbar_notify_admin_unlock') == "Y")) {
+	if (($addMode == "reg") || (getConfig('surfbar_notify_admin_unlock') == 'Y')) {
 		// Notify admin even when he as unlocked an email
 		SURFBAR_NOTIFY_ADMIN("url_{$addMode}", $content);
 	} // END - if
@@ -620,7 +623,7 @@ function SURFBAR_INSERT_URL_BY_ARRAY ($urlData) {
 			$urlData['limit'],
 			$urlData['limit'],
 			$urlData['reload']
-		), __FILE__, __LINE__
+		), __FUNCTION__, __LINE__
 	);
 
 	// Return insert id
@@ -804,7 +807,7 @@ INNER JOIN `{!_MYSQL_PREFIX!}_surfbar_urls` AS u
 ON u.id=l.url_id
 WHERE l.userid=%s AND (UNIX_TIMESTAMP() - ".SURFBAR_GET_SURF_LOCK().") < UNIX_TIMESTAMP(l.last_surfed) AND (((UNIX_TIMESTAMP(l.last_surfed) - u.fixed_reload) < 0 AND u.fixed_reload > 0) OR u.fixed_reload = 0)
 LIMIT 1",
-		array($GLOBALS['userid']), __FILE__, __LINE__
+		array(getUserId()), __FUNCTION__, __LINE__
 	);
 
 	// Fetch row
@@ -844,7 +847,7 @@ function SURFBAR_GET_TOTAL_URLS ($status="ACTIVE", $excludeUserId=0) {
 	$result = SQL_QUERY_ESC("SELECT COUNT(id) AS cnt
 FROM `{!_MYSQL_PREFIX!}_surfbar_urls`
 WHERE userid NOT IN (".implode(",", $UIDs['uid']).") AND `status`='%s'",
-		array($status), __FILE__, __LINE__
+		array($status), __FUNCTION__, __LINE__
 	);
 
 	// Fetch row
@@ -859,43 +862,43 @@ WHERE userid NOT IN (".implode(",", $UIDs['uid']).") AND `status`='%s'",
 // Check wether the user is allowed to book more URLs
 function SURFBAR_IF_USER_BOOK_MORE_URLS ($uid=0) {
 	// Is this admin and userid is zero or does the user has some URLs left to book?
-	return ((($uid == 0) && (IS_ADMIN())) || (SURFBAR_GET_TOTAL_USER_URLS($uid, "", array("REJECTED")) < getConfig('surfbar_max_order')));
+	return ((($uid == 0) && (IS_ADMIN())) || (SURFBAR_GET_TOTAL_USER_URLS($uid, '', array("REJECTED")) < getConfig('surfbar_max_order')));
 }
 // Get total amount of URLs of given status for current user
 function SURFBAR_GET_TOTAL_USER_URLS ($uid=0, $status="",$exclude="") {
 	// Is the user 0 and user is logged in?
 	if (($uid == 0) && (IS_MEMBER())) {
 		// Then use this userid
-		$uid = $GLOBALS['userid'];
+		$uid = getUserId();
 	} elseif ($uid == 0) {
 		// Error!
 		return (getConfig('surfbar_max_order') + 1);
 	}
 
 	// Default is all URLs
-	$ADD = "";
+	$add = '';
 
 	// Is the status set?
 	if (is_array($status)) {
 		// Only URLs with these status
-		$ADD = sprintf(" AND status IN('%s')", implode("','", $status));
+		$add = sprintf(" AND status IN('%s')", implode("','", $status));
 	} elseif (!empty($status)) {
 		// Only URLs with this status
-		$ADD = sprintf(" AND `status`='%s'", $status);
+		$add = sprintf(" AND `status`='%s'", $status);
 	} elseif (is_array($exclude)) {
 		// Exclude URLs with these status
-		$ADD = sprintf(" AND status NOT IN('%s')", implode("','", $exclude));
+		$add = sprintf(" AND status NOT IN('%s')", implode("','", $exclude));
 	} elseif (!empty($exclude)) {
 		// Exclude URLs with this status
-		$ADD = sprintf(" AND status != '%s'", $exclude);
+		$add = sprintf(" AND status != '%s'", $exclude);
 	}
 
 	// Get amount from database
 	$result = SQL_QUERY_ESC("SELECT COUNT(id) AS cnt
 FROM `{!_MYSQL_PREFIX!}_surfbar_urls`
-WHERE userid=%s".$ADD."
+WHERE userid=%s".$add."
 LIMIT %s",
-		array($uid, getConfig('surfbar_max_order')), __FILE__, __LINE__
+		array($uid, getConfig('surfbar_max_order')), __FUNCTION__, __LINE__
 	);
 
 	// Fetch row
@@ -919,7 +922,7 @@ function SURFBAR_GENERATE_VALIDATION_CODE ($urlId, $salt="") {
 	if ($length == 0) $length = 10;
 
 	// Generate a code until the length matches
-	$valCode = "";
+	$valCode = '';
 	while (strlen($valCode) != $length) {
 		// Is the salt set?
 		if (empty($salt)) {
@@ -933,7 +936,7 @@ function SURFBAR_GENERATE_VALIDATION_CODE ($urlId, $salt="") {
 		}
 
 		// ... and now the validation code
-		$valCode = GEN_RANDOM_CODE($length, sha1(SURFBAR_GET_SALT().":".$urlId), $GLOBALS['userid']);
+		$valCode = generateRandomCodde($length, sha1(SURFBAR_GET_SALT().":".$urlId), getUserId());
 		//* DEBUG: */ DEBUG_LOG(__FUNCTION__, __LINE__, "valCode={$valCode}", false);
 	} // END - while
 
@@ -966,11 +969,11 @@ function SURFBAR_LOCKDOWN_ID ($urlId) {
 	///* DEBUG: */ return;
 	// Just add it to the database
 	SQL_QUERY_ESC("INSERT INTO `{!_MYSQL_PREFIX!}_surfbar_locks` (userid, url_id) VALUES (%s, %s)",
-		array($GLOBALS['userid'], bigintval($urlId)), __FILE__, __LINE__);
+		array(getUserId(), bigintval($urlId)), __FUNCTION__, __LINE__);
 
 	// Remove the salt from database
 	SQL_QUERY_ESC("DELETE LOW_PRIORITY FROM `{!_MYSQL_PREFIX!}_surfbar_salts` WHERE url_id=%s AND userid=%s LIMIT 1",
-		array(bigintval($urlId), $GLOBALS['userid']), __FILE__, __LINE__);
+		array(bigintval($urlId), getUserId()), __FUNCTION__, __LINE__);
 }
 // Pay points to the user and remove it from the sender if userid is given else it is a "sponsored surf"
 function SURFBAR_PAY_POINTS () {
@@ -981,13 +984,13 @@ function SURFBAR_PAY_POINTS () {
 	} // END - if
 
 	// Book it to the user
-	//* DEBUG: */ DEBUG_LOG(__FUNCTION__, __LINE__, "uid=".$GLOBALS['userid'].",reward=".SURFBAR_GET_REWARD()."", false);
-	ADD_POINTS_REFSYSTEM(sprintf("surfbar_%s", getConfig('surfbar_pay_model')), $GLOBALS['userid'], SURFBAR_GET_DATA('reward'));
+	//* DEBUG: */ DEBUG_LOG(__FUNCTION__, __LINE__, "uid=".getUserId().",reward=".SURFBAR_GET_REWARD()."", false);
+	ADD_POINTS_REFSYSTEM(sprintf("surfbar_%s", getConfig('surfbar_pay_model')), getUserId(), SURFBAR_GET_DATA('reward'));
 }
 // Updates the statistics of current URL/userid
 function SURFBAR_UPDATE_INSERT_STATS_RECORD () {
 	// Init add
-	$ADD = "";
+	$add = '';
 
 	// Get allowed views
 	$allowed = SURFBAR_GET_VIEWS_ALLOWED();
@@ -995,22 +998,22 @@ function SURFBAR_UPDATE_INSERT_STATS_RECORD () {
 	// Do we have a limit?
 	if ($allowed > 0) {
 		// Then count views_max down!
-		$ADD .= ",views_max=views_max-1";
+		$add .= ",views_max=views_max-1";
 	} // END - if
 
 	// Update URL stats
-	SQL_QUERY_ESC("UPDATE `{!_MYSQL_PREFIX!}_surfbar_urls` SET views_total=views_total+1".$ADD." WHERE id=%s LIMIT 1",
-		array(SURFBAR_GET_ID()), __FILE__, __LINE__);
+	SQL_QUERY_ESC("UPDATE `{!_MYSQL_PREFIX!}_surfbar_urls` SET views_total=views_total+1".$add." WHERE id=%s LIMIT 1",
+		array(SURFBAR_GET_ID()), __FUNCTION__, __LINE__);
 
 	// Update the stats entry
 	SQL_QUERY_ESC("UPDATE `{!_MYSQL_PREFIX!}_surfbar_stats` SET count=count+1 WHERE userid=%s AND url_id=%s LIMIT 1",
-		array($GLOBALS['userid'], SURFBAR_GET_ID()), __FILE__, __LINE__);
+		array(getUserId(), SURFBAR_GET_ID()), __FUNCTION__, __LINE__);
 
 	// Was that update okay?
 	if (SQL_AFFECTEDROWS() < 1) {
 		// No, then insert entry
 		SQL_QUERY_ESC("INSERT INTO `{!_MYSQL_PREFIX!}_surfbar_stats` (userid,url_id,count) VALUES (%s,%s,1)",
-			array($GLOBALS['userid'], SURFBAR_GET_ID()), __FILE__, __LINE__);
+			array(getUserId(), SURFBAR_GET_ID()), __FUNCTION__, __LINE__);
 	} // END - if
 
 	// Update total/daily/weekly/monthly counter
@@ -1029,16 +1032,16 @@ function SURFBAR_UPDATE_SALT_STATS () {
 
 	// Simply store the salt from cache away in database...
 	SQL_QUERY_ESC("UPDATE `{!_MYSQL_PREFIX!}_surfbar_salts` SET last_salt='%s' WHERE url_id=%s AND userid=%s LIMIT 1",
-		array(SURFBAR_GET_SALT(), SURFBAR_GET_ID(), $GLOBALS['userid']), __FILE__, __LINE__);
+		array(SURFBAR_GET_SALT(), SURFBAR_GET_ID(), getUserId()), __FUNCTION__, __LINE__);
 
 	// Debug message
-	//* DEBUG: */ DEBUG_LOG(__FUNCTION__, __LINE__, "salt=".SURFBAR_GET_SALT().",id=".SURFBAR_GET_ID().",uid=".$GLOBALS['userid']."", false);
+	//* DEBUG: */ DEBUG_LOG(__FUNCTION__, __LINE__, "salt=".SURFBAR_GET_SALT().",id=".SURFBAR_GET_ID().",uid=".getUserId()."", false);
 
 	// Was that okay?
 	if (SQL_AFFECTEDROWS() < 1) {
 		// Insert missing entry!
 		SQL_QUERY_ESC("INSERT INTO `{!_MYSQL_PREFIX!}_surfbar_salts` (url_id,userid,last_salt) VALUES (%s, %s, '%s')",
-			array(SURFBAR_GET_ID(), $GLOBALS['userid'], SURFBAR_GET_SALT()), __FILE__, __LINE__);
+			array(SURFBAR_GET_ID(), getUserId(), SURFBAR_GET_SALT()), __FUNCTION__, __LINE__);
 	} // END - if
 
 	// Debug message
@@ -1056,7 +1059,7 @@ FROM `{!_MYSQL_PREFIX!}_surfbar_locks`
 WHERE userid=%s AND url_id=%s AND (UNIX_TIMESTAMP() - ".SURFBAR_GET_SURF_LOCK().") < UNIX_TIMESTAMP(last_surfed)
 ORDER BY last_surfed ASC
 LIMIT 1",
-		array($GLOBALS['userid'], bigintval($urlId)), __FILE__, __LINE__
+		array(getUserId(), bigintval($urlId)), __FUNCTION__, __LINE__
 	);
 
 	// Fetch counter
@@ -1081,9 +1084,9 @@ function SURFBAR_DETERMINE_DEPLETED_USERIDS ($limit=0) {
 	// Do we have a current user id?
 	if ((IS_MEMBER()) && ($limit == 0)) {
 		// Then add this as well
-		$UIDs['uid'][$GLOBALS['userid']]      = $GLOBALS['userid'];
-		$UIDs['points'][$GLOBALS['userid']]   = GET_TOTAL_DATA($GLOBALS['userid'], "user_points", "points") - GET_TOTAL_DATA($GLOBALS['userid'], "user_data", "used_points");
-		$UIDs['notified'][$GLOBALS['userid']] = 0;
+		$UIDs['uid'][getUserId()]      = getUserId();
+		$UIDs['points'][getUserId()]   = GET_TOTAL_DATA(getUserId(), "user_points", "points") - GET_TOTAL_DATA(getUserId(), "user_data", "used_points");
+		$UIDs['notified'][getUserId()] = 0;
 
 		// Get all userid except logged in one
 		$result = SQL_QUERY_ESC("SELECT u.userid, UNIX_TIMESTAMP(d.surfbar_low_notified) AS notified
@@ -1093,7 +1096,7 @@ ON u.userid=d.userid
 WHERE u.userid NOT IN (%s,0) AND u.`status`='ACTIVE'
 GROUP BY u.userid
 ORDER BY u.userid ASC",
-			array($GLOBALS['userid']), __FILE__, __LINE__);
+			array(getUserId()), __FUNCTION__, __LINE__);
 	} else {
 		// Get all userid
 		$result = SQL_QUERY("SELECT u.userid, UNIX_TIMESTAMP(d.surfbar_low_notified) AS notified
@@ -1102,22 +1105,22 @@ INNER JOIN `{!_MYSQL_PREFIX!}_user_data` AS d
 ON u.userid=d.userid
 WHERE u.`status`='ACTIVE'
 GROUP BY u.userid
-ORDER BY u.userid ASC", __FILE__, __LINE__);
+ORDER BY u.userid ASC", __FUNCTION__, __LINE__);
 	}
 
 	// Load all userid
-	while (list($uid, $notified) = SQL_FETCHROW($result)) {
+	while ($content = SQL_FETCHARRAY($result)) {
 		// Get total points
-		$points = GET_TOTAL_DATA($uid, "user_points", "points") - GET_TOTAL_DATA($uid, "user_data", "used_points");
-		//* DEBUG: */ DEBUG_LOG(__FUNCTION__, __LINE__, "uid={$uid},points={$points}", false);
+		$points = GET_TOTAL_DATA($content['userid'], "user_points", "points") - GET_TOTAL_DATA($content['userid'], "user_data", "used_points");
+		//* DEBUG: */ DEBUG_LOG(__FUNCTION__, __LINE__, "uid={$content['userid']},points={$points}", false);
 
 		// Shall we add this to ignore?
 		if ($points <= $limit) {
 			// Ignore this one!
-			//* DEBUG: */ DEBUG_LOG(__FUNCTION__, __LINE__, "uid={$uid} has depleted points amount!", false);
-			$UIDs['uid'][$uid] = $uid;
-			$UIDs['points'][$uid] = $points;
-			$UIDs['notified'][$uid] = $notified;
+			//* DEBUG: */ DEBUG_LOG(__FUNCTION__, __LINE__, "uid={$content['userid']} has depleted points amount!", false);
+			$UIDs['uid'][$content['userid']]      = $content['userid'];
+			$UIDs['points'][$content['userid']]   = $points;
+			$UIDs['notified'][$content['userid']] = $content['notified'];
 		} // END - if
 	} // END - while
 
@@ -1125,7 +1128,7 @@ ORDER BY u.userid ASC", __FILE__, __LINE__);
 	SQL_FREERESULT($result);
 
 	// Debug message
-	//* DEBUG: */ DEBUG_LOG(__FUNCTION__, __LINE__, "UIDs::count=".count($UIDs)." (with own userid=".$GLOBALS['userid'].")", false);
+	//* DEBUG: */ DEBUG_LOG(__FUNCTION__, __LINE__, "UIDs::count=".count($UIDs)." (with own userid=".getUserId().")", false);
 
 	// Return result
 	return $UIDs;
@@ -1137,7 +1140,7 @@ function SURFBAR_DETERMINE_TOTAL_ONLINE () {
 FROM `{!_MYSQL_PREFIX!}_surfbar_stats`
 WHERE (UNIX_TIMESTAMP() - UNIX_TIMESTAMP(last_online)) <= %s
 GROUP BY userid",
-		array(getConfig('online_timeout')), __FILE__, __LINE__);
+		array(getConfig('online_timeout')), __FUNCTION__, __LINE__);
 
 	// Fetch count
 	$cnt = SQL_NUMROWS($result);
@@ -1198,14 +1201,16 @@ function SURFBAR_CHANGE_STATUS ($urlId, $prevStatus, $newStatus, $data=array())
 	// Update the status now
 	// ---------- Comment out for debugging/developing member actions! ---------
 	//SQL_QUERY_ESC("UPDATE `{!_MYSQL_PREFIX!}_surfbar_urls` SET `status`='%s' WHERE id=%s LIMIT 1",
-	//	array($newStatus, bigintval($urlId)), __FILE__, __LINE__);
+	//	array($newStatus, bigintval($urlId)), __FUNCTION__, __LINE__);
 	// ---------- Comment out for debugging/developing member actions! ---------
 
 	// Was that fine?
+	// ---------- Comment out for debugging/developing member actions! ---------
 	//if (SQL_AFFECTEDROWS() != 1) {
 	//	// No, something went wrong
 	//	return false;
 	//} // END - if
+	// ---------- Comment out for debugging/developing member actions! ---------
 
 	// Prepare content for notification routines
 	$data[$urlId]['uid']         = $data[$urlId]['userid'];
@@ -1237,7 +1242,7 @@ function SURFBAR_CALCULATE_DYNAMIC_MIN_VALUE () {
 	$percent = abs(log(getConfig('surfbar_dynamic_percent') / 100 + 1));
 
 	// Get total users
-	$totalUsers = GET_TOTAL_DATA("CONFIRMED", "user_data", "userid", "status", true);
+	$totalUsers = GET_TOTAL_DATA("CONFIRMED", "user_data", 'userid', "status", true);
 
 	// Get online users
 	$onlineUsers = SURFBAR_DETERMINE_TOTAL_ONLINE();
@@ -1273,7 +1278,7 @@ function SURFBAR_CALCULATE_DYNAMIC_MAX_VALUE () {
 	$percent = abs(log(getConfig('surfbar_dynamic_percent') / 100 + 1));
 
 	// Get total users
-	$totalUsers = GET_TOTAL_DATA("CONFIRMED", "user_data", "userid", "status", true);
+	$totalUsers = GET_TOTAL_DATA("CONFIRMED", "user_data", 'userid', "status", true);
 
 	// Calculate addon
 	$addon += abs($max * $percent * $totalUsers);
@@ -1315,36 +1320,36 @@ FROM
 WHERE
 	userid=%s
 ORDER BY
-	id ASC", array($GLOBALS['userid']),
-		__FILE__, __LINE__);
+	id ASC", array(getUserId()),
+		__FUNCTION__, __LINE__);
 
 	// Load all entries
-	while (list($lid, $url, $last) = SQL_FETCHROW($result)) {
+	while ($content = SQL_FETCHARRAY($result)) {
 		// Debug message
-		//* DEBUG: */ DEBUG_LOG(__FUNCTION__, __LINE__, "next - lid={$lid},url={$url},rest=".(time() - $last)."/".SURFBAR_GET_SURF_LOCK()."", false);
+		//* DEBUG: */ DEBUG_LOG(__FUNCTION__, __LINE__, "next - lid={$content['id']},url={$content['url_id']},rest=".(time() - $last)."/".SURFBAR_GET_SURF_LOCK()."", false);
 
 		// Skip entries that are too old
-		if (($last > (time() - SURFBAR_GET_SURF_LOCK())) && (!in_array($url, $ignored))) {
+		if (($last > (time() - SURFBAR_GET_SURF_LOCK())) && (!in_array($content['url_id'], $ignored))) {
 			// Debug message
-			//* DEBUG: */ DEBUG_LOG(__FUNCTION__, __LINE__, "okay - lid={$lid},url={$url},last={$last}", false);
+			//* DEBUG: */ DEBUG_LOG(__FUNCTION__, __LINE__, "okay - lid={$content['id']},url={$content['url_id']},last={$last}", false);
 
 			// Add only if missing or bigger
-			if ((!isset($IDs[$url])) || ($IDs[$url] > $last)) {
+			if ((!isset($IDs[$content['url_id']])) || ($IDs[$content['url_id']] > $last)) {
 				// Debug message
-				//* DEBUG: */ DEBUG_LOG(__FUNCTION__, __LINE__, "ADD - lid={$lid},url={$url},last={$last}", false);
+				//* DEBUG: */ DEBUG_LOG(__FUNCTION__, __LINE__, "ADD - lid={$content['id']},url={$content['url_id']},last={$last}", false);
 
 				// Add this ID
-				$IDs[$url] = $last;
-				$USE[$url] = $lid;
+				$IDs[$content['url_id']] = $last;
+				$USE[$content['url_id']] = $content['id'];
 			} // END - if
 		} else {
 			// Debug message
-			//* DEBUG: */ DEBUG_LOG(__FUNCTION__, __LINE__, "ignore - lid={$lid},url={$url},last={$last}", false);
+			//* DEBUG: */ DEBUG_LOG(__FUNCTION__, __LINE__, "ignore - lid={$content['id']},url={$content['url_id']},last={$last}", false);
 
 			// Ignore these old entries!
-			$ignored[] = $url;
-			unset($IDs[$url]);
-			unset($USE[$url]);
+			$ignored[] = $content['url_id'];
+			unset($IDs[$content['url_id']]);
+			unset($USE[$content['url_id']]);
 		}
 	} // END - while
 
@@ -1355,7 +1360,7 @@ ORDER BY
 	return $USE;
 }
 // "Getter" for maximum random number
-function SURFBAR_GET_MAX_RANDOM ($UIDs, $ADD) {
+function SURFBAR_GET_MAX_RANDOM ($UIDs, $add) {
 	// Count max availabe entries
 	$result = SQL_QUERY("SELECT sbu.id AS cnt
 FROM `{!_MYSQL_PREFIX!}_surfbar_urls` AS sbu
@@ -1363,8 +1368,8 @@ LEFT JOIN `{!_MYSQL_PREFIX!}_surfbar_salts` AS sbs
 ON sbu.id=sbs.url_id
 LEFT JOIN `{!_MYSQL_PREFIX!}_surfbar_locks` AS l
 ON sbu.id=l.url_id
-WHERE sbu.userid NOT IN (".implode(",", $UIDs).") AND (sbu.views_allowed=0 OR (sbu.views_allowed > 0 AND sbu.views_max > 0)) AND sbu.`status`='ACTIVE'".$ADD."
-GROUP BY sbu.id", __FILE__, __LINE__);
+WHERE sbu.userid NOT IN (".implode(",", $UIDs).") AND (sbu.views_allowed=0 OR (sbu.views_allowed > 0 AND sbu.views_max > 0)) AND sbu.`status`='ACTIVE'".$add."
+GROUP BY sbu.id", __FUNCTION__, __LINE__);
 
 	// Log last query
 	//* DEBUG: */ DEBUG_LOG(__FUNCTION__, __LINE__, "lastQuery=".getConfig('db_last_query')."|numRows=".SQL_NUMROWS($result)."|Affected=".SQL_AFFECTEDROWS()."", false);
@@ -1388,7 +1393,7 @@ function SURFBAR_GET_USER_URLS () {
 FROM `{!_MYSQL_PREFIX!}_surfbar_urls` AS u
 WHERE u.userid=%s AND u.status != 'DELETED'
 ORDER BY u.id ASC",
-		array($GLOBALS['userid']), __FILE__, __LINE__);
+		array(getUserId()), __FUNCTION__, __LINE__);
 
 	// Are there entries?
 	if (SQL_NUMROWS($result) > 0) {
@@ -1412,13 +1417,14 @@ function SURFBAR_GET_ACTION_ARRAY ($status) {
 
 	// Get all assigned actions
 	$result = SQL_QUERY_ESC("SELECT action FROM `{!_MYSQL_PREFIX!}_surfbar_actions` WHERE `status`='%s' ORDER BY `id` ASC",
-		array($status), __FILE__, __LINE__);
+		array($status), __FUNCTION__, __LINE__);
 
 	// Some entries there?
 	if (SQL_NUMROWS($result) > 0) {
 		// Load all actions
-		while (list($action) = SQL_FETCHROW($result)) {
-			$returnArray[] = $action;
+		// @TODO This can be somehow rewritten
+		while ($content = SQL_FETCHARRAY($result)) {
+			$returnArray[] = $content['action'];
 		} // END - if
 	} // END - if
 
@@ -1453,24 +1459,24 @@ function SURFBAR_DETERMINE_NEXT_ID ($urlId = 0) {
 		$USE = SURFBAR_GET_LOCK_IDS();
 
 		// Shall we add some URL ids to ignore?
-		$ADD = "";
+		$add = '';
 		if (count($USE) > 0) {
 			// Ignore some!
-			$ADD = " AND sbu.id NOT IN (";
+			$add = " AND sbu.id NOT IN (";
 			foreach ($USE as $url_id => $lid) {
 				// Add URL id
-				$ADD .= $url_id.",";
+				$add .= $url_id.",";
 			} // END - foreach
 
 			// Add closing bracket
-			$ADD = substr($ADD, 0, -1) . ")";
+			$add = substr($add, 0, -1) . ")";
 		} // END - if
 
 		// Determine depleted user account
 		$UIDs = SURFBAR_DETERMINE_DEPLETED_USERIDS();
 
 		// Get maximum randomness factor
-		$maxRand = SURFBAR_GET_MAX_RANDOM($UIDs['uid'], $ADD);
+		$maxRand = SURFBAR_GET_MAX_RANDOM($UIDs['uid'], $add);
 
 		// If more than one URL can be called generate the random number!
 		if ($maxRand > 1) {
@@ -1486,11 +1492,11 @@ LEFT JOIN `{!_MYSQL_PREFIX!}_surfbar_salts` AS sbs
 ON sbu.id=sbs.url_id
 LEFT JOIN `{!_MYSQL_PREFIX!}_surfbar_locks` AS l
 ON sbu.id=l.url_id
-WHERE sbu.userid NOT IN (".implode(",", $UIDs['uid']).") AND sbu.`status`='ACTIVE' AND (sbu.views_allowed=0 OR (sbu.views_allowed > 0 AND sbu.views_max > 0))".$ADD."
+WHERE sbu.userid NOT IN (".implode(",", $UIDs['uid']).") AND sbu.`status`='ACTIVE' AND (sbu.views_allowed=0 OR (sbu.views_allowed > 0 AND sbu.views_max > 0))".$add."
 GROUP BY sbu.id
 ORDER BY l.last_surfed ASC, sbu.id ASC
 LIMIT %s,1",
-			array($randNum), __FILE__, __LINE__
+			array($randNum), __FUNCTION__, __LINE__
 		);
 	} else {
 		// Get data from specified id number
@@ -1502,7 +1508,7 @@ LEFT JOIN `{!_MYSQL_PREFIX!}_surfbar_locks` AS l
 ON sbu.id=l.url_id
 WHERE sbu.userid != %s AND sbu.`status`='ACTIVE' AND sbu.id=%s AND (sbu.views_allowed=0 OR (sbu.views_allowed > 0 AND sbu.views_max > 0))
 LIMIT 1",
-			array($GLOBALS['userid'], bigintval($urlId)), __FILE__, __LINE__
+			array(getUserId(), bigintval($urlId)), __FUNCTION__, __LINE__
 		);
 	}
 
@@ -1521,7 +1527,7 @@ LIMIT 1",
 		if (is_null($GLOBALS['cache_array']['surfbar']['last_salt'])) {
 			// Then repair it wit the static!
 			//* DEBUG: */ DEBUG_LOG(__FUNCTION__, __LINE__, "last_salt - FIXED!", false);
-			$GLOBALS['cache_array']['surfbar']['last_salt'] = "";
+			$GLOBALS['cache_array']['surfbar']['last_salt'] = '';
 		} // END - if
 
 		// Fix missing last_surfed
@@ -1556,8 +1562,8 @@ LIMIT 1",
 	return $nextId;
 }
 // -----------------------------------------------------------------------------
-// PLEASE DO NOT ADD ANY OTHER FUNCTIONS BELOW THIS LINE ELSE THEY "WRAP" THE
-// $GLOBALS['cache_array']['surfbar'] ARRAY!
+// PLEASE DO NOT ADD ANY OTHER FUNCTIONS BELOW THIS LINE IF THEY DON'T "WRAP"
+// THE $GLOBALS['cache_array']['surfbar'] ARRAY!
 // -----------------------------------------------------------------------------
 // Private getter for data elements
 function SURFBAR_GET_DATA ($element) {