X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=inc%2Floader%2Fload-extension.php;h=8452a87aa2dae03c2af5fa091267e10045009372;hb=3bfec15f1d037e1dd4885786103c70d0c1cfe1a8;hp=9bc2bd3ed22d94a06ef648081ae90af405421322;hpb=7f1e2ea946407ee2d90704eab52c0297fb8fca69;p=mailer.git

diff --git a/inc/loader/load-extension.php b/inc/loader/load-extension.php
index 9bc2bd3ed2..8452a87aa2 100644
--- a/inc/loader/load-extension.php
+++ b/inc/loader/load-extension.php
@@ -18,8 +18,8 @@
  * $Author::                                                          $ *
  * -------------------------------------------------------------------- *
  * Copyright (c) 2003 - 2009 by Roland Haeder                           *
- * Copyright (c) 2009 - 2011 by Mailer Developer Team                   *
- * For more information visit: http://www.mxchange.org                  *
+ * Copyright (c) 2009 - 2012 by Mailer Developer Team                   *
+ * For more information visit: http://mxchange.org                      *
  *                                                                      *
  * This program is free software; you can redistribute it and/or modify *
  * it under the terms of the GNU General Public License as published by *
@@ -40,10 +40,10 @@
 // Some security stuff...
 if (!defined('__SECURITY')) {
 	die();
-} // END - if
-
-// Use this code if you don't want to run this cache loader on installation phase
-if (isInstallationPhase()) return;
+} elseif (isInstallationPhase()) {
+	// Use this code if you don't want to run this cache loader on installation phase
+	return;
+}
 
 // Next cached table is the extension
 if (($GLOBALS['cache_instance']->loadCacheFile('extension')) && ($GLOBALS['cache_instance']->extensionVersionMatches('sql_patches'))) {
@@ -53,7 +53,7 @@ if (($GLOBALS['cache_instance']->loadCacheFile('extension')) && ($GLOBALS['cache
 	// Init extension inc-pool
 	$EXT_POOL = array();
 
-	// Do we have entries?
+	// Are there entries?
 	if (count($EXT_DUMMY) > 0) {
 		// Init arrays
 		$EXT_NAMES = array();
@@ -61,11 +61,13 @@ if (($GLOBALS['cache_instance']->loadCacheFile('extension')) && ($GLOBALS['cache
 		// Loop through all
 		foreach ($EXT_DUMMY['ext_name'] as $k => $ext_name) {
 			// Load CSS file
-			if ($EXT_DUMMY['ext_css'][$k] == 'Y') addExtensionCssFile($ext_name . '.css');
+			if ($EXT_DUMMY['ext_css'][$k] == 'Y') {
+				addExtensionCssFile($ext_name . '.css');
+			} // END - if
 
 			// Load extension file itself
 			if (($EXT_DUMMY['ext_active'][$k] == 'Y') || ($EXT_DUMMY['ext_keep'][$k] == 'Y')) {
-				$EXT_POOL[] = $ext_name;
+				array_push($EXT_POOL, $ext_name);
 			} // END - if
 
 			// Version number
@@ -121,7 +123,7 @@ if (($GLOBALS['cache_instance']->loadCacheFile('extension')) && ($GLOBALS['cache
 	unset($EXT_DUMMY);
 
 	// No database load needed
-	$res_ext_crt = false;
+	$res_ext_crt = FALSE;
 
 	// Load all extension files in test-mode (we initialize them later)
 	foreach ($EXT_POOL as $ext) {
@@ -134,36 +136,50 @@ if (($GLOBALS['cache_instance']->loadCacheFile('extension')) && ($GLOBALS['cache
 	// Create cache file here
 	$GLOBALS['cache_instance']->init();
 
-	// Add more if sql_patches is recent enougth
+	// Add more if ext-sql_patches is recent enougth
 	$add = '';
-	if (isExtensionInstalledAndNewer('sql_patches', '0.0.6')) $add = ", `ext_has_css` AS ext_css";
+	if (isExtensionInstalledAndNewer('sql_patches', '0.0.6')) {
+		$add = ',`ext_has_css` AS `ext_css`';
+	} // END - if
 
-	// Load all modules and their data
-	$result = SQL_QUERY('SELECT `id` AS ext_id, `ext_name`, `ext_active`, `ext_version`'.$add.' FROM `{?_MYSQL_PREFIX?}_extensions` ORDER BY `ext_name` ASC', __FILE__, __LINE__);
+	// Query for all extensions
+	$result = SQL_QUERY('SELECT
+	`id` AS `ext_id`,
+	`ext_name`,
+	`ext_active`,
+	`ext_version`
+' . $add . '
+FROM
+	`{?_MYSQL_PREFIX?}_extensions`
+ORDER BY
+	`ext_name` ASC', __FILE__, __LINE__);
+
+	// Load all entries
 	while ($content = SQL_FETCHARRAY($result)) {
 		// Load extension
-		loadExtension($content['ext_name'], 'test');
+		if (!loadExtension($content['ext_name'], 'test')) {
+			// Is the name valid?
+			if (!isExtensionNameValid($content['ext_name'])) {
+				// Is not valid name (empty ext-foo.php script)
+				SQL_QUERY_ESC("DELETE LOW_PRIORITY FROM `{?_MYSQL_PREFIX?}_extensions` WHERE `ext_name`='%s' LIMIT 1",
+					array($content['ext_name']), __FILE__, __LINE__);
+			} else {
+				// Didn't load so deactivate it
+				doDeactivateExtension($content['ext_name'], TRUE);
+			}
+
+			// ... and skip it
+			continue;
+		} // END - if
 
 		// Get menu entry
-		$content['ext_menu'] = 'N';
-		if (ifModuleHasMenu($content['ext_name'], true)) {
-			// Extension is a module and has menu... pew!
-			$content['ext_menu'] = 'Y';
-		} // END - if
+		$content['ext_menu'] = convertBooleanToYesNo(ifModuleHasMenu($content['ext_name'], TRUE));
 
 		// Get language entry
-		$content['ext_lang'] = 'N';
-		if (isLanguageIncludeReadable($content['ext_name'])) {
-			// Readable
-			$content['ext_lang'] = 'Y';
-		} // END - if
+		$content['ext_lang'] = convertBooleanToYesNo(isLanguageIncludeReadable($content['ext_name']));
 
 		// Get function entry
-		$content['ext_func'] = 'N';
-		if (isExtensionFunctionFileReadable($content['ext_name'])) {
-			// Readable
-			$content['ext_func'] = 'Y';
-		} // END - if
+		$content['ext_func'] = convertBooleanToYesNo(isExtensionFunctionFileReadable($content['ext_name']));
 
 		// Transfer EXT_ALWAYS_ACTIVE flag
 		$content['ext_keep'] = getThisExtensionAlwaysActive();