X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=inc%2Fmodules%2Fadmin%2Fadmin-inc.php;h=82b3c4202c8faf5a543e4200dbb8ccbb03c41e81;hb=6fc9548b2a0b5bef38ed406ceb3b68981f3d5e48;hp=d668fbaacd7d4447dedffe3820c367fc7cff8fe4;hpb=9d527cf8f2d95f7f58a42cb159f0ffc732f49d39;p=mailer.git diff --git a/inc/modules/admin/admin-inc.php b/inc/modules/admin/admin-inc.php index d668fbaacd..82b3c4202c 100644 --- a/inc/modules/admin/admin-inc.php +++ b/inc/modules/admin/admin-inc.php @@ -38,7 +38,7 @@ // Some security stuff... if (!defined('__SECURITY')) { - $INC = substr(dirname(__FILE__), 0, strpos(dirname(__FILE__), "/inc") + 4) . "/security.php"; + $INC = substr(dirname(__FILE__), 0, strpos(dirname(__FILE__), '/inc') + 4) . '/security.php'; require($INC); } @@ -81,27 +81,27 @@ function CHECK_ADMIN_LOGIN ($admin_login, $password) { if (isset($GLOBALS['cache_array']['admins']['password'][$aid])) { // Get password from cache $data['password'] = $GLOBALS['cache_array']['admins']['password'][$aid]; - $ret = "pass"; + $ret = 'pass'; incrementConfigEntry('cache_hits'); // Include more admins data? - if (GET_EXT_VERSION("admins") >= "0.7.0") { + if (GET_EXT_VERSION('admins') >= '0.7.2') { // Load them here $data['login_failures'] = $GLOBALS['cache_array']['admins']['login_failures'][$aid]; $data['last_failure'] = $GLOBALS['cache_array']['admins']['last_failure'][$aid]; } // END - if - } elseif (!EXT_IS_ACTIVE("cache")) { + } elseif (!EXT_IS_ACTIVE('cache')) { // Add extra data via filter now - $ADD = runFilterChain('sql_admin_extra_data'); + $add = runFilterChain('sql_admin_extra_data'); // Get password from DB - $result = SQL_QUERY_ESC("SELECT password".$ADD." FROM `{!_MYSQL_PREFIX!}_admins` WHERE id=%s LIMIT 1", + $result = SQL_QUERY_ESC("SELECT password".$add." FROM `{!_MYSQL_PREFIX!}_admins` WHERE id=%s LIMIT 1", array($aid), __FUNCTION__, __LINE__); // Entry found? if (SQL_NUMROWS($result) == 1) { // Login password found - $ret = "pass"; + $ret = 'pass'; // Fetch data $data = SQL_FETCHARRAY($result); @@ -117,8 +117,8 @@ function CHECK_ADMIN_LOGIN ($admin_login, $password) { $data['password'] = generateHash($password); // Is the sql_patches not installed, than we cannot have a valid hashed password here! - if (($ret == "pass") && ((EXT_VERSION_IS_OLDER("sql_patches", "0.3.6")) || (GET_EXT_VERSION("sql_patches") == ""))) $ret = "done"; - } elseif ((EXT_VERSION_IS_OLDER("sql_patches", "0.3.6")) || (GET_EXT_VERSION("sql_patches") == "")) { + if (($ret == 'pass') && ((EXT_VERSION_IS_OLDER('sql_patches', '0.3.6')) || (GET_EXT_VERSION('sql_patches') == ""))) $ret = "done"; + } elseif ((EXT_VERSION_IS_OLDER('sql_patches', '0.3.6')) || (GET_EXT_VERSION('sql_patches') == "")) { // Old hashing way return $ret; } elseif (!isset($data['password'])) { @@ -132,13 +132,13 @@ function CHECK_ADMIN_LOGIN ($admin_login, $password) { // Check if password is same //* DEBUG: */ echo "*".$ret.",".$data['password'].",".$password.",".$salt."*
\n"; - if (($ret == "pass") && ($data['password'] == generateHash($password, $salt)) && ((!empty($salt))) || ($data['password'] == $password)) { + if (($ret == 'pass') && ($data['password'] == generateHash($password, $salt)) && ((!empty($salt))) || ($data['password'] == $password)) { // Re-hash the plain passord with new random salt $data['password'] = generateHash($password); // Do we have 0.7.0 of admins or later? // Remmeber login failures if available - if (GET_EXT_VERSION("admins") >= "0.7.2") { + if (GET_EXT_VERSION('admins') >= '0.7.2') { // Store it in session set_session('mxchange_admin_failures', $data['login_failures']); set_session('mxchange_admin_last_fail', $data['last_failure']); @@ -153,7 +153,7 @@ function CHECK_ADMIN_LOGIN ($admin_login, $password) { } // Rebuild cache - rebuildCacheFiles("admins", "admin"); + rebuildCacheFiles('admins', 'admin'); // Login has failed by default... ;-) $ret = "failed"; @@ -163,7 +163,7 @@ function CHECK_ADMIN_LOGIN ($admin_login, $password) { // All done now $ret = "done"; } // END - if - } elseif ((empty($salt)) && ($ret == "pass")) { + } elseif ((empty($salt)) && ($ret == 'pass')) { // Something bad went wrong $ret = "failed"; } elseif ($ret == "done") { @@ -175,13 +175,13 @@ function CHECK_ADMIN_LOGIN ($admin_login, $password) { } // Count login failure if admins extension version is 0.7.0+ - if (($ret == "pass") && (GET_EXT_VERSION("admins") >= "0.7.0")) { + if (($ret == 'pass') && (GET_EXT_VERSION('admins') >= '0.7.0')) { // Update counter SQL_QUERY_ESC("UPDATE `{!_MYSQL_PREFIX!}_admins` SET login_failures=login_failures+1,last_failure=NOW() WHERE id=%s LIMIT 1", array($aid), __FUNCTION__, __LINE__); // Rebuild cache - rebuildCacheFiles("admins", "admin"); + rebuildCacheFiles('admins', 'admin'); } // END - if // Return the result @@ -192,13 +192,13 @@ function CHECK_ADMIN_LOGIN ($admin_login, $password) { // Try to login the admin by setting some session/cookie variables function LOGIN_ADMIN ($adminLogin, $passHash) { // Reset failure counter on matching admins version - if ((GET_EXT_VERSION("admins") >= "0.7.0") && ((EXT_VERSION_IS_OLDER("sql_patches", "0.3.6")) || (GET_EXT_VERSION("sql_patches") == ""))) { + if ((GET_EXT_VERSION('admins') >= '0.7.0') && ((EXT_VERSION_IS_OLDER('sql_patches', '0.3.6')) || (GET_EXT_VERSION('sql_patches') == ""))) { // Reset counter on out-dated sql_patches version SQL_QUERY_ESC("UPDATE `{!_MYSQL_PREFIX!}_admins` SET login_failures=0,last_failure='0000-00-00 00:00:00' WHERE login='%s' LIMIT 1", array($adminLogin), __FUNCTION__, __LINE__); // Rebuild cache - rebuildCacheFiles("admins", "admin"); + rebuildCacheFiles('admins', 'admin'); } // END - if // Now set all session variables and return the result @@ -218,16 +218,16 @@ function LOGIN_ADMIN ($adminLogin, $passHash) { // Only be executed on cookie checking function CHECK_ADMIN_COOKIES ($admin_login, $password) { // By default no admin cookies are found - $ret = "404"; $pass = ""; + $ret = "404"; $pass = ''; // Get hash $pass = GET_ADMIN_HASH(GET_ADMIN_ID($admin_login)); - if ($pass != "-1") $ret = "pass"; + if ($pass != "-1") $ret = 'pass'; //* DEBUG: */ print __FUNCTION__."(".__LINE__."):".generatePassString($pass)."(".strlen($pass).")/".$password."(".strlen($password).")
\n"; // Check if password matches - if (($ret == "pass") && ((generatePassString($pass) == $password) || ($pass == $password) || ((strlen($pass) == 32) && (md5($password) == $pass)))) { + if (($ret == 'pass') && ((generatePassString($pass) == $password) || ($pass == $password) || ((strlen($pass) == 32) && (md5($password) == $pass)))) { // Passwords matches! $ret = "done"; } @@ -258,7 +258,7 @@ function ADMIN_DO_ACTION ($wht) { define('__ADMIN_ID' , GET_CURRENT_ADMIN_ID()); // Preload templates - if (EXT_IS_ACTIVE("admins")) { + if (EXT_IS_ACTIVE('admins')) { define('__ADMIN_WELCOME', LOAD_TEMPLATE("admin_welcome_admins", true)); } else { define('__ADMIN_WELCOME', LOAD_TEMPLATE("admin_welcome", true)); @@ -271,12 +271,12 @@ function ADMIN_DO_ACTION ($wht) { // Check if action/what pair is valid $result_action = SQL_QUERY_ESC("SELECT id FROM `{!_MYSQL_PREFIX!}_admin_menu` -WHERE `action`='%s' AND ((what='%s' AND what != 'overview') OR ((what='' OR `what` IS NULL) AND '%s'='overview')) +WHERE `action`='%s' AND ((`what`='%s' AND what != 'overview') OR ((`what`='' OR `what` IS NULL) AND '%s'='overview')) LIMIT 1", array($act, $wht, $wht), __FUNCTION__, __LINE__); if (SQL_NUMROWS($result_action) == 1) { // Is valid but does the inlcude file exists? $INC = sprintf("inc/modules/admin/action-%s.php", $act); - if ((INCLUDE_READABLE($INC)) && (VALIDATE_MENU_ACTION("admin", $act, $wht)) && ($GLOBALS['acl_allow'] === true)) { + if ((INCLUDE_READABLE($INC)) && (VALIDATE_MENU_ACTION('admin', $act, $wht)) && ($GLOBALS['acl_allow'] === true)) { // Ok, we finally load the admin action module LOAD_INC($INC); } elseif ($GLOBALS['acl_allow'] === false) { @@ -305,14 +305,14 @@ LIMIT 1", array($act, $wht, $wht), __FUNCTION__, __LINE__); function ADD_ADMIN_MENU ($act, $wht, $return=false) { // Init variables $SUB = false; - $OUT = ""; + $OUT = ''; // Menu descriptions $GLOBALS['menu']['description'] = array(); $GLOBALS['menu']['title'] = array(); // Is there a cache instance? - if ((isCacheInstanceValid()) && (getConfig('cache_admin_menu') == "Y")) { + if ((isCacheInstanceValid()) && (getConfig('cache_admin_menu') == 'Y')) { // Create cache name $cacheName = "admin_".$act."_".$wht."_".GET_LANGUAGE()."_".strtolower(get_session('admin_login')); @@ -336,14 +336,14 @@ function ADD_ADMIN_MENU ($act, $wht, $return=false) { } // END - if // Build main menu - $result_main = SQL_QUERY("SELECT action, title, descr FROM `{!_MYSQL_PREFIX!}_admin_menu` WHERE (what='' OR `what` IS NULL) ORDER BY `sort`, id DESC", __FUNCTION__, __LINE__); + $result_main = SQL_QUERY("SELECT action, title, descr FROM `{!_MYSQL_PREFIX!}_admin_menu` WHERE (`what`='' OR `what` IS NULL) ORDER BY `sort`, id DESC", __FUNCTION__, __LINE__); if (SQL_NUMROWS($result_main) > 0) { $OUT = "\n"; // @TODO Rewrite this to $content = SQL_FETCHARRAY() while (list($menu, $title, $descr) = SQL_FETCHROW($result_main)) { - if ((EXT_IS_ACTIVE("admins")) && (GET_EXT_VERSION("admins") > "0.2")) { - $ACL = ADMINS_CHECK_ACL($menu, ""); + if ((EXT_IS_ACTIVE('admins')) && (GET_EXT_VERSION('admins') > '0.2.0')) { + $ACL = ADMINS_CHECK_ACL($menu, ''); } else { // ACL is "allow"... hmmm $ACL = true; @@ -357,7 +357,8 @@ function ADD_ADMIN_MENU ($act, $wht, $return=false) { } $OUT .= " + + $OUT .= "\n"; + + // Check for menu entries $result_what = SQL_QUERY_ESC("SELECT what, title, descr FROM `{!_MYSQL_PREFIX!}_admin_menu` WHERE `action`='%s' AND `what` != '' AND `what` IS NOT NULL ORDER BY `sort`, id DESC", array($menu), __FUNCTION__, __LINE__); - if ((SQL_NUMROWS($result_what) > 0) && ($act == $menu)) - { + + // Remember the count for later checks + setAdminMenuHasEntries($menu, ((SQL_NUMROWS($result_what) > 0) && ($act == $menu))); + + // Do we have entries? + if ((ifAdminMenuHasEntries($menu)) && (SQL_NUMROWS($result_what) > 0)) { $GLOBALS['menu']['description'] = array(); $GLOBALS['menu']['title'] = array(); $SUB = true; $OUT .= " @@ -387,7 +395,7 @@ function ADD_ADMIN_MENU ($act, $wht, $return=false) { while (list($wht_sub, $title_what, $desc_what) = SQL_FETCHROW($result_what)) { // Filename $INC = sprintf("inc/modules/admin/what-%s.php", $wht_sub); - if ((EXT_IS_ACTIVE("admins")) && (GET_EXT_VERSION("admins") > "0.2")) { + if ((EXT_IS_ACTIVE('admins')) && (GET_EXT_VERSION('admins') > '0.2.0')) { $ACL = ADMINS_CHECK_ACL("", $wht_sub); } else { // ACL is "allow"... hmmm @@ -404,7 +412,7 @@ function ADD_ADMIN_MENU ($act, $wht, $return=false) { $GLOBALS['menu']['description'][$wht_sub] = $desc_what; $OUT .= " + $OUT .= "\n"; } } @@ -437,6 +445,7 @@ function ADD_ADMIN_MENU ($act, $wht, $return=false) { \n"; } + $OUT .= "\n"; } } @@ -447,7 +456,7 @@ function ADD_ADMIN_MENU ($act, $wht, $return=false) { } // Is there a cache instance again? - if ((isCacheInstanceValid()) && (getConfig('cache_admin_menu') == "Y")) { + if ((isCacheInstanceValid()) && (getConfig('cache_admin_menu') == 'Y')) { // Init cache $GLOBALS['cache_instance']->init($cacheName); @@ -474,12 +483,12 @@ function ADD_ADMIN_MENU ($act, $wht, $return=false) { } // Create member selection box -function ADD_MEMBER_SELECTION_BOX ($def="0", $add_all=false, $return=false, $none=false, $field="userid") { +function ADD_MEMBER_SELECTION_BOX ($def="0", $add_all=false, $return=false, $none=false, $field='userid') { // Output selection form with all confirmed user accounts listed $result = SQL_QUERY("SELECT userid, surname, family FROM `{!_MYSQL_PREFIX!}_user_data` ORDER BY userid", __FUNCTION__, __LINE__); // Default output - $OUT = ""; + $OUT = ''; // USe this only for adding points (e.g. adding refs really makes no sence ;-) ) if ($add_all === true) $OUT = " \n"; @@ -487,7 +496,7 @@ function ADD_MEMBER_SELECTION_BOX ($def="0", $add_all=false, $return=false, $non while ($content = SQL_FETCHARRAY($result)) { $OUT .= " \n"; // Walk through all files - while ($file = readdir($handle)) { + foreach ($menuArray as $file) { // Is this a PHP script? if (($file != ".") && ($file != "..") && ($file != "lost+found") && (strpos($file, "".$type."-") > -1) && (strpos($file, ".php") > 0)) { // Then test if the file is readable @@ -669,21 +678,21 @@ function ADMIN_MAKE_MENU_SELECTION ($menu, $type, $name, $default="") { // Is that part different from the overview? if ($part != "overview") { $OUT .= "
 
-  · "; +
 · "; + if (($menu == $act) && (empty($wht))) { $OUT .= ""; } else { @@ -371,12 +372,19 @@ function ADD_ADMIN_MENU ($act, $wht, $return=false) { } else { $OUT .= "]"; } - $OUT .= "
-  --> "; +
 --> "; if ($readable === true) { if ($wht == $wht_sub) { $OUT .= ""; @@ -426,7 +434,7 @@ function ADD_ADMIN_MENU ($act, $wht, $return=false) { } else { $OUT .= ""; } - $OUT .= "