X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=inc%2Fmodules%2Fadmin%2Fwhat-admins_mails.php;h=0f4057362294f4c21ba97e3fec6c83a4ebad94bc;hb=e523b69ecd6c7f37ae1cb36872537073b40c0e27;hp=8afbb9aef92509d1ba40428cfd38ca77187bcfd8;hpb=18e32f1a8971b18bace4f051094acf27800bd7d9;p=mailer.git

diff --git a/inc/modules/admin/what-admins_mails.php b/inc/modules/admin/what-admins_mails.php
index 8afbb9aef9..0f40573622 100644
--- a/inc/modules/admin/what-admins_mails.php
+++ b/inc/modules/admin/what-admins_mails.php
@@ -14,8 +14,6 @@
  * $Date::                                                            $ *
  * $Tag:: 0.2.1-FINAL                                                 $ *
  * $Author::                                                          $ *
- * Needs to be in all Files and every File needs "svn propset           *
- * svn:keywords Date Revision" (autoprobset!) at least!!!!!!            *
  * -------------------------------------------------------------------- *
  * Copyright (c) 2003 - 2009 by Roland Haeder                           *
  * Copyright (c) 2009, 2010 by Mailer Developer Team                    *
@@ -47,10 +45,10 @@ addMenuDescription('admin', __FILE__);
 
 if (isFormSent('edit')) {
 	// Check if entires are checked
-	if (countPostSelection() > 0) {
+	if (ifPostContainsSelections()) {
 		// Add option for events
 		$adminsList = generateOptionList('admins', 'id', 'login', '', 'email');
-		$SW = 2; $rows = '';
+		$rows = '';
 		foreach (postRequestParameter('sel') as $template => $sel) {
 			// First of all load data from DB
 			$result = SQL_QUERY_ESC("SELECT `admin_id`, `id` FROM `{?_MYSQL_PREFIX?}_admins_mails` WHERE `mail_template`='%s' ORDER BY `id` ASC",
@@ -58,18 +56,18 @@ if (isFormSent('edit')) {
 			$OUT = '';
 			$adminId2 = '0'; $id = '0';
 			while ($content = SQL_FETCHARRAY($result)) {
-				// @TODO Can this be rewritten???
-				$OUT .= "<select name=\"admin_id[".$content['id']."]\" size=\"1\" class=\"admin_select\">
-<option value=\"0\"";
+				// @TODO Can this be rewritten to an API function?
+				$OUT .= '<select name="admin_id[' . $content['id'] . ']" size="1" class="form_select">
+<option value="0"';
 				if ($content['admin_id'] == '0') $OUT .= ' selected="selected"';
-				$OUT .=">{--ADMINS_ALL_ADMINS--}</option>\n";
+				$OUT .= '>{--ADMINS_ALL_ADMINS--}</option>';
 				if (isExtensionActive('events')) {
-					$OUT .= "<option value=\"-1\"";
+					$OUT .= '<option value="-1"';
 					if ($content['admin_id'] == '-1') $OUT .= ' selected="selected"';
-					$OUT .= ">{--ADMINS_TO_USER_EVENTS--}</option>\n";
+					$OUT .= '>{--ADMINS_TO_USER_EVENTS--}</option>';
 				}
 				$OUT .= generateOptionList('admins', 'id', 'login', $content['admin_id'], 'email');
-				$OUT .= "</select>\n<br />\n";
+				$OUT .= '</select>';
 
 				// Transfer ids
 				$adminId2 = $content['admin_id'];
@@ -81,7 +79,6 @@ if (isFormSent('edit')) {
 
 			// Prepare content
 			$content['id']            = $id;
-			$content['sw']            = $SW;
 			$content['mail_template'] = $template;
 			$content['admins']        = $adminsList;
 
@@ -95,14 +92,13 @@ if (isFormSent('edit')) {
 
 			// Start outputing line
 			$rows .= loadTemplate('admin_admins_mails_edit_row', true, $content);
-			$SW = 3 - $SW;
-		}
+		} // END - foreach
 
 		// Edit checked entries
 		loadTemplate('admin_admins_mails_edit', false, $rows);
 	} else {
 		// Nothing selected
-		loadTemplate('admin_settings_saved', false, getMessage('ADMINS_NO_MAIL_CHECKED'));
+		loadTemplate('admin_settings_saved', false, '{--ADMINS_NO_MAIL_CHECKED--}');
 	}
 } else {
 	// Load all assigned mails
@@ -120,7 +116,7 @@ ORDER BY
 	m.admin_id ASC,
 	m.mail_template ASC", __FILE__, __LINE__);
 
-	if (SQL_NUMROWS($result) > 0) {
+	if (!SQL_HASZERONUMS($result)) {
 		// Shall I change entries?
 		if (isFormSent('change')) {
 			// Init SQLs
@@ -169,15 +165,10 @@ ORDER BY
 		} // END - if
 
 		// List found entries
-		$OUT = ''; $SW = 2;
+		$OUT = '';
 		while ($content = SQL_FETCHARRAY($result)) {
-			// Prepare content
-			$content['sw']   = $SW;
-			$content['alnk'] = generateAdminLink($content['admin_id']);
-
 			// Load row template
 			$OUT .= loadTemplate('admin_admins_mails_list_row', true, $content);
-			$SW = 3 - $SW;
 		} // END - while
 
 		// Free result
@@ -187,7 +178,7 @@ ORDER BY
 		loadTemplate('admin_admins_mails_list', false, $OUT);
 	} else {
 		// No entries found
-		loadTemplate('admin_settings_saved', false, getMessage('ADMINS_MAILS_NO_ENTRIES'));
+		loadTemplate('admin_settings_saved', false, '{--ADMINS_MAILS_NO_ENTRIES--}');
 	}
 }