X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=inc%2Fmodules%2Fadmin%2Fwhat-admins_mails.php;h=3d7e951eff67f322159bee5e7b81e51c58785613;hb=3c2f106c02f6d86a90f529a0564abcbbe716fe71;hp=724d2ae12b82eeb4dc9c42b7fc9ba33500b8af59;hpb=8a9324b2d931f54f54f4319fd7234910af77012c;p=mailer.git

diff --git a/inc/modules/admin/what-admins_mails.php b/inc/modules/admin/what-admins_mails.php
index 724d2ae12b..3d7e951eff 100644
--- a/inc/modules/admin/what-admins_mails.php
+++ b/inc/modules/admin/what-admins_mails.php
@@ -32,11 +32,11 @@
  ************************************************************************/
 
 // Some security stuff...
-if ((ereg(basename(__FILE__), $_SERVER['PHP_SELF'])) || (!IS_ADMIN()))
-{
+if ((!defined('__SECURITY')) || (!IS_ADMIN())) {
 	$INC = substr(dirname(__FILE__), 0, strpos(dirname(__FILE__), "/inc") + 4) . "/security.php";
 	require($INC);
 }
+
 // Add description as navigation point
 ADD_DESCR("admin", basename(__FILE__));
 
@@ -47,14 +47,14 @@ if (isset($_POST['edit']))
 	if ($SEL > 0)
 	{
 		// Add option for userlog
-		$ADMINS = ADD_OPTION_LINES("admins", "id", "login", "", "email");
-		$SW = 2; $ROWS = "";
-		foreach ($_POST['sel'] as $template=>$sel)
+		$cacheArray['admins'] = ADD_OPTION_LINES("admins", "id", "login", "", "email");
+		$SW = 2; $rowNameS = "";
+		foreach ($_POST['sel'] as $template => $sel)
 		{
 			// First of all load data from DB
 			$result = SQL_QUERY_ESC("SELECT admin_id, id FROM "._MYSQL_PREFIX."_admins_mails WHERE mail_template='%s' ORDER BY id",
 			 array($template), __FILE__, __LINE__);
-			$OUT = ""; $aid = "0"; $aid2 = "0";
+			$OUT = ""; $aid = 0; $aid2 = 0;
 			while (list($aid, $id) = SQL_FETCHROW($result))
 			{
 				$OUT .= "<SELECT name=\"admin_id[".$id."]\" size=\"1\" class=\"admin_select\">
@@ -80,7 +80,7 @@ if (isset($_POST['edit']))
 				'id'      => $id,
 				'id2'     => $id2,
 				'tpl'     => $template,
-				'admins'  => $ADMINS
+				'admins'  => $cacheArray['admins']
 			);
 
 			if ($aid2 > 0)
@@ -92,10 +92,10 @@ if (isset($_POST['edit']))
 			$content['content'] = $OUT;
 
 			// Start outputing line
-			$ROWS .= LOAD_TEMPLATE("admin_admins_mails_edit_row", true, $content);
+			$rowNameS .= LOAD_TEMPLATE("admin_admins_mails_edit_row", true, $content);
 			$SW = 3 - $SW;
 		}
-		define('__ADMINS_ROWS', $ROWS);
+		define('__ADMINS_ROWS', $rowNameS);
 
 		// Edit checked entries
 		LOAD_TEMPLATE("admin_admins_mails_edit");
@@ -122,14 +122,14 @@ ORDER BY m.admin_id, m.mail_template", __FILE__, __LINE__);
 		if (isset($_POST['change']))
 		{
 			// Ok, update database
-			foreach ($_POST['admin_id'] as $id=>$aid)
+			foreach ($_POST['admin_id'] as $id => $aid)
 			{
 				// Secure IDs
 				$id  = bigintval($id);
 				$aid = bigintval($aid);
 
 				// Update entry
-				$result = SQL_QUERY_ESC("UPDATE "._MYSQL_PREFIX."_admins_mails SET admin_id=%d WHERE id=%d ORDER BY id LIMIT 1",
+				$result = SQL_QUERY_ESC("UPDATE "._MYSQL_PREFIX."_admins_mails SET admin_id=%s WHERE id=%s ORDER BY id LIMIT 1",
 				 array($aid, $id), __FILE__, __LINE__);
 
 				if (($aid < 1) && (!empty($_POST['template'][$id])))
@@ -141,7 +141,7 @@ ORDER BY m.admin_id, m.mail_template", __FILE__, __LINE__);
 				if ($_POST['admin_new'][$_POST['template'][$id]] > 0)
 				{
 					// Add new admin
-					$result = SQL_QUERY_ESC("INSERT INTO "._MYSQL_PREFIX."_admins_mails (admin_id, mail_template) VALUES ('%s', '%s')",
+					$result = SQL_QUERY_ESC("INSERT INTO "._MYSQL_PREFIX."_admins_mails (admin_id, mail_template) VALUES ('%s','%s')",
 					 array($aid, $_POST['template'][$id]), __FILE__, __LINE__);
 				}
 			}