X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=inc%2Fmodules%2Fadmin%2Fwhat-admins_mails.php;h=877022ce49175e09df835399c6e0dd65cf5325fe;hb=2379934be6a196a54f4155bb8e24c49b20736969;hp=16e4a6a3950e0777b4432b4825de5d5399a3f9d7;hpb=7fabfadce30a7bea7ce3ad1f1e2e7e5e616f2669;p=mailer.git

diff --git a/inc/modules/admin/what-admins_mails.php b/inc/modules/admin/what-admins_mails.php
index 16e4a6a395..877022ce49 100644
--- a/inc/modules/admin/what-admins_mails.php
+++ b/inc/modules/admin/what-admins_mails.php
@@ -1,7 +1,7 @@
 <?php
 /************************************************************************
- * MXChange v0.2.1                                    Start: 08/14/2004 *
- * ================                             Last change: 10/22/2004 *
+ * Mailer v0.2.1-FINAL                                Start: 08/14/2004 *
+ * ===================                          Last change: 10/22/2004 *
  *                                                                      *
  * -------------------------------------------------------------------- *
  * File              : what-admins_mails.php                            *
@@ -14,10 +14,9 @@
  * $Date::                                                            $ *
  * $Tag:: 0.2.1-FINAL                                                 $ *
  * $Author::                                                          $ *
- * Needs to be in all Files and every File needs "svn propset           *
- * svn:keywords Date Revision" (autoprobset!) at least!!!!!!            *
  * -------------------------------------------------------------------- *
  * Copyright (c) 2003 - 2009 by Roland Haeder                           *
+ * Copyright (c) 2009 - 2011 by Mailer Developer Team                   *
  * For more information visit: http://www.mxchange.org                  *
  *                                                                      *
  * This program is free software; you can redistribute it and/or modify *
@@ -39,50 +38,49 @@
 // Some security stuff...
 if ((!defined('__SECURITY')) || (!isAdmin())) {
 	die();
-}
+} // END - if
 
 // Add description as navigation point
-addMenuDescription('admin', __FILE__);
+addYouAreHereLink('admin', __FILE__);
 
-if (isPostRequestElementSet('edit')) {
+if (isFormSent('edit')) {
 	// Check if entires are checked
-	$SEL = countPostSelection();
-	if ($SEL > 0) {
+	if (ifPostContainsSelections()) {
 		// Add option for events
 		$adminsList = generateOptionList('admins', 'id', 'login', '', 'email');
-		$SW = 2; $rowNameS = '';
+		$rows = '';
 		foreach (postRequestElement('sel') as $template => $sel) {
 			// First of all load data from DB
-			$result = SQL_QUERY_ESC("SELECT `admin_id`, `id` FROM `{?_MYSQL_PREFIX?}_admins_mails` WHERE `mail_template`='%s' ORDER BY `id` ASC",
+			$result = SQL_QUERY_ESC("SELECT `admin_id`,`id` FROM `{?_MYSQL_PREFIX?}_admins_mails` WHERE `mail_template`='%s' ORDER BY `id` ASC",
 				array($template), __FILE__, __LINE__);
-			$OUT = ''; $adminId2 = 0;
+			$OUT = '';
+			$adminId2 = '0'; $id = '0';
 			while ($content = SQL_FETCHARRAY($result)) {
-				// @TODO Can this be rewritten???
-				$OUT .= "<select name=\"admin_id[".$content['id']."]\" size=\"1\" class=\"admin_select\">
-<option value=\"0\"";
+				// @TODO Can this be rewritten to an API function?
+				$OUT .= '<select name="admin_id[' . $content['id'] . ']" size="1" class="form_select">
+<option value="0"';
 				if ($content['admin_id'] == '0') $OUT .= ' selected="selected"';
-				$OUT .=">{--ADMINS_ALL_ADMINS--}</option>\n";
+				$OUT .= '>{--ADMIN_TO_ALL_ADMINS--}</option>';
 				if (isExtensionActive('events')) {
-					$OUT .= "<option value=\"-1\"";
+					$OUT .= '<option value="-1"';
 					if ($content['admin_id'] == '-1') $OUT .= ' selected="selected"';
-					$OUT .= ">{--ADMINS_TO_USER_EVENTS--}</option>\n";
+					$OUT .= '>{--ADMIN_ADMINS_TO_USER_EVENTS--}</option>';
 				}
 				$OUT .= generateOptionList('admins', 'id', 'login', $content['admin_id'], 'email');
-				$OUT .= "</select>\n<br />\n";
-				$adminId2 = $content['admin_id']; $id2 = $content['id'];
-			}
+				$OUT .= '</select>';
+
+				// Transfer ids
+				$adminId2 = $content['admin_id'];
+				$id = $content['id'];
+			} // END - while
 
 			// Free memory
 			SQL_FREERESULT($result);
 
 			// Prepare content
-			$content = array(
-				'sw'      => $SW,
-				'id'      => $id,
-				'id2'     => $id2,
-				'tpl'     => $template,
-				'admins'  => $adminsList
-			);
+			$content['id']            = $id;
+			$content['mail_template'] = $template;
+			$content['admins']        = $adminsList;
 
 			if ($adminId2 > 0) {
 				// Add form for an additional admin
@@ -93,15 +91,14 @@ if (isPostRequestElementSet('edit')) {
 			$content['content'] = $OUT;
 
 			// Start outputing line
-			$rowNameS .= loadTemplate('admin_admins_mails_edit_row', true, $content);
-			$SW = 3 - $SW;
-		}
+			$rows .= loadTemplate('admin_admins_mails_edit_row', true, $content);
+		} // END - foreach
 
 		// Edit checked entries
-		loadTemplate('admin_admins_mails_edit', false, $rowNameS);
+		loadTemplate('admin_admins_mails_edit', false, $rows);
 	} else {
 		// Nothing selected
-		loadTemplate('admin_settings_saved', false, getMessage('ADMINS_NO_MAIL_CHECKED'));
+		displayMessage('{--ADMINS_NO_MAIL_CHECKED--}');
 	}
 } else {
 	// Load all assigned mails
@@ -119,21 +116,21 @@ ORDER BY
 	m.admin_id ASC,
 	m.mail_template ASC", __FILE__, __LINE__);
 
-	if (SQL_NUMROWS($result) > 0) {
+	if (!SQL_HASZERONUMS($result)) {
 		// Shall I change entries?
-		if (isPostRequestElementSet('change')) {
+		if (isFormSent('do_edit')) {
 			// Init SQLs
 			initSqls();
 
 			// Ok, update database
 			foreach (postRequestElement('admin_id') as $id => $content['admin_id']) {
-				// Secure IDs
+				// Secure ids
 				$id  = bigintval($id);
 				$content['admin_id'] = bigintval($content['admin_id']);
 
 				// Update entry
-				addSql(SQL_QUERY_ESC("UPDATE `{?_MYSQL_PREFIX?}_admins_mails` SET admin_id=%s WHERE `id`=%s ORDER BY `id` LIMIT 1",
-				array($content['admin_id'], $id), __FILE__, __LINE__, false));
+				addSql(SQL_QUERY_ESC("UPDATE `{?_MYSQL_PREFIX?}_admins_mails` SET `admin_id`=%s WHERE `id`=%s ORDER BY `id` LIMIT 1",
+					array($content['admin_id'], $id), __FILE__, __LINE__, false));
 
 				if (($content['admin_id'] < 1) && (isPostRequestElementSet('template', $id))) {
 					// Remove any other admin entries
@@ -152,23 +149,26 @@ ORDER BY
 			runFilterChain('run_sqls');
 
 			// Query again...
-			$result = SQL_QUERY("SELECT m.id, m.admin_id, a.login, m.mail_template FROM `{?_MYSQL_PREFIX?}_admins_mails` AS m, `{?_MYSQL_PREFIX?}_admins` AS a WHERE m.admin_id=a.id OR m.admin_id < 1 ORDER BY m.admin_id", __FILE__, __LINE__);
+			$result = SQL_QUERY("SELECT
+	m.id, m.admin_id, a.login, m.mail_template
+FROM
+	`{?_MYSQL_PREFIX?}_admins_mails` AS m
+LEFT JOIN
+	`{?_MYSQL_PREFIX?}_admins` AS a
+ON
+	m.admin_id=a.id
+WHERE
+	(m.admin_id=a.id OR m.admin_id < 1) AND m.mail_template != ''
+ORDER BY
+	m.admin_id ASC,
+	m.mail_template ASC", __FILE__, __LINE__);
 		} // END - if
 
 		// List found entries
-		$OUT = ''; $SW = 2;
-		while ($data = SQL_FETCHARRAY($result)) {
-			// Prepare content
-			$content = array(
-				'sw'   => $SW,
-				'id'   => $data['id'],
-				'tpl'  => $data['mail_template'],
-				'alnk' => generateAdminLink($data['admin_id'])
-			);
-
+		$OUT = '';
+		while ($content = SQL_FETCHARRAY($result)) {
 			// Load row template
 			$OUT .= loadTemplate('admin_admins_mails_list_row', true, $content);
-			$SW = 3 - $SW;
 		} // END - while
 
 		// Free result
@@ -178,7 +178,7 @@ ORDER BY
 		loadTemplate('admin_admins_mails_list', false, $OUT);
 	} else {
 		// No entries found
-		loadTemplate('admin_settings_saved', false, getMessage('ADMINS_MAILS_NO_ENTRIES'));
+		displayMessage('{--ADMIN_ADMINS_MAILS_NO_ENTRIES--}');
 	}
 }