X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=inc%2Fmodules%2Fadmin%2Fwhat-extensions.php;h=dfa59dcfafb71b78b24b8d7d48a3e447f4cfaf00;hb=2f0357c7ac9da6c17d361b8e7cb0b1ad09eb85f6;hp=e4194771727d0affe0d2d2f6af21b849bd96e4c4;hpb=e01fcf1ca8ddeb72af76465df3ef72301a1cdae7;p=mailer.git

diff --git a/inc/modules/admin/what-extensions.php b/inc/modules/admin/what-extensions.php
index e419477172..dfa59dcfaf 100644
--- a/inc/modules/admin/what-extensions.php
+++ b/inc/modules/admin/what-extensions.php
@@ -10,10 +10,10 @@
  * -------------------------------------------------------------------- *
  * Kurzbeschreibung  : Erweiterungen-Management                         *
  * -------------------------------------------------------------------- *
- * $Revision:: 856                                                    $ *
- * $Date:: 2009-03-06 20:24:32 +0100 (Fr, 06. March 2009)             $ *
+ * $Revision::                                                        $ *
+ * $Date::                                                            $ *
  * $Tag:: 0.2.1-FINAL                                                 $ *
- * $Author:: stelzi                                                   $ *
+ * $Author::                                                          $ *
  * Needs to be in all Files and every File needs "svn propset           *
  * svn:keywords Date Revision" (autoprobset!) at least!!!!!!            *
  * -------------------------------------------------------------------- *
@@ -38,12 +38,12 @@
 
 // Some security stuff...
 if ((!defined('__SECURITY')) || (!IS_ADMIN())) {
-	$INC = substr(dirname(__FILE__), 0, strpos(dirname(__FILE__), "/inc") + 4) . "/security.php";
+	$INC = substr(dirname(__FILE__), 0, strpos(dirname(__FILE__), '/inc') + 4) . '/security.php';
 	require($INC);
 }
 
 // Add description as navigation point
-ADD_DESCR("admin", __FILE__);
+ADD_DESCR('admin', __FILE__);
 
 // Normally we want the overview of all registered extensions
 $do = "overview";
@@ -52,18 +52,18 @@ if (REQUEST_ISSET_POST('sel')) $SEL = SELECTION_COUNT(REQUEST_POST('sel'));
 
 if (REQUEST_ISSET_GET(('reg_ext'))) {
 	// We are about to register a new extension
-	$do = "register"; $ext_id = bigintval(REQUEST_GET('reg_ext'));
+	$do = 'register'; $ext_id = bigintval(REQUEST_GET('reg_ext'));
 	// The ID comes from task management and it is - of course - *not* the extension's name!
-} elseif ((REQUEST_ISSET_POST(('change'))) && ($SEL > 0) && (!IS_DEMO())) {
+} elseif ((REQUEST_ISSET_POST('change')) && ($SEL > 0) && (!IS_DEMO())) {
 	// De-/activate extensions
 	foreach (REQUEST_POST('sel') as $ext_id => $active) {
 		// Shall we keep the extension always active?
-		if ((isset($GLOBALS['cache_array']['active_extensions'][GET_EXT_NAME($ext_id)])) && ($GLOBALS['cache_array']['active_extensions'][GET_EXT_NAME($ext_id)] == "Y") && ($active == "N")) {
+		if ((isset($GLOBALS['cache_array']['active_extensions'][GET_EXT_NAME($ext_id)])) && ($GLOBALS['cache_array']['active_extensions'][GET_EXT_NAME($ext_id)] == 'Y') && ($active == 'N')) {
 			// Keep this extension active!
 		} else {
 			// De/activate extension
-			$ACT = "N"; $EXT_LOAD_MODE = "deactivate";
-			if ($active == "N") { $ACT = "Y"; $EXT_LOAD_MODE = "activate"; }
+			$ACT = "N"; $EXT_LOAD_MODE = 'deactivate';
+			if ($active == 'N') { $ACT = "Y"; $EXT_LOAD_MODE = 'activate'; }
 			SQL_QUERY_ESC("UPDATE `{!_MYSQL_PREFIX!}_extensions` SET ext_active='".$ACT."' WHERE id=%s AND ext_active='%s' LIMIT 1",
 				array(bigintval($ext_id), $active), __FILE__, __LINE__);
 
@@ -83,13 +83,13 @@ if (REQUEST_ISSET_GET(('reg_ext'))) {
 			// Change this extension?
 			if ($sel == 1) {
 				// Load mode is modify
-				$EXT_LOAD_MODE = "modify";
+				$EXT_LOAD_MODE = 'modify';
 
 				// Get entry for 'active'
 				$active = REQUEST_POST('active', $ext_id);
 
 				// Update extension's record
-				if (GET_EXT_VERSION("sql_patches") >= "0.0.6") {
+				if (GET_EXT_VERSION('sql_patches') >= '0.0.6') {
 					// Update also CSS column when extensions sql_patches is newer or exact v0.0.6
 					SQL_QUERY_ESC("UPDATE `{!_MYSQL_PREFIX!}_extensions` SET ext_has_css='%s', ext_active='%s' WHERE id=%s LIMIT 1",
 						array(REQUEST_POST('css', $ext_id), $active, $ext_id), __FILE__, __LINE__);
@@ -101,8 +101,8 @@ if (REQUEST_ISSET_GET(('reg_ext'))) {
 
 				// Run SQLs on activation / deactivation
 				switch ($active) {
-					case "Y": $EXT_LOAD_MODE = "activate";   break;
-					case "N": $EXT_LOAD_MODE = "deactivate"; break;
+					case 'Y': $EXT_LOAD_MODE = 'activate';   break;
+					case 'N': $EXT_LOAD_MODE = 'deactivate'; break;
 				}
 
 				// Run embeded SQL commands
@@ -111,15 +111,15 @@ if (REQUEST_ISSET_GET(('reg_ext'))) {
 		}
 
 		// Extensions changed
-		LOAD_TEMPLATE("admin_settings_saved", false, getMessage('ADMIN_EXT_CHANGED'));
+		LOAD_TEMPLATE('admin_settings_saved', false, getMessage('ADMIN_EXT_CHANGED'));
 	} else {
 		// Edit selected entries
-		$SW = "2"; $OUT = "";
+		$SW = "2"; $OUT = '';
 		foreach (REQUEST_POST('sel') as $ext_id => $sel) {
 			// Edit this extension?
-			if (($sel == "Y") || ($sel == "N")) {
+			if (($sel == 'Y') || ($sel == 'N')) {
 				// Load required data
-				if (GET_EXT_VERSION("sql_patches") >= "0.0.6") {
+				if (GET_EXT_VERSION('sql_patches') >= '0.0.6') {
 					$result = SQL_QUERY_ESC("SELECT ext_name, ext_has_css, ext_active FROM `{!_MYSQL_PREFIX!}_extensions` WHERE id=%s LIMIT 1",
 					 array(bigintval($ext_id)), __FILE__, __LINE__);
 					list($name, $css, $active) = SQL_FETCHROW($result);
@@ -133,15 +133,15 @@ if (REQUEST_ISSET_GET(('reg_ext'))) {
 				}
 
 				// Output row
-				$cssSelection = "---";
-				if (GET_EXT_VERSION("sql_patches") >= "0.0.6") $cssSelection = ADD_SELECTION("yn", $css, "css", $ext_id);
+				$cssSelection = '---';
+				if (GET_EXT_VERSION('sql_patches') >= '0.0.6') $cssSelection = ADD_SELECTION('yn', $css, "css", $ext_id);
 
 				// Prepare data for the row template
 				$content = array(
 					'sw'     => $SW,
 					'id'     => $ext_id,
 					'name'   => $name,
-					'active' => ADD_SELECTION("yn", $active, "active", $ext_id),
+					'active' => ADD_SELECTION('yn', $active, 'active', $ext_id),
 					'css'    => $cssSelection,
 				);
 
@@ -150,18 +150,21 @@ if (REQUEST_ISSET_GET(('reg_ext'))) {
 				$SW = 3 - $SW;
 			}
 		} // END - foreach
+
+		// @TODO Rewrite this constant
 		define('__EXTENSIONS_ROWS', $OUT);
 
 		// Load template
 		LOAD_TEMPLATE("admin_extensions_edit");
 		$do = "edit";
 	}
-} elseif ((REQUEST_ISSET_POST(('delete'))) && ($SEL > 0) && (!IS_DEMO())) {
+} elseif ((REQUEST_ISSET_POST('delete')) && ($SEL > 0) && (!IS_DEMO())) {
 	// List extensions and when verbose is enabled SQL statements which will be executed
-	$OUT = ""; $SW = 2;
+	$OUT = ''; $SW = 2;
 	foreach (REQUEST_POST('sel') as $ext_id => $sel) {
 		// Init variables
-		$VERBOSE_OUT = ""; INIT_SQLS();
+		$VERBOSE_OUT = '';
+		INIT_SQLS();
 
 		// Secure id number
 		$ext_id = bigintval($ext_id);
@@ -169,9 +172,9 @@ if (REQUEST_ISSET_GET(('reg_ext'))) {
 		// Get extension name
 		$ext_name = GET_EXT_NAME($ext_id);
 
-		if (getConfig('verbose_sql') == "Y") {
+		if (getConfig('verbose_sql') == 'Y') {
 			// Load SQL commands in remove mode
-			if (LOAD_EXTENSION($ext_name, "remove", "", true)) {
+			if (LOAD_EXTENSION($ext_name, 'remove', '', true)) {
 				// Generate extra table with loaded SQL commands
 				$VERBOSE_OUT = EXTENSION_VERBOSE_TABLE();
 			} // END - if
@@ -195,7 +198,7 @@ if (REQUEST_ISSET_GET(('reg_ext'))) {
 	// Load template
 	LOAD_TEMPLATE("admin_extensions_delete");
 	$do = "delete";
-} elseif ((REQUEST_ISSET_POST(('remove'))) && ($SEL > 0) && (!IS_DEMO())) {
+} elseif ((REQUEST_ISSET_POST('remove')) && ($SEL > 0) && (!IS_DEMO())) {
 	// Remove extensions from DB (you have to delete all files manually!)
 	$cache_update = 0;
 	foreach (REQUEST_POST('sel') as $ext_id => $active) {
@@ -208,19 +211,19 @@ if (REQUEST_ISSET_GET(('reg_ext'))) {
 			runFilterChain('extension_remove', GET_EXT_NAME($ext_id));
 
 			// Run embeded SQL commands
-			EXTENSION_RUN_SQLS($ext_id, "remove");
+			EXTENSION_RUN_SQLS($ext_id, 'remove');
 		} // END - if
 	} // END - foreach
-} elseif (REQUEST_ISSET_GET(('do')) && (!IS_DEMO())) {
+} elseif ((REQUEST_ISSET_GET('do')) && (!IS_DEMO())) {
 	// Other things to do
 	$do = SQL_ESCAPE(strip_tags(REQUEST_GET('do')));
-} elseif (REQUEST_ISSET_GET(('do'))) {
+} elseif (REQUEST_ISSET_GET('do')) {
 	// Demo mode active!
-	$do = "demo";
+	$do = 'demo';
 }
 
 // Shall we display active/inactive extensions?
-$where = "";
+$where = '';
 if (REQUEST_ISSET_GET(('active'))) {
 	$where = sprintf("WHERE ext_active = '%s'", SQL_ESCAPE(strip_tags(REQUEST_GET('active'))));
 } // END - if
@@ -228,7 +231,7 @@ if (REQUEST_ISSET_GET(('active'))) {
 // Case selection
 switch ($do) {
 case "overview": // List all registered extensions
-	if (GET_EXT_VERSION("sql_patches") >= "0.0.6") {
+	if (GET_EXT_VERSION('sql_patches') >= '0.0.6') {
 		// Load extension data with CSS informations
 		$result = SQL_QUERY("SELECT id AS ext_id, ext_name, ext_active, ext_has_css AS ext_css, ext_version
 FROM `{!_MYSQL_PREFIX!}_extensions`
@@ -245,11 +248,11 @@ ORDER BY ext_name", __FILE__, __LINE__);
 	// Are there some entries?
 	if (SQL_NUMROWS($result) > 0) {
 		// Extensions are registered
-		$OUT = ""; $SW = 2;
+		$OUT = ''; $SW = 2;
 		while ($content = SQL_FETCHARRAY($result)) {
 			// Prepare CSS selection output
-			$cssSelection = "---";
-			if (GET_EXT_VERSION("sql_patches") >= "0.0.6") $cssSelection = TRANSLATE_YESNO($content['ext_css']);
+			$cssSelection = '---';
+			if (GET_EXT_VERSION('sql_patches') >= '0.0.6') $cssSelection = TRANSLATE_YESNO($content['ext_css']);
 
 			// Prepare data for the row template
 			$content = array(
@@ -277,11 +280,11 @@ ORDER BY ext_name", __FILE__, __LINE__);
 		LOAD_TEMPLATE("admin_extensions");
 	} else {
 		// No extensions are registered
-		LOAD_TEMPLATE("admin_settings_saved", false, getMessage('ADMIN_NO_EXTENSION_REGISTERED'));
+		LOAD_TEMPLATE('admin_settings_saved', false, getMessage('ADMIN_NO_EXTENSION_REGISTERED'));
 	}
 	break;
 
-case "register": // Register new extension
+case 'register': // Register new extension
 	$result = SQL_QUERY_ESC("SELECT id FROM `{!_MYSQL_PREFIX!}_task_system` WHERE assigned_admin=%s AND task_type='EXTENSION' LIMIT 1",
 		array(GET_CURRENT_ADMIN_ID()), __FILE__, __LINE__);
 	$task_found = SQL_NUMROWS($result);
@@ -304,61 +307,62 @@ case "register": // Register new extension
 			$ext_name = trim(substr($subj, 1, strpos($subj, ":") - 1));
 
 			// Test the extension for deprecation
-			LOAD_EXTENSION($ext_name, "test");
+			LOAD_EXTENSION($ext_name, 'test');
 
 			// Is the extension deprecated?
-			if (EXT_GET_DEPRECATED() == "N") {
+			if (EXT_GET_DEPRECATED() == 'N') {
 				// ... so we can finally register and load it in registration mode
-				if (EXTENSION_REGISTER($ext_name, $ext_id)) {
+				if (REGISTER_EXTENSION($ext_name, $ext_id)) {
 					// Extension was found and successfully registered
-					LOAD_TEMPLATE("admin_settings_saved", false, getMessage('ADMIN_EXTENSION_REGISTERED'));
+					LOAD_TEMPLATE('admin_settings_saved', false, getMessage('ADMIN_EXTENSION_REGISTERED'));
 
 					// Show next link
-					if (EXT_IS_ACTIVE("task")) {
-						LOAD_TEMPLATE("admin_next_link", false, array(
-							'url'   => "modules.php?module=admin&what=list_task",
+					if (EXT_IS_ACTIVE('task')) {
+						LOAD_TEMPLATE('admin_next_link', false, array(
+							'url'   => 'modules.php?module=admin&what=list_task',
 							'title' => getMessage('ADMIN_EXT_REGISTER_NEXT_LINK')
 						));
 					} else {
-						LOAD_TEMPLATE("admin_next_link", false, array(
-							'url'   => "modules.php?module=admin",
+						LOAD_TEMPLATE('admin_next_link', false, array(
+							'url'   => 'modules.php?module=admin',
 							'title' => getMessage('ADMIN_EXT_REGISTER_NEXT_LINK')
 						));
 					}
 
 					// Do we need to update cache file?
-					if ((EXT_IS_ACTIVE("cache")) && ($GLOBALS['cache_mode'] != "no")) {
+					// @TODO Rewrite this to a filter
+					if ((EXT_IS_ACTIVE('cache')) && ($GLOBALS['cache_mode'] != 'no')) {
 						// Remove cache file (will be auto-created again!)
-						if ($GLOBALS['cache_instance']->loadCacheFile("config")) $GLOBALS['cache_instance']->destroyCacheFile();
-						if ($GLOBALS['cache_instance']->loadCacheFile("extensions", true)) $GLOBALS['cache_instance']->destroyCacheFile();
-						if ($GLOBALS['cache_instance']->loadCacheFile("modreg")) $GLOBALS['cache_instance']->destroyCacheFile();
+						if ($GLOBALS['cache_instance']->loadCacheFile('config')) $GLOBALS['cache_instance']->destroyCacheFile();
+						if ($GLOBALS['cache_instance']->loadCacheFile('extensions', true)) $GLOBALS['cache_instance']->destroyCacheFile();
+						if ($GLOBALS['cache_instance']->loadCacheFile('modreg')) $GLOBALS['cache_instance']->destroyCacheFile();
 					} // END - if
-				} elseif (GET_EXT_VERSION($ext_name) != "") {
+				} elseif (GET_EXT_VERSION($ext_name) != '') {
 					// Notify the admin that we have a problem here...
-					LOAD_TEMPLATE("admin_settings_saved", false, getMessage('ADMIN_REG_FAILED_ALREADY'));
+					LOAD_TEMPLATE('admin_settings_saved', false, getMessage('ADMIN_REG_FAILED_ALREADY'));
 				} else {
 					// Notify the admin that we have a problem here...
-					LOAD_TEMPLATE("admin_settings_saved", false, sprintf(getMessage('ADMIN_REG_FAILED_404'), $ext_name));
+					LOAD_TEMPLATE('admin_settings_saved', false, sprintf(getMessage('ADMIN_REG_FAILED_404'), $ext_name));
 				}
 			} else {
 				// Motify the admin that we have a problem here...
-				LOAD_TEMPLATE("admin_settings_saved", false, getMessage('ADMIN_REG_FAILED_DEPRECATED'));
+				LOAD_TEMPLATE('admin_settings_saved', false, getMessage('ADMIN_REG_FAILED_DEPRECATED'));
 			}
 		} else {
 			// Extension was not found in task management
-			LOAD_TEMPLATE("admin_settings_saved", false, getMessage('ADMIN_REG_FAILED_ID_404'));
+			LOAD_TEMPLATE('admin_settings_saved', false, getMessage('ADMIN_REG_FAILED_ID_404'));
 		}
-	} elseif ($task_found == "0") {
+	} elseif ($task_found == '0') {
 		// No longer assigned or old task
-		LOAD_TEMPLATE("admin_settings_saved", false, getMessage('ADMIN_REG_FAILED_ASSIGED'));
+		LOAD_TEMPLATE('admin_settings_saved', false, getMessage('ADMIN_REG_FAILED_ASSIGED'));
 	} else {
 		// ID is invalid
-		LOAD_TEMPLATE("admin_settings_saved", false, getMessage('ADMIN_REG_FAILED_INVALID'));
+		LOAD_TEMPLATE('admin_settings_saved', false, getMessage('ADMIN_REG_FAILED_INVALID'));
 	}
 	break;
 
-case "demo":
-	LOAD_TEMPLATE("admin_settings_saved", false, getMessage('SETTINGS_NOT_SAVED'));
+case 'demo':
+	LOAD_TEMPLATE('admin_settings_saved', false, getMessage('SETTINGS_NOT_SAVED'));
 	break;
 }
 //