X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=inc%2Fmodules%2Fadmin%2Fwhat-extensions.php;h=e85fcc78a15fedd392cd2c135907dacbc6799fb3;hb=96dfdd6b8e6a56d6594c3525e5fd2a066697a6de;hp=33e4de8f72a1a7f3192f619ebd06ed1bd2961c81;hpb=f2c43b993e03f90202044a0c2ea0abd0866ec6ee;p=mailer.git

diff --git a/inc/modules/admin/what-extensions.php b/inc/modules/admin/what-extensions.php
index 33e4de8f72..e85fcc78a1 100644
--- a/inc/modules/admin/what-extensions.php
+++ b/inc/modules/admin/what-extensions.php
@@ -1,7 +1,7 @@
 <?php
 /************************************************************************
- * MXChange v0.2.1                                    Start: 03/22/2004 *
- * ================                             Last change: 12/13/2004 *
+ * Mailer v0.2.1-FINAL                                Start: 03/22/2004 *
+ * ===================                          Last change: 12/13/2004 *
  *                                                                      *
  * -------------------------------------------------------------------- *
  * File              : what-extentions.php                              *
@@ -46,24 +46,18 @@ addMenuDescription('admin', __FILE__);
 
 // Normally we want the overview of all registered extensions
 $do = 'overview';
-$SEL = 0;
-
-// Are some extensions submitted?
-if (isPostRequestElementSet('sel')) {
-	// Then count all
-	$SEL = countPostSelection();
-} // END - if
 
 if (isGetRequestElementSet('reg_ext')) {
 	// We are about to register a new extension
 	$do = 'register'; $ext_id = bigintval(getRequestElement('reg_ext'));
 	// The id comes from task management and it is - of course - *not* the extension's name!
-} elseif ((isPostRequestElementSet('change')) && ($SEL > 0) && (!isDemoModeActive())) {
+} elseif ((isPostRequestElementSet('change')) && (countPostSelection() > 0) && (!isDemoModeActive())) {
 	// De-/activate extensions
 	foreach (postRequestElement('sel') as $ext_id => $active) {
 		// Shall we keep the extension always active?
-		if ((isset($GLOBALS['cache_array']['active_extensions'][getExtensionName($ext_id)])) && ($GLOBALS['cache_array']['active_extensions'][getExtensionName($ext_id)] == 'Y') && ($active != 'Y')) {
+		if ((isset($GLOBALS['cache_array']['always_active'][getExtensionName($ext_id)])) && ($GLOBALS['cache_array']['always_active'][getExtensionName($ext_id)] == 'Y') && ($active == 'Y')) {
 			// Keep this extension active!
+			loadTemplate('admin_settings_saved', false, getMaskedMessage('ADMIN_EXTENSION_ALWAYS_ACTIVE', getExtensionName($ext_id)));
 		} else {
 			// De/activate extension
 			$ACT = 'N'; setExtensionMode('deactivate');
@@ -75,11 +69,11 @@ if (isGetRequestElementSet('reg_ext')) {
 			doExtensionSqls($ext_id, getExtensionMode());
 		}
 	}
-} elseif (((isPostRequestElementSet('edit')) || (isPostRequestElementSet(('modify')))) && ($SEL > 0) && (!isDemoModeActive())) {
+} elseif (((isPostRequestElementSet('edit')) || (isPostRequestElementSet('modify'))) && (countPostSelection() > 0) && (!isDemoModeActive())) {
 	// Change settings like CSS file load
-	if (isPostRequestElementSet(('modify'))) {
+	if (isPostRequestElementSet('modify')) {
 		// Change entries
-		$cache_update = 0;
+		$cache_update = '0';
 		foreach (postRequestElement('sel') as $ext_id => $sel) {
 			// Secure id
 			$ext_id = bigintval($ext_id);
@@ -162,7 +156,7 @@ if (isGetRequestElementSet('reg_ext')) {
 		loadTemplate('admin_extensions_edit', false, $OUT);
 		$do = 'edit';
 	}
-} elseif ((isPostRequestElementSet('delete')) && ($SEL > 0) && (!isDemoModeActive())) {
+} elseif ((isPostRequestElementSet('delete')) && (countPostSelection() > 0) && (!isDemoModeActive())) {
 	// List extensions and when verbose is enabled SQL statements which will be executed
 	$OUT = ''; $SW = 2;
 	foreach (postRequestElement('sel') as $ext_id => $sel) {
@@ -213,9 +207,9 @@ if (isGetRequestElementSet('reg_ext')) {
 	// Load template
 	loadTemplate('admin_extensions_delete', false, $OUT);
 	$do = 'delete';
-} elseif ((isPostRequestElementSet('remove')) && ($SEL > 0) && (!isDemoModeActive())) {
+} elseif ((isPostRequestElementSet('remove')) && (countPostSelection() > 0) && (!isDemoModeActive())) {
 	// Remove extensions from DB (you have to delete all files manually!)
-	$cache_update = 0;
+	$cache_update = '0';
 	foreach (postRequestElement('sel') as $ext_id => $active) {
 		// Secure id number
 		$ext_id = bigintval($ext_id);
@@ -228,7 +222,7 @@ if (isGetRequestElementSet('reg_ext')) {
 	} // END - foreach
 
 	// Extensions removed
-	loadTemplate('admin_settings_saved', false, sprintf(getMessage('ADMIN_EXTENSIONS_REMOVED'), $SEL));
+	loadTemplate('admin_settings_saved', false, getMaskedMessage('ADMIN_EXTENSIONS_REMOVED', countPostSelection()));
 } elseif ((isGetRequestElementSet('do')) && (!isDemoModeActive())) {
 	// Other things to do
 	$do = SQL_ESCAPE(secureString(getRequestElement('do')));
@@ -267,7 +261,7 @@ ORDER BY `ext_name` ASC", __FILE__, __LINE__);
 			while ($content = SQL_FETCHARRAY($result)) {
 				// Prepare CSS selection output
 				$cssSelection = '---';
-				if (getExtensionVersion('sql_patches') >= '0.0.6') $cssSelection = translateYesNo($content['ext_css']);
+				if (isExtensionInstalledAndNewer('sql_patches', '0.0.6')) $cssSelection = translateYesNo($content['ext_css']);
 
 				// Prepare data for the row template
 				$content = array(
@@ -310,10 +304,12 @@ ORDER BY `ext_name` ASC", __FILE__, __LINE__);
 			$result = SQL_QUERY_ESC("SELECT `subject` FROM `{?_MYSQL_PREFIX?}_task_system` WHERE `id`=%s LIMIT 1",
 				array(bigintval($ext_id)), __FILE__, __LINE__);
 			list($subj) = SQL_FETCHROW($result);
+
+			// Free result
 			SQL_FREERESULT($result);
 
 			// Disable cache update by default
-			$cache_update = 0;
+			$cache_update = '0';
 			if (!empty($subj)) {
 				// Extract extension's name from subject...
 				$ext_name = trim(substr($subj, 1, strpos($subj, ':') - 1));
@@ -326,9 +322,9 @@ ORDER BY `ext_name` ASC", __FILE__, __LINE__);
 					// ... so we can finally register and load it in registration mode
 					if (registerExtension($ext_name, $ext_id)) {
 						// Errors?
-						if (getTotalFatalErrors() == 0) {
+						if (getTotalFatalErrors() == '0') {
 							// Extension was found and successfully registered
-							loadTemplate('admin_settings_saved', false, sprintf(getMessage('ADMIN_EXTENSION_REGISTERED'), $ext_name));
+							loadTemplate('admin_settings_saved', false, getMaskedMessage('ADMIN_EXTENSION_REGISTERED', $ext_name));
 
 							// Show next link
 							if (isExtensionActive('task')) {
@@ -344,7 +340,7 @@ ORDER BY `ext_name` ASC", __FILE__, __LINE__);
 							}
 						} else {
 							// Errors detected!
-							loadTemplate('admin_settings_saved', false, sprintf(getMessage('ADMIN_EXTENSION_NOT_REGISTERED'), $ext_name));
+							loadTemplate('admin_settings_saved', false, getMaskedMessage('ADMIN_EXTENSION_NOT_REGISTERED', $ext_name));
 						}
 
 						// Do we need to update cache file?
@@ -360,7 +356,7 @@ ORDER BY `ext_name` ASC", __FILE__, __LINE__);
 						loadTemplate('admin_settings_saved', false, getMessage('ADMIN_REG_FAILED_ALREADY'));
 					} else {
 						// Notify the admin that we have a problem here...
-						loadTemplate('admin_settings_saved', false, sprintf(getMessage('ADMIN_REG_FAILED_404'), $ext_name));
+						loadTemplate('admin_settings_saved', false, getMaskedMessage('ADMIN_REG_FAILED_404', $ext_name));
 					}
 				} else {
 					// Motify the admin that we have a problem here...
@@ -370,7 +366,7 @@ ORDER BY `ext_name` ASC", __FILE__, __LINE__);
 				// Extension was not found in task management
 				loadTemplate('admin_settings_saved', false, getMessage('ADMIN_REG_FAILED_ID_404'));
 			}
-		} elseif ($task_found == 0) {
+		} elseif ($task_found == '0') {
 			// No longer assigned or old task
 			loadTemplate('admin_settings_saved', false, getMessage('ADMIN_REG_FAILED_ASSIGED'));
 		} else {