X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=inc%2Fmysql-manager.php;h=da948fbee81fbe68a32abe9adba2f5357564d939;hb=72f7e9ed8975d7fb4f2ebeb48dd43c896289a57b;hp=7751f364b2fbe100bddccf8c1f15dabbccf34488;hpb=b4784eb7267921f162d2fa90d21fa20fad700962;p=mailer.git diff --git a/inc/mysql-manager.php b/inc/mysql-manager.php index 7751f364b2..da948fbee8 100644 --- a/inc/mysql-manager.php +++ b/inc/mysql-manager.php @@ -16,7 +16,7 @@ * $Author:: $ * * -------------------------------------------------------------------- * * Copyright (c) 2003 - 2009 by Roland Haeder * - * Copyright (c) 2009 - 2012 by Mailer Developer Team * + * Copyright (c) 2009 - 2013 by Mailer Developer Team * * For more information visit: http://mxchange.org * * * * This program is free software; you can redistribute it and/or modify * @@ -61,7 +61,7 @@ function getTitleFromMenu ($mode, $what, $column = 'what', $ADD = '') { $data['title'] = '??? (' . $what . ')'; // Look for title - $result = SQL_QUERY_ESC("SELECT `title` FROM `{?_MYSQL_PREFIX?}_%s_menu` WHERE `%s`='%s'" . $ADD . " LIMIT 1", + $result = sqlQueryEscaped("SELECT `title` FROM `{?_MYSQL_PREFIX?}_%s_menu` WHERE `%s`='%s'" . $ADD . " LIMIT 1", array( $mode, $column, @@ -69,13 +69,13 @@ function getTitleFromMenu ($mode, $what, $column = 'what', $ADD = '') { ), __FUNCTION__, __LINE__); // Is there an entry? - if (SQL_NUMROWS($result) == 1) { + if (sqlNumRows($result) == 1) { // Fetch the title - $data = SQL_FETCHARRAY($result); + $data = sqlFetchArray($result); } // END - if // Free result - SQL_FREERESULT($result); + sqlFreeResult($result); // Return it return $data['title']; @@ -161,7 +161,7 @@ function addYouAreHereLink ($accessLevel, $FQFN, $return = FALSE) { // Is ext-sql_patches installed? //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'isExtensionInstalledAndNewer()=' . intval(isExtensionInstalledAndNewer('sql_patches', '0.2.3')) . ',youre_here=' . getYoureHere() . ',isAdmin()=' . intval(isAdmin()) . ',modCheck=' . $modCheck); - if (((isExtensionInstalledAndNewer('sql_patches', '0.2.3')) && (isYourHereEnabled())) || ((isAdmin()) && ($modCheck == 'admin'))) { + if (((isExtensionInstalledAndNewer('sql_patches', '0.2.3')) && (isYoureHereEnabled())) || ((isAdmin()) && ($modCheck == 'admin'))) { // Output HTML code $OUT = $prefix . '' . getTitleFromMenu($accessLevel, $search, $type, $ADD) . ''; @@ -211,7 +211,7 @@ function addMenu ($mode, $action, $what) { } // END - if // Load SQL data and add the menu to the output stream... - $result_main = SQL_QUERY_ESC("SELECT + $result_main = sqlQueryEscaped("SELECT `title`, `what`, `action`, @@ -227,10 +227,10 @@ ORDER BY array($mode), __FUNCTION__, __LINE__); //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'main_cnt=' . $main_cnt . ',getWhat()=' . getWhat()); - if (!SQL_HASZERONUMS($result_main)) { + if (!ifSqlHasZeroNums($result_main)) { // There are menus available, so we simply display them... :) $GLOBALS['rows'] = ''; - while ($content = SQL_FETCHARRAY($result_main)) { + while ($content = sqlFetchArray($result_main)) { //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'main_cnt=' . $main_cnt . ',action=' . $content['action'] . ',getWhat()=' . getWhat()); // Disable the block-mode enableBlockMode(FALSE); @@ -239,7 +239,7 @@ ORDER BY $GLOBALS['rows'] .= loadTemplate($mode . '_menu_title', TRUE, $content); // Sub menu - $result_sub = SQL_QUERY_ESC("SELECT + $result_sub = sqlQueryEscaped("SELECT `title` AS `sub_title`, `what` AS `sub_what`, `visible` AS `sub_visible`, @@ -259,12 +259,12 @@ ORDER BY ), __FUNCTION__, __LINE__); // Are there some entries? - if (!SQL_HASZERONUMS($result_sub)) { + if (!ifSqlHasZeroNums($result_sub)) { // Init counter $count = '0'; // Load all sub menus - while ($content2 = SQL_FETCHARRAY($result_sub)) { + while ($content2 = sqlFetchArray($result_sub)) { // Merge both arrays in one $content = merge_array($content, $content2); @@ -320,7 +320,7 @@ ORDER BY ); // Add regular menu row or bottom row? - if ($count < SQL_NUMROWS($result_sub)) { + if ($count < sqlNumRows($result_sub)) { $GLOBALS['rows'] .= loadTemplate($mode . '_menu_row', TRUE, $content); } else { $GLOBALS['rows'] .= loadTemplate($mode . '_menu_bottom', TRUE, $content); @@ -344,13 +344,13 @@ ORDER BY } // Free result - SQL_FREERESULT($result_sub); + sqlFreeResult($result_sub); // Count one up $main_cnt++; //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'main_cnt=' . $main_cnt . ',getWhat()=' . getWhat()); - if (SQL_NUMROWS($result_main) > $main_cnt) { + if (sqlNumRows($result_main) > $main_cnt) { // Add separator $GLOBALS['rows'] .= loadTemplate('menu_separator', TRUE, $mode); @@ -371,7 +371,7 @@ ORDER BY } // END - while // Free memory - SQL_FREERESULT($result_main); + sqlFreeResult($result_main); // Prepare filter data array $filterData = array( @@ -483,7 +483,7 @@ function fetchUserData ($value, $column = 'userid') { $value = bigintval($value); // Don't look for invalid userids... - if (!isValidUserId($value)) { + if (!isValidId($value)) { // Invalid, so abort here reportBug(__FUNCTION__, __LINE__, 'User id ' . $value . ' is invalid.'); } // END - if @@ -492,12 +492,12 @@ function fetchUserData ($value, $column = 'userid') { if ((isCurrentUserIdSet()) && (getCurrentUserId() != $value)) { // Unset it unsetCurrentUserId(); - } elseif (isUserDataValid()) { + } elseif (isValidUserData()) { // Use cache, so it is fine //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'value=' . $value . ' is valid, using cache #1'); return TRUE; } // END - if - } elseif (isUserDataValid()) { + } elseif (isValidUserData()) { // Using cache is fine //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'value=' . $value . ' is valid, using cache #2'); return TRUE; @@ -510,16 +510,16 @@ function fetchUserData ($value, $column = 'userid') { $ADD = runFilterChain('convert_user_data_columns', ' '); // Query for the user - $result = SQL_QUERY_ESC("SELECT *" . $ADD . " FROM `{?_MYSQL_PREFIX?}_user_data` WHERE `%s`='%s' LIMIT 1", + $result = sqlQueryEscaped("SELECT *" . $ADD . " FROM `{?_MYSQL_PREFIX?}_user_data` WHERE `%s`='%s' LIMIT 1", array( $column, $value ), __FUNCTION__, __LINE__); // Is there a record? - if (SQL_NUMROWS($result) == 1) { + if (sqlNumRows($result) == 1) { // Load data from cookies - $data = SQL_FETCHARRAY($result); + $data = sqlFetchArray($result); // Set the userid for later use setCurrentUserId($data['userid']); @@ -555,11 +555,11 @@ function fetchUserData ($value, $column = 'userid') { } // END - if // Found, but valid? - $found = isUserDataValid(); + $found = isValidUserData(); } // END - if // Free memory - SQL_FREERESULT($result); + sqlFreeResult($result); // Return result return $found; @@ -580,7 +580,7 @@ function isAdmin () { } // END - if // No admin in installation phase! - if ((isInstallationPhase()) || (!isAdminRegistered())) { + if ((isInstaller()) || (!isAdminRegistered())) { $GLOBALS[__FUNCTION__] = FALSE; return FALSE; } // END - if @@ -646,14 +646,14 @@ function addMaxReceiveList ($mode, $default = '') { switch ($mode) { case 'guest': // Guests (in the registration form) are not allowed to select 0 mails per day. - $result = SQL_QUERY('SELECT `value`, `comment` FROM `{?_MYSQL_PREFIX?}_max_receive` WHERE `value` > 0 ORDER BY `value` ASC', + $result = sqlQuery('SELECT `value`, `comment` FROM `{?_MYSQL_PREFIX?}_max_receive` WHERE `value` > 0 ORDER BY `value` ASC', __FUNCTION__, __LINE__); break; case 'admin': case 'member': // Members are allowed to set to zero mails per day (we will change this soon!) - $result = SQL_QUERY('SELECT `value`, `comment` FROM `{?_MYSQL_PREFIX?}_max_receive` ORDER BY `value` ASC', + $result = sqlQuery('SELECT `value`, `comment` FROM `{?_MYSQL_PREFIX?}_max_receive` ORDER BY `value` ASC', __FUNCTION__, __LINE__); break; @@ -663,9 +663,9 @@ function addMaxReceiveList ($mode, $default = '') { } // Some entries are found? - if (!SQL_HASZERONUMS($result)) { + if (!ifSqlHasZeroNums($result)) { $OUT = ''; - while ($content = SQL_FETCHARRAY($result)) { + while ($content = sqlFetchArray($result)) { $OUT .= ' 0) { + } elseif (isValidId($cid)) { // Lookup the category in database - $result = SQL_QUERY_ESC('SELECT `cat` FROM `{?_MYSQL_PREFIX?}_cats` WHERE `id`=%s LIMIT 1', + $result = sqlQueryEscaped('SELECT `cat` FROM `{?_MYSQL_PREFIX?}_cats` WHERE `id`=%s LIMIT 1', array(bigintval($cid)), __FUNCTION__, __LINE__); - if (SQL_NUMROWS($result) == 1) { + if (sqlNumRows($result) == 1) { // Category found... :-) - $data = SQL_FETCHARRAY($result); + $data = sqlFetchArray($result); } // END - if // Free result - SQL_FREERESULT($result); + sqlFreeResult($result); } // END - if // Return result @@ -901,8 +903,26 @@ function getPaymentTitlePrice ($paymentsId, $full = FALSE) { return $ret; } +// Get payment price +function getPaymentPrice ($paymentsId) { + // Return result + return getPaymentData($paymentsId, 'price'); +} + +// Get payment time +function getPaymentTime ($paymentsId) { + // Return result + return getPaymentData($paymentsId, 'time'); +} + +// Get payment 'payment' +function getPaymentPayment ($paymentsId) { + // Return result + return getPaymentData($paymentsId, 'payment'); +} + // "Getter" for payment data (cached) -function getPaymentData ($paymentsId, $lookFor = 'price') { +function getPaymentData ($paymentsId, $lookFor) { // Default value... $data[$lookFor] = NULL; @@ -915,20 +935,20 @@ function getPaymentData ($paymentsId, $lookFor = 'price') { incrementStatsEntry('cache_hits'); } elseif (!isExtensionActive('cache')) { // Search for it in database - $result = SQL_QUERY_ESC('SELECT `%s` FROM `{?_MYSQL_PREFIX?}_payments` WHERE `id`=%s LIMIT 1', + $result = sqlQueryEscaped('SELECT `%s` FROM `{?_MYSQL_PREFIX?}_payments` WHERE `id`=%s LIMIT 1', array( $lookFor, bigintval($paymentsId) ), __FUNCTION__, __LINE__); // Is the entry there? - if (SQL_NUMROWS($result) == 1) { + if (sqlNumRows($result) == 1) { // Payment type found... :-) - $data = SQL_FETCHARRAY($result); + $data = sqlFetchArray($result); } // END - if // Free result - SQL_FREERESULT($result); + sqlFreeResult($result); } // Return value @@ -941,12 +961,12 @@ function removeReceiver (&$receivers, $key, $userid, $poolId, $statsId = 0, $isB $ret = 'failed'; // Is the userid valid? - if (isValidUserId($userid)) { + if (isValidId($userid)) { // Remove entry from array unset($receivers[$key]); // Is there already a line for this user available? - if ($statsId > 0) { + if (isValidId($statsId)) { // Default is 'normal' mail $type = 'NORMAL'; $rowName = 'stats_id'; @@ -958,7 +978,7 @@ function removeReceiver (&$receivers, $key, $userid, $poolId, $statsId = 0, $isB } // END - if // Try to look the entry up - $result = SQL_QUERY_ESC("SELECT `id` FROM `{?_MYSQL_PREFIX?}_user_links` WHERE `%s`=%s AND `userid`=%s AND `link_type`='%s' LIMIT 1", + $result = sqlQueryEscaped("SELECT `id` FROM `{?_MYSQL_PREFIX?}_user_links` WHERE `%s`=%s AND `userid`=%s AND `link_type`='%s' LIMIT 1", array( $rowName, bigintval($statsId), @@ -967,9 +987,9 @@ function removeReceiver (&$receivers, $key, $userid, $poolId, $statsId = 0, $isB ), __FUNCTION__, __LINE__); // Was it *not* found? - if (SQL_HASZERONUMS($result)) { + if (ifSqlHasZeroNums($result)) { // So we add one! - SQL_QUERY_ESC("INSERT INTO `{?_MYSQL_PREFIX?}_user_links` (`%s`, `userid`, `link_type`) VALUES (%s,%s,'%s')", + sqlQueryEscaped("INSERT INTO `{?_MYSQL_PREFIX?}_user_links` (`%s`, `userid`, `link_type`) VALUES (%s,%s,'%s')", array( $rowName, bigintval($statsId), @@ -980,8 +1000,7 @@ function removeReceiver (&$receivers, $key, $userid, $poolId, $statsId = 0, $isB // Update 'mails_sent' if ext-sql_patches is updated if (isExtensionInstalledAndNewer('sql_patches', '0.7.4')) { // Update the pool - SQL_QUERY_ESC('UPDATE `{?_MYSQL_PREFIX?}_pool` SET `mails_sent`=`mails_sent`+1 WHERE `id`=%s LIMIT 1', - array(bigintval($poolId)), __FUNCTION__, __LINE__); + updatePoolDataById($poolId, 'mails_sent', 1, '+'); } // END - if $ret = 'done'; } else { @@ -990,7 +1009,7 @@ function removeReceiver (&$receivers, $key, $userid, $poolId, $statsId = 0, $isB } // Free memory - SQL_FREERESULT($result); + sqlFreeResult($result); } // END - if } // END - if @@ -1002,12 +1021,12 @@ function removeReceiver (&$receivers, $key, $userid, $poolId, $statsId = 0, $isB function countSumTotalData ($search, $tableName, $lookFor = 'id', $whereStatement = 'userid', $countRows = FALSE, $add = '', $mode = '=') { // Debug message //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'search=' . $search . ',tableName=' . $tableName . ',lookFor=' . $lookFor . ',whereStatement=' . $whereStatement . ',add=' . $add); - if ((empty($search)) && ($search != '0')) { + if ((empty($search)) && (!is_null($search))) { // Count or sum whole table? if ($countRows === TRUE) { // Count whole table //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'COUNT!'); - $result = SQL_QUERY_ESC('SELECT COUNT(`%s`) AS `res` FROM `{?_MYSQL_PREFIX?}_%s`' . $add . ' LIMIT 1', + $result = sqlQueryEscaped('SELECT COUNT(`%s`) AS `res` FROM `{?_MYSQL_PREFIX?}_%s`' . $add . ' LIMIT 1', array( $lookFor, $tableName @@ -1015,7 +1034,7 @@ function countSumTotalData ($search, $tableName, $lookFor = 'id', $whereStatemen } else { // Sum whole table //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'SUM!'); - $result = SQL_QUERY_ESC('SELECT SUM(`%s`) AS `res` FROM `{?_MYSQL_PREFIX?}_%s`' . $add . ' LIMIT 1', + $result = sqlQueryEscaped('SELECT SUM(`%s`) AS `res` FROM `{?_MYSQL_PREFIX?}_%s`' . $add . ' LIMIT 1', array( $lookFor, $tableName @@ -1023,33 +1042,75 @@ function countSumTotalData ($search, $tableName, $lookFor = 'id', $whereStatemen } } elseif (($countRows === TRUE) || ($lookFor == 'userid')) { // Count rows - //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'COUNT!'); - $result = SQL_QUERY_ESC("SELECT COUNT(`%s`) AS `res` FROM `{?_MYSQL_PREFIX?}_%s` WHERE `%s`%s'%s'" . $add . ' LIMIT 1', - array( - $lookFor, - $tableName, - $whereStatement, - $mode, - $search - ), __FUNCTION__, __LINE__); + if (is_null($search)) { + // Fix mode + if ($mode == '=') { + $mode = 'IS'; + } elseif ($mode == '!=') { + $mode = 'IS NOT'; + } + + // Look for NULL/0 + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'COUNT-NULL!'); + $result = sqlQueryEscaped("SELECT COUNT(`%s`) AS `res` FROM `{?_MYSQL_PREFIX?}_%s` WHERE (`%s` %s NULL OR `%s`=0)" . $add . ' LIMIT 1', + array( + $lookFor, + $tableName, + $whereStatement, + $mode, + $whereStatement + ), __FUNCTION__, __LINE__); + } else { + // Regular entry + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'COUNT!'); + $result = sqlQueryEscaped("SELECT COUNT(`%s`) AS `res` FROM `{?_MYSQL_PREFIX?}_%s` WHERE `%s`%s'%s'" . $add . ' LIMIT 1', + array( + $lookFor, + $tableName, + $whereStatement, + $mode, + $search + ), __FUNCTION__, __LINE__); + } } else { - // Add all rows - //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'SUM!'); - $result = SQL_QUERY_ESC("SELECT SUM(`%s`) AS `res` FROM `{?_MYSQL_PREFIX?}_%s` WHERE `%s`%s'%s'" . $add . ' LIMIT 1', - array( - $lookFor, - $tableName, - $whereStatement, - $mode, - $search - ), __FUNCTION__, __LINE__); + // Sum all rows + if (is_null($search)) { + // Fix mode + if ($mode == '=') { + $mode = 'IS'; + } elseif ($mode == '!=') { + $mode = 'IS NOT'; + } + + // Look for NULL/0 + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'SUM-NULL!'); + $result = sqlQueryEscaped("SELECT SUM(`%s`) AS `res` FROM `{?_MYSQL_PREFIX?}_%s` WHERE (`%s` %s NULL OR `%s`=0)" . $add . ' LIMIT 1', + array( + $lookFor, + $tableName, + $whereStatement, + $mode, + $whereStatement + ), __FUNCTION__, __LINE__); + } else { + // Regular entry + //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'SUM!'); + $result = sqlQueryEscaped("SELECT SUM(`%s`) AS `res` FROM `{?_MYSQL_PREFIX?}_%s` WHERE `%s`%s'%s'" . $add . ' LIMIT 1', + array( + $lookFor, + $tableName, + $whereStatement, + $mode, + $search + ), __FUNCTION__, __LINE__); + } } // Load row - $data = SQL_FETCHARRAY($result); + $data = sqlFetchArray($result); // Free result - SQL_FREERESULT($result); + sqlFreeResult($result); // Fix empty values if ((empty($data['res'])) && ($lookFor != 'counter') && ($lookFor != 'id') && ($lookFor != 'userid') && ($lookFor != 'rallye_id')) { @@ -1080,16 +1141,16 @@ function sendAdminEmails ($subject, $message, $isBugReport = FALSE) { } // END - if // Load all admin email addresses - $result = SQL_QUERY('SELECT `email` FROM `{?_MYSQL_PREFIX?}_admins` ORDER BY `id` ASC', __FUNCTION__, __LINE__); + $result = sqlQuery('SELECT `email` FROM `{?_MYSQL_PREFIX?}_admins` ORDER BY `id` ASC', __FUNCTION__, __LINE__); // And send the notification to all of them - while ($content = SQL_FETCHARRAY($result)) { + while ($content = sqlFetchArray($result)) { // Send the email out sendEmail($content['email'], $subject, $message, 'N', $mailHeader); } // END - if // Free result - SQL_FREERESULT($result); + sqlFreeResult($result); // Really simple... ;-) } @@ -1108,17 +1169,17 @@ function getAdminId ($adminLogin) { incrementStatsEntry('cache_hits'); } elseif (!isExtensionActive('cache')) { // Load from database - $result = SQL_QUERY_ESC("SELECT `id` FROM `{?_MYSQL_PREFIX?}_admins` WHERE `login`='%s' LIMIT 1", + $result = sqlQueryEscaped("SELECT `id` FROM `{?_MYSQL_PREFIX?}_admins` WHERE `login`='%s' LIMIT 1", array($adminLogin), __FUNCTION__, __LINE__); // Is there an entry? - if (SQL_NUMROWS($result) == 1) { + if (sqlNumRows($result) == 1) { // Get it - $data = SQL_FETCHARRAY($result); + $data = sqlFetchArray($result); } // END - if // Free result - SQL_FREERESULT($result); + sqlFreeResult($result); } // Return the id @@ -1164,20 +1225,20 @@ function getAdminHash ($adminId) { incrementStatsEntry('cache_hits'); } elseif (!isExtensionActive('cache')) { // Load from database - $result = SQL_QUERY_ESC("SELECT `password` FROM `{?_MYSQL_PREFIX?}_admins` WHERE `id`=%s LIMIT 1", + $result = sqlQueryEscaped("SELECT `password` FROM `{?_MYSQL_PREFIX?}_admins` WHERE `id`=%s LIMIT 1", array(bigintval($adminId)), __FUNCTION__, __LINE__); // Is there an entry? - if (SQL_NUMROWS($result) == 1) { + if (sqlNumRows($result) == 1) { // Fetch data - $data = SQL_FETCHARRAY($result); + $data = sqlFetchArray($result); // Set cache setAdminHash($adminId, $data['password']); } // END - if // Free result - SQL_FREERESULT($result); + sqlFreeResult($result); } // Return password hash @@ -1198,20 +1259,20 @@ function getAdminLogin ($adminId) { incrementStatsEntry('cache_hits'); } elseif (!isExtensionActive('cache')) { // Load from database - $result = SQL_QUERY_ESC("SELECT `login` FROM `{?_MYSQL_PREFIX?}_admins` WHERE `id`=%s LIMIT 1", + $result = sqlQueryEscaped("SELECT `login` FROM `{?_MYSQL_PREFIX?}_admins` WHERE `id`=%s LIMIT 1", array(bigintval($adminId)), __FUNCTION__, __LINE__); // Entry found? - if (SQL_NUMROWS($result) == 1) { + if (sqlNumRows($result) == 1) { // Fetch data - $data = SQL_FETCHARRAY($result); + $data = sqlFetchArray($result); // Set cache $GLOBALS['cache_array']['admin']['login'][$adminId] = $data['login']; } // END - if // Free memory - SQL_FREERESULT($result); + sqlFreeResult($result); } // Return the result @@ -1231,20 +1292,20 @@ function getAdminEmail ($adminId) { incrementStatsEntry('cache_hits'); } elseif (!isExtensionActive('cache')) { // Load from database - $result_admin_id = SQL_QUERY_ESC("SELECT `email` FROM `{?_MYSQL_PREFIX?}_admins` WHERE `id`=%s LIMIT 1", + $result_admin_id = sqlQueryEscaped("SELECT `email` FROM `{?_MYSQL_PREFIX?}_admins` WHERE `id`=%s LIMIT 1", array(bigintval($adminId)), __FUNCTION__, __LINE__); // Entry found? - if (SQL_NUMROWS($result_admin_id) == 1) { + if (sqlNumRows($result_admin_id) == 1) { // Get data - $data = SQL_FETCHARRAY($result_admin_id); + $data = sqlFetchArray($result_admin_id); // Set cache $GLOBALS['cache_array']['admin']['email'][$adminId] = $data['email']; } // END - if // Free result - SQL_FREERESULT($result_admin_id); + sqlFreeResult($result_admin_id); } // Return email @@ -1259,7 +1320,7 @@ function getAdminDefaultAcl ($adminId) { // Is ext-sql_patches there and was it found in cache? if (!isExtensionActive('sql_patches')) { // Not found, which is bad, so we need to allow all - $data['default_acl'] = 'allow'; + $data['default_acl'] = 'allow'; } elseif (isset($GLOBALS['cache_array']['admin']['default_acl'][$adminId])) { // Use cache $data['default_acl'] = $GLOBALS['cache_array']['admin']['default_acl'][$adminId]; @@ -1268,20 +1329,20 @@ function getAdminDefaultAcl ($adminId) { incrementStatsEntry('cache_hits'); } elseif (!isExtensionActive('cache')) { // Load from database - $result_admin_id = SQL_QUERY_ESC("SELECT `default_acl` FROM `{?_MYSQL_PREFIX?}_admins` WHERE `id`=%s LIMIT 1", + $result_admin_id = sqlQueryEscaped("SELECT `default_acl` FROM `{?_MYSQL_PREFIX?}_admins` WHERE `id`=%s LIMIT 1", array(bigintval($adminId)), __FUNCTION__, __LINE__); // Is there an entry? - if (SQL_NUMROWS($result_admin_id) == 1) { + if (sqlNumRows($result_admin_id) == 1) { // Fetch data - $data = SQL_FETCHARRAY($result_admin_id); + $data = sqlFetchArray($result_admin_id); // Set cache $GLOBALS['cache_array']['admin']['default_acl'][$adminId] = $data['default_acl']; } // Free result - SQL_FREERESULT($result_admin_id); + sqlFreeResult($result_admin_id); } // Return default ACL @@ -1296,7 +1357,7 @@ function getAdminMenuMode ($adminId) { // Is ext-sql_patches there and was it found in cache? if (!isExtensionActive('sql_patches')) { // Not found, which is bad, so we need to allow all - $data['la_mode'] = 'global'; + $data['la_mode'] = 'global'; } elseif (isset($GLOBALS['cache_array']['admin']['la_mode'][$adminId])) { // Use cache $data['la_mode'] = $GLOBALS['cache_array']['admin']['la_mode'][$adminId]; @@ -1305,20 +1366,20 @@ function getAdminMenuMode ($adminId) { incrementStatsEntry('cache_hits'); } elseif (!isExtensionActive('cache')) { // Load from database - $result_admin_id = SQL_QUERY_ESC("SELECT `la_mode` FROM `{?_MYSQL_PREFIX?}_admins` WHERE `id`=%s LIMIT 1", + $result_admin_id = sqlQueryEscaped("SELECT `la_mode` FROM `{?_MYSQL_PREFIX?}_admins` WHERE `id`=%s LIMIT 1", array(bigintval($adminId)), __FUNCTION__, __LINE__); // Is there an entry? - if (SQL_NUMROWS($result_admin_id) == 1) { + if (sqlNumRows($result_admin_id) == 1) { // Fetch data - $data = SQL_FETCHARRAY($result_admin_id); + $data = sqlFetchArray($result_admin_id); // Set cache $GLOBALS['cache_array']['admin']['la_mode'][$adminId] = $data['la_mode']; } // Free result - SQL_FREERESULT($result_admin_id); + sqlFreeResult($result_admin_id); } // Return default ACL @@ -1367,7 +1428,7 @@ function generateOptions ($table, $key, $value, $default = '', $extra = '', $whe } // END - if // Run SQL query - $result = SQL_QUERY_ESC("SELECT `%s` AS `key`, `%s` AS `value`" . $extraColumn . " FROM `{?_MYSQL_PREFIX?}_%s` " . $whereStatement . " ORDER BY `%s` ASC", + $result = sqlQueryEscaped("SELECT `%s` AS `key`, `%s` AS `value`" . $extraColumn . " FROM `{?_MYSQL_PREFIX?}_%s` " . $whereStatement . " ORDER BY `%s` ASC", array( $key, $value, @@ -1376,9 +1437,9 @@ function generateOptions ($table, $key, $value, $default = '', $extra = '', $whe ), __FUNCTION__, __LINE__); // Is there rows? - if (!SQL_HASZERONUMS($result)) { + if (!ifSqlHasZeroNums($result)) { // Found data so add them as OPTION lines - while ($content = SQL_FETCHARRAY($result)) { + while ($content = sqlFetchArray($result)) { // Is extra set? if (!isset($content['extra'])) { // Set it to empty @@ -1415,7 +1476,7 @@ function generateOptions ($table, $key, $value, $default = '', $extra = '', $whe } // Free memory - SQL_FREERESULT($result); + sqlFreeResult($result); } // Return - hopefully - the requested data @@ -1428,27 +1489,27 @@ function deleteUserAccount ($userid, $reason) { $data['points'] = '0'; // Search for the points and user data - $result = SQL_QUERY_ESC("SELECT - (SUM(p.`points`) - d.`used_points`) AS `points` + $result = sqlQueryEscaped("SELECT + (SUM(`p`.`points`) - `d`.`used_points`) AS `points` FROM `{?_MYSQL_PREFIX?}_user_points` AS `p` LEFT JOIN `{?_MYSQL_PREFIX?}_user_data` AS `d` ON - p.`userid`=d.`userid` + `p`.`userid`=`d`.`userid` WHERE - p.`userid`=%s + `p`.`userid`=%s LIMIT 1", array(bigintval($userid)), __FUNCTION__, __LINE__); // Is there an entry? - if (SQL_NUMROWS($result) == 1) { + if (sqlNumRows($result) == 1) { // Save his points to add them to the jackpot - $data = SQL_FETCHARRAY($result); + $data = sqlFetchArray($result); // Delete points entries as well // @TODO Rewrite these lines to a filter - SQL_QUERY_ESC("DELETE LOW_PRIORITY FROM `{?_MYSQL_PREFIX?}_user_points` WHERE `userid`=%s", + sqlQueryEscaped("DELETE LOW_PRIORITY FROM `{?_MYSQL_PREFIX?}_user_points` WHERE `userid`=%s", array(bigintval($userid)), __FUNCTION__, __LINE__); // Update mediadata as well @@ -1464,16 +1525,16 @@ LIMIT 1", } // END - if // Free the result - SQL_FREERESULT($result); + sqlFreeResult($result); // Delete category selections as well... - SQL_QUERY_ESC("DELETE LOW_PRIORITY FROM `{?_MYSQL_PREFIX?}_user_cats` WHERE `userid`=%s", + sqlQueryEscaped("DELETE LOW_PRIORITY FROM `{?_MYSQL_PREFIX?}_user_cats` WHERE `userid`=%s", array(bigintval($userid)), __FUNCTION__, __LINE__); // Remove from rallye if found // @TODO Rewrite this to a filter if (isExtensionActive('rallye')) { - SQL_QUERY_ESC("DELETE LOW_PRIORITY FROM `{?_MYSQL_PREFIX?}_rallye_users` WHERE `userid`=%s", + sqlQueryEscaped("DELETE LOW_PRIORITY FROM `{?_MYSQL_PREFIX?}_rallye_users` WHERE `userid`=%s", array(bigintval($userid)), __FUNCTION__, __LINE__); } // END - if @@ -1485,7 +1546,7 @@ LIMIT 1", sendEmail($userid, '{--ADMIN_DELETE_ACCOUNT--}', $message); // Ok, delete the account! - SQL_QUERY_ESC("DELETE LOW_PRIORITY FROM `{?_MYSQL_PREFIX?}_user_data` WHERE `userid`=%s LIMIT 1", array(bigintval($userid)), __FUNCTION__, __LINE__); + sqlQueryEscaped("DELETE LOW_PRIORITY FROM `{?_MYSQL_PREFIX?}_user_data` WHERE `userid`=%s LIMIT 1", array(bigintval($userid)), __FUNCTION__, __LINE__); } // Gets the matching what name from module @@ -1536,7 +1597,7 @@ function generateCategoryOptionsList ($mode, $userid = NULL) { ); // Get categories - $result = SQL_QUERY('SELECT + $result = sqlQuery('SELECT `id`, `cat` FROM @@ -1547,15 +1608,15 @@ ORDER BY __FUNCTION__, __LINE__); // Are there entries? - if (!SQL_HASZERONUMS($result)) { + if (!ifSqlHasZeroNums($result)) { // ... and begin loading stuff - while ($content = SQL_FETCHARRAY($result)) { + while ($content = sqlFetchArray($result)) { // Transfer some data $categories['id'][] = $content['id']; array_push($categories['name'], $content['cat']); // Check which users are in this category - $result_userids = SQL_QUERY_ESC("SELECT `userid` FROM `{?_MYSQL_PREFIX?}_user_cats` WHERE `cat_id`=%s AND `userid` != %s ORDER BY `userid` ASC", + $result_userids = sqlQueryEscaped("SELECT `userid` FROM `{?_MYSQL_PREFIX?}_user_cats` WHERE `cat_id`=%s AND `userid` != %s ORDER BY `userid` ASC", array( bigintval($content['id']), convertNullToZero($userid) @@ -1565,20 +1626,20 @@ ORDER BY $userid_cnt = '0'; // Start adding all - while ($data = SQL_FETCHARRAY($result_userids)) { + while ($data = sqlFetchArray($result_userids)) { // Add user count $userid_cnt += countSumTotalData($data['userid'], 'user_data', 'userid', 'userid', TRUE, runFilterChain('user_exclusion_sql', " AND `status`='CONFIRMED' AND `receive_mails` > 0")); } // END - while // Free memory - SQL_FREERESULT($result_userids); + sqlFreeResult($result_userids); // Add counter array_push($categories['userids'], $userid_cnt); } // END - while // Free memory - SQL_FREERESULT($result); + sqlFreeResult($result); // Generate options $OUT = ''; @@ -1617,7 +1678,7 @@ function addBonusMailToQueue ($subject, $text, $receiverList, $points, $seconds, // HTML extension active? if (isExtensionActive('html_mail')) { // Add HTML mail - SQL_QUERY_ESC("INSERT INTO `{?_MYSQL_PREFIX?}_bonus` ( + sqlQueryEscaped("INSERT INTO `{?_MYSQL_PREFIX?}_bonus` ( `subject`, `text`, `receivers`, @@ -1658,7 +1719,7 @@ function addBonusMailToQueue ($subject, $text, $receiverList, $points, $seconds, ), __FUNCTION__, __LINE__); } else { // Add regular mail - SQL_QUERY_ESC("INSERT INTO `{?_MYSQL_PREFIX?}_bonus` ( + sqlQueryEscaped("INSERT INTO `{?_MYSQL_PREFIX?}_bonus` ( `subject`, `text`, `receivers`, @@ -1718,33 +1779,38 @@ function generateReceiverList ($categoryId, $receiver, $mode = '') { $addWhere = runFilterChain('user_exclusion_sql', ' '); // Category given? - if ($categoryId > 0) { + if (isValidId($categoryId)) { // Select category - $extraColumns = "LEFT JOIN `{?_MYSQL_PREFIX?}_user_cats` AS c ON d.`userid`=c.`userid`"; - $addWhere = sprintf(" AND c.`cat_id`=%s", $categoryId); + $extraColumns = "LEFT JOIN `{?_MYSQL_PREFIX?}_user_cats` AS `c` ON `d`.`userid`=`c`.`userid`"; + $addWhere = sprintf(" AND `c`.`cat_id`=%s", $categoryId); } // END - if // Exclude users in holiday? if (isExtensionInstalledAndNewer('holiday', '0.1.3')) { // Add something for the holiday extension - $addWhere .= " AND d.`holiday_active`='N'"; - } // END - if - - // Include only HTML recipients? - if ((isExtensionActive('html_mail')) && ($mode == 'html')) { - $addWhere .= " AND d.`html`='Y'"; + $addWhere .= " AND `d`.`holiday_active`='N'"; } // END - if // Run query - $result = SQL_QUERY_ESC("SELECT d.`userid` FROM `{?_MYSQL_PREFIX?}_user_data` AS d ".$extraColumns." WHERE d.`status`='CONFIRMED' ".$addWhere." ORDER BY d.`{?order_select?}` {?order_mode?} LIMIT %s", + $result = sqlQueryEscaped("SELECT + `d`.`userid` +FROM + `{?_MYSQL_PREFIX?}_user_data` AS `d` + " . $extraColumns . " +WHERE + `d`.`status`='CONFIRMED' + " . $addWhere . " +ORDER BY + `d`.`{?order_select?}` {?order_mode?} +LIMIT %s", array( $receiver ), __FUNCTION__, __LINE__); // Entries found? - if ((SQL_NUMROWS($result) >= $receiver) && ($receiver > 0)) { + if ((sqlNumRows($result) >= $receiver) && ($receiver > 0)) { // Load all entries - while ($content = SQL_FETCHARRAY($result)) { + while ($content = sqlFetchArray($result)) { // Add receiver when not empty if (!empty($content['userid'])) { $receiverList .= $content['userid'] . ';'; @@ -1752,7 +1818,7 @@ function generateReceiverList ($categoryId, $receiver, $mode = '') { } // END - while // Free memory - SQL_FREERESULT($result); + sqlFreeResult($result); // Remove trailing semicolon $receiverList = substr($receiverList, 0, -1); @@ -1765,23 +1831,28 @@ function generateReceiverList ($categoryId, $receiver, $mode = '') { // Recuce the amount of received emails for the receipients for given email function reduceRecipientReceivedMails ($column, $id, $count) { // Search for mail in database - $result = SQL_QUERY_ESC("SELECT * FROM `{?_MYSQL_PREFIX?}_user_links` WHERE `%s`=%s ORDER BY `userid` ASC LIMIT %s", - array($column, bigintval($id), $count), __FUNCTION__, __LINE__); + $result = sqlQueryEscaped("SELECT * FROM `{?_MYSQL_PREFIX?}_user_links` WHERE `%s`=%s ORDER BY `userid` ASC LIMIT %s", + array( + $column, + bigintval($id), + $count + ), __FUNCTION__, __LINE__ + ); // Are there entries? - if (!SQL_HASZERONUMS($result)) { + if (!ifSqlHasZeroNums($result)) { // Now load all userids for one big query! $userids = array(); - while ($data = SQL_FETCHARRAY($result)) { + while ($data = sqlFetchArray($result)) { // By default reduce and found no emails $num = 0; // We must now look if he has already confirmed this mail, so might sound double, but it may resolve problems // @TODO Rewrite this to a filter - if ((isset($data['stats_id'])) && ($data['stats_id'] > 0)) { + if ((isset($data['stats_id'])) && (isValidId($data['stats_id']))) { // User email $num = countSumTotalData($data['userid'], 'user_stats_data', 'id', 'userid', TRUE, sprintf(" AND `stats_type`='mailid' AND `stats_data`=%s", bigintval($data['stats_id']))); - } elseif ((isset($data['bonus_id'])) && ($data['bonus_id'] > 0)) { + } elseif ((isset($data['bonus_id'])) && (isValidId($data['bonus_id']))) { // Bonus mail $num = countSumTotalData($data['userid'], 'user_stats_data', 'id', 'userid', TRUE, sprintf(" AND `stats_type`='bonusid' AND `stats_data`=%s", bigintval($data['bonus_id']))); } @@ -1792,9 +1863,9 @@ function reduceRecipientReceivedMails ($column, $id, $count) { } // END - if } // END - while - if (count($userids) > 0) { + if (isFilledArray($userids)) { // Now update all user accounts - SQL_QUERY_ESC("UPDATE `{?_MYSQL_PREFIX?}_user_data` SET `emails_received`=`emails_received`-1 WHERE `userid` IN (%s) LIMIT %s", + sqlQueryEscaped("UPDATE `{?_MYSQL_PREFIX?}_user_data` SET `emails_received`=`emails_received`-1 WHERE `userid` IN (%s) LIMIT %s", array( implode(',', $userids), count($userids) @@ -1806,13 +1877,13 @@ function reduceRecipientReceivedMails ($column, $id, $count) { } // END - if // Free result - SQL_FREERESULT($result); + sqlFreeResult($result); } // Creates a new task function createNewTask ($subject, $notes, $taskType, $userid = NULL, $adminId = NULL, $strip = TRUE) { // Insert the task data into the database - SQL_QUERY_ESC("INSERT INTO `{?_MYSQL_PREFIX?}_task_system` (`assigned_admin`, `userid`, `status`, `task_type`, `subject`, `text`, `task_created`) VALUES (%s, %s, 'NEW', '%s', '%s', '%s', UNIX_TIMESTAMP())", + sqlQueryEscaped("INSERT INTO `{?_MYSQL_PREFIX?}_task_system` (`assigned_admin`, `userid`, `status`, `task_type`, `subject`, `text`, `task_created`) VALUES (%s, %s, 'NEW', '%s', '%s', '%s', UNIX_TIMESTAMP())", array( convertZeroToNull($adminId), convertZeroToNull($userid), @@ -1822,7 +1893,7 @@ function createNewTask ($subject, $notes, $taskType, $userid = NULL, $adminId = ), __FUNCTION__, __LINE__, TRUE, $strip); // Return insert id which is the task id - return SQL_INSERTID(); + return getSqlInsertId(); } // Updates last module / online time @@ -1830,7 +1901,7 @@ function updateLastActivity ($userid) { // Is 'what' set? if (isWhatSet()) { // Run the update query - SQL_QUERY_ESC("UPDATE + sqlQueryEscaped("UPDATE `{?_MYSQL_PREFIX?}_user_data` SET `{%%pipe,getUserLastWhatName%%}`='{%%pipe,getWhat%%}', @@ -1844,7 +1915,7 @@ LIMIT 1", ), __FUNCTION__, __LINE__); } else { // No what set, needs to be ignored (last_module is last_what) - SQL_QUERY_ESC("UPDATE + sqlQueryEscaped("UPDATE `{?_MYSQL_PREFIX?}_user_data` SET `{%%pipe,getUserLastWhatName%%}`=NULL, @@ -1859,13 +1930,13 @@ LIMIT 1", } } -// List all given rows (callback function from XML) -function doGenericListEntries ($tableTemplate, $rowTemplate, $noEntryMessageId, $tableName, $columns, $whereColumns, $orderByColumns, $callbackColumns, $extraParameters = array(), $conditions = array(), $content = array()) { +// List all given joined rows (callback function from XML) +function doGenericJoinedListEntries ($tableTemplate, $rowTemplate, $noEntryMessageId, $tableName, $tableJoinType, $tableJoinName, $joinOnLeftTable, $joinOnCondition, $joinOnRightTable, $columns, $whereColumns, $orderByColumns, $callbackColumns, $extraParameters = array(), $conditions = array(), $content = array()) { // Verify that tableName and columns are not empty if ((!is_array($tableName)) || (count($tableName) != 1)) { // No tableName specified reportBug(__FUNCTION__, __LINE__, 'tableName is not given. Please fix your XML,tableName[]=' . gettype($tableName) . '!=array,tableTemplate=' . $tableTemplate . ',rowTemplate=' . $rowTemplate); - } elseif (count($columns) == 0) { + } elseif (!isFilledArray($columns)) { // No columns specified reportBug(__FUNCTION__, __LINE__, 'columns is not given. Please fix your XML,tableTemplate=' . $tableTemplate . ',rowTemplate=' . $rowTemplate . ',tableName[0]=' . $tableName[0]); } @@ -1876,76 +1947,47 @@ function doGenericListEntries ($tableTemplate, $rowTemplate, $noEntryMessageId, // Get the sql part back from given array $sql .= getSqlPartFromXmlArray($columns); - // Remove last commata and add FROM statement - $sql .= ' FROM `{?_MYSQL_PREFIX?}_' . $tableName[0] . '`'; + // Add "FROM" + $sql .= getSqlXmlFromTable($tableName); - // Are there entries from whereColumns to add? - if (count($whereColumns) > 0) { - // Then add these as well - if (count($whereColumns) == 1) { - // One entry found - $sql .= ' WHERE '; + // Add "JOIN" + $sql .= getSqlXmlJoinedTable($tableJoinType, $tableJoinName, $joinOnLeftTable, $joinOnCondition, $joinOnRightTable); - // Table/alias included? - if (!empty($whereColumns[0]['table'])) { - // Add it as well - $sql .= $whereColumns[0]['table'] . '.'; - } // END - if + // Add "WHERE" + $sql .= getSqlXmlWhereConditions($whereColumns, $conditions); - // Add the rest - $sql .= '`' . $whereColumns[0]['column'] . '`' . $whereColumns[0]['condition'] . chr(39) . $whereColumns[0]['look_for'] . chr(39); - } elseif ((count($whereColumns > 1)) && (count($conditions) > 0)) { - // More than one "WHERE" + condition found - foreach ($whereColumns as $idx => $columnArray) { - // Default is WHERE - $condition = ' WHERE '; - - // Is the condition element there? - if (isset($conditions[$columnArray['column']])) { - // Assume the condition - $condition = ' ' . $conditions[$columnArray['column']] . ' '; - } // END - if + // Add "ORDER BY" + $sql .= getSqlXmlOrderBy($orderByColumns); - // Add to SQL query - $sql .= $condition; + // Now handle all over to the inner function which will execute the listing + doListEntries($sql, $tableTemplate, $noEntryMessageId, $rowTemplate, $callbackColumns, $extraParameters, $content); +} - // Table/alias included? - if (!empty($whereColumns[$idx]['table'])) { - // Add it as well - $sql .= $whereColumns[$idx]['table'] . '.'; - } // END - if +// List all given rows (callback function from XML) +function doGenericListEntries ($tableTemplate, $rowTemplate, $noEntryMessageId, $tableName, $columns, $whereColumns, $orderByColumns, $callbackColumns, $extraParameters = array(), $conditions = array(), $content = array()) { + // Verify that tableName and columns are not empty + if ((!is_array($tableName)) || (count($tableName) != 1)) { + // No tableName specified + reportBug(__FUNCTION__, __LINE__, 'tableName is not given. Please fix your XML,tableName[]=' . gettype($tableName) . '!=array,tableTemplate=' . $tableTemplate . ',rowTemplate=' . $rowTemplate); + } elseif (!isFilledArray($columns)) { + // No columns specified + reportBug(__FUNCTION__, __LINE__, 'columns is not given. Please fix your XML,tableTemplate=' . $tableTemplate . ',rowTemplate=' . $rowTemplate . ',tableName[0]=' . $tableName[0]); + } - // Add the rest - $sql .= '`' . $whereColumns[$idx]['column'] . '`' . $whereColumns[$idx]['condition'] . chr(39) . convertDollarDataToGetElement($whereColumns[$idx]['look_for']) . chr(39); - } // END - foreach - } else { - // Did not set $conditions - reportBug(__FUNCTION__, __LINE__, 'Supplied more than "whereColumns" entries but no conditions! Please fix your XML template.'); - } - } // END - if + // This is the minimum query, so at least columns and tableName must have entries + $sql = 'SELECT '; - // Are there entries from orderByColumns to add? - if (count($orderByColumns) > 0) { - // Add them as well - $sql .= ' ORDER BY '; - foreach ($orderByColumns as $orderByColumn => $array) { - // Get keys (table/alias) and values (sorting itself) - $table = trim(implode('', array_keys($array))); - $sorting = trim(implode('', array_values($array))); - - // table/alias can be omitted - if (!empty($table)) { - // table/alias is given - $sql .= $table . '.'; - } // END - if + // Get the sql part back from given array + $sql .= getSqlPartFromXmlArray($columns); - // Add order-by column - $sql .= '`' . $orderByColumn . '` ' . $sorting . ','; - } // END - foreach + // Add "FROM" + $sql .= getSqlXmlFromTable($tableName); - // Remove last column - $sql = substr($sql, 0, -1); - } // END - if + // Add "WHERE" + $sql .= getSqlXmlWhereConditions($whereColumns, $conditions); + + // Add "ORDER BY" + $sql .= getSqlXmlOrderBy($orderByColumns); // Now handle all over to the inner function which will execute the listing doListEntries($sql, $tableTemplate, $noEntryMessageId, $rowTemplate, $callbackColumns, $extraParameters, $content); @@ -1954,13 +1996,13 @@ function doGenericListEntries ($tableTemplate, $rowTemplate, $noEntryMessageId, // Do the listing of entries function doListEntries ($sql, $tableTemplate, $noEntryMessageId, $rowTemplate, $callbackColumns, $extraParameters = array(), $content = array()) { // Run the SQL query - $result = SQL_QUERY($sql, __FUNCTION__, __LINE__); + $result = sqlQuery($sql, __FUNCTION__, __LINE__); // Are there some URLs left? - if (!SQL_HASZERONUMS($result)) { + if (!ifSqlHasZeroNums($result)) { // List all URLs $OUT = ''; - while ($row = SQL_FETCHARRAY($result)) { + while ($row = sqlFetchArray($result)) { // "Translate" content foreach ($callbackColumns as $columnName => $callbackName) { // Fill the callback arguments @@ -1983,7 +2025,7 @@ function doListEntries ($sql, $tableTemplate, $noEntryMessageId, $rowTemplate, $ } // END - while // Is at least one entry set in content? - if ((is_array($content)) && (count($content) > 0)) { + if (isFilledArray($content)) { // Then add generic 'rows' element $content['rows'] = $OUT; } else { @@ -1999,7 +2041,7 @@ function doListEntries ($sql, $tableTemplate, $noEntryMessageId, $rowTemplate, $ } // Free result - SQL_FREERESULT($result); + sqlFreeResult($result); } // Adds a given entry to the database @@ -2009,7 +2051,7 @@ function doGenericAddEntries ($tableName, $columns = array(), $filterFunctions = if ((!is_array($tableName)) || (count($tableName) != 1)) { // No tableName specified reportBug(__FUNCTION__, __LINE__, 'tableName is not given. Please fix your XML,tableName[]=' . gettype($tableName) . '!=array: userIdColumn=' . $userIdColumn); - } elseif (count($columns) == 0) { + } elseif (!isFilledArray($columns)) { // No columns specified reportBug(__FUNCTION__, __LINE__, 'columns is not given. Please fix your XML.'); } @@ -2022,7 +2064,7 @@ function doGenericAddEntries ($tableName, $columns = array(), $filterFunctions = $GLOBALS['__XML_PARSE_RESULT'] = TRUE; // Is there "time columns"? - if (count($timeColumns) > 0) { + if (isFilledArray($timeColumns)) { // Then "walk" through all entries foreach ($timeColumns as $column) { // Convert all (possible) selections @@ -2046,15 +2088,24 @@ function doGenericAddEntries ($tableName, $columns = array(), $filterFunctions = // Debug message //* NOISY-DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'key=' . $key . ',columnName[' . gettype($columnName) . ']=' . $columnName . ',filterFunctions=' . $filterFunctions[$key] . ',extraValues=' . intval(isset($extraValues[$key])) . ',extraValuesName=' . intval(isset($extraValues[$columnName . '_list']))); + // Get value back (no array supported) + $value = postRequestElement($columnName); + + // Is this an array and element 0 is set? + if ((is_array($value)) && (isset($value[0]))) { + // Then only take this + $value = $value[0]; + } // END - if + // Copy entry securely to the final arrays - $sqlColumns[$key] = SQL_ESCAPE($columnName); - $sqlValues[$key] = SQL_ESCAPE(postRequestElement($columnName)); + $sqlColumns[$key] = sqlEscapeString($columnName); + $sqlValues[$key] = sqlEscapeString($value); // Search for it $search = key(search_array($columns, 'column', $columnName)); // Try to handle call-back functions and/or extra values on the list - //* DEBUG: */ outputHtml($key . '/' . $columnName . '='.print_r($columns,true).'search_array()='.print_r(search_array($columns, 'column', $columnName), true).''); + //* DEBUG: */ outputHtml($key . '/' . $columnName . '='.print_r($columns,true).'search_array()='.print_r(search_array($columns, 'column', $columnName), TRUE).''); //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'sqlValues[' . $key . '(' . gettype($key) . ')][' . gettype($sqlValues[$key]) . ']=' . $sqlValues[$key] . ' - BEFORE!'); if (is_string($key)) { // Key is a string @@ -2085,22 +2136,22 @@ function doGenericAddEntries ($tableName, $columns = array(), $filterFunctions = $sql = 'INSERT INTO `{?_MYSQL_PREFIX?}_' . $tableName[0] . '` (`' . implode('`, `', $sqlColumns) . "`) VALUES (" . implode(',', $sqlValues) . ')'; // Run the SQL query - SQL_QUERY($sql, __FUNCTION__, __LINE__); + sqlQuery($sql, __FUNCTION__, __LINE__); // Add id number - setPostRequestElement('id', SQL_INSERTID()); + setPostRequestElement('id', getSqlInsertId()); // Prepare filter data array $filterData = array( 'mode' => 'add', 'table_name' => $tableName, 'content' => postRequestArray(), - 'id' => SQL_INSERTID(), + 'id' => getSqlInsertId(), 'subject' => '', // @TODO Used generic 'userid' here 'userid_column' => array('userid'), 'raw_userid' => array('userid'), - 'affected' => SQL_AFFECTEDROWS(), + 'affected' => sqlAffectedRows(), 'sql' => $sql, ); @@ -2112,7 +2163,7 @@ function doGenericAddEntries ($tableName, $columns = array(), $filterFunctions = // Edit rows by given id numbers function doGenericEditEntriesConfirm ($tableName, $columns = array(), $filterFunctions = array(), $extraValues = array(), $timeColumns = array(), $editNow = array(FALSE), $idColumn = array('id'), $userIdColumn = array('userid'), $rawUserId = array('userid'), $cacheFiles = array(), $subject = '') { // Is there "time columns"? - if (count($timeColumns) > 0) { + if (isFilledArray($timeColumns)) { // Then "walk" through all entries foreach ($timeColumns as $column) { // Convert all (possible) selections @@ -2131,7 +2182,7 @@ function doGenericEditEntriesConfirm ($tableName, $columns = array(), $filterFun // Prepare SQL for this row $sql = sprintf("UPDATE `{?_MYSQL_PREFIX?}_%s` SET", - SQL_ESCAPE($tableName[0]) + sqlEscapeString($tableName[0]) ); // "Walk" through all entries @@ -2185,7 +2236,7 @@ function doGenericEditEntriesConfirm ($tableName, $columns = array(), $filterFun } // END - foreach // Finish SQL command - $sql = substr($sql, 0, -1) . " WHERE `" . SQL_ESCAPE($idColumn[0]) . "`=" . $id; + $sql = substr($sql, 0, -1) . " WHERE `" . sqlEscapeString($idColumn[0]) . "`=" . $id; if ((isset($rawUserId[0])) && (isset($userIdColumn[0])) && (isPostRequestElementSet($rawUserId[0])) && (!is_array(postRequestElement($rawUserId[0])))) { // Add user id as well $sql .= ' AND `' . $userIdColumn[0] . '`=' . bigintval(postRequestElement($rawUserId[0])); @@ -2194,14 +2245,14 @@ function doGenericEditEntriesConfirm ($tableName, $columns = array(), $filterFun // Run this query //* BUG: */ die($sql.''.print_r(postRequestArray(), TRUE).''); - SQL_QUERY($sql, __FUNCTION__, __LINE__); + sqlQuery($sql, __FUNCTION__, __LINE__); // Add affected rows - $edited = SQL_AFFECTEDROWS(); + $edited = sqlAffectedRows(); $affected += $edited; // Load all data from that id - $result = SQL_QUERY_ESC("SELECT * FROM `{?_MYSQL_PREFIX?}_%s` WHERE `%s`=%s LIMIT 1", + $result = sqlQueryEscaped("SELECT * FROM `{?_MYSQL_PREFIX?}_%s` WHERE `%s`=%s LIMIT 1", array( $tableName[0], $idColumn[0], @@ -2209,7 +2260,7 @@ function doGenericEditEntriesConfirm ($tableName, $columns = array(), $filterFun ), __FUNCTION__, __LINE__); // Fetch the data and merge it into $content - $content = merge_array($content, SQL_FETCHARRAY($result)); + $content = merge_array($content, sqlFetchArray($result)); // Prepare filter data array $filterData = array( @@ -2228,11 +2279,11 @@ function doGenericEditEntriesConfirm ($tableName, $columns = array(), $filterFun runFilterChain('send_build_mail', $filterData); // Free the result - SQL_FREERESULT($result); + sqlFreeResult($result); } // END - foreach // Delete cache? - if ((count($cacheFiles) > 0) && (!empty($cacheFiles[0]))) { + if ((isFilledArray($cacheFiles)) && (!empty($cacheFiles[0]))) { // Delete cache file(s) foreach ($cacheFiles as $cache) { // Skip any empty entries @@ -2241,11 +2292,8 @@ function doGenericEditEntriesConfirm ($tableName, $columns = array(), $filterFun continue; } // END - if - // Is the cache file loadable? - if ($GLOBALS['cache_instance']->loadCacheFile($cache)) { - // Then remove it - $GLOBALS['cache_instance']->removeCacheFile(); - } // END - if + // Use rebuildCache() to delete it + rebuildCache($cache); } // END - foreach } // END - if @@ -2276,7 +2324,7 @@ function doGenericDeleteEntriesConfirm ($tableName, $columns = array(), $filterF $idList = ''; foreach (postRequestElement($idColumn[0]) as $id => $sel) { // Is id zero? - if ($id == '0') { + if (!isValidId($id)) { // Then skip this continue; } // END - if @@ -2284,7 +2332,7 @@ function doGenericDeleteEntriesConfirm ($tableName, $columns = array(), $filterF // Is there a userid? if (isPostRequestElementSet($userIdColumn[0])) { // Load all data from that id - $result = SQL_QUERY_ESC("SELECT * FROM `{?_MYSQL_PREFIX?}_%s` WHERE `%s`=%s LIMIT 1", + $result = sqlQueryEscaped("SELECT * FROM `{?_MYSQL_PREFIX?}_%s` WHERE `%s`=%s LIMIT 1", array( $tableName[0], $idColumn[0], @@ -2292,10 +2340,10 @@ function doGenericDeleteEntriesConfirm ($tableName, $columns = array(), $filterF ), __FUNCTION__, __LINE__); // Fetch the data - $content = SQL_FETCHARRAY($result); + $content = sqlFetchArray($result); // Free the result - SQL_FREERESULT($result); + sqlFreeResult($result); // Send "build mails" out sendGenericBuildMails('delete', $tableName, $content, $id, '', $userIdColumn); @@ -2306,7 +2354,7 @@ function doGenericDeleteEntriesConfirm ($tableName, $columns = array(), $filterF } // END - foreach // Run the query - SQL_QUERY_ESC($sql, + sqlQueryEscaped($sql, array( $tableName[0], $idColumn[0], @@ -2314,7 +2362,7 @@ function doGenericDeleteEntriesConfirm ($tableName, $columns = array(), $filterF ), __FUNCTION__, __LINE__); // Return affected rows - return SQL_AFFECTEDROWS(); + return sqlAffectedRows(); } // Build a special template list @@ -2342,12 +2390,12 @@ function doGenericListBuilder ($prefix, $listType, $tableName, $columns, $filter $id = bigintval($id); // Get result from a given column array and table name - $result = SQL_RESULT_FROM_ARRAY($tableName[0], $columns, $idColumn[0], $id, __FUNCTION__, __LINE__); + $result = getSqlResultFromArray($tableName[0], $columns, $idColumn[0], $id, __FUNCTION__, __LINE__); // Is there one entry? - if (SQL_NUMROWS($result) == 1) { + if (sqlNumRows($result) == 1) { // Load all data - $row = SQL_FETCHARRAY($result); + $row = sqlFetchArray($result); // Filter all data foreach ($row as $key => $value) { @@ -2397,7 +2445,7 @@ function doGenericListBuilder ($prefix, $listType, $tableName, $columns, $filter } // END - foreach // Then list it - $OUT .= loadTemplate(sprintf("%s_%s_%s_row", + $OUT .= loadTemplate(sprintf('%s_%s_%s_row', $prefix, $listType, $tableName[0] @@ -2406,11 +2454,11 @@ function doGenericListBuilder ($prefix, $listType, $tableName, $columns, $filter } // END - if // Free the result - SQL_FREERESULT($result); + sqlFreeResult($result); } // END - foreach // Is there an entry in $content? - if ((is_array($content)) && (count($content) > 0)) { + if (isFilledArray($content)) { // Use generic 'rows' $content['rows'] = $OUT; } else { @@ -2419,48 +2467,15 @@ function doGenericListBuilder ($prefix, $listType, $tableName, $columns, $filter } // Load master template - loadTemplate(sprintf("%s_%s_%s", - $prefix, - $listType, - $tableName[0] + loadTemplate( + sprintf('%s_%s_%s', + $prefix, + $listType, + $tableName[0] ), FALSE, $content ); } -// Checks whether given URL is blacklisted -function isUrlBlacklisted ($url) { - // Mark it as not listed by default - $listed = FALSE; - - // Is black-listing enbaled? - if (!isUrlBlacklistEnabled()) { - // No, then all URLs are not in this list - return FALSE; - } elseif (!isset($GLOBALS['blacklist_data'][$url])) { - // Check black-list for given URL - $result = SQL_QUERY_ESC("SELECT UNIX_TIMESTAMP(`timestamp`) AS `blist_timestamp` FROM `{?_MYSQL_PREFIX?}_url_blacklist` WHERE `url`='%s' LIMIT 1", - array($url), __FILE__, __LINE__); - - // Is there an entry? - if (SQL_NUMROWS($result) == 1) { - // Jupp, we got one listed - $GLOBALS['blacklist_data'][$url] = SQL_FETCHARRAY($result); - - // Mark it as listed - $listed = TRUE; - } // END - if - - // Free result - SQL_FREERESULT($result); - } else { - // Is found in cache -> black-listed - $listed = TRUE; - } - - // Return result - return $listed; -} - // Adds key/value pair to a working SQL string together function addKeyValueSql ($key, $value) { // Init SQL @@ -2470,19 +2485,19 @@ function addKeyValueSql ($key, $value) { if (($value == 'NULL') || (is_null($value))) { // Add key with NULL $sql .= sprintf(' `%s`=NULL,', - SQL_ESCAPE($key) + sqlEscapeString($key) ); } elseif ((is_double($value)) || (is_float($value)) || (is_int($value))) { // Is a number, so addd it directly - $sql .= sprintf(" `%s`=%s,", - SQL_ESCAPE($key), + $sql .= sprintf(' `%s`=%s,', + sqlEscapeString($key), $value ); } else { // Else add the value escape'd $sql .= sprintf(" `%s`='%s',", - SQL_ESCAPE($key), - SQL_ESCAPE($value) + sqlEscapeString($key), + sqlEscapeString($value) ); }
'.print_r($columns,true).'
'.print_r(search_array($columns, 'column', $columnName), true).'
'.print_r(search_array($columns, 'column', $columnName), TRUE).'
'.print_r(postRequestArray(), TRUE).'