X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=inc%2Fmysql-manager.php;h=e377a6b3c1550698ac9d9675ec90394226879dc4;hb=7b067fa69c2c1b1514bda61d89fb9ff5c13ebbe5;hp=a1e6936b581d54e24673ce44f1e4a209720ba02e;hpb=16680c2d93b9df15ff01b6eb0b5c2fea04cfc9cd;p=mailer.git

diff --git a/inc/mysql-manager.php b/inc/mysql-manager.php
index a1e6936b58..e377a6b3c1 100644
--- a/inc/mysql-manager.php
+++ b/inc/mysql-manager.php
@@ -253,7 +253,7 @@ function checkModulePermissions ($mod = '') {
 
 			// Destroy cache here
 			// @TODO Rewrite this to a filter
-			if (getOutputMode() == '0') rebuildCacheFile('modules', 'modules');
+			if (getOutputMode() == 0) rebuildCacheFile('modules', 'modules');
 
 			// And reload data
 			unset($GLOBALS['module_status'][$mod]);
@@ -386,7 +386,7 @@ function addMenuDescription ($accessLevel, $FQFN, $return = false, $output = tru
 				//* DEBUG: */ outputHtml(__LINE__.'+'.$type."+<br />");
 				// Add closing div and br-tag
 				$OUT .= "</div><br />\n";
-				$GLOBALS['nav_depth'] = '0';
+				$GLOBALS['nav_depth'] = 0;
 
 				// Run the filter chain
 				$ret = runFilterChain('post_youhere_line', array('access_level' => $accessLevel, 'type' => $type, 'content' => ""));
@@ -766,9 +766,9 @@ function isEmailTaken ($email) {
 }
 
 // Validate the given menu action
-function isMenuActionValid ($mode, $action, $what, $UPDATE=false) {
+function isMenuActionValid ($mode, $action, $what, $updateEntry=false) {
 	// Is the cache entry there and we shall not update?
-	if ((isset($GLOBALS['action_valid'][$mode][$action][$what])) && ($UPDATE === false)) {
+	if ((isset($GLOBALS['action_valid'][$mode][$action][$what])) && ($updateEntry === false)) {
 		// Count cache hit
 		incrementStatsEntry('cache_hits');
 
@@ -784,7 +784,7 @@ function isMenuActionValid ($mode, $action, $what, $UPDATE=false) {
 	if ((!isAdmin()) && ($mode != 'admin')) $add = " AND `locked`='N'";
 
 	//* DEBUG: */ outputHtml(__LINE__.':'.$mode.'/'.$action.'/'.$what."*<br />");
-	if (($mode != 'admin') && ($UPDATE === true)) {
+	if (($mode != 'admin') && ($updateEntry === true)) {
 		// Update guest or member menu
 		$sql = SQL_QUERY_ESC("UPDATE `{?_MYSQL_PREFIX?}_%s_menu` SET counter=counter+1 WHERE `action`='%s' AND `what`='%s'".$add." LIMIT 1",
 			array($mode, $action, $what), __FUNCTION__, __LINE__, false);
@@ -800,7 +800,7 @@ function isMenuActionValid ($mode, $action, $what, $UPDATE=false) {
 
 	// Run SQL command
 	$result = SQL_QUERY($sql, __FUNCTION__, __LINE__);
-	if ($UPDATE === true) {
+	if ($updateEntry === true) {
 		// Check updated/affected rows
 		$ret = (SQL_AFFECTEDROWS() == 1);
 	} else {
@@ -939,13 +939,6 @@ function sendModeMails ($mod, $modes) {
 	loadTemplate('admin_settings_saved', false, $content);
 }
 
-// Update module counter
-function countModuleHit($mod) {
-	// Do count all other modules but not accesses on CSS file css.php!
-	SQL_QUERY_ESC("UPDATE `{?_MYSQL_PREFIX?}_mod_reg` SET `clicks`=`clicks`+1 WHERE `module`='%s' LIMIT 1",
-		array($mod), __FUNCTION__, __LINE__);
-}
-
 // Get action value from mode (admin/guest/member) and what-value
 function getModeAction ($mode, $what) {
 	// Init status
@@ -995,9 +988,8 @@ function getModeAction ($mode, $what) {
 	} elseif ((!isExtensionInstalled('sql_patches')) && ($mode != 'admin')) {
 		// No sql_patches installed, but maybe we need to register an admin?
 		if (isAdminRegistered()) {
-			// Redirect
-			// @TODO Why does this lead into an endless loop but we still need it???
-			// @TODO Commented out redirectToUrl('admin.php');
+			// Redirect to admin area
+			redirectToUrl('admin.php');
 		} // END - if
 	}
 
@@ -1011,7 +1003,7 @@ function getCategory ($cid) {
 	$ret = getMessage('_CATEGORY_404');
 
 	// Is the category id set?
-	if ($cid == '0') {
+	if ($cid == 0) {
 		// No category
 		$ret = getMessage('_CATEGORY_NONE');
 	} elseif ($cid > 0) {
@@ -1124,7 +1116,7 @@ function removeReceiver (&$receivers, $key, $userid, $pool_id, $stats_id = '', $
 function countSumTotalData ($search, $tableName, $lookFor = 'id', $whereStatement = 'userid', $countRows = false, $add = '') {
 	$ret = 0;
 	//* DEBUG: */ outputHtml($search.'/'.$tableName.'/'.$lookFor.'/'.$whereStatement.'/'.$add.'<br />');
-	if ((empty($search)) && ($search != '0')) {
+	if ((empty($search)) && ($search != 0)) {
 		// Count or sum whole table?
 		if ($countRows === true) {
 			// Count whole table
@@ -1159,7 +1151,7 @@ function countSumTotalData ($search, $tableName, $lookFor = 'id', $whereStatemen
 		$ret = '0.00000';
 	} elseif (''.$ret.'' == '') {
 		// Fix empty result
-		$ret = '0';
+		$ret = 0;
 	}
 
 	// Return value
@@ -1213,13 +1205,13 @@ function getReferalLevelPercents ($level) {
  * add_mode    = Add points only to $userid or also refs? (WARNING! Changing 'ref' to 'direct'
  *               for default value will cause no referal will get points ever!!!)
  */
-function addPointsThroughReferalSystem ($subject, $userid, $points, $sendNotify = false, $rid = '0', $locked = false, $add_mode = 'ref') {
+function addPointsThroughReferalSystem ($subject, $userid, $points, $sendNotify = false, $rid = 0, $locked = false, $add_mode = 'ref') {
 	//* DEBUG: */ outputHtml("----------------------- <font color=\"#00aa00\">".__FUNCTION__." - ENTRY</font> ------------------------<ul><li>\n");
 	// Convert mode to lower-case
 	$add_mode = strtolower($add_mode);
 
 	// When $userid = 0 add points to jackpot
-	if (($userid == '0') && (isExtensionActive('jackpot'))) {
+	if (($userid == 0) && (isExtensionActive('jackpot'))) {
 		// Add points to jackpot
 		addPointsToJackpot($points);
 		return;
@@ -1230,7 +1222,7 @@ function addPointsThroughReferalSystem ($subject, $userid, $points, $sendNotify
 		'subject'  => $subject,
 		'userid'   => $userid,
 		'points'   => $points,
-		'notify'   => $notify,
+		'notify'   => $sendNotify,
 		'rid'      => $rid,
 		'locked'   => $locked,
 		'mode'     => 'add',