X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=include%2FCore%2FConfig.php;h=4e5c1e3d04ca02e87a8d19344daa3f2e897c59d4;hb=16d4392573829b5b02db449778cdc4bc4b2e0cbc;hp=761d7f490ec6d34c7917bae4546692691ca01b6f;hpb=f9678bb6c3b178e50e7848f6008ad8cc0230ddc3;p=friendica.git

diff --git a/include/Core/Config.php b/include/Core/Config.php
index 761d7f490e..4e5c1e3d04 100644
--- a/include/Core/Config.php
+++ b/include/Core/Config.php
@@ -1,8 +1,11 @@
 <?php
 namespace Friendica\Core;
+
+use dbm;
+
 /**
  * @file include/Core/Config.php
- * 
+ *
  *  @brief Contains the class with methods for system configuration
  */
 
@@ -19,6 +22,9 @@ namespace Friendica\Core;
  */
 class Config {
 
+	private static $cache;
+	private static $in_db;
+
 	/**
 	 * @brief Loads all configuration values of family into a cached storage.
 	 *
@@ -29,22 +35,28 @@ class Config {
 	 *  The category of the configuration value
 	 * @return void
 	 */
-	public static function load($family) {
-		global $a;
+	public static function load($family = "config") {
+
+		// We don't preload "system" anymore.
+		// This reduces the number of database reads a lot.
+		if ($family === 'system') {
+			return;
+		}
+
+		$a = get_app();
 
 		$r = q("SELECT `v`, `k` FROM `config` WHERE `cat` = '%s'", dbesc($family));
-		if(count($r)) {
-			foreach($r as $rr) {
+		if (dbm::is_result($r)) {
+			foreach ($r as $rr) {
 				$k = $rr['k'];
 				if ($family === 'config') {
 					$a->config[$k] = $rr['v'];
 				} else {
 					$a->config[$family][$k] = $rr['v'];
+					self::$cache[$family][$k] = $rr['v'];
+					self::$in_db[$family][$k] = true;
 				}
 			}
-		} else if ($family != 'config') {
-			// Negative caching
-			$a->config[$family] = "!<unset>!";
 		}
 	}
 
@@ -70,40 +82,46 @@ class Config {
 	 *  If true the config is loaded from the db and not from the cache (default: false)
 	 * @return mixed Stored value or null if it does not exist
 	 */
-	public static function get($family, $key, $default_value=null, $refresh = false) {
+	public static function get($family, $key, $default_value = null, $refresh = false) {
 
-		global $a;
+		$a = get_app();
 
-		if(! $instore) {
-			// Looking if the whole family isn't set
-			if(isset($a->config[$family])) {
-				if($a->config[$family] === '!<unset>!') {
-					return $default_value;
-				}
-			}
+		if (!$refresh) {
 
-			if(isset($a->config[$family][$key])) {
-				if($a->config[$family][$key] === '!<unset>!') {
+			// Do we have the cached value? Then return it
+			if (isset(self::$cache[$family][$key])) {
+				if (self::$cache[$family][$key] === '!<unset>!') {
 					return $default_value;
+				} else {
+					return self::$cache[$family][$key];
 				}
-				return $a->config[$family][$key];
 			}
 		}
 
-		$ret = q("SELECT `v` FROM `config` WHERE `cat` = '%s' AND `k` = '%s' LIMIT 1",
+		$ret = q("SELECT `v` FROM `config` WHERE `cat` = '%s' AND `k` = '%s'",
 			dbesc($family),
 			dbesc($key)
 		);
-		if(count($ret)) {
+		if (dbm::is_result($ret)) {
 			// manage array value
-			$val = (preg_match("|^a:[0-9]+:{.*}$|s", $ret[0]['v'])?unserialize( $ret[0]['v']):$ret[0]['v']);
-			$a->config[$family][$key] = $val;
+			$val = (preg_match("|^a:[0-9]+:{.*}$|s", $ret[0]['v']) ? unserialize($ret[0]['v']) : $ret[0]['v']);
 
+			// Assign the value from the database to the cache
+			self::$cache[$family][$key] = $val;
+			self::$in_db[$family][$key] = true;
 			return $val;
+		} elseif (isset($a->config[$family][$key])) {
+
+			// Assign the value (mostly) from the .htconfig.php to the cache
+			self::$cache[$family][$key] = $a->config[$family][$key];
+			self::$in_db[$family][$key] = false;
+
+			return $a->config[$family][$key];
 		}
-		else {
-			$a->config[$family][$key] = '!<unset>!';
-		}
+
+		self::$cache[$family][$key] = '!<unset>!';
+		self::$in_db[$family][$key] = false;
+
 		return $default_value;
 	}
 
@@ -123,42 +141,50 @@ class Config {
 	 *  The value to store
 	 * @return mixed Stored $value or false if the database update failed
 	 */
-	public static function set($family,$key,$value) {
-		global $a;
+	public static function set($family, $key, $value) {
+		$a = get_app();
+
+		// We store our setting values in a string variable.
+		// So we have to do the conversion here so that the compare below works.
+		// The exception are array values.
+		$dbvalue = (!is_array($value) ? (string)$value : $value);
 
-		// If $a->config[$family] has been previously set to '!<unset>!', then
-		// $a->config[$family][$key] will evaluate to $a->config[$family][0], and
-		// $a->config[$family][$key] = $value will be equivalent to
-		// $a->config[$family][0] = $value[0] (this causes infuriating bugs),
-		// so unset the family before assigning a value to a family's key
-		if($a->config[$family] === '!<unset>!')
-			unset($a->config[$family]);
+		$stored = self::get($family, $key, null, true);
+
+		if (($stored === $dbvalue) AND self::$in_db[$family][$key]) {
+			return true;
+		}
+
+		if ($family === 'config') {
+			$a->config[$key] = $dbvalue;
+		} elseif ($family != 'system') {
+			$a->config[$family][$key] = $dbvalue;
+		}
+
+		// Assign the just added value to the cache
+		self::$cache[$family][$key] = $dbvalue;
 
 		// manage array value
-		$dbvalue = (is_array($value)?serialize($value):$value);
-		$dbvalue = (is_bool($dbvalue) ? intval($dbvalue) : $dbvalue);
-		if(is_null(self::get($family,$key,null,true))) {
-			$a->config[$family][$key] = $value;
-			$ret = q("INSERT INTO `config` ( `cat`, `k`, `v` ) VALUES ( '%s', '%s', '%s' ) ",
+		$dbvalue = (is_array($value) ? serialize($value) : $dbvalue);
+
+		if (is_null($stored) OR !self::$in_db[$family][$key]) {
+			$ret = q("INSERT INTO `config` (`cat`, `k`, `v`) VALUES ('%s', '%s', '%s') ON DUPLICATE KEY UPDATE `v` = '%s'",
 				dbesc($family),
 				dbesc($key),
+				dbesc($dbvalue),
 				dbesc($dbvalue)
 			);
-			if($ret)
-				return $value;
-			return $ret;
+		} else {
+			$ret = q("UPDATE `config` SET `v` = '%s' WHERE `cat` = '%s' AND `k` = '%s'",
+				dbesc($dbvalue),
+				dbesc($family),
+				dbesc($key)
+			);
 		}
-
-		$ret = q("UPDATE `config` SET `v` = '%s' WHERE `cat` = '%s' AND `k` = '%s'",
-			dbesc($dbvalue),
-			dbesc($family),
-			dbesc($key)
-		);
-
-		$a->config[$family][$key] = $value;
-
-		if($ret)
+		if ($ret) {
+			self::$in_db[$family][$key] = true;
 			return $value;
+		}
 		return $ret;
 	}
 
@@ -174,11 +200,12 @@ class Config {
 	 *  The configuration key to delete
 	 * @return mixed
 	 */
-	public static function delete($family,$key) {
+	public static function delete($family, $key) {
 
-		global $a;
-		if(x($a->config[$family],$key))
-			unset($a->config[$family][$key]);
+		if (isset(self::$cache[$family][$key])) {
+			unset(self::$cache[$family][$key]);
+			unset(self::$in_db[$family][$key]);
+		}
 		$ret = q("DELETE FROM `config` WHERE `cat` = '%s' AND `k` = '%s'",
 			dbesc($family),
 			dbesc($key)
@@ -186,5 +213,4 @@ class Config {
 
 		return $ret;
 	}
-
 }