X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=include%2Fconversation.php;h=0fc43fb090abca4173e1cad9d232097b0dabf354;hb=97d31255e5f0eb62adefc6b3cf3a037da49e94fb;hp=90634f4905856bfcb935b484f01e17792929fa56;hpb=010cf3b1e8b5119ab5b8a742a90b3b9af5a27f05;p=friendica.git diff --git a/include/conversation.php b/include/conversation.php index 90634f4905..0fc43fb090 100644 --- a/include/conversation.php +++ b/include/conversation.php @@ -21,7 +21,6 @@ use Friendica\Util\DateTimeFormat; use Friendica\Util\Temporal; use Friendica\Util\XML; -require_once "include/bbcode.php"; require_once "include/acl_selectors.php"; function item_extract_images($body) { @@ -39,7 +38,7 @@ function item_extract_images($body) { $img_st_close++; // make it point to AFTER the closing bracket $img_end += $img_start; - if (! strcmp(substr($orig_body, $img_start + $img_st_close, 5), 'data:')) { + if (!strcmp(substr($orig_body, $img_start + $img_st_close, 5), 'data:')) { // This is an embedded image $saved_image[$cnt] = substr($orig_body, $img_start + $img_st_close, $img_end - ($img_start + $img_st_close)); @@ -214,7 +213,7 @@ function localize_item(&$item) { } if (stristr($item['verb'], ACTIVITY_POKE)) { $verb = urldecode(substr($item['verb'],strpos($item['verb'],'#')+1)); - if (! $verb) { + if (!$verb) { return; } if ($item['object-type']=="" || $item['object-type']!== ACTIVITY_OBJ_PERSON) { @@ -339,7 +338,7 @@ function localize_item(&$item) { $matches = null; if (preg_match_all('/@\[url=(.*?)\]/is', $item['body'], $matches, PREG_SET_ORDER)) { foreach ($matches as $mtch) { - if (! strpos($mtch[1], 'zrl=')) { + if (!strpos($mtch[1], 'zrl=')) { $item['body'] = str_replace($mtch[0], '@[url=' . Profile::zrl($mtch[1]) . ']', $item['body']); } } @@ -374,7 +373,7 @@ function count_descendants($item) { if ($total > 0) { foreach ($item['children'] as $child) { - if (! visible_activity($child)) { + if (!visible_activity($child)) { $total --; } $total += count_descendants($child); @@ -398,7 +397,7 @@ function visible_activity($item) { } if (activity_match($item['verb'], ACTIVITY_FOLLOW) && $item['object-type'] === ACTIVITY_OBJ_NOTE) { - if (! (($item['self']) && ($item['uid'] == local_user()))) { + if (!($item['self'] && ($item['uid'] == local_user()))) { return false; } } @@ -440,14 +439,13 @@ These Fields are not added below (yet). They are here to for bug search. `item`.`forum_mode`, `item`.`mention`, `item`.`global`, -`item`.`gcontact-id`, `item`.`shadow`, */ return "`item`.`author-id`, `item`.`author-link`, `item`.`author-name`, `item`.`author-avatar`, `item`.`owner-id`, `item`.`owner-link`, `item`.`owner-name`, `item`.`owner-avatar`, `item`.`contact-id`, `item`.`uid`, `item`.`id`, `item`.`parent`, - `item`.`uri`, `item`.`thr-parent`, `item`.`parent-uri`, + `item`.`uri`, `item`.`thr-parent`, `item`.`parent-uri`, `item`.`content-warning`, `item`.`commented`, `item`.`created`, `item`.`edited`, `item`.`received`, `item`.`verb`, `item`.`object-type`, `item`.`postopts`, `item`.`plink`, `item`.`guid`, `item`.`wall`, `item`.`private`, `item`.`starred`, @@ -498,8 +496,7 @@ function item_condition() { * that are based on unique features of the calling module. * */ -function conversation(App $a, $items, $mode, $update, $preview = false) { - require_once 'include/bbcode.php'; +function conversation(App $a, $items, $mode, $update, $preview = false, $order = 'commented') { require_once 'mod/proxy.php'; $ssl_state = ((local_user()) ? true : false); @@ -523,6 +520,7 @@ function conversation(App $a, $items, $mode, $update, $preview = false) { $previewing = (($preview) ? ' preview ' : ''); if ($mode === 'network') { + $items = conversation_add_children($items, false, $order); $profile_owner = local_user(); if (!$update) { /* @@ -583,7 +581,7 @@ function conversation(App $a, $items, $mode, $update, $preview = false) { . " var profile_page = 1; "; } } elseif ($mode === 'community') { - $items = community_add_items($items); + $items = conversation_add_children($items, true, $order); $profile_owner = 0; if (!$update) { $live_update_div = '
' . "\r\n" @@ -638,6 +636,10 @@ function conversation(App $a, $items, $mode, $update, $preview = false) { foreach ($items as $item) { + if (!visible_activity($item)) { + continue; + } + if ($arr_blocked) { $blocked = false; foreach ($arr_blocked as $b) { @@ -663,8 +665,8 @@ function conversation(App $a, $items, $mode, $update, $preview = false) { continue; } - $profile_name = ((strlen($item['author-name'])) ? $item['author-name'] : $item['name']); - if ($item['author-link'] && (! $item['author-name'])) { + $profile_name = (strlen($item['author-name']) ? $item['author-name'] : $item['name']); + if ($item['author-link'] && !$item['author-name']) { $profile_name = $item['author-link']; } @@ -856,7 +858,7 @@ function conversation(App $a, $items, $mode, $update, $preview = false) { continue; } - if (! visible_activity($item)) { + if (!visible_activity($item)) { continue; } @@ -902,15 +904,23 @@ function conversation(App $a, $items, $mode, $update, $preview = false) { * * @return array items with parents and comments */ -function community_add_items($parents) { - $max_comments = Config::get("system", "max_comments", 100); +function conversation_add_children($parents, $block_authors, $order) { + $max_comments = Config::get('system', 'max_comments', 100); + + if ($max_comments > 0) { + $limit = ' LIMIT '.intval($max_comments + 1); + } else { + $limit = ''; + } $items = []; + $block_sql = $block_authors ? "AND NOT `author`.`hidden` AND NOT `author`.`blocked`" : ""; + foreach ($parents AS $parent) { $thread_items = dba::p(item_query()." AND `item`.`uid` = ? - AND `item`.`parent-uri` = ? - ORDER BY `item`.`commented` DESC LIMIT ".intval($max_comments + 1), + AND `item`.`parent-uri` = ? $block_sql + ORDER BY `item`.`commented` DESC" . $limit, local_user(), $parent['uri'] ); @@ -951,7 +961,7 @@ function community_add_items($parents) { } } - $items = conv_sort($items, "`commented`"); + $items = conv_sort($items, $order); return $items; } @@ -984,7 +994,7 @@ function best_link_url($item, &$sparkle, $url = '') { } } } - if (! $best_url) { + if (!$best_url) { if ($url != '') { $best_url = $url; } elseif (strlen($item['author-link'])) { @@ -1007,7 +1017,7 @@ function item_photo_menu($item) { $photos_link = ''; $posts_link = ''; - if ((local_user()) && local_user() == $item['uid'] && $item['parent'] == $item['id'] && (! $item['self'])) { + if (local_user() && local_user() == $item['uid'] && $item['parent'] == $item['id'] && !$item['self']) { $sub_link = 'javascript:dosubthread(' . $item['id'] . '); return false;'; } @@ -1120,9 +1130,9 @@ function builtin_activity_puller($item, &$conv_responses) { return; } - if ((activity_match($item['verb'], $verb)) && ($item['id'] != $item['parent'])) { + if (activity_match($item['verb'], $verb) && ($item['id'] != $item['parent'])) { $url = $item['author-link']; - if ((local_user()) && (local_user() == $item['uid']) && ($item['network'] === NETWORK_DFRN) && (! $item['self']) && (link_compare($item['author-link'], $item['url']))) { + if (local_user() && (local_user() == $item['uid']) && ($item['network'] === NETWORK_DFRN) && !$item['self'] && link_compare($item['author-link'], $item['url'])) { $url = 'redir/' . $item['contact-id']; $sparkle = ' class="sparkle" '; } else { @@ -1131,12 +1141,12 @@ function builtin_activity_puller($item, &$conv_responses) { $url = '' . htmlentities($item['author-name']) . ''; - if (! $item['thr-parent']) { + if (!$item['thr-parent']) { $item['thr-parent'] = $item['parent-uri']; } - if (! ((isset($conv_responses[$mode][$item['thr-parent'] . '-l'])) - && (is_array($conv_responses[$mode][$item['thr-parent'] . '-l'])))) { + if (!(isset($conv_responses[$mode][$item['thr-parent'] . '-l']) + && is_array($conv_responses[$mode][$item['thr-parent'] . '-l']))) { $conv_responses[$mode][$item['thr-parent'] . '-l'] = []; } @@ -1145,7 +1155,7 @@ function builtin_activity_puller($item, &$conv_responses) { continue; } - if (! isset($conv_responses[$mode][$item['thr-parent']])) { + if (!isset($conv_responses[$mode][$item['thr-parent']])) { $conv_responses[$mode][$item['thr-parent']] = 1; } else { $conv_responses[$mode][$item['thr-parent']] ++; @@ -1237,7 +1247,7 @@ function format_like($cnt, array $arr, $type, $id) { break; case 'attendmaybe': $phrase = L10n::t('%2$d people attend maybe', $spanatts, $cnt); - $explikers = L10n::t('%s anttend maybe.', $likers); + $explikers = L10n::t('%s attend maybe.', $likers); break; } @@ -1472,7 +1482,7 @@ function add_children_to_list(array $children, array &$item_list) */ function smart_flatten_conversation(array $parent) { - if (! isset($parent['children']) || count($parent['children']) == 0) { + if (!isset($parent['children']) || count($parent['children']) == 0) { return $parent; } @@ -1635,7 +1645,7 @@ function get_responses($conv_responses, $response_verbs, $ob, $item) { foreach ($response_verbs as $v) { $ret[$v] = []; $ret[$v]['count'] = defaults($conv_responses[$v], $item['uri'], ''); - $ret[$v]['list'] = defaults($conv_responses[$v], $item['uri'] . '-l', ''); + $ret[$v]['list'] = defaults($conv_responses[$v], $item['uri'] . '-l', []); $ret[$v]['self'] = defaults($conv_responses[$v], $item['uri'] . '-self', '0'); if (count($ret[$v]['list']) > MAX_LIKERS) { $ret[$v]['list_part'] = array_slice($ret[$v]['list'], 0, MAX_LIKERS);