X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=include%2Fconversation.php;h=cd635521e51516545e43e937c4e294a252a4b3e6;hb=6e10bdf3611723dd2f2021ab766c6eb0d097b879;hp=31920c2fcb163e4e7864cace513afa8148ce4cfe;hpb=4ae37c61966a7f4c055369ee8fd0d4bc20808fdb;p=friendica.git diff --git a/include/conversation.php b/include/conversation.php index 31920c2fcb..cd635521e5 100644 --- a/include/conversation.php +++ b/include/conversation.php @@ -6,12 +6,15 @@ use Friendica\App; use Friendica\Content\ContactSelector; use Friendica\Content\Feature; +use Friendica\Content\Pager; use Friendica\Content\Text\BBCode; use Friendica\Core\Addon; use Friendica\Core\Config; use Friendica\Core\L10n; +use Friendica\Core\Logger; use Friendica\Core\PConfig; use Friendica\Core\Protocol; +use Friendica\Core\Renderer; use Friendica\Core\System; use Friendica\Database\DBA; use Friendica\Model\Contact; @@ -24,6 +27,7 @@ use Friendica\Util\DateTimeFormat; use Friendica\Util\Proxy as ProxyUtils; use Friendica\Util\Temporal; use Friendica\Util\XML; +use Friendica\Util\Crypto; function item_extract_images($body) { @@ -192,7 +196,7 @@ function localize_item(&$item) $xmlhead="<"."?xml version='1.0' encoding='UTF-8' ?".">"; $obj = XML::parseString($xmlhead.$item['object']); - $links = XML::parseString($xmlhead."".unxmlify($obj->link).""); + $links = XML::parseString($xmlhead."".XML::unescape($obj->link).""); $Bname = $obj->title; $Blink = ""; @@ -353,7 +357,8 @@ function localize_item(&$item) $author = ['uid' => 0, 'id' => $item['author-id'], 'network' => $item['author-network'], 'url' => $item['author-link']]; - if (!empty($item['plink'])) { + // Only create a redirection to a magic link when logged in + if (!empty($item['plink']) && (local_user() || remote_user())) { $item['plink'] = Contact::magicLinkbyContact($author, $item['plink']); } } @@ -432,8 +437,8 @@ function conv_get_blocklist() * that are based on unique features of the calling module. * */ -function conversation(App $a, array $items, $mode, $update, $preview = false, $order = 'commented', $uid = 0) { - +function conversation(App $a, array $items, Pager $pager, $mode, $update, $preview = false, $order = 'commented', $uid = 0) +{ $ssl_state = (local_user() ? true : false); $profile_owner = 0; @@ -468,7 +473,7 @@ function conversation(App $a, array $items, $mode, $update, $preview = false, $o . ((x($_GET, 'cmax')) ? '&cmax=' . $_GET['cmax'] : '') . ((x($_GET, 'file')) ? '&file=' . $_GET['file'] : '') - . "'; var profile_page = " . $a->pager['page'] . "; \r\n"; + . "'; var profile_page = " . $pager->getPage() . "; \r\n"; } } elseif ($mode === 'profile') { $items = conversation_add_children($items, false, $order, $uid); @@ -487,7 +492,7 @@ function conversation(App $a, array $items, $mode, $update, $preview = false, $o $live_update_div = '
' . "\r\n" . "\r\n"; + . "; var netargs = '?f='; var profile_page = " . $pager->getPage() . "; \r\n"; } } } elseif ($mode === 'notes') { @@ -497,7 +502,7 @@ function conversation(App $a, array $items, $mode, $update, $preview = false, $o if (!$update) { $live_update_div = '
' . "\r\n" . "\r\n"; + . "; var netargs = '/?f='; var profile_page = " . $pager->getPage() . "; \r\n"; } } elseif ($mode === 'display') { $items = conversation_add_children($items, false, $order, $uid); @@ -515,7 +520,7 @@ function conversation(App $a, array $items, $mode, $update, $preview = false, $o if (!$update) { $live_update_div = '
' . "\r\n" . "\r\n"; + ."/?f='; var profile_page = " . $pager->getPage() . "; \r\n"; } } elseif ($mode === 'contacts') { $items = conversation_add_children($items, true, $order, $uid); @@ -524,7 +529,7 @@ function conversation(App $a, array $items, $mode, $update, $preview = false, $o if (!$update) { $live_update_div = '
' . "\r\n" . "\r\n"; + ."/?f='; var profile_page = " . $pager->getPage() . "; \r\n"; } } elseif ($mode === 'search') { $live_update_div = '' . "\r\n"; @@ -533,7 +538,7 @@ function conversation(App $a, array $items, $mode, $update, $preview = false, $o $page_dropping = ((local_user() && local_user() == $profile_owner) ? true : false); if (!$update) { - $_SESSION['return_url'] = $a->query_string; + $_SESSION['return_path'] = $a->query_string; } $cb = ['items' => $items, 'mode' => $mode, 'update' => $update, 'preview' => $preview]; @@ -550,7 +555,7 @@ function conversation(App $a, array $items, $mode, $update, $preview = false, $o $threads = []; $threadsid = -1; - $page_template = get_markup_template("conversation.tpl"); + $page_template = Renderer::getMarkupTemplate("conversation.tpl"); if (!empty($items)) { if (in_array($mode, ['community', 'contacts'])) { @@ -709,7 +714,7 @@ function conversation(App $a, array $items, $mode, $update, $preview = false, $o } } else { // Normal View - $page_template = get_markup_template("threaded_conversation.tpl"); + $page_template = Renderer::getMarkupTemplate("threaded_conversation.tpl"); $conv = new Thread($mode, $preview, $writable); @@ -749,13 +754,13 @@ function conversation(App $a, array $items, $mode, $update, $preview = false, $o $threads = $conv->getTemplateData($conv_responses); if (!$threads) { - logger('[ERROR] conversation : Failed to get template data.', LOGGER_DEBUG); + Logger::log('[ERROR] conversation : Failed to get template data.', Logger::DEBUG); $threads = []; } } } - $o = replace_macros($page_template, [ + $o = Renderer::replaceMacros($page_template, [ '$baseurl' => System::baseUrl($ssl_state), '$return_path' => $a->query_string, '$live_update' => $live_update_div, @@ -1059,7 +1064,7 @@ function format_like($cnt, array $arr, $type, $id) { } $phrase .= EOL ; - $o .= replace_macros(get_markup_template('voting_fakelink.tpl'), [ + $o .= Renderer::replaceMacros(Renderer::getMarkupTemplate('voting_fakelink.tpl'), [ '$phrase' => $phrase, '$type' => $type, '$id' => $id @@ -1073,18 +1078,16 @@ function status_editor(App $a, $x, $notes_cid = 0, $popup = false) { $o = ''; - $geotag = x($x, 'allow_location') ? replace_macros(get_markup_template('jot_geotag.tpl'), []) : ''; + $geotag = x($x, 'allow_location') ? Renderer::replaceMacros(Renderer::getMarkupTemplate('jot_geotag.tpl'), []) : ''; - $tpl = get_markup_template('jot-header.tpl'); - $a->page['htmlhead'] .= replace_macros($tpl, [ + $tpl = Renderer::getMarkupTemplate('jot-header.tpl'); + $a->page['htmlhead'] .= Renderer::replaceMacros($tpl, [ '$newpost' => 'true', '$baseurl' => System::baseUrl(true), '$geotag' => $geotag, '$nickname' => $x['nickname'], '$ispublic' => L10n::t('Visible to everybody'), - '$linkurl' => L10n::t('Please enter a link URL:'), - '$vidurl' => L10n::t("Please enter a video link/URL:"), - '$audurl' => L10n::t("Please enter an audio link/URL:"), + '$linkurl' => L10n::t('Please enter a image/video/audio/webpage URL:'), '$term' => L10n::t('Tag term:'), '$fileas' => L10n::t('Save to Folder:'), '$whereareu' => L10n::t('Where are you right now?'), @@ -1116,10 +1119,10 @@ function status_editor(App $a, $x, $notes_cid = 0, $popup = false) $public_post_link = '&public=1'; } - // $tpl = replace_macros($tpl,array('$jotplugins' => $jotplugins)); - $tpl = get_markup_template("jot.tpl"); + // $tpl = Renderer::replaceMacros($tpl,array('$jotplugins' => $jotplugins)); + $tpl = Renderer::getMarkupTemplate("jot.tpl"); - $o .= replace_macros($tpl,[ + $o .= Renderer::replaceMacros($tpl,[ '$new_post' => L10n::t('New Post'), '$return_path' => $query_str, '$action' => 'item', @@ -1128,12 +1131,14 @@ function status_editor(App $a, $x, $notes_cid = 0, $popup = false) '$shortupload' => L10n::t('upload photo'), '$attach' => L10n::t('Attach file'), '$shortattach' => L10n::t('attach file'), - '$weblink' => L10n::t('Insert web link'), - '$shortweblink' => L10n::t('web link'), - '$video' => L10n::t('Insert video link'), - '$shortvideo' => L10n::t('video link'), - '$audio' => L10n::t('Insert audio link'), - '$shortaudio' => L10n::t('audio link'), + '$edbold' => L10n::t('Bold'), + '$editalic' => L10n::t('Italic'), + '$eduline' => L10n::t('Underline'), + '$edquote' => L10n::t('Quote'), + '$edcode' => L10n::t('Code'), + '$edimg' => L10n::t('Image'), + '$edurl' => L10n::t('Link'), + '$edattach' => L10n::t('Link or Media'), '$setloc' => L10n::t('Set your location'), '$shortsetloc' => L10n::t('set location'), '$noloc' => L10n::t('Clear browser location'), @@ -1162,7 +1167,7 @@ function status_editor(App $a, $x, $notes_cid = 0, $popup = false) '$notes_cid' => $notes_cid, '$sourceapp' => L10n::t($a->sourcename), '$cancel' => L10n::t('Cancel'), - '$rand_num' => random_digits(12), + '$rand_num' => Crypto::randomDigits(12), // ACL permissions box '$acl' => $x['acl'],