X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=include%2Fdiaspora2.php;h=f6b8b9a704165e976f9d05a8a97c22ca06ec0f0c;hb=75f5cfe63e2d84fbe55384a7b2769c55bbf423b6;hp=1cc6e55e3bd9b27c29419a9ae97643f89278df38;hpb=db15f76177fedd9620ed62518d4c11c6ac493107;p=friendica.git diff --git a/include/diaspora2.php b/include/diaspora2.php index 1cc6e55e3b..f6b8b9a704 100644 --- a/include/diaspora2.php +++ b/include/diaspora2.php @@ -20,7 +20,7 @@ require_once("include/datetime.php"); */ class diaspora { - public static function fetch_relay() { + public static function relay_list() { $serverdata = get_config("system", "relay_server"); if ($serverdata == "") @@ -64,6 +64,168 @@ class diaspora { return $relay; } + function repair_signature($signature, $handle = "", $level = 1) { + + if ($signature == "") + return ($signature); + + if (base64_encode(base64_decode(base64_decode($signature))) == base64_decode($signature)) { + $signature = base64_decode($signature); + logger("Repaired double encoded signature from Diaspora/Hubzilla handle ".$handle." - level ".$level, LOGGER_DEBUG); + + // Do a recursive call to be able to fix even multiple levels + if ($level < 10) + $signature = self::repair_signature($signature, $handle, ++$level); + } + + return($signature); + } + + /** + * @brief: Decodes incoming Diaspora message + * + * @param array $importer from user table + * @param string $xml urldecoded Diaspora salmon + * + * @return array + * 'message' -> decoded Diaspora XML message + * 'author' -> author diaspora handle + * 'key' -> author public key (converted to pkcs#8) + */ + function decode($importer, $xml) { + + $public = false; + $basedom = parse_xml_string($xml); + + if (!is_object($basedom)) + return false; + + $children = $basedom->children('https://joindiaspora.com/protocol'); + + if($children->header) { + $public = true; + $author_link = str_replace('acct:','',$children->header->author_id); + } else { + + $encrypted_header = json_decode(base64_decode($children->encrypted_header)); + + $encrypted_aes_key_bundle = base64_decode($encrypted_header->aes_key); + $ciphertext = base64_decode($encrypted_header->ciphertext); + + $outer_key_bundle = ''; + openssl_private_decrypt($encrypted_aes_key_bundle,$outer_key_bundle,$importer['prvkey']); + + $j_outer_key_bundle = json_decode($outer_key_bundle); + + $outer_iv = base64_decode($j_outer_key_bundle->iv); + $outer_key = base64_decode($j_outer_key_bundle->key); + + $decrypted = mcrypt_decrypt(MCRYPT_RIJNDAEL_128, $outer_key, $ciphertext, MCRYPT_MODE_CBC, $outer_iv); + + + $decrypted = pkcs5_unpad($decrypted); + + /** + * $decrypted now contains something like + * + * + * 8e+G2+ET8l5BPuW0sVTnQw== + * UvSMb4puPeB14STkcDWq+4QE302Edu15oaprAQSkLKU= + * galaxor@diaspora.priateship.org + * + */ + + logger('decrypted: '.$decrypted, LOGGER_DEBUG); + $idom = parse_xml_string($decrypted,false); + + $inner_iv = base64_decode($idom->iv); + $inner_aes_key = base64_decode($idom->aes_key); + + $author_link = str_replace('acct:','',$idom->author_id); + } + + $dom = $basedom->children(NAMESPACE_SALMON_ME); + + // figure out where in the DOM tree our data is hiding + + if($dom->provenance->data) + $base = $dom->provenance; + elseif($dom->env->data) + $base = $dom->env; + elseif($dom->data) + $base = $dom; + + if (!$base) { + logger('unable to locate salmon data in xml'); + http_status_exit(400); + } + + + // Stash the signature away for now. We have to find their key or it won't be good for anything. + $signature = base64url_decode($base->sig); + + // unpack the data + + // strip whitespace so our data element will return to one big base64 blob + $data = str_replace(array(" ","\t","\r","\n"),array("","","",""),$base->data); + + + // stash away some other stuff for later + + $type = $base->data[0]->attributes()->type[0]; + $keyhash = $base->sig[0]->attributes()->keyhash[0]; + $encoding = $base->encoding; + $alg = $base->alg; + + + $signed_data = $data.'.'.base64url_encode($type).'.'.base64url_encode($encoding).'.'.base64url_encode($alg); + + + // decode the data + $data = base64url_decode($data); + + + if($public) + $inner_decrypted = $data; + else { + + // Decode the encrypted blob + + $inner_encrypted = base64_decode($data); + $inner_decrypted = mcrypt_decrypt(MCRYPT_RIJNDAEL_128, $inner_aes_key, $inner_encrypted, MCRYPT_MODE_CBC, $inner_iv); + $inner_decrypted = pkcs5_unpad($inner_decrypted); + } + + if (!$author_link) { + logger('Could not retrieve author URI.'); + http_status_exit(400); + } + // Once we have the author URI, go to the web and try to find their public key + // (first this will look it up locally if it is in the fcontact cache) + // This will also convert diaspora public key from pkcs#1 to pkcs#8 + + logger('Fetching key for '.$author_link); + $key = self::key($author_link); + + if (!$key) { + logger('Could not retrieve author key.'); + http_status_exit(400); + } + + $verify = rsa_verify($signed_data,$signature,$key); + + if (!$verify) { + logger('Message did not verify. Discarding.'); + http_status_exit(400); + } + + logger('Message verified.'); + + return array('message' => $inner_decrypted, 'author' => $author_link, 'key' => $key); + + } + + /** * @brief Dispatches public messages and find the fitting receivers * @@ -122,54 +284,46 @@ class diaspora { $type = $fields->getName(); + logger("Received message type ".$type." from ".$sender." for user ".$importer["uid"], LOGGER_DEBUG); + switch ($type) { - case "account_deletion": // Done - //return true; + case "account_deletion": return self::receive_account_deletion($importer, $fields); - case "comment": // Done - //return true; + case "comment": return self::receive_comment($importer, $sender, $fields); - case "conversation": // Done - //return true; + case "conversation": return self::receive_conversation($importer, $msg, $fields); - case "like": // Done - //return true; + case "like": return self::receive_like($importer, $sender, $fields); - case "message": // Done - //return true; + case "message": return self::receive_message($importer, $fields); case "participation": // Not implemented return self::receive_participation($importer, $fields); - case "photo": // Not needed + case "photo": // Not implemented return self::receive_photo($importer, $fields); case "poll_participation": // Not implemented return self::receive_poll_participation($importer, $fields); - case "profile": // Done - //return true; + case "profile": return self::receive_profile($importer, $fields); case "request": - //return true; return self::receive_request($importer, $fields); - case "reshare": // Done - //return true; + case "reshare": return self::receive_reshare($importer, $fields); - case "retraction": // Done - //return true; + case "retraction": return self::receive_retraction($importer, $sender, $fields); - case "status_message": // Done - //return true; + case "status_message": return self::receive_status_message($importer, $fields); default: @@ -287,13 +441,13 @@ class diaspora { return false; if (isset($parent_author_signature)) { - $key = self::get_key($msg["author"]); + $key = self::key($msg["author"]); if (!rsa_verify($signed_data, $parent_author_signature, $key, "sha256")) return false; } - $key = self::get_key($fields->author); + $key = self::key($fields->author); return rsa_verify($signed_data, $author_signature, $key, "sha256"); } @@ -305,10 +459,10 @@ class diaspora { * * @return string The public key */ - private function get_key($handle) { + private function key($handle) { logger("Fetching diaspora key for: ".$handle); - $r = self::get_person_by_handle($handle); + $r = self::person_by_handle($handle); if($r) return $r["pubkey"]; @@ -322,7 +476,7 @@ class diaspora { * * @return array the queried data */ - private function get_person_by_handle($handle) { + private function person_by_handle($handle) { $r = q("SELECT * FROM `fcontact` WHERE `network` = '%s' AND `addr` = '%s' LIMIT 1", dbesc(NETWORK_DIASPORA), @@ -417,7 +571,33 @@ class diaspora { return $r; } - private function get_contact_by_handle($uid, $handle) { + public static function handle_from_contact($contact_id) { + $handle = False; + + logger("contact id is ".$contact_id, LOGGER_DEBUG); + + $r = q("SELECT `network`, `addr`, `self`, `url`, `nick` FROM `contact` WHERE `id` = %d", + intval($contact_id) + ); + if($r) { + $contact = $r[0]; + + logger("contact 'self' = ".$contact['self']." 'url' = ".$contact['url'], LOGGER_DEBUG); + + if($contact['addr'] != "") + $handle = $contact['addr']; + elseif(($contact['network'] === NETWORK_DFRN) || ($contact['self'] == 1)) { + $baseurl_start = strpos($contact['url'],'://') + 3; + $baseurl_length = strpos($contact['url'],'/profile') - $baseurl_start; // allows installations in a subdirectory--not sure how Diaspora will handle + $baseurl = substr($contact['url'], $baseurl_start, $baseurl_length); + $handle = $contact['nick'].'@'.$baseurl; + } + } + + return $handle; + } + + private function contact_by_handle($uid, $handle) { $r = q("SELECT * FROM `contact` WHERE `uid` = %d AND `addr` = '%s' LIMIT 1", intval($uid), dbesc($handle) @@ -469,14 +649,14 @@ class diaspora { return false; } - private function get_allowed_contact_by_handle($importer, $handle, $is_comment = false) { - $contact = self::get_contact_by_handle($importer["uid"], $handle); + private function allowed_contact_by_handle($importer, $handle, $is_comment = false) { + $contact = self::contact_by_handle($importer["uid"], $handle); if (!$contact) { logger("A Contact for handle ".$handle." and user ".$importer["uid"]." was not found"); return false; } - if (!self::post_allow($importer, $contact, false)) { + if (!self::post_allow($importer, $contact, $is_comment)) { logger("The handle: ".$handle." is not allowed to post to user ".$importer["uid"]); return false; } @@ -491,10 +671,10 @@ class diaspora { if($r) { logger("message ".$guid." already exists for user ".$uid); - return false; + return true; } - return true; + return false; } private function fetch_guid($item) { @@ -515,7 +695,7 @@ class diaspora { logger("Trying to fetch item ".$guid." from ".$server, LOGGER_DEBUG); - $msg = self::fetch_message($guid, $server); + $msg = self::message($guid, $server); if (!$msg) return false; @@ -526,7 +706,7 @@ class diaspora { return self::dispatch_public($msg); } - private function fetch_message($guid, $server, $level = 0) { + private function message($guid, $server, $level = 0) { if ($level > 5) return false; @@ -544,29 +724,32 @@ class diaspora { if ($source_xml->post->reshare) { // Reshare of a reshare - old Diaspora version - return self::fetch_message($source_xml->post->reshare->root_guid, $server, ++$level); + return self::message($source_xml->post->reshare->root_guid, $server, ++$level); } elseif ($source_xml->getName() == "reshare") { // Reshare of a reshare - new Diaspora version - return self::fetch_message($source_xml->root_guid, $server, ++$level); + return self::message($source_xml->root_guid, $server, ++$level); } + $author = ""; + // Fetch the author - for the old and the new Diaspora version if ($source_xml->post->status_message->diaspora_handle) $author = (string)$source_xml->post->status_message->diaspora_handle; - elseif ($source_xml->author) + elseif ($source_xml->author AND ($source_xml->getName() == "status_message")) $author = (string)$source_xml->author; + // If this isn't a "status_message" then quit if (!$author) return false; $msg = array("message" => $x, "author" => $author); - $msg["key"] = self::get_key($msg["author"]); + $msg["key"] = self::key($msg["author"]); return $msg; } - private function fetch_parent_item($uid, $guid, $author, $contact) { + private function parent_item($uid, $guid, $author, $contact) { $r = q("SELECT `id`, `body`, `wall`, `uri`, `private`, `origin`, `author-name`, `author-link`, `author-avatar`, `owner-name`, `owner-link`, `owner-avatar` @@ -577,7 +760,7 @@ class diaspora { $result = self::store_by_guid($guid, $contact["url"], $uid); if (!$result) { - $person = self::get_person_by_handle($author); + $person = self::person_by_handle($author); $result = self::store_by_guid($guid, $person["url"], $uid); } @@ -593,13 +776,15 @@ class diaspora { } if (!$r) { - logger("parent item not found: parent: ".$guid." item: ".$guid); + logger("parent item not found: parent: ".$guid." - user: ".$uid); return false; - } else + } else { + logger("parent item found: parent: ".$guid." - user: ".$uid); return $r[0]; + } } - private function get_author_contact_by_url($contact, $person, $uid) { + private function author_contact_by_url($contact, $person, $uid) { $r = q("SELECT `id`, `network` FROM `contact` WHERE `nurl` = '%s' AND `uid` = %d LIMIT 1", dbesc(normalise_link($person["url"])), intval($uid)); @@ -643,7 +828,7 @@ class diaspora { private function receive_account_deletion($importer, $data) { $author = notags(unxmlify($data->author)); - $contact = self::get_contact_by_handle($importer["uid"], $author); + $contact = self::contact_by_handle($importer["uid"], $author); if (!$contact) { logger("cannot find contact for author: ".$author); return false; @@ -660,25 +845,25 @@ class diaspora { $text = unxmlify($data->text); $author = notags(unxmlify($data->author)); - $contact = self::get_allowed_contact_by_handle($importer, $sender, true); + $contact = self::allowed_contact_by_handle($importer, $sender, true); if (!$contact) return false; if (self::message_exists($importer["uid"], $guid)) return false; - $parent_item = self::fetch_parent_item($importer["uid"], $parent_guid, $author, $contact); + $parent_item = self::parent_item($importer["uid"], $parent_guid, $author, $contact); if (!$parent_item) return false; - $person = self::get_person_by_handle($author); + $person = self::person_by_handle($author); if (!is_array($person)) { logger("unable to find author details"); return false; } // Fetch the contact id - if we know this contact - $author_contact = self::get_author_contact_by_url($contact, $person, $importer["uid"]); + $author_contact = self::author_contact_by_url($contact, $person, $importer["uid"]); $datarray = array(); @@ -710,7 +895,9 @@ class diaspora { self::fetch_guid($datarray); $message_id = item_store($datarray); - // print_r($datarray); + + if ($message_id) + logger("Stored comment ".$datarray["guid"]." with message id ".$message_id, LOGGER_DEBUG); // If we are the origin of the parent we store the original data and notify our followers if($message_id AND $parent_item["origin"]) { @@ -770,7 +957,7 @@ class diaspora { $person = $contact; $key = $msg["key"]; } else { - $person = self::get_person_by_handle($msg_author); + $person = self::person_by_handle($msg_author); if (is_array($person) && x($person, "pubkey")) $key = $person["pubkey"]; @@ -859,7 +1046,7 @@ class diaspora { return false; } - $contact = self::get_allowed_contact_by_handle($importer, $msg["author"], true); + $contact = self::allowed_contact_by_handle($importer, $msg["author"], true); if (!$contact) return false; @@ -914,22 +1101,17 @@ class diaspora { private function construct_like_object($importer, $parent_item) { $objtype = ACTIVITY_OBJ_NOTE; - $link = xmlify(''."\n") ; + $link = ''; $parent_body = $parent_item["body"]; - $obj = <<< EOT + $xmldata = array("object" => array("type" => $objtype, + "local" => "1", + "id" => $parent_item["uri"], + "link" => $link, + "title" => "", + "content" => $parent_body)); - - $objtype - 1 - {$parent_item["uri"]} - $link - - $parent_body - -EOT; - - return $obj; + return xml::from_array($xmldata, $xml, true); } private function receive_like($importer, $sender, $data) { @@ -944,25 +1126,25 @@ EOT; if (!in_array($parent_type, array("Post", "Comment"))) return false; - $contact = self::get_allowed_contact_by_handle($importer, $sender, true); + $contact = self::allowed_contact_by_handle($importer, $sender, true); if (!$contact) return false; if (self::message_exists($importer["uid"], $guid)) return false; - $parent_item = self::fetch_parent_item($importer["uid"], $parent_guid, $author, $contact); + $parent_item = self::parent_item($importer["uid"], $parent_guid, $author, $contact); if (!$parent_item) return false; - $person = self::get_person_by_handle($author); + $person = self::person_by_handle($author); if (!is_array($person)) { logger("unable to find author details"); return false; } // Fetch the contact id - if we know this contact - $author_contact = self::get_author_contact_by_url($contact, $person, $importer["uid"]); + $author_contact = self::author_contact_by_url($contact, $person, $importer["uid"]); // "positive" = "false" would be a Dislike - wich isn't currently supported by Diaspora // We would accept this anyhow. @@ -999,7 +1181,9 @@ EOT; $datarray["body"] = self::construct_like_body($contact, $parent_item, $guid); $message_id = item_store($datarray); - // print_r($datarray); + + if ($message_id) + logger("Stored like ".$datarray["guid"]." with message id ".$message_id, LOGGER_DEBUG); // If we are the origin of the parent we store the original data and notify our followers if($message_id AND $parent_item["origin"]) { @@ -1026,7 +1210,7 @@ EOT; $author = notags(unxmlify($data->author)); $conversation_guid = notags(unxmlify($data->conversation_guid)); - $contact = self::get_allowed_contact_by_handle($importer, $author, true); + $contact = self::allowed_contact_by_handle($importer, $author, true); if (!$contact) return false; @@ -1048,7 +1232,7 @@ EOT; $body = diaspora2bb($text); $message_uri = $author.":".$guid; - $person = self::get_person_by_handle($author); + $person = self::person_by_handle($author); if (!$person) { logger("unable to find author details"); return false; @@ -1107,7 +1291,7 @@ EOT; private function receive_profile($importer, $data) { $author = notags(unxmlify($data->author)); - $contact = self::get_contact_by_handle($importer["uid"], $author); + $contact = self::contact_by_handle($importer["uid"], $author); if (!$contact) return; @@ -1184,6 +1368,8 @@ EOT; update_gcontact($gcontact); + logger("Profile of contact ".$contact["id"]." stored for user ".$importer["uid"], LOGGER_DEBUG); + return true; } @@ -1261,7 +1447,7 @@ EOT; if (!$author || !$recipient) return; - $contact = self::get_contact_by_handle($importer["uid"],$author); + $contact = self::contact_by_handle($importer["uid"],$author); if($contact) { @@ -1272,10 +1458,10 @@ EOT; return true; } - $ret = self::get_person_by_handle($author); + $ret = self::person_by_handle($author); if (!$ret || ($ret["network"] != NETWORK_DIASPORA)) { - logger("Cannot resolve diaspora handle ".$author ." for ".$recipient); + logger("Cannot resolve diaspora handle ".$author." for ".$recipient); return false; } @@ -1302,7 +1488,7 @@ EOT; // find the contact record we just created - $contact_record = self::get_contact_by_handle($importer["uid"],$author); + $contact_record = self::contact_by_handle($importer["uid"],$author); if (!$contact_record) { logger("unable to locate newly created contact record."); @@ -1361,13 +1547,13 @@ EOT; $u = q("SELECT * FROM `user` WHERE `uid` = %d LIMIT 1", intval($importer["uid"])); if($u) - $ret = diaspora_share($u[0], $contact_record); + $ret = self::send_share($u[0], $contact_record); } return true; } - private function get_original_item($guid, $orig_author, $author) { + private function original_item($guid, $orig_author, $author) { // Do we already have this item? $r = q("SELECT `body`, `tag`, `app`, `created`, `object-type`, `uri`, `guid`, @@ -1391,22 +1577,24 @@ EOT; logger("1st try: reshared message ".$guid." will be fetched from original server: ".$server); $item_id = self::store_by_guid($guid, $server); - if (!$item_id) { - $server = "https://".substr($author, strpos($author, "@") + 1); - logger("2nd try: reshared message ".$guid." will be fetched from sharer's server: ".$server); - $item = self::store_by_guid($guid, $server); - } if (!$item_id) { $server = "http://".substr($orig_author, strpos($orig_author, "@") + 1); - logger("3rd try: reshared message ".$guid." will be fetched from original server: ".$server); - $item = self::store_by_guid($guid, $server); + logger("2nd try: reshared message ".$guid." will be fetched from original server: ".$server); + $item_id = self::store_by_guid($guid, $server); + } + + // Deactivated by now since there is a risk that someone could manipulate postings through this method +/* if (!$item_id) { + $server = "https://".substr($author, strpos($author, "@") + 1); + logger("3rd try: reshared message ".$guid." will be fetched from sharer's server: ".$server); + $item_id = self::store_by_guid($guid, $server); } if (!$item_id) { $server = "http://".substr($author, strpos($author, "@") + 1); logger("4th try: reshared message ".$guid." will be fetched from sharer's server: ".$server); - $item = self::store_by_guid($guid, $server); + $item_id = self::store_by_guid($guid, $server); } - +*/ if ($item_id) { $r = q("SELECT `body`, `tag`, `app`, `created`, `object-type`, `uri`, `guid`, `author-name`, `author-link`, `author-avatar` @@ -1429,17 +1617,19 @@ EOT; $public = notags(unxmlify($data->public)); $created_at = notags(unxmlify($data->created_at)); - $contact = self::get_allowed_contact_by_handle($importer, $author, false); + $contact = self::allowed_contact_by_handle($importer, $author, false); if (!$contact) return false; if (self::message_exists($importer["uid"], $guid)) return false; - $original_item = self::get_original_item($root_guid, $root_author, $author); + $original_item = self::original_item($root_guid, $root_author, $author); if (!$original_item) return false; + $orig_url = App::get_baseurl()."/display/".$original_item["guid"]; + $datarray = array(); $datarray["uid"] = $importer["uid"]; @@ -1463,7 +1653,7 @@ EOT; $datarray["object"] = json_encode($data); $prefix = share_header($original_item["author-name"], $original_item["author-link"], $original_item["author-avatar"], - $original_item["guid"], $original_item["created"], $original_item["uri"]); + $original_item["guid"], $original_item["created"], $orig_url); $datarray["body"] = $prefix.$original_item["body"]."[/share]"; $datarray["tag"] = $original_item["tag"]; @@ -1477,7 +1667,9 @@ EOT; self::fetch_guid($datarray); $message_id = item_store($datarray); - // print_r($datarray); + + if ($message_id) + logger("Stored reshare ".$datarray["guid"]." with message id ".$message_id, LOGGER_DEBUG); return $message_id; } @@ -1487,7 +1679,7 @@ EOT; $target_guid = notags(unxmlify($data->target_guid)); $author = notags(unxmlify($data->author)); - $person = self::get_person_by_handle($author); + $person = self::person_by_handle($author); if (!is_array($person)) { logger("unable to find author detail for ".$author); return false; @@ -1501,16 +1693,20 @@ EOT; return false; // Only delete it if the author really fits - if (!link_compare($r[0]["author-link"],$person["url"])) + if (!link_compare($r[0]["author-link"], $person["url"])) { + logger("Item author ".$r[0]["author-link"]." doesn't fit to expected contact ".$person["url"], LOGGER_DEBUG); return false; + } // Check if the sender is the thread owner $p = q("SELECT `author-link`, `origin` FROM `item` WHERE `id` = %d", intval($r[0]["parent"])); // Only delete it if the parent author really fits - if (!link_compare($p[0]["author-link"], $contact["url"])) + if (!link_compare($p[0]["author-link"], $contact["url"]) AND !link_compare($r[0]["author-link"], $contact["url"])) { + logger("Thread author ".$p[0]["author-link"]." and item author ".$r[0]["author-link"]." don't fit to expected contact ".$contact["url"], LOGGER_DEBUG); return false; + } // Currently we don't have a central deletion function that we could use in this case. The function "item_drop" doesn't work for that case q("UPDATE `item` SET `deleted` = 1, `edited` = '%s', `changed` = '%s', `body` = '' , `title` = '' WHERE `id` = %d", @@ -1520,12 +1716,14 @@ EOT; ); delete_thread($r[0]["id"], $r[0]["parent-uri"]); + logger("Deleted target ".$target_guid." from user ".$importer["uid"], LOGGER_DEBUG); + // Now check if the retraction needs to be relayed by us if($p[0]["origin"]) { // Formerly we stored the signed text, the signature and the author in different fields. // We now store the raw data so that we are more flexible. - q("INSERT INTO `sign` (`iid`,`signed_text`) VALUES (%d,'%s')", + q("INSERT INTO `sign` (`retract_iid`,`signed_text`) VALUES (%d,'%s')", intval($r[0]["id"]), dbesc(json_encode($data)) ); @@ -1538,12 +1736,14 @@ EOT; private function receive_retraction($importer, $sender, $data) { $target_type = notags(unxmlify($data->target_type)); - $contact = self::get_contact_by_handle($importer["uid"], $sender); + $contact = self::contact_by_handle($importer["uid"], $sender); if (!$contact) { logger("cannot find contact for sender: ".$sender." and user ".$importer["uid"]); return false; } + logger("Got retraction for ".$target_type.", sender ".$sender." and user ".$importer["uid"], LOGGER_DEBUG); + switch ($target_type) { case "Comment": case "Like": @@ -1553,7 +1753,9 @@ EOT; return self::item_retraction($importer, $contact, $data);; case "Person": - contact_remove($contact["id"]); + /// @todo What should we do with an "unshare"? + // Removing the contact isn't correct since we still can read the public items + //contact_remove($contact["id"]); return true; default: @@ -1578,7 +1780,7 @@ EOT; // print_r($poll); // die("poll!\n"); //} - $contact = self::get_allowed_contact_by_handle($importer, $author, false); + $contact = self::allowed_contact_by_handle($importer, $author, false); if (!$contact) return false; @@ -1644,18 +1846,18 @@ EOT; self::fetch_guid($datarray); $message_id = item_store($datarray); - // print_r($datarray); - logger("Stored item with message id ".$message_id, LOGGER_DEBUG); + if ($message_id) + logger("Stored item ".$datarray["guid"]." with message id ".$message_id, LOGGER_DEBUG); return $message_id; } - /******************************************************************************************* - * Here come all the functions that are needed to transmit data with the Diaspora protocol * - *******************************************************************************************/ + /****************************************************************************************** + * Here are all the functions that are needed to transmit data with the Diaspora protocol * + ******************************************************************************************/ - private function get_my_handle($me) { + private function my_handle($me) { if ($contact["addr"] != "") return $contact["addr"]; @@ -1668,7 +1870,7 @@ EOT; logger("Message: ".$msg, LOGGER_DATA); - $handle = self::get_my_handle($user); + $handle = self::my_handle($user); $b64url_data = base64url_encode($msg); @@ -1683,20 +1885,17 @@ EOT; $signature = rsa_sign($signable_data,$prvkey); $sig = base64url_encode($signature); -$magic_env = <<< EOT - - -
- $handle -
- - base64url - RSA-SHA256 - $data - $sig - - -EOT; + $xmldata = array("diaspora" => array("header" => array("author_id" => $handle), + "me:env" => array("me:encoding" => "base64url", + "me:alg" => "RSA-SHA256", + "me:data" => $data, + "@attributes" => array("type" => "application/xml"), + "me:sig" => $sig))); + + $namespaces = array("" => "https://joindiaspora.com/protocol", + "me" => "http://salmon-protocol.org/ns/magic-env"); + + $magic_env = xml::from_array($xmldata, $xml, false, $namespaces); logger("magic_env: ".$magic_env, LOGGER_DATA); return $magic_env; @@ -1723,7 +1922,7 @@ EOT; $outer_iv = random_string(16); $b_outer_iv = base64_encode($outer_iv); - $handle = self::get_my_handle($user); + $handle = self::my_handle($user); $padded_data = pkcs5_pad($msg,16); $inner_encrypted = mcrypt_encrypt(MCRYPT_RIJNDAEL_128, $inner_aes_key, $padded_data, MCRYPT_MODE_CBC, $inner_iv); @@ -1743,14 +1942,11 @@ EOT; $signature = rsa_sign($signable_data,$prvkey); $sig = base64url_encode($signature); -$decrypted_header = <<< EOT - - $b_inner_iv - $b_inner_aes_key - $handle - -EOT; + $xmldata = array("decrypted_header" => array("iv" => $b_inner_iv, + "aes_key" => $b_inner_aes_key, + "author_id" => $handle)); + $decrypted_header = xml::from_array($xmldata, $xml, true); $decrypted_header = pkcs5_pad($decrypted_header,16); $ciphertext = mcrypt_encrypt(MCRYPT_RIJNDAEL_128, $outer_aes_key, $decrypted_header, MCRYPT_MODE_CBC, $outer_iv); @@ -1768,20 +1964,17 @@ EOT; "ciphertext" => base64_encode($ciphertext))); $cipher_json = base64_encode($encrypted_header_json_object); - $encrypted_header = "".$cipher_json.""; - -$magic_env = <<< EOT - - - $encrypted_header - - base64url - RSA-SHA256 - $data - $sig - - -EOT; + $xmldata = array("diaspora" => array("encrypted_header" => $cipher_json, + "me:env" => array("me:encoding" => "base64url", + "me:alg" => "RSA-SHA256", + "me:data" => $data, + "@attributes" => array("type" => "application/xml"), + "me:sig" => $sig))); + + $namespaces = array("" => "https://joindiaspora.com/protocol", + "me" => "http://salmon-protocol.org/ns/magic-env"); + + $magic_env = xml::from_array($xmldata, $xml, false, $namespaces); logger("magic_env: ".$magic_env, LOGGER_DATA); return $magic_env; @@ -1799,7 +1992,17 @@ EOT; return $slap; } - private function transmit($owner, $contact, $slap, $public_batch, $queue_run=false, $guid = "") { + private function signature($owner, $message) { + $sigmsg = $message; + unset($sigmsg["author_signature"]); + unset($sigmsg["parent_author_signature"]); + + $signed_text = implode(";", $sigmsg); + + return base64_encode(rsa_sign($signed_text, $owner["uprvkey"], "sha256")); + } + + public static function transmit($owner, $contact, $slap, $public_batch, $queue_run=false, $guid = "") { $a = get_app(); @@ -1839,7 +2042,7 @@ EOT; dbesc($slap), intval($public_batch) ); - if(count($r)) { + if($r) { logger("add_to_queue ignored - identical item already in queue"); } else { // queue message for redelivery @@ -1847,41 +2050,43 @@ EOT; } } - return(($return_code) ? $return_code : (-1)); } - public static function send_share($me,$contact) { - $myaddr = self::get_my_handle($me); - $theiraddr = $contact["addr"]; - $data = array("XML" => array("post" => array("request" => array( - "sender_handle" => $myaddr, - "recipient_handle" => $theiraddr - )))); + private function build_and_transmit($owner, $contact, $type, $message, $public_batch = false, $guid = "") { + + $data = array("XML" => array("post" => array($type => $message))); $msg = xml::from_array($data, $xml); - $slap = self::build_message($msg, $me, $contact, $me["prvkey"], $contact["pubkey"]); + logger('message: '.$msg, LOGGER_DATA); + logger('send guid '.$guid, LOGGER_DEBUG); - return(self::transmit($owner,$contact,$slap, false)); + $slap = self::build_message($msg, $owner, $contact, $owner['uprvkey'], $contact['pubkey'], $public_batch); + $return_code = self::transmit($owner, $contact, $slap, $public_batch, false, $guid); + + logger("guid: ".$item["guid"]." result ".$return_code, LOGGER_DEBUG); + + return $return_code; } - public static function send_unshare($me,$contact) { - $myaddr = self::get_my_handle($me); + public static function send_share($owner,$contact) { - $data = array("XML" => array("post" => array("retraction" => array( - "post_guid" => $me["guid"], - "diaspora_handle" => $myaddr, - "type" => "Person" - )))); + $message = array("sender_handle" => self::my_handle($owner), + "recipient_handle" => $contact["addr"]); - $msg = xml::from_array($data, $xml); + return self::build_and_transmit($owner, $contact, "request", $message); + } + + public static function send_unshare($owner,$contact) { - $slap = self::build_message($msg, $me, $contact, $me["prvkey"], $contact["pubkey"]); + $message = array("post_guid" => $owner["guid"], + "diaspora_handle" => self::my_handle($owner), + "type" => "Person"); - return(self::transmit($owner,$contact,$slap, false)); + return self::build_and_transmit($owner, $contact, "retraction", $message); } private function is_reshare($body) { @@ -1915,7 +2120,7 @@ EOT; dbesc($guid), NETWORK_DFRN, NETWORK_DIASPORA); if ($r) { $ret= array(); - $ret["root_handle"] = diaspora_handle_from_contact($r[0]["contact-id"]); + $ret["root_handle"] = self::handle_from_contact($r[0]["contact-id"]); $ret["root_guid"] = $guid; return($ret); } @@ -1953,28 +2158,7 @@ EOT; public static function send_status($item, $owner, $contact, $public_batch = false) { - $myaddr = self::get_my_handle($owner); - $theiraddr = $contact["addr"]; - - $title = $item["title"]; - $body = $item["body"]; - - // convert to markdown - $body = html_entity_decode(bb2diaspora($body)); - - // Adding the title - if(strlen($title)) - $body = "## ".html_entity_decode($title)."\n\n".$body; - - if ($item["attach"]) { - $cnt = preg_match_all('/href=\"(.*?)\"(.*?)title=\"(.*?)\"/ism', $item["attach"], $matches, PREG_SET_ORDER); - if(cnt) { - $body .= "\n".t("Attachments:")."\n"; - foreach($matches as $mtch) - $body .= "[".$mtch[3]."](".$mtch[1].")\n"; - } - } - + $myaddr = self::my_handle($owner); $public = (($item["private"]) ? "false" : "true"); @@ -1990,8 +2174,27 @@ EOT; "created_at" => $created, "provider_display_name" => $item["app"]); - $data = array("XML" => array("post" => array("reshare" => $message))); + $type = "reshare"; } else { + $title = $item["title"]; + $body = $item["body"]; + + // convert to markdown + $body = html_entity_decode(bb2diaspora($body)); + + // Adding the title + if(strlen($title)) + $body = "## ".html_entity_decode($title)."\n\n".$body; + + if ($item["attach"]) { + $cnt = preg_match_all('/href=\"(.*?)\"(.*?)title=\"(.*?)\"/ism', $item["attach"], $matches, PREG_SET_ORDER); + if(cnt) { + $body .= "\n".t("Attachments:")."\n"; + foreach($matches as $mtch) + $body .= "[".$mtch[3]."](".$mtch[1].")\n"; + } + } + $location = array(); if ($item["location"] != "") @@ -2014,30 +2217,18 @@ EOT; if (count($location) == 0) unset($message["location"]); - $data = array("XML" => array("post" => array("status_message" => $message))); + $type = "status_message"; } - $msg = xml::from_array($data, $xml); - - logger("status: ".$owner["username"]." -> ".$contact["name"]." base message: ".$msg, LOGGER_DATA); - logger("send guid ".$item["guid"], LOGGER_DEBUG); - - $slap = self::build_message($msg, $owner, $contact, $owner["uprvkey"], $contact["pubkey"], $public_batch); - - $return_code = self::transmit($owner,$contact,$slap, false); - - logger("guid: ".$item["guid"]." result ".$return_code, LOGGER_DEBUG); - - return $return_code; + return self::build_and_transmit($owner, $contact, $type, $message, $public_batch, $item["guid"]); } - private function construct_like($item,$owner,$contact,$public_batch = false) { + private function construct_like($item, $owner) { - $myaddr = self::get_my_handle($owner); + $myaddr = self::my_handle($owner); $p = q("SELECT `guid`, `uri`, `parent-uri` FROM `item` WHERE `uri` = '%s' LIMIT 1", - dbesc($item["thr-parent"]) - ); + dbesc($item["thr-parent"])); if(!$p) return false; @@ -2046,113 +2237,75 @@ EOT; $target_type = ($parent["uri"] === $parent["parent-uri"] ? "Post" : "Comment"); $positive = "true"; - // sign it - $signed_text = $positive.";".$item["guid"].";".$target_type.";".$parent["guid"].";".$myaddr; - - $authorsig = base64_encode(rsa_sign($signed_text, $owner["uprvkey"], "sha256")); - - $message = array("positive" => $positive, + return(array("positive" => $positive, "guid" => $item["guid"], - "target_type" => $item["guid"], + "target_type" => $target_type, "parent_guid" => $parent["guid"], "author_signature" => $authorsig, - "diaspora_handle" => $myaddr); - - $data = array("XML" => array("post" => array("like" => $message))); - - return xml::from_array($data, $xml); + "diaspora_handle" => $myaddr)); } - private function construct_comment($item,$owner,$contact,$public_batch = false, $data = null) { - - if (is_array($data)) - $message = $data; - else { - $myaddr = self::get_my_handle($owner); - - $p = q("SELECT `guid` FROM `item` WHERE `parent` = %d AND `id` = %d LIMIT 1", - intval($item["parent"]), - intval($item["parent"]) - ); - - if (!$p) - return false; - - $parent = $p[0]; + private function construct_comment($item, $owner) { - $text = html_entity_decode(bb2diaspora($item["body"])); - - $message = array("guid" => $item["guid"], - "parent_guid" => $parent["guid"], - "author_signature" => "", - "text" => $text, - "diaspora_handle" => $myaddr); - } + $myaddr = self::my_handle($owner); - // sign it - $sigmsg = $message; - unset($sigmsg["author_signature"]); - unset($sigmsg["parent_author_signature"]); - - $signed_text = implode(";", $sigmsg); + $p = q("SELECT `guid` FROM `item` WHERE `parent` = %d AND `id` = %d LIMIT 1", + intval($item["parent"]), + intval($item["parent"]) + ); - $authorsig = base64_encode(rsa_sign($signed_text, $owner["uprvkey"], "sha256")); + if (!$p) + return false; - if ($message["author_signature"] == "") - $message["author_signature"] = $authorsig; - else - $message["parent_author_signature"] = $authorsig; + $parent = $p[0]; - $data = array("XML" => array("post" => array("comment" => $message))); + $text = html_entity_decode(bb2diaspora($item["body"])); - return xml::from_array($data, $xml); + return(array("guid" => $item["guid"], + "parent_guid" => $parent["guid"], + "author_signature" => "", + "text" => $text, + "diaspora_handle" => $myaddr)); } public static function send_followup($item,$owner,$contact,$public_batch = false) { - if($item['verb'] === ACTIVITY_LIKE) - $msg = self::construct_like($item, $owner, $contact, $public_batch); - else - $msg = self::construct_comment($item, $owner, $contact, $public_batch); - - if (!$msg) - return $msg; - - logger("base message: ".$msg, LOGGER_DATA); - logger("send guid ".$item["guid"], LOGGER_DEBUG); - - $slap = self::build_message($msg, $owner, $contact, $owner["uprvkey"], $contact["pubkey"], $public_batch); + if($item['verb'] === ACTIVITY_LIKE) { + $message = self::construct_like($item, $owner); + $type = "like"; + } else { + $message = self::construct_comment($item, $owner); + $type = "comment"; + } - $return_code = self::transmit($owner, $contact, $slap, $public_batch, false, $item["guid"]); + if (!$message) + return false; - logger("guid: ".$item["guid"]." result ".$return_code, LOGGER_DEBUG); + $message["author_signature"] = self::signature($owner, $message); - return $return_code; + return self::build_and_transmit($owner, $contact, $type, $message, $public_batch, $item["guid"]); } - function send_relay($item, $owner, $contact, $public_batch = false) { + private function message_from_signatur($item, $signature) { - if ($item["deleted"]) - $sql_sign_id = "retract_iid"; - else - $sql_sign_id = "iid"; - - // fetch the original signature if the relayable was created by a Diaspora - // or DFRN user. - - $r = q("SELECT `signed_text`, `signature`, `signer` FROM `sign` WHERE `".$sql_sign_id."` = %d LIMIT 1", - intval($item["id"]) - ); - - if(count($r)) { - $orig_sign = $r[0]; - $signed_text = $orig_sign['signed_text']; - $authorsig = $orig_sign['signature']; - $handle = $orig_sign['signer']; - - // Split the signed text - $signed_parts = explode(";", $signed_text); + // Split the signed text + $signed_parts = explode(";", $signature['signed_text']); + if ($item["deleted"]) + $message = array("parent_author_signature" => "", + "target_guid" => $signed_parts[0], + "target_type" => $signed_parts[1], + "sender_handle" => $signature['signer'], + "target_author_signature" => $signature['signature']); + elseif ($item['verb'] === ACTIVITY_LIKE) + $message = array("positive" => $signed_parts[0], + "guid" => $signed_parts[1], + "target_type" => $signed_parts[2], + "parent_guid" => $signed_parts[3], + "parent_author_signature" => "", + "author_signature" => $signature['signature'], + "diaspora_handle" => $signed_parts[4]); + else { // Remove the comment guid $guid = array_shift($signed_parts); @@ -2165,148 +2318,73 @@ EOT; // Glue the parts together $text = implode(";", $signed_parts); - $data = array("guid" => $guid, + $message = array("guid" => $guid, "parent_guid" => $parent_guid, "parent_author_signature" => "", - "author_signature" => $orig_sign['signature'], + "author_signature" => $signature['signature'], "text" => implode(";", $signed_parts), "diaspora_handle" => $handle); } - - - $myaddr = self::get_my_handle($owner); - - if ($item['deleted']) - ; // Retraction - elseif($item['verb'] === ACTIVITY_LIKE) - $msg = self::construct_like($item, $owner, $contact, $public_batch); - else - $msg = self::construct_comment($item, $owner, $contact, $public_batch, $data); -die($msg); -/* - // Diaspora doesn't support threaded comments, but some - // versions of Diaspora (i.e. Diaspora-pistos) support - // likes on comments - if($item['verb'] === ACTIVITY_LIKE && $item['thr-parent']) { - $p = q("select guid, type, uri, `parent-uri` from item where uri = '%s' limit 1", - dbesc($item['thr-parent']) - ); - } - else { - // The first item in the `item` table with the parent id is the parent. However, MySQL doesn't always - // return the items ordered by `item`.`id`, in which case the wrong item is chosen as the parent. - // The only item with `parent` and `id` as the parent id is the parent item. - $p = q("select guid, type, uri, `parent-uri` from item where parent = %d and id = %d limit 1", - intval($item['parent']), - intval($item['parent']) - ); + return $message; } - if(count($p)) - $parent = $p[0]; - else - return; - - $like = false; - $relay_retract = false; - $sql_sign_id = 'iid'; - if( $item['deleted']) { - $relay_retract = true; - - $target_type = ( ($item['verb'] === ACTIVITY_LIKE) ? 'Like' : 'Comment'); - - $sql_sign_id = 'retract_iid'; - $tpl = get_markup_template('diaspora_relayable_retraction.tpl'); - } - elseif($item['verb'] === ACTIVITY_LIKE) { - $like = true; - - $target_type = ( $parent['uri'] === $parent['parent-uri'] ? 'Post' : 'Comment'); -// $positive = (($item['deleted']) ? 'false' : 'true'); - $positive = 'true'; - $tpl = get_markup_template('diaspora_like_relay.tpl'); - } - else { // item is a comment - $tpl = get_markup_template('diaspora_comment_relay.tpl'); - } + public static function send_relay($item, $owner, $contact, $public_batch = false) { + if ($item["deleted"]) { + $sql_sign_id = "retract_iid"; + $type = "relayable_retraction"; + } elseif ($item['verb'] === ACTIVITY_LIKE) { + $sql_sign_id = "iid"; + $type = "like"; + } else { + $sql_sign_id = "iid"; + $type = "comment"; + } - // fetch the original signature if the relayable was created by a Diaspora - // or DFRN user. Relayables for other networks are not supported. - - $r = q("SELECT `signed_text`, `signature`, `signer` FROM `sign` WHERE " . $sql_sign_id . " = %d LIMIT 1", - intval($item['id']) - ); - if(count($r)) { - $orig_sign = $r[0]; - $signed_text = $orig_sign['signed_text']; - $authorsig = $orig_sign['signature']; - $handle = $orig_sign['signer']; - - // Split the signed text - $signed_parts = explode(";", $signed_text); - - // Remove the parent guid - array_shift($signed_parts); - - // Remove the comment guid - array_shift($signed_parts); - - // Remove the handle - array_pop($signed_parts); - - // Glue the parts together - $text = implode(";", $signed_parts); - } - else { - // This part is meant for cases where we don't have the signatur. (Which shouldn't happen with posts from Diaspora and Friendica) - // This means that the comment won't be accepted by newer Diaspora servers - - $body = $item['body']; - $text = html_entity_decode(bb2diaspora($body)); - - $handle = diaspora_handle_from_contact($item['contact-id']); - if(! $handle) - return; - - if($relay_retract) - $signed_text = $item['guid'] . ';' . $target_type; - elseif($like) - $signed_text = $item['guid'] . ';' . $target_type . ';' . $parent['guid'] . ';' . $positive . ';' . $handle; - else - $signed_text = $item['guid'] . ';' . $parent['guid'] . ';' . $text . ';' . $handle; + // fetch the original signature - $authorsig = base64_encode(rsa_sign($signed_text,$owner['uprvkey'],'sha256')); - } + $r = q("SELECT `signed_text`, `signature`, `signer` FROM `sign` WHERE `".$sql_sign_id."` = %d LIMIT 1", + intval($item["id"])); - // Sign the relayable with the top-level owner's signature - $parentauthorsig = base64_encode(rsa_sign($signed_text,$owner['uprvkey'],'sha256')); + if (!$r) + return self::send_followup($item, $owner, $contact, $public_batch); + + $signature = $r[0]; + + // Old way - is used by the internal Friendica functions + /// @todo Change all signatur storing functions to the new format + if ($signature['signed_text'] AND $signature['signature'] AND $signature['signer']) + $message = self::message_from_signatur($item, $signature); + else {// New way + $msg = json_decode($signature['signed_text'], true); + + $message = array(); + foreach ($msg AS $field => $data) { + if (!$item["deleted"]) { + if ($field == "author") + $field = "diaspora_handle"; + if ($field == "parent_type") + $field = "target_type"; + } - $msg = replace_macros($tpl,array( - '$guid' => xmlify($item['guid']), - '$parent_guid' => xmlify($parent['guid']), - '$target_type' =>xmlify($target_type), - '$authorsig' => xmlify($authorsig), - '$parentsig' => xmlify($parentauthorsig), - '$body' => xmlify($text), - '$positive' => xmlify($positive), - '$handle' => xmlify($handle) - )); + $message[$field] = $data; + } + } - logger('diaspora_send_relay: base message: ' . $msg, LOGGER_DATA); - logger('send guid '.$item['guid'], LOGGER_DEBUG); + if ($item["deleted"]) { + $signed_text = $message["target_guid"].';'.$message["target_type"]; + $message["parent_author_signature"] = base64_encode(rsa_sign($signed_text, $owner["uprvkey"], "sha256")); + } else + $message["parent_author_signature"] = self::signature($owner, $message); - $slap = 'xml=' . urlencode(urlencode(diaspora_msg_build($msg,$owner,$contact,$owner['uprvkey'],$contact['pubkey'],$public_batch))); - //$slap = 'xml=' . urlencode(diaspora_msg_build($msg,$owner,$contact,$owner['uprvkey'],$contact['pubkey'],$public_batch)); + logger("Relayed data ".print_r($message, true), LOGGER_DEBUG); - return(diaspora_transmit($owner,$contact,$slap,$public_batch,false,$item['guid'])); -*/ + return self::build_and_transmit($owner, $contact, $type, $message, $public_batch, $item["guid"]); } - public static function send_retraction($item, $owner, $contact, $public_batch = false) { - $myaddr = self::get_my_handle($owner); + $myaddr = self::my_handle($owner); // Check whether the retraction is for a top-level post or whether it's a relayable if ($item["uri"] !== $item["parent-uri"]) { @@ -2324,30 +2402,19 @@ die($msg); "sender_handle" => $myaddr, "target_author_signature" => base64_encode(rsa_sign($signed_text,$owner['uprvkey'],'sha256'))); - $data = array("XML" => array("post" => array($msg_type => $message))); - $msg = xml::from_array($data, $xml); - - logger("send guid ".$item["guid"], LOGGER_DEBUG); - - $slap = self::build_message($msg, $owner, $contact, $owner["uprvkey"], $contact["pubkey"], $public_batch); - - $return_code = self::transmit($owner, $contact, $slap, $public_batch, false, $item["guid"]); - - logger("guid: ".$item["guid"]." result ".$return_code, LOGGER_DEBUG); - - return $return_code; + return self::build_and_transmit($owner, $contact, $msg_type, $message, $public_batch, $item["guid"]); } - public static function send_mail($item,$owner,$contact) { + public static function send_mail($item, $owner, $contact) { - $myaddr = self::get_my_handle($owner); + $myaddr = self::my_handle($owner); $r = q("SELECT * FROM `conv` WHERE `id` = %d AND `uid` = %d LIMIT 1", intval($item["convid"]), intval($item["uid"]) ); - if (!count($r)) { + if (!$r) { logger("conversation not found."); return; } @@ -2365,7 +2432,6 @@ die($msg); $created = datetime_convert("UTC", "UTC", $item["created"], 'Y-m-d H:i:s \U\T\C'); $signed_text = $item["guid"].";".$cnv["guid"].";".$body.";".$created.";".$myaddr.";".$cnv['guid']; - $sig = base64_encode(rsa_sign($signed_text, $owner["uprvkey"], "sha256")); $msg = array( @@ -2379,9 +2445,10 @@ die($msg); "conversation_guid" => $cnv["guid"] ); - if ($item["reply"]) - $data = array("XML" => array("post" => array("message" => $msg))); - else { + if ($item["reply"]) { + $message = $msg; + $type = "message"; + } else { $message = array("guid" => $cnv["guid"], "subject" => $cnv["subject"], "created_at" => datetime_convert("UTC", "UTC", $cnv['created'], 'Y-m-d H:i:s \U\T\C'), @@ -2389,21 +2456,10 @@ die($msg); "diaspora_handle" => $cnv["creator"], "participant_handles" => $cnv["recips"]); - $data = array("XML" => array("post" => array("conversation" => $message))); + $type = "conversation"; } - $xmsg = xml::from_array($data, $xml); - - logger("conversation: ".print_r($xmsg,true), LOGGER_DATA); - logger("send guid ".$item["guid"], LOGGER_DEBUG); - - $slap = self::build_message($xmsg, $owner, $contact, $owner["uprvkey"], $contact["pubkey"], false); - - $return_code = self::transmit($owner, $contact, $slap, false, false, $item["guid"]); - - logger("guid: ".$item["guid"]." result ".$return_code, LOGGER_DEBUG); - - return $return_code; + return self::build_and_transmit($owner, $contact, $type, $message, false, $item["guid"]); } } ?>