X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=include%2Fqueue.php;h=f36e7723cd209b14978bcb40cadddfaaafafd3e2;hb=87eb3d5ef268534e1c8fac9ed63dad4fb50989ee;hp=157fc88d944a350b747a731ef0756f1117d432cb;hpb=ec9c9f0be78f9db691ee1c7174f10a7850033717;p=friendica.git

diff --git a/include/queue.php b/include/queue.php
index 157fc88d94..f36e7723cd 100644
--- a/include/queue.php
+++ b/include/queue.php
@@ -17,34 +17,19 @@ function queue_run(&$argv, &$argc){
 		unset($db_host, $db_user, $db_pass, $db_data);
 	};
 
-
 	require_once("include/session.php");
 	require_once("include/datetime.php");
 	require_once('include/items.php');
 	require_once('include/bbcode.php');
-	require_once('include/pidfile.php');
 	require_once('include/socgraph.php');
 
 	load_config('config');
 	load_config('system');
 
 	// Don't check this stuff if the function is called by the poller
-	if (App::callstack() != "poller_run") {
-		$lockpath = get_lockpath();
-		if ($lockpath != '') {
-			$pidfile = new pidfile($lockpath, 'queue');
-			if($pidfile->is_already_running()) {
-				logger("queue: Already running");
-				if ($pidfile->running_time() > 9*60) {
-					$pidfile->kill();
-					logger("queue: killed stale process");
-					// Calling a new instance
-					proc_run('php',"include/queue.php");
-				}
-				return;
-			}
-		}
-	}
+	if (App::callstack() != "poller_run")
+		if (App::is_already_running('queue', 'include/queue.php', 540))
+			return;
 
 	$a->set_baseurl(get_config('system','url'));
 
@@ -59,55 +44,58 @@ function queue_run(&$argv, &$argc){
 	$deadservers = array();
 	$serverlist = array();
 
-	logger('queue: start');
+	if (!$queue_id) {
 
-	// Handling the pubsubhubbub requests
-	proc_run('php','include/pubsubpublish.php');
+		logger('queue: start');
 
-	$interval = ((get_config('system','delivery_interval') === false) ? 2 : intval(get_config('system','delivery_interval')));
+		// Handling the pubsubhubbub requests
+		proc_run(PRIORITY_HIGH,'include/pubsubpublish.php');
 
-	// If we are using the worker we don't need a delivery interval
-	if (get_config("system", "worker"))
-		$interval = false;
+		$interval = ((get_config('system','delivery_interval') === false) ? 2 : intval(get_config('system','delivery_interval')));
 
-	$r = q("select * from deliverq where 1");
-	if($r) {
-		foreach($r as $rr) {
-			logger('queue: deliverq');
-			proc_run('php','include/delivery.php',$rr['cmd'],$rr['item'],$rr['contact']);
-			if($interval)
-				@time_sleep_until(microtime(true) + (float) $interval);
-		}
-	}
+		// If we are using the worker we don't need a delivery interval
+		if (get_config("system", "worker"))
+			$interval = false;
 
-	$r = q("SELECT `queue`.*, `contact`.`name`, `contact`.`uid` FROM `queue`
-		INNER JOIN `contact` ON `queue`.`cid` = `contact`.`id`
-		WHERE `queue`.`created` < UTC_TIMESTAMP() - INTERVAL 3 DAY");
-	if($r) {
-		foreach($r as $rr) {
-			logger('Removing expired queue item for ' . $rr['name'] . ', uid=' . $rr['uid']);
-			logger('Expired queue data :' . $rr['content'], LOGGER_DATA);
+		$r = q("select * from deliverq where 1");
+		if ($r) {
+			foreach ($r as $rr) {
+				logger('queue: deliverq');
+				proc_run(PRIORITY_HIGH,'include/delivery.php',$rr['cmd'],$rr['item'],$rr['contact']);
+				if($interval) {
+					time_sleep_until(microtime(true) + (float) $interval);
+				}
+			}
 		}
-		q("DELETE FROM `queue` WHERE `created` < UTC_TIMESTAMP() - INTERVAL 3 DAY");
-	}
 
-	if($queue_id) {
-		$r = q("SELECT `id` FROM `queue` WHERE `id` = %d LIMIT 1",
-			intval($queue_id)
-		);
-	}
-	else {
+		$r = q("SELECT `queue`.*, `contact`.`name`, `contact`.`uid` FROM `queue`
+			INNER JOIN `contact` ON `queue`.`cid` = `contact`.`id`
+			WHERE `queue`.`created` < UTC_TIMESTAMP() - INTERVAL 3 DAY");
+		if ($r) {
+			foreach ($r as $rr) {
+				logger('Removing expired queue item for ' . $rr['name'] . ', uid=' . $rr['uid']);
+				logger('Expired queue data :' . $rr['content'], LOGGER_DATA);
+			}
+			q("DELETE FROM `queue` WHERE `created` < UTC_TIMESTAMP() - INTERVAL 3 DAY");
+		}
 
 		// For the first 12 hours we'll try to deliver every 15 minutes
 		// After that, we'll only attempt delivery once per hour.
 
 		$r = q("SELECT `id` FROM `queue` WHERE ((`created` > UTC_TIMESTAMP() - INTERVAL 12 HOUR && `last` < UTC_TIMESTAMP() - INTERVAL 15 MINUTE) OR (`last` < UTC_TIMESTAMP() - INTERVAL 1 HOUR)) ORDER BY `cid`, `created`");
+	} else {
+		logger('queue: start for id '.$queue_id);
+
+		$r = q("SELECT `id` FROM `queue` WHERE `id` = %d LIMIT 1",
+			intval($queue_id)
+		);
 	}
-	if(! $r){
+
+	if (!$r){
 		return;
 	}
 
-	if(! $queue_id)
+	if (!$queue_id)
 		call_hooks('queue_predeliver', $a, $r);
 
 
@@ -121,16 +109,17 @@ function queue_run(&$argv, &$argc){
 		// queue_predeliver hooks may have changed the queue db details,
 		// so check again if this entry still needs processing
 
-		if($queue_id) {
+		if($queue_id)
 			$qi = q("SELECT * FROM `queue` WHERE `id` = %d LIMIT 1",
-				intval($queue_id)
-			);
-		}
-		else {
+				intval($queue_id));
+		elseif (get_config("system", "worker")) {
+			logger('Call queue for id '.$q_item['id']);
+			proc_run(PRIORITY_LOW, "include/queue.php", $q_item['id']);
+			continue;
+		} else
 			$qi = q("SELECT * FROM `queue` WHERE `id` = %d AND `last` < UTC_TIMESTAMP() - INTERVAL 15 MINUTE ",
-				intval($q_item['id'])
-			);
-		}
+				intval($q_item['id']));
+
 		if(! count($qi))
 			continue;
 
@@ -138,7 +127,7 @@ function queue_run(&$argv, &$argc){
 		$c = q("SELECT * FROM `contact` WHERE `id` = %d LIMIT 1",
 			intval($qi[0]['cid'])
 		);
-		if(! count($c)) {
+		if (! dbm::is_result($c)) {
 			remove_queue_item($q_item['id']);
 			continue;
 		}
@@ -168,7 +157,7 @@ function queue_run(&$argv, &$argc){
 			FROM `user` WHERE `uid` = %d LIMIT 1",
 			intval($c[0]['uid'])
 		);
-		if(! count($u)) {
+		if (! dbm::is_result($u)) {
 			remove_queue_item($q_item['id']);
 			continue;
 		}
@@ -207,7 +196,7 @@ function queue_run(&$argv, &$argc){
 			case NETWORK_DIASPORA:
 				if($contact['notify']) {
 					logger('queue: diaspora_delivery: item '.$q_item['id'].' for '.$contact['name'].' <'.$contact['url'].'>');
-					$deliver_status = diaspora_transmit($owner,$contact,$data,$public,true);
+					$deliver_status = Diaspora::transmit($owner,$contact,$data,$public,true);
 
 					if($deliver_status == (-1)) {
 						update_queue_time($q_item['id']);