X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=lib%2Factivity.php;h=9282461c1ccce4a29ef3c769191fcd3d426d32c2;hb=d6b28c64830f632bb2f4b6f3c9369b9e56ad217a;hp=5234a54c03d9221ffb49e53a81bf9aa5bc905c15;hpb=c585a43d6f55070f9e3f2ad163bda256984fda6f;p=quix0rs-gnu-social.git diff --git a/lib/activity.php b/lib/activity.php index 5234a54c03..9282461c1c 100644 --- a/lib/activity.php +++ b/lib/activity.php @@ -100,11 +100,13 @@ class Activity public $title; // title of the activity public $categories = array(); // list of AtomCategory objects public $enclosures = array(); // list of enclosure URL references + public $attachments = array(); // list of attachments public $extra = array(); // extra elements as array(tag, attrs, content) public $source; // ActivitySource object representing 'home feed' public $selfLink; // public $editLink; // + public $generator; // ActivityObject representing the generating application /** * Turns a regular old Atom into a magical activity @@ -243,6 +245,9 @@ class Activity if (!empty($targetEl)) { $this->target = new ActivityObject($targetEl); + } elseif (ActivityUtils::compareVerbs($this->verb, array(ActivityVerb::FAVORITE))) { + // StatusNet didn't send a 'target' for their Favorite atom entries + $this->target = clone($this->objects[0]); } $this->summary = ActivityUtils::childContent($entry, 'summary'); @@ -365,8 +370,11 @@ class Activity // content $activity['content'] = $this->content; - // generator <-- We could use this when we know a notice is created - // locally. Or if we know the upstream Generator. + // generator + + if (!empty($this->generator)) { + $activity['generator'] = $this->generator->asArray(); + } // icon <-- possibly a mini object representing verb? @@ -374,82 +382,80 @@ class Activity $activity['id'] = $this->id; // object - if ($this->verb == ActivityVerb::POST && count($this->objects) == 1) { - $activity['object'] = $this->objects[0]->asArray(); - - // Context stuff. For now I'm just sticking most of it - // in a property called "context" - if (!empty($this->context)) { - - if (!empty($this->context->location)) { - $loc = $this->context->location; + if (count($this->objects) == 0) { + common_log(LOG_ERR, "Can't save " . $this->id); + } else { + if (count($this->objects) > 1) { + common_log(LOG_WARNING, "Ignoring " . (count($this->objects) - 1) . " extra objects in JSON output for activity " . $this->id); + } + $object = $this->objects[0]; + + if ($object instanceof Activity) { + // Sharing a post activity is more like sharing the original object + if (ActivityVerb::canonical($this->verb) == ActivityVerb::canonical(ActivityVerb::SHARE) && + ActivityVerb::canonical($object->verb) == ActivityVerb::canonical(ActivityVerb::POST)) { + // XXX: Here's one for the obfuscation record books + $object = $object->objects[0]; + } + } - // GeoJSON + $activity['object'] = $object->asArray(); - $activity['geopoint'] = array( - 'type' => 'Point', - 'coordinates' => array($loc->lat, $loc->lon) - ); + if ($object instanceof Activity) { + $activity['object']['objectType'] = 'activity'; + } + foreach ($this->attachments as $attachment) { + if (empty($activity['object']['attachments'])) { + $activity['object']['attachments'] = array(); } - - $activity['to'] = $this->context->getToArray(); - $activity['context'] = $this->context->asArray(); + $activity['object']['attachments'][] = $attachment->asArray(); } + } + + // Context stuff. - // Instead of adding enclosures as an extension to JSON - // Activities, it seems like we should be using the - // attachements property of ActivityObject - - $attachments = array(); - - // XXX: OK, this is kinda cheating. We should probably figure out - // what kind of objects these are based on mime-type and then - // create specific object types. Right now this rely on - // duck-typing. Also, we should include an embed code for - // video attachments. + if (!empty($this->context)) { - foreach ($this->enclosures as $enclosure) { + if (!empty($this->context->location)) { + $loc = $this->context->location; - if (is_string($enclosure)) { + $activity['location'] = array( + 'objectType' => 'place', + 'position' => sprintf("%+02.5F%+03.5F/", $loc->lat, $loc->lon), + 'lat' => $loc->lat, + 'lon' => $loc->lon + ); - $attachments[]['id'] = $enclosure; + $name = $loc->getName(); - } else { + if ($name) { + $activity['location']['displayName'] = $name; + } + + $url = $loc->getURL(); - $attachments[]['id'] = $enclosure->url; + if ($url) { + $activity['location']['url'] = $url; + } + } - $mediaLink = new ActivityStreamsMediaLink( - $enclosure->url, - null, - null, - $enclosure->mimetype - // XXX: Add 'size' as an extension to MediaLink? - ); + $activity['to'] = $this->context->getToArray(); - $attachments[]['mediaLink'] = $mediaLink->asArray(); // extension + $ctxarr = $this->context->asArray(); - if ($enclosure->title) { - $attachments[]['displayName'] = $enclosure->title; - } - } + if (array_key_exists('inReplyTo', $ctxarr)) { + $activity['object']['inReplyTo'] = $ctxarr['inReplyTo']; + unset($ctxarr['inReplyTo']); } - if (!empty($attachments)) { - $activity['object']['attachments'] = $attachments; + if (!array_key_exists('status_net', $activity)) { + $activity['status_net'] = array(); } - } else { - $activity['object'] = array(); - foreach($this->objects as $object) { - $oa = $object->asArray(); - if ($object instanceof Activity) { - // throw in a type - // XXX: hackety-hack - $oa['objectType'] = 'activity'; - } - $activity['object'][] = $oa; + foreach ($ctxarr as $key => $value) { + $activity['status_net'][$key] = $value; } } @@ -477,25 +483,30 @@ class Activity // eceived a remote notice? Probably not. // verb - // - // We can probably use the whole schema URL here but probably the - // relative simple name is easier to parse - $activity['verb'] = substr($this->verb, strrpos($this->verb, '/') + 1); + + $activity['verb'] = ActivityVerb::canonical($this->verb); // url - $activity['url'] = $this->id; + if ($this->link) { + $activity['url'] = $this->link; + } /* Purely extensions hereafter */ - $tags = array(); - - // Use an Activity Object for term? Which object? Note? - foreach ($this->categories as $cat) { - $tags[] = $cat->term; + if ($activity['verb'] == 'post') { + $tags = array(); + foreach ($this->categories as $cat) { + if (mb_strlen($cat->term) > 0) { + // Couldn't figure out which object type to use, so... + $tags[] = array('objectType' => 'http://activityschema.org/object/hashtag', + 'displayName' => $cat->term); + } + } + if (count($tags) > 0) { + $activity['object']['tags'] = $tags; + } } - $activity['tags'] = $tags; - // XXX: a bit of a hack... Since JSON isn't namespaced we probably // shouldn't be using 'statusnet:notice_info', but this will work // for the moment. @@ -503,7 +514,15 @@ class Activity foreach ($this->extra as $e) { list($objectName, $props, $txt) = $e; if (!empty($objectName)) { - $activity[$objectName] = $props; + $parts = explode(":", $objectName); + if (count($parts) == 2 && $parts[0] == "statusnet") { + if (!array_key_exists('status_net', $activity)) { + $activity['status_net'] = array(); + } + $activity['status_net'][$parts[1]] = $props; + } else { + $activity[$objectName] = $props; + } } } @@ -545,7 +564,13 @@ class Activity } else { $xs->element('id', null, $this->id); - $xs->element('title', null, $this->title); + + if ($this->title) { + $xs->element('title', null, $this->title); + } else { + // Require element + $xs->element('title', null, ""); + } $xs->element('content', array('type' => 'html'), $this->content); @@ -555,8 +580,8 @@ class Activity if (!empty($this->link)) { $xs->element('link', array('rel' => 'alternate', - 'type' => 'text/html'), - $this->link); + 'type' => 'text/html', + 'href' => $this->link)); } } @@ -601,30 +626,24 @@ class Activity } if (!empty($this->context->conversation)) { - $xs->element('link', array('rel' => 'ostatus:conversation', + $xs->element('link', array('rel' => ActivityContext::CONVERSATION, 'href' => $this->context->conversation)); + $xs->element(ActivityContext::CONVERSATION, null, $this->context->conversation); + /* Since we use XMLWriter we just use the previously hardcoded prefix for ostatus, + otherwise we should use something like this: + $xs->elementNS(array(ActivityContext::OSTATUS => 'ostatus'), // namespace + 'conversation', // tag (or the element name from ActivityContext::CONVERSATION) + null, // attributes + $this->context->conversation); // content + */ } - foreach ($this->context->attention as $attnURI) { - $xs->element('link', array('rel' => 'ostatus:attention', - 'href' => $attnURI)); - $xs->element('link', array('rel' => 'mentioned', + foreach ($this->context->attention as $attnURI=>$type) { + $xs->element('link', array('rel' => ActivityContext::MENTIONED, + ActivityContext::OBJECTTYPE => $type, // FIXME: undocumented 'href' => $attnURI)); } - // XXX: shoulda used ActivityVerb::SHARE - - if (!empty($this->context->forwardID)) { - if (!empty($this->context->forwardUrl)) { - $xs->element('ostatus:forward', - array('ref' => $this->context->forwardID, - 'href' => $this->context->forwardUrl)); - } else { - $xs->element('ostatus:forward', - array('ref' => $this->context->forwardID)); - } - } - if (!empty($this->context->location)) { $loc = $this->context->location; $xs->element('georss:point', null, $loc->lat . ' ' . $loc->lon);