X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=lib%2Factivity.php;h=daf9f4b22effd6ce53b237f6e09c90c2809e841a;hb=586fb5a5175d7a10f5f78dd026434e48202e5451;hp=ecae96b50ab0951f9e6fa2af387c11a42af2797c;hpb=772383e84b298fb12d1e0c1b1d230183199066ad;p=quix0rs-gnu-social.git
diff --git a/lib/activity.php b/lib/activity.php
index ecae96b50a..daf9f4b22e 100644
--- a/lib/activity.php
+++ b/lib/activity.php
@@ -106,7 +106,7 @@ class Activity
public $source; // ActivitySource object representing 'home feed'
public $selfLink; //
public $editLink; //
-
+ public $generator; // ActivityObject representing the generating application
/**
* Turns a regular old Atom into a magical activity
*
@@ -180,7 +180,7 @@ class Activity
foreach ($objectEls as $objectEl) {
// Special case for embedded activities
$objectType = ActivityUtils::childContent($objectEl, self::OBJECTTYPE, self::SPEC);
- if (!empty($objectType) && $objectType == ActivityObject::ACTIVITY) {
+ if ((!empty($objectType) && $objectType == ActivityObject::ACTIVITY) || $this->verb == ActivityVerb::SHARE) {
$this->objects[] = new Activity($objectEl);
} else {
$this->objects[] = new ActivityObject($objectEl);
@@ -244,6 +244,9 @@ class Activity
if (!empty($targetEl)) {
$this->target = new ActivityObject($targetEl);
+ } elseif (ActivityUtils::compareVerbs($this->verb, array(ActivityVerb::FAVORITE))) {
+ // StatusNet didn't send a 'target' for their Favorite atom entries
+ $this->target = clone($this->objects[0]);
}
$this->summary = ActivityUtils::childContent($entry, 'summary');
@@ -264,7 +267,7 @@ class Activity
// From APP. Might be useful.
- $this->selfLink = ActivityUtils::getLink($entry, 'self', 'application/atom+xml');
+ $this->selfLink = ActivityUtils::getSelfLink($entry);
$this->editLink = ActivityUtils::getLink($entry, 'edit', 'application/atom+xml');
}
@@ -366,8 +369,11 @@ class Activity
// content
$activity['content'] = $this->content;
- // generator <-- We could use this when we know a notice is created
- // locally. Or if we know the upstream Generator.
+ // generator
+
+ if (!empty($this->generator)) {
+ $activity['generator'] = $this->generator->asArray();
+ }
// icon <-- possibly a mini object representing verb?
@@ -386,9 +392,10 @@ class Activity
if ($object instanceof Activity) {
// Sharing a post activity is more like sharing the original object
- if ($this->verb == 'share' && $object->verb == 'post') {
+ if (ActivityVerb::canonical($this->verb) == ActivityVerb::canonical(ActivityVerb::SHARE) &&
+ ActivityVerb::canonical($object->verb) == ActivityVerb::canonical(ActivityVerb::POST)) {
// XXX: Here's one for the obfuscation record books
- $object = $object->object;
+ $object = $object->objects[0];
}
}
@@ -479,7 +486,9 @@ class Activity
$activity['verb'] = ActivityVerb::canonical($this->verb);
// url
- $activity['url'] = $this->id;
+ if ($this->link) {
+ $activity['url'] = $this->link;
+ }
/* Purely extensions hereafter */
@@ -570,8 +579,8 @@ class Activity
if (!empty($this->link)) {
$xs->element('link', array('rel' => 'alternate',
- 'type' => 'text/html'),
- $this->link);
+ 'type' => 'text/html',
+ 'href' => $this->link));
}
}
@@ -616,28 +625,33 @@ class Activity
}
if (!empty($this->context->conversation)) {
- $xs->element('link', array('rel' => 'ostatus:conversation',
- 'href' => $this->context->conversation));
- }
-
- foreach ($this->context->attention as $attnURI) {
- $xs->element('link', array('rel' => 'ostatus:attention',
- 'href' => $attnURI));
- $xs->element('link', array('rel' => 'mentioned',
- 'href' => $attnURI));
- }
-
- // XXX: shoulda used ActivityVerb::SHARE
-
- if (!empty($this->context->forwardID)) {
- if (!empty($this->context->forwardUrl)) {
- $xs->element('ostatus:forward',
- array('ref' => $this->context->forwardID,
- 'href' => $this->context->forwardUrl));
+ $convattr = [];
+ $conv = Conversation::getKV('uri', $this->context->conversation);
+ if ($conv instanceof Conversation) {
+ $convattr['href'] = $conv->getUrl();
+ $convattr['local_id'] = $conv->getID();
+ $convattr['ref'] = $conv->getUri();
+ $xs->element('link', array('rel' => 'ostatus:'.ActivityContext::CONVERSATION,
+ 'href' => $convattr['href']));
} else {
- $xs->element('ostatus:forward',
- array('ref' => $this->context->forwardID));
+ $convattr['ref'] = $this->context->conversation;
}
+ $xs->element('ostatus:'.ActivityContext::CONVERSATION,
+ $convattr,
+ $this->context->conversation);
+ /* Since we use XMLWriter we just use the previously hardcoded prefix for ostatus,
+ otherwise we should use something like this:
+ $xs->elementNS(array(ActivityContext::OSTATUS => 'ostatus'), // namespace
+ ActivityContext::CONVERSATION,
+ null, // attributes
+ $this->context->conversation); // content
+ */
+ }
+
+ foreach ($this->context->attention as $attnURI=>$type) {
+ $xs->element('link', array('rel' => ActivityContext::MENTIONED,
+ ActivityContext::OBJECTTYPE => $type, // FIXME: undocumented
+ 'href' => $attnURI));
}
if (!empty($this->context->location)) {