X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=lib%2Fstompqueuemanager.php;h=f059b42f0095f69f5db827bbf3f5698d128f87ba;hb=69ac99ff949ab0118ff25a62471980ad0ec7a52b;hp=7da7c001107edb32a6f316533d1864a107004f5b;hpb=03200235b1a1bba56c24e1bb659023ba24265eb3;p=quix0rs-gnu-social.git

diff --git a/lib/stompqueuemanager.php b/lib/stompqueuemanager.php
index 7da7c00110..f059b42f00 100644
--- a/lib/stompqueuemanager.php
+++ b/lib/stompqueuemanager.php
@@ -1,6 +1,6 @@
 <?php
 /**
- * Laconica, the distributed open-source microblogging tool
+ * StatusNet, the distributed open-source microblogging tool
  *
  * Abstract class for queue managers
  *
@@ -20,12 +20,12 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  *
  * @category  QueueManager
- * @package   Laconica
- * @author    Evan Prodromou <evan@controlyourself.ca>
- * @author    Sarven Capadisli <csarven@controlyourself.ca>
- * @copyright 2009 Control Yourself, Inc.
+ * @package   StatusNet
+ * @author    Evan Prodromou <evan@status.net>
+ * @author    Sarven Capadisli <csarven@status.net>
+ * @copyright 2009 StatusNet, Inc.
  * @license   http://www.fsf.org/licensing/licenses/agpl-3.0.html GNU Affero General Public License version 3.0
- * @link      http://laconi.ca/
+ * @link      http://status.net/
  */
 
 require_once 'Stomp.php';
@@ -108,57 +108,55 @@ class StompQueueManager
 
             $handsocks = $handler->getSockets();
 
-            $this->_log(LOG_DEBUG, "Got ".count($handsocks)." sockets from handler.");
-            $this->_log(LOG_DEBUG, print_r($handsocks, true));
-
             $socks = array_merge(array($stompsock), $handsocks);
 
             $read = $socks;
             $write = array();
             $except = array();
 
-            $this->_log(LOG_DEBUG, "Starting select");
             $ready = stream_select($read, $write, $except, $handler->timeout(), 0);
-            $this->_log(LOG_DEBUG, "Finished select with value '$ready'");
-
-            if (!$ready || $read[0] !== $stompsock) {
-                $handler->idle(QUEUE_HANDLER_MISS_IDLE);
-            } else {
-                $frame = $this->con->readFrame();
-
-                if (!empty($frame)) {
-                    $notice = Notice::staticGet('id', $frame->body);
-
-                    if (empty($notice)) {
-                        $this->_log(LOG_WARNING, 'Got ID '. $frame->body .' for non-existent notice in queue '. $queue);
-                        $this->con->ack($frame);
-                    } else {
-                        if ($handler->handle_notice($notice)) {
-                            $this->_log(LOG_INFO, 'Successfully handled notice '. $notice->id .' posted at ' . $frame->headers['created'] . ' in queue '. $queue);
-                            $this->con->ack($frame);
-                        } else {
-                            $this->_log(LOG_WARNING, 'Failed handling notice '. $notice->id .' posted at ' . $frame->headers['created']  . ' in queue '. $queue);
-                            // FIXME we probably shouldn't have to do
-                            // this kind of queue management ourselves
-                            $this->con->ack($frame);
-                            $this->enqueue($notice, $queue);
-                        }
-                        unset($notice);
-                    }
-
-                    unset($frame);
-
-                    $handler->idle(QUEUE_HANDLER_HIT_IDLE);
 
-                } else {
-                    $handler->idle(QUEUE_HANDLER_MISS_IDLE);
+            if ($ready === false) {
+                $this->_log(LOG_ERR, "Error selecting on sockets");
+            } else if ($ready > 0) {
+                if (in_array($stompsock, $read)) {
+                    $this->_handleNotice($queue, $handler);
                 }
+                $handler->idle(QUEUE_HANDLER_HIT_IDLE);
             }
         }
 
         $this->con->unsubscribe($this->_queueName($queue));
     }
 
+    function _handleNotice($queue, $handler)
+    {
+        $frame = $this->con->readFrame();
+
+        if (!empty($frame)) {
+            $notice = Notice::staticGet('id', $frame->body);
+
+            if (empty($notice)) {
+                $this->_log(LOG_WARNING, 'Got ID '. $frame->body .' for non-existent notice in queue '. $queue);
+                $this->con->ack($frame);
+            } else {
+                if ($handler->handle_notice($notice)) {
+                    $this->_log(LOG_INFO, 'Successfully handled notice '. $notice->id .' posted at ' . $frame->headers['created'] . ' in queue '. $queue);
+                    $this->con->ack($frame);
+                } else {
+                    $this->_log(LOG_WARNING, 'Failed handling notice '. $notice->id .' posted at ' . $frame->headers['created']  . ' in queue '. $queue);
+                    // FIXME we probably shouldn't have to do
+                    // this kind of queue management ourselves
+                    $this->con->ack($frame);
+                    $this->enqueue($notice, $queue);
+                }
+                unset($notice);
+            }
+
+            unset($frame);
+        }
+    }
+
     function _queueName($queue)
     {
         return common_config('queue', 'queue_basename') . $queue;