X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=mod%2Fcommon.php;h=9933c3f51fc2178a76a47bb9ef52f91d90852307;hb=de4a2e6fd03cd0aab94a256eba92ed593931534b;hp=9f9379be57d989cc0dff050ab44eafe7ddb11995;hpb=d4c3dcf2fccefcb2c79881be09fd3b1c73dc611a;p=friendica.git

diff --git a/mod/common.php b/mod/common.php
index 9f9379be57..9933c3f51f 100644
--- a/mod/common.php
+++ b/mod/common.php
@@ -1,11 +1,16 @@
 <?php
+/**
+ * @file include/common.php
+ */
+use Friendica\App;
+use Friendica\Database\DBM;
+use Friendica\Model\GlobalContact;
+use Friendica\Object\Contact;
 
-require_once('include/socgraph.php');
-require_once('include/Contact.php');
-require_once('include/contact_selectors.php');
-require_once('mod/contacts.php');
+require_once 'include/contact_selectors.php';
+require_once 'mod/contacts.php';
 
-function common_content(&$a) {
+function common_content(App $a) {
 
 	$o = '';
 
@@ -19,23 +24,27 @@ function common_content(&$a) {
 		return;
 	}
 
-	if($cmd !== 'loc' && $cmd != 'rem')
+	if ($cmd !== 'loc' && $cmd != 'rem') {
 		return;
+	}
 
-	if(! $uid)
+	if (! $uid) {
 		return;
+	}
 
-	if($cmd === 'loc' && $cid) {
+	if ($cmd === 'loc' && $cid) {
 		$c = q("SELECT `name`, `url`, `photo` FROM `contact` WHERE `id` = %d AND `uid` = %d LIMIT 1",
 			intval($cid),
 			intval($uid)
 		);
+		/// @TODO Handle $c with DBM::is_result()
 		$a->page['aside'] = "";
-		profile_load($a, "", 0, get_contact_details_by_url($c[0]["url"]));
+		profile_load($a, "", 0, Contact::getDetailsByURL($c[0]["url"]));
 	} else {
 		$c = q("SELECT `name`, `url`, `photo` FROM `contact` WHERE `self` = 1 AND `uid` = %d LIMIT 1",
 			intval($uid)
 		);
+		/// @TODO Handle $c with DBM::is_result()
 
 		$vcard_widget .= replace_macros(get_markup_template("vcard-widget.tpl"),array(
 			'$name' => htmlentities($c[0]['name']),
@@ -43,13 +52,15 @@ function common_content(&$a) {
 			'url' => 'contacts/' . $cid
 		));
 
-		if(! x($a->page,'aside'))
+		if (! x($a->page,'aside')) {
 			$a->page['aside'] = '';
+		}
 		$a->page['aside'] .= $vcard_widget;
 	}
 
-	if(! count($c))
+	if (! DBM::is_result($c)) {
 		return;
+	}
 
 	if(! $cid) {
 		if(get_my_url()) {
@@ -57,87 +68,89 @@ function common_content(&$a) {
 				dbesc(normalise_link(get_my_url())),
 				intval($profile_uid)
 			);
-			if (dbm::is_result($r))
+			if (DBM::is_result($r))
 				$cid = $r[0]['id'];
 			else {
 				$r = q("SELECT `id` FROM `gcontact` WHERE `nurl` = '%s' LIMIT 1",
 					dbesc(normalise_link(get_my_url()))
 				);
-				if (dbm::is_result($r))
+				if (DBM::is_result($r))
 					$zcid = $r[0]['id'];
 			}
 		}
 	}
 
-
-
-	if($cid == 0 && $zcid == 0)
+	if ($cid == 0 && $zcid == 0) {
 		return;
+	}
 
+	if ($cid) {
+		$t = GlobalContact::countCommonFriends($uid, $cid);
+	} else {
+		$t = GlobalContact::countCommonFriendsZcid($uid, $zcid);
+	}
 
-	if($cid)
-		$t = count_common_friends($uid, $cid);
-	else
-		$t = count_common_friends_zcid($uid, $zcid);
-
-	if(count($t))
+	if (count($t)) {
 		$a->set_pager_total($t);
-	else {
-		notice( t('No contacts in common.') . EOL);
+	} else {
+		notice(t('No contacts in common.') . EOL);
 		return $o;
 	}
 
 
-	if($cid)
-		$r = common_friends($uid, $cid, $a->pager['start'], $a->pager['itemspage']);
-	else
-		$r = common_friends_zcid($uid, $zcid, $a->pager['start'], $a->pager['itemspage']);
+	if ($cid) {
+		$r = GlobalContact::commonFriends($uid, $cid, $a->pager['start'], $a->pager['itemspage']);
+	} else {
+		$r = GlobalContact::commonFriendsZcid($uid, $zcid, $a->pager['start'], $a->pager['itemspage']);
+	}
 
 
-	if(! dbm::is_result($r)) {
+	if (! DBM::is_result($r)) {
 		return $o;
 	}
 
 	$id = 0;
 
-	foreach($r as $rr) {
+	foreach ($r as $rr) {
 
 		//get further details of the contact
-		$contact_details = get_contact_details_by_url($rr['url'], $uid);
+		$contact_details = Contact::getDetailsByURL($rr['url'], $uid);
 
-		// $rr[id] is needed to use contact_photo_menu()
-		$rr[id] = $rr[cid];
+		// $rr['id'] is needed to use contact_photo_menu()
+		/// @TODO Adding '/" here avoids E_NOTICE on missing constants
+		$rr['id'] = $rr['cid'];
 
 		$photo_menu = '';
-		$photo_menu = contact_photo_menu($rr);
+		$photo_menu = Contact::photoMenu($rr);
 
 		$entry = array(
-			'url'		=> $rr['url'],
-			'itemurl'	=> (($contact_details['addr'] != "") ? $contact_details['addr'] : $rr['url']),
-			'name'		=> $contact_details['name'],
-			'thumb'		=> proxy_url($contact_details['thumb'], false, PROXY_SIZE_THUMB),
-			'img_hover'	=> htmlentities($contact_details['name']),
-			'details'	=> $contact_details['location'],
-			'tags'		=> $contact_details['keywords'],
-			'about'		=> $contact_details['about'],
-			'account_type'	=> account_type($contact_details),
-			'network'	=> network_to_name($contact_details['network'], $contact_details['url']),
-			'photo_menu'	=> $photo_menu,
-			'id'		=> ++$id,
+			'url'          => $rr['url'],
+			'itemurl'      => (($contact_details['addr'] != "") ? $contact_details['addr'] : $rr['url']),
+			'name'         => $contact_details['name'],
+			'thumb'        => proxy_url($contact_details['thumb'], false, PROXY_SIZE_THUMB),
+			'img_hover'    => htmlentities($contact_details['name']),
+			'details'      => $contact_details['location'],
+			'tags'         => $contact_details['keywords'],
+			'about'        => $contact_details['about'],
+			'account_type' => Contact::getAccountType($contact_details),
+			'network'      => network_to_name($contact_details['network'], $contact_details['url']),
+			'photo_menu'   => $photo_menu,
+			'id'           => ++$id,
 		);
 		$entries[] = $entry;
 	}
 
-	if($cmd === 'loc' && $cid && $uid == local_user()) {
+	if ($cmd === 'loc' && $cid && $uid == local_user()) {
 		$tab_str = contacts_tab($a, $cid, 4);
-	} else
+	} else {
 		$title = t('Common Friends');
+	}
 
 	$tpl = get_markup_template('viewcontact_template.tpl');
 
 	$o .= replace_macros($tpl,array(
-		'$title' => $title,
-		'$tab_str' => $tab_str,
+		'$title'    => $title,
+		'$tab_str'  => $tab_str,
 		'$contacts' => $entries,
 		'$paginate' => paginate($a),
 	));