X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=mod%2Fevents.php;h=04a88e98bb5056eb2d845ffe65e53b9b822086e6;hb=122ad0af14f046c2462a03fe33967dc41abfc8b5;hp=5a5a22d3186bd194a079dc407966a30c7e7ef472;hpb=9a4240c3b2f1d31a60f823223dcbb9b24d67e20d;p=friendica.git diff --git a/mod/events.php b/mod/events.php index 5a5a22d318..04a88e98bb 100644 --- a/mod/events.php +++ b/mod/events.php @@ -1,26 +1,42 @@ . + * + * The events module */ use Friendica\App; -use Friendica\BaseObject; use Friendica\Content\Nav; use Friendica\Content\Widget\CalendarExport; use Friendica\Core\ACL; -use Friendica\Core\L10n; use Friendica\Core\Logger; +use Friendica\Core\Protocol; use Friendica\Core\Renderer; -use Friendica\Core\System; use Friendica\Core\Theme; use Friendica\Core\Worker; use Friendica\Database\DBA; +use Friendica\DI; +use Friendica\Model\Conversation; use Friendica\Model\Event; use Friendica\Model\Item; -use Friendica\Model\Profile; -use Friendica\Module\Login; -use Friendica\Util\ACLFormatter; +use Friendica\Model\User; +use Friendica\Module\BaseProfile; +use Friendica\Module\Security\Login; use Friendica\Util\DateTimeFormat; use Friendica\Util\Strings; use Friendica\Util\Temporal; @@ -38,22 +54,20 @@ function events_init(App $a) return; } - if (empty($a->page['aside'])) { - $a->page['aside'] = ''; + if (empty(DI::page()['aside'])) { + DI::page()['aside'] = ''; } $cal_widget = CalendarExport::getHTML(); - $a->page['aside'] .= $cal_widget; + DI::page()['aside'] .= $cal_widget; return; } function events_post(App $a) { - - Logger::log('post: ' . print_r($_REQUEST, true), Logger::DATA); - + Logger::debug('post', ['request' => $_REQUEST]); if (!local_user()) { return; } @@ -68,6 +82,8 @@ function events_post(App $a) $adjust = intval($_POST['adjust'] ?? 0); $nofinish = intval($_POST['nofinish'] ?? 0); + $share = intval($_POST['share'] ?? 0); + // The default setting for the `private` field in event_store() is false, so mirror that $private_event = false; @@ -115,66 +131,62 @@ function events_post(App $a) ]; $action = ($event_id == '') ? 'new' : 'event/' . $event_id; - $onerror_path = 'events/' . $action . '?' . http_build_query($params, null, null, PHP_QUERY_RFC3986); + $onerror_path = 'events/' . $action . '?' . http_build_query($params, '', '&', PHP_QUERY_RFC3986); if (strcmp($finish, $start) < 0 && !$nofinish) { - notice(L10n::t('Event can not end before it has started.') . EOL); + notice(DI::l10n()->t('Event can not end before it has started.')); if (intval($_REQUEST['preview'])) { - echo L10n::t('Event can not end before it has started.'); + echo DI::l10n()->t('Event can not end before it has started.'); exit(); } - $a->internalRedirect($onerror_path); + DI::baseUrl()->redirect($onerror_path); } if (!$summary || ($start === DBA::NULL_DATETIME)) { - notice(L10n::t('Event title and start time are required.') . EOL); + notice(DI::l10n()->t('Event title and start time are required.')); if (intval($_REQUEST['preview'])) { - echo L10n::t('Event title and start time are required.'); + echo DI::l10n()->t('Event title and start time are required.'); exit(); } - $a->internalRedirect($onerror_path); + DI::baseUrl()->redirect($onerror_path); } - $share = intval($_POST['share'] ?? 0); - - $c = q("SELECT `id` FROM `contact` WHERE `uid` = %d AND `self` LIMIT 1", - intval(local_user()) - ); - - if (DBA::isResult($c)) { - $self = $c[0]['id']; - } else { - $self = 0; - } + $self = \Friendica\Model\Contact::getPublicIdByUserId($uid); + $aclFormatter = DI::aclFormatter(); if ($share) { - - /** @var ACLFormatter $aclFormatter */ - $aclFormatter = BaseObject::getClass(ACLFormatter::class); - - $str_group_allow = $aclFormatter->toString($_POST['group_allow'] ?? ''); - $str_contact_allow = $aclFormatter->toString($_POST['contact_allow'] ?? ''); - $str_group_deny = $aclFormatter->toString($_POST['group_deny'] ?? ''); - $str_contact_deny = $aclFormatter->toString($_POST['contact_deny'] ?? ''); - - // Undo the pseudo-contact of self, since there are real contacts now - if (strpos($str_contact_allow, '<' . $self . '>') !== false) { - $str_contact_allow = str_replace('<' . $self . '>', '', $str_contact_allow); - } - // Make sure to set the `private` field as true. This is necessary to - // have the posts show up correctly in Diaspora if an event is created - // as visible only to self at first, but then edited to display to others. - if (strlen($str_group_allow) || strlen($str_contact_allow) || strlen($str_group_deny) || strlen($str_contact_deny)) { - $private_event = true; + $user = User::getById($uid, ['allow_cid', 'allow_gid', 'deny_cid', 'deny_gid']); + if (!DBA::isResult($user)) { + return; + } + + $str_contact_allow = isset($_REQUEST['contact_allow']) ? $aclFormatter->toString($_REQUEST['contact_allow']) : $user['allow_cid'] ?? ''; + $str_group_allow = isset($_REQUEST['group_allow']) ? $aclFormatter->toString($_REQUEST['group_allow']) : $user['allow_gid'] ?? ''; + $str_contact_deny = isset($_REQUEST['contact_deny']) ? $aclFormatter->toString($_REQUEST['contact_deny']) : $user['deny_cid'] ?? ''; + $str_group_deny = isset($_REQUEST['group_deny']) ? $aclFormatter->toString($_REQUEST['group_deny']) : $user['deny_gid'] ?? ''; + + $visibility = $_REQUEST['visibility'] ?? ''; + if ($visibility === 'public') { + // The ACL selector introduced in version 2019.12 sends ACL input data even when the Public visibility is selected + $str_contact_allow = $str_group_allow = $str_contact_deny = $str_group_deny = ''; + } else if ($visibility === 'custom') { + // Since we know from the visibility parameter the item should be private, we have to prevent the empty ACL + // case that would make it public. So we always append the author's contact id to the allowed contacts. + // See https://github.com/friendica/friendica/issues/9672 + $str_contact_allow .= $aclFormatter->toString($self); } } else { - // Note: do not set `private` field for self-only events. It will - // keep even you from seeing them! - $str_contact_allow = '<' . $self . '>'; + $str_contact_allow = $aclFormatter->toString($self); $str_group_allow = $str_contact_deny = $str_group_deny = ''; } + // Make sure to set the `private` field as true. This is necessary to + // have the posts show up correctly in Diaspora if an event is created + // as visible only to self at first, but then edited to display to others. + if (strlen($str_group_allow) || strlen($str_contact_allow) || strlen($str_group_deny) || strlen($str_contact_deny)) { + $private_event = true; + } $datarray = []; $datarray['start'] = $start; @@ -193,6 +205,9 @@ function events_post(App $a) $datarray['deny_gid'] = $str_group_deny; $datarray['private'] = $private_event; $datarray['id'] = $event_id; + $datarray['network'] = Protocol::DFRN; + $datarray['protocol'] = Conversation::PARCEL_DIRECT; + $datarray['direction'] = Conversation::PUSH; if (intval($_REQUEST['preview'])) { $html = Event::getHTML($datarray); @@ -206,18 +221,18 @@ function events_post(App $a) Worker::add(PRIORITY_HIGH, "Notifier", Delivery::POST, $item_id); } - $a->internalRedirect('events'); + DI::baseUrl()->redirect('events'); } function events_content(App $a) { if (!local_user()) { - notice(L10n::t('Permission denied.') . EOL); + notice(DI::l10n()->t('Permission denied.')); return Login::form(); } if ($a->argc == 1) { - $_SESSION['return_path'] = $a->cmd; + $_SESSION['return_path'] = DI::args()->getCommand(); } if (($a->argc > 2) && ($a->argv[1] === 'ignore') && intval($a->argv[2])) { @@ -243,8 +258,13 @@ function events_content(App $a) // get the translation strings for the callendar $i18n = Event::getStrings(); + DI::page()->registerStylesheet('view/asset/fullcalendar/dist/fullcalendar.min.css'); + DI::page()->registerStylesheet('view/asset/fullcalendar/dist/fullcalendar.print.min.css', 'print'); + DI::page()->registerFooterScript('view/asset/moment/min/moment-with-locales.min.js'); + DI::page()->registerFooterScript('view/asset/fullcalendar/dist/fullcalendar.min.js'); + $htpl = Renderer::getMarkupTemplate('event_head.tpl'); - $a->page['htmlhead'] .= Renderer::replaceMacros($htpl, [ + DI::page()['htmlhead'] .= Renderer::replaceMacros($htpl, [ '$module_url' => '/events', '$modparams' => 1, '$i18n' => $i18n, @@ -254,7 +274,7 @@ function events_content(App $a) $tabs = ''; // tabs if ($a->theme_events_in_profile) { - $tabs = Profile::getTabs($a, 'events', true); + $tabs = BaseProfile::getTabsHTML($a, 'events', true); } $mode = 'view'; @@ -350,7 +370,7 @@ function events_content(App $a) foreach ($r as $rr) { $j = $rr['adjust'] ? DateTimeFormat::local($rr['start'], 'j') : DateTimeFormat::utc($rr['start'], 'j'); if (empty($links[$j])) { - $links[$j] = System::baseUrl() . '/' . $a->cmd . '#link-' . $j; + $links[$j] = DI::baseUrl() . '/' . DI::args()->getCommand() . '#link-' . $j; } } } @@ -386,27 +406,27 @@ function events_content(App $a) } // ACL blocks are loaded in modals in frio - $a->page->registerFooterScript(Theme::getPathForFile('asset/typeahead.js/dist/typeahead.bundle.js')); - $a->page->registerFooterScript(Theme::getPathForFile('js/friendica-tagsinput/friendica-tagsinput.js')); - $a->page->registerStylesheet(Theme::getPathForFile('js/friendica-tagsinput/friendica-tagsinput.css')); - $a->page->registerStylesheet(Theme::getPathForFile('js/friendica-tagsinput/friendica-tagsinput-typeahead.css')); + DI::page()->registerFooterScript(Theme::getPathForFile('asset/typeahead.js/dist/typeahead.bundle.js')); + DI::page()->registerFooterScript(Theme::getPathForFile('js/friendica-tagsinput/friendica-tagsinput.js')); + DI::page()->registerStylesheet(Theme::getPathForFile('js/friendica-tagsinput/friendica-tagsinput.css')); + DI::page()->registerStylesheet(Theme::getPathForFile('js/friendica-tagsinput/friendica-tagsinput-typeahead.css')); $o = Renderer::replaceMacros($tpl, [ '$tabs' => $tabs, - '$title' => L10n::t('Events'), - '$view' => L10n::t('View'), - '$new_event' => [System::baseUrl() . '/events/new', L10n::t('Create New Event'), '', ''], - '$previous' => [System::baseUrl() . '/events/$prevyear/$prevmonth', L10n::t('Previous'), '', ''], - '$next' => [System::baseUrl() . '/events/$nextyear/$nextmonth', L10n::t('Next'), '', ''], + '$title' => DI::l10n()->t('Events'), + '$view' => DI::l10n()->t('View'), + '$new_event' => [DI::baseUrl() . '/events/new', DI::l10n()->t('Create New Event'), '', ''], + '$previous' => [DI::baseUrl() . '/events/$prevyear/$prevmonth', DI::l10n()->t('Previous'), '', ''], + '$next' => [DI::baseUrl() . '/events/$nextyear/$nextmonth', DI::l10n()->t('Next'), '', ''], '$calendar' => Temporal::getCalendarTable($y, $m, $links, ' eventcal'), '$events' => $events, - '$today' => L10n::t('today'), - '$month' => L10n::t('month'), - '$week' => L10n::t('week'), - '$day' => L10n::t('day'), - '$list' => L10n::t('list'), + '$today' => DI::l10n()->t('today'), + '$month' => DI::l10n()->t('month'), + '$week' => DI::l10n()->t('week'), + '$day' => DI::l10n()->t('day'), + '$list' => DI::l10n()->t('list'), ]); if (!empty($_GET['id'])) { @@ -429,15 +449,23 @@ function events_content(App $a) // Passed parameters overrides anything found in the DB if (in_array($mode, ['edit', 'new', 'copy'])) { + $share_checked = ''; + $share_disabled = ''; + if (empty($orig_event)) { - $orig_event = []; + $orig_event = User::getById(local_user(), ['allow_cid', 'allow_gid', 'deny_cid', 'deny_gid']);; + } elseif ($orig_event['allow_cid'] !== '<' . local_user() . '>' + || $orig_event['allow_gid'] + || $orig_event['deny_cid'] + || $orig_event['deny_gid']) { + $share_checked = ' checked="checked" '; } // In case of an error the browser is redirected back here, with these parameters filled in with the previous values if (!empty($_REQUEST['nofinish'])) {$orig_event['nofinish'] = $_REQUEST['nofinish'];} if (!empty($_REQUEST['adjust'])) {$orig_event['adjust'] = $_REQUEST['adjust'];} if (!empty($_REQUEST['summary'])) {$orig_event['summary'] = $_REQUEST['summary'];} - if (!empty($_REQUEST['description'])) {$orig_event['description'] = $_REQUEST['description'];} + if (!empty($_REQUEST['desc'])) {$orig_event['desc'] = $_REQUEST['desc'];} if (!empty($_REQUEST['location'])) {$orig_event['location'] = $_REQUEST['location'];} if (!empty($_REQUEST['start'])) {$orig_event['start'] = $_REQUEST['start'];} if (!empty($_REQUEST['finish'])) {$orig_event['finish'] = $_REQUEST['finish'];} @@ -445,31 +473,19 @@ function events_content(App $a) $n_checked = (!empty($orig_event['nofinish']) ? ' checked="checked" ' : ''); $a_checked = (!empty($orig_event['adjust']) ? ' checked="checked" ' : ''); - $t_orig = !empty($orig_event) ? $orig_event['summary'] : ''; - $d_orig = !empty($orig_event) ? $orig_event['desc'] : ''; - $l_orig = !empty($orig_event) ? $orig_event['location'] : ''; - $eid = !empty($orig_event) ? $orig_event['id'] : 0; - $cid = !empty($orig_event) ? $orig_event['cid'] : 0; - $uri = !empty($orig_event) ? $orig_event['uri'] : ''; - - $sh_disabled = ''; - $sh_checked = ''; - - if (!empty($orig_event) - && ($orig_event['allow_cid'] !== '<' . local_user() . '>' - || $orig_event['allow_gid'] - || $orig_event['deny_cid'] - || $orig_event['deny_gid'])) - { - $sh_checked = ' checked="checked" '; - } + $t_orig = $orig_event['summary'] ?? ''; + $d_orig = $orig_event['desc'] ?? ''; + $l_orig = $orig_event['location'] ?? ''; + $eid = $orig_event['id'] ?? 0; + $cid = $orig_event['cid'] ?? 0; + $uri = $orig_event['uri'] ?? ''; if ($cid || $mode === 'edit') { - $sh_disabled = 'disabled="disabled"'; + $share_disabled = 'disabled="disabled"'; } - $sdt = !empty($orig_event) ? $orig_event['start'] : 'now'; - $fdt = !empty($orig_event) ? $orig_event['finish'] : 'now'; + $sdt = $orig_event['start'] ?? 'now'; + $fdt = $orig_event['finish'] ?? 'now'; $tz = date_default_timezone_get(); if (!empty($orig_event)) { @@ -491,7 +507,7 @@ function events_content(App $a) $fminute = !empty($orig_event) ? DateTimeFormat::convert($fdt, $tz, 'UTC', 'i') : '00'; if (!$cid && in_array($mode, ['new', 'copy'])) { - $acl = ACL::getFullSelectorHTML($a->page, $a->user, false, ACL::getDefaultUserPermissions($orig_event)); + $acl = ACL::getFullSelectorHTML(DI::page(), $a->user, false, ACL::getDefaultUserPermissions($orig_event)); } else { $acl = ''; } @@ -506,19 +522,19 @@ function events_content(App $a) $tpl = Renderer::getMarkupTemplate('event_form.tpl'); $o .= Renderer::replaceMacros($tpl, [ - '$post' => System::baseUrl() . '/events', + '$post' => DI::baseUrl() . '/events', '$eid' => $eid, '$cid' => $cid, '$uri' => $uri, - '$title' => L10n::t('Event details'), - '$desc' => L10n::t('Starting date and Title are required.'), - '$s_text' => L10n::t('Event Starts:') . ' *', + '$title' => DI::l10n()->t('Event details'), + '$desc' => DI::l10n()->t('Starting date and Title are required.'), + '$s_text' => DI::l10n()->t('Event Starts:') . ' *', '$s_dsel' => Temporal::getDateTimeField( new DateTime(), DateTime::createFromFormat('Y', intval($syear) + 5), DateTime::createFromFormat('Y-m-d H:i', "$syear-$smonth-$sday $shour:$sminute"), - L10n::t('Event Starts:'), + DI::l10n()->t('Event Starts:'), 'start_text', true, true, @@ -526,39 +542,39 @@ function events_content(App $a) '', true ), - '$n_text' => L10n::t('Finish date/time is not known or not relevant'), + '$n_text' => DI::l10n()->t('Finish date/time is not known or not relevant'), '$n_checked' => $n_checked, - '$f_text' => L10n::t('Event Finishes:'), + '$f_text' => DI::l10n()->t('Event Finishes:'), '$f_dsel' => Temporal::getDateTimeField( new DateTime(), DateTime::createFromFormat('Y', intval($fyear) + 5), DateTime::createFromFormat('Y-m-d H:i', "$fyear-$fmonth-$fday $fhour:$fminute"), - L10n::t('Event Finishes:'), + DI::l10n()->t('Event Finishes:'), 'finish_text', true, true, 'start_text' ), - '$a_text' => L10n::t('Adjust for viewer timezone'), + '$a_text' => DI::l10n()->t('Adjust for viewer timezone'), '$a_checked' => $a_checked, - '$d_text' => L10n::t('Description:'), + '$d_text' => DI::l10n()->t('Description:'), '$d_orig' => $d_orig, - '$l_text' => L10n::t('Location:'), + '$l_text' => DI::l10n()->t('Location:'), '$l_orig' => $l_orig, - '$t_text' => L10n::t('Title:') . ' *', + '$t_text' => DI::l10n()->t('Title:') . ' *', '$t_orig' => $t_orig, - '$summary' => ['summary', L10n::t('Title:'), $t_orig, '', '*'], - '$sh_text' => L10n::t('Share this event'), - '$share' => ['share', L10n::t('Share this event'), $sh_checked, '', $sh_disabled], - '$sh_checked' => $sh_checked, - '$nofinish' => ['nofinish', L10n::t('Finish date/time is not known or not relevant'), $n_checked], - '$adjust' => ['adjust', L10n::t('Adjust for viewer timezone'), $a_checked], - '$preview' => L10n::t('Preview'), + '$summary' => ['summary', DI::l10n()->t('Title:'), $t_orig, '', '*'], + '$sh_text' => DI::l10n()->t('Share this event'), + '$share' => ['share', DI::l10n()->t('Share this event'), $share_checked, '', $share_disabled], + '$sh_checked' => $share_checked, + '$nofinish' => ['nofinish', DI::l10n()->t('Finish date/time is not known or not relevant'), $n_checked], + '$adjust' => ['adjust', DI::l10n()->t('Adjust for viewer timezone'), $a_checked], + '$preview' => DI::l10n()->t('Preview'), '$acl' => $acl, - '$submit' => L10n::t('Submit'), - '$basic' => L10n::t('Basic'), - '$advanced' => L10n::t('Advanced'), - '$permissions' => L10n::t('Permissions'), + '$submit' => DI::l10n()->t('Submit'), + '$basic' => DI::l10n()->t('Basic'), + '$advanced' => DI::l10n()->t('Advanced'), + '$permissions' => DI::l10n()->t('Permissions'), ]); return $o; @@ -574,11 +590,9 @@ function events_content(App $a) } if (Item::exists(['id' => $ev[0]['itemid']])) { - notice(L10n::t('Failed to remove event') . EOL); - } else { - info(L10n::t('Event removed') . EOL); + notice(DI::l10n()->t('Failed to remove event')); } - $a->internalRedirect('events'); + DI::baseUrl()->redirect('events'); } }