X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=mod%2Ffollow.php;h=818a1ae5e95c7dd6ac0291655a2d50799ef5d526;hb=3444c29b0bf56b84d58516991f65cebb03fb627e;hp=2a5241a0ca47673f853fb25c94a742421887a719;hpb=79d766b55246a760b1abe2f189693c5f5699a1a8;p=friendica.git

diff --git a/mod/follow.php b/mod/follow.php
index 2a5241a0ca..818a1ae5e9 100644
--- a/mod/follow.php
+++ b/mod/follow.php
@@ -1,8 +1,26 @@
 <?php
 /**
- * @file mod/follow.php
+ * @copyright Copyright (C) 2010-2022, the Friendica project
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
  */
+
 use Friendica\App;
+use Friendica\Content\Widget;
 use Friendica\Core\Protocol;
 use Friendica\Core\Renderer;
 use Friendica\DI;
@@ -11,6 +29,8 @@ use Friendica\Model\Profile;
 use Friendica\Model\Item;
 use Friendica\Network\Probe;
 use Friendica\Database\DBA;
+use Friendica\Model\Post;
+use Friendica\Model\User;
 use Friendica\Util\Strings;
 
 function follow_post(App $a)
@@ -23,32 +43,9 @@ function follow_post(App $a)
 		DI::baseUrl()->redirect('contact');
 	}
 
-	$uid = local_user();
-	$url = Strings::escapeTags(trim($_REQUEST['url']));
-	$return_path = 'follow?url=' . urlencode($url);
-
-	// Makes the connection request for friendica contacts easier
-	// This is just a precaution if maybe this page is called somewhere directly via POST
-	$_SESSION['fastlane'] = $url;
-
-	$result = Contact::createFromProbe($uid, $url, true);
-
-	if ($result['success'] == false) {
-		// Possibly it is a remote item and not an account
-		follow_remote_item($url);
-
-		if ($result['message']) {
-			notice($result['message']);
-		}
-		DI::baseUrl()->redirect($return_path);
-	} elseif ($result['cid']) {
-		DI::baseUrl()->redirect('contact/' . $result['cid']);
-	}
-
-	info(DI::l10n()->t('The contact could not be added.'));
+	$url = Probe::cleanURI($_REQUEST['url']);
 
-	DI::baseUrl()->redirect($return_path);
-	// NOTREACHED
+	follow_process($a, $url);
 }
 
 function follow_content(App $a)
@@ -63,8 +60,7 @@ function follow_content(App $a)
 
 	$uid = local_user();
 
-	// Issue 4815: Silently removing a prefixing @
-	$url = ltrim(Strings::escapeTags(trim($_REQUEST['url'] ?? '')), '@!');
+	$url = Probe::cleanURI(trim($_REQUEST['url'] ?? ''));
 
 	// Issue 6874: Allow remote following from Peertube
 	if (strpos($url, 'acct:') === 0) {
@@ -78,135 +74,125 @@ function follow_content(App $a)
 	$submit = DI::l10n()->t('Submit Request');
 
 	// Don't try to add a pending contact
-	$r = q("SELECT `pending` FROM `contact` WHERE `uid` = %d AND ((`rel` != %d) OR (`network` = '%s')) AND
-		(`nurl` = '%s' OR `alias` = '%s' OR `alias` = '%s') AND
-		`network` != '%s' LIMIT 1",
-		intval(local_user()), DBA::escape(Contact::FOLLOWER), DBA::escape(Protocol::DFRN), DBA::escape(Strings::normaliseLink($url)),
-		DBA::escape(Strings::normaliseLink($url)), DBA::escape($url), DBA::escape(Protocol::STATUSNET));
-
-	if ($r) {
-		if ($r[0]['pending']) {
+	$user_contact = DBA::selectFirst('contact', ['pending'], ["`uid` = ? AND ((`rel` != ?) OR (`network` = ?)) AND
+		(`nurl` = ? OR `alias` = ? OR `alias` = ?) AND `network` != ?",
+		$uid, Contact::FOLLOWER, Protocol::DFRN, Strings::normaliseLink($url),
+		Strings::normaliseLink($url), $url, Protocol::STATUSNET]);
+
+	if (DBA::isResult($user_contact)) {
+		if ($user_contact['pending']) {
 			notice(DI::l10n()->t('You already added this contact.'));
 			$submit = '';
-			//$a->internalRedirect($_SESSION['return_path']);
-			// NOTREACHED
 		}
 	}
 
-	$ret = Probe::uri($url);
+	$contact = Contact::getByURL($url, true);
+
+	// Possibly it is a mail contact
+	if (empty($contact)) {
+		$contact = Probe::uri($url, Protocol::MAIL, $uid);
+	}
+
+	if (empty($contact) || ($contact['network'] == Protocol::PHANTOM)) {
+		// Possibly it is a remote item and not an account
+		follow_remote_item($url);
+
+		notice(DI::l10n()->t("The network type couldn't be detected. Contact can't be added."));
+		$submit = '';
+		$contact = ['url' => $url, 'network' => Protocol::PHANTOM, 'name' => $url, 'keywords' => ''];
+	}
 
-	$protocol = Contact::getProtocol($ret['url'], $ret['network']);
+	$protocol = Contact::getProtocol($contact['url'], $contact['network']);
 
 	if (($protocol == Protocol::DIASPORA) && !DI::config()->get('system', 'diaspora_enabled')) {
 		notice(DI::l10n()->t("Diaspora support isn't enabled. Contact can't be added."));
 		$submit = '';
-		//$a->internalRedirect($_SESSION['return_path']);
-		// NOTREACHED
 	}
 
 	if (($protocol == Protocol::OSTATUS) && DI::config()->get('system', 'ostatus_disabled')) {
 		notice(DI::l10n()->t("OStatus support is disabled. Contact can't be added."));
 		$submit = '';
-		//$a->internalRedirect($_SESSION['return_path']);
-		// NOTREACHED
-	}
-
-	if ($protocol == Protocol::PHANTOM) {
-		// Possibly it is a remote item and not an account
-		follow_remote_item($url);
-
-		notice(DI::l10n()->t("The network type couldn't be detected. Contact can't be added."));
-		$submit = '';
-		//$a->internalRedirect($_SESSION['return_path']);
-		// NOTREACHED
 	}
 
 	if ($protocol == Protocol::MAIL) {
-		$ret['url'] = $ret['addr'];
+		$contact['url'] = $contact['addr'];
 	}
 
-	if (($protocol === Protocol::DFRN) && !DBA::isResult($r)) {
-		$request = $ret['request'];
-		$tpl = Renderer::getMarkupTemplate('dfrn_request.tpl');
-	} else {
-		$request = DI::baseUrl() . '/follow';
-		$tpl = Renderer::getMarkupTemplate('auto_request.tpl');
+	if (!empty($_REQUEST['auto'])) {
+		follow_process($a, $contact['url']);
 	}
 
-	$r = q("SELECT `url` FROM `contact` WHERE `uid` = %d AND `self` LIMIT 1", intval($uid));
+	$request = DI::baseUrl() . '/follow';
+	$tpl = Renderer::getMarkupTemplate('auto_request.tpl');
 
-	if (!$r) {
+	$owner = User::getOwnerDataById($uid);
+	if (empty($owner)) {
 		notice(DI::l10n()->t('Permission denied.'));
 		DI::baseUrl()->redirect($return_path);
 		// NOTREACHED
 	}
 
-	$myaddr = $r[0]['url'];
-	$gcontact_id = 0;
-
-	// Makes the connection request for friendica contacts easier
-	$_SESSION['fastlane'] = $ret['url'];
-
-	$r = q("SELECT `id`, `location`, `about`, `keywords` FROM `gcontact` WHERE `nurl` = '%s'",
-		Strings::normaliseLink($ret['url']));
-
-	if (!$r) {
-		$r = [['location' => '', 'about' => '', 'keywords' => '']];
-	} else {
-		$gcontact_id = $r[0]['id'];
-	}
-
-	if ($protocol === Protocol::DIASPORA) {
-		$r[0]['location'] = '';
-		$r[0]['about'] = '';
-	}
+	$myaddr = $owner['url'];
 
 	$o = Renderer::replaceMacros($tpl, [
 		'$header'        => DI::l10n()->t('Connect/Follow'),
-		'$desc'          => '',
 		'$pls_answer'    => DI::l10n()->t('Please answer the following:'),
-		'$does_know_you' => ['knowyou', DI::l10n()->t('Does %s know you?', $ret['name'])],
-		'$add_note'      => DI::l10n()->t('Add a personal note:'),
-		'$page_desc'     => '',
-		'$friendica'     => '',
-		'$statusnet'     => '',
-		'$diaspora'      => '',
-		'$diasnote'      => '',
 		'$your_address'  => DI::l10n()->t('Your Identity Address:'),
-		'$invite_desc'   => '',
-		'$emailnet'      => '',
+		'$url_label'     => DI::l10n()->t('Profile URL'),
+		'$keywords_label'=> DI::l10n()->t('Tags:'),
 		'$submit'        => $submit,
 		'$cancel'        => DI::l10n()->t('Cancel'),
-		'$nickname'      => '',
-		'$name'          => $ret['name'],
-		'$url'           => $ret['url'],
-		'$zrl'           => Profile::zrl($ret['url']),
-		'$url_label'     => DI::l10n()->t('Profile URL'),
-		'$myaddr'        => $myaddr,
+
 		'$request'       => $request,
-		'$keywords'      => $r[0]['keywords'],
-		'$keywords_label'=> DI::l10n()->t('Tags:')
+		'$name'          => $contact['name'],
+		'$url'           => $contact['url'],
+		'$zrl'           => Profile::zrl($contact['url']),
+		'$myaddr'        => $myaddr,
+		'$keywords'      => $contact['keywords'],
+
+		'$does_know_you' => ['knowyou', DI::l10n()->t('%s knows you', $contact['name'])],
+		'$addnote_field' => ['dfrn-request-message', DI::l10n()->t('Add a personal note:')],
 	]);
 
 	DI::page()['aside'] = '';
 
-	$profiledata = Contact::getDetailsByURL($ret['url']);
-	if ($profiledata) {
-		Profile::load($a, '', $profiledata, false);
-	}
+	if (!in_array($protocol, [Protocol::PHANTOM, Protocol::MAIL])) {
+		DI::page()['aside'] = Widget\VCard::getHTML($contact);
 
-	if ($gcontact_id <> 0) {
 		$o .= Renderer::replaceMacros(Renderer::getMarkupTemplate('section_title.tpl'),
 			['$title' => DI::l10n()->t('Status Messages and Posts')]
 		);
 
 		// Show last public posts
-		$o .= Contact::getPostsFromUrl($ret['url']);
+		$o .= Contact::getPostsFromUrl($contact['url']);
 	}
 
 	return $o;
 }
 
+function follow_process(App $a, string $url)
+{
+	$return_path = 'follow?url=' . urlencode($url);
+
+	$result = Contact::createFromProbeForUser($a->getLoggedInUserId(), $url);
+
+	if ($result['success'] == false) {
+		// Possibly it is a remote item and not an account
+		follow_remote_item($url);
+
+		if ($result['message']) {
+			notice($result['message']);
+		}
+		DI::baseUrl()->redirect($return_path);
+	} elseif ($result['cid']) {
+		DI::baseUrl()->redirect('contact/' . $result['cid']);
+	}
+
+	notice(DI::l10n()->t('The contact could not be added.'));
+
+	DI::baseUrl()->redirect($return_path);
+}
+
 function follow_remote_item($url)
 {
 	$item_id = Item::fetchByLink($url, local_user());
@@ -216,7 +202,7 @@ function follow_remote_item($url)
 	}
 
 	if (!empty($item_id)) {
-		$item = Item::selectFirst(['guid'], ['id' => $item_id]);
+		$item = Post::selectFirst(['guid'], ['id' => $item_id]);
 		if (DBA::isResult($item)) {
 			DI::baseUrl()->redirect('display/' . $item['guid']);
 		}