X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=mod%2Fitem.php;h=355d315baf98f95d834a4f56f515eaa0c24fd5f9;hb=b8c4332a2040cea440f6f5b746165be5f62d4d30;hp=5d9ca819962cb18b40f602c47555544e39e8b508;hpb=81925e37300e666d0b7efef997f9177b5e4fdfd4;p=friendica.git diff --git a/mod/item.php b/mod/item.php index 5d9ca81996..355d315baf 100644 --- a/mod/item.php +++ b/mod/item.php @@ -29,13 +29,12 @@ use Friendica\Util\Emailer; require_once 'include/enotify.php'; require_once 'include/tags.php'; -require_once 'include/files.php'; require_once 'include/threads.php'; require_once 'include/text.php'; require_once 'include/items.php'; function item_post(App $a) { - if (!local_user() && !remote_user() && !x($_REQUEST, 'commenter')) { + if (!local_user() && !remote_user()) { return; } @@ -46,21 +45,20 @@ function item_post(App $a) { if (x($_REQUEST, 'dropitems')) { $arr_drop = explode(',', $_REQUEST['dropitems']); drop_items($arr_drop); - $json = array('success' => 1); + $json = ['success' => 1]; echo json_encode($json); killme(); } call_hooks('post_local_start', $_REQUEST); - // logger('postinput ' . file_get_contents('php://input')); logger('postvars ' . print_r($_REQUEST,true), LOGGER_DATA); - $api_source = x($_REQUEST, 'api_source') && $_REQUEST['api_source']; + $api_source = defaults($_REQUEST, 'api_source', false); $message_id = ((x($_REQUEST, 'message_id') && $api_source) ? strip_tags($_REQUEST['message_id']) : ''); - $return_path = (x($_REQUEST, 'return') ? $_REQUEST['return'] : ''); - $preview = (x($_REQUEST, 'preview') ? intval($_REQUEST['preview']) : 0); + $return_path = defaults($_REQUEST, 'return', ''); + $preview = intval(defaults($_REQUEST, 'preview', 0)); /* * Check for doubly-submitted posts, and reject duplicates @@ -77,93 +75,56 @@ function item_post(App $a) { } // Is this a reply to something? - $parent = (x($_REQUEST, 'parent') ? intval($_REQUEST['parent']) : 0); - $parent_uri = (x($_REQUEST, 'parent_uri') ? trim($_REQUEST['parent_uri']) : ''); + $thr_parent = intval(defaults($_REQUEST, 'parent', 0)); + $thr_parent_uri = trim(defaults($_REQUEST, 'parent_uri', '')); + + $thr_parent_contact = null; + $parent = 0; $parent_item = null; - $parent_contact = null; - $thr_parent = ''; - $parid = 0; - $r = false; - $objecttype = null; + $parent_user = null; - if ($parent || $parent_uri) { + $parent_contact = null; - $objecttype = ACTIVITY_OBJ_COMMENT; + $objecttype = null; + $profile_uid = defaults($_REQUEST, 'profile_uid', local_user()); - if (!x($_REQUEST, 'type')) { - $_REQUEST['type'] = 'net-comment'; - } - - if ($parent) { - $r = q("SELECT * FROM `item` WHERE `id` = %d LIMIT 1", - intval($parent) - ); - } elseif ($parent_uri && local_user()) { - // This is coming from an API source, and we are logged in - $r = q("SELECT * FROM `item` WHERE `uri` = '%s' AND `uid` = %d LIMIT 1", - dbesc($parent_uri), - intval(local_user()) - ); + if ($thr_parent || $thr_parent_uri) { + if ($thr_parent) { + $parent_item = dba::selectFirst('item', [], ['id' => $thr_parent]); + } elseif ($thr_parent_uri) { + $parent_item = dba::selectFirst('item', [], ['uri' => $thr_parent_uri, 'uid' => $profile_uid]); } // if this isn't the real parent of the conversation, find it - if (DBM::is_result($r)) { - $parid = $r[0]['parent']; - $parent_uri = $r[0]['uri']; - if ($r[0]['id'] != $r[0]['parent']) { - $r = q("SELECT * FROM `item` WHERE `id` = `parent` AND `parent` = %d LIMIT 1", - intval($parid) - ); + if (DBM::is_result($parent_item)) { + + // The URI and the contact is taken from the direct parent which needn't to be the top parent + $thr_parent_uri = $parent_item['uri']; + $thr_parent_contact = Contact::getDetailsByURL($parent_item["author-link"]); + + if ($parent_item['id'] != $parent_item['parent']) { + $parent_item = dba::selectFirst('item', [], ['id' => $parent_item['parent']]); } } - if (!DBM::is_result($r)) { + if (!DBM::is_result($parent_item)) { notice(t('Unable to locate original post.') . EOL); if (x($_REQUEST, 'return')) { goaway($return_path); } killme(); } - $parent_item = $r[0]; - $parent = $r[0]['id']; - // multi-level threading - preserve the info but re-parent to our single level threading - $thr_parent = $parent_uri; + $parent = $parent_item['id']; + $parent_user = $parent_item['uid']; - if ($parent_item['contact-id'] && $uid) { - $r = q("SELECT * FROM `contact` WHERE `id` = %d AND `uid` = %d LIMIT 1", - intval($parent_item['contact-id']), - intval($uid) - ); - if (DBM::is_result($r)) { - $parent_contact = $r[0]; - } + $parent_contact = Contact::getDetailsByURL($parent_item["author-link"]); - // If the contact id doesn't fit with the contact, then set the contact to null - $thrparent = q("SELECT `author-link`, `network` FROM `item` WHERE `uri` = '%s' LIMIT 1", dbesc($thr_parent)); - if (DBM::is_result($thrparent) && ($thrparent[0]["network"] === NETWORK_OSTATUS) - && (normalise_link($parent_contact["url"]) != normalise_link($thrparent[0]["author-link"]))) { - $parent_contact = Contact::getDetailsByURL($thrparent[0]["author-link"]); - - if (!isset($parent_contact["nick"])) { - $probed_contact = Probe::uri($thrparent[0]["author-link"]); - if ($probed_contact["network"] != NETWORK_FEED) { - $parent_contact = $probed_contact; - $parent_contact["nurl"] = normalise_link($probed_contact["url"]); - $parent_contact["thumb"] = $probed_contact["photo"]; - $parent_contact["micro"] = $probed_contact["photo"]; - $parent_contact["addr"] = $probed_contact["addr"]; - } - } - logger('no contact found: ' . print_r($thrparent, true), LOGGER_DEBUG); - } else { - logger('parent contact: ' . print_r($parent_contact, true), LOGGER_DEBUG); - } + $objecttype = ACTIVITY_OBJ_COMMENT; - if ($parent_contact["nick"] == "") { - $parent_contact["nick"] = $parent_contact["name"]; - } + if (!x($_REQUEST, 'type')) { + $_REQUEST['type'] = 'net-comment'; } } @@ -171,47 +132,29 @@ function item_post(App $a) { logger('mod_item: item_post parent=' . $parent); } - $profile_uid = (x($_REQUEST, 'profile_uid') ? intval($_REQUEST['profile_uid']) : 0); - $post_id = (x($_REQUEST, 'post_id') ? intval($_REQUEST['post_id']) : 0); - $app = (x($_REQUEST, 'source') ? strip_tags($_REQUEST['source']) : ''); - $extid = (x($_REQUEST, 'extid') ? strip_tags($_REQUEST['extid']) : ''); - $object = (x($_REQUEST, 'object') ? $_REQUEST['object'] : ''); + $post_id = intval(defaults($_REQUEST, 'post_id', 0)); + $app = strip_tags(defaults($_REQUEST, 'source', '')); + $extid = strip_tags(defaults($_REQUEST, 'extid', '')); + $object = defaults($_REQUEST, 'object', ''); + + // Ensure that the user id in a thread always stay the same + if (!is_null($parent_user) && in_array($parent_user, [local_user(), 0])) { + $profile_uid = $parent_user; + } // Check for multiple posts with the same message id (when the post was created via API) if (($message_id != '') && ($profile_uid != 0)) { - $r = q("SELECT * FROM `item` WHERE `uri` = '%s' AND `uid` = %d LIMIT 1", - dbesc($message_id), - intval($profile_uid) - ); - - if (DBM::is_result($r)) { + if (dba::exists('item', ['uri' => $message_id, 'uid' => $profile_uid])) { logger("Message with URI ".$message_id." already exists for user ".$profile_uid, LOGGER_DEBUG); return; } } - $allow_moderated = false; - - // here is where we are going to check for permission to post a moderated comment. - - // First check that the parent exists and it is a wall item. - - if (x($_REQUEST, 'commenter') && (!$parent || !$parent_item['wall'])) { - notice(t('Permission denied.') . EOL) ; - if (x($_REQUEST, 'return')) { - goaway($return_path); - } - killme(); - } - // Allow commenting if it is an answer to a public post - $allow_comment = ($profile_uid == 0) && $parent && in_array($parent_item['network'], [NETWORK_OSTATUS, NETWORK_DIASPORA, NETWORK_DFRN]); + $allow_comment = local_user() && ($profile_uid == 0) && $parent && in_array($parent_item['network'], [NETWORK_OSTATUS, NETWORK_DIASPORA, NETWORK_DFRN]); - /* - * Now check that it is a page_type of PAGE_BLOG, and that valid personal details - * have been provided, and run any anti-spam plugins - */ - if (!(can_write_wall($profile_uid) || $allow_comment) && !$allow_moderated) { + // Now check that valid personal details have been provided + if (!can_write_wall($profile_uid) && !$allow_comment) { notice(t('Permission denied.') . EOL) ; if (x($_REQUEST, 'return')) { goaway($return_path); @@ -225,23 +168,12 @@ function item_post(App $a) { $orig_post = null; if ($post_id) { - $i = q("SELECT * FROM `item` WHERE `uid` = %d AND `id` = %d LIMIT 1", - intval($profile_uid), - intval($post_id) - ); - if (!DBM::is_result($i)) { - killme(); - } - $orig_post = $i[0]; + $orig_post = dba::selectFirst('item', [], ['id' => $post_id]); } - $user = null; - - $r = q("SELECT * FROM `user` WHERE `uid` = %d LIMIT 1", - intval($profile_uid) - ); - if (DBM::is_result($r)) { - $user = $r[0]; + $user = dba::selectFirst('user', [], ['uid' => $profile_uid]); + if (!DBM::is_result($user) && !$orig_post) { + return; } if ($orig_post) { @@ -259,7 +191,7 @@ function item_post(App $a) { $title = notags(trim($_REQUEST['title'])); $body = escape_tags(trim($_REQUEST['body'])); $private = $orig_post['private']; - $pubmail_enable = $orig_post['pubmail']; + $pubmail_enabled = $orig_post['pubmail']; $network = $orig_post['network']; $guid = $orig_post['guid']; $extid = $orig_post['extid']; @@ -282,9 +214,7 @@ function item_post(App $a) { $str_group_deny = $user['deny_gid']; $str_contact_deny = $user['deny_cid']; } else { - // use the posted permissions - $str_group_allow = perms2str($_REQUEST['group_allow']); $str_contact_allow = perms2str($_REQUEST['contact_allow']); $str_group_deny = perms2str($_REQUEST['group_deny']); @@ -327,20 +257,12 @@ function item_post(App $a) { $private = $parent_item['private']; } - $pubmail_enable = ((x($_REQUEST, 'pubmail_enable') && intval($_REQUEST['pubmail_enable']) && !$private) ? 1 : 0); + $pubmail_enabled = defaults($_REQUEST, 'pubmail_enable', false) && !$private; // if using the API, we won't see pubmail_enable - figure out if it should be set - if ($api_source && $profile_uid && $profile_uid == local_user() && !$private) { - $mail_disabled = ((function_exists('imap_open') && !Config::get('system', 'imap_disabled')) ? 0 : 1); - if (!$mail_disabled) { - /// @TODO Check if only pubmail is loaded, * loads all columns - $r = q("SELECT * FROM `mailacct` WHERE `uid` = %d AND `server` != '' LIMIT 1", - intval(local_user()) - ); - if (DBM::is_result($r) && intval($r[0]['pubmail'])) { - $pubmail_enabled = true; - } + if (function_exists('imap_open') && !Config::get('system', 'imap_disabled')) { + $pubmail_enabled = dba::exists('mailacct', ["`uid` = ? AND `server` != ? AND `pubmail`", local_user(), '']); } } @@ -377,8 +299,7 @@ function item_post(App $a) { if (local_user() && ((local_user() == $profile_uid) || $allow_comment)) { $self = true; - $r = q("SELECT * FROM `contact` WHERE `uid` = %d AND `self` LIMIT 1", - intval($_SESSION['uid'])); + $author = dba::selectFirst('contact', [], ['uid' => local_user(), 'self' => true]); } elseif (remote_user()) { if (x($_SESSION, 'remote') && is_array($_SESSION['remote'])) { foreach ($_SESSION['remote'] as $v) { @@ -389,28 +310,19 @@ function item_post(App $a) { } } if ($contact_id) { - $r = q("SELECT * FROM `contact` WHERE `id` = %d LIMIT 1", - intval($contact_id) - ); + $author = dba::selectFirst('contact', [], ['id' => $contact_id]); } } - if (DBM::is_result($r)) { - $author = $r[0]; + if (DBM::is_result($author)) { $contact_id = $author['id']; } // get contact info for owner - if ($profile_uid == local_user() || $allow_comment) { $contact_record = $author; } else { - $r = q("SELECT * FROM `contact` WHERE `uid` = %d AND `self` LIMIT 1", - intval($profile_uid) - ); - if (DBM::is_result($r)) { - $contact_record = $r[0]; - } + $contact_record = dba::selectFirst('contact', [], ['uid' => $profile_uid, 'self' => true]); } $post_type = notags(trim($_REQUEST['type'])); @@ -429,43 +341,28 @@ function item_post(App $a) { $tags = get_tags($body); - /* - * add a statusnet style reply tag if the original post was from there - * and we are replying, and there isn't one already - */ - if ($parent && ($parent_contact['network'] == NETWORK_OSTATUS)) { - $contact = '@[url=' . $parent_contact['url'] . ']' . $parent_contact['nick'] . '[/url]'; - - if (!in_array($contact, $tags)) { - $body = $contact . ' ' . $body; - $tags[] = $contact; - } - - $toplevel_contact = ""; - $toplevel_parent = q("SELECT `contact`.* FROM `contact` - INNER JOIN `item` ON `item`.`contact-id` = `contact`.`id` AND `contact`.`url` = `item`.`author-link` - WHERE `item`.`id` = `item`.`parent` AND `item`.`parent` = %d", intval($parent)); - if (DBM::is_result($toplevel_parent)) { - if (!empty($toplevel_parent[0]['addr'])) { - $toplevel_contact = '@' . $toplevel_parent[0]['addr']; - } else { - $toplevel_contact = '@' . $toplevel_parent[0]['nick'] . '+' . $toplevel_parent[0]['id']; + // Add a tag if the parent contact is from OStatus (This will notify them during delivery) + if ($parent) { + if ($thr_parent_contact['network'] == NETWORK_OSTATUS) { + $contact = '@[url=' . $thr_parent_contact['url'] . ']' . $thr_parent_contact['nick'] . '[/url]'; + if (!in_array($contact, $tags)) { + $tags[] = $contact; } - } else { - $toplevel_parent = q("SELECT `author-link`, `author-name` FROM `item` WHERE `id` = `parent` AND `parent` = %d", intval($parent)); - $toplevel_contact = '@[url=' . $toplevel_parent[0]['author-link'] . ']' . $toplevel_parent[0]['author-name'] . '[/url]'; } - if (!in_array($toplevel_contact, $tags)) { - $tags[] = $toplevel_contact; + if ($parent_contact['network'] == NETWORK_OSTATUS) { + $contact = '@[url=' . $parent_contact['url'] . ']' . $parent_contact['nick'] . '[/url]'; + if (!in_array($contact, $tags)) { + $tags[] = $contact; + } } } - $tagged = array(); + $tagged = []; $private_forum = false; $only_to_forum = false; - $forum_contact = array(); + $forum_contact = []; if (count($tags)) { foreach ($tags as $tag) { @@ -558,29 +455,20 @@ function item_post(App $a) { if (!strlen($image_uri)) { continue; } - $srch = '<' . intval($original_contact_id) . '>'; - $r = q("SELECT `id` FROM `photo` WHERE `allow_cid` = '%s' AND `allow_gid` = '' AND `deny_cid` = '' AND `deny_gid` = '' - AND `resource-id` = '%s' AND `uid` = %d LIMIT 1", - dbesc($srch), - dbesc($image_uri), - intval($profile_uid) - ); + /// @todo these lines should be moved to Model/Photo + $srch = '<' . intval($original_contact_id) . '>'; - if (!DBM::is_result($r)) { + $condition = ['allow_cid' => $srch, 'allow_gid' => '', 'deny_cid' => '', 'deny_gid' => '', + 'resource-id' => $image_uri, 'uid' => $profile_uid]; + if (!dba::exists('photo', $condition)) { continue; } - $r = q("UPDATE `photo` SET `allow_cid` = '%s', `allow_gid` = '%s', `deny_cid` = '%s', `deny_gid` = '%s' - WHERE `resource-id` = '%s' AND `uid` = %d AND `album` = '%s' ", - dbesc($str_contact_allow), - dbesc($str_group_allow), - dbesc($str_contact_deny), - dbesc($str_group_deny), - dbesc($image_uri), - intval($profile_uid), - dbesc(t('Wall Photos')) - ); + $fields = ['allow_cid' => $str_contact_allow, 'allow_gid' => $str_group_allow, + 'deny_cid' => $str_contact_deny, 'deny_gid' => $str_group_deny]; + $condition = ['resource-id' => $image_uri, 'uid' => $profile_uid, 'album' => t('Wall Photos')]; + dba::update('photo', $fields, $condition); } } } @@ -595,21 +483,10 @@ function item_post(App $a) { $attaches = $match[1]; if (count($attaches)) { foreach ($attaches as $attach) { - $r = q("SELECT * FROM `attach` WHERE `uid` = %d AND `id` = %d LIMIT 1", - intval($profile_uid), - intval($attach) - ); - if (DBM::is_result($r)) { - $r = q("UPDATE `attach` SET `allow_cid` = '%s', `allow_gid` = '%s', `deny_cid` = '%s', `deny_gid` = '%s' - WHERE `uid` = %d AND `id` = %d", - dbesc($str_contact_allow), - dbesc($str_group_allow), - dbesc($str_contact_deny), - dbesc($str_group_deny), - intval($profile_uid), - intval($attach) - ); - } + $fields = ['allow_cid' => $str_contact_allow, 'allow_gid' => $str_group_allow, + 'deny_cid' => $str_contact_deny, 'deny_gid' => $str_group_deny]; + $condition = ['id' => $attach]; + dba::update('attach', $fields, $condition); } } } @@ -652,15 +529,15 @@ function item_post(App $a) { if (preg_match_all('/(\[attachment\]([0-9]+)\[\/attachment\])/',$body,$match)) { foreach ($match[2] as $mtch) { - $r = q("SELECT `id`,`filename`,`filesize`,`filetype` FROM `attach` WHERE `uid` = %d AND `id` = %d LIMIT 1", - intval($profile_uid), - intval($mtch) - ); - if (DBM::is_result($r)) { + $fields = ['id', 'filename', 'filesize', 'filetype']; + $attachment = dba::selectFirst('attach', $fields, ['id' => $mtch]); + if (DBM::is_result($attachment)) { if (strlen($attachments)) { $attachments .= ','; } - $attachments .= '[attach]href="' . System::baseUrl() . '/attach/' . $r[0]['id'] . '" length="' . $r[0]['filesize'] . '" type="' . $r[0]['filetype'] . '" title="' . (($r[0]['filename']) ? $r[0]['filename'] : '') . '"[/attach]'; + $attachments .= '[attach]href="' . System::baseUrl() . '/attach/' . $attachment['id'] . + '" length="' . $attachment['filesize'] . '" type="' . $attachment['filetype'] . + '" title="' . ($attachment['filename'] ? $attachment['filename'] : '') . '"[/attach]'; } $body = str_replace($match[1],'',$body); } @@ -685,18 +562,18 @@ function item_post(App $a) { // even if the post arrived via API we are considering that it // originated on this site by default for determining relayability. - $origin = (x($_REQUEST, 'origin') ? intval($_REQUEST['origin']) : 1); + $origin = intval(defaults($_REQUEST, 'origin', 1)); $notify_type = ($parent ? 'comment-new' : 'wall-new'); - $uri = ($message_id ? $message_id : item_new_uri($a->get_hostname(),$profile_uid, $guid)); + $uri = ($message_id ? $message_id : item_new_uri($a->get_hostname(), $profile_uid, $guid)); - // Fallback so that we alway have a thr-parent - if (!$thr_parent) { - $thr_parent = $uri; + // Fallback so that we alway have a parent uri + if (!$thr_parent_uri || !$parent) { + $thr_parent_uri = $uri; } - $datarray = array(); + $datarray = []; $datarray['uid'] = $profile_uid; $datarray['type'] = $post_type; $datarray['wall'] = $wall; @@ -734,15 +611,18 @@ function item_post(App $a) { $datarray['deny_cid'] = $str_contact_deny; $datarray['deny_gid'] = $str_group_deny; $datarray['private'] = $private; - $datarray['pubmail'] = $pubmail_enable; + $datarray['pubmail'] = $pubmail_enabled; $datarray['attach'] = $attachments; $datarray['bookmark'] = intval($bookmark); - $datarray['thr-parent'] = $thr_parent; + + // This is not a bug. The item store function changes 'parent-uri' to 'thr-parent' and fetches 'parent-uri' new. (We should change this) + $datarray['parent-uri'] = $thr_parent_uri; + $datarray['postopts'] = $postopts; $datarray['origin'] = $origin; - $datarray['moderated'] = $allow_moderated; - $datarray['gcontact-id'] = GContact::getId(array("url" => $datarray['author-link'], "network" => $datarray['network'], - "photo" => $datarray['author-avatar'], "name" => $datarray['author-name'])); + $datarray['moderated'] = false; + $datarray['gcontact-id'] = GContact::getId(["url" => $datarray['author-link'], "network" => $datarray['network'], + "photo" => $datarray['author-avatar'], "name" => $datarray['author-name']]); $datarray['object'] = $object; /* @@ -756,11 +636,7 @@ function item_post(App $a) { // This triggers posts via API and the mirror functions $datarray['api_source'] = $api_source; - $datarray['parent-uri'] = ($parent == 0) ? $uri : $parent_item['uri']; - $datarray['plink'] = System::baseUrl() . '/display/' . urlencode($datarray['guid']); - $datarray['last-child'] = 1; - $datarray['visible'] = 1; - + // This field is for storing the raw conversation data $datarray['protocol'] = PROTOCOL_DFRN; $r = dba::fetch_first("SELECT `conversation-uri`, `conversation-href` FROM `conversation` WHERE `item-uri` = ?", $datarray['parent-uri']); @@ -786,9 +662,9 @@ function item_post(App $a) { // We set the datarray ID to -1 because in preview mode the dataray // doesn't have an ID. $datarray["id"] = -1; - $o = conversation($a,array(array_merge($contact_record,$datarray)),'search', false, true); + $o = conversation($a,[array_merge($contact_record,$datarray)],'search', false, true); logger('preview: ' . $o); - echo json_encode(array('preview' => $o)); + echo json_encode(['preview' => $o]); killme(); } @@ -800,7 +676,7 @@ function item_post(App $a) { goaway($return_path); } - $json = array('cancel' => 1); + $json = ['cancel' => 1]; if (x($_REQUEST, 'jsreload') && strlen($_REQUEST['jsreload'])) { $json['reload'] = System::baseUrl() . '/' . $_REQUEST['jsreload']; } @@ -810,7 +686,12 @@ function item_post(App $a) { } if ($orig_post) { - $fields = array( + + // Fill the cache field + // This could be done in Item::update as well - but we have to check for the existance of some fields. + put_item_in_cache($datarray); + + $fields = [ 'title' => $datarray['title'], 'body' => $datarray['body'], 'tag' => $datarray['tag'], @@ -819,7 +700,7 @@ function item_post(App $a) { 'rendered-html' => $datarray['rendered-html'], 'rendered-hash' => $datarray['rendered-hash'], 'edited' => datetime_convert(), - 'changed' => datetime_convert()); + 'changed' => datetime_convert()]; Item::update($fields, ['id' => $post_id]); @@ -841,7 +722,17 @@ function item_post(App $a) { $post_id = item_store($datarray); - $datarray["id"] = $post_id; + if (!$post_id) { + logger("Item wasn't stored."); + goaway($return_path); + } + + $datarray = dba::selectFirst('item', [], ['id' => $post_id]); + + if (!DBM::is_result($datarray)) { + logger("Item with id ".$post_id." couldn't be fetched."); + goaway($return_path); + } // update filetags in pconfig file_tag_update_pconfig($uid, $categories_old, $categories_new, 'category'); @@ -849,7 +740,7 @@ function item_post(App $a) { // These notifications are sent if someone else is commenting other your wall if ($parent) { if ($contact_record != $author) { - notification(array( + notification([ 'type' => NOTIFY_COMMENT, 'notify_flags' => $user['notify-flags'], 'language' => $user['language'], @@ -865,14 +756,14 @@ function item_post(App $a) { 'otype' => 'item', 'parent' => $parent, 'parent_uri' => $parent_item['uri'] - )); + ]); } // Store the comment signature information in case we need to relay to Diaspora Diaspora::storeCommentSignature($datarray, $author, ($self ? $user['prvkey'] : false), $post_id); } else { if (($contact_record != $author) && !count($forum_contact)) { - notification(array( + notification([ 'type' => NOTIFY_WALL, 'notify_flags' => $user['notify-flags'], 'language' => $user['language'], @@ -886,7 +777,7 @@ function item_post(App $a) { 'source_photo' => $datarray['author-avatar'], 'verb' => ACTIVITY_POST, 'otype' => 'item' - )); + ]); } } @@ -913,7 +804,7 @@ function item_post(App $a) { $html = prepare_body($datarray); $message = '' . $link . $html . $disclaimer . ''; include_once 'include/html2plain.php'; - $params = array ( + $params = [ 'fromName' => $a->user['username'], 'fromEmail' => $a->user['email'], 'toEmail' => $addr, @@ -921,7 +812,7 @@ function item_post(App $a) { 'messageSubject' => $subject, 'htmlVersion' => $message, 'textVersion' => html2plain($html.$disclaimer) - ); + ]; Emailer::send($params); } } @@ -931,7 +822,7 @@ function item_post(App $a) { // We now do it in the background to save some time. // This is important in interactive environments like the frontend or the API. // We don't fork a new process since this is done anyway with the following command - Worker::add(array('priority' => PRIORITY_HIGH, 'dont_fork' => true), "CreateShadowEntry", $post_id); + Worker::add(['priority' => PRIORITY_HIGH, 'dont_fork' => true], "CreateShadowEntry", $post_id); // Call the background process that is delivering the item to the receivers Worker::add(PRIORITY_HIGH, "Notifier", $notify_type, $post_id); @@ -953,7 +844,7 @@ function item_post_return($baseurl, $api_source, $return_path) { goaway($return_path); } - $json = array('success' => 1); + $json = ['success' => 1]; if (x($_REQUEST, 'jsreload') && strlen($_REQUEST['jsreload'])) { $json['reload'] = $baseurl . '/' . $_REQUEST['jsreload']; } @@ -976,10 +867,14 @@ function item_content(App $a) { $o = ''; if (($a->argc == 3) && ($a->argv[1] === 'drop') && intval($a->argv[2])) { - $o = drop_item($a->argv[2], !is_ajax()); + if (is_ajax()) { + $o = Item::delete($a->argv[2]); + } else { + $o = drop_item($a->argv[2]); + } if (is_ajax()) { // ajax return: [, 0 (no perm) | ] - echo json_encode(array(intval($a->argv[2]), intval($o))); + echo json_encode([intval($a->argv[2]), intval($o)]); killme(); } } @@ -1210,5 +1105,5 @@ function handle_tag(App $a, &$body, &$inform, &$str_tags, $profile_uid, $tag, $n } } - return array('replaced' => $replaced, 'contact' => $r[0]); + return ['replaced' => $replaced, 'contact' => $r[0]]; }