X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=mod%2Fphoto.php;h=72b7e8e95a00610724ff59655ee54dceb10e298d;hb=10ede7314136edb1c475e1af546a59ff4c5648cf;hp=71c92ffe2cd98e07149a4f656753121024c1794c;hpb=9c2c4839968169a191084d6d2b0d629d82430e67;p=friendica.git

diff --git a/mod/photo.php b/mod/photo.php
index 71c92ffe2c..72b7e8e95a 100644
--- a/mod/photo.php
+++ b/mod/photo.php
@@ -1,5 +1,7 @@
 <?php
 
+use Friendica\App;
+
 require_once('include/security.php');
 require_once('include/Photo.php');
 
@@ -9,7 +11,7 @@ function photo_init(App $a) {
 	$prvcachecontrol = false;
 	$file = "";
 
-	switch($a->argc) {
+	switch ($a->argc) {
 		case 4:
 			$person = $a->argv[3];
 			$customres = intval($a->argv[2]);
@@ -29,7 +31,6 @@ function photo_init(App $a) {
 			// NOTREACHED
 	}
 
-	//	strtotime($_SERVER['HTTP_IF_MODIFIED_SINCE']) >= filemtime($localFileName)) {
 	if (isset($_SERVER['HTTP_IF_MODIFIED_SINCE'])) {
 		header('HTTP/1.1 304 Not Modified');
 		header("Last-Modified: " . gmdate("D, d M Y H:i:s", time()) . " GMT");
@@ -48,12 +49,11 @@ function photo_init(App $a) {
 
 	if (isset($type)) {
 
-
 		/**
 		 * Profile photos
 		 */
 
-		switch($type) {
+		switch ($type) {
 
 			case 'profile':
 			case 'custom':
@@ -70,9 +70,13 @@ function photo_init(App $a) {
 				break;
 		}
 
-		$uid = str_replace(array('.jpg','.png'),array('',''), $person);
+		$uid = str_replace(array('.jpg', '.png', '.gif'), array('', '', ''), $person);
 
-		$r = qu("SELECT * FROM `photo` WHERE `scale` = %d AND `uid` = %d AND `profile` = 1 LIMIT 1",
+		foreach (Photo::supportedTypes() AS $m => $e) {
+			$uid = str_replace('.'.$e, '', $uid);
+		}
+
+		$r = q("SELECT * FROM `photo` WHERE `scale` = %d AND `uid` = %d AND `profile` = 1 LIMIT 1",
 			intval($resolution),
 			intval($uid)
 		);
@@ -80,7 +84,7 @@ function photo_init(App $a) {
 			$data = $r[0]['data'];
 			$mimetype = $r[0]['type'];
 		}
-		if (! isset($data)) {
+		if (empty($data)) {
 			$data = file_get_contents($default);
 			$mimetype = 'image/jpeg';
 		}
@@ -91,17 +95,19 @@ function photo_init(App $a) {
 		 */
 
 		$resolution = 0;
-		foreach ( Photo::supportedTypes() as $m=>$e){
-			$photo = str_replace(".$e",'',$photo);
+		$photo = str_replace(array('.jpg', '.png', '.gif'), array('', '', ''), $photo);
+
+		foreach (Photo::supportedTypes() AS $m => $e) {
+			$photo = str_replace('.'.$e, '', $photo);
 		}
 
-		if (substr($photo,-2,1) == '-') {
-			$resolution = intval(substr($photo,-1,1));
-			$photo = substr($photo,0,-2);
+		if (substr($photo, -2, 1) == '-') {
+			$resolution = intval(substr($photo, -1, 1));
+			$photo = substr($photo, 0, -2);
 		}
 
-        // check if the photo exists and get the owner of the photo
-		$r = qu("SELECT `uid` FROM `photo` WHERE `resource-id` = '%s' LIMIT 1",
+		// check if the photo exists and get the owner of the photo
+		$r = q("SELECT `uid` FROM `photo` WHERE `resource-id` = '%s' LIMIT 1",
 			dbesc($photo),
 			intval($resolution)
 		);
@@ -111,12 +117,12 @@ function photo_init(App $a) {
 
 			// Now we'll see if we can access the photo
 
-			$r = qu("SELECT * FROM `photo` WHERE `resource-id` = '%s' AND `scale` <= %d $sql_extra ORDER BY scale DESC LIMIT 1",
+			$r = q("SELECT * FROM `photo` WHERE `resource-id` = '%s' AND `scale` <= %d $sql_extra ORDER BY scale DESC LIMIT 1",
 				dbesc($photo),
 				intval($resolution)
 			);
 
-			$public = (dbm::is_result($r)) AND ($r[0]['allow_cid'] == '') AND ($r[0]['allow_gid'] == '') AND ($r[0]['deny_cid']  == '') AND ($r[0]['deny_gid']  == '');
+			$public = (dbm::is_result($r)) && ($r[0]['allow_cid'] == '') && ($r[0]['allow_gid'] == '') && ($r[0]['deny_cid']  == '') && ($r[0]['deny_gid']  == '');
 
 			if (dbm::is_result($r)) {
 				$resolution = $r[0]['scale'];
@@ -133,9 +139,9 @@ function photo_init(App $a) {
 		}
 	}
 
-	if (! isset($data)) {
+	if (empty($data)) {
 		if (isset($resolution)) {
-			switch($resolution) {
+			switch ($resolution) {
 
 				case 4:
 					$data = file_get_contents('images/person-175.jpg');
@@ -157,8 +163,8 @@ function photo_init(App $a) {
 		}
 	}
 
-	// Resize only if its not a GIF
-	if ($mime != "image/gif") {
+	// Resize only if its not a GIF and it is supported by the library
+	if (($mimetype != "image/gif") && in_array($mimetype, Photo::supportedTypes())) {
 		$ph = new Photo($data, $mimetype);
 		if ($ph->is_valid()) {
 			if (isset($customres) && $customres > 0 && $customres < 500) {
@@ -184,8 +190,7 @@ function photo_init(App $a) {
 
 		header("Cache-Control: no-store, no-cache, must-revalidate");
 
-	}
-	else {
+	} else {
 		header("Last-Modified: " . gmdate("D, d M Y H:i:s", time()) . " GMT");
 		header('Etag: "'.md5($data).'"');
 	 	header("Expires: " . gmdate("D, d M Y H:i:s", time() + (31536000)) . " GMT");
@@ -197,12 +202,15 @@ function photo_init(App $a) {
 	if ($public and ($file != "")) {
 		// If the photo path isn't there, try to create it
 		$basepath = $a->get_basepath();
-		if (!is_dir($basepath."/photo"))
-			if (is_writable($basepath))
+		if (!is_dir($basepath."/photo")) {
+			if (is_writable($basepath)) {
 				mkdir($basepath."/photo");
+			}
+		}
 
-		if (is_dir($basepath."/photo"))
+		if (is_dir($basepath."/photo")) {
 			file_put_contents($basepath."/photo/".$file, $data);
+		}
 	}
 
 	killme();