X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=mod%2Fprofile_photo.php;h=da45226fe02bbc20f983774eac313f21a5e5c946;hb=50ba02809425b9cc166909bc30100ec2c4e338e1;hp=a1428adc878d60b862962e2c6ec94472e5c7cfd3;hpb=762a78661109d28dbc29a15b379b342938b35f40;p=friendica.git
diff --git a/mod/profile_photo.php b/mod/profile_photo.php
index a1428adc87..da45226fe0 100644
--- a/mod/profile_photo.php
+++ b/mod/profile_photo.php
@@ -4,15 +4,17 @@
*/
use Friendica\App;
+use Friendica\BaseModule;
use Friendica\Core\Config;
use Friendica\Core\L10n;
use Friendica\Core\System;
use Friendica\Core\Worker;
-use Friendica\Database\DBM;
+use Friendica\Database\DBA;
use Friendica\Model\Contact;
use Friendica\Model\Photo;
use Friendica\Model\Profile;
use Friendica\Object\Image;
+use Friendica\Util\Security;
function profile_photo_init(App $a)
{
@@ -25,15 +27,14 @@ function profile_photo_init(App $a)
function profile_photo_post(App $a)
{
-
if (!local_user()) {
notice(L10n::t('Permission denied.') . EOL);
return;
}
- check_form_security_token_redirectOnErr('/profile_photo', 'profile_photo');
+ BaseModule::checkFormSecurityTokenRedirectOnError('/profile_photo', 'profile_photo');
- if ((x($_POST, 'cropfinal')) && ($_POST['cropfinal'] == 1)) {
+ if (!empty($_POST['cropfinal']) && $_POST['cropfinal'] == 1) {
// unless proven otherwise
$is_default_profile = 1;
@@ -42,7 +43,10 @@ function profile_photo_post(App $a)
$r = q("select id, `is-default` from profile where id = %d and uid = %d limit 1", intval($_REQUEST['profile']),
intval(local_user())
);
- if (DBM::is_result($r) && (!intval($r[0]['is-default']))) $is_default_profile = 0;
+
+ if (DBA::isResult($r) && (!intval($r[0]['is-default']))) {
+ $is_default_profile = 0;
+ }
}
@@ -67,22 +71,22 @@ function profile_photo_post(App $a)
$srcW = $_POST['xfinal'] - $srcX;
$srcH = $_POST['yfinal'] - $srcY;
- $r = q("SELECT * FROM `photo` WHERE `resource-id` = '%s' AND `uid` = %d AND `scale` = %d LIMIT 1", dbesc($image_id),
- dbesc(local_user()), intval($scale));
-
- if (DBM::is_result($r)) {
+ $r = q("SELECT * FROM `photo` WHERE `resource-id` = '%s' AND `uid` = %d AND `scale` = %d LIMIT 1", DBA::escape($image_id),
+ DBA::escape(local_user()), intval($scale));
+ $path = 'profile/' . $a->user['nickname'];
+ if (DBA::isResult($r)) {
$base_image = $r[0];
$Image = new Image($base_image['data'], $base_image['type']);
if ($Image->isValid()) {
- $Image->crop(175, $srcX, $srcY, $srcW, $srcH);
+ $Image->crop(300, $srcX, $srcY, $srcW, $srcH);
$r = Photo::store($Image, local_user(), 0, $base_image['resource-id'], $base_image['filename'],
L10n::t('Profile Photos'), 4, $is_default_profile);
if ($r === false) {
- notice(L10n::t('Image size reduction [%s] failed.', "175") . EOL);
+ notice(L10n::t('Image size reduction [%s] failed.', "300") . EOL);
}
$Image->scaleDown(80);
@@ -107,12 +111,12 @@ function profile_photo_post(App $a)
if ($is_default_profile) {
$r = q("UPDATE `photo` SET `profile` = 0 WHERE `profile` = 1 AND `resource-id` != '%s' AND `uid` = %d",
- dbesc($base_image['resource-id']), intval(local_user())
+ DBA::escape($base_image['resource-id']), intval(local_user())
);
} else {
$r = q("update profile set photo = '%s', thumb = '%s' where id = %d and uid = %d",
- dbesc(System::baseUrl() . '/photo/' . $base_image['resource-id'] . '-4.' . $Image->getExt()),
- dbesc(System::baseUrl() . '/photo/' . $base_image['resource-id'] . '-5.' . $Image->getExt()),
+ DBA::escape(System::baseUrl() . '/photo/' . $base_image['resource-id'] . '-4.' . $Image->getExt()),
+ DBA::escape(System::baseUrl() . '/photo/' . $base_image['resource-id'] . '-5.' . $Image->getExt()),
intval($_REQUEST['profile']), intval(local_user())
);
}
@@ -121,9 +125,8 @@ function profile_photo_post(App $a)
info(L10n::t('Shift-reload the page or clear browser cache if the new photo does not display immediately.') . EOL);
// Update global directory in background
- $url = System::baseUrl() . '/profile/' . $a->user['nickname'];
- if ($url && strlen(Config::get('system', 'directory'))) {
- Worker::add(PRIORITY_LOW, "Directory", $url);
+ if ($path && strlen(Config::get('system', 'directory'))) {
+ Worker::add(PRIORITY_LOW, "Directory", $a->getBaseURL() . '/' . $path);
}
Worker::add(PRIORITY_LOW, 'ProfileUpdate', local_user());
@@ -132,7 +135,7 @@ function profile_photo_post(App $a)
}
}
- goaway(System::baseUrl() . '/profiles');
+ $a->internalRedirect($path);
return; // NOTREACHED
}
@@ -163,7 +166,9 @@ function profile_photo_post(App $a)
$ph->orient($src);
@unlink($src);
- profile_photo_crop_ui_head($a, $ph);
+
+ $imagecrop = profile_photo_crop_ui_head($a, $ph);
+ $a->internalRedirect('profile_photo/use/' . $imagecrop['hash']);
}
function profile_photo_content(App $a)
@@ -182,26 +187,25 @@ function profile_photo_content(App $a)
$imagecrop = [];
- if ($a->argv[1] == 'use') {
- if ($a->argc < 3) {
- notice(L10n::t('Permission denied.') . EOL);
- return;
- };
-
-// check_form_security_token_redirectOnErr('/profile_photo', 'profile_photo');
+ if (isset($a->argv[1]) && $a->argv[1] == 'use' && $a->argc >= 3) {
+ // BaseModule::checkFormSecurityTokenRedirectOnError('/profile_photo', 'profile_photo');
$resource_id = $a->argv[2];
//die(":".local_user());
$r = q("SELECT * FROM `photo` WHERE `uid` = %d AND `resource-id` = '%s' ORDER BY `scale` ASC", intval(local_user()),
- dbesc($resource_id)
+ DBA::escape($resource_id)
);
- if (!DBM::is_result($r)) {
+
+ if (!DBA::isResult($r)) {
notice(L10n::t('Permission denied.') . EOL);
return;
}
+
$havescale = false;
foreach ($r as $rr) {
- if ($rr['scale'] == 5) $havescale = true;
+ if ($rr['scale'] == 5) {
+ $havescale = true;
+ }
}
// set an already uloaded photo as profile photo
@@ -210,7 +214,7 @@ function profile_photo_content(App $a)
$r = q("UPDATE `photo` SET `profile`=0 WHERE `profile`=1 AND `uid`=%d", intval(local_user()));
$r = q("UPDATE `photo` SET `profile`=1 WHERE `uid` = %d AND `resource-id` = '%s'", intval(local_user()),
- dbesc($resource_id)
+ DBA::escape($resource_id)
);
Contact::updateSelfFromUserID(local_user(), true);
@@ -221,7 +225,7 @@ function profile_photo_content(App $a)
Worker::add(PRIORITY_LOW, "Directory", $url);
}
- goaway(System::baseUrl() . '/profiles');
+ $a->internalRedirect('profile/' . $a->user['nickname']);
return; // NOTREACHED
}
$ph = new Image($r[0]['data'], $r[0]['type']);
@@ -233,8 +237,7 @@ function profile_photo_content(App $a)
intval(local_user())
);
-
- if (!empty($imagecrop)) {
+ if (empty($imagecrop)) {
$tpl = get_markup_template('profile_photo.tpl');
$o = replace_macros($tpl,
@@ -245,7 +248,7 @@ function profile_photo_content(App $a)
'$title' => L10n::t('Upload Profile Photo'),
'$submit' => L10n::t('Upload'),
'$profiles' => $profiles,
- '$form_security_token' => get_form_security_token("profile_photo"),
+ '$form_security_token' => BaseModule::getFormSecurityToken("profile_photo"),
'$select' => sprintf('%s %s', L10n::t('or'),
($newuser) ? '' . L10n::t('skip this step') . '' : '' . L10n::t('select a photo from your photo albums') . '')
]);
@@ -257,12 +260,12 @@ function profile_photo_content(App $a)
$o = replace_macros($tpl,
[
'$filename' => $filename,
- '$profile' => intval($_REQUEST['profile']),
+ '$profile' => (isset($_REQUEST['profile']) ? intval($_REQUEST['profile']) : 0),
'$resource' => $imagecrop['hash'] . '-' . $imagecrop['resolution'],
'$image_url' => System::baseUrl() . '/photo/' . $filename,
'$title' => L10n::t('Crop Image'),
'$desc' => L10n::t('Please adjust the image cropping for optimum viewing.'),
- '$form_security_token' => get_form_security_token("profile_photo"),
+ '$form_security_token' => BaseModule::getFormSecurityToken("profile_photo"),
'$done' => L10n::t('Done Editing')
]);
return $o;
@@ -271,23 +274,23 @@ function profile_photo_content(App $a)
return; // NOTREACHED
}
-function profile_photo_crop_ui_head(App $a, Image $Image)
+function profile_photo_crop_ui_head(App $a, Image $image)
{
$max_length = Config::get('system', 'max_image_length');
if (!$max_length) {
$max_length = MAX_IMAGE_LENGTH;
}
if ($max_length > 0) {
- $Image->scaleDown($max_length);
+ $image->scaleDown($max_length);
}
- $width = $Image->getWidth();
- $height = $Image->getHeight();
+ $width = $image->getWidth();
+ $height = $image->getHeight();
if ($width < 175 || $height < 175) {
- $Image->scaleUp(200);
- $width = $Image->getWidth();
- $height = $Image->getHeight();
+ $image->scaleUp(300);
+ $width = $image->getWidth();
+ $height = $image->getHeight();
}
$hash = Photo::newResource();
@@ -296,7 +299,7 @@ function profile_photo_crop_ui_head(App $a, Image $Image)
$smallest = 0;
$filename = '';
- $r = Photo::store($Image, local_user(), 0, $hash, $filename, L10n::t('Profile Photos'), 0);
+ $r = Photo::store($image, local_user(), 0, $hash, $filename, L10n::t('Profile Photos'), 0);
if ($r) {
info(L10n::t('Image uploaded successfully.') . EOL);
@@ -305,8 +308,8 @@ function profile_photo_crop_ui_head(App $a, Image $Image)
}
if ($width > 640 || $height > 640) {
- $Image->scaleDown(640);
- $r = Photo::store($Image, local_user(), 0, $hash, $filename, L10n::t('Profile Photos'), 1);
+ $image->scaleDown(640);
+ $r = Photo::store($image, local_user(), 0, $hash, $filename, L10n::t('Profile Photos'), 1);
if ($r === false) {
notice(L10n::t('Image size reduction [%s] failed.', "640") . EOL);
@@ -316,12 +319,11 @@ function profile_photo_crop_ui_head(App $a, Image $Image)
}
$a->page['htmlhead'] .= replace_macros(get_markup_template("crophead.tpl"), []);
- $a->page['end'] .= replace_macros(get_markup_template("cropend.tpl"), []);
$imagecrop = [
'hash' => $hash,
'resolution' => $smallest,
- 'ext' => $Image->getExt(),
+ 'ext' => $image->getExt(),
];
return $imagecrop;