X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=mod%2Fwall_upload.php;h=a9828e61f94333b478b4984ffe694c184fc2d62b;hb=720a43461d67ab229de0aecfc5008f22cc4c1c54;hp=31112367a9442eb0c33253d3e68c4fab3b072d3f;hpb=26b5de9a766c91da0566cc3599944c3ff07b221b;p=friendica.git diff --git a/mod/wall_upload.php b/mod/wall_upload.php index 31112367a9..a9828e61f9 100644 --- a/mod/wall_upload.php +++ b/mod/wall_upload.php @@ -1,62 +1,66 @@ . + * + * Module for uploading a picture to the profile wall * * By default the picture will be stored in the photo album with the name Wall Photos. * You can specify a different album by adding an optional query string "album=" * to the url + * */ use Friendica\App; -use Friendica\Core\Config; -use Friendica\Core\L10n; use Friendica\Core\Logger; use Friendica\Core\Session; -use Friendica\Core\System; use Friendica\Database\DBA; +use Friendica\DI; use Friendica\Model\Photo; use Friendica\Model\User; +use Friendica\Module\BaseApi; use Friendica\Object\Image; use Friendica\Util\Images; use Friendica\Util\Strings; function wall_upload_post(App $a, $desktopmode = true) { - Logger::log("wall upload: starting new upload", Logger::DEBUG); + Logger::info("wall upload: starting new upload"); $r_json = (!empty($_GET['response']) && $_GET['response'] == 'json'); - $album = (!empty($_GET['album']) ? Strings::escapeTags(trim($_GET['album'])) : ''); + $album = trim($_GET['album'] ?? ''); - if ($a->argc > 1) { + if (DI::args()->getArgc() > 1) { if (empty($_FILES['media'])) { - $nick = $a->argv[1]; - $r = q("SELECT `user`.*, `contact`.`id` FROM `user` - INNER JOIN `contact` on `user`.`uid` = `contact`.`uid` - WHERE `user`.`nickname` = '%s' AND `user`.`blocked` = 0 - AND `contact`.`self` = 1 LIMIT 1", - DBA::escape($nick) - ); - - if (!DBA::isResult($r)) { + $nick = DI::args()->getArgv()[1]; + $user = DBA::selectFirst('owner-view', ['id', 'uid', 'nickname', 'page-flags'], ['nickname' => $nick, 'blocked' => false]); + if (!DBA::isResult($user)) { if ($r_json) { - echo json_encode(['error' => L10n::t('Invalid request.')]); + echo json_encode(['error' => DI::l10n()->t('Invalid request.')]); exit(); } return; } } else { - $user_info = api_get_user($a); - $r = q("SELECT `user`.*, `contact`.`id` FROM `user` - INNER JOIN `contact` on `user`.`uid` = `contact`.`uid` - WHERE `user`.`nickname` = '%s' AND `user`.`blocked` = 0 - AND `contact`.`self` = 1 LIMIT 1", - DBA::escape($user_info['screen_name']) - ); + $user = DBA::selectFirst('owner-view', ['id', 'uid', 'nickname', 'page-flags'], ['uid' => BaseApi::getCurrentUserID(), 'blocked' => false]); } } else { if ($r_json) { - echo json_encode(['error' => L10n::t('Invalid request.')]); + echo json_encode(['error' => DI::l10n()->t('Invalid request.')]); exit(); } return; @@ -68,40 +72,31 @@ function wall_upload_post(App $a, $desktopmode = true) $can_post = false; $visitor = 0; - $page_owner_uid = $r[0]['uid']; - $default_cid = $r[0]['id']; - $page_owner_nick = $r[0]['nickname']; - $community_page = (($r[0]['page-flags'] == User::PAGE_FLAGS_COMMUNITY) ? true : false); + $page_owner_uid = $user['uid']; + $default_cid = $user['id']; + $page_owner_nick = $user['nickname']; + $community_page = (($user['page-flags'] == User::PAGE_FLAGS_COMMUNITY) ? true : false); if ((local_user()) && (local_user() == $page_owner_uid)) { $can_post = true; } elseif ($community_page && !empty(Session::getRemoteContactID($page_owner_uid))) { $contact_id = Session::getRemoteContactID($page_owner_uid); - - $r = q("SELECT `uid` FROM `contact` - WHERE `blocked` = 0 AND `pending` = 0 - AND `id` = %d AND `uid` = %d LIMIT 1", - intval($contact_id), - intval($page_owner_uid) - ); - if (DBA::isResult($r)) { - $can_post = true; - $visitor = $contact_id; - } + $can_post = DBA::exists('contact', ['blocked' => false, 'pending' => false, 'id' => $contact_id, 'uid' => $page_owner_uid]); + $visitor = $contact_id; } if (!$can_post) { if ($r_json) { - echo json_encode(['error' => L10n::t('Permission denied.')]); + echo json_encode(['error' => DI::l10n()->t('Permission denied.')]); exit(); } - notice(L10n::t('Permission denied.') . EOL); + notice(DI::l10n()->t('Permission denied.')); exit(); } if (empty($_FILES['userfile']) && empty($_FILES['media'])) { if ($r_json) { - echo json_encode(['error' => L10n::t('Invalid request.')]); + echo json_encode(['error' => DI::l10n()->t('Invalid request.')]); } exit(); } @@ -152,52 +147,23 @@ function wall_upload_post(App $a, $desktopmode = true) if ($src == "") { if ($r_json) { - echo json_encode(['error' => L10n::t('Invalid request.')]); + echo json_encode(['error' => DI::l10n()->t('Invalid request.')]); exit(); } - notice(L10n::t('Invalid request.').EOL); + notice(DI::l10n()->t('Invalid request.')); exit(); } - // This is a special treatment for picture upload from Twidere - if (($filename == "octet-stream") && ($filetype != "")) { - $filename = $filetype; - $filetype = ""; - } + $filetype = Images::getMimeTypeBySource($src, $filename, $filetype); - if ($filetype == "") { - $filetype = Images::guessType($filename); - } - - // If there is a temp name, then do a manual check - // This is more reliable than the provided value - - $imagedata = getimagesize($src); - if ($imagedata) { - $filetype = $imagedata['mime']; - } - - Logger::log("File upload src: " . $src . " - filename: " . $filename . - " - size: " . $filesize . " - type: " . $filetype, Logger::DEBUG); - - $maximagesize = Config::get('system', 'maximagesize'); - - if (($maximagesize) && ($filesize > $maximagesize)) { - $msg = L10n::t('Image exceeds size limit of %s', Strings::formatBytes($maximagesize)); - if ($r_json) { - echo json_encode(['error' => $msg]); - } else { - echo $msg. EOL; - } - @unlink($src); - exit(); - } + Logger::info("File upload src: " . $src . " - filename: " . $filename . + " - size: " . $filesize . " - type: " . $filetype); $imagedata = @file_get_contents($src); $Image = new Image($imagedata, $filetype); if (!$Image->isValid()) { - $msg = L10n::t('Unable to process image.'); + $msg = DI::l10n()->t('Unable to process image.'); if ($r_json) { echo json_encode(['error' => $msg]); } else { @@ -210,33 +176,57 @@ function wall_upload_post(App $a, $desktopmode = true) $Image->orient($src); @unlink($src); - $max_length = Config::get('system', 'max_image_length'); - if (!$max_length) { - $max_length = MAX_IMAGE_LENGTH; - } + $max_length = DI::config()->get('system', 'max_image_length'); if ($max_length > 0) { $Image->scaleDown($max_length); - Logger::log("File upload: Scaling picture to new size " . $max_length, Logger::DEBUG); + $filesize = strlen($Image->asString()); + Logger::info("File upload: Scaling picture to new size " . $max_length); } $width = $Image->getWidth(); $height = $Image->getHeight(); + $maximagesize = DI::config()->get('system', 'maximagesize'); + + if (!empty($maximagesize) && ($filesize > $maximagesize)) { + // Scale down to multiples of 640 until the maximum size isn't exceeded anymore + foreach ([5120, 2560, 1280, 640] as $pixels) { + if (($filesize > $maximagesize) && (max($width, $height) > $pixels)) { + Logger::info('Resize', ['size' => $filesize, 'width' => $width, 'height' => $height, 'max' => $maximagesize, 'pixels' => $pixels]); + $Image->scaleDown($pixels); + $filesize = strlen($Image->asString()); + $width = $Image->getWidth(); + $height = $Image->getHeight(); + } + } + if ($filesize > $maximagesize) { + Logger::notice('Image size is too big', ['size' => $filesize, 'max' => $maximagesize]); + $msg = DI::l10n()->t('Image exceeds size limit of %s', Strings::formatBytes($maximagesize)); + if ($r_json) { + echo json_encode(['error' => $msg]); + } else { + echo $msg. EOL; + } + @unlink($src); + exit(); + } + } + $resource_id = Photo::newResource(); $smallest = 0; // If we don't have an album name use the Wall Photos album if (!strlen($album)) { - $album = L10n::t('Wall Photos'); + $album = DI::l10n()->t('Wall Photos'); } $defperm = '<' . $default_cid . '>'; - $r = Photo::store($Image, $page_owner_uid, $visitor, $resource_id, $filename, $album, 0, 0, $defperm); + $r = Photo::store($Image, $page_owner_uid, $visitor, $resource_id, $filename, $album, 0, Photo::DEFAULT, $defperm); if (!$r) { - $msg = L10n::t('Image upload failed.'); + $msg = DI::l10n()->t('Image upload failed.'); if ($r_json) { echo json_encode(['error' => $msg]); } else { @@ -247,7 +237,7 @@ function wall_upload_post(App $a, $desktopmode = true) if ($width > 640 || $height > 640) { $Image->scaleDown(640); - $r = Photo::store($Image, $page_owner_uid, $visitor, $resource_id, $filename, $album, 1, 0, $defperm); + $r = Photo::store($Image, $page_owner_uid, $visitor, $resource_id, $filename, $album, 1, Photo::DEFAULT, $defperm); if ($r) { $smallest = 1; } @@ -255,19 +245,15 @@ function wall_upload_post(App $a, $desktopmode = true) if ($width > 320 || $height > 320) { $Image->scaleDown(320); - $r = Photo::store($Image, $page_owner_uid, $visitor, $resource_id, $filename, $album, 2, 0, $defperm); + $r = Photo::store($Image, $page_owner_uid, $visitor, $resource_id, $filename, $album, 2, Photo::DEFAULT, $defperm); if ($r && ($smallest == 0)) { $smallest = 2; } } if (!$desktopmode) { - $r = q("SELECT `id`, `datasize`, `width`, `height`, `type` FROM `photo` - WHERE `resource-id` = '%s' - ORDER BY `width` DESC LIMIT 1", - $resource_id - ); - if (!$r) { + $photo = Photo::selectFirst(['id', 'datasize', 'width', 'height', 'type'], ['resource-id' => $resource_id], ['order' => ['width']]); + if (!$photo) { if ($r_json) { echo json_encode(['error' => '']); exit(); @@ -276,31 +262,31 @@ function wall_upload_post(App $a, $desktopmode = true) } $picture = []; - $picture["id"] = $r[0]["id"]; - $picture["size"] = $r[0]["datasize"]; - $picture["width"] = $r[0]["width"]; - $picture["height"] = $r[0]["height"]; - $picture["type"] = $r[0]["type"]; - $picture["albumpage"] = System::baseUrl() . '/photos/' . $page_owner_nick . '/image/' . $resource_id; - $picture["picture"] = System::baseUrl() . "/photo/{$resource_id}-0." . $Image->getExt(); - $picture["preview"] = System::baseUrl() . "/photo/{$resource_id}-{$smallest}." . $Image->getExt(); + $picture["id"] = $photo["id"]; + $picture["size"] = $photo["datasize"]; + $picture["width"] = $photo["width"]; + $picture["height"] = $photo["height"]; + $picture["type"] = $photo["type"]; + $picture["albumpage"] = DI::baseUrl() . '/photos/' . $page_owner_nick . '/image/' . $resource_id; + $picture["picture"] = DI::baseUrl() . "/photo/{$resource_id}-0." . $Image->getExt(); + $picture["preview"] = DI::baseUrl() . "/photo/{$resource_id}-{$smallest}." . $Image->getExt(); if ($r_json) { echo json_encode(['picture' => $picture]); exit(); } - Logger::log("upload done", Logger::DEBUG); + Logger::info("upload done"); return $picture; } - Logger::log("upload done", Logger::DEBUG); + Logger::info("upload done"); if ($r_json) { echo json_encode(['ok' => true]); exit(); } - echo "\n\n" . '[url=' . System::baseUrl() . '/photos/' . $page_owner_nick . '/image/' . $resource_id . '][img]' . System::baseUrl() . "/photo/{$resource_id}-{$smallest}.".$Image->getExt()."[/img][/url]\n\n"; + echo "\n\n" . '[url=' . DI::baseUrl() . '/photos/' . $page_owner_nick . '/image/' . $resource_id . '][img]' . DI::baseUrl() . "/photo/{$resource_id}-{$smallest}.".$Image->getExt()."[/img][/url]\n\n"; exit(); // NOTREACHED }