X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=simgear%2Fstructure%2Fevent_mgr.cxx;h=11b34b7a1e6ce05533b067913c522788ce6367d4;hb=c82df0590dd46347e2f1d0dca4cc3712f67f3654;hp=eeefaac99f76e5be79648ed3e07189552acb8188;hpb=c033979130b1c5822c5e9fc55bffc09632d5a48f;p=simgear.git diff --git a/simgear/structure/event_mgr.cxx b/simgear/structure/event_mgr.cxx index eeefaac9..11b34b7a 100644 --- a/simgear/structure/event_mgr.cxx +++ b/simgear/structure/event_mgr.cxx @@ -16,6 +16,7 @@ void SGEventMgr::add(const std::string& name, SGCallback* cb, t->callback = cb; t->repeat = repeat; t->name = name; + t->running = false; SGTimerQueue* q = simtime ? &_simQueue : &_rtQueue; @@ -52,8 +53,13 @@ void SGEventMgr::removeTask(const std::string& name) SG_LOG(SG_GENERAL, SG_WARN, "removeTask: no task found with name:" << name); return; } - - delete t; + if (t->running) { + // mark as not repeating so that the SGTimerQueue::update() + // will clean it up + t->repeat = false; + } else { + delete t; + } } //////////////////////////////////////////////////////////////////////// @@ -96,7 +102,11 @@ void SGTimerQueue::update(double deltaSecs) SGTimer* t = remove(); if(t->repeat) insert(t, t->interval); + // warning: this is not thread safe + // but the entire timer queue isn't either + t->running = true; t->run(); + t->running = false; if (!t->repeat) delete t; }