X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=src%2FBaseEntity.php;h=065d100fa3245e4332c4842c3c3cfa3fc15ee2f1;hb=d60d2caef6abca991d5f81b4882a8957918ed0c4;hp=1ea3f8a16b2d713360c0c7a2d16645fdc6673d59;hpb=e80d68ba53776bed047d897f52db7e25b35a479d;p=friendica.git

diff --git a/src/BaseEntity.php b/src/BaseEntity.php
index 1ea3f8a16b..065d100fa3 100644
--- a/src/BaseEntity.php
+++ b/src/BaseEntity.php
@@ -1,6 +1,6 @@
 <?php
 /**
- * @copyright Copyright (C) 2020, Friendica
+ * @copyright Copyright (C) 2010-2022, the Friendica project
  *
  * @license GNU AGPL version 3 or any later version
  *
@@ -21,32 +21,50 @@
 
 namespace Friendica;
 
+use Friendica\Network\HTTPException;
+
 /**
- * The API entity classes are meant as data transfer objects. As such, their member should be protected.
- * Then the JsonSerializable interface ensures the protected members will be included in a JSON encode situation.
+ * The Entity classes directly inheriting from this abstract class are meant to represent a single business entity.
+ * Their properties may or may not correspond with the database fields of the table we use to represent it.
+ * Each model method must correspond to a business action being performed on this entity.
+ * Only these methods will be allowed to alter the model data.
+ *
+ * To persist such a model, the associated Repository must be instantiated and the "save" method must be called
+ * and passed the entity as a parameter.
+ *
+ * Ideally, the constructor should only be called in the associated Factory which will instantiate entities depending
+ * on the provided data.
  *
- * Constructors are supposed to take as arguments the Friendica dependencies/model/collection/data it needs to
- * populate the class members.
+ * Since these objects aren't meant to be using any dependency, including logging, unit tests can and must be
+ * written for each and all of their methods
  */
-abstract class BaseEntity implements \JsonSerializable
+abstract class BaseEntity extends BaseDataTransferObject
 {
 	/**
-	 * Returns the current entity as an json array
-	 *
-	 * @return array
+	 * @param string $name
+	 * @return mixed
+	 * @throws HTTPException\InternalServerErrorException
 	 */
-	public function jsonSerialize()
+	public function __get(string $name)
 	{
-		return $this->toArray();
+		if (!property_exists($this, $name)) {
+			throw new HTTPException\InternalServerErrorException('Unknown property ' . $name . ' in Entity ' . static::class);
+		}
+
+		return $this->$name;
 	}
 
 	/**
-	 * Returns the current entity as an array
-	 *
-	 * @return array
+	 * @param mixed $name
+	 * @return bool
+	 * @throws HTTPException\InternalServerErrorException
 	 */
-	public function toArray()
+	public function __isset($name): bool
 	{
-		return get_object_vars($this);
+		if (!property_exists($this, $name)) {
+			throw new HTTPException\InternalServerErrorException('Unknown property ' . $name . ' of type ' . gettype($name) . ' in Entity ' . static::class);
+		}
+
+		return !empty($this->$name);
 	}
 }