X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=src%2FCore%2FAddon.php;h=2ec46b71c1835b2792841c4d418a1c2e03ac5ff6;hb=cbe435bb708ccf17a4b5bea1e20c3258c9524700;hp=3adc7fc0ec284d0714fa96135a42c8e8ff161287;hpb=4e9236e9e999a19d5346d8d19088b167f8e42e09;p=friendica.git

diff --git a/src/Core/Addon.php b/src/Core/Addon.php
index 3adc7fc0ec..2ec46b71c1 100644
--- a/src/Core/Addon.php
+++ b/src/Core/Addon.php
@@ -2,271 +2,250 @@
 /**
  * @file src/Core/Addon.php
  */
-namespace Friendica\Core;
-
-use Friendica\Core\Config;
-use Friendica\Database\DBM;
-use Friendica\Core\Worker;
 
-use dba;
+namespace Friendica\Core;
 
-require_once 'include/dba.php';
+use Friendica\BaseObject;
+use Friendica\Database\DBA;
+use Friendica\Util\Strings;
 
 /**
  * Some functions to handle addons
  */
-class Addon
+class Addon extends BaseObject
 {
 	/**
-	 * @brief uninstalls an addon.
-	 *
-	 * @param string $addon name of the addon
-	 * @return boolean
+	 * The addon sub-directory
+	 * @var string
 	 */
-	public static function uninstall($addon)
-	{
-		logger("Addons: uninstalling " . $addon);
-		dba::delete('addon', ['name' => $addon]);
-
-		@include_once('addon/' . $addon . '/' . $addon . '.php');
-		if (function_exists($addon . '_uninstall')) {
-			$func = $addon . '_uninstall';
-			$func();
-		}
-	}
+	const DIRECTORY = 'addon';
 
 	/**
-	 * @brief installs an addon.
+	 * List of the names of enabled addons
 	 *
-	 * @param string $addon name of the addon
-	 * @return bool
+	 * @var array
 	 */
-	public static function install($addon)
-	{
-		// silently fail if addon was removed
-
-		if (!file_exists('addon/' . $addon . '/' . $addon . '.php')) {
-			return false;
-		}
-		logger("Addons: installing " . $addon);
-		$t = @filemtime('addon/' . $addon . '/' . $addon . '.php');
-		@include_once('addon/' . $addon . '/' . $addon . '.php');
-		if (function_exists($addon . '_install')) {
-			$func = $addon . '_install';
-			$func();
-
-			$addon_admin = (function_exists($addon."_addon_admin") ? 1 : 0);
-
-			dba::insert('addon', ['name' => $addon, 'installed' => true,
-						'timestamp' => $t, 'plugin_admin' => $addon_admin]);
-
-			// we can add the following with the previous SQL
-			// once most site tables have been updated.
-			// This way the system won't fall over dead during the update.
-
-			if (file_exists('addon/' . $addon . '/.hidden')) {
-				dba::update('addon', ['hidden' => true], ['name' => $addon]);
-			}
-			return true;
-		} else {
-			logger("Addons: FAILED installing " . $addon);
-			return false;
-		}
-	}
+	private static $addons = [];
 
 	/**
-	 * reload all updated addons
+	 * Returns the list of available addons with their current status and info.
+	 * This list is made from scanning the addon/ folder.
+	 * Unsupported addons are excluded unless they already are enabled or system.show_unsupported_addon is set.
+	 *
+	 * @return array
+	 * @throws \Exception
 	 */
-	public static function reload()
+	public static function getAvailableList()
 	{
-		$addons = Config::get('system', 'addon');
-		if (strlen($addons)) {
-			$r = dba::select('addon', [], ['installed' => 1]);
-			if (DBM::is_result($r)) {
-				$installed = dba::inArray($r);
-			} else {
-				$installed = [];
-			}
-
-			$addon_list = explode(',', $addons);
-
-			if (count($addon_list)) {
-				foreach ($addon_list as $addon) {
-					$addon = trim($addon);
-					$fname = 'addon/' . $addon . '/' . $addon . '.php';
-
-					if (file_exists($fname)) {
-						$t = @filemtime($fname);
-						foreach ($installed as $i) {
-							if (($i['name'] == $addon) && ($i['timestamp'] != $t)) {
-								logger('Reloading addon: ' . $i['name']);
-								@include_once($fname);
-
-								if (function_exists($addon . '_uninstall')) {
-									$func = $addon . '_uninstall';
-									$func();
-								}
-								if (function_exists($addon . '_install')) {
-									$func = $addon . '_install';
-									$func();
-								}
-								dba::update('addon', ['timestamp' => $t], ['id' => $i['id']]);
-							}
-						}
+		$addons = [];
+		$files = glob('addon/*/');
+		if (is_array($files)) {
+			foreach ($files as $file) {
+				if (is_dir($file)) {
+					list($tmp, $addon) = array_map('trim', explode('/', $file));
+					$info = self::getInfo($addon);
+
+					if (Config::get('system', 'show_unsupported_addons')
+						|| strtolower($info['status']) != 'unsupported'
+						|| self::isEnabled($addon)
+					) {
+						$addons[] = [$addon, (self::isEnabled($addon) ? 'on' : 'off'), $info];
 					}
 				}
 			}
 		}
+
+		return $addons;
 	}
 
 	/**
-	 * @brief check if addon is enabled
+	 * Returns a list of addons that can be configured at the node level.
+	 * The list is formatted for display in the admin panel aside.
 	 *
-	 * @param string $addon
-	 * @return boolean
+	 * @return array
+	 * @throws \Exception
 	 */
-	public static function isEnabled($addon)
+	public static function getAdminList()
 	{
-		return dba::exists('addon', ['installed' => true, 'name' => $addon]);
+		$addons_admin = [];
+		$addonsAdminStmt = DBA::select('addon', ['name'], ['plugin_admin' => 1], ['order' => ['name']]);
+		while ($addon = DBA::fetch($addonsAdminStmt)) {
+			$addons_admin[$addon['name']] = [
+				'url' => 'admin/addons/' . $addon['name'],
+				'name' => $addon['name'],
+				'class' => 'addon'
+			];
+		}
+		DBA::close($addonsAdminStmt);
+
+		return $addons_admin;
 	}
 
 
 	/**
-	 * @brief registers a hook.
+	 * @brief Synchronize addons:
+	 *
+	 * system.addon contains a comma-separated list of names
+	 * of addons which are used on this system.
+	 * Go through the database list of already installed addons, and if we have
+	 * an entry, but it isn't in the config list, call the uninstall procedure
+	 * and mark it uninstalled in the database (for now we'll remove it).
+	 * Then go through the config list and if we have a addon that isn't installed,
+	 * call the install procedure and add it to the database.
 	 *
-	 * @param string $hook the name of the hook
-	 * @param string $file the name of the file that hooks into
-	 * @param string $function the name of the function that the hook will call
-	 * @param int $priority A priority (defaults to 0)
-	 * @return mixed|bool
 	 */
-	public static function registerHook($hook, $file, $function, $priority = 0)
+	public static function loadAddons()
 	{
-		$condition = ['hook' => $hook, 'file' => $file, 'function' => $function];
-		$exists = dba::exists('hook', $condition);
-		if ($exists) {
-			return true;
+		$installed_addons = [];
+
+		$r = DBA::select('addon', [], ['installed' => 1]);
+		if (DBA::isResult($r)) {
+			$installed_addons = DBA::toArray($r);
 		}
 
-		$r = dba::insert('hook', ['hook' => $hook, 'file' => $file, 'function' => $function, 'priority' => $priority]);
+		$addons = Config::get('system', 'addon');
+		$addons_arr = [];
 
-		return $r;
-	}
+		if ($addons) {
+			$addons_arr = explode(',', str_replace(' ', '', $addons));
+		}
 
-	/**
-	 * @brief unregisters a hook.
-	 *
-	 * @param string $hook the name of the hook
-	 * @param string $file the name of the file that hooks into
-	 * @param string $function the name of the function that the hook called
-	 * @return array
-	 */
-	public static function unregisterHook($hook, $file, $function)
-	{
-		$condition = ['hook' => $hook, 'file' => $file, 'function' => $function];
-		$r = dba::delete('hook', $condition);
-		return $r;
-	}
+		self::$addons = $addons_arr;
 
-	/**
-	 * Load hooks
-	 */
-	public static function loadHooks()
-	{
-		$a = get_app();
-		$a->hooks = [];
-		$r = dba::select('hook', ['hook', 'file', 'function'], [], ['order' => ['priority' => 'desc', 'file']]);
+		$installed_arr = [];
 
-		while ($rr = dba::fetch($r)) {
-			if (! array_key_exists($rr['hook'], $a->hooks)) {
-				$a->hooks[$rr['hook']] = [];
+		foreach ($installed_addons as $addon) {
+			if (!self::isEnabled($addon['name'])) {
+				self::uninstall($addon['name']);
+			} else {
+				$installed_arr[] = $addon['name'];
 			}
-			$a->hooks[$rr['hook']][] = [$rr['file'],$rr['function']];
 		}
-		dba::close($r);
-	}
 
-	/**
-	 * @brief Forks a hook.
-	 *
-	 * Use this function when you want to fork a hook via the worker.
-	 *
-	 * @param string $name of the hook to call
-	 * @param string|array $data to transmit to the callback handler
-	 */
-	public static function forkHooks($priority, $name, $data = null)
-	{
-		$a = get_app();
-
-		if (is_array($a->hooks) && array_key_exists($name, $a->hooks)) {
-			foreach ($a->hooks[$name] as $hook) {
-				Worker::add($priority, 'ForkHook', $name, $hook, $data);
+		foreach (self::$addons as $p) {
+			if (!in_array($p, $installed_arr)) {
+				self::install($p);
 			}
 		}
 	}
 
 	/**
-	 * @brief Calls a hook.
-	 *
-	 * Use this function when you want to be able to allow a hook to manipulate
-	 * the provided data.
+	 * @brief uninstalls an addon.
 	 *
-	 * @param string $name of the hook to call
-	 * @param string|array &$data to transmit to the callback handler
+	 * @param string $addon name of the addon
+	 * @return void
+	 * @throws \Exception
 	 */
-	public static function callHooks($name, &$data = null)
+	public static function uninstall($addon)
 	{
-		$a = get_app();
+		$addon = Strings::sanitizeFilePathItem($addon);
 
-		if (is_array($a->hooks) && array_key_exists($name, $a->hooks)) {
-			foreach ($a->hooks[$name] as $hook) {
-				self::callSingleHook($a, $name, $hook, $data);
-			}
+		Logger::notice("Addon {addon}: {action}", ['action' => 'uninstall', 'addon' => $addon]);
+		DBA::delete('addon', ['name' => $addon]);
+
+		@include_once('addon/' . $addon . '/' . $addon . '.php');
+		if (function_exists($addon . '_uninstall')) {
+			$func = $addon . '_uninstall';
+			$func();
 		}
+
+		DBA::delete('hook', ['file' => 'addon/' . $addon . '/' . $addon . '.php']);
+
+		unset(self::$addons[array_search($addon, self::$addons)]);
+
+		Addon::saveEnabledList();
 	}
 
 	/**
-	 * @brief Calls a single hook.
+	 * @brief installs an addon.
 	 *
-	 * @param string $name of the hook to call
-	 * @param array $hook Hook data
-	 * @param string|array &$data to transmit to the callback handler
+	 * @param string $addon name of the addon
+	 * @return bool
+	 * @throws \Exception
 	 */
-	public static function callSingleHook($a, $name, $hook, &$data = null)
+	public static function install($addon)
 	{
-		// Don't run a theme's hook if the user isn't using the theme
-		if (strpos($hook[0], 'view/theme/') !== false && strpos($hook[0], 'view/theme/'.current_theme()) === false) {
-			return;
+		$addon = Strings::sanitizeFilePathItem($addon);
+
+		// silently fail if addon was removed of if $addon is funky
+		if (!file_exists('addon/' . $addon . '/' . $addon . '.php')) {
+			return false;
 		}
 
-		@include_once($hook[0]);
-		if (function_exists($hook[1])) {
-			$func = $hook[1];
-			$func($a, $data);
+		Logger::notice("Addon {addon}: {action}", ['action' => 'install', 'addon' => $addon]);
+		$t = @filemtime('addon/' . $addon . '/' . $addon . '.php');
+		@include_once('addon/' . $addon . '/' . $addon . '.php');
+		if (function_exists($addon . '_install')) {
+			$func = $addon . '_install';
+			$func(self::getApp());
+
+			$addon_admin = (function_exists($addon . "_addon_admin") ? 1 : 0);
+
+			DBA::insert('addon', ['name' => $addon, 'installed' => true,
+				'timestamp' => $t, 'plugin_admin' => $addon_admin]);
+
+			// we can add the following with the previous SQL
+			// once most site tables have been updated.
+			// This way the system won't fall over dead during the update.
+
+			if (file_exists('addon/' . $addon . '/.hidden')) {
+				DBA::update('addon', ['hidden' => true], ['name' => $addon]);
+			}
+
+			if (!self::isEnabled($addon)) {
+				self::$addons[] = $addon;
+			}
+
+			Addon::saveEnabledList();
+
+			return true;
 		} else {
-			// remove orphan hooks
-			$condition = ['hook' => $name, 'file' => $hook[0], 'function' => $hook[1]];
-			dba::delete('hook', $condition, ['cascade' => false]);
+			Logger::error("Addon {addon}: {action} failed", ['action' => 'install', 'addon' => $addon]);
+			return false;
 		}
 	}
 
 	/**
-	 * check if an app_menu hook exist for addon $name.
-	 * Return true if the addon is an app
+	 * reload all updated addons
 	 */
-	public static function isApp($name)
+	public static function reload()
 	{
-		$a = get_app();
+		$addons = Config::get('system', 'addon');
+		if (strlen($addons)) {
+			$r = DBA::select('addon', [], ['installed' => 1]);
+			if (DBA::isResult($r)) {
+				$installed = DBA::toArray($r);
+			} else {
+				$installed = [];
+			}
+
+			$addon_list = explode(',', $addons);
 
-		if (is_array($a->hooks) && (array_key_exists('app_menu', $a->hooks))) {
-			foreach ($a->hooks['app_menu'] as $hook) {
-				if ($hook[0] == 'addon/'.$name.'/'.$name.'.php') {
-					return true;
+			foreach ($addon_list as $addon) {
+				$addon = Strings::sanitizeFilePathItem(trim($addon));
+				$fname = 'addon/' . $addon . '/' . $addon . '.php';
+				if (file_exists($fname)) {
+					$t = @filemtime($fname);
+					foreach ($installed as $i) {
+						if (($i['name'] == $addon) && ($i['timestamp'] != $t)) {
+
+							Logger::notice("Addon {addon}: {action}", ['action' => 'reload', 'addon' => $i['name']]);
+							@include_once($fname);
+
+							if (function_exists($addon . '_uninstall')) {
+								$func = $addon . '_uninstall';
+								$func(self::getApp());
+							}
+							if (function_exists($addon . '_install')) {
+								$func = $addon . '_install';
+								$func(self::getApp());
+							}
+							DBA::update('addon', ['timestamp' => $t], ['id' => $i['id']]);
+						}
+					}
 				}
 			}
 		}
-
-		return false;
 	}
 
 	/**
@@ -284,10 +263,13 @@ class Addon
 	 *   *\endcode
 	 * @param string $addon the name of the addon
 	 * @return array with the addon information
+	 * @throws \Exception
 	 */
 	public static function getInfo($addon)
 	{
-		$a = get_app();
+		$a = self::getApp();
+
+		$addon = Strings::sanitizeFilePathItem($addon);
 
 		$info = [
 			'name' => $addon,
@@ -304,7 +286,7 @@ class Addon
 
 		$stamp1 = microtime(true);
 		$f = file_get_contents("addon/$addon/$addon.php");
-		$a->save_timestamp($stamp1, "file");
+		$a->getProfiler()->saveTimestamp($stamp1, "file", System::callstack());
 
 		$r = preg_match("|/\*.*\*/|msU", $f, $m);
 
@@ -313,7 +295,12 @@ class Addon
 			foreach ($ll as $l) {
 				$l = trim($l, "\t\n\r */");
 				if ($l != "") {
-					list($type, $v) = array_map("trim", explode(":", $l, 2));
+					$addon_info = array_map("trim", explode(":", $l, 2));
+					if (count($addon_info) < 2) {
+						continue;
+					}
+
+					list($type, $v) = $addon_info;
 					$type = strtolower($type);
 					if ($type == "author" || $type == "maintainer") {
 						$r = preg_match("|([^<]+)<([^>]+)>|", $v, $m);
@@ -332,4 +319,101 @@ class Addon
 		}
 		return $info;
 	}
+
+	/**
+	 * Checks if the provided addon is enabled
+	 *
+	 * @param string $addon
+	 * @return boolean
+	 */
+	public static function isEnabled($addon)
+	{
+		return in_array($addon, self::$addons);
+	}
+
+	/**
+	 * Returns a list of the enabled addon names
+	 *
+	 * @return array
+	 */
+	public static function getEnabledList()
+	{
+		return self::$addons;
+	}
+
+	/**
+	 * Saves the current enabled addon list in the system.addon config key
+	 *
+	 * @return boolean
+	 */
+	public static function saveEnabledList()
+	{
+		return Config::set('system', 'addon', implode(',', self::$addons));
+	}
+
+	/**
+	 * Returns the list of non-hidden enabled addon names
+	 *
+	 * @return array
+	 * @throws \Exception
+	 */
+	public static function getVisibleList()
+	{
+		$visible_addons = [];
+		$stmt = DBA::select('addon', ['name'], ['hidden' => false, 'installed' => true]);
+		if (DBA::isResult($stmt)) {
+			foreach (DBA::toArray($stmt) as $addon) {
+				$visible_addons[] = $addon['name'];
+			}
+		}
+
+		return $visible_addons;
+	}
+
+	/**
+	 * Shim of Hook::register left for backward compatibility purpose.
+	 *
+	 * @see        Hook::register
+	 * @deprecated since version 2018.12
+	 * @param string $hook     the name of the hook
+	 * @param string $file     the name of the file that hooks into
+	 * @param string $function the name of the function that the hook will call
+	 * @param int    $priority A priority (defaults to 0)
+	 * @return mixed|bool
+	 * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+	 */
+	public static function registerHook($hook, $file, $function, $priority = 0)
+	{
+		return Hook::register($hook, $file, $function, $priority);
+	}
+
+	/**
+	 * Shim of Hook::unregister left for backward compatibility purpose.
+	 *
+	 * @see        Hook::unregister
+	 * @deprecated since version 2018.12
+	 * @param string $hook     the name of the hook
+	 * @param string $file     the name of the file that hooks into
+	 * @param string $function the name of the function that the hook called
+	 * @return boolean
+	 * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+	 */
+	public static function unregisterHook($hook, $file, $function)
+	{
+		return Hook::unregister($hook, $file, $function);
+	}
+
+	/**
+	 * Shim of Hook::callAll left for backward-compatibility purpose.
+	 *
+	 * @see        Hook::callAll
+	 * @deprecated since version 2018.12
+	 * @param string        $name of the hook to call
+	 * @param string|array &$data to transmit to the callback handler
+	 * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+	 */
+	public static function callHooks($name, &$data = null)
+	{
+		Hook::callAll($name, $data);
+	}
 }