X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=src%2FModel%2FContact.php;h=0e542316dbabbd0d1890fbda2339af5f6142d555;hb=2702732308d4abbb8b99dde79a35d6332ef91df3;hp=0262a4a9fddb581cb06b2d09a9abf04364a643c8;hpb=3f3422975266835fc125d1d61aae85ccc10d96d9;p=friendica.git diff --git a/src/Model/Contact.php b/src/Model/Contact.php index 0262a4a9fd..0e542316db 100644 --- a/src/Model/Contact.php +++ b/src/Model/Contact.php @@ -1,14 +1,29 @@ . + * */ + namespace Friendica\Model; use Friendica\App\BaseURL; use Friendica\Content\Pager; -use Friendica\Core\Config; use Friendica\Core\Hook; -use Friendica\Core\L10n; use Friendica\Core\Logger; use Friendica\Core\Protocol; use Friendica\Core\Session; @@ -16,6 +31,8 @@ use Friendica\Core\System; use Friendica\Core\Worker; use Friendica\Database\DBA; use Friendica\DI; +use Friendica\Model\Notify\Type; +use Friendica\Network\HTTPException; use Friendica\Network\Probe; use Friendica\Protocol\Activity; use Friendica\Protocol\ActivityPub; @@ -29,7 +46,7 @@ use Friendica\Util\Network; use Friendica\Util\Strings; /** - * @brief functions for interacting with a contact + * functions for interacting with a contact */ class Contact { @@ -174,13 +191,13 @@ class Contact } /** - * @brief Tests if the given contact is a follower + * Tests if the given contact is a follower * * @param int $cid Either public contact id or user's contact id * @param int $uid User ID * * @return boolean is the contact id a follower? - * @throws \Friendica\Network\HTTPException\InternalServerErrorException + * @throws HTTPException\InternalServerErrorException * @throws \ImagickException */ public static function isFollower($cid, $uid) @@ -199,13 +216,13 @@ class Contact } /** - * @brief Tests if the given contact url is a follower + * Tests if the given contact url is a follower * * @param string $url Contact URL * @param int $uid User ID * * @return boolean is the contact id a follower? - * @throws \Friendica\Network\HTTPException\InternalServerErrorException + * @throws HTTPException\InternalServerErrorException * @throws \ImagickException */ public static function isFollowerByURL($url, $uid) @@ -220,13 +237,13 @@ class Contact } /** - * @brief Tests if the given user follow the given contact + * Tests if the given user follow the given contact * * @param int $cid Either public contact id or user's contact id * @param int $uid User ID * * @return boolean is the contact url being followed? - * @throws \Friendica\Network\HTTPException\InternalServerErrorException + * @throws HTTPException\InternalServerErrorException * @throws \ImagickException */ public static function isSharing($cid, $uid) @@ -245,13 +262,13 @@ class Contact } /** - * @brief Tests if the given user follow the given contact url + * Tests if the given user follow the given contact url * * @param string $url Contact URL * @param int $uid User ID * * @return boolean is the contact url being followed? - * @throws \Friendica\Network\HTTPException\InternalServerErrorException + * @throws HTTPException\InternalServerErrorException * @throws \ImagickException */ public static function isSharingByURL($url, $uid) @@ -266,32 +283,40 @@ class Contact } /** - * @brief Get the basepath for a given contact link + * Get the basepath for a given contact link * * @param string $url The contact link + * @param boolean $dont_update Don't update the contact * * @return string basepath - * @return boolean $dont_update Don't update the contact - * @throws \Friendica\Network\HTTPException\InternalServerErrorException + * @throws HTTPException\InternalServerErrorException * @throws \ImagickException */ public static function getBasepath($url, $dont_update = false) { - $contact = DBA::selectFirst('contact', ['baseurl'], ['uid' => 0, 'nurl' => Strings::normaliseLink($url)]); + $contact = DBA::selectFirst('contact', ['id', 'baseurl'], ['uid' => 0, 'nurl' => Strings::normaliseLink($url)]); + if (!DBA::isResult($contact)) { + return ''; + } + if (!empty($contact['baseurl'])) { return $contact['baseurl']; } elseif ($dont_update) { return ''; } - self::updateFromProbeByURL($url, true); + // Update the existing contact + self::updateFromProbe($contact['id'], '', true); - $contact = DBA::selectFirst('contact', ['baseurl'], ['uid' => 0, 'nurl' => Strings::normaliseLink($url)]); - if (!empty($contact['baseurl'])) { - return $contact['baseurl']; + // And fetch the result + $contact = DBA::selectFirst('contact', ['baseurl'], ['id' => $contact['id']]); + if (empty($contact['baseurl'])) { + Logger::info('No baseurl for contact', ['url' => $url]); + return ''; } - return ''; + Logger::info('Found baseurl for contact', ['url' => $url, 'baseurl' => $contact['baseurl']]); + return $contact['baseurl']; } /** @@ -306,13 +331,36 @@ class Contact return Strings::compareLink(self::getBasepath($url, true), DI::baseUrl()); } + /** + * Check if the given contact ID is on the same server + * + * @param string $url The contact link + * + * @return boolean Is it the same server? + */ + public static function isLocalById(int $cid) + { + $contact = DBA::selectFirst('contact', ['url', 'baseurl'], ['id' => $cid]); + if (!DBA::isResult($contact)) { + return false; + } + + if (empty($contact['baseurl'])) { + $baseurl = self::getBasepath($contact['url'], true); + } else { + $baseurl = $contact['baseurl']; + } + + return Strings::compareLink($baseurl, DI::baseUrl()); + } + /** * Returns the public contact id of the given user id * * @param integer $uid User ID * * @return integer|boolean Public contact id for given user id - * @throws Exception + * @throws \Exception */ public static function getPublicIdByUserId($uid) { @@ -324,13 +372,13 @@ class Contact } /** - * @brief Returns the contact id for the user and the public contact id for a given contact id + * Returns the contact id for the user and the public contact id for a given contact id * * @param int $cid Either public contact id or user's contact id * @param int $uid User ID * * @return array with public and user's contact id - * @throws \Friendica\Network\HTTPException\InternalServerErrorException + * @throws HTTPException\InternalServerErrorException * @throws \ImagickException */ public static function getPublicAndUserContacID($cid, $uid) @@ -386,7 +434,7 @@ class Contact } /** - * @brief Block contact id for user id + * Block contact id for user id * * @param int $cid Either public contact id or user's contact id * @param int $uid User ID @@ -408,7 +456,7 @@ class Contact } /** - * @brief Returns "block" state for contact id and user id + * Returns "block" state for contact id and user id * * @param int $cid Either public contact id or user's contact id * @param int $uid User ID @@ -449,7 +497,7 @@ class Contact } /** - * @brief Ignore contact id for user id + * Ignore contact id for user id * * @param int $cid Either public contact id or user's contact id * @param int $uid User ID @@ -471,7 +519,7 @@ class Contact } /** - * @brief Returns "ignore" state for contact id and user id + * Returns "ignore" state for contact id and user id * * @param int $cid Either public contact id or user's contact id * @param int $uid User ID @@ -512,7 +560,7 @@ class Contact } /** - * @brief Set "collapsed" for contact id and user id + * Set "collapsed" for contact id and user id * * @param int $cid Either public contact id or user's contact id * @param int $uid User ID @@ -530,13 +578,13 @@ class Contact } /** - * @brief Returns "collapsed" state for contact id and user id + * Returns "collapsed" state for contact id and user id * * @param int $cid Either public contact id or user's contact id * @param int $uid User ID * * @return boolean is the contact id blocked for the given user? - * @throws \Friendica\Network\HTTPException\InternalServerErrorException + * @throws HTTPException\InternalServerErrorException * @throws \ImagickException */ public static function isCollapsedByUser($cid, $uid) @@ -559,7 +607,7 @@ class Contact } /** - * @brief Returns a list of contacts belonging in a group + * Returns a list of contacts belonging in a group * * @param int $gid * @return array @@ -593,41 +641,12 @@ class Contact return $return; } - /** - * @brief Returns the count of OStatus contacts in a group - * - * @param int $gid - * @return int - * @throws \Exception - */ - public static function getOStatusCountByGroupId($gid) - { - $return = 0; - if (intval($gid)) { - $contacts = DBA::fetchFirst('SELECT COUNT(*) AS `count` - FROM `contact` - INNER JOIN `group_member` - ON `contact`.`id` = `group_member`.`contact-id` - WHERE `gid` = ? - AND `contact`.`uid` = ? - AND `contact`.`network` = ? - AND `contact`.`notify` != ""', - $gid, - local_user(), - Protocol::OSTATUS - ); - $return = $contacts['count']; - } - - return $return; - } - /** * Creates the self-contact for the provided user id * * @param int $uid * @return bool Operation success - * @throws \Friendica\Network\HTTPException\InternalServerErrorException + * @throws HTTPException\InternalServerErrorException */ public static function createSelfFromUserId($uid) { @@ -674,11 +693,11 @@ class Contact * * @param int $uid * @param boolean $update_avatar Force the avatar update - * @throws \Friendica\Network\HTTPException\InternalServerErrorException + * @throws HTTPException\InternalServerErrorException */ public static function updateSelfFromUserID($uid, $update_avatar = false) { - $fields = ['id', 'name', 'nick', 'location', 'about', 'keywords', 'gender', 'avatar', + $fields = ['id', 'name', 'nick', 'location', 'about', 'keywords', 'avatar', 'xmpp', 'contact-type', 'forum', 'prv', 'avatar-date', 'url', 'nurl', 'unsearchable', 'photo', 'thumb', 'micro', 'addr', 'request', 'notify', 'poll', 'confirm', 'poco']; $self = DBA::selectFirst('contact', $fields, ['uid' => $uid, 'self' => true]); @@ -686,15 +705,15 @@ class Contact return; } - $fields = ['nickname', 'page-flags', 'account-type', 'hidewall']; + $fields = ['nickname', 'page-flags', 'account-type']; $user = DBA::selectFirst('user', $fields, ['uid' => $uid]); if (!DBA::isResult($user)) { return; } $fields = ['name', 'photo', 'thumb', 'about', 'address', 'locality', 'region', - 'country-name', 'gender', 'pub_keywords', 'xmpp', 'net-publish']; - $profile = DBA::selectFirst('profile', $fields, ['uid' => $uid, 'is-default' => true]); + 'country-name', 'pub_keywords', 'xmpp', 'net-publish']; + $profile = DBA::selectFirst('profile', $fields, ['uid' => $uid]); if (!DBA::isResult($profile)) { return; } @@ -704,7 +723,7 @@ class Contact $fields = ['name' => $profile['name'], 'nick' => $user['nickname'], 'avatar-date' => $self['avatar-date'], 'location' => Profile::formatLocation($profile), 'about' => $profile['about'], 'keywords' => $profile['pub_keywords'], - 'gender' => $profile['gender'], 'contact-type' => $user['account-type'], + 'contact-type' => $user['account-type'], 'xmpp' => $profile['xmpp']]; $avatar = Photo::selectFirst(['resource-id', 'type'], ['uid' => $uid, 'profile' => true]); @@ -738,7 +757,7 @@ class Contact $fields['avatar'] = DI::baseUrl() . '/photo/profile/' .$uid . '.' . $file_suffix; $fields['forum'] = $user['page-flags'] == User::PAGE_FLAGS_COMMUNITY; $fields['prv'] = $user['page-flags'] == User::PAGE_FLAGS_PRVGROUP; - $fields['unsearchable'] = $user['hidewall'] || !$profile['net-publish']; + $fields['unsearchable'] = !$profile['net-publish']; // it seems as if ported accounts can have wrong values, so we make sure that now everything is fine. $fields['url'] = DI::baseUrl() . '/profile/' . $user['nickname']; @@ -771,16 +790,16 @@ class Contact // Update the profile $fields = ['photo' => DI::baseUrl() . '/photo/profile/' .$uid . '.' . $file_suffix, 'thumb' => DI::baseUrl() . '/photo/avatar/' . $uid .'.' . $file_suffix]; - DBA::update('profile', $fields, ['uid' => $uid, 'is-default' => true]); + DBA::update('profile', $fields, ['uid' => $uid]); } } /** - * @brief Marks a contact for removal + * Marks a contact for removal * * @param int $id contact id * @return null - * @throws \Friendica\Network\HTTPException\InternalServerErrorException + * @throws HTTPException\InternalServerErrorException */ public static function remove($id) { @@ -798,13 +817,13 @@ class Contact } /** - * @brief Sends an unfriend message. Does not remove the contact + * Sends an unfriend message. Does not remove the contact * * @param array $user User unfriending * @param array $contact Contact unfriended * @param boolean $dissolve Remove the contact on the remote side * @return void - * @throws \Friendica\Network\HTTPException\InternalServerErrorException + * @throws HTTPException\InternalServerErrorException * @throws \ImagickException */ public static function terminateFriendship(array $user, array $contact, $dissolve = false) @@ -847,7 +866,7 @@ class Contact } /** - * @brief Marks a contact for archival after a communication issue delay + * Marks a contact for archival after a communication issue delay * * Contact has refused to recognise us as a friend. We will start a countdown. * If they still don't recognise us in 32 days, the relationship is over, @@ -857,7 +876,7 @@ class Contact * * @param array $contact contact to mark for archival * @return null - * @throws \Friendica\Network\HTTPException\InternalServerErrorException + * @throws HTTPException\InternalServerErrorException */ public static function markForArchival(array $contact) { @@ -889,7 +908,7 @@ class Contact */ /// @todo Check for contact vitality via probing - $archival_days = Config::get('system', 'archival_days', 32); + $archival_days = DI::config()->get('system', 'archival_days', 32); $expiry = $contact['term-date'] . ' + ' . $archival_days . ' days '; if (DateTimeFormat::utcNow() > DateTimeFormat::utc($expiry)) { @@ -905,7 +924,7 @@ class Contact } /** - * @brief Cancels the archival countdown + * Cancels the archival countdown * * @see Contact::markForArchival() * @@ -948,7 +967,7 @@ class Contact } /** - * @brief Get contact data for a given profile link + * Get contact data for a given profile link * * The function looks at several places (contact table and gcontact table) for the contact * It caches its result for the same script execution to prevent duplicate calls @@ -958,7 +977,7 @@ class Contact * @param array $default If not data was found take this data as default value * * @return array Contact data - * @throws \Friendica\Network\HTTPException\InternalServerErrorException + * @throws HTTPException\InternalServerErrorException */ public static function getDetailsByURL($url, $uid = -1, array $default = []) { @@ -982,14 +1001,14 @@ class Contact // Fetch contact data from the contact table for the given user $s = DBA::p("SELECT `id`, `id` AS `cid`, 0 AS `gid`, 0 AS `zid`, `uid`, `url`, `nurl`, `alias`, `network`, `name`, `nick`, `addr`, `location`, `about`, `xmpp`, - `keywords`, `gender`, `photo`, `thumb`, `micro`, `forum`, `prv`, (`forum` | `prv`) AS `community`, `contact-type`, `bd` AS `birthday`, `self`, `rel`, `pending` + `keywords`, `photo`, `thumb`, `micro`, `forum`, `prv`, (`forum` | `prv`) AS `community`, `contact-type`, `bd` AS `birthday`, `self`, `rel`, `pending` FROM `contact` WHERE `nurl` = ? AND `uid` = ?", $nurl, $uid); $r = DBA::toArray($s); // Fetch contact data from the contact table for the given user, checking with the alias if (!DBA::isResult($r)) { $s = DBA::p("SELECT `id`, `id` AS `cid`, 0 AS `gid`, 0 AS `zid`, `uid`, `url`, `nurl`, `alias`, `network`, `name`, `nick`, `addr`, `location`, `about`, `xmpp`, - `keywords`, `gender`, `photo`, `thumb`, `micro`, `forum`, `prv`, (`forum` | `prv`) AS `community`, `contact-type`, `bd` AS `birthday`, `self`, `rel`, `pending` + `keywords`, `photo`, `thumb`, `micro`, `forum`, `prv`, (`forum` | `prv`) AS `community`, `contact-type`, `bd` AS `birthday`, `self`, `rel`, `pending` FROM `contact` WHERE `alias` IN (?, ?, ?) AND `uid` = ?", $nurl, $url, $ssl_url, $uid); $r = DBA::toArray($s); } @@ -997,7 +1016,7 @@ class Contact // Fetch the data from the contact table with "uid=0" (which is filled automatically) if (!DBA::isResult($r)) { $s = DBA::p("SELECT `id`, 0 AS `cid`, `id` AS `zid`, 0 AS `gid`, `uid`, `url`, `nurl`, `alias`, `network`, `name`, `nick`, `addr`, `location`, `about`, `xmpp`, - `keywords`, `gender`, `photo`, `thumb`, `micro`, `forum`, `prv`, (`forum` | `prv`) AS `community`, `contact-type`, `bd` AS `birthday`, 0 AS `self`, `rel`, `pending` + `keywords`, `photo`, `thumb`, `micro`, `forum`, `prv`, (`forum` | `prv`) AS `community`, `contact-type`, `bd` AS `birthday`, 0 AS `self`, `rel`, `pending` FROM `contact` WHERE `nurl` = ? AND `uid` = 0", $nurl); $r = DBA::toArray($s); } @@ -1005,7 +1024,7 @@ class Contact // Fetch the data from the contact table with "uid=0" (which is filled automatically) - checked with the alias if (!DBA::isResult($r)) { $s = DBA::p("SELECT `id`, 0 AS `cid`, `id` AS `zid`, 0 AS `gid`, `uid`, `url`, `nurl`, `alias`, `network`, `name`, `nick`, `addr`, `location`, `about`, `xmpp`, - `keywords`, `gender`, `photo`, `thumb`, `micro`, `forum`, `prv`, (`forum` | `prv`) AS `community`, `contact-type`, `bd` AS `birthday`, 0 AS `self`, `rel`, `pending` + `keywords`, `photo`, `thumb`, `micro`, `forum`, `prv`, (`forum` | `prv`) AS `community`, `contact-type`, `bd` AS `birthday`, 0 AS `self`, `rel`, `pending` FROM `contact` WHERE `alias` IN (?, ?, ?) AND `uid` = 0", $nurl, $url, $ssl_url); $r = DBA::toArray($s); } @@ -1013,12 +1032,13 @@ class Contact // Fetch the data from the gcontact table if (!DBA::isResult($r)) { $s = DBA::p("SELECT 0 AS `id`, 0 AS `cid`, `id` AS `gid`, 0 AS `zid`, 0 AS `uid`, `url`, `nurl`, `alias`, `network`, `name`, `nick`, `addr`, `location`, `about`, '' AS `xmpp`, - `keywords`, `gender`, `photo`, `photo` AS `thumb`, `photo` AS `micro`, 0 AS `forum`, 0 AS `prv`, `community`, `contact-type`, `birthday`, 0 AS `self`, 2 AS `rel`, 0 AS `pending` + `keywords`, `photo`, `photo` AS `thumb`, `photo` AS `micro`, 0 AS `forum`, 0 AS `prv`, `community`, `contact-type`, `birthday`, 0 AS `self`, 2 AS `rel`, 0 AS `pending` FROM `gcontact` WHERE `nurl` = ?", $nurl); $r = DBA::toArray($s); } if (DBA::isResult($r)) { + $authoritativeResult = true; // If there is more than one entry we filter out the connector networks if (count($r) > 1) { foreach ($r as $id => $result) { @@ -1052,6 +1072,7 @@ class Contact $profile["bd"] = DBA::NULL_DATE; } } else { + $authoritativeResult = false; $profile = $default; } @@ -1085,17 +1106,20 @@ class Contact if (empty($profile["cid"]) && ($profile["network"] ?? "") == Protocol::DIASPORA) { $profile["location"] = ""; $profile["about"] = ""; - $profile["gender"] = ""; $profile["birthday"] = DBA::NULL_DATE; } - $cache[$url][$uid] = $profile; + // Only cache the result if it came from the DB since this method is used in widely different contexts + // @see display_fetch_author for an example of $default parameter diverging from the DB result + if ($authoritativeResult) { + $cache[$url][$uid] = $profile; + } return $profile; } /** - * @brief Get contact data for a given address + * Get contact data for a given address * * The function looks at several places (contact table and gcontact table) for the contact * @@ -1103,7 +1127,7 @@ class Contact * @param int $uid User id * * @return array Contact data - * @throws \Friendica\Network\HTTPException\InternalServerErrorException + * @throws HTTPException\InternalServerErrorException * @throws \ImagickException */ public static function getDetailsByAddr($addr, $uid = -1) @@ -1118,7 +1142,7 @@ class Contact // Fetch contact data from the contact table for the given user $r = q("SELECT `id`, `id` AS `cid`, 0 AS `gid`, 0 AS `zid`, `uid`, `url`, `nurl`, `alias`, `network`, `name`, `nick`, `addr`, `location`, `about`, `xmpp`, - `keywords`, `gender`, `photo`, `thumb`, `micro`, `forum`, `prv`, (`forum` | `prv`) AS `community`, `contact-type`, `bd` AS `birthday`, `self`, `rel`, `pending` + `keywords`, `photo`, `thumb`, `micro`, `forum`, `prv`, (`forum` | `prv`) AS `community`, `contact-type`, `bd` AS `birthday`, `self`, `rel`, `pending` FROM `contact` WHERE `addr` = '%s' AND `uid` = %d AND NOT `deleted`", DBA::escape($addr), intval($uid) @@ -1126,7 +1150,7 @@ class Contact // Fetch the data from the contact table with "uid=0" (which is filled automatically) if (!DBA::isResult($r)) { $r = q("SELECT `id`, 0 AS `cid`, `id` AS `zid`, 0 AS `gid`, `uid`, `url`, `nurl`, `alias`, `network`, `name`, `nick`, `addr`, `location`, `about`, `xmpp`, - `keywords`, `gender`, `photo`, `thumb`, `micro`, `forum`, `prv`, (`forum` | `prv`) AS `community`, `contact-type`, `bd` AS `birthday`, 0 AS `self`, `rel`, `pending` + `keywords`, `photo`, `thumb`, `micro`, `forum`, `prv`, (`forum` | `prv`) AS `community`, `contact-type`, `bd` AS `birthday`, 0 AS `self`, `rel`, `pending` FROM `contact` WHERE `addr` = '%s' AND `uid` = 0 AND NOT `deleted`", DBA::escape($addr) ); @@ -1135,7 +1159,7 @@ class Contact // Fetch the data from the gcontact table if (!DBA::isResult($r)) { $r = q("SELECT 0 AS `id`, 0 AS `cid`, `id` AS `gid`, 0 AS `zid`, 0 AS `uid`, `url`, `nurl`, `alias`, `network`, `name`, `nick`, `addr`, `location`, `about`, '' AS `xmpp`, - `keywords`, `gender`, `photo`, `photo` AS `thumb`, `photo` AS `micro`, `community` AS `forum`, 0 AS `prv`, `community`, `contact-type`, `birthday`, 0 AS `self`, 2 AS `rel`, 0 AS `pending` + `keywords`, `photo`, `photo` AS `thumb`, `photo` AS `micro`, `community` AS `forum`, 0 AS `prv`, `community`, `contact-type`, `birthday`, 0 AS `self`, 2 AS `rel`, 0 AS `pending` FROM `gcontact` WHERE `addr` = '%s'", DBA::escape($addr) ); @@ -1153,12 +1177,12 @@ class Contact } /** - * @brief Returns the data array for the photo menu of a given contact + * Returns the data array for the photo menu of a given contact * * @param array $contact contact * @param int $uid optional, default 0 * @return array - * @throws \Friendica\Network\HTTPException\InternalServerErrorException + * @throws HTTPException\InternalServerErrorException * @throws \ImagickException */ public static function photoMenu(array $contact, $uid = 0) @@ -1176,7 +1200,7 @@ class Contact if (empty($contact['uid']) || ($contact['uid'] != $uid)) { if ($uid == 0) { $profile_link = self::magicLink($contact['url']); - $menu = ['profile' => [L10n::t('View Profile'), $profile_link, true]]; + $menu = ['profile' => [DI::l10n()->t('View Profile'), $profile_link, true]]; return $menu; } @@ -1201,9 +1225,9 @@ class Contact } if ($sparkle) { - $status_link = $profile_link . '?tab=status'; + $status_link = $profile_link . '/status'; $photos_link = str_replace('/profile/', '/photos/', $profile_link); - $profile_link = $profile_link . '?tab=profile'; + $profile_link = $profile_link . '/profile'; } if (self::canReceivePrivateMessages($contact) && empty($contact['pending'])) { @@ -1232,36 +1256,40 @@ class Contact } } + if (!empty($follow_link) || !empty($unfollow_link)) { + $contact_drop_link = ''; + } + /** * Menu array: * "name" => [ "Label", "link", (bool)Should the link opened in a new tab? ] */ if (empty($contact['uid'])) { $menu = [ - 'profile' => [L10n::t('View Profile') , $profile_link , true], - 'network' => [L10n::t('Network Posts') , $posts_link , false], - 'edit' => [L10n::t('View Contact') , $contact_url , false], - 'follow' => [L10n::t('Connect/Follow'), $follow_link , true], - 'unfollow'=> [L10n::t('UnFollow') , $unfollow_link, true], + 'profile' => [DI::l10n()->t('View Profile') , $profile_link , true], + 'network' => [DI::l10n()->t('Network Posts') , $posts_link , false], + 'edit' => [DI::l10n()->t('View Contact') , $contact_url , false], + 'follow' => [DI::l10n()->t('Connect/Follow'), $follow_link , true], + 'unfollow'=> [DI::l10n()->t('UnFollow') , $unfollow_link, true], ]; } else { $menu = [ - 'status' => [L10n::t('View Status') , $status_link , true], - 'profile' => [L10n::t('View Profile') , $profile_link , true], - 'photos' => [L10n::t('View Photos') , $photos_link , true], - 'network' => [L10n::t('Network Posts') , $posts_link , false], - 'edit' => [L10n::t('View Contact') , $contact_url , false], - 'drop' => [L10n::t('Drop Contact') , $contact_drop_link, false], - 'pm' => [L10n::t('Send PM') , $pm_url , false], - 'poke' => [L10n::t('Poke') , $poke_link , false], - 'follow' => [L10n::t('Connect/Follow'), $follow_link , true], - 'unfollow'=> [L10n::t('UnFollow') , $unfollow_link , true], + 'status' => [DI::l10n()->t('View Status') , $status_link , true], + 'profile' => [DI::l10n()->t('View Profile') , $profile_link , true], + 'photos' => [DI::l10n()->t('View Photos') , $photos_link , true], + 'network' => [DI::l10n()->t('Network Posts') , $posts_link , false], + 'edit' => [DI::l10n()->t('View Contact') , $contact_url , false], + 'drop' => [DI::l10n()->t('Drop Contact') , $contact_drop_link, false], + 'pm' => [DI::l10n()->t('Send PM') , $pm_url , false], + 'poke' => [DI::l10n()->t('Poke') , $poke_link , false], + 'follow' => [DI::l10n()->t('Connect/Follow'), $follow_link , true], + 'unfollow'=> [DI::l10n()->t('UnFollow') , $unfollow_link , true], ]; if (!empty($contact['pending'])) { $intro = DBA::selectFirst('intro', ['id'], ['contact-id' => $contact['id']]); if (DBA::isResult($intro)) { - $menu['follow'] = [L10n::t('Approve'), 'notifications/intros/' . $intro['id'], true]; + $menu['follow'] = [DI::l10n()->t('Approve'), 'notifications/intros/' . $intro['id'], true]; } } } @@ -1282,7 +1310,7 @@ class Contact } /** - * @brief Returns ungrouped contact count or list for user + * Returns ungrouped contact count or list for user * * Returns either the total number of ungrouped contacts for the given user * id or a paginated list of ungrouped contacts. @@ -1393,7 +1421,7 @@ class Contact } /** - * @brief Fetch the contact id for a given URL and user + * Fetch the contact id for a given URL and user * * First lookup in the contact table to find a record matching either `url`, `nurl`, * `addr` or `alias`. @@ -1417,7 +1445,7 @@ class Contact * @param boolean $in_loop Internally used variable to prevent an endless loop * * @return integer Contact ID - * @throws \Friendica\Network\HTTPException\InternalServerErrorException + * @throws HTTPException\InternalServerErrorException * @throws \ImagickException */ public static function getIdForURL($url, $uid = 0, $no_update = false, $default = [], $in_loop = false) @@ -1631,12 +1659,12 @@ class Contact } /** - * @brief Checks if the contact is archived + * Checks if the contact is archived * * @param int $cid contact id * * @return boolean Is the contact archived? - * @throws \Friendica\Network\HTTPException\InternalServerErrorException + * @throws HTTPException\InternalServerErrorException */ public static function isArchived(int $cid) { @@ -1675,12 +1703,12 @@ class Contact } /** - * @brief Checks if the contact is blocked + * Checks if the contact is blocked * * @param int $cid contact id * * @return boolean Is the contact blocked? - * @throws \Friendica\Network\HTTPException\InternalServerErrorException + * @throws HTTPException\InternalServerErrorException */ public static function isBlocked($cid) { @@ -1701,7 +1729,7 @@ class Contact } /** - * @brief Checks if the contact is hidden + * Checks if the contact is hidden * * @param int $cid contact id * @@ -1722,7 +1750,7 @@ class Contact } /** - * @brief Returns posts from a given contact url + * Returns posts from a given contact url * * @param string $contact_url Contact URL * @@ -1758,7 +1786,15 @@ class Contact $cid, GRAVITY_PARENT, GRAVITY_COMMENT, local_user()]; } - $pager = new Pager(DI::args()->getQueryString()); + if (DI::mode()->isMobile()) { + $itemsPerPage = DI::pConfig()->get(local_user(), 'system', 'itemspage_mobile_network', + DI::config()->get('system', 'itemspage_network_mobile')); + } else { + $itemsPerPage = DI::pConfig()->get(local_user(), 'system', 'itemspage_network', + DI::config()->get('system', 'itemspage_network')); + } + + $pager = new Pager(DI::l10n(), DI::args()->getQueryString(), $itemsPerPage); $params = ['order' => ['received' => true], 'limit' => [$pager->getStart(), $pager->getItemsPerPage()]]; @@ -1768,13 +1804,13 @@ class Contact $items = Item::inArray($r); - $o = conversation($a, $items, $pager, 'contacts', $update, false, 'commented', local_user()); + $o = conversation($a, $items, 'contacts', $update, false, 'commented', local_user()); } else { $r = Item::selectForUser(local_user(), [], $condition, $params); $items = Item::inArray($r); - $o = conversation($a, $items, $pager, 'contact-posts', false); + $o = conversation($a, $items, 'contact-posts', false); } if (!$update) { @@ -1785,7 +1821,7 @@ class Contact } /** - * @brief Returns the account type name + * Returns the account type name * * The function can be called with either the user or the contact array * @@ -1820,15 +1856,15 @@ class Contact switch ($type) { case self::TYPE_ORGANISATION: - $account_type = L10n::t("Organisation"); + $account_type = DI::l10n()->t("Organisation"); break; case self::TYPE_NEWS: - $account_type = L10n::t('News'); + $account_type = DI::l10n()->t('News'); break; case self::TYPE_COMMUNITY: - $account_type = L10n::t("Forum"); + $account_type = DI::l10n()->t("Forum"); break; default: @@ -1840,7 +1876,7 @@ class Contact } /** - * @brief Blocks a contact + * Blocks a contact * * @param int $cid * @return bool @@ -1854,7 +1890,7 @@ class Contact } /** - * @brief Unblocks a contact + * Unblocks a contact * * @param int $cid * @return bool @@ -1868,7 +1904,7 @@ class Contact } /** - * @brief Updates the avatar links in a contact only if needed + * Updates the avatar links in a contact only if needed * * @param string $avatar Link to avatar picture * @param int $uid User id of contact owner @@ -1876,7 +1912,7 @@ class Contact * @param bool $force force picture update * * @return array Returns array of the different avatar sizes - * @throws \Friendica\Network\HTTPException\InternalServerErrorException + * @throws HTTPException\InternalServerErrorException * @throws \ImagickException */ public static function updateAvatar($avatar, $uid, $cid, $force = false) @@ -1888,6 +1924,14 @@ class Contact $data = [$contact["photo"], $contact["thumb"], $contact["micro"]]; } + foreach ($data as $image_uri) { + $image_rid = Photo::ridFromURI($image_uri); + if ($image_rid && !Photo::exists(['resource-id' => $image_rid, 'uid' => $uid])) { + Logger::info('Regenerating avatar', ['contact uid' => $uid, 'cid' => $cid, 'missing photo' => $image_rid, 'avatar' => $contact['avatar']]); + $force = true; + } + } + if (($contact["avatar"] != $avatar) || $force) { $photos = Photo::importProfilePhoto($avatar, $uid, $cid, true); @@ -1910,8 +1954,8 @@ class Contact return $data; } - /** - * @brief Helper function for "updateFromProbe". Updates personal and public contact + /** + * Helper function for "updateFromProbe". Updates personal and public contact * * @param integer $id contact id * @param integer $uid user id @@ -1969,8 +2013,8 @@ class Contact DBA::update('contact', $fields, $condition); } - /** - * @brief Remove duplicated contacts + /** + * Remove duplicated contacts * * @param string $nurl Normalised contact url * @param integer $uid User id @@ -2018,7 +2062,7 @@ class Contact * @param string $network Optional network we are probing for * @param boolean $force Optional forcing of network probing (otherwise we use the cached data) * @return boolean - * @throws \Friendica\Network\HTTPException\InternalServerErrorException + * @throws HTTPException\InternalServerErrorException * @throws \ImagickException */ public static function updateFromProbe($id, $network = '', $force = false) @@ -2031,7 +2075,7 @@ class Contact // These fields aren't updated by this routine: // 'xmpp', 'sensitive' - $fields = ['uid', 'avatar', 'name', 'nick', 'location', 'keywords', 'about', 'gender', + $fields = ['uid', 'avatar', 'name', 'nick', 'location', 'keywords', 'about', 'unsearchable', 'url', 'addr', 'batch', 'notify', 'poll', 'request', 'confirm', 'poco', 'network', 'alias', 'baseurl', 'forum', 'prv', 'contact-type', 'pubkey']; $contact = DBA::selectFirst('contact', $fields, ['id' => $id]); @@ -2110,6 +2154,12 @@ class Contact if ($force) { self::updateContact($id, $uid, $ret['url'], ['last-update' => $updated, 'success_update' => $updated]); } + + // Update the public contact + if ($uid != 0) { + self::updateFromProbeByURL($ret['url']); + } + return true; } @@ -2190,6 +2240,7 @@ class Contact /** * Takes a $uid and a url/handle and adds a new contact + * * Currently if the contact is DFRN, interactive needs to be true, to redirect to the * dfrn_request page. * @@ -2199,36 +2250,36 @@ class Contact * $return['success'] boolean true if successful * $return['message'] error text if success is false. * - * @brief Takes a $uid and a url/handle and adds a new contact + * Takes a $uid and a url/handle and adds a new contact * @param int $uid * @param string $url * @param bool $interactive * @param string $network * @return array - * @throws \Friendica\Network\HTTPException\InternalServerErrorException + * @throws HTTPException\InternalServerErrorException * @throws \ImagickException */ public static function createFromProbe($uid, $url, $interactive = false, $network = '') { $result = ['cid' => -1, 'success' => false, 'message' => '']; - $a = \get_app(); + $a = DI::app(); // remove ajax junk, e.g. Twitter $url = str_replace('/#!/', '/', $url); if (!Network::isUrlAllowed($url)) { - $result['message'] = L10n::t('Disallowed profile URL.'); + $result['message'] = DI::l10n()->t('Disallowed profile URL.'); return $result; } if (Network::isUrlBlocked($url)) { - $result['message'] = L10n::t('Blocked domain'); + $result['message'] = DI::l10n()->t('Blocked domain'); return $result; } if (!$url) { - $result['message'] = L10n::t('Connect URL missing.'); + $result['message'] = DI::l10n()->t('Connect URL missing.'); return $result; } @@ -2237,7 +2288,7 @@ class Contact Hook::callAll('follow', $arr); if (empty($arr)) { - $result['message'] = L10n::t('The contact could not be added. Please check the relevant network credentials in your Settings -> Social Networks page.'); + $result['message'] = DI::l10n()->t('The contact could not be added. Please check the relevant network credentials in your Settings -> Social Networks page.'); return $result; } @@ -2277,9 +2328,9 @@ class Contact // NOTREACHED } - } elseif (Config::get('system', 'dfrn_only') && ($ret['network'] != Protocol::DFRN)) { - $result['message'] = L10n::t('This site is not configured to allow communications with other networks.') . EOL; - $result['message'] .= L10n::t('No compatible communication protocols or feeds were discovered.') . EOL; + } elseif (DI::config()->get('system', 'dfrn_only') && ($ret['network'] != Protocol::DFRN)) { + $result['message'] = DI::l10n()->t('This site is not configured to allow communications with other networks.') . EOL; + $result['message'] .= DI::l10n()->t('No compatible communication protocols or feeds were discovered.') . EOL; return $result; } @@ -2290,30 +2341,30 @@ class Contact // do we have enough information? if (empty($ret['name']) || empty($ret['poll']) || (empty($ret['url']) && empty($ret['addr']))) { - $result['message'] .= L10n::t('The profile address specified does not provide adequate information.') . EOL; + $result['message'] .= DI::l10n()->t('The profile address specified does not provide adequate information.') . EOL; if (empty($ret['poll'])) { - $result['message'] .= L10n::t('No compatible communication protocols or feeds were discovered.') . EOL; + $result['message'] .= DI::l10n()->t('No compatible communication protocols or feeds were discovered.') . EOL; } if (empty($ret['name'])) { - $result['message'] .= L10n::t('An author or name was not found.') . EOL; + $result['message'] .= DI::l10n()->t('An author or name was not found.') . EOL; } if (empty($ret['url'])) { - $result['message'] .= L10n::t('No browser URL could be matched to this address.') . EOL; + $result['message'] .= DI::l10n()->t('No browser URL could be matched to this address.') . EOL; } if (strpos($url, '@') !== false) { - $result['message'] .= L10n::t('Unable to match @-style Identity Address with a known protocol or email contact.') . EOL; - $result['message'] .= L10n::t('Use mailto: in front of address to force email check.') . EOL; + $result['message'] .= DI::l10n()->t('Unable to match @-style Identity Address with a known protocol or email contact.') . EOL; + $result['message'] .= DI::l10n()->t('Use mailto: in front of address to force email check.') . EOL; } return $result; } - if ($protocol === Protocol::OSTATUS && Config::get('system', 'ostatus_disabled')) { - $result['message'] .= L10n::t('The profile address specified belongs to a network which has been disabled on this site.') . EOL; + if ($protocol === Protocol::OSTATUS && DI::config()->get('system', 'ostatus_disabled')) { + $result['message'] .= DI::l10n()->t('The profile address specified belongs to a network which has been disabled on this site.') . EOL; $ret['notify'] = ''; } if (!$ret['notify']) { - $result['message'] .= L10n::t('Limited profile. This person will be unable to receive direct/personal notifications from you.') . EOL; + $result['message'] .= DI::l10n()->t('Limited profile. This person will be unable to receive direct/personal notifications from you.') . EOL; } $writeable = ((($protocol === Protocol::OSTATUS) && ($ret['notify'])) ? 1 : 0); @@ -2374,7 +2425,7 @@ class Contact $contact = DBA::selectFirst('contact', [], ['url' => $ret['url'], 'network' => $ret['network'], 'uid' => $uid]); if (!DBA::isResult($contact)) { - $result['message'] .= L10n::t('Unable to retrieve contact information.') . EOL; + $result['message'] .= DI::l10n()->t('Unable to retrieve contact information.') . EOL; return $result; } @@ -2429,7 +2480,7 @@ class Contact } /** - * @brief Updated contact's SSL policy + * Updated contact's SSL policy * * @param array $contact Contact array * @param string $new_policy New policy, valid: self,full @@ -2477,7 +2528,7 @@ class Contact * @param bool $sharing True: Contact is now sharing with Owner; False: Contact is now following Owner (default) * @param string $note Introduction additional message * @return bool|null True: follow request is accepted; False: relationship is rejected; Null: relationship is pending - * @throws \Friendica\Network\HTTPException\InternalServerErrorException + * @throws HTTPException\InternalServerErrorException * @throws \ImagickException */ public static function addRelationship(array $importer, array $contact, array $datarray, $sharing = false, $note = '') @@ -2584,18 +2635,18 @@ class Contact Group::addMember(User::getDefaultGroup($importer['uid'], $contact_record["network"]), $contact_record['id']); - if (($user['notify-flags'] & NOTIFY_INTRO) && + if (($user['notify-flags'] & Type::INTRO) && in_array($user['page-flags'], [User::PAGE_FLAGS_NORMAL])) { notification([ - 'type' => NOTIFY_INTRO, + 'type' => Type::INTRO, 'notify_flags' => $user['notify-flags'], 'language' => $user['language'], 'to_name' => $user['username'], 'to_email' => $user['email'], 'uid' => $user['uid'], - 'link' => DI::baseUrl() . '/notifications/intro', - 'source_name' => ((strlen(stripslashes($contact_record['name']))) ? stripslashes($contact_record['name']) : L10n::t('[Name Withheld]')), + 'link' => DI::baseUrl() . '/notifications/intros', + 'source_name' => ((strlen(stripslashes($contact_record['name']))) ? stripslashes($contact_record['name']) : DI::l10n()->t('[Name Withheld]')), 'source_link' => $contact_record['url'], 'source_photo' => $contact_record['photo'], 'verb' => ($sharing ? Activity::FRIEND : Activity::FOLLOW), @@ -2603,8 +2654,17 @@ class Contact ]); } } elseif (DBA::isResult($user) && in_array($user['page-flags'], [User::PAGE_FLAGS_SOAPBOX, User::PAGE_FLAGS_FREELOVE, User::PAGE_FLAGS_COMMUNITY])) { + if (($user['page-flags'] == User::PAGE_FLAGS_FREELOVE) && ($network != Protocol::DIASPORA)) { + self::createFromProbe($importer['uid'], $url, false, $network); + } + $condition = ['uid' => $importer['uid'], 'url' => $url, 'pending' => true]; - DBA::update('contact', ['pending' => false], $condition); + $fields = ['pending' => false]; + if ($user['page-flags'] == User::PAGE_FLAGS_FREELOVE) { + $fields['rel'] = Contact::FRIEND; + } + + DBA::update('contact', $fields, $condition); return true; } @@ -2632,7 +2692,7 @@ class Contact } /** - * @brief Create a birthday event. + * Create a birthday event. * * Update the year and the birthday. */ @@ -2674,30 +2734,27 @@ class Contact * Remove the unavailable contact ids from the provided list * * @param array $contact_ids Contact id list + * @return array * @throws \Exception */ - public static function pruneUnavailable(array &$contact_ids) + public static function pruneUnavailable(array $contact_ids) { if (empty($contact_ids)) { - return; - } - - $str = DBA::escape(implode(',', $contact_ids)); - - $stmt = DBA::p("SELECT `id` FROM `contact` WHERE `id` IN ( " . $str . ") AND `blocked` = 0 AND `pending` = 0 AND `archive` = 0"); - - $return = []; - while($contact = DBA::fetch($stmt)) { - $return[] = $contact['id']; + return []; } - DBA::close($stmt); + $contacts = Contact::selectToArray(['id'], [ + 'id' => $contact_ids, + 'blocked' => false, + 'pending' => false, + 'archive' => false, + ]); - $contact_ids = $return; + return array_column($contacts, 'id'); } /** - * @brief Returns a magic link to authenticate remote visitors + * Returns a magic link to authenticate remote visitors * * @todo check if the return is either a fully qualified URL or a relative path to Friendica basedir * @@ -2705,7 +2762,7 @@ class Contact * @param string $url An url that we will be redirected to after the authentication * * @return string with "redir" link - * @throws \Friendica\Network\HTTPException\InternalServerErrorException + * @throws HTTPException\InternalServerErrorException * @throws \ImagickException */ public static function magicLink($contact_url, $url = '') @@ -2726,13 +2783,13 @@ class Contact } /** - * @brief Returns a magic link to authenticate remote visitors + * Returns a magic link to authenticate remote visitors * * @param integer $cid The contact id of the target contact profile * @param string $url An url that we will be redirected to after the authentication * * @return string with "redir" link - * @throws \Friendica\Network\HTTPException\InternalServerErrorException + * @throws HTTPException\InternalServerErrorException * @throws \ImagickException */ public static function magicLinkbyId($cid, $url = '') @@ -2743,13 +2800,13 @@ class Contact } /** - * @brief Returns a magic link to authenticate remote visitors + * Returns a magic link to authenticate remote visitors * * @param array $contact The contact array with "uid", "network" and "url" * @param string $url An url that we will be redirected to after the authentication * * @return string with "redir" link - * @throws \Friendica\Network\HTTPException\InternalServerErrorException + * @throws HTTPException\InternalServerErrorException * @throws \ImagickException */ public static function magicLinkByContact($contact, $url = '')