X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=src%2FModel%2FItem.php;h=18b56215ce39ca9a680e64fc062f693c84dca392;hb=58e5f0d9c5ba75f92cc4c77b5b27069789f11318;hp=bed726704a24dbeaf9b37aac87f0cb1d5b875e8b;hpb=8640afc82e24e8b3ae3595a5aa4978be3bb868c4;p=friendica.git
diff --git a/src/Model/Item.php b/src/Model/Item.php
index bed726704a..18b56215ce 100644
--- a/src/Model/Item.php
+++ b/src/Model/Item.php
@@ -22,6 +22,9 @@
namespace Friendica\Model;
use Friendica\Contact\LocalRelationship\Entity\LocalRelationship;
+use Friendica\Content\Image;
+use Friendica\Content\Post\Collection\PostMedias;
+use Friendica\Content\Post\Entity\PostMedia;
use Friendica\Content\Text\BBCode;
use Friendica\Content\Text\HTML;
use Friendica\Core\Hook;
@@ -34,6 +37,7 @@ use Friendica\Database\DBA;
use Friendica\DI;
use Friendica\Model\Post\Category;
use Friendica\Network\HTTPException\InternalServerErrorException;
+use Friendica\Network\HTTPException\ServiceUnavailableException;
use Friendica\Protocol\Activity;
use Friendica\Protocol\ActivityPub;
use Friendica\Protocol\Delivery;
@@ -113,7 +117,7 @@ class Item
const DELIVER_FIELDLIST = [
'uid', 'id', 'parent', 'uri-id', 'uri', 'thr-parent', 'parent-uri', 'guid',
'parent-guid', 'conversation', 'received', 'created', 'edited', 'verb', 'object-type', 'object', 'target',
- 'private', 'title', 'body', 'raw-body', 'location', 'coord', 'app',
+ 'private', 'title', 'body', 'raw-body', 'language', 'location', 'coord', 'app',
'inform', 'deleted', 'extid', 'post-type', 'post-reason', 'gravity',
'allow_cid', 'allow_gid', 'deny_cid', 'deny_gid',
'author-id', 'author-addr', 'author-link', 'author-name', 'author-avatar', 'owner-id', 'owner-link', 'contact-uid',
@@ -326,7 +330,7 @@ class Item
*/
public static function markForDeletionById(int $item_id, int $priority = Worker::PRIORITY_HIGH): bool
{
- Logger::info('Mark item for deletion by id', ['id' => $item_id, 'callstack' => System::callstack()]);
+ Logger::info('Mark item for deletion by id', ['id' => $item_id]);
// locate item to be deleted
$fields = [
'id', 'uri', 'uri-id', 'uid', 'parent', 'parent-uri-id', 'origin',
@@ -791,7 +795,7 @@ class Item
}
if (!DBA::isResult($parent)) {
- Logger::notice('item parent was not found - ignoring item', ['uri-id' => $item['uri-id'], 'thr-parent-id' => $item['thr-parent-id'], 'uid' => $item['uid'], 'callstack' => System::callstack(20)]);
+ Logger::notice('item parent was not found - ignoring item', ['uri-id' => $item['uri-id'], 'thr-parent-id' => $item['thr-parent-id'], 'uid' => $item['uid']]);
return [];
}
@@ -876,6 +880,10 @@ class Item
if (is_int($notify) && in_array($notify, Worker::PRIORITIES)) {
$priority = $notify;
}
+
+ // Mastodon style API visibility
+ $copy_permissions = ($item['visibility'] ?? 'private') == 'private';
+ unset($item['visibility']);
} else {
$item['network'] = trim(($item['network'] ?? '') ?: Protocol::PHANTOM);
}
@@ -1034,10 +1042,12 @@ class Item
// Reshares have to keep their permissions to allow groups to work
if (!$defined_permissions && (!$item['origin'] || ($item['verb'] != Activity::ANNOUNCE))) {
- $item['allow_cid'] = $toplevel_parent['allow_cid'];
- $item['allow_gid'] = $toplevel_parent['allow_gid'];
- $item['deny_cid'] = $toplevel_parent['deny_cid'];
- $item['deny_gid'] = $toplevel_parent['deny_gid'];
+ // Don't store the permissions on pure AP posts
+ $store_permissions = ($item['network'] != Protocol::ACTIVITYPUB) || $item['origin'] || !empty($item['diaspora_signed_text']);
+ $item['allow_cid'] = $store_permissions ? $toplevel_parent['allow_cid'] : '';
+ $item['allow_gid'] = $store_permissions ? $toplevel_parent['allow_gid'] : '';
+ $item['deny_cid'] = $store_permissions ? $toplevel_parent['deny_cid'] : '';
+ $item['deny_gid'] = $store_permissions ? $toplevel_parent['deny_gid'] : '';
}
$parent_origin = $toplevel_parent['origin'];
@@ -1179,7 +1189,7 @@ class Item
if (!empty($quote_id)) {
// This is one of these "should not happen" situations.
// The protocol implementations should already have done this job.
- Logger::notice('Quote-uri-id detected in post', ['id' => $quote_id, 'guid' => $item['guid'], 'uri-id' => $item['uri-id'], 'callstack' => System::callstack(20)]);
+ Logger::notice('Quote-uri-id detected in post', ['id' => $quote_id, 'guid' => $item['guid'], 'uri-id' => $item['uri-id']]);
$item['quote-uri-id'] = $quote_id;
}
}
@@ -1208,8 +1218,6 @@ class Item
// Check for hashtags in the body and repair or add hashtag links
$item['body'] = self::setHashtags($item['body']);
- $item['language'] = self::getLanguage($item);
-
$notify_type = Delivery::POST;
// Filling item related side tables
@@ -1258,6 +1266,8 @@ class Item
}
}
+ $item['language'] = self::getLanguage($item);
+
$inserted = Post::insert($item['uri-id'], $item);
if ($item['gravity'] == self::GRAVITY_PARENT) {
@@ -1355,6 +1365,9 @@ class Item
if ($notify) {
DI::contentItem()->postProcessPost($posted_item);
+ if ($copy_permissions && ($posted_item['thr-parent-id'] != $posted_item['uri-id']) && ($posted_item['private'] == self::PRIVATE)) {
+ DI::contentItem()->copyPermissions($posted_item['thr-parent-id'], $posted_item['uri-id']);
+ }
} else {
Hook::callAll('post_remote_end', $posted_item);
}
@@ -1471,6 +1484,10 @@ class Item
*/
private static function setOwnerforResharedItem(array $item)
{
+ if ($item['uid'] == 0) {
+ return;
+ }
+
$parent = Post::selectFirst(
['id', 'causer-id', 'owner-id', 'author-id', 'author-link', 'origin', 'post-reason'],
['uri-id' => $item['thr-parent-id'], 'uid' => $item['uid']]
@@ -1987,7 +2004,7 @@ class Item
return '';
}
- $languages = self::getLanguageArray(trim($item['title'] . "\n" . $item['body']), 3, $item['uri-id'], $item['author-id']);
+ $languages = self::getLanguageArray($item['title'] . ' ' . ($item['content-warning'] ?? '') . ' ' . $item['body'], 3, $item['uri-id'], $item['author-id']);
if (empty($languages)) {
return '';
}
@@ -2006,67 +2023,141 @@ class Item
*/
public static function getLanguageArray(string $body, int $count, int $uri_id = 0, int $author_id = 0): array
{
- $naked_body = BBCode::toSearchText($body, $uri_id);
+ $searchtext = BBCode::toSearchText($body, $uri_id);
- if ((count(explode(' ', $naked_body)) < 10) && (mb_strlen($naked_body) < 30) && $author_id) {
+ if ((count(explode(' ', $searchtext)) < 10) && (mb_strlen($searchtext) < 30) && $author_id) {
$author = Contact::selectFirst(['about'], ['id' => $author_id]);
if (!empty($author['about'])) {
$about = BBCode::toSearchText($author['about'], 0);
- $about = self::getDominantLanguage($about);
- Logger::debug('About field added', ['author' => $author_id, 'body' => $naked_body, 'about' => $about]);
- $naked_body .= ' ' . $about;
+ Logger::debug('About field added', ['author' => $author_id, 'body' => $searchtext, 'about' => $about]);
+ $searchtext .= ' ' . $about;
}
}
- if (empty($naked_body)) {
+ if (empty($searchtext)) {
return [];
}
- $naked_body = self::getDominantLanguage($naked_body);
+ $ld = new Language(DI::l10n()->getDetectableLanguages());
- $availableLanguages = DI::l10n()->getAvailableLanguages(true);
- $availableLanguages = DI::l10n()->convertForLanguageDetection($availableLanguages);
+ $result = [];
- $ld = new Language(array_keys($availableLanguages));
- $languages = $ld->detect($naked_body)->limit(0, $count)->close() ?: [];
+ foreach (self::splitByBlocks($searchtext) as $block) {
+ $languages = $ld->detect($block)->close() ?: [];
- $data = [
- 'text' => $naked_body,
- 'detected' => $languages,
- 'uri-id' => $uri_id,
- ];
+ $data = [
+ 'text' => $block,
+ 'detected' => $languages,
+ 'uri-id' => $uri_id,
+ 'author-id' => $author_id,
+ ];
+ Hook::callAll('detect_languages', $data);
+
+ foreach ($data['detected'] as $language => $quality) {
+ $result[$language] = max($result[$language] ?? 0, $quality * (strlen($block) / strlen($searchtext)));
+ }
+ }
+
+ $result = self::compactLanguages($result);
- Hook::callAll('detect_languages', $data);
- $languages = $data['detected'];
+ arsort($result);
+ return array_slice($result, 0, $count);
+ }
+ /**
+ * Concert the language code in the detection result to ISO 639-1.
+ * On duplicates the system uses the higher quality value.
+ *
+ * @param array $result
+ * @return array
+ */
+ private static function compactLanguages(array $result): array
+ {
+ $languages = [];
+ foreach ($result as $language => $quality) {
+ if ($quality == 0) {
+ continue;
+ }
+ $code = DI::l10n()->toISO6391($language);
+ if (empty($languages[$code]) || ($languages[$code] < $quality)) {
+ $languages[$code] = $quality;
+ }
+ }
return $languages;
}
/**
- * Check if latin or non latin are dominant in the body and only return the dominant one
+ * Split a string into different unicode blocks
+ * Currently the text is split into the latin and the non latin part.
*
* @param string $body
- * @return string
+ * @return array
*/
- private static function getDominantLanguage(string $body): string
+ private static function splitByBlocks(string $body): array
{
- $latin = '';
- $non_latin = '';
+ if (!class_exists('IntlChar')) {
+ return [$body];
+ }
+
+ $blocks = [];
+ $previous_block = 0;
+
for ($i = 0; $i < mb_strlen($body); $i++) {
$character = mb_substr($body, $i, 1);
- $ord = mb_ord($character);
-
- // We add the most common characters to both strings.
- if (($ord <= 64) || ($ord >= 91 && $ord <= 96) || ($ord >= 123 && $ord <= 191) || in_array($ord, [215, 247]) || ($ord >= 697 && $ord <= 735) || ($ord > 65535)) {
- $latin .= $character;
- $non_latin .= $character;
- } elseif ($ord < 768) {
- $latin .= $character;
+ $previous = ($i > 0) ? mb_substr($body, $i - 1, 1) : '';
+ $next = ($i < mb_strlen($body)) ? mb_substr($body, $i + 1, 1) : '';
+
+ if (!\IntlChar::isalpha($character)) {
+ if (($previous != '') && (\IntlChar::isalpha($previous))) {
+ $previous_block = self::getBlockCode($previous);
+ }
+
+ $block = (($next != '') && \IntlChar::isalpha($next)) ? self::getBlockCode($next) : $previous_block;
+ $blocks[$block] = ($blocks[$block] ?? '') . $character;
} else {
- $non_latin .= $character;
+ $block = self::getBlockCode($character);
+ $blocks[$block] = ($blocks[$block] ?? '') . $character;
+ }
+ }
+
+ foreach (array_keys($blocks) as $key) {
+ $blocks[$key] = trim($blocks[$key]);
+ if (empty($blocks[$key])) {
+ unset($blocks[$key]);
}
}
- return (mb_strlen($latin) > mb_strlen($non_latin)) ? $latin : $non_latin;
+
+ return array_values($blocks);
+ }
+
+ /**
+ * returns the block code for the given character
+ *
+ * @param string $character
+ * @return integer 0 = no alpha character (blank, signs, emojis, ...), 1 = latin character, 2 = character in every other language
+ */
+ private static function getBlockCode(string $character): int
+ {
+ if (!\IntlChar::isalpha($character)) {
+ return 0;
+ }
+ return self::isLatin($character) ? 1 : 2;
+ }
+
+ /**
+ * Checks if the given character is in one of the latin code blocks
+ *
+ * @param string $character
+ * @return boolean
+ */
+ private static function isLatin(string $character): bool
+ {
+ return in_array(\IntlChar::getBlockCode($character), [
+ \IntlChar::BLOCK_CODE_BASIC_LATIN, \IntlChar::BLOCK_CODE_LATIN_1_SUPPLEMENT,
+ \IntlChar::BLOCK_CODE_LATIN_EXTENDED_A, \IntlChar::BLOCK_CODE_LATIN_EXTENDED_B,
+ \IntlChar::BLOCK_CODE_LATIN_EXTENDED_C, \IntlChar::BLOCK_CODE_LATIN_EXTENDED_D,
+ \IntlChar::BLOCK_CODE_LATIN_EXTENDED_E, \IntlChar::BLOCK_CODE_LATIN_EXTENDED_ADDITIONAL
+ ]);
}
public static function getLanguageMessage(array $item): string
@@ -2075,7 +2166,15 @@ class Item
$used_languages = '';
foreach (json_decode($item['language'], true) as $language => $reliability) {
- $used_languages .= $iso639->languageByCode1($language) . ' (' . $language . "): " . number_format($reliability, 5) . '\n';
+ $code = DI::l10n()->toISO6391($language);
+
+ $native = $iso639->nativeByCode1($code);
+ $language = $iso639->languageByCode1($code);
+ if ($native != $language) {
+ $used_languages .= DI::l10n()->t('%s (%s - %s): %s', $native, $language, $code, number_format($reliability, 5)) . '\n';
+ } else {
+ $used_languages .= DI::l10n()->t('%s (%s): %s', $native, $code, number_format($reliability, 5)) . '\n';
+ }
}
$used_languages = DI::l10n()->t('Detected languages in this post:\n%s', $used_languages);
return $used_languages;
@@ -2103,7 +2202,7 @@ class Item
$hostPart = $host ?: $parsed['host'] ?? '';
if (!$hostPart) {
- Logger::warning('Empty host GUID part', ['uri' => $uri, 'host' => $host, 'parsed' => $parsed, 'callstack' => System::callstack(10)]);
+ Logger::warning('Empty host GUID part', ['uri' => $uri, 'host' => $host, 'parsed' => $parsed]);
}
// Glue it together to be able to make a hash from it
@@ -3175,15 +3274,15 @@ class Item
if (!empty($shared_item['uri-id'])) {
$shared_uri_id = $shared_item['uri-id'];
$shared_links[] = strtolower($shared_item['plink']);
- $shared_attachments = Post\Media::splitAttachments($shared_uri_id, [], $shared_item['has-media']);
- $shared_links = array_merge($shared_links, array_column($shared_attachments['visual'], 'url'));
- $shared_links = array_merge($shared_links, array_column($shared_attachments['link'], 'url'));
- $shared_links = array_merge($shared_links, array_column($shared_attachments['additional'], 'url'));
- $item['body'] = self::replaceVisualAttachments($shared_attachments, $item['body']);
+ $sharedSplitAttachments = DI::postMediaRepository()->splitAttachments($shared_uri_id, [], $shared_item['has-media']);
+ $shared_links = array_merge($shared_links, $sharedSplitAttachments['visual']->column('url'));
+ $shared_links = array_merge($shared_links, $sharedSplitAttachments['link']->column('url'));
+ $shared_links = array_merge($shared_links, $sharedSplitAttachments['additional']->column('url'));
+ $item['body'] = self::replaceVisualAttachments($sharedSplitAttachments['visual'], $item['body']);
}
- $attachments = Post\Media::splitAttachments($item['uri-id'], $shared_links, $item['has-media'] ?? false);
- $item['body'] = self::replaceVisualAttachments($attachments, $item['body'] ?? '');
+ $itemSplitAttachments = DI::postMediaRepository()->splitAttachments($item['uri-id'], $shared_links, $item['has-media'] ?? false);
+ $item['body'] = self::replaceVisualAttachments($itemSplitAttachments['visual'], $item['body'] ?? '');
self::putInCache($item);
$item['body'] = $body;
@@ -3208,7 +3307,7 @@ class Item
$filter_reasons[] = DI::l10n()->t('Content warning: %s', $item['content-warning']);
}
- $item['attachments'] = $attachments;
+ $item['attachments'] = $itemSplitAttachments;
$hook_data = [
'item' => $item,
@@ -3237,11 +3336,11 @@ class Item
return $s;
}
- if (!empty($shared_attachments)) {
- $s = self::addGallery($s, $shared_attachments, $item['uri-id']);
- $s = self::addVisualAttachments($shared_attachments, $shared_item, $s, true);
- $s = self::addLinkAttachment($shared_uri_id ?: $item['uri-id'], $shared_attachments, $body, $s, true, $quote_shared_links);
- $s = self::addNonVisualAttachments($shared_attachments, $item, $s, true);
+ if (!empty($sharedSplitAttachments)) {
+ $s = self::addGallery($s, $sharedSplitAttachments['visual']);
+ $s = self::addVisualAttachments($sharedSplitAttachments['visual'], $shared_item, $s, true);
+ $s = self::addLinkAttachment($shared_uri_id ?: $item['uri-id'], $sharedSplitAttachments, $body, $s, true, $quote_shared_links);
+ $s = self::addNonVisualAttachments($sharedSplitAttachments['additional'], $item, $s, true);
$body = BBCode::removeSharedData($body);
}
@@ -3251,10 +3350,10 @@ class Item
$s = substr($s, 0, $pos);
}
- $s = self::addGallery($s, $attachments, $item['uri-id']);
- $s = self::addVisualAttachments($attachments, $item, $s, false);
- $s = self::addLinkAttachment($item['uri-id'], $attachments, $body, $s, false, $shared_links);
- $s = self::addNonVisualAttachments($attachments, $item, $s, false);
+ $s = self::addGallery($s, $itemSplitAttachments['visual']);
+ $s = self::addVisualAttachments($itemSplitAttachments['visual'], $item, $s, false);
+ $s = self::addLinkAttachment($item['uri-id'], $itemSplitAttachments, $body, $s, false, $shared_links);
+ $s = self::addNonVisualAttachments($itemSplitAttachments['additional'], $item, $s, false);
$s = self::addQuestions($item, $s);
// Map.
@@ -3282,45 +3381,35 @@ class Item
return $hook_data['html'];
}
- /**
- * @param array $images
- * @return string
- * @throws \Friendica\Network\HTTPException\ServiceUnavailableException
- */
- private static function makeImageGrid(array $images): string
- {
- // Image for first column (fc) and second column (sc)
- $images_fc = [];
- $images_sc = [];
-
- for ($i = 0; $i < count($images); $i++) {
- ($i % 2 == 0) ? ($images_fc[] = $images[$i]) : ($images_sc[] = $images[$i]);
- }
-
- return Renderer::replaceMacros(Renderer::getMarkupTemplate('content/image_grid.tpl'), [
- 'columns' => [
- 'fc' => $images_fc,
- 'sc' => $images_sc,
- ],
- ]);
- }
-
/**
* Modify links to pictures to links for the "Fancybox" gallery
*
- * @param string $s
- * @param array $attachments
- * @param integer $uri_id
+ * @param string $s
+ * @param PostMedias $PostMedias
* @return string
*/
- private static function addGallery(string $s, array $attachments, int $uri_id): string
+ private static function addGallery(string $s, PostMedias $PostMedias): string
{
- foreach ($attachments['visual'] as $attachment) {
- if (empty($attachment['preview']) || ($attachment['type'] != Post\Media::IMAGE)) {
+ foreach ($PostMedias as $PostMedia) {
+ if (!$PostMedia->preview || ($PostMedia->type !== Post\Media::IMAGE)) {
continue;
}
- $s = str_replace('hasDimensions()) {
+ $pattern = '#(.*?)">#';
+
+ $s = preg_replace_callback($pattern, function () use ($PostMedia) {
+ return Renderer::replaceMacros(Renderer::getMarkupTemplate('content/image/single_with_height_allocation.tpl'), [
+ '$image' => $PostMedia,
+ '$allocated_height' => $PostMedia->getAllocatedHeight(),
+ '$allocated_max_width' => ($PostMedia->previewWidth ?? $PostMedia->width) . 'px',
+ ]);
+ }, $s);
+ } else {
+ $s = str_replace('startRecording('rendering');
- foreach ($attachments['visual'] as $attachment) {
- if (!empty($attachment['preview'])) {
- if (Network::isLocalLink($attachment['preview'])) {
+ foreach ($PostMedias as $PostMedia) {
+ if ($PostMedia->preview) {
+ if (DI::baseUrl()->isLocalUri($PostMedia->preview)) {
continue;
}
- $proxy = Post\Media::getPreviewUrlForId($attachment['id'], Proxy::SIZE_LARGE);
- $search = ['[img=' . $attachment['preview'] . ']', ']' . $attachment['preview'] . '[/img]'];
+ $proxy = DI::baseUrl() . $PostMedia->getPreviewPath(Proxy::SIZE_LARGE);
+ $search = ['[img=' . $PostMedia->preview . ']', ']' . $PostMedia->preview . '[/img]'];
$replace = ['[img=' . $proxy . ']', ']' . $proxy . '[/img]'];
$body = str_replace($search, $replace, $body);
- } elseif ($attachment['filetype'] == 'image') {
- if (Network::isLocalLink($attachment['url'])) {
+ } elseif ($PostMedia->mimetype->type == 'image') {
+ if (DI::baseUrl()->isLocalUri($PostMedia->url)) {
continue;
}
- $proxy = Post\Media::getUrlForId($attachment['id']);
- $search = ['[img=' . $attachment['url'] . ']', ']' . $attachment['url'] . '[/img]'];
+ $proxy = DI::baseUrl() . $PostMedia->getPreviewPath(Proxy::SIZE_LARGE);
+ $search = ['[img=' . $PostMedia->url . ']', ']' . $PostMedia->url . '[/img]'];
$replace = ['[img=' . $proxy . ']', ']' . $proxy . '[/img]'];
$body = str_replace($search, $replace, $body);
@@ -3414,29 +3503,31 @@ class Item
/**
* Add visual attachments to the content
*
- * @param array $attachments
- * @param array $item
- * @param string $content
+ * @param PostMedias $PostMedias
+ * @param array $item
+ * @param string $content
+ * @param bool $shared
* @return string modified content
+ * @throws ServiceUnavailableException
*/
- private static function addVisualAttachments(array $attachments, array $item, string $content, bool $shared): string
+ private static function addVisualAttachments(PostMedias $PostMedias, array $item, string $content, bool $shared): string
{
DI::profiler()->startRecording('rendering');
$leading = '';
$trailing = '';
- $images = [];
+ $images = new PostMedias();
// @todo In the future we should make a single for the template engine with all media in it. This allows more flexibilty.
- foreach ($attachments['visual'] as $attachment) {
- if (self::containsLink($item['body'], $attachment['preview'] ?? $attachment['url'], $attachment['type'])) {
+ foreach ($PostMedias as $PostMedia) {
+ if (self::containsLink($item['body'], $PostMedia->preview ?? $PostMedia->url, $PostMedia->type)) {
continue;
}
- if ($attachment['filetype'] == 'image') {
- $preview_url = Post\Media::getPreviewUrlForId($attachment['id'], ($attachment['width'] > $attachment['height']) ? Proxy::SIZE_MEDIUM : Proxy::SIZE_LARGE);
- } elseif (!empty($attachment['preview'])) {
- $preview_url = Post\Media::getPreviewUrlForId($attachment['id'], Proxy::SIZE_LARGE);
+ if ($PostMedia->mimetype->type == 'image' || $PostMedia->preview) {
+ $preview_size = Proxy::SIZE_MEDIUM;
+ $preview_url = DI::baseUrl() . $PostMedia->getPreviewPath($preview_size);
} else {
+ $preview_size = 0;
$preview_url = '';
}
@@ -3444,15 +3535,15 @@ class Item
continue;
}
- if (($attachment['filetype'] == 'video')) {
+ if ($PostMedia->mimetype->type == 'video') {
/// @todo Move the template to /content as well
$media = Renderer::replaceMacros(Renderer::getMarkupTemplate('video_top.tpl'), [
'$video' => [
- 'id' => $attachment['id'],
- 'src' => $attachment['url'],
- 'name' => $attachment['name'] ?: $attachment['url'],
+ 'id' => $PostMedia->id,
+ 'src' => (string)$PostMedia->url,
+ 'name' => $PostMedia->name ?: $PostMedia->url,
'preview' => $preview_url,
- 'mime' => $attachment['mimetype'],
+ 'mime' => (string)$PostMedia->mimetype,
],
]);
if (($item['post-type'] ?? null) == Item::PT_VIDEO) {
@@ -3460,13 +3551,13 @@ class Item
} else {
$trailing .= $media;
}
- } elseif ($attachment['filetype'] == 'audio') {
+ } elseif ($PostMedia->mimetype->type == 'audio') {
$media = Renderer::replaceMacros(Renderer::getMarkupTemplate('content/audio.tpl'), [
'$audio' => [
- 'id' => $attachment['id'],
- 'src' => $attachment['url'],
- 'name' => $attachment['name'] ?: $attachment['url'],
- 'mime' => $attachment['mimetype'],
+ 'id' => $PostMedia->id,
+ 'src' => (string)$PostMedia->url,
+ 'name' => $PostMedia->name ?: $PostMedia->url,
+ 'mime' => (string)$PostMedia->mimetype,
],
]);
if (($item['post-type'] ?? null) == Item::PT_AUDIO) {
@@ -3474,23 +3565,17 @@ class Item
} else {
$trailing .= $media;
}
- } elseif ($attachment['filetype'] == 'image') {
- $src_url = Post\Media::getUrlForId($attachment['id']);
+ } elseif ($PostMedia->mimetype->type == 'image') {
+ $src_url = DI::baseUrl() . $PostMedia->getPhotoPath();
if (self::containsLink($item['body'], $src_url)) {
continue;
}
- $images[] = ['src' => $src_url, 'preview' => $preview_url, 'attachment' => $attachment, 'uri_id' => $item['uri-id']];
+
+ $images[] = $PostMedia->withUrl(new Uri($src_url))->withPreview(new Uri($preview_url), $preview_size);
}
}
- $media = '';
- if (count($images) > 1) {
- $media = self::makeImageGrid($images);
- } elseif (count($images) == 1) {
- $media = Renderer::replaceMacros(Renderer::getMarkupTemplate('content/image.tpl'), [
- '$image' => $images[0],
- ]);
- }
+ $media = Image::getBodyAttachHtml($images);
// On Diaspora posts the attached pictures are leading
if ($item['network'] == Protocol::DIASPORA) {
@@ -3519,59 +3604,62 @@ class Item
/**
* Add link attachment to the content
*
- * @param array $attachments
- * @param string $body
- * @param string $content
- * @param bool $shared
- * @param array $ignore_links A list of URLs to ignore
+ * @param int $uriid
+ * @param PostMedias[] $attachments
+ * @param string $body
+ * @param string $content
+ * @param bool $shared
+ * @param array $ignore_links A list of URLs to ignore
* @return string modified content
+ * @throws InternalServerErrorException
+ * @throws ServiceUnavailableException
*/
private static function addLinkAttachment(int $uriid, array $attachments, string $body, string $content, bool $shared, array $ignore_links): string
{
DI::profiler()->startRecording('rendering');
// Don't show a preview when there is a visual attachment (audio or video)
- $types = array_column($attachments['visual'], 'type');
- $preview = !in_array(Post\Media::IMAGE, $types) && !in_array(Post\Media::VIDEO, $types);
-
- if (!empty($attachments['link'])) {
- foreach ($attachments['link'] as $link) {
- $found = false;
- foreach ($ignore_links as $ignore_link) {
- if (Strings::compareLink($link['url'], $ignore_link)) {
- $found = true;
- }
- }
- // @todo Judge between the links to use the one with most information
- if (!$found && (empty($attachment) || !empty($link['author-name']) ||
- (empty($attachment['name']) && !empty($link['name'])) ||
- (empty($attachment['description']) && !empty($link['description'])) ||
- (empty($attachment['preview']) && !empty($link['preview'])))) {
- $attachment = $link;
+ $types = $attachments['visual']->column('type');
+ $preview = !in_array(PostMedia::TYPE_IMAGE, $types) && !in_array(PostMedia::TYPE_VIDEO, $types);
+
+ /** @var ?PostMedia $attachment */
+ $attachment = null;
+ foreach ($attachments['link'] as $PostMedia) {
+ $found = false;
+ foreach ($ignore_links as $ignore_link) {
+ if (Strings::compareLink($PostMedia->url, $ignore_link)) {
+ $found = true;
}
}
+ // @todo Judge between the links to use the one with most information
+ if (!$found && (empty($attachment) || $PostMedia->authorName ||
+ (!$attachment->name && $PostMedia->name) ||
+ (!$attachment->description && $PostMedia->description) ||
+ (!$attachment->preview && $PostMedia->preview))) {
+ $attachment = $PostMedia;
+ }
}
if (!empty($attachment)) {
$data = [
'after' => '',
- 'author_name' => $attachment['author-name'] ?? '',
- 'author_url' => $attachment['author-url'] ?? '',
- 'description' => $attachment['description'] ?? '',
+ 'author_name' => $attachment->authorName ?? '',
+ 'author_url' => (string)($attachment->authorUrl ?? ''),
+ 'description' => $attachment->description ?? '',
'image' => '',
'preview' => '',
- 'provider_name' => $attachment['publisher-name'] ?? '',
- 'provider_url' => $attachment['publisher-url'] ?? '',
+ 'provider_name' => $attachment->publisherName ?? '',
+ 'provider_url' => (string)($attachment->publisherUrl ?? ''),
'text' => '',
- 'title' => $attachment['name'] ?? '',
+ 'title' => $attachment->name ?? '',
'type' => 'link',
- 'url' => $attachment['url']
+ 'url' => (string)$attachment->url,
];
- if ($preview && !empty($attachment['preview'])) {
- if ($attachment['preview-width'] >= 500) {
- $data['image'] = Post\Media::getPreviewUrlForId($attachment['id'], Proxy::SIZE_MEDIUM);
+ if ($preview && $attachment->preview) {
+ if ($attachment->previewWidth >= 500) {
+ $data['image'] = DI::baseUrl() . $attachment->getPreviewPath(Proxy::SIZE_MEDIUM);
} else {
- $data['preview'] = Post\Media::getPreviewUrlForId($attachment['id'], Proxy::SIZE_MEDIUM);
+ $data['preview'] = DI::baseUrl() . $attachment->getPreviewPath(Proxy::SIZE_MEDIUM);
}
}
@@ -3639,19 +3727,21 @@ class Item
}
/**
- * Add non visual attachments to the content
+ * Add non-visual attachments to the content
*
- * @param array $attachments
- * @param array $item
- * @param string $content
+ * @param PostMedias $PostMedias
+ * @param array $item
+ * @param string $content
* @return string modified content
+ * @throws InternalServerErrorException
+ * @throws \ImagickException
*/
- private static function addNonVisualAttachments(array $attachments, array $item, string $content): string
+ private static function addNonVisualAttachments(PostMedias $PostMedias, array $item, string $content): string
{
DI::profiler()->startRecording('rendering');
$trailing = '';
- foreach ($attachments['additional'] as $attachment) {
- if (strpos($item['body'], $attachment['url'])) {
+ foreach ($PostMedias as $PostMedia) {
+ if (strpos($item['body'], $PostMedia->url)) {
continue;
}
@@ -3662,16 +3752,16 @@ class Item
'url' => $item['author-link'],
'alias' => $item['author-alias']
];
- $the_url = Contact::magicLinkByContact($author, $attachment['url']);
+ $the_url = Contact::magicLinkByContact($author, $PostMedia->url);
- $title = Strings::escapeHtml(trim(($attachment['description'] ?? '') ?: $attachment['url']));
+ $title = Strings::escapeHtml(trim($PostMedia->description ?? '' ?: $PostMedia->url));
- if (!empty($attachment['size'])) {
- $title .= ' ' . $attachment['size'] . ' ' . DI::l10n()->t('bytes');
+ if ($PostMedia->size) {
+ $title .= ' ' . $PostMedia->size . ' ' . DI::l10n()->t('bytes');
}
/// @todo Use a template
- $icon = '';
+ $icon = '';
$trailing .= '' . $icon . '';
}
@@ -3855,11 +3945,12 @@ class Item
* Fetches item for given URI or plink
*
* @param string $uri
- * @param integer $uid
+ * @param int $uid
+ * @param int $completion
*
* @return integer item id
*/
- public static function fetchByLink(string $uri, int $uid = 0): int
+ public static function fetchByLink(string $uri, int $uid = 0, int $completion = ActivityPub\Receiver::COMPLETION_MANUAL): int
{
Logger::info('Trying to fetch link', ['uid' => $uid, 'uri' => $uri]);
$item_id = self::searchByLink($uri, $uid);
@@ -3880,7 +3971,7 @@ class Item
return is_numeric($hookData['item_id']) ? $hookData['item_id'] : 0;
}
- $fetched_uri = ActivityPub\Processor::fetchMissingActivity($uri, [], '', ActivityPub\Receiver::COMPLETION_MANUAL, $uid);
+ $fetched_uri = ActivityPub\Processor::fetchMissingActivity($uri, [], '', $completion, $uid);
if ($fetched_uri) {
$item_id = self::searchByLink($fetched_uri, $uid);
@@ -3940,7 +4031,7 @@ class Item
}
$url = $shared['message_id'] ?: $shared['link'];
- $id = self::fetchByLink($url);
+ $id = self::fetchByLink($url, 0, ActivityPub\Receiver::COMPLETION_ASYNC);
if (!$id) {
Logger::notice('Post could not be fetched.', ['url' => $url, 'uid' => $uid]);
return 0;