X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=src%2FModel%2FItem.php;h=30c29e1518b18cea736de93613f6a9c9657abd3a;hb=67f4fdab322f6e717ad99ed324878552579fd24f;hp=9fafe26aa670585e6f35f037a84c8a1b1156d4c8;hpb=b07dfbb03f06f72d8776da317361fa5bcad098e2;p=friendica.git diff --git a/src/Model/Item.php b/src/Model/Item.php index 9fafe26aa6..30c29e1518 100644 --- a/src/Model/Item.php +++ b/src/Model/Item.php @@ -7,24 +7,33 @@ namespace Friendica\Model; use Friendica\BaseObject; -use Friendica\Content\Text; +use Friendica\Content\Text\BBCode; +use Friendica\Content\Text\HTML; use Friendica\Core\Addon; use Friendica\Core\Config; +use Friendica\Core\Lock; +use Friendica\Core\Logger; use Friendica\Core\L10n; use Friendica\Core\PConfig; +use Friendica\Core\Protocol; +use Friendica\Core\Renderer; use Friendica\Core\System; use Friendica\Core\Worker; -use Friendica\Database\DBM; +use Friendica\Database\DBA; use Friendica\Model\Contact; -use Friendica\Model\Conversation; -use Friendica\Model\Group; +use Friendica\Model\Event; +use Friendica\Model\FileTag; +use Friendica\Model\PermissionSet; use Friendica\Model\Term; +use Friendica\Model\ItemURI; use Friendica\Object\Image; use Friendica\Protocol\Diaspora; use Friendica\Protocol\OStatus; use Friendica\Util\DateTimeFormat; +use Friendica\Util\Map; use Friendica\Util\XML; -use dba; +use Friendica\Util\Security; +use Friendica\Util\Strings; use Text_LanguageDetect; require_once 'boot.php'; @@ -33,14 +42,25 @@ require_once 'include/text.php'; class Item extends BaseObject { + // Posting types, inspired by https://www.w3.org/TR/activitystreams-vocabulary/#object-types + const PT_ARTICLE = 0; + const PT_NOTE = 1; + const PT_PAGE = 2; + const PT_IMAGE = 16; + const PT_AUDIO = 17; + const PT_VIDEO = 18; + const PT_DOCUMENT = 19; + const PT_EVENT = 32; + const PT_PERSONAL_NOTE = 128; + // Field list that is used to display the items const DISPLAY_FIELDLIST = ['uid', 'id', 'parent', 'uri', 'thr-parent', 'parent-uri', 'guid', 'network', 'commented', 'created', 'edited', 'received', 'verb', 'object-type', 'postopts', 'plink', - 'wall', 'private', 'starred', 'origin', 'title', 'body', 'file', 'attach', + 'wall', 'private', 'starred', 'origin', 'title', 'body', 'file', 'attach', 'language', 'content-warning', 'location', 'coord', 'app', 'rendered-hash', 'rendered-html', 'object', 'allow_cid', 'allow_gid', 'deny_cid', 'deny_gid', 'item_id', - 'author-id', 'author-link', 'author-name', 'author-avatar', - 'owner-id', 'owner-link', 'owner-name', 'owner-avatar', + 'author-id', 'author-link', 'author-name', 'author-avatar', 'author-network', + 'owner-id', 'owner-link', 'owner-name', 'owner-avatar', 'owner-network', 'contact-id', 'contact-link', 'contact-name', 'contact-avatar', 'writable', 'self', 'cid', 'alias', 'event-id', 'event-created', 'event-edited', 'event-start', 'event-finish', @@ -51,22 +71,28 @@ class Item extends BaseObject const DELIVER_FIELDLIST = ['uid', 'id', 'parent', 'uri', 'thr-parent', 'parent-uri', 'guid', 'created', 'edited', 'verb', 'object-type', 'object', 'target', 'private', 'title', 'body', 'location', 'coord', 'app', - 'attach', 'tag', 'bookmark', 'deleted', 'extid', + 'attach', 'tag', 'deleted', 'extid', 'post-type', 'allow_cid', 'allow_gid', 'deny_cid', 'deny_gid', 'author-id', 'author-link', 'owner-link', 'contact-uid', - 'signed_text', 'signature', 'signer']; + 'signed_text', 'signature', 'signer', 'network']; // Field list for "item-content" table that is mixed with the item table - const CONTENT_FIELDLIST = ['title', 'content-warning', 'body', 'location', + const MIXED_CONTENT_FIELDLIST = ['title', 'content-warning', 'body', 'location', 'coord', 'app', 'rendered-hash', 'rendered-html', 'verb', - 'object-type', 'object', 'target-type', 'target']; + 'object-type', 'object', 'target-type', 'target', 'plink']; + + // Field list for "item-content" table that is not present in the "item" table + const CONTENT_FIELDLIST = ['language']; + + // Field list for additional delivery data + const DELIVERY_DATA_FIELDLIST = ['postopts', 'inform']; // All fields in the item table const ITEM_FIELDLIST = ['id', 'uid', 'parent', 'uri', 'parent-uri', 'thr-parent', 'guid', - 'contact-id', 'type', 'wall', 'gravity', 'extid', 'icid', + 'contact-id', 'type', 'wall', 'gravity', 'extid', 'icid', 'iaid', 'psid', 'created', 'edited', 'commented', 'received', 'changed', 'verb', 'postopts', 'plink', 'resource-id', 'event-id', 'tag', 'attach', 'inform', - 'file', 'allow_cid', 'allow_gid', 'deny_cid', 'deny_gid', + 'file', 'allow_cid', 'allow_gid', 'deny_cid', 'deny_gid', 'post-type', 'private', 'pubmail', 'moderated', 'visible', 'starred', 'bookmark', 'unseen', 'deleted', 'origin', 'forum_mode', 'mention', 'global', 'network', 'title', 'content-warning', 'body', 'location', 'coord', 'app', @@ -74,6 +100,53 @@ class Item extends BaseObject 'author-id', 'author-link', 'author-name', 'author-avatar', 'owner-id', 'owner-link', 'owner-name', 'owner-avatar']; + // Never reorder or remove entries from this list. Just add new ones at the end, if needed. + // The item-activity table only stores the index and needs this array to know the matching activity. + const ACTIVITIES = [ACTIVITY_LIKE, ACTIVITY_DISLIKE, ACTIVITY_ATTEND, ACTIVITY_ATTENDNO, ACTIVITY_ATTENDMAYBE]; + + private static $legacy_mode = null; + + public static function isLegacyMode() + { + if (is_null(self::$legacy_mode)) { + self::$legacy_mode = (Config::get("system", "post_update_version") < 1279); + } + + return self::$legacy_mode; + } + + /** + * @brief returns an activity index from an activity string + * + * @param string $activity activity string + * @return integer Activity index + */ + public static function activityToIndex($activity) + { + $index = array_search($activity, self::ACTIVITIES); + + if (is_bool($index)) { + $index = -1; + } + + return $index; + } + + /** + * @brief returns an activity string from an activity index + * + * @param integer $index activity index + * @return string Activity string + */ + private static function indexToActivity($index) + { + if (is_null($index) || !array_key_exists($index, self::ACTIVITIES)) { + return ''; + } + + return self::ACTIVITIES[$index]; + } + /** * @brief Fetch a single item row * @@ -82,16 +155,14 @@ class Item extends BaseObject */ public static function fetch($stmt) { - $row = dba::fetch($stmt); + $row = DBA::fetch($stmt); - // Fetch data from the item-content table whenever there is content there - foreach (self::CONTENT_FIELDLIST as $field) { - if (empty($row[$field]) && !empty($row['item-' . $field])) { - $row[$field] = $row['item-' . $field]; - } - unset($row['item-' . $field]); + if (is_bool($row)) { + return $row; } + // ---------------------- Transform item structure data ---------------------- + // We prefer the data from the user's contact over the public one if (!empty($row['author-link']) && !empty($row['contact-link']) && ($row['author-link'] == $row['contact-link'])) { @@ -114,11 +185,79 @@ class Item extends BaseObject } // We can always comment on posts from these networks - if (isset($row['writable']) && !empty($row['network']) && - in_array($row['network'], [NETWORK_DFRN, NETWORK_DIASPORA, NETWORK_OSTATUS])) { + if (array_key_exists('writable', $row) && + in_array($row['internal-network'], [Protocol::ACTIVITYPUB, Protocol::DFRN, Protocol::DIASPORA, Protocol::OSTATUS])) { $row['writable'] = true; } + // ---------------------- Transform item content data ---------------------- + + // Fetch data from the item-content table whenever there is content there + if (self::isLegacyMode()) { + $legacy_fields = array_merge(self::DELIVERY_DATA_FIELDLIST, self::MIXED_CONTENT_FIELDLIST); + foreach ($legacy_fields as $field) { + if (empty($row[$field]) && !empty($row['internal-item-' . $field])) { + $row[$field] = $row['internal-item-' . $field]; + } + unset($row['internal-item-' . $field]); + } + } + + if (!empty($row['internal-iaid']) && array_key_exists('verb', $row)) { + $row['verb'] = self::indexToActivity($row['internal-activity']); + if (array_key_exists('title', $row)) { + $row['title'] = ''; + } + if (array_key_exists('body', $row)) { + $row['body'] = $row['verb']; + } + if (array_key_exists('object', $row)) { + $row['object'] = ''; + } + if (array_key_exists('object-type', $row)) { + $row['object-type'] = ACTIVITY_OBJ_NOTE; + } + } elseif (array_key_exists('verb', $row) && in_array($row['verb'], ['', ACTIVITY_POST, ACTIVITY_SHARE])) { + // Posts don't have an object or target - but having tags or files. + // We safe some performance by building tag and file strings only here. + // We remove object and target since they aren't used for this type. + if (array_key_exists('object', $row)) { + $row['object'] = ''; + } + if (array_key_exists('target', $row)) { + $row['target'] = ''; + } + } + + if (!array_key_exists('verb', $row) || in_array($row['verb'], ['', ACTIVITY_POST, ACTIVITY_SHARE])) { + // Build the tag string out of the term entries + if (array_key_exists('tag', $row) && empty($row['tag'])) { + $row['tag'] = Term::tagTextFromItemId($row['internal-iid']); + } + + // Build the file string out of the term entries + if (array_key_exists('file', $row) && empty($row['file'])) { + $row['file'] = Term::fileTextFromItemId($row['internal-iid']); + } + } + + if (array_key_exists('signed_text', $row) && array_key_exists('interaction', $row) && !is_null($row['interaction'])) { + $row['signed_text'] = $row['interaction']; + } + + if (array_key_exists('ignored', $row) && array_key_exists('internal-user-ignored', $row) && !is_null($row['internal-user-ignored'])) { + $row['ignored'] = $row['internal-user-ignored']; + } + + // Remove internal fields + unset($row['internal-activity']); + unset($row['internal-network']); + unset($row['internal-iid']); + unset($row['internal-iaid']); + unset($row['internal-icid']); + unset($row['internal-user-ignored']); + unset($row['interaction']); + return $row; } @@ -138,7 +277,7 @@ class Item extends BaseObject $data[] = $row; } if ($do_close) { - dba::close($stmt); + DBA::close($stmt); } return $data; } @@ -156,10 +295,10 @@ class Item extends BaseObject if (is_bool($stmt)) { $retval = $stmt; } else { - $retval = (dba::num_rows($stmt) > 0); + $retval = (DBA::numRows($stmt) > 0); } - dba::close($stmt); + DBA::close($stmt); return $retval; } @@ -173,7 +312,7 @@ class Item extends BaseObject * @param array $condition * @param array $params * @return bool|array - * @see dba::select + * @see DBA::select */ public static function selectFirstForUser($uid, array $selected = [], array $condition = [], $params = []) { @@ -215,7 +354,7 @@ class Item extends BaseObject * @param array $condition * @param array $params * @return bool|array - * @see dba::select + * @see DBA::select */ public static function selectFirst(array $fields = [], array $condition = [], $params = []) { @@ -227,7 +366,7 @@ class Item extends BaseObject return $result; } else { $row = self::fetch($result); - dba::close($result); + DBA::close($result); return $row; } } @@ -251,11 +390,11 @@ class Item extends BaseObject $usermode = true; } - $fields = self::fieldlist($selected); + $fields = self::fieldlist($usermode); $select_fields = self::constructSelectFields($fields, $selected); - $condition_string = dba::buildCondition($condition); + $condition_string = DBA::buildCondition($condition); $condition_string = self::addTablesToFields($condition_string, $fields); @@ -263,13 +402,13 @@ class Item extends BaseObject $condition_string = $condition_string . ' AND ' . self::condition(false); } - $param_string = self::addTablesToFields(dba::buildParameter($params), $fields); + $param_string = self::addTablesToFields(DBA::buildParameter($params), $fields); - $table = "`item` " . self::constructJoins($uid, $select_fields . $condition_string . $param_string, false); + $table = "`item` " . self::constructJoins($uid, $select_fields . $condition_string . $param_string, false, $usermode); $sql = "SELECT " . $select_fields . " FROM " . $table . $condition_string . $param_string; - return dba::p($sql, $condition); + return DBA::p($sql, $condition); } /** @@ -302,7 +441,7 @@ class Item extends BaseObject * @param array $condition * @param array $params * @return bool|array - * @see dba::select + * @see DBA::select */ public static function selectFirstThreadForUser($uid, array $selected = [], array $condition = [], $params = []) { @@ -323,7 +462,7 @@ class Item extends BaseObject * @param array $condition * @param array $params * @return bool|array - * @see dba::select + * @see DBA::select */ public static function selectFirstThread(array $fields = [], array $condition = [], $params = []) { @@ -334,7 +473,7 @@ class Item extends BaseObject return $result; } else { $row = self::fetch($result); - dba::close($result); + DBA::close($result); return $row; } } @@ -358,16 +497,18 @@ class Item extends BaseObject $usermode = true; } - $fields = self::fieldlist($selected); + $fields = self::fieldlist($usermode); + + $fields['thread'] = ['mention', 'ignored', 'iid']; $threadfields = ['thread' => ['iid', 'uid', 'contact-id', 'owner-id', 'author-id', 'created', 'edited', 'commented', 'received', 'changed', 'wall', 'private', - 'pubmail', 'moderated', 'visible', 'starred', 'ignored', 'bookmark', + 'pubmail', 'moderated', 'visible', 'starred', 'ignored', 'post-type', 'unseen', 'deleted', 'origin', 'forum_mode', 'mention', 'network']]; $select_fields = self::constructSelectFields($fields, $selected); - $condition_string = dba::buildCondition($condition); + $condition_string = DBA::buildCondition($condition); $condition_string = self::addTablesToFields($condition_string, $threadfields); $condition_string = self::addTablesToFields($condition_string, $fields); @@ -376,15 +517,15 @@ class Item extends BaseObject $condition_string = $condition_string . ' AND ' . self::condition(true); } - $param_string = dba::buildParameter($params); + $param_string = DBA::buildParameter($params); $param_string = self::addTablesToFields($param_string, $threadfields); $param_string = self::addTablesToFields($param_string, $fields); - $table = "`thread` " . self::constructJoins($uid, $select_fields . $condition_string . $param_string, true); + $table = "`thread` " . self::constructJoins($uid, $select_fields . $condition_string . $param_string, true, $usermode); $sql = "SELECT " . $select_fields . " FROM " . $table . $condition_string . $param_string; - return dba::p($sql, $condition); + return DBA::p($sql, $condition); } /** @@ -392,26 +533,37 @@ class Item extends BaseObject * * @return array field list */ - private static function fieldlist($selected) + private static function fieldlist($usermode) { $fields = []; $fields['item'] = ['id', 'uid', 'parent', 'uri', 'parent-uri', 'thr-parent', 'guid', 'contact-id', 'owner-id', 'author-id', 'type', 'wall', 'gravity', 'extid', - 'created', 'edited', 'commented', 'received', 'changed', 'postopts', - 'plink', 'resource-id', 'event-id', 'tag', 'attach', 'inform', - 'file', 'allow_cid', 'allow_gid', 'deny_cid', 'deny_gid', + 'created', 'edited', 'commented', 'received', 'changed', 'psid', + 'resource-id', 'event-id', 'tag', 'attach', 'post-type', 'file', 'private', 'pubmail', 'moderated', 'visible', 'starred', 'bookmark', 'unseen', 'deleted', 'origin', 'forum_mode', 'mention', 'global', - 'id' => 'item_id', 'network', 'icid']; + 'id' => 'item_id', 'network', 'icid', 'iaid', 'id' => 'internal-iid', + 'network' => 'internal-network', 'icid' => 'internal-icid', + 'iaid' => 'internal-iaid']; + + if ($usermode) { + $fields['user-item'] = ['ignored' => 'internal-user-ignored']; + } + + $fields['item-activity'] = ['activity', 'activity' => 'internal-activity']; - $fields['item-content'] = self::CONTENT_FIELDLIST; + $fields['item-content'] = array_merge(self::CONTENT_FIELDLIST, self::MIXED_CONTENT_FIELDLIST); + + $fields['item-delivery-data'] = self::DELIVERY_DATA_FIELDLIST; + + $fields['permissionset'] = ['allow_cid', 'allow_gid', 'deny_cid', 'deny_gid']; $fields['author'] = ['url' => 'author-link', 'name' => 'author-name', - 'thumb' => 'author-avatar', 'nick' => 'author-nick']; + 'thumb' => 'author-avatar', 'nick' => 'author-nick', 'network' => 'author-network']; $fields['owner'] = ['url' => 'owner-link', 'name' => 'owner-name', - 'thumb' => 'owner-avatar', 'nick' => 'owner-nick']; + 'thumb' => 'owner-avatar', 'nick' => 'owner-nick', 'network' => 'owner-network']; $fields['contact'] = ['url' => 'contact-link', 'name' => 'contact-name', 'thumb' => 'contact-avatar', 'writable', 'self', 'id' => 'cid', 'alias', 'uid' => 'contact-uid', @@ -430,6 +582,8 @@ class Item extends BaseObject $fields['sign'] = ['signed_text', 'signature', 'signer']; + $fields['diaspora-interaction'] = ['interaction']; + return $fields; } @@ -447,7 +601,13 @@ class Item extends BaseObject } else { $master_table = "`item`"; } - return "$master_table.`visible` AND NOT $master_table.`deleted` AND NOT $master_table.`moderated` AND (`user-item`.`hidden` IS NULL OR NOT `user-item`.`hidden`) "; + return sprintf("$master_table.`visible` AND NOT $master_table.`deleted` AND NOT $master_table.`moderated` + AND (`user-item`.`hidden` IS NULL OR NOT `user-item`.`hidden`) + AND (`user-author`.`blocked` IS NULL OR NOT `user-author`.`blocked`) + AND (`user-author`.`ignored` IS NULL OR NOT `user-author`.`ignored` OR `item`.`gravity` != %d) + AND (`user-owner`.`blocked` IS NULL OR NOT `user-owner`.`blocked`) + AND (`user-owner`.`ignored` IS NULL OR NOT `user-owner`.`ignored` OR `item`.`gravity` != %d) ", + GRAVITY_PARENT, GRAVITY_PARENT); } /** @@ -459,7 +619,7 @@ class Item extends BaseObject * * @return string The SQL joins for the "select" functions */ - private static function constructJoins($uid, $sql_commands, $thread_mode) + private static function constructJoins($uid, $sql_commands, $thread_mode, $user_mode) { if ($thread_mode) { $master_table = "`thread`"; @@ -471,14 +631,28 @@ class Item extends BaseObject $joins = ''; } - $joins .= sprintf("STRAIGHT_JOIN `contact` ON `contact`.`id` = $master_table.`contact-id` - AND NOT `contact`.`blocked` - AND ((NOT `contact`.`readonly` AND NOT `contact`.`pending` AND (`contact`.`rel` IN (%s, %s))) - OR `contact`.`self` OR (`item`.`id` != `item`.`parent`) OR `contact`.`uid` = 0) - STRAIGHT_JOIN `contact` AS `author` ON `author`.`id` = $master_table.`author-id` AND NOT `author`.`blocked` - STRAIGHT_JOIN `contact` AS `owner` ON `owner`.`id` = $master_table.`owner-id` AND NOT `owner`.`blocked` - LEFT JOIN `user-item` ON `user-item`.`iid` = $master_table_key AND `user-item`.`uid` = %d", - CONTACT_IS_SHARING, CONTACT_IS_FRIEND, intval($uid)); + if ($user_mode) { + $joins .= sprintf("STRAIGHT_JOIN `contact` ON `contact`.`id` = $master_table.`contact-id` + AND NOT `contact`.`blocked` + AND ((NOT `contact`.`readonly` AND NOT `contact`.`pending` AND (`contact`.`rel` IN (%s, %s))) + OR `contact`.`self` OR `item`.`gravity` != %d OR `contact`.`uid` = 0) + STRAIGHT_JOIN `contact` AS `author` ON `author`.`id` = $master_table.`author-id` AND NOT `author`.`blocked` + STRAIGHT_JOIN `contact` AS `owner` ON `owner`.`id` = $master_table.`owner-id` AND NOT `owner`.`blocked` + LEFT JOIN `user-item` ON `user-item`.`iid` = $master_table_key AND `user-item`.`uid` = %d + LEFT JOIN `user-contact` AS `user-author` ON `user-author`.`cid` = $master_table.`author-id` AND `user-author`.`uid` = %d + LEFT JOIN `user-contact` AS `user-owner` ON `user-owner`.`cid` = $master_table.`owner-id` AND `user-owner`.`uid` = %d", + Contact::SHARING, Contact::FRIEND, GRAVITY_PARENT, intval($uid), intval($uid), intval($uid)); + } else { + if (strpos($sql_commands, "`contact`.") !== false) { + $joins .= "LEFT JOIN `contact` ON `contact`.`id` = $master_table.`contact-id`"; + } + if (strpos($sql_commands, "`author`.") !== false) { + $joins .= " LEFT JOIN `contact` AS `author` ON `author`.`id` = $master_table.`author-id`"; + } + if (strpos($sql_commands, "`owner`.") !== false) { + $joins .= " LEFT JOIN `contact` AS `owner` ON `owner`.`id` = $master_table.`owner-id`"; + } + } if (strpos($sql_commands, "`group_member`.") !== false) { $joins .= " STRAIGHT_JOIN `group_member` ON `group_member`.`contact-id` = $master_table.`contact-id`"; @@ -496,8 +670,24 @@ class Item extends BaseObject $joins .= " LEFT JOIN `sign` ON `sign`.`iid` = `item`.`id`"; } + if (strpos($sql_commands, "`diaspora-interaction`.") !== false) { + $joins .= " LEFT JOIN `diaspora-interaction` ON `diaspora-interaction`.`uri-id` = `item`.`uri-id`"; + } + + if (strpos($sql_commands, "`item-activity`.") !== false) { + $joins .= " LEFT JOIN `item-activity` ON `item-activity`.`uri-id` = `item`.`uri-id`"; + } + if (strpos($sql_commands, "`item-content`.") !== false) { - $joins .= " LEFT JOIN `item-content` ON `item-content`.`id` = `item`.`icid`"; + $joins .= " LEFT JOIN `item-content` ON `item-content`.`uri-id` = `item`.`uri-id`"; + } + + if (strpos($sql_commands, "`item-delivery-data`.") !== false) { + $joins .= " LEFT JOIN `item-delivery-data` ON `item-delivery-data`.`iid` = `item`.`id`"; + } + + if (strpos($sql_commands, "`permissionset`.") !== false) { + $joins .= " LEFT JOIN `permissionset` ON `permissionset`.`id` = `item`.`psid`"; } if ((strpos($sql_commands, "`parent-item`.") !== false) || (strpos($sql_commands, "`parent-author`.") !== false)) { @@ -521,12 +711,32 @@ class Item extends BaseObject */ private static function constructSelectFields($fields, $selected) { + if (!empty($selected)) { + $selected[] = 'internal-iid'; + $selected[] = 'internal-iaid'; + $selected[] = 'internal-icid'; + $selected[] = 'internal-network'; + } + + if (in_array('verb', $selected)) { + $selected[] = 'internal-activity'; + } + + if (in_array('ignored', $selected)) { + $selected[] = 'internal-user-ignored'; + } + + if (in_array('signed_text', $selected)) { + $selected[] = 'interaction'; + } + $selection = []; foreach ($fields as $table => $table_fields) { foreach ($table_fields as $field => $select) { if (empty($selected) || in_array($select, $selected)) { - if (in_array($select, self::CONTENT_FIELDLIST)) { - $selection[] = "`item`.`".$select."` AS `item-" . $select . "`"; + $legacy_fields = array_merge(self::DELIVERY_DATA_FIELDLIST, self::MIXED_CONTENT_FIELDLIST); + if (self::isLegacyMode() && in_array($select, $legacy_fields)) { + $selection[] = "`item`.`".$select."` AS `internal-item-" . $select . "`"; } if (is_int($field)) { $selection[] = "`" . $table . "`.`" . $select . "`"; @@ -585,41 +795,131 @@ class Item extends BaseObject } // To ensure the data integrity we do it in an transaction - dba::transaction(); + DBA::transaction(); // We cannot simply expand the condition to check for origin entries // The condition needn't to be a simple array but could be a complex condition. // And we have to execute this query before the update to ensure to fetch the same data. - $items = dba::select('item', ['id', 'origin', 'uri', 'plink'], $condition); + $items = DBA::select('item', ['id', 'origin', 'uri', 'uri-id', 'iaid', 'icid', 'tag', 'file'], $condition); $content_fields = []; - foreach (self::CONTENT_FIELDLIST as $field) { + foreach (array_merge(self::CONTENT_FIELDLIST, self::MIXED_CONTENT_FIELDLIST) as $field) { if (isset($fields[$field])) { $content_fields[$field] = $fields[$field]; - unset($fields[$field]); + if (in_array($field, self::CONTENT_FIELDLIST) || !self::isLegacyMode()) { + unset($fields[$field]); + } else { + $fields[$field] = null; + } + } + } + + $clear_fields = ['bookmark', 'type', 'author-name', 'author-avatar', 'author-link', 'owner-name', 'owner-avatar', 'owner-link']; + foreach ($clear_fields as $field) { + if (array_key_exists($field, $fields)) { + $fields[$field] = null; } } + if (array_key_exists('tag', $fields)) { + $tags = $fields['tag']; + $fields['tag'] = null; + } else { + $tags = null; + } + + if (array_key_exists('file', $fields)) { + $files = $fields['file']; + $fields['file'] = null; + } else { + $files = ''; + } + + $delivery_data = ['postopts' => defaults($fields, 'postopts', ''), + 'inform' => defaults($fields, 'inform', '')]; + + $fields['postopts'] = null; + $fields['inform'] = null; + if (!empty($fields)) { - $success = dba::update('item', $fields, $condition); + $success = DBA::update('item', $fields, $condition); if (!$success) { - dba::close($items); - dba::rollback(); + DBA::close($items); + DBA::rollback(); return false; } } // When there is no content for the "old" item table, this will count the fetched items - $rows = dba::affected_rows(); + $rows = DBA::affectedRows(); + + while ($item = DBA::fetch($items)) { + if (!empty($item['iaid']) || (!empty($content_fields['verb']) && (self::activityToIndex($content_fields['verb']) >= 0))) { + self::updateActivity($content_fields, ['uri-id' => $item['uri-id']]); + + if (empty($item['iaid'])) { + $item_activity = DBA::selectFirst('item-activity', ['id'], ['uri-id' => $item['uri-id']]); + if (DBA::isResult($item_activity)) { + $item_fields = ['iaid' => $item_activity['id'], 'icid' => null]; + foreach (self::MIXED_CONTENT_FIELDLIST as $field) { + if (self::isLegacyMode()) { + $item_fields[$field] = null; + } else { + unset($item_fields[$field]); + } + } + DBA::update('item', $item_fields, ['id' => $item['id']]); - while ($item = dba::fetch($items)) { - if (!empty($item['plink'])) { - $content_fields['plink'] = $item['plink']; + if (!empty($item['icid']) && !DBA::exists('item', ['icid' => $item['icid']])) { + DBA::delete('item-content', ['id' => $item['icid']]); + } + } + } elseif (!empty($item['icid'])) { + DBA::update('item', ['icid' => null], ['id' => $item['id']]); + + if (!DBA::exists('item', ['icid' => $item['icid']])) { + DBA::delete('item-content', ['id' => $item['icid']]); + } + } + } else { + self::updateContent($content_fields, ['uri-id' => $item['uri-id']]); + + if (empty($item['icid'])) { + $item_content = DBA::selectFirst('item-content', [], ['uri-id' => $item['uri-id']]); + if (DBA::isResult($item_content)) { + $item_fields = ['icid' => $item_content['id']]; + // Clear all fields in the item table that have a content in the item-content table + foreach ($item_content as $field => $content) { + if (in_array($field, self::MIXED_CONTENT_FIELDLIST) && !empty($item_content[$field])) { + if (self::isLegacyMode()) { + $item_fields[$field] = null; + } else { + unset($item_fields[$field]); + } + } + } + DBA::update('item', $item_fields, ['id' => $item['id']]); + } + } + } + + if (!is_null($tags)) { + Term::insertFromTagFieldByItemId($item['id'], $tags); + if (!empty($item['tag'])) { + DBA::update('item', ['tag' => ''], ['id' => $item['id']]); + } + } + + if (!empty($files)) { + Term::insertFromFileFieldByItemId($item['id'], $files); + if (!empty($item['file'])) { + DBA::update('item', ['file' => ''], ['id' => $item['id']]); + } } - self::updateContent($content_fields, ['uri' => $item['uri']]); - Term::insertFromTagFieldByItemId($item['id']); - Term::insertFromFileFieldByItemId($item['id']); + + self::updateDeliveryData($item['id'], $delivery_data); + self::updateThread($item['id']); // We only need to notfiy others when it is an original entry from us. @@ -629,8 +929,8 @@ class Item extends BaseObject } } - dba::close($items); - dba::commit(); + DBA::close($items); + DBA::commit(); return $rows; } @@ -642,11 +942,11 @@ class Item extends BaseObject */ public static function delete($condition, $priority = PRIORITY_HIGH) { - $items = dba::select('item', ['id'], $condition); - while ($item = dba::fetch($items)) { + $items = self::select(['id'], $condition); + while ($item = self::fetch($items)) { self::deleteById($item['id'], $priority); } - dba::close($items); + DBA::close($items); } /** @@ -661,18 +961,18 @@ class Item extends BaseObject return; } - $items = dba::select('item', ['id', 'uid'], $condition); - while ($item = dba::fetch($items)) { + $items = self::select(['id', 'uid'], $condition); + while ($item = self::fetch($items)) { // "Deleting" global items just means hiding them if ($item['uid'] == 0) { - dba::update('user-item', ['hidden' => true], ['iid' => $item['id'], 'uid' => $uid], true); + DBA::update('user-item', ['hidden' => true], ['iid' => $item['id'], 'uid' => $uid], true); } elseif ($item['uid'] == $uid) { self::deleteById($item['id'], PRIORITY_HIGH); } else { - logger('Wrong ownership. Not deleting item ' . $item['id']); + Logger::log('Wrong ownership. Not deleting item ' . $item['id']); } } - dba::close($items); + DBA::close($items); } /** @@ -683,25 +983,26 @@ class Item extends BaseObject * * @return boolean success */ - private static function deleteById($item_id, $priority = PRIORITY_HIGH) + public static function deleteById($item_id, $priority = PRIORITY_HIGH) { // locate item to be deleted $fields = ['id', 'uri', 'uid', 'parent', 'parent-uri', 'origin', 'deleted', 'file', 'resource-id', 'event-id', 'attach', - 'verb', 'object-type', 'object', 'target', 'contact-id']; - $item = dba::selectFirst('item', $fields, ['id' => $item_id]); - if (!DBM::is_result($item)) { - logger('Item with ID ' . $item_id . " hasn't been found.", LOGGER_DEBUG); + 'verb', 'object-type', 'object', 'target', 'contact-id', + 'icid', 'iaid', 'psid']; + $item = self::selectFirst($fields, ['id' => $item_id]); + if (!DBA::isResult($item)) { + Logger::log('Item with ID ' . $item_id . " hasn't been found.", Logger::DEBUG); return false; } if ($item['deleted']) { - logger('Item with ID ' . $item_id . ' has already been deleted.', LOGGER_DEBUG); + Logger::log('Item with ID ' . $item_id . ' has already been deleted.', Logger::DEBUG); return false; } - $parent = dba::selectFirst('item', ['origin'], ['id' => $item['parent']]); - if (!DBM::is_result($parent)) { + $parent = self::selectFirst(['origin'], ['id' => $item['parent']]); + if (!DBA::isResult($parent)) { $parent = ['origin' => false]; } @@ -709,18 +1010,24 @@ class Item extends BaseObject $matches = false; $cnt = preg_match_all('/<(.*?)>/', $item['file'], $matches, PREG_SET_ORDER); - if ($cnt) { - foreach ($matches as $mtch) { - file_tag_unsave_file($item['uid'], $item['id'], $mtch[1],true); + + if ($cnt) + { + foreach ($matches as $mtch) + { + FileTag::unsaveFile($item['uid'], $item['id'], $mtch[1],true); } } $matches = false; $cnt = preg_match_all('/\[(.*?)\]/', $item['file'], $matches, PREG_SET_ORDER); - if ($cnt) { - foreach ($matches as $mtch) { - file_tag_unsave_file($item['uid'], $item['id'], $mtch[1],false); + + if ($cnt) + { + foreach ($matches as $mtch) + { + FileTag::unsaveFile($item['uid'], $item['id'], $mtch[1],false); } } @@ -731,7 +1038,7 @@ class Item extends BaseObject * generate a resource-id and therefore aren't intimately linked to the item. */ if (strlen($item['resource-id'])) { - dba::delete('photo', ['resource-id' => $item['resource-id'], 'uid' => $item['uid']]); + DBA::delete('photo', ['resource-id' => $item['resource-id'], 'uid' => $item['uid']]); } // If item is a link to an event, delete the event. @@ -742,24 +1049,39 @@ class Item extends BaseObject // If item has attachments, drop them foreach (explode(", ", $item['attach']) as $attach) { preg_match("|attach/(\d+)|", $attach, $matches); - dba::delete('attach', ['id' => $matches[1], 'uid' => $item['uid']]); + if (is_array($matches) && count($matches) > 1) { + DBA::delete('attach', ['id' => $matches[1], 'uid' => $item['uid']]); + } } // Delete tags that had been attached to other items self::deleteTagsFromItem($item); // Set the item to "deleted" - dba::update('item', ['deleted' => true, 'edited' => DateTimeFormat::utcNow(), 'changed' => DateTimeFormat::utcNow()], - ['id' => $item['id']]); + $item_fields = ['deleted' => true, 'edited' => DateTimeFormat::utcNow(), 'changed' => DateTimeFormat::utcNow()]; + DBA::update('item', $item_fields, ['id' => $item['id']]); - Term::insertFromTagFieldByItemId($item['id']); - Term::insertFromFileFieldByItemId($item['id']); + Term::insertFromTagFieldByItemId($item['id'], ''); + Term::insertFromFileFieldByItemId($item['id'], ''); self::deleteThread($item['id'], $item['parent-uri']); if (!self::exists(["`uri` = ? AND `uid` != 0 AND NOT `deleted`", $item['uri']])) { self::delete(['uri' => $item['uri'], 'uid' => 0, 'deleted' => false], $priority); } + DBA::delete('item-delivery-data', ['iid' => $item['id']]); + + // We don't delete the item-activity here, since we need some of the data for ActivityPub + + if (!empty($item['icid']) && !self::exists(['icid' => $item['icid'], 'deleted' => false])) { + DBA::delete('item-content', ['id' => $item['icid']], ['cascade' => false]); + } + // When the permission set will be used in photo and events as well, + // this query here needs to be extended. + if (!empty($item['psid']) && !self::exists(['psid' => $item['psid'], 'deleted' => false])) { + DBA::delete('permissionset', ['id' => $item['psid']], ['cascade' => false]); + } + // If it's the parent of a comment thread, kill all the kids if ($item['id'] == $item['parent']) { self::delete(['parent' => $item['parent'], 'deleted' => false], $priority); @@ -776,13 +1098,13 @@ class Item extends BaseObject } elseif ($item['uid'] != 0) { // When we delete just our local user copy of an item, we have to set a marker to hide it - $global_item = dba::selectFirst('item', ['id'], ['uri' => $item['uri'], 'uid' => 0, 'deleted' => false]); - if (DBM::is_result($global_item)) { - dba::update('user-item', ['hidden' => true], ['iid' => $global_item['id'], 'uid' => $item['uid']], true); + $global_item = self::selectFirst(['id'], ['uri' => $item['uri'], 'uid' => 0, 'deleted' => false]); + if (DBA::isResult($global_item)) { + DBA::update('user-item', ['hidden' => true], ['iid' => $global_item['id'], 'uid' => $item['uid']], true); } } - logger('Item with ID ' . $item_id . " has been deleted.", LOGGER_DEBUG); + Logger::log('Item with ID ' . $item_id . " has been deleted.", Logger::DEBUG); return true; } @@ -800,8 +1122,8 @@ class Item extends BaseObject return; } - $i = dba::selectFirst('item', ['id', 'contact-id', 'tag'], ['uri' => $xt->id, 'uid' => $item['uid']]); - if (!DBM::is_result($i)) { + $i = self::selectFirst(['id', 'contact-id', 'tag'], ['uri' => $xt->id, 'uid' => $item['uid']]); + if (!DBA::isResult($i)) { return; } @@ -827,16 +1149,14 @@ class Item extends BaseObject private static function guid($item, $notify) { - $guid = notags(trim($item['guid'])); - - if (!empty($guid)) { - return $guid; + if (!empty($item['guid'])) { + return Strings::escapeTags(trim($item['guid'])); } if ($notify) { // We have to avoid duplicates. So we create the GUID in form of a hash of the plink or uri. // We add the hash of our own host because our host is the original creator of the post. - $prefix_host = get_app()->get_hostname(); + $prefix_host = get_app()->getHostName(); } else { $prefix_host = ''; @@ -874,7 +1194,7 @@ class Item extends BaseObject } elseif (!empty($item['uri'])) { $guid = self::guidFromUri($item['uri'], $prefix_host); } else { - $guid = get_guid(32, hash('crc32', $prefix_host)); + $guid = System::createUUID(hash('crc32', $prefix_host)); } return $guid; @@ -887,7 +1207,7 @@ class Item extends BaseObject if (!empty($contact_id)) { return $contact_id; } - logger('Missing contact-id. Called by: '.System::callstack(), LOGGER_DEBUG); + Logger::log('Missing contact-id. Called by: '.System::callstack(), Logger::DEBUG); /* * First we are looking for a suitable contact that matches with the author of the post * This is done only for comments @@ -903,16 +1223,27 @@ class Item extends BaseObject // Still missing? Then use the "self" contact of the current user if ($contact_id == 0) { - $self = dba::selectFirst('contact', ['id'], ['self' => true, 'uid' => $item['uid']]); - if (DBM::is_result($self)) { + $self = DBA::selectFirst('contact', ['id'], ['self' => true, 'uid' => $item['uid']]); + if (DBA::isResult($self)) { $contact_id = $self["id"]; } } - logger("Contact-id was missing for post ".$item['guid']." from user id ".$item['uid']." - now set to ".$contact_id, LOGGER_DEBUG); + Logger::log("Contact-id was missing for post ".$item['guid']." from user id ".$item['uid']." - now set to ".$contact_id, Logger::DEBUG); return $contact_id; } + // This function will finally cover most of the preparation functionality in mod/item.php + public static function prepare(&$item) + { + $data = BBCode::getAttachmentData($item['body']); + if ((preg_match_all("/\[bookmark\=([^\]]*)\](.*?)\[\/bookmark\]/ism", $item['body'], $match, PREG_SET_ORDER) || isset($data["type"])) + && ($posttype != Item::PT_PERSONAL_NOTE)) { + $posttype = Item::PT_PAGE; + $objecttype = ACTIVITY_OBJ_BOOKMARK; + } + } + public static function insert($item, $force_parent = false, $notify = false, $dontcache = false) { $a = get_app(); @@ -920,10 +1251,9 @@ class Item extends BaseObject // If it is a posting where users should get notifications, then define it as wall posting if ($notify) { $item['wall'] = 1; - $item['type'] = 'wall'; $item['origin'] = 1; - $item['network'] = NETWORK_DFRN; - $item['protocol'] = PROTOCOL_DFRN; + $item['network'] = Protocol::DFRN; + $item['protocol'] = Conversation::PARCEL_DFRN; if (is_int($notify)) { $priority = $notify; @@ -931,11 +1261,14 @@ class Item extends BaseObject $priority = PRIORITY_HIGH; } } else { - $item['network'] = trim(defaults($item, 'network', NETWORK_PHANTOM)); + $item['network'] = trim(defaults($item, 'network', Protocol::PHANTOM)); } $item['guid'] = self::guid($item, $notify); - $item['uri'] = notags(trim(defaults($item, 'uri', self::newURI($item['uid'], $item['guid'])))); + $item['uri'] = Strings::escapeTags(trim(defaults($item, 'uri', self::newURI($item['uid'], $item['guid'])))); + + // Store URI data + $item['uri-id'] = ItemURI::insert(['uri' => $item['uri'], 'guid' => $item['guid']]); // Store conversation data $item = Conversation::insert($item); @@ -946,22 +1279,21 @@ class Item extends BaseObject */ $dsprsig = null; - if (x($item, 'dsprsig')) { + if (isset($item['dsprsig'])) { $encoded_signature = $item['dsprsig']; $dsprsig = json_decode(base64_decode($item['dsprsig'])); unset($item['dsprsig']); } - if (!empty($item['diaspora_signed_text'])) { + $diaspora_signed_text = ''; + if (isset($item['diaspora_signed_text'])) { $diaspora_signed_text = $item['diaspora_signed_text']; unset($item['diaspora_signed_text']); - } else { - $diaspora_signed_text = ''; } // Converting the plink /// @TODO Check if this is really still needed - if ($item['network'] == NETWORK_OSTATUS) { + if ($item['network'] == Protocol::OSTATUS) { if (isset($item['plink'])) { $item['plink'] = OStatus::convertHref($item['plink']); } elseif (isset($item['uri'])) { @@ -973,19 +1305,15 @@ class Item extends BaseObject $item['parent-uri'] = $item['thr-parent']; } - $item['type'] = defaults($item, 'type', 'remote'); - if (isset($item['gravity'])) { $item['gravity'] = intval($item['gravity']); } elseif ($item['parent-uri'] === $item['uri']) { $item['gravity'] = GRAVITY_PARENT; } elseif (activity_match($item['verb'], ACTIVITY_POST)) { $item['gravity'] = GRAVITY_COMMENT; - } elseif ($item['type'] == 'activity') { - $item['gravity'] = GRAVITY_ACTIVITY; } else { $item['gravity'] = GRAVITY_UNKNOWN; // Should not happen - logger('Unknown gravity for verb: ' . $item['verb'] . ' - type: ' . $item['type'], LOGGER_DEBUG); + Logger::log('Unknown gravity for verb: ' . $item['verb'], Logger::DEBUG); } $uid = intval($item['uid']); @@ -993,8 +1321,8 @@ class Item extends BaseObject // check for create date and expire time $expire_interval = Config::get('system', 'dbclean-expire-days', 0); - $user = dba::selectFirst('user', ['expire'], ['uid' => $uid]); - if (DBM::is_result($user) && ($user['expire'] > 0) && (($user['expire'] < $expire_interval) || ($expire_interval == 0))) { + $user = DBA::selectFirst('user', ['expire'], ['uid' => $uid]); + if (DBA::isResult($user) && ($user['expire'] > 0) && (($user['expire'] < $expire_interval) || ($expire_interval == 0))) { $expire_interval = $user['expire']; } @@ -1002,7 +1330,7 @@ class Item extends BaseObject $expire_date = time() - ($expire_interval * 86400); $created_date = strtotime($item['created']); if ($created_date < $expire_date) { - logger('item-store: item created ('.date('c', $created_date).') before expiration time ('.date('c', $expire_date).'). ignored. ' . print_r($item,true), LOGGER_DEBUG); + Logger::log('item-store: item created ('.date('c', $created_date).') before expiration time ('.date('c', $expire_date).'). ignored. ' . print_r($item,true), Logger::DEBUG); return 0; } } @@ -1012,23 +1340,21 @@ class Item extends BaseObject * We have to check several networks since Friendica posts could be repeated * via OStatus (maybe Diasporsa as well) */ - if (in_array($item['network'], [NETWORK_DIASPORA, NETWORK_DFRN, NETWORK_OSTATUS, ""])) { + if (in_array($item['network'], [Protocol::ACTIVITYPUB, Protocol::DIASPORA, Protocol::DFRN, Protocol::OSTATUS, ""])) { $condition = ["`uri` = ? AND `uid` = ? AND `network` IN (?, ?, ?)", trim($item['uri']), $item['uid'], - NETWORK_DIASPORA, NETWORK_DFRN, NETWORK_OSTATUS]; - $existing = dba::selectFirst('item', ['id', 'network'], $condition); - if (DBM::is_result($existing)) { + Protocol::DIASPORA, Protocol::DFRN, Protocol::OSTATUS]; + $existing = self::selectFirst(['id', 'network'], $condition); + if (DBA::isResult($existing)) { // We only log the entries with a different user id than 0. Otherwise we would have too many false positives if ($uid != 0) { - logger("Item with uri ".$item['uri']." already existed for user ".$uid." with id ".$existing["id"]." target network ".$existing["network"]." - new network: ".$item['network']); + Logger::log("Item with uri ".$item['uri']." already existed for user ".$uid." with id ".$existing["id"]." target network ".$existing["network"]." - new network: ".$item['network']); } return $existing["id"]; } } - self::addLanguageInPostopts($item); - $item['wall'] = intval(defaults($item, 'wall', 0)); $item['extid'] = trim(defaults($item, 'extid', '')); $item['author-name'] = trim(defaults($item, 'author-name', '')); @@ -1048,6 +1374,7 @@ class Item extends BaseObject $item['visible'] = ((x($item, 'visible') !== false) ? intval($item['visible']) : 1); $item['deleted'] = 0; $item['parent-uri'] = trim(defaults($item, 'parent-uri', $item['uri'])); + $item['post-type'] = defaults($item, 'post-type', self::PT_ARTICLE); $item['verb'] = trim(defaults($item, 'verb', '')); $item['object-type'] = trim(defaults($item, 'object-type', '')); $item['object'] = trim(defaults($item, 'object', '')); @@ -1059,7 +1386,6 @@ class Item extends BaseObject $item['deny_cid'] = trim(defaults($item, 'deny_cid', '')); $item['deny_gid'] = trim(defaults($item, 'deny_gid', '')); $item['private'] = intval(defaults($item, 'private', 0)); - $item['bookmark'] = intval(defaults($item, 'bookmark', 0)); $item['body'] = trim(defaults($item, 'body', '')); $item['tag'] = trim(defaults($item, 'tag', '')); $item['attach'] = trim(defaults($item, 'attach', '')); @@ -1073,10 +1399,12 @@ class Item extends BaseObject // When there is no content then we don't post it if ($item['body'].$item['title'] == '') { - logger('No body, no title.'); + Logger::log('No body, no title.'); return 0; } + self::addLanguageToItemArray($item); + // Items cannot be stored before they happen ... if ($item['created'] > DateTimeFormat::utcNow()) { $item['created'] = DateTimeFormat::utcNow(); @@ -1087,10 +1415,6 @@ class Item extends BaseObject $item['edited'] = DateTimeFormat::utcNow(); } - if (($item['author-link'] == "") && ($item['owner-link'] == "")) { - logger("Both author-link and owner-link are empty. Called by: " . System::callstack(), LOGGER_DEBUG); - } - $item['plink'] = defaults($item, 'plink', System::baseUrl() . '/display/' . urlencode($item['guid'])); // The contact-id should be set before "self::insert" was called - but there seems to be issues sometimes @@ -1102,7 +1426,7 @@ class Item extends BaseObject $item['author-id'] = defaults($item, 'author-id', Contact::getIdForURL($item["author-link"], 0, false, $default)); if (Contact::isBlocked($item["author-id"])) { - logger('Contact '.$item["author-id"].' is blocked, item '.$item["uri"].' will not be stored'); + Logger::log('Contact '.$item["author-id"].' is blocked, item '.$item["uri"].' will not be stored'); return 0; } @@ -1112,36 +1436,22 @@ class Item extends BaseObject $item['owner-id'] = defaults($item, 'owner-id', Contact::getIdForURL($item["owner-link"], 0, false, $default)); if (Contact::isBlocked($item["owner-id"])) { - logger('Contact '.$item["owner-id"].' is blocked, item '.$item["uri"].' will not be stored'); + Logger::log('Contact '.$item["owner-id"].' is blocked, item '.$item["uri"].' will not be stored'); return 0; } - // These fields aren't stored anymore in the item table, they are fetched upon request - unset($item['author-link']); - unset($item['author-name']); - unset($item['author-avatar']); + if ($item['network'] == Protocol::PHANTOM) { + Logger::log('Missing network. Called by: '.System::callstack(), Logger::DEBUG); - unset($item['owner-link']); - unset($item['owner-name']); - unset($item['owner-avatar']); - - if ($item['network'] == NETWORK_PHANTOM) { - logger('Missing network. Called by: '.System::callstack(), LOGGER_DEBUG); - - $contact = Contact::getDetailsByURL($item['author-link'], $item['uid']); - if (!empty($contact['network'])) { - $item['network'] = $contact["network"]; - } else { - $item['network'] = NETWORK_DFRN; - } - logger("Set network to " . $item["network"] . " for " . $item["uri"], LOGGER_DEBUG); + $item['network'] = Protocol::DFRN; + Logger::log("Set network to " . $item["network"] . " for " . $item["uri"], Logger::DEBUG); } // Checking if there is already an item with the same guid - logger('Checking for an item for user '.$item['uid'].' on network '.$item['network'].' with the guid '.$item['guid'], LOGGER_DEBUG); + Logger::log('Checking for an item for user '.$item['uid'].' on network '.$item['network'].' with the guid '.$item['guid'], Logger::DEBUG); $condition = ['guid' => $item['guid'], 'network' => $item['network'], 'uid' => $item['uid']]; if (self::exists($condition)) { - logger('found item with guid '.$item['guid'].' for user '.$item['uid'].' on network '.$item['network'], LOGGER_DEBUG); + Logger::log('found item with guid '.$item['guid'].' for user '.$item['uid'].' on network '.$item['network'], Logger::DEBUG); return 0; } @@ -1173,9 +1483,9 @@ class Item extends BaseObject 'wall', 'private', 'forum_mode', 'origin']; $condition = ['uri' => $item['parent-uri'], 'uid' => $item['uid']]; $params = ['order' => ['id' => false]]; - $parent = dba::selectFirst('item', $fields, $condition, $params); + $parent = self::selectFirst($fields, $condition, $params); - if (DBM::is_result($parent)) { + if (DBA::isResult($parent)) { // is the new message multi-level threaded? // even though we don't support it now, preserve the info // and re-attach to the conversation parent. @@ -1187,9 +1497,9 @@ class Item extends BaseObject 'parent-uri' => $item['parent-uri'], 'uid' => $item['uid']]; $params = ['order' => ['id' => false]]; - $toplevel_parent = dba::selectFirst('item', $fields, $condition, $params); + $toplevel_parent = self::selectFirst($fields, $condition, $params); - if (DBM::is_result($toplevel_parent)) { + if (DBA::isResult($toplevel_parent)) { $parent = $toplevel_parent; } } @@ -1222,15 +1532,15 @@ class Item extends BaseObject } // If its a post from myself then tag the thread as "mention" - logger("Checking if parent ".$parent_id." has to be tagged as mention for user ".$item['uid'], LOGGER_DEBUG); - $user = dba::selectFirst('user', ['nickname'], ['uid' => $item['uid']]); - if (DBM::is_result($user)) { - $self = normalise_link(System::baseUrl() . '/profile/' . $user['nickname']); + Logger::log("Checking if parent ".$parent_id." has to be tagged as mention for user ".$item['uid'], Logger::DEBUG); + $user = DBA::selectFirst('user', ['nickname'], ['uid' => $item['uid']]); + if (DBA::isResult($user)) { + $self = Strings::normaliseLink(System::baseUrl() . '/profile/' . $user['nickname']); $self_id = Contact::getIdForURL($self, 0, true); - logger("'myself' is ".$self_id." for parent ".$parent_id." checking against ".$item['author-id']." and ".$item['owner-id'], LOGGER_DEBUG); + Logger::log("'myself' is ".$self_id." for parent ".$parent_id." checking against ".$item['author-id']." and ".$item['owner-id'], Logger::DEBUG); if (($item['author-id'] == $self_id) || ($item['owner-id'] == $self_id)) { - dba::update('thread', ['mention' => true], ['iid' => $parent_id]); - logger("tagged thread ".$parent_id." as mention for user ".$self, LOGGER_DEBUG); + DBA::update('thread', ['mention' => true], ['iid' => $parent_id]); + Logger::log("tagged thread ".$parent_id." as mention for user ".$self, Logger::DEBUG); } } } else { @@ -1239,12 +1549,12 @@ class Item extends BaseObject * we don't have or can't see the original post. */ if ($force_parent) { - logger('$force_parent=true, reply converted to top-level post.'); + Logger::log('$force_parent=true, reply converted to top-level post.'); $parent_id = 0; $item['parent-uri'] = $item['uri']; $item['gravity'] = GRAVITY_PARENT; } else { - logger('item parent '.$item['parent-uri'].' for '.$item['uid'].' was not found - ignoring item'); + Logger::log('item parent '.$item['parent-uri'].' for '.$item['uid'].' was not found - ignoring item'); return 0; } @@ -1252,18 +1562,21 @@ class Item extends BaseObject } } + $item['parent-uri-id'] = ItemURI::getIdByURI($item['parent-uri']); + $item['thr-parent-id'] = ItemURI::getIdByURI($item['thr-parent']); + $condition = ["`uri` = ? AND `network` IN (?, ?) AND `uid` = ?", - $item['uri'], $item['network'], NETWORK_DFRN, $item['uid']]; + $item['uri'], $item['network'], Protocol::DFRN, $item['uid']]; if (self::exists($condition)) { - logger('duplicated item with the same uri found. '.print_r($item,true)); + Logger::log('duplicated item with the same uri found. '.print_r($item,true)); return 0; } // On Friendica and Diaspora the GUID is unique - if (in_array($item['network'], [NETWORK_DFRN, NETWORK_DIASPORA])) { + if (in_array($item['network'], [Protocol::DFRN, Protocol::DIASPORA])) { $condition = ['guid' => $item['guid'], 'uid' => $item['uid']]; if (self::exists($condition)) { - logger('duplicated item with the same guid found. '.print_r($item,true)); + Logger::log('duplicated item with the same guid found. '.print_r($item,true)); return 0; } } else { @@ -1271,7 +1584,7 @@ class Item extends BaseObject $condition = ["`body` = ? AND `network` = ? AND `created` = ? AND `contact-id` = ? AND `uid` = ?", $item['body'], $item['network'], $item['created'], $item['contact-id'], $item['uid']]; if (self::exists($condition)) { - logger('duplicated item with the same body found. '.print_r($item,true)); + Logger::log('duplicated item with the same body found. '.print_r($item,true)); return 0; } } @@ -1281,7 +1594,7 @@ class Item extends BaseObject $item["global"] = true; // Set the global flag on all items if this was a global item entry - dba::update('item', ['global' => true], ['uri' => $item["uri"]]); + self::update(['global' => true], ['uri' => $item["uri"]]); } else { $item["global"] = self::exists(['uid' => 0, 'uri' => $item["uri"]]); } @@ -1301,10 +1614,14 @@ class Item extends BaseObject $item["deleted"] = $parent_deleted; // Fill the cache field - put_item_in_cache($item); + self::putInCache($item); if ($notify) { + $item['edit'] = false; + $item['parent'] = $parent_id; Addon::callHooks('post_local', $item); + unset($item['edit']); + unset($item['parent']); } else { Addon::callHooks('post_remote', $item); } @@ -1314,7 +1631,7 @@ class Item extends BaseObject unset($item['api_source']); if (x($item, 'cancel')) { - logger('post cancelled by addon.'); + Logger::log('post cancelled by addon.'); return 0; } @@ -1325,23 +1642,59 @@ class Item extends BaseObject */ if ($item["uid"] == 0) { if (self::exists(['uri' => trim($item['uri']), 'uid' => 0])) { - logger('Global item already stored. URI: '.$item['uri'].' on network '.$item['network'], LOGGER_DEBUG); + Logger::log('Global item already stored. URI: '.$item['uri'].' on network '.$item['network'], Logger::DEBUG); return 0; } } - logger('' . print_r($item,true), LOGGER_DATA); + Logger::log('' . print_r($item,true), Logger::DATA); + + if (array_key_exists('tag', $item)) { + $tags = $item['tag']; + unset($item['tag']); + } else { + $tags = ''; + } + + if (array_key_exists('file', $item)) { + $files = $item['file']; + unset($item['file']); + } else { + $files = ''; + } + + // Creates or assigns the permission set + $item['psid'] = PermissionSet::fetchIDForPost($item); + + // We are doing this outside of the transaction to avoid timing problems + if (!self::insertActivity($item)) { + self::insertContent($item); + } + + $delivery_data = ['postopts' => defaults($item, 'postopts', ''), + 'inform' => defaults($item, 'inform', '')]; + + unset($item['postopts']); + unset($item['inform']); + + // These fields aren't stored anymore in the item table, they are fetched upon request + unset($item['author-link']); + unset($item['author-name']); + unset($item['author-avatar']); + + unset($item['owner-link']); + unset($item['owner-name']); + unset($item['owner-avatar']); - dba::transaction(); - self::insertContent($item); - $ret = dba::insert('item', $item); + DBA::transaction(); + $ret = DBA::insert('item', $item); // When the item was successfully stored we fetch the ID of the item. - if (DBM::is_result($ret)) { - $current_post = dba::lastInsertId(); + if (DBA::isResult($ret)) { + $current_post = DBA::lastInsertId(); } else { // This can happen - for example - if there are locking timeouts. - dba::rollback(); + DBA::rollback(); // Store the data into a spool file so that we can try again later. @@ -1357,39 +1710,43 @@ class Item extends BaseObject $spoolpath = get_spoolpath(); if ($spoolpath != "") { $spool = $spoolpath.'/'.$file; + + // Ensure to have the removed data from above again in the item array + $item = array_merge($item, $delivery_data); + file_put_contents($spool, json_encode($item)); - logger("Item wasn't stored - Item was spooled into file ".$file, LOGGER_DEBUG); + Logger::log("Item wasn't stored - Item was spooled into file ".$file, Logger::DEBUG); } return 0; } if ($current_post == 0) { // This is one of these error messages that never should occur. - logger("couldn't find created item - we better quit now."); - dba::rollback(); + Logger::log("couldn't find created item - we better quit now."); + DBA::rollback(); return 0; } // How much entries have we created? // We wouldn't need this query when we could use an unique index - but MySQL has length problems with them. - $entries = dba::count('item', ['uri' => $item['uri'], 'uid' => $item['uid'], 'network' => $item['network']]); + $entries = DBA::count('item', ['uri' => $item['uri'], 'uid' => $item['uid'], 'network' => $item['network']]); if ($entries > 1) { // There are duplicates. We delete our just created entry. - logger('Duplicated post occurred. uri = ' . $item['uri'] . ' uid = ' . $item['uid']); + Logger::log('Duplicated post occurred. uri = ' . $item['uri'] . ' uid = ' . $item['uid']); // Yes, we could do a rollback here - but we are having many users with MyISAM. - dba::delete('item', ['id' => $current_post]); - dba::commit(); + DBA::delete('item', ['id' => $current_post]); + DBA::commit(); return 0; } elseif ($entries == 0) { // This really should never happen since we quit earlier if there were problems. - logger("Something is terribly wrong. We haven't found our created entry."); - dba::rollback(); + Logger::log("Something is terribly wrong. We haven't found our created entry."); + DBA::rollback(); return 0; } - logger('created item '.$current_post); + Logger::log('created item '.$current_post); self::updateContact($item); if (!$parent_id || ($item['parent-uri'] === $item['uri'])) { @@ -1397,17 +1754,17 @@ class Item extends BaseObject } // Set parent id - dba::update('item', ['parent' => $parent_id], ['id' => $current_post]); + self::update(['parent' => $parent_id], ['id' => $current_post]); $item['id'] = $current_post; $item['parent'] = $parent_id; // update the commented timestamp on the parent // Only update "commented" if it is really a comment - if (($item['verb'] == ACTIVITY_POST) || !Config::get("system", "like_no_comment")) { - dba::update('item', ['commented' => DateTimeFormat::utcNow(), 'changed' => DateTimeFormat::utcNow()], ['id' => $parent_id]); + if (($item['gravity'] != GRAVITY_ACTIVITY) || !Config::get("system", "like_no_comment")) { + self::update(['commented' => DateTimeFormat::utcNow(), 'changed' => DateTimeFormat::utcNow()], ['id' => $parent_id]); } else { - dba::update('item', ['changed' => DateTimeFormat::utcNow()], ['id' => $parent_id]); + self::update(['changed' => DateTimeFormat::utcNow()], ['id' => $parent_id]); } if ($dsprsig) { @@ -1417,17 +1774,20 @@ class Item extends BaseObject */ if (base64_encode(base64_decode(base64_decode($dsprsig->signature))) == base64_decode($dsprsig->signature)) { $dsprsig->signature = base64_decode($dsprsig->signature); - logger("Repaired double encoded signature from handle ".$dsprsig->signer, LOGGER_DEBUG); + Logger::log("Repaired double encoded signature from handle ".$dsprsig->signer, Logger::DEBUG); } - dba::insert('sign', ['iid' => $current_post, 'signed_text' => $dsprsig->signed_text, - 'signature' => $dsprsig->signature, 'signer' => $dsprsig->signer]); + if (!empty($dsprsig->signed_text) && empty($dsprsig->signature) && empty($dsprsig->signer)) { + DBA::insert('diaspora-interaction', ['uri-id' => $item['uri-id'], 'interaction' => $dsprsig->signed_text], true); + } else { + // The other fields are used by very old Friendica servers, so we currently store them differently + DBA::insert('sign', ['iid' => $current_post, 'signed_text' => $dsprsig->signed_text, + 'signature' => $dsprsig->signature, 'signer' => $dsprsig->signer]); + } } if (!empty($diaspora_signed_text)) { - // Formerly we stored the signed text, the signature and the author in different fields. - // We now store the raw data so that we are more flexible. - dba::insert('sign', ['iid' => $current_post, 'signed_text' => $diaspora_signed_text]); + DBA::insert('diaspora-interaction', ['uri-id' => $item['uri-id'], 'interaction' => $diaspora_signed_text], true); } $deleted = self::tagDeliver($item['uid'], $current_post); @@ -1437,15 +1797,15 @@ class Item extends BaseObject * in it. */ if (!$deleted && !$dontcache) { - $posted_item = dba::selectFirst('item', [], ['id' => $current_post]); - if (DBM::is_result($posted_item)) { + $posted_item = self::selectFirst(self::ITEM_FIELDLIST, ['id' => $current_post]); + if (DBA::isResult($posted_item)) { if ($notify) { Addon::callHooks('post_local_end', $posted_item); } else { Addon::callHooks('post_remote_end', $posted_item); } } else { - logger('new item not found in DB, id ' . $current_post); + Logger::log('new item not found in DB, id ' . $current_post); } } @@ -1455,14 +1815,23 @@ class Item extends BaseObject self::updateThread($parent_id); } - dba::commit(); + $delivery_data['iid'] = $current_post; + + self::insertDeliveryData($delivery_data); + + DBA::commit(); /* * Due to deadlock issues with the "term" table we are doing these steps after the commit. * This is not perfect - but a workable solution until we found the reason for the problem. */ - Term::insertFromTagFieldByItemId($current_post); - Term::insertFromFileFieldByItemId($current_post); + if (!empty($tags)) { + Term::insertFromTagFieldByItemId($current_post, $tags); + } + + if (!empty($files)) { + Term::insertFromFileFieldByItemId($current_post, $files); + } if ($item['parent-uri'] === $item['uri']) { self::addShadow($current_post); @@ -1473,45 +1842,162 @@ class Item extends BaseObject check_user_notification($current_post); if ($notify) { - Worker::add(['priority' => $priority, 'dont_fork' => true], "Notifier", $notify_type, $current_post); - } elseif (!empty($parent) && $parent['origin']) { - Worker::add(['priority' => PRIORITY_HIGH, 'dont_fork' => true], "Notifier", "comment-import", $current_post); + Worker::add(['priority' => $priority, 'dont_fork' => true], 'Notifier', $notify_type, $current_post); + } elseif ($item['visible'] && ((!empty($parent) && $parent['origin']) || $item['origin'])) { + if ($item['gravity'] == GRAVITY_ACTIVITY) { + $cmd = $item['origin'] ? 'activity-new' : 'activity-import'; + } elseif ($item['gravity'] == GRAVITY_COMMENT) { + $cmd = $item['origin'] ? 'comment-new' : 'comment-import'; + } else { + $cmd = 'wall-new'; + } + + Worker::add(['priority' => PRIORITY_HIGH, 'dont_fork' => true], 'Notifier', $cmd, $current_post); } return $current_post; } + /** + * @brief Insert a new item delivery data entry + * + * @param array $item The item fields that are to be inserted + */ + private static function insertDeliveryData($delivery_data) + { + if (empty($delivery_data['iid']) || (empty($delivery_data['postopts']) && empty($delivery_data['inform']))) { + return; + } + + DBA::insert('item-delivery-data', $delivery_data); + } + + /** + * @brief Update an existing item delivery data entry + * + * @param integer $id The item id that is to be updated + * @param array $item The item fields that are to be inserted + */ + private static function updateDeliveryData($id, $delivery_data) + { + if (empty($id) || (empty($delivery_data['postopts']) && empty($delivery_data['inform']))) { + return; + } + + DBA::update('item-delivery-data', $delivery_data, ['iid' => $id], true); + } + /** * @brief Insert a new item content entry * * @param array $item The item fields that are to be inserted */ - private static function insertContent(&$item) + private static function insertActivity(&$item) { - $fields = ['uri' => $item['uri'], 'plink' => $item['plink'], - 'uri-plink-hash' => hash('sha1', $item['plink']).hash('sha1', $item['uri'])]; + $activity_index = self::activityToIndex($item['verb']); + + if ($activity_index < 0) { + return false; + } + + $fields = ['activity' => $activity_index, 'uri-hash' => (string)$item['uri-id'], 'uri-id' => $item['uri-id']]; + + // We just remove everything that is content + foreach (array_merge(self::CONTENT_FIELDLIST, self::MIXED_CONTENT_FIELDLIST) as $field) { + unset($item[$field]); + } + + // To avoid timing problems, we are using locks. + $locked = Lock::acquire('item_insert_activity'); + if (!$locked) { + Logger::log("Couldn't acquire lock for URI " . $item['uri'] . " - proceeding anyway."); + } + + // Do we already have this content? + $item_activity = DBA::selectFirst('item-activity', ['id'], ['uri-id' => $item['uri-id']]); + if (DBA::isResult($item_activity)) { + $item['iaid'] = $item_activity['id']; + Logger::log('Fetched activity for URI ' . $item['uri'] . ' (' . $item['iaid'] . ')'); + } elseif (DBA::insert('item-activity', $fields)) { + $item['iaid'] = DBA::lastInsertId(); + Logger::log('Inserted activity for URI ' . $item['uri'] . ' (' . $item['iaid'] . ')'); + } else { + // This shouldn't happen. + Logger::log('Could not insert activity for URI ' . $item['uri'] . ' - should not happen'); + Lock::release('item_insert_activity'); + return false; + } + if ($locked) { + Lock::release('item_insert_activity'); + } + return true; + } - unset($item['plink']); + /** + * @brief Insert a new item content entry + * + * @param array $item The item fields that are to be inserted + */ + private static function insertContent(&$item) + { + $fields = ['uri-plink-hash' => (string)$item['uri-id'], 'uri-id' => $item['uri-id']]; - foreach (self::CONTENT_FIELDLIST as $field) { + foreach (array_merge(self::CONTENT_FIELDLIST, self::MIXED_CONTENT_FIELDLIST) as $field) { if (isset($item[$field])) { $fields[$field] = $item[$field]; unset($item[$field]); } } - // Do we already have this content? - if (!dba::exists('item-content', ['uri' => $item['uri']])) { - dba::insert('item-content', $fields, true); + // To avoid timing problems, we are using locks. + $locked = Lock::acquire('item_insert_content'); + if (!$locked) { + Logger::log("Couldn't acquire lock for URI " . $item['uri'] . " - proceeding anyway."); } - $item_content = dba::selectFirst('item-content', ['id'], ['uri' => $item['uri']]); - if (DBM::is_result($item_content)) { + // Do we already have this content? + $item_content = DBA::selectFirst('item-content', ['id'], ['uri-id' => $item['uri-id']]); + if (DBA::isResult($item_content)) { $item['icid'] = $item_content['id']; - logger('Insert content for URI ' . $item['uri'] . ' (' . $item['icid'] . ')'); + Logger::log('Fetched content for URI ' . $item['uri'] . ' (' . $item['icid'] . ')'); + } elseif (DBA::insert('item-content', $fields)) { + $item['icid'] = DBA::lastInsertId(); + Logger::log('Inserted content for URI ' . $item['uri'] . ' (' . $item['icid'] . ')'); + } else { + // This shouldn't happen. + Logger::log('Could not insert content for URI ' . $item['uri'] . ' - should not happen'); + } + if ($locked) { + Lock::release('item_insert_content'); } } + /** + * @brief Update existing item content entries + * + * @param array $item The item fields that are to be changed + * @param array $condition The condition for finding the item content entries + */ + private static function updateActivity($item, $condition) + { + if (empty($item['verb'])) { + return false; + } + $activity_index = self::activityToIndex($item['verb']); + + if ($activity_index < 0) { + return false; + } + + $fields = ['activity' => $activity_index]; + + Logger::log('Update activity for ' . json_encode($condition)); + + DBA::update('item-activity', $fields, $condition, true); + + return true; + } + /** * @brief Update existing item content entries * @@ -1522,24 +2008,21 @@ class Item extends BaseObject { // We have to select only the fields from the "item-content" table $fields = []; - foreach (self::CONTENT_FIELDLIST as $field) { + foreach (array_merge(self::CONTENT_FIELDLIST, self::MIXED_CONTENT_FIELDLIST) as $field) { if (isset($item[$field])) { $fields[$field] = $item[$field]; } } if (empty($fields)) { - return; + // when there are no fields at all, just use the condition + // This is to ensure that we always store content. + $fields = $condition; } - if (!empty($item['plink'])) { - $fields['plink'] = $item['plink']; - $fields['uri-plink-hash'] = hash('sha1', $item['plink']) . hash('sha1', $condition['uri']); - } + Logger::log('Update content for ' . json_encode($condition)); - logger('Update content for URI ' . $condition['uri']); - - dba::update('item-content', $fields, $condition, true); + DBA::update('item-content', $fields, $condition, true); } /** @@ -1551,20 +2034,22 @@ class Item extends BaseObject public static function distribute($itemid, $signed_text = '') { $condition = ["`id` IN (SELECT `parent` FROM `item` WHERE `id` = ?)", $itemid]; - $parent = dba::selectFirst('item', ['owner-id'], $condition); - if (!DBM::is_result($parent)) { + $parent = self::selectFirst(['owner-id'], $condition); + if (!DBA::isResult($parent)) { return; } // Only distribute public items from native networks $condition = ['id' => $itemid, 'uid' => 0, - 'network' => [NETWORK_DFRN, NETWORK_DIASPORA, NETWORK_OSTATUS, ""], + 'network' => [Protocol::ACTIVITYPUB, Protocol::DFRN, Protocol::DIASPORA, Protocol::OSTATUS, ""], 'visible' => true, 'deleted' => false, 'moderated' => false, 'private' => false]; $item = self::selectFirst(self::ITEM_FIELDLIST, ['id' => $itemid]); - if (!DBM::is_result($item)) { + if (!DBA::isResult($item)) { return; } + $origin = $item['origin']; + unset($item['id']); unset($item['parent']); unset($item['mention']); @@ -1574,20 +2059,54 @@ class Item extends BaseObject $users = []; - $condition = ["`nurl` IN (SELECT `nurl` FROM `contact` WHERE `id` = ?) AND `uid` != 0 AND NOT `blocked` AND `rel` IN (?, ?)", - $parent['owner-id'], CONTACT_IS_SHARING, CONTACT_IS_FRIEND]; - $contacts = dba::select('contact', ['uid'], $condition); - while ($contact = dba::fetch($contacts)) { + /// @todo add a field "pcid" in the contact table that referrs to the public contact id. + $owner = DBA::selectFirst('contact', ['url', 'nurl', 'alias'], ['id' => $parent['owner-id']]); + if (!DBA::isResult($owner)) { + return; + } + + $condition = ['nurl' => $owner['nurl'], 'rel' => [Contact::SHARING, Contact::FRIEND]]; + $contacts = DBA::select('contact', ['uid'], $condition); + while ($contact = DBA::fetch($contacts)) { + if ($contact['uid'] == 0) { + continue; + } + $users[$contact['uid']] = $contact['uid']; } + DBA::close($contacts); + + $condition = ['alias' => $owner['url'], 'rel' => [Contact::SHARING, Contact::FRIEND]]; + $contacts = DBA::select('contact', ['uid'], $condition); + while ($contact = DBA::fetch($contacts)) { + if ($contact['uid'] == 0) { + continue; + } + + $users[$contact['uid']] = $contact['uid']; + } + DBA::close($contacts); + + if (!empty($owner['alias'])) { + $condition = ['url' => $owner['alias'], 'rel' => [Contact::SHARING, Contact::FRIEND]]; + $contacts = DBA::select('contact', ['uid'], $condition); + while ($contact = DBA::fetch($contacts)) { + if ($contact['uid'] == 0) { + continue; + } + + $users[$contact['uid']] = $contact['uid']; + } + DBA::close($contacts); + } $origin_uid = 0; if ($item['uri'] != $item['parent-uri']) { - $parents = dba::select('item', ['uid', 'origin'], ["`uri` = ? AND `uid` != 0", $item['parent-uri']]); - while ($parent = dba::fetch($parents)) { + $parents = self::select(['uid', 'origin'], ["`uri` = ? AND `uid` != 0", $item['parent-uri']]); + while ($parent = self::fetch($parents)) { $users[$parent['uid']] = $parent['uid']; - if ($parent['origin'] && !$item['origin']) { + if ($parent['origin'] && !$origin) { $origin_uid = $parent['uid']; } } @@ -1620,25 +2139,19 @@ class Item extends BaseObject } if (empty($item['contact-id'])) { - $self = dba::selectFirst('contact', ['id'], ['self' => true, 'uid' => $uid]); - if (!DBM::is_result($self)) { + $self = DBA::selectFirst('contact', ['id'], ['self' => true, 'uid' => $uid]); + if (!DBA::isResult($self)) { return; } $item['contact-id'] = $self['id']; } - if (in_array($item['type'], ["net-comment", "wall-comment"])) { - $item['type'] = 'remote-comment'; - } elseif ($item['type'] == 'wall') { - $item['type'] = 'remote'; - } - /// @todo Handling of "event-id" $notify = false; if ($item['uri'] == $item['parent-uri']) { - $contact = dba::selectFirst('contact', [], ['id' => $item['contact-id'], 'self' => false]); - if (DBM::is_result($contact)) { + $contact = DBA::selectFirst('contact', [], ['id' => $item['contact-id'], 'self' => false]); + if (DBA::isResult($contact)) { $notify = self::isRemoteSelf($contact, $item); } } @@ -1646,9 +2159,9 @@ class Item extends BaseObject $distributed = self::insert($item, false, $notify, true); if (!$distributed) { - logger("Distributed public item " . $itemid . " for user " . $uid . " wasn't stored", LOGGER_DEBUG); + Logger::log("Distributed public item " . $itemid . " for user " . $uid . " wasn't stored", Logger::DEBUG); } else { - logger("Distributed public item " . $itemid . " for user " . $uid . " with id " . $distributed, LOGGER_DEBUG); + Logger::log("Distributed public item " . $itemid . " for user " . $uid . " with id " . $distributed, Logger::DEBUG); } } @@ -1663,11 +2176,11 @@ class Item extends BaseObject */ public static function addShadow($itemid) { - $fields = ['uid', 'private', 'moderated', 'visible', 'deleted', 'network']; + $fields = ['uid', 'private', 'moderated', 'visible', 'deleted', 'network', 'uri']; $condition = ['id' => $itemid, 'parent' => [0, $itemid]]; - $item = dba::selectFirst('item', $fields, $condition); + $item = self::selectFirst($fields, $condition); - if (!DBM::is_result($item)) { + if (!DBA::isResult($item)) { return; } @@ -1682,40 +2195,36 @@ class Item extends BaseObject } // is it an entry from a connector? Only add an entry for natively connected networks - if (!in_array($item["network"], [NETWORK_DFRN, NETWORK_DIASPORA, NETWORK_OSTATUS, ""])) { + if (!in_array($item["network"], [Protocol::ACTIVITYPUB, Protocol::DFRN, Protocol::DIASPORA, Protocol::OSTATUS, ""])) { return; } - $item = self::selectFirst(self::ITEM_FIELDLIST, ['id' => $itemid]); + if (self::exists(['uri' => $item['uri'], 'uid' => 0])) { + return; + } - if (DBM::is_result($item) && ($item["allow_cid"] == '') && ($item["allow_gid"] == '') && - ($item["deny_cid"] == '') && ($item["deny_gid"] == '')) { - - if (!self::exists(['uri' => $item['uri'], 'uid' => 0])) { - // Preparing public shadow (removing user specific data) - $item['uid'] = 0; - unset($item['id']); - unset($item['parent']); - unset($item['wall']); - unset($item['mention']); - unset($item['origin']); - unset($item['starred']); - if ($item['uri'] == $item['parent-uri']) { - $item['contact-id'] = $item['owner-id']; - } else { - $item['contact-id'] = $item['author-id']; - } + $item = self::selectFirst(self::ITEM_FIELDLIST, ['id' => $itemid]); - if (in_array($item['type'], ["net-comment", "wall-comment"])) { - $item['type'] = 'remote-comment'; - } elseif ($item['type'] == 'wall') { - $item['type'] = 'remote'; - } + if (DBA::isResult($item)) { + // Preparing public shadow (removing user specific data) + $item['uid'] = 0; + unset($item['id']); + unset($item['parent']); + unset($item['wall']); + unset($item['mention']); + unset($item['origin']); + unset($item['starred']); + unset($item['postopts']); + unset($item['inform']); + if ($item['uri'] == $item['parent-uri']) { + $item['contact-id'] = $item['owner-id']; + } else { + $item['contact-id'] = $item['author-id']; + } - $public_shadow = self::insert($item, false, false, true); + $public_shadow = self::insert($item, false, false, true); - logger("Stored public shadow for thread ".$itemid." under id ".$public_shadow, LOGGER_DEBUG); - } + Logger::log("Stored public shadow for thread ".$itemid." under id ".$public_shadow, Logger::DEBUG); } } @@ -1729,7 +2238,7 @@ class Item extends BaseObject public static function addShadowPost($itemid) { $item = self::selectFirst(self::ITEM_FIELDLIST, ['id' => $itemid]); - if (!DBM::is_result($item)) { + if (!DBA::isResult($item)) { return; } @@ -1766,59 +2275,35 @@ class Item extends BaseObject unset($item['mention']); unset($item['origin']); unset($item['starred']); + unset($item['postopts']); + unset($item['inform']); $item['contact-id'] = Contact::getIdForURL($item['author-link']); - if (in_array($item['type'], ["net-comment", "wall-comment"])) { - $item['type'] = 'remote-comment'; - } elseif ($item['type'] == 'wall') { - $item['type'] = 'remote'; - } - $public_shadow = self::insert($item, false, false, true); - logger("Stored public shadow for comment ".$item['uri']." under id ".$public_shadow, LOGGER_DEBUG); + Logger::log("Stored public shadow for comment ".$item['uri']." under id ".$public_shadow, Logger::DEBUG); // If this was a comment to a Diaspora post we don't get our comment back. // This means that we have to distribute the comment by ourselves. - if ($origin && self::exists(['id' => $parent, 'network' => NETWORK_DIASPORA])) { + if ($origin && self::exists(['id' => $parent, 'network' => Protocol::DIASPORA])) { self::distribute($public_shadow); } } /** - * Adds a "lang" specification in a "postopts" element of given $arr, - * if possible and not already present. + * Adds a language specification in a "language" element of given $arr. * Expects "body" element to exist in $arr. */ - private static function addLanguageInPostopts(&$item) + private static function addLanguageToItemArray(&$item) { - $postopts = ""; - - if (!empty($item['postopts'])) { - if (strstr($item['postopts'], 'lang=')) { - // do not override - return; - } - $postopts = $item['postopts']; - } + $naked_body = BBCode::toPlaintext($item['body'], false); - $naked_body = Text\BBCode::toPlaintext($item['body'], false); + $ld = new Text_LanguageDetect(); + $ld->setNameMode(2); + $languages = $ld->detect($naked_body, 3); - $languages = (new Text_LanguageDetect())->detect($naked_body, 3); - - if (sizeof($languages) > 0) { - if ($postopts != '') { - $postopts .= '&'; // arbitrary separator, to be reviewed - } - - $postopts .= 'lang='; - $sep = ""; - - foreach ($languages as $language => $score) { - $postopts .= $sep . $language . ";" . $score; - $sep = ':'; - } - $item['postopts'] = $postopts; + if (is_array($languages)) { + $item['language'] = json_encode($languages); } } @@ -1861,16 +2346,10 @@ class Item extends BaseObject public static function newURI($uid, $guid = "") { if ($guid == "") { - $guid = get_guid(32); + $guid = System::createUUID(); } - $hostname = self::getApp()->get_hostname(); - - $user = dba::selectFirst('user', ['nickname'], ['uid' => $uid]); - - $uri = "urn:X-dfrn:" . $hostname . ':' . $user['nickname'] . ':' . $guid; - - return $uri; + return self::getApp()->getBaseURL() . '/objects/' . $guid; } /** @@ -1885,37 +2364,37 @@ class Item extends BaseObject private static function updateContact($arr) { // Unarchive the author - $contact = dba::selectFirst('contact', [], ['id' => $arr["author-id"]]); - if (DBM::is_result($contact)) { + $contact = DBA::selectFirst('contact', [], ['id' => $arr["author-id"]]); + if (DBA::isResult($contact)) { Contact::unmarkForArchival($contact); } // Unarchive the contact if it's not our own contact - $contact = dba::selectFirst('contact', [], ['id' => $arr["contact-id"], 'self' => false]); - if (DBM::is_result($contact)) { + $contact = DBA::selectFirst('contact', [], ['id' => $arr["contact-id"], 'self' => false]); + if (DBA::isResult($contact)) { Contact::unmarkForArchival($contact); } - $update = (!$arr['private'] && (($arr["author-link"] === $arr["owner-link"]) || ($arr["parent-uri"] === $arr["uri"]))); + $update = (!$arr['private'] && ((defaults($arr, 'author-link', '') === defaults($arr, 'owner-link', '')) || ($arr["parent-uri"] === $arr["uri"]))); // Is it a forum? Then we don't care about the rules from above - if (!$update && ($arr["network"] == NETWORK_DFRN) && ($arr["parent-uri"] === $arr["uri"])) { - if (dba::exists('contact', ['id' => $arr['contact-id'], 'forum' => true])) { + if (!$update && ($arr["network"] == Protocol::DFRN) && ($arr["parent-uri"] === $arr["uri"])) { + if (DBA::exists('contact', ['id' => $arr['contact-id'], 'forum' => true])) { $update = true; } } if ($update) { - dba::update('contact', ['success_update' => $arr['received'], 'last-item' => $arr['received']], + DBA::update('contact', ['success_update' => $arr['received'], 'last-item' => $arr['received']], ['id' => $arr['contact-id']]); } // Now do the same for the system wide contacts with uid=0 if (!$arr['private']) { - dba::update('contact', ['success_update' => $arr['received'], 'last-item' => $arr['received']], + DBA::update('contact', ['success_update' => $arr['received'], 'last-item' => $arr['received']], ['id' => $arr['owner-id']]); if ($arr['owner-id'] != $arr['author-id']) { - dba::update('contact', ['success_update' => $arr['received'], 'last-item' => $arr['received']], + DBA::update('contact', ['success_update' => $arr['received'], 'last-item' => $arr['received']], ['id' => $arr['author-id']]); } } @@ -1924,7 +2403,7 @@ class Item extends BaseObject public static function setHashtags(&$item) { - $tags = get_tags($item["body"]); + $tags = BBCode::getTags($item["body"]); // No hashtags? if (!count($tags)) { @@ -1991,14 +2470,20 @@ class Item extends BaseObject public static function getGuidById($id) { - $item = dba::selectFirst('item', ['guid'], ['id' => $id]); - if (DBM::is_result($item)) { + $item = self::selectFirst(['guid'], ['id' => $id]); + if (DBA::isResult($item)) { return $item['guid']; } else { return ''; } } + /** + * This function is only used for the old Friendica app on Android that doesn't like paths with guid + * @param string $guid item guid + * @param int $uid user id + * @return array with id and nick of the item with the given guid + */ public static function getIdAndNickByGuid($guid, $uid = 0) { $nick = ""; @@ -2010,28 +2495,28 @@ class Item extends BaseObject // Does the given user have this item? if ($uid) { - $item = dba::fetch_first("SELECT `item`.`id`, `user`.`nickname` FROM `item` - INNER JOIN `user` ON `user`.`uid` = `item`.`uid` - WHERE `item`.`visible` AND NOT `item`.`deleted` AND NOT `item`.`moderated` - AND `item`.`guid` = ? AND `item`.`uid` = ?", $guid, $uid); - if (DBM::is_result($item)) { - $id = $item["id"]; - $nick = $item["nickname"]; + $item = self::selectFirst(['id'], ['guid' => $guid, 'uid' => $uid]); + if (DBA::isResult($item)) { + $user = DBA::selectFirst('user', ['nickname'], ['uid' => $uid]); + if (!DBA::isResult($user)) { + return; + } + $id = $item['id']; + $nick = $user['nickname']; } } // Or is it anywhere on the server? if ($nick == "") { - $item = dba::fetch_first("SELECT `item`.`id`, `user`.`nickname` FROM `item` - INNER JOIN `user` ON `user`.`uid` = `item`.`uid` - WHERE `item`.`visible` AND NOT `item`.`deleted` AND NOT `item`.`moderated` - AND `item`.`allow_cid` = '' AND `item`.`allow_gid` = '' - AND `item`.`deny_cid` = '' AND `item`.`deny_gid` = '' - AND NOT `item`.`private` AND `item`.`wall` - AND `item`.`guid` = ?", $guid); - if (DBM::is_result($item)) { - $id = $item["id"]; - $nick = $item["nickname"]; + $condition = ["`guid` = ? AND `uid` != 0", $guid]; + $item = self::selectFirst(['id', 'uid'], $condition); + if (DBA::isResult($item)) { + $user = DBA::selectFirst('user', ['nickname'], ['uid' => $item['uid']]); + if (!DBA::isResult($user)) { + return; + } + $id = $item['id']; + $nick = $user['nickname']; } } return ["nick" => $nick, "id" => $id]; @@ -2047,33 +2532,33 @@ class Item extends BaseObject { $mention = false; - $user = dba::selectFirst('user', [], ['uid' => $uid]); - if (!DBM::is_result($user)) { + $user = DBA::selectFirst('user', [], ['uid' => $uid]); + if (!DBA::isResult($user)) { return; } - $community_page = (($user['page-flags'] == PAGE_COMMUNITY) ? true : false); - $prvgroup = (($user['page-flags'] == PAGE_PRVGROUP) ? true : false); + $community_page = (($user['page-flags'] == Contact::PAGE_COMMUNITY) ? true : false); + $prvgroup = (($user['page-flags'] == Contact::PAGE_PRVGROUP) ? true : false); - $item = dba::selectFirst('item', [], ['id' => $item_id]); - if (!DBM::is_result($item)) { + $item = self::selectFirst(self::ITEM_FIELDLIST, ['id' => $item_id]); + if (!DBA::isResult($item)) { return; } - $link = normalise_link(System::baseUrl() . '/profile/' . $user['nickname']); + $link = Strings::normaliseLink(System::baseUrl() . '/profile/' . $user['nickname']); /* * Diaspora uses their own hardwired link URL in @-tags * instead of the one we supply with webfinger */ - $dlink = normalise_link(System::baseUrl() . '/u/' . $user['nickname']); + $dlink = Strings::normaliseLink(System::baseUrl() . '/u/' . $user['nickname']); $cnt = preg_match_all('/[\@\!]\[url\=(.*?)\](.*?)\[\/url\]/ism', $item['body'], $matches, PREG_SET_ORDER); if ($cnt) { foreach ($matches as $mtch) { - if (link_compare($link, $mtch[1]) || link_compare($dlink, $mtch[1])) { + if (Strings::compareLink($link, $mtch[1]) || Strings::compareLink($dlink, $mtch[1])) { $mention = true; - logger('mention found: ' . $mtch[2]); + Logger::log('mention found: ' . $mtch[2]); } } } @@ -2083,8 +2568,8 @@ class Item extends BaseObject !$item['wall'] && !$item['origin'] && ($item['id'] == $item['parent'])) { // mmh.. no mention.. community page or private group... no wall.. no origin.. top-post (not a comment) // delete it! - logger("no-mention top-level post to community or private group. delete."); - dba::delete('item', ['id' => $item_id]); + Logger::log("no-mention top-level post to community or private group. delete."); + DBA::delete('item', ['id' => $item_id]); return true; } return; @@ -2108,8 +2593,8 @@ class Item extends BaseObject } // now change this copy of the post to a forum head message and deliver to all the tgroup members - $self = dba::selectFirst('contact', ['id', 'name', 'url', 'thumb'], ['uid' => $uid, 'self' => true]); - if (!DBM::is_result($self)) { + $self = DBA::selectFirst('contact', ['id', 'name', 'url', 'thumb'], ['uid' => $uid, 'self' => true]); + if (!DBA::isResult($self)) { return; } @@ -2119,12 +2604,13 @@ class Item extends BaseObject $private = ($user['allow_cid'] || $user['allow_gid'] || $user['deny_cid'] || $user['deny_gid']) ? 1 : 0; + $psid = PermissionSet::fetchIDForPost($user); + $forum_mode = ($prvgroup ? 2 : 1); $fields = ['wall' => true, 'origin' => true, 'forum_mode' => $forum_mode, 'contact-id' => $self['id'], - 'owner-id' => $owner_id, 'owner-link' => $self['url'], 'private' => $private, 'allow_cid' => $user['allow_cid'], - 'allow_gid' => $user['allow_gid'], 'deny_cid' => $user['deny_cid'], 'deny_gid' => $user['deny_gid']]; - dba::update('item', $fields, ['id' => $item_id]); + 'owner-id' => $owner_id, 'private' => $private, 'psid' => $psid]; + self::update($fields, ['id' => $item_id]); self::updateThread($item_id); @@ -2140,34 +2626,34 @@ class Item extends BaseObject } // Prevent the forwarding of posts that are forwarded - if ($datarray["extid"] == NETWORK_DFRN) { - logger('Already forwarded', LOGGER_DEBUG); + if (!empty($datarray["extid"]) && ($datarray["extid"] == Protocol::DFRN)) { + Logger::log('Already forwarded', Logger::DEBUG); return false; } // Prevent to forward already forwarded posts - if ($datarray["app"] == $a->get_hostname()) { - logger('Already forwarded (second test)', LOGGER_DEBUG); + if ($datarray["app"] == $a->getHostName()) { + Logger::log('Already forwarded (second test)', Logger::DEBUG); return false; } // Only forward posts if ($datarray["verb"] != ACTIVITY_POST) { - logger('No post', LOGGER_DEBUG); + Logger::log('No post', Logger::DEBUG); return false; } - if (($contact['network'] != NETWORK_FEED) && $datarray['private']) { - logger('Not public', LOGGER_DEBUG); + if (($contact['network'] != Protocol::FEED) && $datarray['private']) { + Logger::log('Not public', Logger::DEBUG); return false; } $datarray2 = $datarray; - logger('remote-self start - Contact '.$contact['url'].' - '.$contact['remote_self'].' Item '.print_r($datarray, true), LOGGER_DEBUG); + Logger::log('remote-self start - Contact '.$contact['url'].' - '.$contact['remote_self'].' Item '.print_r($datarray, true), Logger::DEBUG); if ($contact['remote_self'] == 2) { - $self = dba::selectFirst('contact', ['id', 'name', 'url', 'thumb'], + $self = DBA::selectFirst('contact', ['id', 'name', 'url', 'thumb'], ['uid' => $contact['uid'], 'self' => true]); - if (DBM::is_result($self)) { + if (DBA::isResult($self)) { $datarray['contact-id'] = $self["id"]; $datarray['owner-name'] = $self["name"]; @@ -2186,13 +2672,13 @@ class Item extends BaseObject unset($datarray['author-id']); } - if ($contact['network'] != NETWORK_FEED) { - $datarray["guid"] = get_guid(32); + if ($contact['network'] != Protocol::FEED) { + $datarray["guid"] = System::createUUID(); unset($datarray["plink"]); $datarray["uri"] = self::newURI($contact['uid'], $datarray["guid"]); $datarray["parent-uri"] = $datarray["uri"]; $datarray["thr-parent"] = $datarray["uri"]; - $datarray["extid"] = NETWORK_DFRN; + $datarray["extid"] = Protocol::DFRN; $urlpart = parse_url($datarray2['author-link']); $datarray["app"] = $urlpart["host"]; } else { @@ -2200,10 +2686,10 @@ class Item extends BaseObject } } - if ($contact['network'] != NETWORK_FEED) { + if ($contact['network'] != Protocol::FEED) { // Store the original post $result = self::insert($datarray2, false, false); - logger('remote-self post original item - Contact '.$contact['url'].' return '.$result.' Item '.print_r($datarray2, true), LOGGER_DEBUG); + Logger::log('remote-self post original item - Contact '.$contact['url'].' return '.$result.' Item '.print_r($datarray2, true), Logger::DEBUG); } else { $datarray["app"] = "Feed"; $result = true; @@ -2233,7 +2719,7 @@ class Item extends BaseObject return $s; } - logger('check for photos', LOGGER_DEBUG); + Logger::log('check for photos', Logger::DEBUG); $site = substr(System::baseUrl(), strpos(System::baseUrl(), '://')); $orig_body = $s; @@ -2247,7 +2733,7 @@ class Item extends BaseObject $img_st_close++; // make it point to AFTER the closing bracket $image = substr($orig_body, $img_start + $img_st_close, $img_len); - logger('found photo ' . $image, LOGGER_DEBUG); + Logger::log('found photo ' . $image, Logger::DEBUG); if (stristr($image, $site . '/photo/')) { // Only embed locally hosted photos @@ -2260,8 +2746,8 @@ class Item extends BaseObject $res = substr($i, $x + 1); $i = substr($i, 0, $x); $fields = ['data', 'type', 'allow_cid', 'allow_gid', 'deny_cid', 'deny_gid']; - $photo = dba::selectFirst('photo', $fields, ['resource-id' => $i, 'scale' => $res, 'uid' => $uid]); - if (DBM::is_result($photo)) { + $photo = DBA::selectFirst('photo', $fields, ['resource-id' => $i, 'scale' => $res, 'uid' => $uid]); + if (DBA::isResult($photo)) { /* * Check to see if we should replace this photo link with an embedded image * 1. No need to do so if the photo is public @@ -2289,7 +2775,7 @@ class Item extends BaseObject // If a custom width and height were specified, apply before embedding if (preg_match("/\[img\=([0-9]*)x([0-9]*)\]/is", substr($orig_body, $img_start, $img_st_close), $match)) { - logger('scaling photo', LOGGER_DEBUG); + Logger::log('scaling photo', Logger::DEBUG); $width = intval($match[1]); $height = intval($match[2]); @@ -2302,9 +2788,9 @@ class Item extends BaseObject } } - logger('replacing photo', LOGGER_DEBUG); + Logger::log('replacing photo', Logger::DEBUG); $image = 'data:' . $type . ';base64,' . base64_encode($data); - logger('replaced: ' . $image, LOGGER_DATA); + Logger::log('replaced: ' . $image, Logger::DATA); } } } @@ -2328,17 +2814,8 @@ class Item extends BaseObject private static function hasPermissions($obj) { - return ( - ( - x($obj, 'allow_cid') - ) || ( - x($obj, 'allow_gid') - ) || ( - x($obj, 'deny_cid') - ) || ( - x($obj, 'deny_gid') - ) - ); + return !empty($obj['allow_cid']) || !empty($obj['allow_gid']) || + !empty($obj['deny_cid']) || !empty($obj['deny_gid']); } private static function samePermissions($obj1, $obj2) @@ -2362,7 +2839,7 @@ class Item extends BaseObject } // returns an array of contact-ids that are allowed to see this object - private static function enumeratePermissions($obj) + public static function enumeratePermissions($obj) { $allow_people = expand_acl($obj['allow_cid']); $allow_groups = Group::expand(expand_acl($obj['allow_gid'])); @@ -2404,82 +2881,87 @@ class Item extends BaseObject return; } + $condition = ["`uid` = ? AND NOT `deleted` AND `id` = `parent` AND `gravity` = ?", + $uid, GRAVITY_PARENT]; + /* * $expire_network_only = save your own wall posts * and just expire conversations started by others */ - $expire_network_only = PConfig::get($uid,'expire', 'network_only'); - $sql_extra = (intval($expire_network_only) ? " AND wall = 0 " : ""); + $expire_network_only = PConfig::get($uid, 'expire', 'network_only', false); + + if ($expire_network_only) { + $condition[0] .= " AND NOT `wall`"; + } if ($network != "") { - $sql_extra .= sprintf(" AND network = '%s' ", dbesc($network)); + $condition[0] .= " AND `network` = ?"; + $condition[] = $network; /* * There is an index "uid_network_received" but not "uid_network_created" * This avoids the creation of another index just for one purpose. * And it doesn't really matter wether to look at "received" or "created" */ - $range = "AND `received` < UTC_TIMESTAMP() - INTERVAL %d DAY "; + $condition[0] .= " AND `received` < UTC_TIMESTAMP() - INTERVAL ? DAY"; + $condition[] = $days; } else { - $range = "AND `created` < UTC_TIMESTAMP() - INTERVAL %d DAY "; + $condition[0] .= " AND `created` < UTC_TIMESTAMP() - INTERVAL ? DAY"; + $condition[] = $days; } - $r = q("SELECT `file`, `resource-id`, `starred`, `type`, `id` FROM `item` - WHERE `uid` = %d $range - AND `id` = `parent` - $sql_extra - AND `deleted` = 0", - intval($uid), - intval($days) - ); + $items = self::select(['file', 'resource-id', 'starred', 'type', 'id', 'post-type'], $condition); - if (!DBM::is_result($r)) { + if (!DBA::isResult($items)) { return; } - $expire_items = PConfig::get($uid, 'expire', 'items', 1); + $expire_items = PConfig::get($uid, 'expire', 'items', true); // Forcing expiring of items - but not notes and marked items if ($force) { $expire_items = true; } - $expire_notes = PConfig::get($uid, 'expire', 'notes', 1); - $expire_starred = PConfig::get($uid, 'expire', 'starred', 1); - $expire_photos = PConfig::get($uid, 'expire', 'photos', 0); + $expire_notes = PConfig::get($uid, 'expire', 'notes', true); + $expire_starred = PConfig::get($uid, 'expire', 'starred', true); + $expire_photos = PConfig::get($uid, 'expire', 'photos', false); - logger('User '.$uid.': expire: # items=' . count($r). "; expire items: $expire_items, expire notes: $expire_notes, expire starred: $expire_starred, expire photos: $expire_photos"); - - foreach ($r as $item) { + $expired = 0; + while ($item = Item::fetch($items)) { // don't expire filed items - if (strpos($item['file'],'[') !== false) { + if (strpos($item['file'], '[') !== false) { continue; } // Only expire posts, not photos and photo comments - if ($expire_photos == 0 && strlen($item['resource-id'])) { + if (!$expire_photos && strlen($item['resource-id'])) { continue; - } elseif ($expire_starred == 0 && intval($item['starred'])) { + } elseif (!$expire_starred && intval($item['starred'])) { continue; - } elseif ($expire_notes == 0 && $item['type'] == 'note') { + } elseif (!$expire_notes && (($item['type'] == 'note') || ($item['post-type'] == Item::PT_PERSONAL_NOTE))) { continue; - } elseif ($expire_items == 0 && $item['type'] != 'note') { + } elseif (!$expire_items && ($item['type'] != 'note') && ($item['post-type'] != Item::PT_PERSONAL_NOTE)) { continue; } self::deleteById($item['id'], PRIORITY_LOW); + + ++$expired; } + DBA::close($items); + Logger::log('User ' . $uid . ": expired $expired items; expire items: $expire_items, expire notes: $expire_notes, expire starred: $expire_starred, expire photos: $expire_photos"); } public static function firstPostDate($uid, $wall = false) { $condition = ['uid' => $uid, 'wall' => $wall, 'deleted' => false, 'visible' => true, 'moderated' => false]; $params = ['order' => ['created' => false]]; - $thread = dba::selectFirst('thread', ['created'], $condition, $params); - if (DBM::is_result($thread)) { + $thread = DBA::selectFirst('thread', ['created'], $condition, $params); + if (DBA::isResult($thread)) { return substr(DateTimeFormat::local($thread['created']), 0, 10); } return false; @@ -2508,68 +2990,65 @@ class Item extends BaseObject switch ($verb) { case 'like': case 'unlike': - $bodyverb = L10n::t('%1$s likes %2$s\'s %3$s'); $activity = ACTIVITY_LIKE; break; case 'dislike': case 'undislike': - $bodyverb = L10n::t('%1$s doesn\'t like %2$s\'s %3$s'); $activity = ACTIVITY_DISLIKE; break; case 'attendyes': case 'unattendyes': - $bodyverb = L10n::t('%1$s is attending %2$s\'s %3$s'); $activity = ACTIVITY_ATTEND; break; case 'attendno': case 'unattendno': - $bodyverb = L10n::t('%1$s is not attending %2$s\'s %3$s'); $activity = ACTIVITY_ATTENDNO; break; case 'attendmaybe': case 'unattendmaybe': - $bodyverb = L10n::t('%1$s may attend %2$s\'s %3$s'); $activity = ACTIVITY_ATTENDMAYBE; break; default: - logger('like: unknown verb ' . $verb . ' for item ' . $item_id); + Logger::log('like: unknown verb ' . $verb . ' for item ' . $item_id); return false; } // Enable activity toggling instead of on/off $event_verb_flag = $activity === ACTIVITY_ATTEND || $activity === ACTIVITY_ATTENDNO || $activity === ACTIVITY_ATTENDMAYBE; - logger('like: verb ' . $verb . ' item ' . $item_id); + Logger::log('like: verb ' . $verb . ' item ' . $item_id); - $item = dba::selectFirst('item', [], ['`id` = ? OR `uri` = ?', $item_id, $item_id]); - if (!DBM::is_result($item)) { - logger('like: unknown item ' . $item_id); + $item = self::selectFirst(self::ITEM_FIELDLIST, ['`id` = ? OR `uri` = ?', $item_id, $item_id]); + if (!DBA::isResult($item)) { + Logger::log('like: unknown item ' . $item_id); return false; } + $item_uri = $item['uri']; + $uid = $item['uid']; if (($uid == 0) && local_user()) { $uid = local_user(); } - if (!can_write_wall($uid)) { - logger('like: unable to write on wall ' . $uid); + if (!Security::canWriteToUserWall($uid)) { + Logger::log('like: unable to write on wall ' . $uid); return false; } // Retrieves the local post owner - $owner_self_contact = dba::selectFirst('contact', [], ['uid' => $uid, 'self' => true]); - if (!DBM::is_result($owner_self_contact)) { - logger('like: unknown owner ' . $uid); + $owner_self_contact = DBA::selectFirst('contact', [], ['uid' => $uid, 'self' => true]); + if (!DBA::isResult($owner_self_contact)) { + Logger::log('like: unknown owner ' . $uid); return false; } // Retrieve the current logged in user's public contact $author_id = public_contact(); - $author_contact = dba::selectFirst('contact', [], ['id' => $author_id]); - if (!DBM::is_result($author_contact)) { - logger('like: unknown author ' . $author_id); + $author_contact = DBA::selectFirst('contact', ['url'], ['id' => $author_id]); + if (!DBA::isResult($author_contact)) { + Logger::log('like: unknown author ' . $author_id); return false; } @@ -2579,9 +3058,9 @@ class Item extends BaseObject $item_contact = $owner_self_contact; } else { $item_contact_id = Contact::getIdForURL($author_contact['url'], $uid, true); - $item_contact = dba::selectFirst('contact', [], ['id' => $item_contact_id]); - if (!DBM::is_result($item_contact)) { - logger('like: unknown item contact ' . $item_contact_id); + $item_contact = DBA::selectFirst('contact', [], ['id' => $item_contact_id]); + if (!DBA::isResult($item_contact)) { + Logger::log('like: unknown item contact ' . $item_contact_id); return false; } } @@ -2591,40 +3070,24 @@ class Item extends BaseObject // we need to eradicate your first choice. if ($event_verb_flag) { $verbs = [ACTIVITY_ATTEND, ACTIVITY_ATTENDNO, ACTIVITY_ATTENDMAYBE]; + + // Translate to the index based activity index + $activities = []; + foreach ($verbs as $verb) { + $activities[] = self::activityToIndex($verb); + } } else { - $verbs = $activity; + $activities = self::activityToIndex($activity); } - $base_condition = ['verb' => $verbs, 'deleted' => false, 'gravity' => GRAVITY_ACTIVITY, - 'author-id' => $author_contact['id'], 'uid' => item['uid']]; + $condition = ['activity' => $activities, 'deleted' => false, 'gravity' => GRAVITY_ACTIVITY, + 'author-id' => $author_id, 'uid' => $item['uid'], 'thr-parent' => $item_uri]; - $condition = array_merge($base_condition, ['parent' => $item_id]); $like_item = self::selectFirst(['id', 'guid', 'verb'], $condition); - if (!DBM::is_result($like_item)) { - $condition = array_merge($base_condition, ['parent-uri' => $item_id]); - $like_item = self::selectFirst(['id', 'guid', 'verb'], $condition); - } - - if (!DBM::is_result($like_item)) { - $condition = array_merge($base_condition, ['thr-parent' => $item_id]); - $like_item = self::selectFirst(['id', 'guid', 'verb'], $condition); - } - // If it exists, mark it as deleted - if (DBM::is_result($like_item)) { - // Already voted, undo it - $fields = ['deleted' => true, 'unseen' => true, 'changed' => DateTimeFormat::utcNow()]; - /// @todo Consider using self::update - but before doing so, check the side effects - dba::update('item', $fields, ['id' => $like_item['id']]); - - // Clean up the Diaspora signatures for this like - // Go ahead and do it even if Diaspora support is disabled. We still want to clean up - // if it had been enabled in the past - dba::delete('sign', ['iid' => $like_item['id']]); - - $like_item_id = $like_item['id']; - Worker::add(PRIORITY_HIGH, "Notifier", "like", $like_item_id); + if (DBA::isResult($like_item)) { + self::deleteById($like_item['id']); if (!$event_verb_flag || $like_item['verb'] == $activity) { return true; @@ -2636,55 +3099,25 @@ class Item extends BaseObject return true; } - // Else or if event verb different from existing row, create a new item row - $post_type = (($item['resource-id']) ? L10n::t('photo') : L10n::t('status')); - if ($item['object-type'] === ACTIVITY_OBJ_EVENT) { - $post_type = L10n::t('event'); - } - $objtype = $item['resource-id'] ? ACTIVITY_OBJ_IMAGE : ACTIVITY_OBJ_NOTE ; - $link = xmlify('' . "\n") ; - $body = $item['body']; - - $obj = <<< EOT - - - $objtype - 1 - {$item['uri']} - $link - - $body - -EOT; - - $ulink = '[url=' . $author_contact['url'] . ']' . $author_contact['name'] . '[/url]'; - $alink = '[url=' . $item['author-link'] . ']' . $item['author-name'] . '[/url]'; - $plink = '[url=' . System::baseUrl() . '/display/' . $owner_self_contact['nick'] . '/' . $item['id'] . ']' . $post_type . '[/url]'; + $objtype = $item['resource-id'] ? ACTIVITY_OBJ_IMAGE : ACTIVITY_OBJ_NOTE; $new_item = [ - 'guid' => get_guid(32), + 'guid' => System::createUUID(), 'uri' => self::newURI($item['uid']), 'uid' => $item['uid'], 'contact-id' => $item_contact_id, - 'type' => 'activity', 'wall' => $item['wall'], 'origin' => 1, + 'network' => Protocol::DFRN, 'gravity' => GRAVITY_ACTIVITY, 'parent' => $item['id'], 'parent-uri' => $item['uri'], 'thr-parent' => $item['uri'], - 'owner-id' => $item['owner-id'], - 'owner-name' => $item['owner-name'], - 'owner-link' => $item['owner-link'], - 'owner-avatar' => $item['owner-avatar'], - 'author-id' => $author_contact['id'], - 'author-name' => $author_contact['name'], - 'author-link' => $author_contact['url'], - 'author-avatar' => $author_contact['thumb'], - 'body' => sprintf($bodyverb, $ulink, $alink, $plink), + 'owner-id' => $author_id, + 'author-id' => $author_id, + 'body' => $activity, 'verb' => $activity, 'object-type' => $objtype, - 'object' => $obj, 'allow_cid' => $item['allow_cid'], 'allow_gid' => $item['allow_gid'], 'deny_cid' => $item['deny_cid'], @@ -2693,6 +3126,11 @@ EOT; 'unseen' => 1, ]; + $signed = Diaspora::createLikeSignature($uid, $new_item); + if (!empty($signed)) { + $new_item['diaspora_signed_text'] = json_encode($signed); + } + $new_item_id = self::insert($new_item); // If the parent item isn't visible then set it to visible @@ -2700,48 +3138,43 @@ EOT; self::update(['visible' => true], ['id' => $item['id']]); } - // Save the author information for the like in case we need to relay to Diaspora - Diaspora::storeLikeSignature($item_contact, $new_item_id); - $new_item['id'] = $new_item_id; Addon::callHooks('post_local_end', $new_item); - Worker::add(PRIORITY_HIGH, "Notifier", "like", $new_item_id); - return true; } private static function addThread($itemid, $onlyshadow = false) { $fields = ['uid', 'created', 'edited', 'commented', 'received', 'changed', 'wall', 'private', 'pubmail', - 'moderated', 'visible', 'starred', 'bookmark', 'contact-id', + 'moderated', 'visible', 'starred', 'contact-id', 'post-type', 'deleted', 'origin', 'forum_mode', 'mention', 'network', 'author-id', 'owner-id']; $condition = ["`id` = ? AND (`parent` = ? OR `parent` = 0)", $itemid, $itemid]; - $item = dba::selectFirst('item', $fields, $condition); + $item = self::selectFirst($fields, $condition); - if (!DBM::is_result($item)) { + if (!DBA::isResult($item)) { return; } $item['iid'] = $itemid; if (!$onlyshadow) { - $result = dba::insert('thread', $item); + $result = DBA::insert('thread', $item); - logger("Add thread for item ".$itemid." - ".print_r($result, true), LOGGER_DEBUG); + Logger::log("Add thread for item ".$itemid." - ".print_r($result, true), Logger::DEBUG); } } private static function updateThread($itemid, $setmention = false) { - $fields = ['uid', 'guid', 'created', 'edited', 'commented', 'received', 'changed', - 'wall', 'private', 'pubmail', 'moderated', 'visible', 'starred', 'bookmark', 'contact-id', + $fields = ['uid', 'guid', 'created', 'edited', 'commented', 'received', 'changed', 'post-type', + 'wall', 'private', 'pubmail', 'moderated', 'visible', 'starred', 'contact-id', 'deleted', 'origin', 'forum_mode', 'network', 'author-id', 'owner-id']; $condition = ["`id` = ? AND (`parent` = ? OR `parent` = 0)", $itemid, $itemid]; - $item = dba::selectFirst('item', $fields, $condition); - if (!DBM::is_result($item)) { + $item = self::selectFirst($fields, $condition); + if (!DBA::isResult($item)) { return; } @@ -2759,30 +3192,357 @@ EOT; } } - $result = dba::update('thread', $fields, ['iid' => $itemid]); + $result = DBA::update('thread', $fields, ['iid' => $itemid]); - logger("Update thread for item ".$itemid." - guid ".$item["guid"]." - ".(int)$result, LOGGER_DEBUG); + Logger::log("Update thread for item ".$itemid." - guid ".$item["guid"]." - ".(int)$result, Logger::DEBUG); } private static function deleteThread($itemid, $itemuri = "") { - $item = dba::selectFirst('thread', ['uid'], ['iid' => $itemid]); - if (!DBM::is_result($item)) { - logger('No thread found for id '.$itemid, LOGGER_DEBUG); + $item = DBA::selectFirst('thread', ['uid'], ['iid' => $itemid]); + if (!DBA::isResult($item)) { + Logger::log('No thread found for id '.$itemid, Logger::DEBUG); return; } - // Using dba::delete at this time could delete the associated item entries - $result = dba::e("DELETE FROM `thread` WHERE `iid` = ?", $itemid); + $result = DBA::delete('thread', ['iid' => $itemid], ['cascade' => false]); - logger("deleteThread: Deleted thread for item ".$itemid." - ".print_r($result, true), LOGGER_DEBUG); + Logger::log("deleteThread: Deleted thread for item ".$itemid." - ".print_r($result, true), Logger::DEBUG); if ($itemuri != "") { $condition = ["`uri` = ? AND NOT `deleted` AND NOT (`uid` IN (?, 0))", $itemuri, $item["uid"]]; if (!self::exists($condition)) { - dba::delete('item', ['uri' => $itemuri, 'uid' => 0]); - logger("deleteThread: Deleted shadow for item ".$itemuri, LOGGER_DEBUG); + DBA::delete('item', ['uri' => $itemuri, 'uid' => 0]); + Logger::log("deleteThread: Deleted shadow for item ".$itemuri, Logger::DEBUG); + } + } + } + + public static function getPermissionsSQLByUserId($owner_id, $remote_verified = false, $groups = null) + { + $local_user = local_user(); + $remote_user = remote_user(); + + /* + * Construct permissions + * + * default permissions - anonymous user + */ + $sql = " AND NOT `item`.`private`"; + + // Profile owner - everything is visible + if ($local_user && ($local_user == $owner_id)) { + $sql = ''; + } elseif ($remote_user) { + /* + * Authenticated visitor. Unless pre-verified, + * check that the contact belongs to this $owner_id + * and load the groups the visitor belongs to. + * If pre-verified, the caller is expected to have already + * done this and passed the groups into this function. + */ + $set = PermissionSet::get($owner_id, $remote_user, $groups); + + if (!empty($set)) { + $sql_set = " OR (`item`.`private` IN (1,2) AND `item`.`wall` AND `item`.`psid` IN (" . implode(',', $set) . "))"; + } else { + $sql_set = ''; + } + + $sql = " AND (NOT `item`.`private`" . $sql_set . ")"; + } + + return $sql; + } + + /** + * get translated item type + * + * @param array $itme + * @return string + */ + public static function postType($item) + { + if (!empty($item['event-id'])) { + return L10n::t('event'); + } elseif (!empty($item['resource-id'])) { + return L10n::t('photo'); + } elseif (!empty($item['verb']) && $item['verb'] !== ACTIVITY_POST) { + return L10n::t('activity'); + } elseif ($item['id'] != $item['parent']) { + return L10n::t('comment'); + } + + return L10n::t('post'); + } + + /** + * Sets the "rendered-html" field of the provided item + * + * Body is preserved to avoid side-effects as we modify it just-in-time for spoilers and private image links + * + * @param array $item + * @param bool $update + * + * @todo Remove reference, simply return "rendered-html" and "rendered-hash" + */ + public static function putInCache(&$item, $update = false) + { + $body = $item["body"]; + + $rendered_hash = defaults($item, 'rendered-hash', ''); + $rendered_html = defaults($item, 'rendered-html', ''); + + if ($rendered_hash == '' + || $rendered_html == "" + || $rendered_hash != hash("md5", $item["body"]) + || Config::get("system", "ignore_cache") + ) { + $a = self::getApp(); + redir_private_images($a, $item); + + $item["rendered-html"] = prepare_text($item["body"]); + $item["rendered-hash"] = hash("md5", $item["body"]); + + $hook_data = ['item' => $item, 'rendered-html' => $item['rendered-html'], 'rendered-hash' => $item['rendered-hash']]; + Addon::callHooks('put_item_in_cache', $hook_data); + $item['rendered-html'] = $hook_data['rendered-html']; + $item['rendered-hash'] = $hook_data['rendered-hash']; + unset($hook_data); + + // Force an update if the generated values differ from the existing ones + if ($rendered_hash != $item["rendered-hash"]) { + $update = true; + } + + // Only compare the HTML when we forcefully ignore the cache + if (Config::get("system", "ignore_cache") && ($rendered_html != $item["rendered-html"])) { + $update = true; + } + + if ($update && !empty($item["id"])) { + self::update( + [ + 'rendered-html' => $item["rendered-html"], + 'rendered-hash' => $item["rendered-hash"] + ], + ['id' => $item["id"]] + ); + } + } + + $item["body"] = $body; + } + + /** + * @brief Given an item array, convert the body element from bbcode to html and add smilie icons. + * If attach is true, also add icons for item attachments. + * + * @param array $item + * @param boolean $attach + * @param boolean $is_preview + * @return string item body html + * @hook prepare_body_init item array before any work + * @hook prepare_body_content_filter ('item'=>item array, 'filter_reasons'=>string array) before first bbcode to html + * @hook prepare_body ('item'=>item array, 'html'=>body string, 'is_preview'=>boolean, 'filter_reasons'=>string array) after first bbcode to html + * @hook prepare_body_final ('item'=>item array, 'html'=>body string) after attach icons and blockquote special case handling (spoiler, author) + */ + public static function prepareBody(array &$item, $attach = false, $is_preview = false) + { + $a = self::getApp(); + Addon::callHooks('prepare_body_init', $item); + + // In order to provide theme developers more possibilities, event items + // are treated differently. + if ($item['object-type'] === ACTIVITY_OBJ_EVENT && isset($item['event-id'])) { + $ev = Event::getItemHTML($item); + return $ev; + } + + $tags = Term::populateTagsFromItem($item); + + $item['tags'] = $tags['tags']; + $item['hashtags'] = $tags['hashtags']; + $item['mentions'] = $tags['mentions']; + + // Compile eventual content filter reasons + $filter_reasons = []; + if (!$is_preview && public_contact() != $item['author-id']) { + if (!empty($item['content-warning']) && (!local_user() || !PConfig::get(local_user(), 'system', 'disable_cw', false))) { + $filter_reasons[] = L10n::t('Content warning: %s', $item['content-warning']); + } + + $hook_data = [ + 'item' => $item, + 'filter_reasons' => $filter_reasons + ]; + Addon::callHooks('prepare_body_content_filter', $hook_data); + $filter_reasons = $hook_data['filter_reasons']; + unset($hook_data); + } + + // Update the cached values if there is no "zrl=..." on the links. + $update = (!local_user() && !remote_user() && ($item["uid"] == 0)); + + // Or update it if the current viewer is the intented viewer. + if (($item["uid"] == local_user()) && ($item["uid"] != 0)) { + $update = true; + } + + self::putInCache($item, $update); + $s = $item["rendered-html"]; + + $hook_data = [ + 'item' => $item, + 'html' => $s, + 'preview' => $is_preview, + 'filter_reasons' => $filter_reasons + ]; + Addon::callHooks('prepare_body', $hook_data); + $s = $hook_data['html']; + unset($hook_data); + + if (!$attach) { + // Replace the blockquotes with quotes that are used in mails. + $mailquote = '
'; + $s = str_replace(['
', '
', '
'], [$mailquote, $mailquote, $mailquote], $s); + return $s; + } + + $as = ''; + $vhead = false; + $matches = []; + preg_match_all('|\[attach\]href=\"(.*?)\" length=\"(.*?)\" type=\"(.*?)\"(?: title=\"(.*?)\")?|', $item['attach'], $matches, PREG_SET_ORDER); + foreach ($matches as $mtch) { + $mime = $mtch[3]; + + $the_url = Contact::magicLinkById($item['author-id'], $mtch[1]); + + if (strpos($mime, 'video') !== false) { + if (!$vhead) { + $vhead = true; + $a->page['htmlhead'] .= Renderer::replaceMacros(Renderer::getMarkupTemplate('videos_head.tpl'), [ + '$baseurl' => System::baseUrl(), + ]); + } + + $url_parts = explode('/', $the_url); + $id = end($url_parts); + $as .= Renderer::replaceMacros(Renderer::getMarkupTemplate('video_top.tpl'), [ + '$video' => [ + 'id' => $id, + 'title' => L10n::t('View Video'), + 'src' => $the_url, + 'mime' => $mime, + ], + ]); + } + + $filetype = strtolower(substr($mime, 0, strpos($mime, '/'))); + if ($filetype) { + $filesubtype = strtolower(substr($mime, strpos($mime, '/') + 1)); + $filesubtype = str_replace('.', '-', $filesubtype); + } else { + $filetype = 'unkn'; + $filesubtype = 'unkn'; + } + + $title = Strings::escapeHtml(trim(!empty($mtch[4]) ? $mtch[4] : $mtch[1])); + $title .= ' ' . $mtch[2] . ' ' . L10n::t('bytes'); + + $icon = '
'; + $as .= '' . $icon . ''; + } + + if ($as != '') { + $s .= '
'.$as.'
'; + } + + // Map. + if (strpos($s, '
') !== false && x($item, 'coord')) { + $x = Map::byCoordinates(trim($item['coord'])); + if ($x) { + $s = preg_replace('/\
/', '$0' . $x, $s); } } + + + // Look for spoiler. + $spoilersearch = '
'; + + // Remove line breaks before the spoiler. + while ((strpos($s, "\n" . $spoilersearch) !== false)) { + $s = str_replace("\n" . $spoilersearch, $spoilersearch, $s); + } + while ((strpos($s, "
" . $spoilersearch) !== false)) { + $s = str_replace("
" . $spoilersearch, $spoilersearch, $s); + } + + while ((strpos($s, $spoilersearch) !== false)) { + $pos = strpos($s, $spoilersearch); + $rnd = Strings::getRandomHex(8); + $spoilerreplace = '
' . L10n::t('Click to open/close') . ''. + '