X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=src%2FModel%2FItemURI.php;h=1755552299741b6884060ea8e4452c75b4aac13d;hb=c6a9e8be397c5b3c519470f8e22f23b0fbdd3b68;hp=265585be7ba8f8dba3dceb89ac050d512c121a32;hpb=2ec3a97393959e42d450e074271d2d622d25701f;p=friendica.git

diff --git a/src/Model/ItemURI.php b/src/Model/ItemURI.php
index 265585be7b..1755552299 100644
--- a/src/Model/ItemURI.php
+++ b/src/Model/ItemURI.php
@@ -1,6 +1,6 @@
 <?php
 /**
- * @copyright Copyright (C) 2020, Friendica
+ * @copyright Copyright (C) 2010-2023, the Friendica project
  *
  * @license GNU AGPL version 3 or any later version
  *
@@ -21,7 +21,10 @@
 
 namespace Friendica\Model;
 
+use Friendica\Core\Logger;
+use Friendica\Database\Database;
 use Friendica\Database\DBA;
+use Friendica\DI;
 
 class ItemURI
 {
@@ -29,26 +32,28 @@ class ItemURI
 	 * Insert an item-uri record and return its id
 	 *
 	 * @param array $fields Item-uri fields
-	 *
-	 * @return integer item-uri id
+	 * @return int|null item-uri id
 	 * @throws \Exception
 	 */
-	public static function insert($fields)
+	public static function insert(array $fields)
 	{
-		// If the URI gets too long we only take the first parts and hope for best
-		$uri = substr($fields['uri'], 0, 255);
+		$fields = DI::dbaDefinition()->truncateFieldsForTable('item-uri', $fields);
 
-		if (!DBA::exists('item-uri', ['uri' => $uri])) {
-			DBA::insert('item-uri', $fields, true);
+		if (!DBA::exists('item-uri', ['uri' => $fields['uri']])) {
+			DBA::insert('item-uri', $fields, Database::INSERT_IGNORE);
 		}
 
-		$itemuri = DBA::selectFirst('item-uri', ['id'], ['uri' => $uri]);
-
+		$itemuri = DBA::selectFirst('item-uri', ['id', 'guid'], ['uri' => $fields['uri']]);
 		if (!DBA::isResult($itemuri)) {
 			// This shouldn't happen
+			Logger::warning('Item-uri not found', $fields);
 			return null;
 		}
 
+		if (empty($itemuri['guid']) && !empty($fields['guid'])) {
+			DBA::update('item-uri', ['guid' => $fields['guid']], ['id' => $itemuri['id']]);
+		}
+
 		return $itemuri['id'];
 	}
 
@@ -56,21 +61,34 @@ class ItemURI
 	 * Searched for an id of a given uri. Adds it, if not existing yet.
 	 *
 	 * @param string $uri
+	 * @param bool   $insert
 	 *
 	 * @return integer item-uri id
+	 *
 	 * @throws \Exception
 	 */
-	public static function getIdByURI($uri)
+	public static function getIdByURI(string $uri, bool $insert = true): int
 	{
-		// If the URI gets too long we only take the first parts and hope for best
-		$uri = substr($uri, 0, 255);
+		if (empty($uri)) {
+			return 0;
+		}
 
 		$itemuri = DBA::selectFirst('item-uri', ['id'], ['uri' => $uri]);
 
-		if (!DBA::isResult($itemuri)) {
+		if (!DBA::isResult($itemuri) && $insert) {
 			return self::insert(['uri' => $uri]);
 		}
 
-		return $itemuri['id'];
+		return $itemuri['id'] ?? 0;
+	}
+
+	/**
+	 * @param int $uriId
+	 * @return bool
+	 * @throws \Exception
+	 */
+	public static function exists(int $uriId): bool
+	{
+		return DBA::exists('item-uri', ['id' => $uriId]);
 	}
 }