X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=src%2FModel%2FPhoto.php;h=d9e6f7cadebb8c54688cce3f531d15d5e025da54;hb=624e4c192c7f837ac0587a50da6e1409081eb519;hp=2edca93870806066742d40ddd14c23573f4238f2;hpb=543cc7f51f1e6a655ace88095b70a7fdad9e163c;p=friendica.git

diff --git a/src/Model/Photo.php b/src/Model/Photo.php
index 2edca93870..d9e6f7cade 100644
--- a/src/Model/Photo.php
+++ b/src/Model/Photo.php
@@ -32,6 +32,7 @@ use Friendica\Core\Storage\Exception\InvalidClassStorageException;
 use Friendica\Core\Storage\Exception\ReferenceStorageException;
 use Friendica\Core\Storage\Exception\StorageException;
 use Friendica\Core\Storage\Type\SystemResource;
+use Friendica\Network\HTTPClient\Client\HttpClientAccept;
 use Friendica\Object\Image;
 use Friendica\Util\DateTimeFormat;
 use Friendica\Util\Images;
@@ -497,7 +498,8 @@ class Photo
 
 		$filename = basename($image_url);
 		if (!empty($image_url)) {
-			$ret = DI::httpClient()->get($image_url);
+			$ret = DI::httpClient()->get($image_url, HttpClientAccept::IMAGE);
+			Logger::debug('Got picture', ['Content-Type' => $ret->getHeader('Content-Type'), 'url' => $image_url]);
 			$img_str = $ret->getBody();
 			$type = $ret->getContentType();
 		} else {
@@ -634,6 +636,7 @@ class Photo
 		$sql_extra = Security::getPermissionsSQLByUserId($uid);
 
 		$avatar_type = (local_user() && (local_user() == $uid)) ? self::USER_AVATAR : self::DEFAULT;
+		$banner_type = (local_user() && (local_user() == $uid)) ? self::USER_BANNER : self::DEFAULT;
 
 		$key = "photo_albums:".$uid.":".local_user().":".remote_user();
 		$albums = DI::cache()->get($key);
@@ -643,19 +646,21 @@ class Photo
 				// At this time we just store the data in the cache
 				$albums = DBA::toArray(DBA::p("SELECT COUNT(DISTINCT `resource-id`) AS `total`, `album`, ANY_VALUE(`created`) AS `created`
 					FROM `photo`
-					WHERE `uid` = ? AND `photo-type` IN (?, ?) $sql_extra
+					WHERE `uid` = ? AND `photo-type` IN (?, ?, ?) $sql_extra
 					GROUP BY `album` ORDER BY `created` DESC",
 					$uid,
 					self::DEFAULT,
+					$banner_type,
 					$avatar_type
 				));
 			} else {
 				// This query doesn't do the count and is much faster
 				$albums = DBA::toArray(DBA::p("SELECT DISTINCT(`album`), '' AS `total`
 					FROM `photo` USE INDEX (`uid_album_scale_created`)
-					WHERE `uid` = ? AND `photo-type` IN (?, ?) $sql_extra",
+					WHERE `uid` = ? AND `photo-type` IN (?, ?, ?) $sql_extra",
 					$uid,
 					self::DEFAULT,
+					$banner_type,
 					$avatar_type
 				));
 			}
@@ -699,10 +704,19 @@ class Photo
 		}
 		$image_uri = substr($image_uri, strrpos($image_uri, '/') + 1);
 		$image_uri = substr($image_uri, 0, strpos($image_uri, '-'));
-		if (!strlen($image_uri)) {
-			return '';
-		}
-		return $image_uri;
+		return trim($image_uri);
+	}
+
+	/**
+	 * Checks if the given URL is a local photo.
+	 * Since it is meant for time critical occasions, the check is done without any database requests.
+	 *
+	 * @param string $url
+	 * @return boolean
+	 */
+	public static function isPhotoURI(string $url): bool
+	{
+		return !empty(self::ridFromURI($url));
 	}
 
 	/**
@@ -871,6 +885,70 @@ class Photo
 		return DBA::exists('photo', ['resource-id' => $guid]);
 	}
 
+	private static function fitImageSize($Image)
+	{
+		$max_length = DI::config()->get('system', 'max_image_length');
+		if ($max_length > 0) {
+			$Image->scaleDown($max_length);
+			Logger::info('File upload: Scaling picture to new size', ['max-length' => $max_length]);
+		}
+
+		$filesize = strlen($Image->asString());
+		$width    = $Image->getWidth();
+		$height   = $Image->getHeight();
+
+		$maximagesize = DI::config()->get('system', 'maximagesize');
+
+		if (!empty($maximagesize) && ($filesize > $maximagesize)) {
+			// Scale down to multiples of 640 until the maximum size isn't exceeded anymore
+			foreach ([5120, 2560, 1280, 640] as $pixels) {
+				if (($filesize > $maximagesize) && (max($width, $height) > $pixels)) {
+					Logger::info('Resize', ['size' => $filesize, 'width' => $width, 'height' => $height, 'max' => $maximagesize, 'pixels' => $pixels]);
+					$Image->scaleDown($pixels);
+					$filesize = strlen($Image->asString());
+					$width = $Image->getWidth();
+					$height = $Image->getHeight();
+				}
+			}
+			if ($filesize > $maximagesize) {
+				Logger::notice('Image size is too big', ['size' => $filesize, 'max' => $maximagesize]);
+				return null;
+			}
+		}
+
+		return $Image;
+	}
+
+	private static function loadImageFromURL(string $image_url)
+	{
+		$filename = basename($image_url);
+		if (!empty($image_url)) {
+			$ret = DI::httpClient()->get($image_url, HttpClientAccept::IMAGE);
+			Logger::debug('Got picture', ['Content-Type' => $ret->getHeader('Content-Type'), 'url' => $image_url]);
+			$img_str = $ret->getBody();
+			$type = $ret->getContentType();
+		} else {
+			$img_str = '';
+			$type = '';
+		}
+
+		if (empty($img_str)) {
+			Logger::notice('Empty content');
+			return [];
+		}
+
+		$type = Images::getMimeTypeByData($img_str, $image_url, $type);
+
+		$Image = new Image($img_str, $type);
+
+		$Image = self::fitImageSize($Image);
+		if (empty($Image)) {
+			return [];
+		}
+
+		return ['image' => $Image, 'filename' => $filename];
+	}
+
 	private static function uploadImage(array $files)
 	{
 		Logger::info('starting new upload');
@@ -939,44 +1017,26 @@ class Photo
 		$Image->orient($src);
 		@unlink($src);
 
-		$max_length = DI::config()->get('system', 'max_image_length');
-		if ($max_length > 0) {
-			$Image->scaleDown($max_length);
-			$filesize = strlen($Image->asString());
-			Logger::info('File upload: Scaling picture to new size', ['max-length' => $max_length]);
-		}
-
-		$width = $Image->getWidth();
-		$height = $Image->getHeight();
-
-		$maximagesize = DI::config()->get('system', 'maximagesize');
-
-		if (!empty($maximagesize) && ($filesize > $maximagesize)) {
-			// Scale down to multiples of 640 until the maximum size isn't exceeded anymore
-			foreach ([5120, 2560, 1280, 640] as $pixels) {
-				if (($filesize > $maximagesize) && (max($width, $height) > $pixels)) {
-					Logger::info('Resize', ['size' => $filesize, 'width' => $width, 'height' => $height, 'max' => $maximagesize, 'pixels' => $pixels]);
-					$Image->scaleDown($pixels);
-					$filesize = strlen($Image->asString());
-					$width = $Image->getWidth();
-					$height = $Image->getHeight();
-				}
-			}
-			if ($filesize > $maximagesize) {
-				@unlink($src);
-				Logger::notice('Image size is too big', ['size' => $filesize, 'max' => $maximagesize]);
-				return [];
-			}
+		$Image = self::fitImageSize($Image);
+		if (empty($Image)) {
+			return [];
 		}
 
-		return ['image' => $Image, 'filename' => $filename, 'width' => $width, 'height' => $height];
+		return ['image' => $Image, 'filename' => $filename];
 	}
 
 	/**
-	 *
-	 * @param int   $uid   User ID
-	 * @param array $files uploaded file array
+	 * @param int         $uid   User ID
+	 * @param array       $files uploaded file array
+	 * @param string      $album
+	 * @param string|null $allow_cid
+	 * @param string|null $allow_gid
+	 * @param string      $deny_cid
+	 * @param string      $deny_gid
+	 * @param string      $desc
+	 * @param string      $resource_id
 	 * @return array photo record
+	 * @throws \Friendica\Network\HTTPException\InternalServerErrorException
 	 */
 	public static function upload(int $uid, array $files, string $album = '', string $allow_cid = null, string $allow_gid = null, string $deny_cid = '', string $deny_gid = '', string $desc = '', string $resource_id = ''): array
 	{
@@ -994,8 +1054,8 @@ class Photo
 
 		$Image    = $data['image'];
 		$filename = $data['filename'];
-		$width    = $data['width'];
-		$height   = $data['height'];
+		$width    = $Image->getWidth();
+		$height   = $Image->getHeight();
 
 		$resource_id = $resource_id ?: self::newResource();
 		$album       = $album ?: DI::l10n()->t('Wall Photos');
@@ -1053,22 +1113,36 @@ class Photo
 	}
 
 	/**
+	 * Upload a user avatar
 	 *
-	 * @param int   $uid   User ID
-	 * @param array $files uploaded file array
+	 * @param int    $uid   User ID
+	 * @param array  $files uploaded file array
+	 * @param string $url   External image url
 	 * @return string avatar resource
 	 */
-	public static function uploadAvatar(int $uid, array $files): string
+	public static function uploadAvatar(int $uid, array $files, string $url = ''): string
 	{
-		$data = self::uploadImage($files);
-		if (empty($data)) {
+		if (!empty($files)) {
+			$data = self::uploadImage($files);
+			if (empty($data)) {
+				Logger::info('upload failed');
+				return '';
+			}
+		} elseif (!empty($url)) {
+			$data = self::loadImageFromURL($url);
+			if (empty($data)) {
+				Logger::info('loading from external url failed');
+				return '';
+			}
+		} else {
+			Logger::info('Neither files nor url provided');
 			return '';
 		}
 
 		$Image    = $data['image'];
 		$filename = $data['filename'];
-		$width    = $data['width'];
-		$height   = $data['height'];
+		$width    = $Image->getWidth();
+		$height   = $Image->getHeight();
 
 		$resource_id = self::newResource();
 		$album       = DI::l10n()->t(self::PROFILE_PHOTOS);
@@ -1117,23 +1191,36 @@ class Photo
 	}
 
 	/**
+	 * Upload a user banner
 	 *
-	 * @param int   $uid   User ID
-	 * @param array $files uploaded file array
+	 * @param int    $uid   User ID
+	 * @param array  $files uploaded file array
+	 * @param string $url   External image url
 	 * @return string avatar resource
 	 */
-	public static function uploadBanner(int $uid, array $files): string
+	public static function uploadBanner(int $uid, array $files = [], string $url = ''): string
 	{
-		$data = self::uploadImage($files);
-		if (empty($data)) {
-			Logger::info('upload failed');
+		if (!empty($files)) {
+			$data = self::uploadImage($files);
+			if (empty($data)) {
+				Logger::info('upload failed');
+				return '';
+			}
+		} elseif (!empty($url)) {
+			$data = self::loadImageFromURL($url);
+			if (empty($data)) {
+				Logger::info('loading from external url failed');
+				return '';
+			}
+		} else {
+			Logger::info('Neither files nor url provided');
 			return '';
 		}
 
 		$Image    = $data['image'];
 		$filename = $data['filename'];
-		$width    = $data['width'];
-		$height   = $data['height'];
+		$width    = $Image->getWidth();
+		$height   = $Image->getHeight();
 
 		$resource_id = self::newResource();
 		$album       = DI::l10n()->t(self::BANNER_PHOTOS);