X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=src%2FModule%2FAttach.php;h=7d877c12655b0a11efa78413a0debaadc1e8d93c;hb=dd534919d7e3af010bbc2477e3d0e89a47dd0872;hp=7a625e600ae608766641bfe82eadc44dcea00a47;hpb=d6efc901946c91cf26a4436c4b58b1636e4bc9c9;p=friendica.git diff --git a/src/Module/Attach.php b/src/Module/Attach.php index 7a625e600a..7d877c1265 100644 --- a/src/Module/Attach.php +++ b/src/Module/Attach.php @@ -1,13 +1,29 @@ . + * */ - namespace Friendica\Module; use Friendica\BaseModule; use Friendica\Core\Logger; +use Friendica\Core\System; use Friendica\DI; use Friendica\Model\Attach as MAttach; @@ -19,23 +35,21 @@ class Attach extends BaseModule /** * Return to user an attached file given the id */ - public static function rawContent(array $parameters = []) + protected function rawContent(array $request = []) { - $a = DI::app(); - if ($a->argc != 2) { + if (empty($this->parameters['item'])) { throw new \Friendica\Network\HTTPException\BadRequestException(); } - // @TODO: Replace with parameter from router - $item_id = intval($a->argv[1]); - + $item_id = intval($this->parameters['item']); + // Check for existence $item = MAttach::exists(['id' => $item_id]); if ($item === false) { throw new \Friendica\Network\HTTPException\NotFoundException(DI::l10n()->t('Item was not found.')); } - // Now we'll fetch the item, if we have enough permisson + // Now we'll fetch the item, if we have enough permission $item = MAttach::getByIdWithPermission($item_id); if ($item === false) { throw new \Friendica\Network\HTTPException\ForbiddenException(DI::l10n()->t('Permission denied.')); @@ -43,7 +57,7 @@ class Attach extends BaseModule $data = MAttach::getData($item); if (is_null($data)) { - Logger::log('NULL data for attachment with id ' . $item['id']); + Logger::notice('NULL data for attachment with id ' . $item['id']); throw new \Friendica\Network\HTTPException\NotFoundException(DI::l10n()->t('Item was not found.')); } @@ -58,7 +72,7 @@ class Attach extends BaseModule } echo $data; - exit(); + System::exit(); // NOTREACHED } }