X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=src%2FModule%2FPhoto.php;h=bcfe13f5372e4330a2650f15caa8225a3109ab66;hb=64f51d337f3999afe234537c3704211656718462;hp=f5bbf4a77446d73ecdf723073e6d554509a31d36;hpb=326a7d22ba59d84cc00f7ccfbcd5a56596cbbc6d;p=friendica.git diff --git a/src/Module/Photo.php b/src/Module/Photo.php index f5bbf4a774..bcfe13f537 100644 --- a/src/Module/Photo.php +++ b/src/Module/Photo.php @@ -6,6 +6,7 @@ namespace Friendica\Module; use Friendica\BaseModule; +use Friendica\Core\L10n; use Friendica\Core\Logger; use Friendica\Core\System; use Friendica\Model\Photo as MPhoto; @@ -25,8 +26,9 @@ class Photo extends BaseModule public static function init() { $a = self::getApp(); + // @TODO: Replace with parameter from router if ($a->argc <= 1 || $a->argc > 4) { - System::httpExit(400, "Bad Request"); + throw new \Friendica\Network\HTTPException\BadRequestException(); } if (isset($_SERVER["HTTP_IF_MODIFIED_SINCE"])) { @@ -45,11 +47,9 @@ class Photo extends BaseModule exit; } - /// @todo Add Authentication to enable fetching of non public content - // $requester = HTTPSignature::getSigner('', $_SERVER); - $customsize = 0; $photo = false; + // @TODO: Replace with parameter from router switch($a->argc) { case 4: $customsize = intval($a->argv[2]); @@ -75,9 +75,7 @@ class Photo extends BaseModule } if ($photo === false) { - // not using System::httpExit() because we don't want html here. - header($_SERVER["SERVER_PROTOCOL"] . " 404 Not Found" , true, 404); - exit(); + System::httpExit('404', 'Not Found'); } $cacheable = ($photo["allow_cid"] . $photo["allow_gid"] . $photo["deny_cid"] . $photo["deny_gid"] === "") && (isset($photo["cacheable"]) ? $photo["cacheable"] : true); @@ -86,7 +84,7 @@ class Photo extends BaseModule if (is_null($img) || !$img->isValid()) { Logger::log("Invalid photo with id {$photo["id"]}."); - System::httpExit(500, ["description" => "Invalid photo with id {$photo["id"]}."]); + throw new \Friendica\Network\HTTPException\InternalServerErrorException(L10n::t('Invalid photo with id %s.', $photo["id"])); } // if customsize is set and image is not a gif, resize it