X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=src%2FProtocol%2FActivityPub%2FProcessor.php;h=948a3983bc1d6bde8d9ff02a3792af0c715b3bb9;hb=bd8032f2baa0e77cdf537093bd2fc7edf6f9a85d;hp=f5d8e48dedace989d7bf41da35d33066ec1be3c3;hpb=b84c68f02455ea6d2a4384229535c45d6426fe4b;p=friendica.git

diff --git a/src/Protocol/ActivityPub/Processor.php b/src/Protocol/ActivityPub/Processor.php
index f5d8e48ded..948a3983bc 100644
--- a/src/Protocol/ActivityPub/Processor.php
+++ b/src/Protocol/ActivityPub/Processor.php
@@ -1,6 +1,6 @@
 <?php
 /**
- * @copyright Copyright (C) 2010-2021, the Friendica project
+ * @copyright Copyright (C) 2010-2022, the Friendica project
  *
  * @license GNU AGPL version 3 or any later version
  *
@@ -26,6 +26,7 @@ use Friendica\Content\Text\HTML;
 use Friendica\Content\Text\Markdown;
 use Friendica\Core\Logger;
 use Friendica\Core\Protocol;
+use Friendica\Core\System;
 use Friendica\Database\DBA;
 use Friendica\DI;
 use Friendica\Model\APContact;
@@ -52,18 +53,14 @@ use Friendica\Util\Strings;
 class Processor
 {
 	/**
-	 * Converts mentions from Pleroma into the Friendica format
+	 * Extracts the tag character (#, @, !) from mention links
 	 *
 	 * @param string $body
-	 *
-	 * @return string converted body
+	 * @return string
 	 */
-	private static function convertMentions($body)
+	protected static function normalizeMentionLinks(string $body): string
 	{
-		$URLSearchString = "^\[\]";
-		$body = preg_replace("/\[url\=([$URLSearchString]*)\]([#@!])(.*?)\[\/url\]/ism", '$2[url=$1]$3[/url]', $body);
-
-		return $body;
+		return preg_replace('%\[url=([^\[\]]*)]([#@!])(.*?)\[/url]%ism', '$2[url=$1]$3[/url]', $body);
 	}
 
 	/**
@@ -94,17 +91,21 @@ class Processor
 	 *
 	 * @return string with replaced emojis
 	 */
-	private static function replaceEmojis($body, array $emojis)
+	private static function replaceEmojis(int $uri_id, $body, array $emojis)
 	{
 		$body = strtr($body,
 			array_combine(
 				array_column($emojis, 'name'),
 				array_map(function ($emoji) {
-					return '[class=emoji mastodon][img=' . $emoji['href'] . ']' . $emoji['name'] . '[/img][/class]';
+					return '[emoji=' . $emoji['href'] . ']' . $emoji['name'] . '[/emoji]';
 				}, $emojis)
 			)
 		);
 
+		// We store the emoji here to be able to avoid storing it in the media
+		foreach ($emojis as $emoji) {
+			Post\Link::getByLink($uri_id, $emoji['href']);
+		}
 		return $body;
 	}
 
@@ -124,7 +125,7 @@ class Processor
 		$data = ['uri-id' => $uriid];
 		$data['type'] = Post\Media::UNKNOWN;
 		$data['url'] = $attachment['url'];
-		$data['mimetype'] = $attachment['mediaType'];
+		$data['mimetype'] = $attachment['mediaType'] ?? null;
 		$data['height'] = $attachment['height'] ?? null;
 		$data['width'] = $attachment['width'] ?? null;
 		$data['size'] = $attachment['size'] ?? null;
@@ -179,6 +180,38 @@ class Processor
 		}
 
 		Item::update($item, ['uri' => $activity['id']]);
+
+		if ($activity['object_type'] == 'as:Event') {
+			$posts = Post::select(['event-id', 'uid'], ['uri' => $activity['id']]);
+			while ($post = DBA::fetch($posts)) {
+				if (empty($post['event-id'])) {
+					continue;
+				}
+				self::updateEvent($post['event-id'], $activity);
+			}
+		}
+	}
+
+	/**
+	 * Update an existing event
+	 *
+	 * @param int $event_id 
+	 * @param array $activity 
+	 */
+	private static function updateEvent(int $event_id, array $activity)
+	{
+		$event = DBA::selectFirst('event', [], ['id' => $event_id]);
+
+		$event['edited']   = DateTimeFormat::utc($activity['updated']);
+		$event['summary']  = HTML::toBBCode($activity['name']);
+		$event['desc']     = HTML::toBBCode($activity['content']);
+		$event['start']    = $activity['start-time'];
+		$event['finish']   = $activity['end-time'];
+		$event['nofinish'] = empty($event['finish']);
+		$event['location'] = $activity['location'];
+
+		Logger::info('Updating event', ['uri' => $activity['id'], 'id' => $event_id]);
+		Event::store($event);
 	}
 
 	/**
@@ -257,6 +290,8 @@ class Processor
 			$item['post-type'] = Item::PT_IMAGE;
 		} elseif ($activity['object_type'] == 'as:Page') {
 			$item['post-type'] = Item::PT_PAGE;
+		} elseif ($activity['object_type'] == 'as:Question') {
+			$item['post-type'] = Item::PT_POLL;
 		} elseif ($activity['object_type'] == 'as:Video') {
 			$item['post-type'] = Item::PT_VIDEO;
 		} else {
@@ -287,8 +322,12 @@ class Processor
 
 		$item['uri'] = $activity['id'];
 
-		$item['created'] = DateTimeFormat::utc($activity['published']);
-		$item['edited'] = DateTimeFormat::utc($activity['updated']);
+		if (empty($activity['published']) || empty($activity['updated'])) {
+			DI::logger()->notice('published or updated keys are empty for activity', ['activity' => $activity, 'callstack' => System::callstack(10)]);
+		}
+
+		$item['created'] = DateTimeFormat::utc($activity['published'] ?? 'now');
+		$item['edited'] = DateTimeFormat::utc($activity['updated'] ?? 'now');
 		$guid = $activity['sc:identifier'] ?: self::getGUIDByURL($item['uri']);
 		$item['guid'] = $activity['diaspora:guid'] ?: $guid;
 
@@ -396,6 +435,8 @@ class Processor
 	 *
 	 * @param array $activity Activity array
 	 * @param array $item
+	 *
+	 * @return int event id
 	 * @throws \Exception
 	 */
 	public static function createEvent($activity, $item)
@@ -406,7 +447,6 @@ class Processor
 		$event['finish']    = $activity['end-time'];
 		$event['nofinish']  = empty($event['finish']);
 		$event['location']  = $activity['location'];
-		$event['adjust']    = $activity['adjust'] ?? true;
 		$event['cid']       = $item['contact-id'];
 		$event['uid']       = $item['uid'];
 		$event['uri']       = $item['uri'];
@@ -419,14 +459,16 @@ class Processor
 		$event['direction'] = $item['direction'];
 		$event['source']    = $item['source'];
 
-		$condition = ['uri' => $item['uri'], 'uid' => $item['uid']];
-		$ev = DBA::selectFirst('event', ['id'], $condition);
+		$ev = DBA::selectFirst('event', ['id'], ['uri' => $item['uri'], 'uid' => $item['uid']]);
 		if (DBA::isResult($ev)) {
 			$event['id'] = $ev['id'];
 		}
 
 		$event_id = Event::store($event);
+
 		Logger::info('Event was stored', ['id' => $event_id]);
+
+		return $event_id;
 	}
 
 	/**
@@ -456,10 +498,10 @@ class Processor
 		}
 
 		if (!empty($activity['emojis'])) {
-			$content = self::replaceEmojis($content, $activity['emojis']);
+			$content = self::replaceEmojis($item['uri-id'], $content, $activity['emojis']);
 		}
 
-		$content = self::convertMentions($content);
+		$content = self::addMentionLinks($content, $activity['tags']);
 
 		if (!empty($activity['source'])) {
 			$item['body'] = $activity['source'];
@@ -609,7 +651,16 @@ class Processor
 				continue;
 			}
 
-			if (DI::pConfig()->get($receiver, 'system', 'accept_only_sharer', false) && ($receiver != 0) && ($item['gravity'] == GRAVITY_PARENT)) {
+			$is_forum = false;
+
+			if ($receiver != 0) {
+				$user = User::getById($receiver, ['account-type']);
+				if (!empty($user['account-type'])) {
+					$is_forum = ($user['account-type'] == User::ACCOUNT_TYPE_COMMUNITY);
+				}
+			}
+
+			if (!$is_forum && DI::pConfig()->get($receiver, 'system', 'accept_only_sharer', false) && ($receiver != 0) && ($item['gravity'] == GRAVITY_PARENT)) {
 				$skip = !Contact::isSharingByURL($activity['author'], $receiver);
 
 				if ($skip && (($activity['type'] == 'as:Announce') || ($item['isForum'] ?? false))) {
@@ -625,7 +676,9 @@ class Processor
 			}
 
 			if (($item['gravity'] != GRAVITY_ACTIVITY) && ($activity['object_type'] == 'as:Event')) {
-				self::createEvent($activity, $item);
+				$event_id = self::createEvent($activity, $item);
+
+				$item = Event::getItemArrayForImportedId($event_id, $item);
 			}
 
 			$item_id = Item::insert($item);
@@ -744,7 +797,7 @@ class Processor
 					$title = $matches[3];
 				}
 
-				$title = trim(HTML::toPlaintext(BBCode::convert($title, false, BBCode::API, true), 0));
+				$title = trim(BBCode::toPlaintext($title));
 
 				if (strlen($title) > 20) {
 					$title = substr($title, 0, 20) . '...';
@@ -910,7 +963,7 @@ class Processor
 		$cid = Contact::getIdForURL($activity['actor'], $uid);
 		if (!empty($cid)) {
 			self::switchContact($cid);
-			DBA::update('contact', ['hub-verify' => $activity['id'], 'protocol' => Protocol::ACTIVITYPUB], ['id' => $cid]);
+			Contact::update(['hub-verify' => $activity['id'], 'protocol' => Protocol::ACTIVITYPUB], ['id' => $cid]);
 		}
 
 		$item = ['author-id' => Contact::getIdForURL($activity['actor']),
@@ -930,7 +983,7 @@ class Processor
 		}
 
 		if (empty($contact)) {
-			DBA::update('contact', ['hub-verify' => $activity['id'], 'protocol' => Protocol::ACTIVITYPUB], ['id' => $cid]);
+			Contact::update(['hub-verify' => $activity['id'], 'protocol' => Protocol::ACTIVITYPUB], ['id' => $cid]);
 		}
 
 		Logger::notice('Follow user ' . $uid . ' from contact ' . $cid . ' with id ' . $activity['id']);
@@ -1009,7 +1062,7 @@ class Processor
 		}
 
 		$condition = ['id' => $cid];
-		DBA::update('contact', $fields, $condition);
+		Contact::update($fields, $condition);
 		Logger::info('Accept contact request', ['contact' => $cid, 'user' => $uid]);
 	}
 
@@ -1035,9 +1088,12 @@ class Processor
 
 		self::switchContact($cid);
 
-		if (DBA::exists('contact', ['id' => $cid, 'rel' => Contact::SHARING])) {
+		$contact = Contact::getById($cid, ['rel']);
+		if ($contact['rel'] == Contact::SHARING) {
 			Contact::remove($cid);
 			Logger::info('Rejected contact request - contact removed', ['contact' => $cid, 'user' => $uid]);
+		} elseif ($contact['rel'] == Contact::FRIEND) {
+			Contact::update(['rel' => Contact::FOLLOWER], ['id' => $cid]);
 		} else {
 			Logger::info('Rejected contact request', ['contact' => $cid, 'user' => $uid]);
 		}
@@ -1100,7 +1156,7 @@ class Processor
 			return;
 		}
 
-		Contact::removeFollower($owner, $contact);
+		Contact::removeFollower($contact);
 		Logger::info('Undo following request', ['contact' => $cid, 'user' => $uid]);
 	}
 
@@ -1192,4 +1248,38 @@ class Processor
 
 		return implode('', $kept_mentions);
 	}
+
+	/**
+	 * Adds links to string mentions
+	 *
+	 * @param string $body
+	 * @param array  $tags
+	 * @return string
+	 */
+	protected static function addMentionLinks(string $body, array $tags): string
+	{
+		// This prevents links to be added again to Pleroma-style mention links
+		$body = self::normalizeMentionLinks($body);
+
+		$body = BBCode::performWithEscapedTags($body, ['url'], function ($body) use ($tags) {
+			foreach ($tags as $tag) {
+				if (empty($tag['name']) || empty($tag['type']) || empty($tag['href']) || !in_array($tag['type'], ['Mention', 'Hashtag'])) {
+					continue;
+				}
+
+				$hash = substr($tag['name'], 0, 1);
+				$name = substr($tag['name'], 1);
+				if (!in_array($hash, Tag::TAG_CHARACTER)) {
+					$hash = '';
+					$name = $tag['name'];
+				}
+
+				$body = str_replace($tag['name'], $hash . '[url=' . $tag['href'] . ']' . $name . '[/url]', $body);
+			}
+
+			return $body;
+		});
+
+		return $body;
+	}
 }