X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=src%2FProtocol%2FActivityPub%2FProcessor.php;h=e6f3e156690042bd1701c20c9d662b181238c048;hb=befc2af5043a3afde251721c0d27df695db1bb7e;hp=b743489302e3790c6e573549e54777eca0d9e084;hpb=4643c95c7eda13df3c9d929f567335dc77aa0f82;p=friendica.git

diff --git a/src/Protocol/ActivityPub/Processor.php b/src/Protocol/ActivityPub/Processor.php
index b743489302..e6f3e15669 100644
--- a/src/Protocol/ActivityPub/Processor.php
+++ b/src/Protocol/ActivityPub/Processor.php
@@ -1,6 +1,6 @@
 <?php
 /**
- * @copyright Copyright (C) 2020, Friendica
+ * @copyright Copyright (C) 2010-2021, the Friendica project
  *
  * @license GNU AGPL version 3 or any later version
  *
@@ -24,22 +24,25 @@ namespace Friendica\Protocol\ActivityPub;
 use Friendica\Content\PageInfo;
 use Friendica\Content\Text\BBCode;
 use Friendica\Content\Text\HTML;
+use Friendica\Content\Text\Markdown;
 use Friendica\Core\Logger;
 use Friendica\Core\Protocol;
-use Friendica\Core\System;
 use Friendica\Database\DBA;
 use Friendica\DI;
 use Friendica\Model\APContact;
 use Friendica\Model\Contact;
 use Friendica\Model\Conversation;
 use Friendica\Model\Event;
+use Friendica\Model\GServer;
 use Friendica\Model\Item;
 use Friendica\Model\ItemURI;
 use Friendica\Model\Mail;
 use Friendica\Model\Tag;
 use Friendica\Model\User;
+use Friendica\Model\Post;
 use Friendica\Protocol\Activity;
 use Friendica\Protocol\ActivityPub;
+use Friendica\Protocol\Relay;
 use Friendica\Util\DateTimeFormat;
 use Friendica\Util\JsonLD;
 use Friendica\Util\Strings;
@@ -64,6 +67,26 @@ class Processor
 		return $body;
 	}
 
+	/**
+	 * Convert the language array into a language JSON
+	 *
+	 * @param array $languages
+	 * @return string language JSON
+	 */
+	private static function processLanguages(array $languages)
+	{
+		$codes = array_keys($languages);
+		$lang = [];
+		foreach ($codes as $code) {
+			$lang[$code] = 1;
+		}
+
+		if (empty($lang)) {
+			return '';
+		}
+
+		return json_encode($lang);
+	}
 	/**
 	 * Replaces emojis in the body
 	 *
@@ -74,13 +97,57 @@ class Processor
 	 */
 	private static function replaceEmojis($body, array $emojis)
 	{
-		foreach ($emojis as $emoji) {
-			$replace = '[class=emoji mastodon][img=' . $emoji['href'] . ']' . $emoji['name'] . '[/img][/class]';
-			$body = str_replace($emoji['name'], $replace, $body);
-		}
+		$body = strtr($body,
+			array_combine(
+				array_column($emojis, 'name'),
+				array_map(function ($emoji) {
+					return '[class=emoji mastodon][img=' . $emoji['href'] . ']' . $emoji['name'] . '[/img][/class]';
+				}, $emojis)
+			)
+		);
+
 		return $body;
 	}
 
+	/**
+	 * Store attached media files in the post-media table
+	 *
+	 * @param int $uriid
+	 * @param array $attachment
+	 * @return void
+	 */
+	private static function storeAttachmentAsMedia(int $uriid, array $attachment)
+	{
+		if (empty($attachment['url'])) {
+			return;
+		}
+
+		$data = ['uri-id' => $uriid];
+
+		$filetype = strtolower(substr($attachment['mediaType'], 0, strpos($attachment['mediaType'], '/')));
+		if ($filetype == 'image') {
+			$data['type'] = Post\Media::IMAGE;
+		} elseif ($filetype == 'video') {
+			$data['type'] = Post\Media::VIDEO;
+		} elseif ($filetype == 'audio') {
+			$data['type'] = Post\Media::AUDIO;
+		} elseif (in_array($attachment['mediaType'], ['application/x-bittorrent', 'application/x-bittorrent;x-scheme-handler/magnet'])) {
+			$data['type'] = Post\Media::TORRENT;
+		} else {
+			Logger::info('Unknown type', ['attachment' => $attachment]);
+			return;
+		}
+
+		$data['url'] = $attachment['url'];
+		$data['mimetype'] = $attachment['mediaType'];
+		$data['height'] = $attachment['height'] ?? null;
+		$data['size'] = $attachment['size'] ?? null;
+		$data['preview'] = $attachment['image'] ?? null;
+		$data['description'] = $attachment['name'] ?? null;
+
+		Post\Media::insert($data);
+	}
+
 	/**
 	 * Add attachment data to the item array
 	 *
@@ -110,10 +177,20 @@ class Processor
 					$item['body'] = PageInfo::appendDataToBody($item['body'], $data);
 					break;
 				default:
+					self::storeAttachmentAsMedia($item['uri-id'], $attach);
+
 					$filetype = strtolower(substr($attach['mediaType'], 0, strpos($attach['mediaType'], '/')));
 					if ($filetype == 'image') {
-						if (!empty($activity['source']) && strpos($activity['source'], $attach['url'])) {
-							continue 2;
+						if (!empty($activity['source'])) {
+							foreach ([0, 1, 2] as $size) {
+								if (preg_match('#/photo/.*-' . $size . '\.#ism', $attach['url']) && 
+									strpos(preg_replace('#(/photo/.*)-[012]\.#ism', '$1-' . $size . '.', $activity['source']), $attach['url'])) {
+									continue 3;
+								}
+							}
+							if (strpos($activity['source'], $attach['url'])) {
+								continue 2;
+							}
 						}
 
 						$item['body'] .= "\n";
@@ -138,21 +215,13 @@ class Processor
 							continue 2;
 						}
 
-						$item['body'] .= "\n[audio]" . $attach['url'] . '[/audio]';
+						$item['body'] = '[audio]' . $attach['url'] . "[/audio]\n" . $item['body'];
 					} elseif ($filetype == 'video') {
 						if (!empty($activity['source']) && strpos($activity['source'], $attach['url'])) {
 							continue 2;
 						}
 
-						$item['body'] .= "\n[video]" . $attach['url'] . '[/video]';
-					} else {
-						if (!empty($item["attach"])) {
-							$item["attach"] .= ',';
-						} else {
-							$item["attach"] = '';
-						}
-
-						$item["attach"] .= '[attach]href="' . $attach['url'] . '" length="' . ($attach['length'] ?? '0') . '" type="' . $attach['mediaType'] . '" title="' . ($attach['name'] ?? '') . '"[/attach]';
+						$item['body'] = '[video]' . $attach['url'] . "[/video]\n" . $item['body'];
 					}
 			}
 		}
@@ -168,7 +237,7 @@ class Processor
 	 */
 	public static function updateItem($activity)
 	{
-		$item = Item::selectFirst(['uri', 'uri-id', 'thr-parent', 'gravity'], ['uri' => $activity['id']]);
+		$item = Post::selectFirst(['uri', 'uri-id', 'thr-parent', 'gravity'], ['uri' => $activity['id']]);
 		if (!DBA::isResult($item)) {
 			Logger::warning('No existing item, item will be created', ['uri' => $activity['id']]);
 			$item = self::createItem($activity);
@@ -180,6 +249,9 @@ class Processor
 		$item['edited'] = DateTimeFormat::utc($activity['updated']);
 
 		$item = self::processContent($activity, $item);
+
+		$item = self::constructAttachList($activity, $item);
+
 		if (empty($item)) {
 			return;
 		}
@@ -207,12 +279,9 @@ class Processor
 		} else {
 			$item['gravity'] = GRAVITY_COMMENT;
 			$item['object-type'] = Activity\ObjectType::COMMENT;
-
-			// Ensure that the comment reaches all receivers of the referring post
-			$activity['receiver'] = self::addReceivers($activity);
 		}
 
-		if (empty($activity['directmessage']) && ($activity['id'] != $activity['reply-to-id']) && !Item::exists(['uri' => $activity['reply-to-id']])) {
+		if (empty($activity['directmessage']) && ($activity['id'] != $activity['reply-to-id']) && !Post::exists(['uri' => $activity['reply-to-id']])) {
 			Logger::notice('Parent not found. Try to refetch it.', ['parent' => $activity['reply-to-id']]);
 			self::fetchMissingActivity($activity['reply-to-id'], $activity);
 		}
@@ -220,7 +289,7 @@ class Processor
 		$item['diaspora_signed_text'] = $activity['diaspora:comment'] ?? '';
 
 		/// @todo What to do with $activity['context']?
-		if (empty($activity['directmessage']) && ($item['gravity'] != GRAVITY_PARENT) && !Item::exists(['uri' => $item['thr-parent']])) {
+		if (empty($activity['directmessage']) && ($item['gravity'] != GRAVITY_PARENT) && !Post::exists(['uri' => $item['thr-parent']])) {
 			Logger::info('Parent not found, message will be discarded.', ['thr-parent' => $item['thr-parent']]);
 			return [];
 		}
@@ -250,14 +319,25 @@ class Processor
 			}
 		}
 
+		if (!empty($activity['from-relay'])) {
+			$item['direction'] = Conversation::RELAY;
+		}
+
 		$item['isForum'] = false;
 
 		if (!empty($activity['thread-completion'])) {
-			// Store the original actor in the "causer" fields to enable the check for ignored or blocked contacts
-			$item['causer-link'] = $item['owner-link'];
-			$item['causer-id'] = $item['owner-id'];
+			if ($activity['thread-completion'] != $item['owner-id']) {
+				$actor = Contact::getById($activity['thread-completion'], ['url']);
+				$item['causer-link'] = $actor['url'];
+				$item['causer-id'] = $activity['thread-completion'];
+				Logger::info('Use inherited actor as causer.', ['id' => $item['owner-id'], 'activity' => $activity['thread-completion'], 'owner' => $item['owner-link'], 'actor' => $actor['url']]);
+			} else {
+				// Store the original actor in the "causer" fields to enable the check for ignored or blocked contacts
+				$item['causer-link'] = $item['owner-link'];
+				$item['causer-id'] = $item['owner-id'];
+				Logger::info('Use actor as causer.', ['id' => $item['owner-id'], 'actor' => $item['owner-link']]);
+			}
 
-			Logger::info('Ignoring actor because of thread completion.', ['actor' => $item['owner-link']]);
 			$item['owner-link'] = $item['author-link'];
 			$item['owner-id'] = $item['author-id'];
 		} else {
@@ -273,9 +353,14 @@ class Processor
 		$item['guid'] = $activity['diaspora:guid'] ?: $guid;
 
 		$item['uri-id'] = ItemURI::insert(['uri' => $item['uri'], 'guid' => $item['guid']]);
+		if (empty($item['uri-id'])) {
+			Logger::warning('Unable to get a uri-id for an item uri', ['uri' => $item['uri'], 'guid' => $item['guid']]);
+			return [];
+		}
 
 		$item = self::processContent($activity, $item);
 		if (empty($item)) {
+			Logger::info('Message was not processed');
 			return [];
 		}
 
@@ -283,6 +368,19 @@ class Processor
 
 		$item = self::constructAttachList($activity, $item);
 
+		// We received the post via AP, so we set the protocol of the server to AP
+		$contact = Contact::getById($item['author-id'], ['gsid']);
+		if (!empty($contact['gsid'])) {
+			GServer::setProtocol($contact['gsid'], Post\DeliveryData::ACTIVITYPUB);
+		}
+
+		if ($item['author-id'] != $item['owner-id']) {
+			$contact = Contact::getById($item['owner-id'], ['gsid']);
+			if (!empty($contact['gsid'])) {
+				GServer::setProtocol($contact['gsid'], Post\DeliveryData::ACTIVITYPUB);
+			}
+		}
+
 		return $item;
 	}
 
@@ -315,7 +413,7 @@ class Processor
 		}
 
 		foreach ($activity['receiver'] as $receiver) {
-			$item = Item::selectFirst(['id', 'uri-id', 'tag', 'origin', 'author-link'], ['uri' => $activity['target_id'], 'uid' => $receiver]);
+			$item = Post::selectFirst(['id', 'uri-id', 'origin', 'author-link'], ['uri' => $activity['target_id'], 'uid' => $receiver]);
 			if (!DBA::isResult($item)) {
 				// We don't fetch missing content for this purpose
 				continue;
@@ -331,35 +429,6 @@ class Processor
 		}
 	}
 
-	/**
-	 * Add users to the receiver list of the given public activity.
-	 * This is used to ensure that the activity will be stored in every thread.
-	 *
-	 * @param array $activity Activity array
-	 * @return array Modified receiver list
-	 */
-	private static function addReceivers(array $activity)
-	{
-		if (!in_array(0, $activity['receiver'])) {
-			// Private activities will not be modified
-			return $activity['receiver'];
-		}
-
-		// Add all owners of the referring item to the receivers
-		$original = $receivers = $activity['receiver'];
-		$items = Item::select(['uid'], ['uri' => $activity['object_id']]);
-		while ($item = DBA::fetch($items)) {
-			$receivers['uid:' . $item['uid']] = $item['uid'];
-		}
-		DBA::close($items);
-
-		if (count($original) != count($receivers)) {
-			Logger::info('Improved data', ['id' => $activity['id'], 'object' => $activity['object_id'], 'original' => $original, 'improved' => $receivers, 'callstack' => System::callstack()]);
-		}
-
-		return $receivers;
-	}
-
 	/**
 	 * Prepare the item array for an activity
 	 *
@@ -378,8 +447,6 @@ class Processor
 
 		$item['diaspora_signed_text'] = $activity['diaspora:like'] ?? '';
 
-		$activity['receiver'] = self::addReceivers($activity);
-
 		self::postItem($activity, $item);
 	}
 
@@ -392,20 +459,24 @@ class Processor
 	 */
 	public static function createEvent($activity, $item)
 	{
-		$event['summary']  = HTML::toBBCode($activity['name']);
-		$event['desc']     = HTML::toBBCode($activity['content']);
-		$event['start']    = $activity['start-time'];
-		$event['finish']   = $activity['end-time'];
-		$event['nofinish'] = empty($event['finish']);
-		$event['location'] = $activity['location'];
-		$event['adjust']   = true;
-		$event['cid']      = $item['contact-id'];
-		$event['uid']      = $item['uid'];
-		$event['uri']      = $item['uri'];
-		$event['edited']   = $item['edited'];
-		$event['private']  = $item['private'];
-		$event['guid']     = $item['guid'];
-		$event['plink']    = $item['plink'];
+		$event['summary']   = HTML::toBBCode($activity['name']);
+		$event['desc']      = HTML::toBBCode($activity['content']);
+		$event['start']     = $activity['start-time'];
+		$event['finish']    = $activity['end-time'];
+		$event['nofinish']  = empty($event['finish']);
+		$event['location']  = $activity['location'];
+		$event['adjust']    = true;
+		$event['cid']       = $item['contact-id'];
+		$event['uid']       = $item['uid'];
+		$event['uri']       = $item['uri'];
+		$event['edited']    = $item['edited'];
+		$event['private']   = $item['private'];
+		$event['guid']      = $item['guid'];
+		$event['plink']     = $item['plink'];
+		$event['network']   = $item['network'];
+		$event['protocol']  = $item['protocol'];
+		$event['direction'] = $item['direction'];
+		$event['source']    = $item['source'];
 
 		$condition = ['uri' => $item['uri'], 'uid' => $item['uid']];
 		$ev = DBA::selectFirst('event', ['id'], $condition);
@@ -427,22 +498,35 @@ class Processor
 	 */
 	private static function processContent($activity, $item)
 	{
-		$item['title'] = HTML::toBBCode($activity['name']);
-
-		if (!empty($activity['source'])) {
-			$item['body'] = $activity['source'];
+		if (!empty($activity['mediatype']) && ($activity['mediatype'] == 'text/markdown')) {
+			$item['title'] = Markdown::toBBCode($activity['name']);
+			$content = Markdown::toBBCode($activity['content']);
+		} elseif (!empty($activity['mediatype']) && ($activity['mediatype'] == 'text/bbcode')) {
+			$item['title'] = $activity['name'];
+			$content = $activity['content'];
 		} else {
+			// By default assume "text/html"
+			$item['title'] = HTML::toBBCode($activity['name']);
 			$content = HTML::toBBCode($activity['content']);
+		}
 
-			if (!empty($activity['emojis'])) {
-				$content = self::replaceEmojis($content, $activity['emojis']);
-			}
+		if (!empty($activity['languages'])) {
+			$item['language'] = self::processLanguages($activity['languages']);
+		}
+
+		if (!empty($activity['emojis'])) {
+			$content = self::replaceEmojis($content, $activity['emojis']);
+		}
 
-			$content = self::convertMentions($content);
+		$content = self::convertMentions($content);
 
+		if (!empty($activity['source'])) {
+			$item['body'] = $activity['source'];
+			$item['raw-body'] = $content;
+		} else {
 			if (empty($activity['directmessage']) && ($item['thr-parent'] != $item['uri']) && ($item['gravity'] == GRAVITY_COMMENT)) {
 				$item_private = !in_array(0, $activity['item_receiver']);
-				$parent = Item::selectFirst(['id', 'uri-id', 'private', 'author-link', 'alias'], ['uri' => $item['thr-parent']]);
+				$parent = Post::selectFirst(['id', 'uri-id', 'private', 'author-link', 'alias'], ['uri' => $item['thr-parent']]);
 				if (!DBA::isResult($parent)) {
 					Logger::warning('Unknown parent item.', ['uri' => $item['thr-parent']]);
 					return false;
@@ -455,7 +539,7 @@ class Processor
 				$content = self::removeImplicitMentionsFromBody($content, $parent);
 			}
 			$item['content-warning'] = HTML::toBBCode($activity['summary']);
-			$item['body'] = $content;
+			$item['raw-body'] = $item['body'] = $content;
 		}
 
 		self::storeFromBody($item);
@@ -520,6 +604,7 @@ class Processor
 		}
 
 		$stored = false;
+		ksort($activity['receiver']);
 
 		foreach ($activity['receiver'] as $receiver) {
 			if ($receiver == -1) {
@@ -548,10 +633,19 @@ class Processor
 				case Receiver::TARGET_ANSWER:
 					$item['post-type'] = Item::PT_COMMENT;
 					break;
+				case Receiver::TARGET_GLOBAL:
+					$item['post-type'] = Item::PT_GLOBAL;
+					break;
 				default:
 					$item['post-type'] = Item::PT_ARTICLE;
 			}
 
+			if (!empty($activity['from-relay'])) {
+				$item['post-type'] = Item::PT_RELAY;
+			} elseif (!empty($activity['thread-completion'])) {
+				$item['post-type'] = Item::PT_FETCHED;
+			}
+
 			if ($item['isForum'] ?? false) {
 				$item['contact-id'] = Contact::getIdForURL($activity['actor'], $receiver);
 			} else {
@@ -719,12 +813,13 @@ class Processor
 	/**
 	 * Fetches missing posts
 	 *
-	 * @param string $url message URL
-	 * @param array $child activity array with the child of this message
+	 * @param string $url         message URL
+	 * @param array  $child       activity array with the child of this message
+	 * @param string $relay_actor Relay actor
 	 * @return string fetched message URL
 	 * @throws \Friendica\Network\HTTPException\InternalServerErrorException
 	 */
-	public static function fetchMissingActivity(string $url, array $child = [])
+	public static function fetchMissingActivity(string $url, array $child = [], string $relay_actor = '')
 	{
 		if (!empty($child['receiver'])) {
 			$uid = ActivityPub\Receiver::getFirstUserFromReceivers($child['receiver']);
@@ -743,15 +838,26 @@ class Processor
 			return '';
 		}
 
-		if (!empty($child['author'])) {
-			$actor = $child['author'];
-		} elseif (!empty($object['actor'])) {
-			$actor = $object['actor'];
+		if (!empty($object['actor'])) {
+			$object_actor = $object['actor'];
 		} elseif (!empty($object['attributedTo'])) {
-			$actor = $object['attributedTo'];
+			$object_actor = $object['attributedTo'];
+			if (is_array($object_actor)) {
+				$compacted = JsonLD::compact($object);
+				$object_actor = JsonLD::fetchElement($compacted, 'as:attributedTo', '@id');
+			}
 		} else {
 			// Shouldn't happen
-			$actor = '';
+			$object_actor = '';
+		}
+
+		$signer = [$object_actor];
+
+		if (!empty($child['author'])) {
+			$actor = $child['author'];
+			$signer[] = $actor;
+		} else {
+			$actor = $object_actor;
 		}
 
 		if (!empty($object['published'])) {
@@ -763,7 +869,7 @@ class Processor
 		}
 
 		$activity = [];
-		$activity['@context'] = $object['@context'];
+		$activity['@context'] = $object['@context'] ?? ActivityPub::CONTEXT;
 		unset($object['@context']);
 		$activity['id'] = $object['id'];
 		$activity['to'] = $object['to'] ?? [];
@@ -775,15 +881,65 @@ class Processor
 
 		$ldactivity = JsonLD::compact($activity);
 
-		$ldactivity['thread-completion'] = true;
+		if (!empty($relay_actor)) {
+			$ldactivity['thread-completion'] = $ldactivity['from-relay'] = Contact::getIdForURL($relay_actor);
+		} elseif (!empty($child['thread-completion'])) {
+			$ldactivity['thread-completion'] = $child['thread-completion'];
+		} else {
+			$ldactivity['thread-completion'] = Contact::getIdForURL($actor);
+		}
+
+		if (!empty($relay_actor) && !self::acceptIncomingMessage($ldactivity, $object['id'])) {
+			return '';
+		}
 
-		ActivityPub\Receiver::processActivity($ldactivity, json_encode($activity), $uid, true, false, [$actor]);
+		ActivityPub\Receiver::processActivity($ldactivity, json_encode($activity), $uid, true, false, $signer);
 
 		Logger::notice('Activity had been fetched and processed.', ['url' => $url, 'object' => $activity['id']]);
 
 		return $activity['id'];
 	}
 
+	/**
+	 * Test if incoming relay messages should be accepted
+	 *
+	 * @param array $activity activity array
+	 * @param string $id      object ID
+	 * @return boolean true if message is accepted
+	 */
+	private static function acceptIncomingMessage(array $activity, string $id)
+	{
+		if (empty($activity['as:object'])) {
+			Logger::info('No object field in activity - accepted', ['id' => $id]);
+			return true;
+		}
+
+		$replyto = JsonLD::fetchElement($activity['as:object'], 'as:inReplyTo', '@id');
+		$uriid = ItemURI::getIdByURI($replyto);
+		if (Post::exists(['uri-id' => $uriid])) {
+			Logger::info('Post is a reply to an existing post - accepted', ['id' => $id, 'uri-id' => $uriid, 'replyto' => $replyto]);
+			return true;
+		}
+
+		$attributed_to = JsonLD::fetchElement($activity['as:object'], 'as:attributedTo', '@id');
+		$authorid = Contact::getIdForURL($attributed_to);
+
+		$body = HTML::toBBCode(JsonLD::fetchElement($activity['as:object'], 'as:content', '@value'));
+
+		$messageTags = [];
+		$tags = Receiver::processTags(JsonLD::fetchElementArray($activity['as:object'], 'as:tag') ?? []);
+		if (!empty($tags)) {
+			foreach ($tags as $tag) {
+				if ($tag['type'] != 'Hashtag') {
+					continue;
+				}
+				$messageTags[] = ltrim(mb_strtolower($tag['name']), '#');
+			}
+		}
+
+		return Relay::isSolicitedPost($messageTags, $body, $authorid, $id, Protocol::ACTIVITYPUB);
+	}
+
 	/**
 	 * perform a "follow" request
 	 *
@@ -807,20 +963,15 @@ class Processor
 		if (!empty($cid)) {
 			self::switchContact($cid);
 			DBA::update('contact', ['hub-verify' => $activity['id'], 'protocol' => Protocol::ACTIVITYPUB], ['id' => $cid]);
-			$contact = DBA::selectFirst('contact', [], ['id' => $cid, 'network' => Protocol::NATIVE_SUPPORT]);
-		} else {
-			$contact = [];
 		}
 
 		$item = ['author-id' => Contact::getIdForURL($activity['actor']),
 			'author-link' => $activity['actor']];
 
-		$note = Strings::escapeTags(trim($activity['content'] ?? ''));
-
 		// Ensure that the contact has got the right network type
 		self::switchContact($item['author-id']);
 
-		$result = Contact::addRelationship($owner, $contact, $item, false, $note);
+		$result = Contact::addRelationship($owner, [], $item, false, $activity['content'] ?? '');
 		if ($result === true) {
 			ActivityPub\Transmitter::sendContactAccept($item['author-link'], $activity['id'], $owner['uid']);
 		}
@@ -1039,7 +1190,7 @@ class Processor
 
 		$implicit_mentions = [];
 		if (empty($parent_author['url'])) {
-			Logger::notice('Author public contact unknown.', ['author-link' => $parent['author-link'], 'item-id' => $parent['id']]);
+			Logger::notice('Author public contact unknown.', ['author-link' => $parent['author-link'], 'parent-id' => $parent['id']]);
 		} else {
 			$implicit_mentions[] = $parent_author['url'];
 			$implicit_mentions[] = $parent_author['nurl'];