X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=src%2FProtocol%2FActivityPub%2FReceiver.php;h=4504cee4c49367b7e587d0b2d767ba21a0e55aff;hb=3d8e82d95d9cc76b45a8db301b22c4111f335e1c;hp=f094833060255c7acb9fe85d7df1f00eb52b82d5;hpb=1e305e748d0bb88a0da0b0d54c8f9d02f0117de2;p=friendica.git

diff --git a/src/Protocol/ActivityPub/Receiver.php b/src/Protocol/ActivityPub/Receiver.php
index f094833060..4504cee4c4 100644
--- a/src/Protocol/ActivityPub/Receiver.php
+++ b/src/Protocol/ActivityPub/Receiver.php
@@ -1,6 +1,6 @@
 <?php
 /**
- * @copyright Copyright (C) 2010-2021, the Friendica project
+ * @copyright Copyright (C) 2010-2022, the Friendica project
  *
  * @license GNU AGPL version 3 or any later version
  *
@@ -56,7 +56,7 @@ class Receiver
 {
 	const PUBLIC_COLLECTION = 'as:Public';
 	const ACCOUNT_TYPES = ['as:Person', 'as:Organization', 'as:Service', 'as:Group', 'as:Application'];
-	const CONTENT_TYPES = ['as:Note', 'as:Article', 'as:Video', 'as:Image', 'as:Event', 'as:Audio'];
+	const CONTENT_TYPES = ['as:Note', 'as:Article', 'as:Video', 'as:Image', 'as:Event', 'as:Audio', 'as:Page', 'as:Question'];
 	const ACTIVITY_TYPES = ['as:Like', 'as:Dislike', 'as:Accept', 'as:Reject', 'as:TentativeAccept'];
 
 	const TARGET_UNKNOWN = 0;
@@ -68,17 +68,6 @@ class Receiver
 	const TARGET_ANSWER = 6;
 	const TARGET_GLOBAL = 7;
 
-	/**
-	 * Checks if the web request is done for the AP protocol
-	 *
-	 * @return bool is it AP?
-	 */
-	public static function isRequest()
-	{
-		return stristr($_SERVER['HTTP_ACCEPT'] ?? '', 'application/activity+json') ||
-			stristr($_SERVER['HTTP_ACCEPT'] ?? '', 'application/ld+json');
-	}
-
 	/**
 	 * Checks incoming message from the inbox
 	 *
@@ -128,28 +117,28 @@ class Receiver
 		if (LDSignature::isSigned($activity)) {
 			$ld_signer = LDSignature::getSigner($activity);
 			if (empty($ld_signer)) {
-				Logger::log('Invalid JSON-LD signature from ' . $actor, Logger::DEBUG);
+				Logger::info('Invalid JSON-LD signature from ' . $actor);
 			} elseif ($ld_signer != $http_signer) {
 				$signer[] = $ld_signer;
 			}
 			if (!empty($ld_signer && ($actor == $http_signer))) {
-				Logger::log('The HTTP and the JSON-LD signature belong to ' . $ld_signer, Logger::DEBUG);
+				Logger::info('The HTTP and the JSON-LD signature belong to ' . $ld_signer);
 				$trust_source = true;
 			} elseif (!empty($ld_signer)) {
-				Logger::log('JSON-LD signature is signed by ' . $ld_signer, Logger::DEBUG);
+				Logger::info('JSON-LD signature is signed by ' . $ld_signer);
 				$trust_source = true;
 			} elseif ($actor == $http_signer) {
-				Logger::log('Bad JSON-LD signature, but HTTP signer fits the actor.', Logger::DEBUG);
+				Logger::info('Bad JSON-LD signature, but HTTP signer fits the actor.');
 				$trust_source = true;
 			} else {
-				Logger::log('Invalid JSON-LD signature and the HTTP signer is different.', Logger::DEBUG);
+				Logger::info('Invalid JSON-LD signature and the HTTP signer is different.');
 				$trust_source = false;
 			}
 		} elseif ($actor == $http_signer) {
-			Logger::log('Trusting post without JSON-LD signature, The actor fits the HTTP signer.', Logger::DEBUG);
+			Logger::info('Trusting post without JSON-LD signature, The actor fits the HTTP signer.');
 			$trust_source = true;
 		} else {
-			Logger::log('No JSON-LD signature, different actor.', Logger::DEBUG);
+			Logger::info('No JSON-LD signature, different actor.');
 			$trust_source = false;
 		}
 
@@ -321,7 +310,7 @@ class Receiver
 
 		$object_id = JsonLD::fetchElement($activity, 'as:object', '@id');
 		if (empty($object_id)) {
-			Logger::log('No object found', Logger::DEBUG);
+			Logger::info('No object found');
 			return [];
 		}
 
@@ -332,13 +321,36 @@ class Receiver
 
 		$object_type = self::fetchObjectType($activity, $object_id, $uid);
 
+		// Fetch the activity on Lemmy "Announce" messages (announces of activities)
+		if (($type == 'as:Announce') && in_array($object_type, array_merge(self::ACTIVITY_TYPES, ['as:Delete', 'as:Undo', 'as:Update']))) {
+			$data = ActivityPub::fetchContent($object_id, $uid);
+			if (!empty($data)) {
+				$type = $object_type;
+				$activity = JsonLD::compact($data);
+
+				// Some variables need to be refetched since the activity changed
+				$actor = JsonLD::fetchElement($activity, 'as:actor', '@id');
+				$object_id = JsonLD::fetchElement($activity, 'as:object', '@id');
+				$object_type = self::fetchObjectType($activity, $object_id, $uid);
+			}
+		}
+
+		// Any activities on account types must not be altered
+		if (in_array($object_type, self::ACCOUNT_TYPES)) {
+			$object_data = [];
+			$object_data['id'] = JsonLD::fetchElement($activity, '@id');
+			$object_data['object_id'] = JsonLD::fetchElement($activity, 'as:object', '@id');
+			$object_data['object_actor'] = JsonLD::fetchElement($activity['as:object'], 'as:actor', '@id');
+			$object_data['object_object'] = JsonLD::fetchElement($activity['as:object'], 'as:object');
+			$object_data['object_type'] = JsonLD::fetchElement($activity['as:object'], '@type');
+			$object_data['push'] = $push;
+		} elseif (in_array($type, ['as:Create', 'as:Update', 'as:Announce']) || strpos($type, '#emojiReaction')) {
 		// Fetch the content only on activities where this matters
 		// We can receive "#emojiReaction" when fetching content from Hubzilla systems
-		if (in_array($type, ['as:Create', 'as:Update', 'as:Announce']) || strpos($type, '#emojiReaction')) {
 			// Always fetch on "Announce"
 			$object_data = self::fetchObject($object_id, $activity['as:object'], $trust_source && ($type != 'as:Announce'), $uid);
 			if (empty($object_data)) {
-				Logger::log("Object data couldn't be processed", Logger::DEBUG);
+				Logger::info("Object data couldn't be processed");
 				return [];
 			}
 
@@ -358,7 +370,7 @@ class Receiver
 			}
 		} elseif (in_array($type, array_merge(self::ACTIVITY_TYPES, ['as:Follow'])) && in_array($object_type, self::CONTENT_TYPES)) {
 			// Create a mostly empty array out of the activity data (instead of the object).
-			// This way we later don't have to check for the existence of ech individual array element.
+			// This way we later don't have to check for the existence of each individual array element.
 			$object_data = self::processObject($activity);
 			$object_data['name'] = $type;
 			$object_data['author'] = JsonLD::fetchElement($activity, 'as:actor', '@id');
@@ -412,7 +424,7 @@ class Receiver
 			}
 		}
 
-		Logger::log('Processing ' . $object_data['type'] . ' ' . $object_data['object_type'] . ' ' . $object_data['id'], Logger::DEBUG);
+		Logger::info('Processing ' . $object_data['type'] . ' ' . $object_data['object_type'] . ' ' . $object_data['id']);
 
 		return $object_data;
 	}
@@ -484,6 +496,12 @@ class Receiver
 			return;
 		}
 
+		// Lemmy is announcing activities.
+		// We are changing the announces into regular activities.
+		if (($type == 'as:Announce') && in_array($object_data['type'] ?? '', array_merge(self::ACTIVITY_TYPES, ['as:Delete', 'as:Undo', 'as:Update']))) {
+			$type = $object_data['type'];
+		}
+
 		if (!$trust_source) {
 			Logger::info('Activity trust could not be achieved.',  ['id' => $object_data['object_id'], 'type' => $type, 'signer' => $signer, 'actor' => $actor, 'attributedTo' => $attributed_to]);
 			return;
@@ -617,7 +635,7 @@ class Receiver
 				break;
 
 			default:
-				Logger::log('Unknown activity: ' . $type . ' ' . $object_data['object_type'], Logger::DEBUG);
+				Logger::info('Unknown activity: ' . $type . ' ' . $object_data['object_type']);
 				break;
 		}
 	}
@@ -932,16 +950,16 @@ class Receiver
 			$data = ActivityPub::fetchContent($object_id, $uid);
 			if (!empty($data)) {
 				$object = JsonLD::compact($data);
-				Logger::log('Fetched content for ' . $object_id, Logger::DEBUG);
+				Logger::info('Fetched content for ' . $object_id);
 			} else {
-				Logger::log('Empty content for ' . $object_id . ', check if content is available locally.', Logger::DEBUG);
+				Logger::info('Empty content for ' . $object_id . ', check if content is available locally.');
 
 				$item = Post::selectFirst(Item::DELIVER_FIELDLIST, ['uri' => $object_id]);
 				if (!DBA::isResult($item)) {
-					Logger::log('Object with url ' . $object_id . ' was not found locally.', Logger::DEBUG);
+					Logger::info('Object with url ' . $object_id . ' was not found locally.');
 					return false;
 				}
-				Logger::log('Using already stored item for url ' . $object_id, Logger::DEBUG);
+				Logger::info('Using already stored item for url ' . $object_id);
 				$data = ActivityPub\Transmitter::createNote($item);
 				$object = JsonLD::compact($data);
 			}
@@ -957,7 +975,7 @@ class Receiver
 				return false;
 			}
 		} else {
-			Logger::log('Using original object for url ' . $object_id, Logger::DEBUG);
+			Logger::info('Using original object for url ' . $object_id);
 		}
 
 		$type = JsonLD::fetchElement($object, '@type');
@@ -966,6 +984,18 @@ class Receiver
 			return false;
 		}
 
+		// Lemmy is resharing "create" activities instead of content
+		// We fetch the content from the activity.
+		if (in_array($type, ['as:Create'])) {
+			$object = $object['as:object'];
+			$type = JsonLD::fetchElement($object, '@type');
+			if (empty($type)) {
+				Logger::info('Empty type');
+				return false;
+			}
+			$object_data = self::processObject($object);
+		}
+
 		// We currently don't handle 'pt:CacheFile', but with this step we avoid logging
 		if (in_array($type, self::CONTENT_TYPES) || ($type == 'pt:CacheFile')) {
 			$object_data = self::processObject($object);
@@ -984,7 +1014,7 @@ class Receiver
 			return self::fetchObject($object_id, [], false, $uid);
 		}
 
-		Logger::log('Unhandled object type: ' . $type, Logger::DEBUG);
+		Logger::info('Unhandled object type: ' . $type);
 		return false;
 	}
 
@@ -1340,6 +1370,14 @@ class Receiver
 		// An empty "id" field is translated to "./" by the compactor, so we have to check for this content
 		if (empty($object_data['reply-to-id']) || ($object_data['reply-to-id'] == './')) {
 			$object_data['reply-to-id'] = $object_data['id'];
+
+			// On activities the "reply to" is the id of the object it refers to
+			if (in_array($object_data['object_type'], self::ACTIVITY_TYPES)) {
+				$object_id = JsonLD::fetchElement($object, 'as:object', '@id');
+				if (!empty($object_id)) {
+					$object_data['reply-to-id'] = $object_id;
+				}
+			}
 		} else {
 			// Some systems (e.g. GNU Social) don't reply to the "id" field but the "uri" field.
 			$replyToId = Item::getURIByLink($object_data['reply-to-id']);
@@ -1389,7 +1427,6 @@ class Receiver
 		$object_data = self::getSource($object, $object_data);
 		$object_data['start-time'] = JsonLD::fetchElement($object, 'as:startTime', '@value');
 		$object_data['end-time'] = JsonLD::fetchElement($object, 'as:endTime', '@value');
-		$object_data['adjust'] = JsonLD::fetchElement($object, 'dfrn:adjust', '@value');
 		$object_data['location'] = $location;
 		$object_data['latitude'] = JsonLD::fetchElement($object, 'as:location', 'as:latitude', '@type', 'as:Place');
 		$object_data['latitude'] = JsonLD::fetchElement($object_data, 'latitude', '@value');