X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=src%2FProtocol%2FActivityPub%2FReceiver.php;h=4b8f1557b88e3aaaa29e85c01406dee915052021;hb=7f4d399fc8ca0abd4ab99f1ee9dfecd5fa175fde;hp=d452676b8b46d2d629f06ef56eb4aa9174b8a9e1;hpb=2c41ebbfaa45ea4417180b048cb8b8743f42c405;p=friendica.git diff --git a/src/Protocol/ActivityPub/Receiver.php b/src/Protocol/ActivityPub/Receiver.php index d452676b8b..4b8f1557b8 100644 --- a/src/Protocol/ActivityPub/Receiver.php +++ b/src/Protocol/ActivityPub/Receiver.php @@ -255,7 +255,7 @@ class Receiver * @throws \Friendica\Network\HTTPException\InternalServerErrorException * @throws \ImagickException */ - private static function fetchObjectType(array $activity, string $object_id, int $uid = 0) + public static function fetchObjectType(array $activity, string $object_id, int $uid = 0) { if (!empty($activity['as:object'])) { $object_type = JsonLD::fetchElement($activity['as:object'], '@type'); @@ -446,7 +446,7 @@ class Receiver } elseif (in_array($type, array_merge(self::ACTIVITY_TYPES, ['as:Announce', 'as:Follow'])) && in_array($object_type, self::CONTENT_TYPES)) { // Create a mostly empty array out of the activity data (instead of the object). // This way we later don't have to check for the existence of each individual array element. - $object_data = self::processObject($activity, false); + $object_data = self::processObject($activity); $object_data['name'] = $type; $object_data['author'] = JsonLD::fetchElement($activity, 'as:actor', '@id'); $object_data['object_id'] = $object_id; @@ -559,7 +559,7 @@ class Receiver return true; } - if ($type == 'as:View') { + if (!DI::config()->get('system', 'process_view') && ($type == 'as:View')) { Logger::info('View activities are ignored.', ['signer' => $signer, 'http_signer' => $http_signer]); return true; } @@ -1433,12 +1433,12 @@ class Receiver Logger::info('Empty type'); return false; } - $object_data = self::processObject($object, false); + $object_data = self::processObject($object); } // We currently don't handle 'pt:CacheFile', but with this step we avoid logging if (in_array($type, self::CONTENT_TYPES) || ($type == 'pt:CacheFile')) { - $object_data = self::processObject($object, false); + $object_data = self::processObject($object); if (!empty($data)) { $object_data['raw-object'] = json_encode($data); @@ -1843,17 +1843,45 @@ class Receiver * Fetches data from the object part of an activity * * @param array $object - * @param bool $c2s "true" = The object is a "client to server" object * * @return array|bool Object data or FALSE if $object does not contain @id element * @throws \Exception */ - private static function processObject(array $object, bool $c2s) + private static function processObject(array $object) { - if (!$c2s && !JsonLD::fetchElement($object, '@id')) { + if (!JsonLD::fetchElement($object, '@id')) { return false; } + $object_data = self::getObjectDataFromActivity($object); + + $receiverdata = self::getReceivers($object, $object_data['actor'] ?? '', $object_data['tags'], true, false); + $receivers = $reception_types = []; + foreach ($receiverdata as $key => $data) { + $receivers[$key] = $data['uid']; + $reception_types[$data['uid']] = $data['type'] ?? 0; + } + + $object_data['receiver_urls'] = self::getReceiverURL($object); + $object_data['receiver'] = $receivers; + $object_data['reception_type'] = $reception_types; + + $object_data['unlisted'] = in_array(-1, $object_data['receiver']); + unset($object_data['receiver'][-1]); + unset($object_data['reception_type'][-1]); + + return $object_data; + } + + /** + * Create an object data array from a given activity + * + * @param array $object + * + * @return array Object data + */ + public static function getObjectDataFromActivity(array $object): array + { $object_data = []; $object_data['object_type'] = JsonLD::fetchElement($object, '@type'); $object_data['id'] = JsonLD::fetchElement($object, '@id'); @@ -1982,25 +2010,6 @@ class Receiver $object_data['question'] = self::processQuestion($object); } - if ($c2s) { - $object_data['target'] = self::getTargets($object, $object_data['actor'] ?? ''); - $object_data['receiver'] = []; - } else { - $receiverdata = self::getReceivers($object, $object_data['actor'] ?? '', $object_data['tags'], true, false); - $receivers = $reception_types = []; - foreach ($receiverdata as $key => $data) { - $receivers[$key] = $data['uid']; - $reception_types[$data['uid']] = $data['type'] ?? 0; - } - - $object_data['receiver_urls'] = self::getReceiverURL($object); - $object_data['receiver'] = $receivers; - $object_data['reception_type'] = $reception_types; - - $object_data['unlisted'] = in_array(-1, $object_data['receiver']); - unset($object_data['receiver'][-1]); - unset($object_data['reception_type'][-1]); - } return $object_data; } @@ -2028,190 +2037,4 @@ class Receiver { return DBA::exists('arrived-activity', ['object-id' => $id]); } - - /** - * Process client to server activities - * - * @param array $activity - * @param integer $uid - * @param array $application - * @return array - */ - public static function processC2SActivity(array $activity, int $uid, array $application): array - { - $ldactivity = JsonLD::compact($activity); - if (empty($ldactivity)) { - Logger::notice('Invalid activity', ['activity' => $activity, 'uid' => $uid]); - return []; - } - - $type = JsonLD::fetchElement($ldactivity, '@type'); - if (!$type) { - Logger::notice('Empty type', ['activity' => $ldactivity, 'uid' => $uid]); - return []; - } - - $object_id = JsonLD::fetchElement($ldactivity, 'as:object', '@id') ?? ''; - $object_type = self::fetchObjectType($ldactivity, $object_id, $uid); - if (!$object_type && !$object_id) { - Logger::notice('Empty object type or id', ['activity' => $ldactivity, 'uid' => $uid]); - return []; - } - - Logger::debug('Processing activity', ['type' => $type, 'object_type' => $object_type, 'object_id' => $object_id, 'activity' => $ldactivity]); - return self::routeC2SActivities($type, $object_type, $object_id, $uid, $application, $ldactivity); - } - - /** - * Accumulate the targets and visibility of this post - * - * @param array $object - * @param string $actor - * @return array - */ - private static function getTargets(array $object, string $actor): array - { - $profile = APContact::getByURL($actor); - $followers = $profile['followers']; - - $targets = []; - - foreach (['as:to', 'as:cc', 'as:bto', 'as:bcc'] as $element) { - switch ($element) { - case 'as:to': - $type = self::TARGET_TO; - break; - case 'as:cc': - $type = self::TARGET_CC; - break; - case 'as:bto': - $type = self::TARGET_BTO; - break; - case 'as:bcc': - $type = self::TARGET_BCC; - break; - } - $receiver_list = JsonLD::fetchElementArray($object, $element, '@id'); - if (empty($receiver_list)) { - continue; - } - - foreach ($receiver_list as $receiver) { - if ($receiver == self::PUBLIC_COLLECTION) { - $targets[self::TARGET_GLOBAL] = ($element == 'as:to'); - continue; - } - - if ($receiver == $followers) { - $targets[self::TARGET_FOLLOWER] = true; - continue; - } - $targets[$type][] = Contact::getIdForURL($receiver); - } - } - return $targets; - } - - /** - * Route client to server activities - * - * @param string $type - * @param string $object_type - * @param string $object_id - * @param integer $uid - * @param array $application - * @param array $ldactivity - * @return array - */ - private static function routeC2SActivities(string $type, string $object_type, string $object_id, int $uid, array $application, array $ldactivity): array - { - switch ($type) { - case 'as:Create': - if (in_array($object_type, self::CONTENT_TYPES)) { - return self::createContent($uid, $application, $ldactivity); - } - break; - case 'as:Update': - if (in_array($object_type, self::CONTENT_TYPES) && !empty($object_id)) { - return self::updateContent($uid, $object_id, $application, $ldactivity); - } - break; - case 'as:Follow': - if (in_array($object_type, self::ACCOUNT_TYPES) && !empty($object_id)) { - return self::followAccount($uid, $object_id, $ldactivity); - } - break; - } - return []; - } - - /** - * Create a new post or comment - * - * @param integer $uid - * @param array $application - * @param array $ldactivity - * @return array - */ - private static function createContent(int $uid, array $application, array $ldactivity): array - { - $object_data = self::processObject($ldactivity['as:object'], true); - $item = Processor::processC2SContent($object_data, $application, $uid); - Logger::debug('Got data', ['item' => $item, 'object' => $object_data]); - - $id = Item::insert($item, true); - if (!empty($id)) { - $item = Post::selectFirst(['uri-id'], ['id' => $id]); - if (!empty($item['uri-id'])) { - return Transmitter::createActivityFromItem($id); - } - } - return []; - } - - /** - * Update an existing post or comment - * - * @param integer $uid - * @param string $object_id - * @param array $application - * @param array $ldactivity - * @return array - */ - private static function updateContent(int $uid, string $object_id, array $application, array $ldactivity):array - { - $id = Item::fetchByLink($object_id, $uid); - $original_post = Post::selectFirst(['uri-id'], ['uid' => $uid, 'origin' => true, 'id' => $id]); - if (empty($original_post)) { - Logger::debug('Item not found or does not belong to the user', ['id' => $id, 'uid' => $uid, 'object_id' => $object_id, 'activity' => $ldactivity]); - return []; - } - - $object_data = self::processObject($ldactivity['as:object'], true); - $item = Processor::processC2SContent($object_data, $application, $uid); - if (empty($item['title']) && empty($item['body'])) { - Logger::debug('Empty body and title', ['id' => $id, 'uid' => $uid, 'object_id' => $object_id, 'activity' => $ldactivity]); - return []; - } - $post = ['title' => $item['title'], 'body' => $item['body']]; - Logger::debug('Got data', ['id' => $id, 'uid' => $uid, 'item' => $post]); - Item::update($post, ['id' => $id]); - Item::updateDisplayCache($original_post['uri-id']); - - return Transmitter::createActivityFromItem($id); - } - - /** - * Follow a given account - * @todo Check the expected return value - * - * @param integer $uid - * @param string $object_id - * @param array $ldactivity - * @return array - */ - private static function followAccount(int $uid, string $object_id, array $ldactivity): array - { - return []; - } }