X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=src%2FProtocol%2FActivityPub%2FTransmitter.php;h=06dbaee71f81f1c619a9e857dde8dd80c465cb01;hb=57f6086fcd42e97069ebdf2c81bd481db4f3e2c4;hp=1032627b32911a92613036c56908558a5ad73aae;hpb=c7308d98fa6e40fbef4f212300cc0ef6739e9c00;p=friendica.git

diff --git a/src/Protocol/ActivityPub/Transmitter.php b/src/Protocol/ActivityPub/Transmitter.php
index 1032627b32..06dbaee71f 100644
--- a/src/Protocol/ActivityPub/Transmitter.php
+++ b/src/Protocol/ActivityPub/Transmitter.php
@@ -20,6 +20,8 @@ use Friendica\Model\Term;
 use Friendica\Model\User;
 use Friendica\Util\DateTimeFormat;
 use Friendica\Content\Text\BBCode;
+use Friendica\Content\Text\Plaintext;
+use Friendica\Util\XML;
 use Friendica\Util\JsonLD;
 use Friendica\Util\LDSignature;
 use Friendica\Model\Profile;
@@ -152,7 +154,7 @@ class Transmitter
 
 		$condition = ['uid' => 0, 'contact-id' => $public_contact, 'author-id' => $public_contact,
 			'private' => false, 'gravity' => [GRAVITY_PARENT, GRAVITY_COMMENT],
-			'deleted' => false, 'visible' => true];
+			'deleted' => false, 'visible' => true, 'moderated' => false];
 		$count = DBA::count('item', $condition);
 
 		$data = ['@context' => ActivityPub::CONTEXT];
@@ -186,6 +188,18 @@ class Transmitter
 		return $data;
 	}
 
+	/**
+	 * Return the service array containing information the used software and it's url
+	 *
+	 * @return array with service data
+	 */
+	private static function getService()
+	{
+		return ['type' => 'Service',
+			'name' =>  FRIENDICA_PLATFORM . " '" . FRIENDICA_CODENAME . "' " . FRIENDICA_VERSION . '-' . DB_UPDATE_VERSION,
+			'url' => BaseObject::getApp()->getBaseURL()];
+	}
+
 	/**
 	 * Return the ActivityPub profile of the given user
 	 *
@@ -242,10 +256,29 @@ class Transmitter
 		$data['icon'] = ['type' => 'Image',
 			'url' => $contact['avatar']];
 
+		$data['generator'] = self::getService();
+
 		// tags: https://kitty.town/@inmysocks/100656097926961126.json
 		return $data;
 	}
 
+	/**
+	 * @param string $username
+	 * @return array
+	 * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+	 */
+	public static function getDeletedUser($username)
+	{
+		return [
+			'@context' => ActivityPub::CONTEXT,
+			'id' => System::baseUrl() . '/profile/' . $username,
+			'type' => 'Tombstone',
+			'published' => DateTimeFormat::utcNow(DateTimeFormat::ATOM),
+			'updated' => DateTimeFormat::utcNow(DateTimeFormat::ATOM),
+			'deleted' => DateTimeFormat::utcNow(DateTimeFormat::ATOM),
+		];
+	}
+
 	/**
 	 * Returns an array with permissions of a given item array
 	 *
@@ -303,15 +336,16 @@ class Transmitter
 	/**
 	 * Creates an array of permissions from an item thread
 	 *
-	 * @param array   $item
-	 * @param boolean $blindcopy
-	 * @param boolean $last_id
+	 * @param array   $item       Item array
+	 * @param boolean $blindcopy  addressing via "bcc" or "cc"?
+	 * @param integer $last_id    Last item id for adding receivers
+	 * @param boolean $forum_mode "true" means that we are sending content to a forum
 	 *
 	 * @return array with permission data
 	 * @throws \Friendica\Network\HTTPException\InternalServerErrorException
 	 * @throws \ImagickException
 	 */
-	private static function createPermissionBlockForItem($item, $blindcopy, $last_id = 0)
+	private static function createPermissionBlockForItem($item, $blindcopy, $last_id = 0, $forum_mode = false)
 	{
 		if ($last_id == 0) {
 			$last_id = $item['id'];
@@ -343,7 +377,7 @@ class Transmitter
 			$actor_profile = APContact::getByURL($item['author-link']);
 		}
 
-		$terms = Term::tagArrayFromItemId($item['id'], TERM_MENTION);
+		$terms = Term::tagArrayFromItemId($item['id'], [Term::MENTION, Term::IMPLICIT_MENTION]);
 
 		if (!$item['private']) {
 			$data = array_merge($data, self::fetchPermissionBlockFromConversation($item));
@@ -362,16 +396,24 @@ class Transmitter
 			foreach ($terms as $term) {
 				$cid = Contact::getIdForURL($term['url'], $item['uid']);
 				if (!empty($cid) && in_array($cid, $receiver_list)) {
-					$contact = DBA::selectFirst('contact', ['url'], ['id' => $cid, 'network' => $networks]);
-					if (DBA::isResult($contact) && !empty($profile = APContact::getByURL($contact['url'], false))) {
+					$contact = DBA::selectFirst('contact', ['url', 'network', 'protocol'], ['id' => $cid]);
+					if (!DBA::isResult($contact) || (!in_array($contact['network'], $networks) && ($contact['protocol'] != Protocol::ACTIVITYPUB))) {
+						continue;
+					}
+
+					if (!empty($profile = APContact::getByURL($contact['url'], false))) {
 						$data['to'][] = $profile['url'];
 					}
 				}
 			}
 
 			foreach ($receiver_list as $receiver) {
-				$contact = DBA::selectFirst('contact', ['url', 'hidden'], ['id' => $receiver, 'network' => $networks]);
-				if (DBA::isResult($contact) && !empty($profile = APContact::getByURL($contact['url'], false))) {
+				$contact = DBA::selectFirst('contact', ['url', 'hidden', 'network', 'protocol'], ['id' => $receiver]);
+				if (!DBA::isResult($contact) || (!in_array($contact['network'], $networks) && ($contact['protocol'] != Protocol::ACTIVITYPUB))) {
+					continue;
+				}
+
+				if (!empty($profile = APContact::getByURL($contact['url'], false))) {
 					if ($contact['hidden'] || $always_bcc) {
 						$data['bcc'][] = $profile['url'];
 					} else {
@@ -381,46 +423,48 @@ class Transmitter
 			}
 		}
 
-		$parents = Item::select(['id', 'author-link', 'owner-link', 'gravity', 'uri'], ['parent' => $item['parent']]);
-		while ($parent = Item::fetch($parents)) {
-			if ($parent['gravity'] == GRAVITY_PARENT) {
-				$profile = APContact::getByURL($parent['owner-link'], false);
-				if (!empty($profile)) {
-					if ($item['gravity'] != GRAVITY_PARENT) {
-						// Comments to forums are directed to the forum
-						// But comments to forums aren't directed to the followers collection
-						if ($profile['type'] == 'Group') {
-							$data['to'][] = $profile['url'];
+		if (!empty($item['parent'])) {
+			$parents = Item::select(['id', 'author-link', 'owner-link', 'gravity', 'uri'], ['parent' => $item['parent']]);
+			while ($parent = Item::fetch($parents)) {
+				if ($parent['gravity'] == GRAVITY_PARENT) {
+					$profile = APContact::getByURL($parent['owner-link'], false);
+					if (!empty($profile)) {
+						if ($item['gravity'] != GRAVITY_PARENT) {
+							// Comments to forums are directed to the forum
+							// But comments to forums aren't directed to the followers collection
+							if ($profile['type'] == 'Group') {
+								$data['to'][] = $profile['url'];
+							} else {
+								$data['cc'][] = $profile['url'];
+								if (!$item['private']) {
+									$data['cc'][] = $actor_profile['followers'];
+								}
+							}
 						} else {
-							$data['cc'][] = $profile['url'];
-							if (!$item['private']) {
+							// Public thread parent post always are directed to the followers
+							if (!$item['private'] && !$forum_mode) {
 								$data['cc'][] = $actor_profile['followers'];
 							}
 						}
-					} else {
-						// Public thread parent post always are directed to the followes
-						if (!$item['private']) {
-							$data['cc'][] = $actor_profile['followers'];
-						}
 					}
 				}
-			}
 
-			// Don't include data from future posts
-			if ($parent['id'] >= $last_id) {
-				continue;
-			}
+				// Don't include data from future posts
+				if ($parent['id'] >= $last_id) {
+					continue;
+				}
 
-			$profile = APContact::getByURL($parent['author-link'], false);
-			if (!empty($profile)) {
-				if (($profile['type'] == 'Group') || ($parent['uri'] == $item['thr-parent'])) {
-					$data['to'][] = $profile['url'];
-				} else {
-					$data['cc'][] = $profile['url'];
+				$profile = APContact::getByURL($parent['author-link'], false);
+				if (!empty($profile)) {
+					if (($profile['type'] == 'Group') || ($parent['uri'] == $item['thr-parent'])) {
+						$data['to'][] = $profile['url'];
+					} else {
+						$data['cc'][] = $profile['url'];
+					}
 				}
 			}
+			DBA::close($parents);
 		}
-		DBA::close($parents);
 
 		$data['to'] = array_unique($data['to']);
 		$data['cc'] = array_unique($data['cc']);
@@ -463,6 +507,18 @@ class Transmitter
 		return $receivers;
 	}
 
+	/**
+	 * Check if an inbox is archived
+	 *
+	 * @param string $url Inbox url
+	 *
+	 * @return boolean "true" if inbox is archived
+	 */
+	private static function archivedInbox($url)
+	{
+		return DBA::exists('inbox-status', ['url' => $url, 'archive' => true]);
+	}
+
 	/**
 	 * Fetches a list of inboxes of followers of a given user
 	 *
@@ -485,14 +541,18 @@ class Transmitter
 			$networks = [Protocol::ACTIVITYPUB, Protocol::OSTATUS];
 		}
 
-		$condition = ['uid' => $uid, 'network' => $networks, 'archive' => false, 'pending' => false];
+		$condition = ['uid' => $uid, 'archive' => false, 'pending' => false];
 
 		if (!empty($uid)) {
 			$condition['rel'] = [Contact::FOLLOWER, Contact::FRIEND];
 		}
 
-		$contacts = DBA::select('contact', ['url'], $condition);
+		$contacts = DBA::select('contact', ['url', 'network', 'protocol'], $condition);
 		while ($contact = DBA::fetch($contacts)) {
+			if (!in_array($contact['network'], $networks) && ($contact['protocol'] != Protocol::ACTIVITYPUB)) {
+				continue;
+			}
+
 			if (Network::isUrlBlocked($contact['url'])) {
 				continue;
 			}
@@ -504,7 +564,9 @@ class Transmitter
 				} else {
 					$target = $profile['sharedinbox'];
 				}
-				$inboxes[$target] = $target;
+				if (!self::archivedInbox($target)) {
+					$inboxes[$target] = $target;
+				}
 			}
 		}
 		DBA::close($contacts);
@@ -515,18 +577,18 @@ class Transmitter
 	/**
 	 * Fetches an array of inboxes for the given item and user
 	 *
-	 * @param array   $item
-	 * @param integer $uid      User ID
-	 * @param boolean $personal fetch personal inboxes
-	 * @param integer $last_id Last item id for adding receivers
-	 *
+	 * @param array   $item       Item array
+	 * @param integer $uid        User ID
+	 * @param boolean $personal   fetch personal inboxes
+	 * @param integer $last_id    Last item id for adding receivers
+	 * @param boolean $forum_mode "true" means that we are sending content to a forum
 	 * @return array with inboxes
 	 * @throws \Friendica\Network\HTTPException\InternalServerErrorException
 	 * @throws \ImagickException
 	 */
-	public static function fetchTargetInboxes($item, $uid, $personal = false, $last_id = 0)
+	public static function fetchTargetInboxes($item, $uid, $personal = false, $last_id = 0, $forum_mode = false)
 	{
-		$permissions = self::createPermissionBlockForItem($item, true, $last_id);
+		$permissions = self::createPermissionBlockForItem($item, true, $last_id, $forum_mode);
 		if (empty($permissions)) {
 			return [];
 		}
@@ -561,7 +623,9 @@ class Transmitter
 						} else {
 							$target = $profile['sharedinbox'];
 						}
-						$inboxes[$target] = $target;
+						if (!self::archivedInbox($target)) {
+							$inboxes[$target] = $target;
+						}
 					}
 				}
 			}
@@ -570,6 +634,106 @@ class Transmitter
 		return $inboxes;
 	}
 
+	/**
+	 * Creates an array in the structure of the item table for a given mail id
+	 *
+	 * @param integer $mail_id
+	 *
+	 * @return array
+	 * @throws \Exception
+	 */
+	public static function ItemArrayFromMail($mail_id)
+	{
+		$mail = DBA::selectFirst('mail', [], ['id' => $mail_id]);
+
+		$reply = DBA::selectFirst('mail', ['uri'], ['parent-uri' => $mail['parent-uri'], 'reply' => false]);
+
+		// Making the post more compatible for Mastodon by:
+		// - Making it a note and not an article (no title)
+		// - Moving the title into the "summary" field that is used as a "content warning"
+		$mail['body'] = '[abstract]' . $mail['title'] . "[/abstract]\n" . $mail['body'];
+		$mail['title'] = '';
+
+		$mail['author-link'] = $mail['owner-link'] = $mail['from-url'];
+		$mail['allow_cid'] = '<'.$mail['contact-id'].'>';
+		$mail['allow_gid'] = '';
+		$mail['deny_cid'] = '';
+		$mail['deny_gid'] = '';
+		$mail['private'] = true;
+		$mail['deleted'] = false;
+		$mail['edited'] = $mail['created'];
+		$mail['plink'] = $mail['uri'];
+		$mail['thr-parent'] = $reply['uri'];
+		$mail['gravity'] = ($mail['reply'] ? GRAVITY_COMMENT: GRAVITY_PARENT);
+
+		$mail['event-type'] = '';
+		$mail['attach'] = '';
+
+		$mail['parent'] = 0;
+
+		return $mail;
+	}
+
+	/**
+	 * Creates an activity array for a given mail id
+	 *
+	 * @param integer $mail_id
+	 * @param boolean $object_mode Is the activity item is used inside another object?
+	 *
+	 * @return array of activity
+	 * @throws \Exception
+	 */
+	public static function createActivityFromMail($mail_id, $object_mode = false)
+	{
+		$mail = self::ItemArrayFromMail($mail_id);
+		$object = self::createNote($mail);
+
+		$object['to'] = $object['cc'];
+		unset($object['cc']);
+
+		$object['tag'] = [['type' => 'Mention', 'href' => $object['to'][0], 'name' => 'test']];
+
+		if (!$object_mode) {
+			$data = ['@context' => ActivityPub::CONTEXT];
+		} else {
+			$data = [];
+		}
+
+		$data['id'] = $mail['uri'] . '#Create';
+		$data['type'] = 'Create';
+		$data['actor'] = $mail['author-link'];
+		$data['published'] = DateTimeFormat::utc($mail['created'] . '+00:00', DateTimeFormat::ATOM);
+		$data['instrument'] = self::getService();
+		$data = array_merge($data, self::createPermissionBlockForItem($mail, true));
+
+		if (empty($data['to']) && !empty($data['cc'])) {
+			$data['to'] = $data['cc'];
+		}
+
+		if (empty($data['to']) && !empty($data['bcc'])) {
+			$data['to'] = $data['bcc'];
+		}
+
+		unset($data['cc']);
+		unset($data['bcc']);
+
+		$object['to'] = $data['to'];
+		unset($object['cc']);
+		unset($object['bcc']);
+
+		$data['directMessage'] = true;
+
+		$data['object'] = $object;
+
+		$owner = User::getOwnerDataById($mail['uid']);
+
+		if (!$object_mode && !empty($owner)) {
+			return LDSignature::sign($data, $owner);
+		} else {
+			return $data;
+		}
+	}
+
 	/**
 	 * Returns the activity type of a given item
 	 *
@@ -609,6 +773,8 @@ class Transmitter
 			$type = 'TentativeAccept';
 		} elseif ($item['verb'] == ACTIVITY_FOLLOW) {
 			$type = 'Follow';
+		} elseif ($item['verb'] == ACTIVITY_TAG) {
+			$type = 'Add';
 		} else {
 			$type = '';
 		}
@@ -659,7 +825,7 @@ class Transmitter
 			return false;
 		}
 
-		if ($item['wall']) {
+		if ($item['wall'] && ($item['uri'] == $item['parent-uri'])) {
 			$owner = User::getOwnerDataById($item['uid']);
 			if (($owner['account-type'] == User::ACCOUNT_TYPE_COMMUNITY) && ($item['author-link'] != $owner['url'])) {
 				$type = 'Announce';
@@ -674,7 +840,7 @@ class Transmitter
 			$condition = ['item-uri' => $item['uri'], 'protocol' => Conversation::PARCEL_ACTIVITYPUB];
 			$conversation = DBA::selectFirst('conversation', ['source'], $condition);
 			if (DBA::isResult($conversation)) {
-				$data = json_decode($conversation['source']);
+				$data = json_decode($conversation['source'], true);
 				if (!empty($data)) {
 					return $data;
 				}
@@ -697,16 +863,23 @@ class Transmitter
 
 		$data['id'] = $item['uri'] . '#' . $type;
 		$data['type'] = $type;
-		$data['actor'] = $item['owner-link'];
+
+		if (Item::isForumPost($item) && ($type != 'Announce')) {
+			$data['actor'] = $item['author-link'];
+		} else {
+			$data['actor'] = $item['owner-link'];
+		}
 
 		$data['published'] = DateTimeFormat::utc($item['created'] . '+00:00', DateTimeFormat::ATOM);
 
-		$data['instrument'] = ['type' => 'Service', 'name' => BaseObject::getApp()->getUserAgent()];
+		$data['instrument'] = self::getService();
 
 		$data = array_merge($data, self::createPermissionBlockForItem($item, false));
 
 		if (in_array($data['type'], ['Create', 'Update', 'Delete'])) {
 			$data['object'] = self::createNote($item);
+		} elseif ($data['type'] == 'Add') {
+			$data = self::createAddTag($item, $data);
 		} elseif ($data['type'] == 'Announce') {
 			$data = self::createAnnounce($item, $data);
 		} elseif ($data['type'] == 'Follow') {
@@ -807,12 +980,12 @@ class Transmitter
 	{
 		$tags = [];
 
-		$terms = Term::tagArrayFromItemId($item['id']);
+		$terms = Term::tagArrayFromItemId($item['id'], [Term::HASHTAG, Term::MENTION, Term::IMPLICIT_MENTION]);
 		foreach ($terms as $term) {
-			if ($term['type'] == TERM_HASHTAG) {
+			if ($term['type'] == Term::HASHTAG) {
 				$url = System::baseUrl() . '/search?tag=' . urlencode($term['term']);
 				$tags[] = ['type' => 'Hashtag', 'href' => $url, 'name' => '#' . $term['term']];
-			} elseif ($term['type'] == TERM_MENTION) {
+			} elseif ($term['type'] == Term::MENTION || $term['type'] == Term::IMPLICIT_MENTION) {
 				$contact = Contact::getDetailsByURL($term['url']);
 				if (!empty($contact['addr'])) {
 					$mention = '@' . $contact['addr'];
@@ -1014,7 +1187,7 @@ class Transmitter
 			return $data;
 		}
 
-		$data['summary'] = null; // Ignore by now
+		$data['summary'] = BBCode::toPlaintext(BBCode::getAbstract($item['body'], Protocol::ACTIVITYPUB));
 
 		if ($item['uri'] != $item['thr-parent']) {
 			$data['inReplyTo'] = $item['thr-parent'];
@@ -1048,6 +1221,8 @@ class Transmitter
 
 		if ($type == 'Note') {
 			$body = self::removePictures($body);
+		} elseif (($type == 'Article') && empty($data['summary'])) {
+			$data['summary'] = BBCode::toPlaintext(Plaintext::shorten(self::removePictures($body), 1000));
 		}
 
 		if ($type == 'Event') {
@@ -1081,6 +1256,30 @@ class Transmitter
 		return $data;
 	}
 
+	/**
+	 * Creates an an "add tag" entry
+	 *
+	 * @param array $item
+	 * @param array $data activity data
+	 *
+	 * @return array with activity data for adding tags
+	 * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+	 * @throws \ImagickException
+	 */
+	private static function createAddTag($item, $data)
+	{
+		$object = XML::parseString($item['object'], false);
+		$target = XML::parseString($item["target"], false);
+
+		$data['diaspora:guid'] = $item['guid'];
+		$data['actor'] = $item['author-link'];
+		$data['target'] = (string)$target->id;
+		$data['summary'] = BBCode::toPlaintext($item['body']);
+		$data['object'] = ['id' => (string)$object->id, 'type' => 'tag', 'name' => (string)$object->title, 'content' => (string)$object->content];
+
+		return $data;
+	}
+
 	/**
 	 * Creates an announce object entry
 	 *
@@ -1157,7 +1356,7 @@ class Transmitter
 			'actor' => $owner['url'],
 			'object' => $suggestion['url'],
 			'content' => $suggestion['note'],
-			'instrument' => ['type' => 'Service', 'name' => BaseObject::getApp()->getUserAgent()],
+			'instrument' => self::getService(),
 			'to' => [ActivityPub::PUBLIC_COLLECTION],
 			'cc' => []];
 
@@ -1186,7 +1385,7 @@ class Transmitter
 			'actor' => $owner['url'],
 			'object' => $owner['url'],
 			'published' => DateTimeFormat::utcNow(DateTimeFormat::ATOM),
-			'instrument' => ['type' => 'Service', 'name' => BaseObject::getApp()->getUserAgent()],
+			'instrument' => self::getService(),
 			'to' => [ActivityPub::PUBLIC_COLLECTION],
 			'cc' => []];
 
@@ -1209,13 +1408,23 @@ class Transmitter
 	{
 		$owner = User::getOwnerDataById($uid);
 
+		if (empty($owner)) {
+			Logger::error('No owner data found, the deletion message cannot be processed.', ['user' => $uid]);
+			return false;
+		}
+
+		if (empty($owner['uprvkey'])) {
+			Logger::error('No private key for owner found, the deletion message cannot be processed.', ['user' => $uid]);
+			return false;
+		}
+
 		$data = ['@context' => ActivityPub::CONTEXT,
 			'id' => System::baseUrl() . '/activity/' . System::createGUID(),
 			'type' => 'Delete',
 			'actor' => $owner['url'],
 			'object' => $owner['url'],
 			'published' => DateTimeFormat::utcNow(DateTimeFormat::ATOM),
-			'instrument' => ['type' => 'Service', 'name' => BaseObject::getApp()->getUserAgent()],
+			'instrument' => self::getService(),
 			'to' => [ActivityPub::PUBLIC_COLLECTION],
 			'cc' => []];
 
@@ -1246,7 +1455,7 @@ class Transmitter
 			'actor' => $owner['url'],
 			'object' => self::getProfile($uid),
 			'published' => DateTimeFormat::utcNow(DateTimeFormat::ATOM),
-			'instrument' => ['type' => 'Service', 'name' => BaseObject::getApp()->getUserAgent()],
+			'instrument' => self::getService(),
 			'to' => [$profile['followers']],
 			'cc' => []];
 
@@ -1282,7 +1491,7 @@ class Transmitter
 			'type' => $activity,
 			'actor' => $owner['url'],
 			'object' => $profile['url'],
-			'instrument' => ['type' => 'Service', 'name' => BaseObject::getApp()->getUserAgent()],
+			'instrument' => self::getService(),
 			'to' => [$profile['url']]];
 
 		Logger::log('Sending activity ' . $activity . ' to ' . $target . ' for user ' . $uid, Logger::DEBUG);
@@ -1317,6 +1526,13 @@ class Transmitter
 			$uid = $first_user['uid'];
 		}
 
+		$condition = ['verb' => ACTIVITY_FOLLOW, 'uid' => 0, 'parent-uri' => $object,
+			'author-id' => Contact::getPublicIdByUserId($uid)];
+		if (Item::exists($condition)) {
+			Logger::log('Follow for ' . $object . ' for user ' . $uid . ' does already exist.', Logger::DEBUG);
+			return false;
+		}
+
 		$owner = User::getOwnerDataById($uid);
 
 		$data = ['@context' => ActivityPub::CONTEXT,
@@ -1324,7 +1540,7 @@ class Transmitter
 			'type' => 'Follow',
 			'actor' => $owner['url'],
 			'object' => $object,
-			'instrument' => ['type' => 'Service', 'name' => BaseObject::getApp()->getUserAgent()],
+			'instrument' => self::getService(),
 			'to' => [$profile['url']]];
 
 		Logger::log('Sending follow ' . $object . ' to ' . $target . ' for user ' . $uid, Logger::DEBUG);
@@ -1351,13 +1567,16 @@ class Transmitter
 			'id' => System::baseUrl() . '/activity/' . System::createGUID(),
 			'type' => 'Accept',
 			'actor' => $owner['url'],
-			'object' => ['id' => $id, 'type' => 'Follow',
+			'object' => [
+				'id' => (string)$id,
+				'type' => 'Follow',
 				'actor' => $profile['url'],
-				'object' => $owner['url']],
-			'instrument' => ['type' => 'Service', 'name' => BaseObject::getApp()->getUserAgent()],
+				'object' => $owner['url']
+			],
+			'instrument' => self::getService(),
 			'to' => [$profile['url']]];
 
-		Logger::log('Sending accept to ' . $target . ' for user ' . $uid . ' with id ' . $id, Logger::DEBUG);
+		Logger::debug('Sending accept to ' . $target . ' for user ' . $uid . ' with id ' . $id);
 
 		$signed = LDSignature::sign($data, $owner);
 		HTTPSignature::transmit($signed, $profile['inbox'], $uid);
@@ -1381,13 +1600,16 @@ class Transmitter
 			'id' => System::baseUrl() . '/activity/' . System::createGUID(),
 			'type' => 'Reject',
 			'actor' => $owner['url'],
-			'object' => ['id' => $id, 'type' => 'Follow',
+			'object' => [
+				'id' => (string)$id,
+				'type' => 'Follow',
 				'actor' => $profile['url'],
-				'object' => $owner['url']],
-			'instrument' => ['type' => 'Service', 'name' => BaseObject::getApp()->getUserAgent()],
+				'object' => $owner['url']
+			],
+			'instrument' => self::getService(),
 			'to' => [$profile['url']]];
 
-		Logger::log('Sending reject to ' . $target . ' for user ' . $uid . ' with id ' . $id, Logger::DEBUG);
+		Logger::debug('Sending reject to ' . $target . ' for user ' . $uid . ' with id ' . $id);
 
 		$signed = LDSignature::sign($data, $owner);
 		HTTPSignature::transmit($signed, $profile['inbox'], $uid);
@@ -1421,7 +1643,7 @@ class Transmitter
 			'object' => ['id' => $object_id, 'type' => 'Follow',
 				'actor' => $owner['url'],
 				'object' => $profile['url']],
-			'instrument' => ['type' => 'Service', 'name' => BaseObject::getApp()->getUserAgent()],
+			'instrument' => self::getService(),
 			'to' => [$profile['url']]];
 
 		Logger::log('Sending undo to ' . $target . ' for user ' . $uid . ' with id ' . $id, Logger::DEBUG);
@@ -1432,6 +1654,10 @@ class Transmitter
 
 	private static function prependMentions($body, array $permission_block)
 	{
+		if (Config::get('system', 'disable_implicit_mentions')) {
+			return $body;
+		}
+
 		$mentions = [];
 
 		foreach ($permission_block['to'] as $profile_url) {