X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=src%2FProtocol%2FDiaspora.php;h=f8e4f35c18d62f5d05a3df011ed4280295488312;hb=e36f2bb1fb3439e9993c7568e57140c4f954b772;hp=bb1a3f46e95bc1e27f750283e8603d678c347c5a;hpb=0091d318e52f621f1af15e268b578798b972a25d;p=friendica.git diff --git a/src/Protocol/Diaspora.php b/src/Protocol/Diaspora.php index bb1a3f46e9..f8e4f35c18 100644 --- a/src/Protocol/Diaspora.php +++ b/src/Protocol/Diaspora.php @@ -1,6 +1,6 @@ children(NAMESPACE_SALMON_ME); // Not sure if this cleaning is needed - $data = str_replace(array(" ", "\t", "\r", "\n"), array("", "", "", ""), $base->data); + $data = str_replace([" ", "\t", "\r", "\n"], ["", "", "", ""], $base->data); // Build the signed data $type = $base->data[0]->attributes()->type[0]; @@ -273,15 +321,15 @@ class Diaspora $author_addr = base64_decode($key_id); $key = self::key($author_addr); - $verify = rsa_verify($signed_data, $signature, $key); + $verify = Crypto::rsaVerify($signed_data, $signature, $key); if (!$verify) { logger('Message did not verify. Discarding.'); http_status_exit(400); } - return array('message' => (string)base64url_decode($base->data), + return ['message' => (string)base64url_decode($base->data), 'author' => unxmlify($author_addr), - 'key' => (string)$key); + 'key' => (string)$key]; } /** @@ -364,7 +412,7 @@ class Diaspora // unpack the data // strip whitespace so our data element will return to one big base64 blob - $data = str_replace(array(" ", "\t", "\r", "\n"), array("", "", "", ""), $base->data); + $data = str_replace([" ", "\t", "\r", "\n"], ["", "", "", ""], $base->data); // stash away some other stuff for later @@ -406,7 +454,7 @@ class Diaspora http_status_exit(400); } - $verify = rsa_verify($signed_data, $signature, $key); + $verify = Crypto::rsaVerify($signed_data, $signature, $key); if (!$verify) { logger('Message did not verify. Discarding.'); @@ -415,9 +463,9 @@ class Diaspora logger('Message verified.'); - return array('message' => (string)$inner_decrypted, + return ['message' => (string)$inner_decrypted, 'author' => unxmlify($author_link), - 'key' => (string)$key); + 'key' => (string)$key]; } @@ -456,11 +504,11 @@ class Diaspora // Process item retractions. This has to be done separated from the other stuff, // since retractions for comments could come even from non followers. - if (!empty($fields) && in_array($fields->getName(), array('retraction'))) { + if (!empty($fields) && in_array($fields->getName(), ['retraction'])) { $target = notags(unxmlify($fields->target_type)); - if (in_array($target, array("Comment", "Like", "Post", "Reshare", "StatusMessage"))) { + if (in_array($target, ["Comment", "Like", "Post", "Reshare", "StatusMessage"])) { logger('processing retraction for '.$target, LOGGER_DEBUG); - $importer = array("uid" => 0, "page-flags" => PAGE_FREELOVE); + $importer = ["uid" => 0, "page-flags" => PAGE_FREELOVE]; $message_id = self::dispatch($importer, $msg, $fields); return $message_id; } @@ -484,7 +532,7 @@ class Diaspora logger("Unwanted message from ".$msg["author"]." send by ".$_SERVER["REMOTE_ADDR"]." with ".$_SERVER["HTTP_USER_AGENT"].": ".print_r($msg, true), LOGGER_DEBUG); } else { // Use a dummy importer to import the data for the public copy - $importer = array("uid" => 0, "page-flags" => PAGE_FREELOVE); + $importer = ["uid" => 0, "page-flags" => PAGE_FREELOVE]; $message_id = self::dispatch($importer, $msg, $fields); } @@ -541,7 +589,7 @@ class Diaspora case "message": return self::receiveMessage($importer, $fields); - case "participation": // Not implemented + case "participation": return self::receiveParticipation($importer, $fields); case "photo": // Not implemented @@ -609,7 +657,7 @@ class Diaspora // All retractions are handled identically from now on. // In the new version there will only be "retraction". - if (in_array($type, array("signed_retraction", "relayable_retraction"))) + if (in_array($type, ["signed_retraction", "relayable_retraction"])) $type = "retraction"; if ($type == "request") { @@ -629,7 +677,7 @@ class Diaspora if ($fieldname == "participant_handles") { $fieldname = "participants"; } - if (in_array($type, array("like", "participation"))) { + if (in_array($type, ["like", "participation"])) { if ($fieldname == "target_type") { $fieldname = "parent_type"; } @@ -662,15 +710,14 @@ class Diaspora $author_signature = base64_decode($entry); } elseif (($fieldname == "parent_author_signature") && ($entry != "")) { $parent_author_signature = base64_decode($entry); - } elseif (!in_array($fieldname, array("author_signature", "parent_author_signature", "target_author_signature"))) { + } elseif (!in_array($fieldname, ["author_signature", "parent_author_signature", "target_author_signature"])) { if ($signed_data != "") { $signed_data .= ";"; - $signed_data_parent .= ";"; } $signed_data .= $entry; } - if (!in_array($fieldname, array("parent_author_signature", "target_author_signature")) + if (!in_array($fieldname, ["parent_author_signature", "target_author_signature"]) || ($orig_type == "relayable_retraction") ) { XML::copy($entry, $fields, $fieldname); @@ -678,7 +725,7 @@ class Diaspora } // This is something that shouldn't happen at all. - if (in_array($type, array("status_message", "reshare", "profile"))) { + if (in_array($type, ["status_message", "reshare", "profile"])) { if ($msg["author"] != $fields->author) { logger("Message handle is not the same as envelope sender. Quitting this message."); return false; @@ -686,8 +733,8 @@ class Diaspora } // Only some message types have signatures. So we quit here for the other types. - if (!in_array($type, array("comment", "like"))) { - return array("fields" => $fields, "relayed" => false); + if (!in_array($type, ["comment", "like"])) { + return ["fields" => $fields, "relayed" => false]; } // No author_signature? This is a must, so we quit. if (!isset($author_signature)) { @@ -700,7 +747,7 @@ class Diaspora $key = self::key($msg["author"]); - if (!rsa_verify($signed_data, $parent_author_signature, $key, "sha256")) { + if (!Crypto::rsaVerify($signed_data, $parent_author_signature, $key, "sha256")) { logger("No valid parent author signature for parent author ".$msg["author"]. " in type ".$type." - signed data: ".$signed_data." - Message: ".$msg["message"]." - Signature ".$parent_author_signature, LOGGER_DEBUG); return false; } @@ -710,11 +757,11 @@ class Diaspora $key = self::key($fields->author); - if (!rsa_verify($signed_data, $author_signature, $key, "sha256")) { + if (!Crypto::rsaVerify($signed_data, $author_signature, $key, "sha256")) { logger("No valid author signature for author ".$fields->author. " in type ".$type." - signed data: ".$signed_data." - Message: ".$msg["message"]." - Signature ".$author_signature, LOGGER_DEBUG); return false; } else { - return array("fields" => $fields, "relayed" => $relayed); + return ["fields" => $fields, "relayed" => $relayed]; } } @@ -928,10 +975,12 @@ class Diaspora /** * @brief Get a contact id for a given handle * + * @todo Move to Friendica\Model\Contact + * * @param int $uid The user id * @param string $handle The handle in the format user@domain.tld * - * @return The contact id + * @return int Contact id */ private static function contactByHandle($uid, $handle) { @@ -993,16 +1042,18 @@ class Diaspora * That makes us friends. * Normally this should have handled by getting a request - but this could get lost */ - if ($contact["rel"] == CONTACT_IS_FOLLOWER && in_array($importer["page-flags"], array(PAGE_FREELOVE))) { - dba::update( - 'contact', - array('rel' => CONTACT_IS_FRIEND, 'writable' => true), - array('id' => $contact["id"], 'uid' => $contact["uid"]) - ); - - $contact["rel"] = CONTACT_IS_FRIEND; - logger("defining user ".$contact["nick"]." as friend"); - } + // It is deactivated by now, due to side effects. See issue https://github.com/friendica/friendica/pull/4033 + // It is not removed by now. Possibly the code is needed? + //if (!$is_comment && $contact["rel"] == CONTACT_IS_FOLLOWER && in_array($importer["page-flags"], array(PAGE_FREELOVE))) { + // dba::update( + // 'contact', + // array('rel' => CONTACT_IS_FRIEND, 'writable' => true), + // array('id' => $contact["id"], 'uid' => $contact["uid"]) + // ); + // + // $contact["rel"] = CONTACT_IS_FRIEND; + // logger("defining user ".$contact["nick"]." as friend"); + //} // We don't seem to like that person if ($contact["blocked"] || $contact["readonly"] || $contact["archive"]) { @@ -1090,7 +1141,7 @@ class Diaspora preg_replace_callback( $expression, function ($match) use ($item) { - return self::fetchGuidSub($match, $item); + self::fetchGuidSub($match, $item); }, $item["body"] ); @@ -1098,7 +1149,7 @@ class Diaspora preg_replace_callback( "&\[url=/posts/([^\[\]]*)\](.*)\[\/url\]&Usi", function ($match) use ($item) { - return self::fetchGuidSub($match, $item); + self::fetchGuidSub($match, $item); }, $item["body"] ); @@ -1111,7 +1162,7 @@ class Diaspora * @param string $body The item body to replace links from * @param string $author_link The author link for missing local contact fallback * - * @return the replaced string + * @return string the replaced string */ public static function replacePeopleGuid($body, $author_link) { @@ -1260,7 +1311,7 @@ class Diaspora return false; } - $msg = array("message" => $x, "author" => $author); + $msg = ["message" => $x, "author" => $author]; $msg["key"] = self::key($msg["author"]); @@ -1340,16 +1391,12 @@ class Diaspora if ($r) { $cid = $r[0]["id"]; $network = $r[0]["network"]; - - // We are receiving content from a user that possibly is about to be terminated - // This means the user is vital, so we remove a possible termination date. - Contact::unmarkForArchival($r[0]); } else { $cid = $contact["id"]; $network = NETWORK_DIASPORA; } - return array("cid" => $cid, "network" => $network); + return ["cid" => $cid, "network" => $network]; } /** @@ -1433,7 +1480,7 @@ class Diaspora // Check signature $signed_text = 'AccountMigration:'.$old_handle.':'.$new_handle; $key = self::key($old_handle); - if (!rsa_verify($signed_text, $signature, $key, "sha256")) { + if (!Crypto::rsaVerify($signed_text, $signature, $key, "sha256")) { logger('No valid signature for migration.'); return false; } @@ -1448,30 +1495,30 @@ class Diaspora return false; } - $fields = array('url' => $data['url'], 'nurl' => normalise_link($data['url']), + $fields = ['url' => $data['url'], 'nurl' => normalise_link($data['url']), 'name' => $data['name'], 'nick' => $data['nick'], 'addr' => $data['addr'], 'batch' => $data['batch'], 'notify' => $data['notify'], 'poll' => $data['poll'], - 'network' => $data['network']); + 'network' => $data['network']]; - dba::update('contact', $fields, array('addr' => $old_handle)); + dba::update('contact', $fields, ['addr' => $old_handle]); - $fields = array('url' => $data['url'], 'nurl' => normalise_link($data['url']), + $fields = ['url' => $data['url'], 'nurl' => normalise_link($data['url']), 'name' => $data['name'], 'nick' => $data['nick'], 'addr' => $data['addr'], 'connect' => $data['addr'], 'notify' => $data['notify'], 'photo' => $data['photo'], - 'server_url' => $data['baseurl'], 'network' => $data['network']); + 'server_url' => $data['baseurl'], 'network' => $data['network']]; - dba::update('gcontact', $fields, array('addr' => $old_handle)); + dba::update('gcontact', $fields, ['addr' => $old_handle]); logger('Contacts are updated.'); // update items /// @todo This is an extreme performance killer - $fields = array( - 'owner-link' => array($contact["url"], $data["url"]), - 'author-link' => array($contact["url"], $data["url"]), - ); + $fields = [ + 'owner-link' => [$contact["url"], $data["url"]], + 'author-link' => [$contact["url"], $data["url"]], + ]; foreach ($fields as $n => $f) { $r = q( "SELECT `id` FROM `item` WHERE `%s` = '%s' AND `uid` = %d LIMIT 1", @@ -1640,7 +1687,7 @@ class Diaspora // Fetch the contact id - if we know this contact $author_contact = self::authorContactByUrl($contact, $person, $importer["uid"]); - $datarray = array(); + $datarray = []; $datarray["uid"] = $importer["uid"]; $datarray["contact-id"] = $author_contact["cid"]; @@ -1696,7 +1743,7 @@ class Diaspora if ($message_id && $parent_item["origin"]) { // Formerly we stored the signed text, the signature and the author in different fields. // We now store the raw data so that we are more flexible. - dba::insert('sign', array('iid' => $message_id, 'signed_text' => json_encode($data))); + dba::insert('sign', ['iid' => $message_id, 'signed_text' => json_encode($data)]); // notify others Worker::add(PRIORITY_HIGH, "Notifier", "comment-import", $message_id); @@ -1781,22 +1828,22 @@ class Diaspora dba::unlock(); - dba::update('conv', array('updated' => datetime_convert()), array('id' => $conversation["id"])); + dba::update('conv', ['updated' => datetime_convert()], ['id' => $conversation["id"]]); notification( - array( + [ "type" => NOTIFY_MAIL, "notify_flags" => $importer["notify-flags"], "language" => $importer["language"], "to_name" => $importer["username"], "to_email" => $importer["email"], "uid" =>$importer["uid"], - "item" => array("subject" => $subject, "body" => $body), + "item" => ["subject" => $subject, "body" => $body], "source_name" => $person["name"], "source_link" => $person["url"], "source_photo" => $person["thumb"], "verb" => ACTIVITY_POST, - "otype" => "mail") + "otype" => "mail"] ); return true; } @@ -1909,12 +1956,12 @@ class Diaspora $link = ''; $parent_body = $parent_item["body"]; - $xmldata = array("object" => array("type" => $objtype, + $xmldata = ["object" => ["type" => $objtype, "local" => "1", "id" => $parent_item["uri"], "link" => $link, "title" => "", - "content" => $parent_body)); + "content" => $parent_body]]; return XML::fromArray($xmldata, $xml, true); } @@ -1938,7 +1985,7 @@ class Diaspora // likes on comments aren't supported by Diaspora - only on posts // But maybe this will be supported in the future, so we will accept it. - if (!in_array($parent_type, array("Post", "Comment"))) { + if (!in_array($parent_type, ["Post", "Comment"])) { return false; } @@ -1974,7 +2021,7 @@ class Diaspora $verb = ACTIVITY_DISLIKE; } - $datarray = array(); + $datarray = []; $datarray["protocol"] = PROTOCOL_DIASPORA; @@ -2015,7 +2062,7 @@ class Diaspora // like on comments have the comment as parent. So we need to fetch the toplevel parent if ($parent_item["id"] != $parent_item["parent"]) { - $toplevel = dba::select('item', array('origin'), array('id' => $parent_item["parent"]), array('limit' => 1)); + $toplevel = dba::selectFirst('item', ['origin'], ['id' => $parent_item["parent"]]); $origin = $toplevel["origin"]; } else { $origin = $parent_item["origin"]; @@ -2025,7 +2072,7 @@ class Diaspora if ($message_id && $origin) { // Formerly we stored the signed text, the signature and the author in different fields. // We now store the raw data so that we are more flexible. - dba::insert('sign', array('iid' => $message_id, 'signed_text' => json_encode($data))); + dba::insert('sign', ['iid' => $message_id, 'signed_text' => json_encode($data)]); // notify others Worker::add(PRIORITY_HIGH, "Notifier", "comment-import", $message_id); @@ -2114,7 +2161,7 @@ class Diaspora dba::unlock(); - dba::update('conv', array('updated' => datetime_convert()), array('id' => $conversation["id"])); + dba::update('conv', ['updated' => datetime_convert()], ['id' => $conversation["id"]]); return true; } @@ -2128,7 +2175,54 @@ class Diaspora */ private static function receiveParticipation($importer, $data) { - // I'm not sure if we can fully support this message type + $author = strtolower(notags(unxmlify($data->author))); + $parent_guid = notags(unxmlify($data->parent_guid)); + + $contact_id = Contact::getIdForURL($author); + if (!$contact_id) { + logger('Contact not found: '.$author); + return false; + } + + $person = self::personByHandle($author); + if (!is_array($person)) { + logger("Person not found: ".$author); + return false; + } + + $item = dba::selectFirst('item', ['id'], ['guid' => $parent_guid, 'origin' => true, 'private' => false]); + if (!DBM::is_result($item)) { + logger('Item not found, no origin or private: '.$parent_guid); + return false; + } + + $author_parts = explode('@', $author); + if (isset($author_parts[1])) { + $server = $author_parts[1]; + } else { + // Should never happen + $server = $author; + } + + logger('Received participation for ID: '.$item['id'].' - Contact: '.$contact_id.' - Server: '.$server, LOGGER_DEBUG); + dba::insert('participation', ['iid' => $item['id'], 'cid' => $contact_id, 'fid' => $person['id'], 'server' => $server]); + + // Send all existing comments and likes to the requesting server + $comments = dba::p("SELECT `item`.`id`, `item`.`verb`, `contact`.`self` + FROM `item` + INNER JOIN `contact` ON `contact`.`id` = `item`.`contact-id` + WHERE `item`.`parent` = ? AND `item`.`id` != `item`.`parent`", $item['id']); + while ($comment = dba::fetch($comments)) { + if ($comment['verb'] == ACTIVITY_POST) { + $cmd = $comment['self'] ? 'comment-new' : 'comment-import'; + } else { + $cmd = $comment['self'] ? 'like' : 'comment-import'; + } + logger("Send ".$cmd." for item ".$comment['id']." to contact ".$contact_id, LOGGER_DEBUG); + Worker::add(PRIORITY_HIGH, 'Delivery', $cmd, $comment['id'], $contact_id); + } + dba::close($comments); + return true; } @@ -2190,7 +2284,7 @@ class Diaspora $tags = explode("#", $tags); - $keywords = array(); + $keywords = []; foreach ($tags as $tag) { $tag = trim(strtolower($tag)); if ($tag != "") { @@ -2211,7 +2305,7 @@ class Diaspora $image_url = "http://".$handle_parts[1].$image_url; } - Photo::updateContactAvatar($image_url, $importer["uid"], $contact["id"]); + Contact::updateAvatar($image_url, $importer["uid"], $contact["id"]); // Generic birthday. We don't know the timezone. The year is irrelevant. @@ -2244,15 +2338,15 @@ class Diaspora intval($importer["uid"]) ); - $gcontact = array("url" => $contact["url"], "network" => NETWORK_DIASPORA, "generation" => 2, + $gcontact = ["url" => $contact["url"], "network" => NETWORK_DIASPORA, "generation" => 2, "photo" => $image_url, "name" => $name, "location" => $location, "about" => $about, "birthday" => $birthday, "gender" => $gender, "addr" => $author, "nick" => $nick, "keywords" => $keywords, - "hide" => !$searchable, "nsfw" => $nsfw); + "hide" => !$searchable, "nsfw" => $nsfw]; - $gcid = GlobalContact::update($gcontact); + $gcid = GContact::update($gcontact); - GlobalContact::link($gcid, $importer["uid"], $contact["id"]); + GContact::link($gcid, $importer["uid"], $contact["id"]); logger("Profile of contact ".$contact["id"]." stored for user ".$importer["uid"], LOGGER_DEBUG); @@ -2273,8 +2367,8 @@ class Diaspora if ($contact["rel"] == CONTACT_IS_SHARING) { dba::update( 'contact', - array('rel' => CONTACT_IS_FRIEND, 'writable' => true), - array('id' => $contact["id"], 'uid' => $importer["uid"]) + ['rel' => CONTACT_IS_FRIEND, 'writable' => true], + ['id' => $contact["id"], 'uid' => $importer["uid"]] ); } // send notification @@ -2293,7 +2387,7 @@ class Diaspora // they are not CONTACT_IS_FOLLOWER anymore but that's what we have in the array if ($self && $contact["rel"] == CONTACT_IS_FOLLOWER) { - $arr = array(); + $arr = []; $arr["protocol"] = PROTOCOL_DIASPORA; $arr["uri"] = $arr["parent-uri"] = item_new_uri($a->get_hostname(), $importer["uid"]); $arr["uid"] = $importer["uid"]; @@ -2311,16 +2405,18 @@ class Diaspora $A = "[url=".$self[0]["url"]."]".$self[0]["name"]."[/url]"; $B = "[url=".$contact["url"]."]".$contact["name"]."[/url]"; $BPhoto = "[url=".$contact["url"]."][img]".$contact["thumb"]."[/img][/url]"; - $arr["body"] = sprintf(t("%1$s is now friends with %2$s"), $A, $B)."\n\n\n".$Bphoto; + $arr["body"] = sprintf(t('%1$s is now friends with %2$s'), $A, $B)."\n\n\n".$BPhoto; $arr["object"] = self::constructNewFriendObject($contact); $arr["last-child"] = 1; - $arr["allow_cid"] = $user[0]["allow_cid"]; - $arr["allow_gid"] = $user[0]["allow_gid"]; - $arr["deny_cid"] = $user[0]["deny_cid"]; - $arr["deny_gid"] = $user[0]["deny_gid"]; + $user = dba::selectFirst('user', ['allow_cid', 'allow_gid', 'deny_cid', 'deny_gid'], ['uid' => $importer["uid"]]); + + $arr["allow_cid"] = $user["allow_cid"]; + $arr["allow_gid"] = $user["allow_gid"]; + $arr["deny_cid"] = $user["deny_cid"]; + $arr["deny_gid"] = $user["deny_gid"]; $i = item_store($arr); if ($i) { @@ -2343,10 +2439,10 @@ class Diaspora $link = ''."\n". ''."\n"; - $xmldata = array("object" => array("type" => $objtype, + $xmldata = ["object" => ["type" => $objtype, "title" => $contact["name"], "id" => $contact["url"]."/".$contact["name"], - "link" => $link)); + "link" => $link]]; return XML::fromArray($xmldata, $xml, true); } @@ -2396,7 +2492,7 @@ class Diaspora // If we are now friends, we are sending a share message. // Normally we needn't to do so, but the first message could have been vanished. - if (in_array($contact["rel"], array(CONTACT_IS_FRIEND))) { + if (in_array($contact["rel"], [CONTACT_IS_FRIEND])) { $u = q("SELECT * FROM `user` WHERE `uid` = %d LIMIT 1", intval($importer["uid"])); if ($u) { logger("Sending share message to author ".$author." - Contact: ".$contact["id"]." - User: ".$importer["uid"], LOGGER_DEBUG); @@ -2411,7 +2507,7 @@ class Diaspora } } - if (!$following && $sharing && in_array($importer["page-flags"], array(PAGE_SOAPBOX, PAGE_NORMAL))) { + if (!$following && $sharing && in_array($importer["page-flags"], [PAGE_SOAPBOX, PAGE_NORMAL])) { logger("Author ".$author." wants to share with us - but doesn't want to listen. Request is ignored.", LOGGER_DEBUG); return false; } elseif (!$following && !$sharing) { @@ -2465,13 +2561,9 @@ class Diaspora logger("Author ".$author." was added as contact number ".$contact_record["id"].".", LOGGER_DEBUG); - $def_gid = get_default_group($importer['uid'], $ret["network"]); - - if (intval($def_gid)) { - group_add_member($importer["uid"], "", $contact_record["id"], $def_gid); - } + Group::addMember(User::getDefaultGroup($importer['uid'], $ret["network"]), $contact_record['id']); - Photo::updateContactAvatar($ret["photo"], $importer['uid'], $contact_record["id"], true); + Contact::updateAvatar($ret["photo"], $importer['uid'], $contact_record["id"], true); if ($importer["page-flags"] == PAGE_NORMAL) { logger("Sending intra message for author ".$author.".", LOGGER_DEBUG); @@ -2494,7 +2586,7 @@ class Diaspora logger("Does an automatic friend approval for author ".$author.".", LOGGER_DEBUG); - Photo::updateContactAvatar($contact_record["photo"], $importer["uid"], $contact_record["id"]); + Contact::updateAvatar($contact_record["photo"], $importer["uid"], $contact_record["id"]); // technically they are sharing with us (CONTACT_IS_SHARING), // but if our page-type is PAGE_COMMUNITY or PAGE_SOAPBOX @@ -2529,7 +2621,7 @@ class Diaspora $ret = self::sendShare($u[0], $contact_record); // Send the profile data, maybe it weren't transmitted before - self::sendProfile($importer["uid"], array($contact_record)); + self::sendProfile($importer["uid"], [$contact_record]); } } @@ -2562,7 +2654,7 @@ class Diaspora // Then refetch the content, if it is a reshare from a reshare. // If it is a reshared post from another network then reformat to avoid display problems with two share elements if (self::isReshare($r[0]["body"], true)) { - $r = array(); + $r = []; } elseif (self::isReshare($r[0]["body"], false) || strstr($r[0]["body"], "[share")) { $r[0]["body"] = diaspora2bb(bb2diaspora($r[0]["body"])); @@ -2646,7 +2738,7 @@ class Diaspora $orig_url = System::baseUrl()."/display/".$original_item["guid"]; - $datarray = array(); + $datarray = []; $datarray["uid"] = $importer["uid"]; $datarray["contact-id"] = $contact["id"]; @@ -2691,6 +2783,8 @@ class Diaspora self::fetchGuid($datarray); $message_id = item_store($datarray); + self::sendParticipation($contact, $datarray); + if ($message_id) { logger("Stored reshare ".$datarray["guid"]." with message id ".$message_id, LOGGER_DEBUG); return true; @@ -2725,13 +2819,13 @@ class Diaspora } // Fetch items that are about to be deleted - $fields = array('uid', 'id', 'parent', 'parent-uri', 'author-link'); + $fields = ['uid', 'id', 'parent', 'parent-uri', 'author-link']; // When we receive a public retraction, we delete every item that we find. if ($importer['uid'] == 0) { - $condition = array("`guid` = ? AND NOT `file` LIKE '%%[%%' AND NOT `deleted`", $target_guid); + $condition = ["`guid` = ? AND NOT `file` LIKE '%%[%%' AND NOT `deleted`", $target_guid]; } else { - $condition = array("`guid` = ? AND `uid` = ? AND NOT `file` LIKE '%%[%%' AND NOT `deleted`", $target_guid, $importer['uid']); + $condition = ["`guid` = ? AND `uid` = ? AND NOT `file` LIKE '%%[%%' AND NOT `deleted`", $target_guid, $importer['uid']]; } $r = dba::select('item', $fields, $condition); if (!DBM::is_result($r)) { @@ -2741,7 +2835,7 @@ class Diaspora while ($item = dba::fetch($r)) { // Fetch the parent item - $parent = dba::select('item', array('author-link', 'origin'), array('id' => $item["parent"]), array('limit' => 1)); + $parent = dba::selectFirst('item', ['author-link', 'origin'], ['id' => $item["parent"]]); // Only delete it if the parent author really fits if (!link_compare($parent["author-link"], $contact["url"]) && !link_compare($item["author-link"], $contact["url"])) { @@ -2753,13 +2847,13 @@ class Diaspora // The function "item_drop" doesn't work for that case dba::update( 'item', - array( + [ 'deleted' => true, 'title' => '', 'body' => '', 'edited' => datetime_convert(), - 'changed' => datetime_convert()), - array('id' => $item["id"]) + 'changed' => datetime_convert()], + ['id' => $item["id"]] ); // Delete the thread - if it is a starting post and not a comment @@ -2793,7 +2887,7 @@ class Diaspora $target_type = notags(unxmlify($data->target_type)); $contact = self::contactByHandle($importer["uid"], $sender); - if (!$contact && (in_array($target_type, array("Contact", "Person")))) { + if (!$contact && (in_array($target_type, ["Contact", "Person"]))) { logger("cannot find contact for sender: ".$sender." and user ".$importer["uid"]); return false; } @@ -2850,7 +2944,7 @@ class Diaspora return true; } - $address = array(); + $address = []; if ($data->location) { foreach ($data->location->children() as $fieldname => $data) { $address[$fieldname] = notags(unxmlify($data)); @@ -2859,7 +2953,7 @@ class Diaspora $body = diaspora2bb($text); - $datarray = array(); + $datarray = []; // Attach embedded pictures to the body if ($data->photo) { @@ -2929,6 +3023,8 @@ class Diaspora self::fetchGuid($datarray); $message_id = item_store($datarray); + self::sendParticipation($contact, $datarray); + if ($message_id) { logger("Stored item ".$datarray["guid"]." with message id ".$message_id, LOGGER_DEBUG); return true; @@ -2994,14 +3090,14 @@ class Diaspora $ciphertext = self::aesEncrypt($aes_key, $iv, $msg); - $json = json_encode(array("iv" => $b_iv, "key" => $b_aes_key)); + $json = json_encode(["iv" => $b_iv, "key" => $b_aes_key]); $encrypted_key_bundle = ""; openssl_public_encrypt($json, $encrypted_key_bundle, $pubkey); $json_object = json_encode( - array("aes_key" => base64_encode($encrypted_key_bundle), - "encrypted_magic_envelope" => base64_encode($ciphertext)) + ["aes_key" => base64_encode($encrypted_key_bundle), + "encrypted_magic_envelope" => base64_encode($ciphertext)] ); return $json_object; @@ -3018,7 +3114,7 @@ class Diaspora public static function buildMagicEnvelope($msg, $user) { $b64url_data = base64url_encode($msg); - $data = str_replace(array("\n", "\r", " ", "\t"), array("", "", "", ""), $b64url_data); + $data = str_replace(["\n", "\r", " ", "\t"], ["", "", "", ""], $b64url_data); $key_id = base64url_encode(self::myHandle($user)); $type = "application/xml"; @@ -3031,17 +3127,17 @@ class Diaspora $user['uprvkey'] = $user['prvkey']; } - $signature = rsa_sign($signable_data, $user["uprvkey"]); + $signature = Crypto::rsaSign($signable_data, $user["uprvkey"]); $sig = base64url_encode($signature); - $xmldata = array("me:env" => array("me:data" => $data, - "@attributes" => array("type" => $type), + $xmldata = ["me:env" => ["me:data" => $data, + "@attributes" => ["type" => $type], "me:encoding" => $encoding, "me:alg" => $alg, "me:sig" => $sig, - "@attributes2" => array("key_id" => $key_id))); + "@attributes2" => ["key_id" => $key_id]]]; - $namespaces = array("me" => "http://salmon-protocol.org/ns/magic-env"); + $namespaces = ["me" => "http://salmon-protocol.org/ns/magic-env"]; return XML::fromArray($xmldata, $xml, false, $namespaces); } @@ -3087,7 +3183,7 @@ class Diaspora $signed_text = implode(";", $sigmsg); - return base64_encode(rsa_sign($signed_text, $owner["uprvkey"], "sha256")); + return base64_encode(Crypto::rsaSign($signed_text, $owner["uprvkey"], "sha256")); } /** @@ -3112,7 +3208,15 @@ class Diaspora } $logid = random_string(4); - $dest_url = (($public_batch) ? $contact["batch"] : $contact["notify"]); + $dest_url = ($public_batch ? $contact["batch"] : $contact["notify"]); + + // Fetch the fcontact entry when there is missing data + // Will possibly happen when data is transmitted to a DFRN contact + if (empty($dest_url) && !empty($contact['addr'])) { + $fcontact = self::personByHandle($contact['addr']); + $dest_url = ($public_batch ? $fcontact["batch"] : $fcontact["notify"]); + } + if (!$dest_url) { logger("no url for contact: ".$contact["id"]." batch mode =".$public_batch); return 0; @@ -3126,7 +3230,7 @@ class Diaspora if (!intval(Config::get("system", "diaspora_test"))) { $content_type = (($public_batch) ? "application/magic-envelope+xml" : "application/json"); - post_url($dest_url."/", $envelope, array("Content-Type: ".$content_type)); + post_url($dest_url."/", $envelope, ["Content-Type: ".$content_type]); $return_code = $a->get_curl_code(); } else { logger("test_mode"); @@ -3174,7 +3278,7 @@ class Diaspora */ public static function buildPostXml($type, $message) { - $data = array($type => $message); + $data = [$type => $message]; return XML::fromArray($data, $xml); } @@ -3213,11 +3317,59 @@ class Diaspora $return_code = self::transmit($owner, $contact, $envelope, $public_batch, false, $guid); } - logger("guid: ".$item["guid"]." result ".$return_code, LOGGER_DEBUG); + logger("guid: ".$guid." result ".$return_code, LOGGER_DEBUG); return $return_code; } + /** + * @brief sends a participation (Used to get all further updates) + * + * @param array $contact Target of the communication + * @param array $item Item array + * + * @return int The result of the transmission + */ + private static function sendParticipation($contact, $item) + { + // Don't send notifications for private postings + if ($item['private']) { + return; + } + + $cachekey = "diaspora:sendParticipation:".$item['guid']; + + $result = Cache::get($cachekey); + if (!is_null($result)) { + return; + } + + // Fetch some user id to have a valid handle to transmit the participation. + // In fact it doesn't matter which user sends this - but it is needed by the protocol. + // If the item belongs to a user, we take this user id. + if ($item['uid'] == 0) { + $condition = ['verified' => true, 'blocked' => false, 'account_removed' => false, 'account_expired' => false]; + $first_user = dba::selectFirst('user', ['uid'], $condition); + $owner = User::getOwnerDataById($first_user['uid']); + } else { + $owner = User::getOwnerDataById($item['uid']); + } + + $author = self::myHandle($owner); + + $message = ["author" => $author, + "guid" => get_guid(32), + "parent_type" => "Post", + "parent_guid" => $item["guid"]]; + + logger("Send participation for ".$item["guid"]." by ".$author, LOGGER_DEBUG); + + // It doesn't matter what we store, we only want to avoid sending repeated notifications for the same item + Cache::set($cachekey, $item["guid"], CACHE_QUARTER_HOUR); + + return self::buildAndTransmit($owner, $contact, "participation", $message); + } + /** * @brief sends an account migration * @@ -3233,11 +3385,11 @@ class Diaspora $profile = self::createProfileData($uid); $signed_text = 'AccountMigration:'.$old_handle.':'.$profile['author']; - $signature = base64_encode(rsa_sign($signed_text, $owner["uprvkey"], "sha256")); + $signature = base64_encode(Crypto::rsaSign($signed_text, $owner["uprvkey"], "sha256")); - $message = array("author" => $old_handle, + $message = ["author" => $old_handle, "profile" => $profile, - "signature" => $signature); + "signature" => $signature]; logger("Send account migration ".print_r($message, true), LOGGER_DEBUG); @@ -3275,10 +3427,10 @@ class Diaspora } */ - $message = array("author" => self::myHandle($owner), + $message = ["author" => self::myHandle($owner), "recipient" => $contact["addr"], "following" => "true", - "sharing" => "true"); + "sharing" => "true"]; logger("Send share ".print_r($message, true), LOGGER_DEBUG); @@ -3295,10 +3447,10 @@ class Diaspora */ public static function sendUnshare($owner, $contact) { - $message = array("author" => self::myHandle($owner), + $message = ["author" => self::myHandle($owner), "recipient" => $contact["addr"], "following" => "false", - "sharing" => "false"); + "sharing" => "false"]; logger("Send unshare ".print_r($message, true), LOGGER_DEBUG); @@ -3358,7 +3510,7 @@ class Diaspora NETWORK_DIASPORA ); if ($r) { - $ret= array(); + $ret= []; $ret["root_handle"] = self::handleFromContact($r[0]["contact-id"]); $ret["root_guid"] = $guid; return($ret); @@ -3376,7 +3528,7 @@ class Diaspora $profile = $matches[1]; } - $ret= array(); + $ret= []; $ret["root_handle"] = preg_replace("=https?://(.*)/u/(.*)=ism", "$2@$1", $profile); if (($ret["root_handle"] == $profile) || ($ret["root_handle"] == "")) { @@ -3413,23 +3565,23 @@ class Diaspora { $r = q("SELECT `guid`, `uid`, `start`, `finish`, `nofinish`, `summary`, `desc`, `location`, `adjust` FROM `event` WHERE `id` = %d", intval($event_id)); if (!DBM::is_result($r)) { - return array(); + return []; } $event = $r[0]; - $eventdata = array(); + $eventdata = []; $r = q("SELECT `timezone` FROM `user` WHERE `uid` = %d", intval($event['uid'])); if (!DBM::is_result($r)) { - return array(); + return []; } $user = $r[0]; $r = q("SELECT `addr`, `nick` FROM `contact` WHERE `uid` = %d AND `self`", intval($event['uid'])); if (!DBM::is_result($r)) { - return array(); + return []; } $owner = $r[0]; @@ -3466,7 +3618,7 @@ class Diaspora $eventdata['description'] = html_entity_decode(bb2diaspora($event['desc'])); } if ($event['location']) { - $location = array(); + $location = []; $location["address"] = html_entity_decode(bb2diaspora($event['location'])); $location["lat"] = 0; $location["lng"] = 0; @@ -3503,13 +3655,13 @@ class Diaspora // Detect a share element and do a reshare if (!$item['private'] && ($ret = self::isReshare($item["body"]))) { - $message = array("author" => $myaddr, + $message = ["author" => $myaddr, "guid" => $item["guid"], "created_at" => $created, "root_author" => $ret["root_handle"], "root_guid" => $ret["root_guid"], "provider_display_name" => $item["app"], - "public" => $public); + "public" => $public]; $type = "reshare"; } else { @@ -3534,7 +3686,7 @@ class Diaspora } } - $location = array(); + $location = []; if ($item["location"] != "") $location["address"] = $item["location"]; @@ -3545,13 +3697,13 @@ class Diaspora $location["lng"] = $coord[1]; } - $message = array("author" => $myaddr, + $message = ["author" => $myaddr, "guid" => $item["guid"], "created_at" => $created, "public" => $public, "text" => $body, "provider_display_name" => $item["app"], - "location" => $location); + "location" => $location]; // Diaspora rejects messages when they contain a location without "lat" or "lng" if (!isset($location["lat"]) || !isset($location["lng"])) { @@ -3571,7 +3723,7 @@ class Diaspora $type = "status_message"; } - $msg = array("type" => $type, "message" => $message); + $msg = ["type" => $type, "message" => $message]; Cache::set($cachekey, $msg, CACHE_QUARTER_HOUR); @@ -3622,12 +3774,12 @@ class Diaspora $positive = "false"; } - return(array("author" => self::myHandle($owner), + return(["author" => self::myHandle($owner), "guid" => $item["guid"], "parent_guid" => $parent["guid"], "parent_type" => $target_type, "positive" => $positive, - "author_signature" => "")); + "author_signature" => ""]); } /** @@ -3665,11 +3817,11 @@ class Diaspora return false; } - return(array("author" => self::myHandle($owner), + return(["author" => self::myHandle($owner), "guid" => $item["guid"], "parent_guid" => $parent["guid"], "status" => $attend_answer, - "author_signature" => "")); + "author_signature" => ""]); } /** @@ -3704,12 +3856,12 @@ class Diaspora $text = html_entity_decode(bb2diaspora($item["body"])); $created = datetime_convert("UTC", "UTC", $item["created"], 'Y-m-d\TH:i:s\Z'); - $comment = array("author" => self::myHandle($owner), + $comment = ["author" => self::myHandle($owner), "guid" => $item["guid"], "created_at" => $created, "parent_guid" => $parent["guid"], "text" => $text, - "author_signature" => ""); + "author_signature" => ""]; // Send the thread parent guid only if it is a threaded comment if ($item['thr-parent'] != $item['parent-uri']) { @@ -3733,10 +3885,10 @@ class Diaspora */ public static function sendFollowup($item, $owner, $contact, $public_batch = false) { - if (in_array($item['verb'], array(ACTIVITY_ATTEND, ACTIVITY_ATTENDNO, ACTIVITY_ATTENDMAYBE))) { + if (in_array($item['verb'], [ACTIVITY_ATTEND, ACTIVITY_ATTENDNO, ACTIVITY_ATTENDMAYBE])) { $message = self::constructAttend($item, $owner); $type = "event_participation"; - } elseif (in_array($item["verb"], array(ACTIVITY_LIKE, ACTIVITY_DISLIKE))) { + } elseif (in_array($item["verb"], [ACTIVITY_LIKE, ACTIVITY_DISLIKE])) { $message = self::constructLike($item, $owner); $type = "like"; } else { @@ -3767,17 +3919,17 @@ class Diaspora $signed_parts = explode(";", $signature['signed_text']); if ($item["deleted"]) { - $message = array("author" => $signature['signer'], + $message = ["author" => $signature['signer'], "target_guid" => $signed_parts[0], - "target_type" => $signed_parts[1]); - } elseif (in_array($item["verb"], array(ACTIVITY_LIKE, ACTIVITY_DISLIKE))) { - $message = array("author" => $signed_parts[4], + "target_type" => $signed_parts[1]]; + } elseif (in_array($item["verb"], [ACTIVITY_LIKE, ACTIVITY_DISLIKE])) { + $message = ["author" => $signed_parts[4], "guid" => $signed_parts[1], "parent_guid" => $signed_parts[3], "parent_type" => $signed_parts[2], "positive" => $signed_parts[0], "author_signature" => $signature['signature'], - "parent_author_signature" => ""); + "parent_author_signature" => ""]; } else { // Remove the comment guid $guid = array_shift($signed_parts); @@ -3791,12 +3943,12 @@ class Diaspora // Glue the parts together $text = implode(";", $signed_parts); - $message = array("author" => $handle, + $message = ["author" => $handle, "guid" => $guid, "parent_guid" => $parent_guid, "text" => implode(";", $signed_parts), "author_signature" => $signature['signature'], - "parent_author_signature" => ""); + "parent_author_signature" => ""]; } return $message; } @@ -3815,7 +3967,7 @@ class Diaspora { if ($item["deleted"]) { return self::sendRetraction($item, $owner, $contact, $public_batch, true); - } elseif (in_array($item["verb"], array(ACTIVITY_LIKE, ACTIVITY_DISLIKE))) { + } elseif (in_array($item["verb"], [ACTIVITY_LIKE, ACTIVITY_DISLIKE])) { $type = "like"; } else { $type = "comment"; @@ -3844,7 +3996,7 @@ class Diaspora } else {// New way $msg = json_decode($signature['signed_text'], true); - $message = array(); + $message = []; if (is_array($msg)) { foreach ($msg as $field => $data) { if (!$item["deleted"]) { @@ -3889,15 +4041,15 @@ class Diaspora if ($item['id'] == $item['parent']) { $target_type = "Post"; - } elseif (in_array($item["verb"], array(ACTIVITY_LIKE, ACTIVITY_DISLIKE))) { + } elseif (in_array($item["verb"], [ACTIVITY_LIKE, ACTIVITY_DISLIKE])) { $target_type = "Like"; } else { $target_type = "Comment"; } - $message = array("author" => $itemaddr, + $message = ["author" => $itemaddr, "target_guid" => $item['guid'], - "target_type" => $target_type); + "target_type" => $target_type]; logger("Got message ".print_r($message, true), LOGGER_DEBUG); @@ -3929,36 +4081,36 @@ class Diaspora } $cnv = $r[0]; - $conv = array( + $conv = [ "author" => $cnv["creator"], "guid" => $cnv["guid"], "subject" => $cnv["subject"], "created_at" => datetime_convert("UTC", "UTC", $cnv['created'], 'Y-m-d\TH:i:s\Z'), "participants" => $cnv["recips"] - ); + ]; $body = bb2diaspora($item["body"]); $created = datetime_convert("UTC", "UTC", $item["created"], 'Y-m-d\TH:i:s\Z'); - $msg = array( + $msg = [ "author" => $myaddr, "guid" => $item["guid"], "conversation_guid" => $cnv["guid"], "text" => $body, "created_at" => $created, - ); + ]; if ($item["reply"]) { $message = $msg; $type = "message"; } else { - $message = array( + $message = [ "author" => $cnv["creator"], "guid" => $cnv["guid"], "subject" => $cnv["subject"], "created_at" => datetime_convert("UTC", "UTC", $cnv['created'], 'Y-m-d\TH:i:s\Z'), "participants" => $cnv["recips"], - "message" => $msg); + "message" => $msg]; $type = "conversation"; } @@ -3966,6 +4118,62 @@ class Diaspora return self::buildAndTransmit($owner, $contact, $type, $message, false, $item["guid"]); } + /** + * @brief Split a name into first name and last name + * + * @param string $name The name + * + * @return array The array with "first" and "last" + */ + public static function splitName($name) { + $name = trim($name); + + // Is the name longer than 64 characters? Then cut the rest of it. + if (strlen($name) > 64) { + if ((strpos($name, ' ') <= 64) && (strpos($name, ' ') !== false)) { + $name = trim(substr($name, 0, strrpos(substr($name, 0, 65), ' '))); + } else { + $name = substr($name, 0, 64); + } + } + + // Take the first word as first name + $first = ((strpos($name, ' ') ? trim(substr($name, 0, strpos($name, ' '))) : $name)); + $last = (($first === $name) ? '' : trim(substr($name, strlen($first)))); + if ((strlen($first) < 32) && (strlen($last) < 32)) { + return ['first' => $first, 'last' => $last]; + } + + // Take the last word as last name + $first = ((strrpos($name, ' ') ? trim(substr($name, 0, strrpos($name, ' '))) : $name)); + $last = (($first === $name) ? '' : trim(substr($name, strlen($first)))); + + if ((strlen($first) < 32) && (strlen($last) < 32)) { + return ['first' => $first, 'last' => $last]; + } + + // Take the first 32 characters if there is no space in the first 32 characters + if ((strpos($name, ' ') > 32) || (strpos($name, ' ') === false)) { + $first = substr($name, 0, 32); + $last = substr($name, 32); + return ['first' => $first, 'last' => $last]; + } + + $first = trim(substr($name, 0, strrpos(substr($name, 0, 33), ' '))); + $last = (($first === $name) ? '' : trim(substr($name, strlen($first)))); + + // Check if the last name is longer than 32 characters + if (strlen($last) > 32) { + if (strpos($last, ' ') <= 32) { + $last = trim(substr($last, 0, strrpos(substr($last, 0, 33), ' '))); + } else { + $last = substr($last, 0, 32); + } + } + + return ['first' => $first, 'last' => $last]; + } + /** * @brief Create profile data * @@ -3985,15 +4193,16 @@ class Diaspora ); if (!$r) { - return array(); + return []; } $profile = $r[0]; - $handle = $profile["addr"]; - $first = ((strpos($profile['name'], ' ') - ? trim(substr($profile['name'], 0, strpos($profile['name'], ' '))) : $profile['name'])); - $last = (($first === $profile['name']) ? '' : trim(substr($profile['name'], strlen($first)))); + + $split_name = self::splitName($profile['name']); + $first = $split_name['first']; + $last = $split_name['last']; + $large = System::baseUrl().'/photo/custom/300/'.$profile['uid'].'.jpg'; $medium = System::baseUrl().'/photo/custom/100/'.$profile['uid'].'.jpg'; $small = System::baseUrl().'/photo/custom/50/' .$profile['uid'].'.jpg'; @@ -4026,7 +4235,7 @@ class Diaspora $tags = trim($tags); } - return array("author" => $handle, + return ["author" => $handle, "first_name" => $first, "last_name" => $last, "image_url" => $large, @@ -4038,7 +4247,7 @@ class Diaspora "location" => $location, "searchable" => $searchable, "nsfw" => "false", - "tag_string" => $tags); + "tag_string" => $tags]; } /** @@ -4054,6 +4263,11 @@ class Diaspora return; } + $owner = User::getOwnerDataById($uid); + if (!$owner) { + return; + } + if (!$recips) { $recips = q( "SELECT `id`,`name`,`network`,`pubkey`,`notify` FROM `contact` WHERE `network` = '%s' @@ -4072,7 +4286,7 @@ class Diaspora foreach ($recips as $recip) { logger("Send updated profile data for user ".$uid." to contact ".$recip["id"], LOGGER_DEBUG); - self::buildAndTransmit($profile, $recip, "profile", $message, false, "", true); + self::buildAndTransmit($owner, $recip, "profile", $message, false, "", true); } } @@ -4104,18 +4318,22 @@ class Diaspora return false; } - if (!in_array($r[0]["verb"], array(ACTIVITY_LIKE, ACTIVITY_DISLIKE))) { + if (!in_array($r[0]["verb"], [ACTIVITY_LIKE, ACTIVITY_DISLIKE])) { return false; } $message = self::constructLike($r[0], $contact); + if ($message === false) { + return false; + } + $message["author_signature"] = self::signature($contact, $message); /* * Now store the signature more flexible to dynamically support new fields. * This will break Diaspora compatibility with Friendica versions prior to 3.5. */ - dba::insert('sign', array('iid' => $post_id, 'signed_text' => json_encode($message))); + dba::insert('sign', ['iid' => $post_id, 'signed_text' => json_encode($message)]); logger('Stored diaspora like signature'); return true; @@ -4141,13 +4359,17 @@ class Diaspora $contact["uprvkey"] = $uprvkey; $message = self::constructComment($item, $contact); + if ($message === false) { + return false; + } + $message["author_signature"] = self::signature($contact, $message); /* * Now store the signature more flexible to dynamically support new fields. * This will break Diaspora compatibility with Friendica versions prior to 3.5. */ - dba::insert('sign', array('iid' => $message_id, 'signed_text' => json_encode($message))); + dba::insert('sign', ['iid' => $message_id, 'signed_text' => json_encode($message)]); logger('Stored diaspora comment signature'); return true;