X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=src%2FProtocol%2FSalmon.php;h=aecc35e9f9372f34159f7899a320c87c05dc0a55;hb=41f502266e10dfa7f10a51bf47dcfb9a31ca9afc;hp=f30488ce140eeef304b7dd99eb8258707c11c014;hpb=d53e53cceb2823cceec36f91f39f8b1e6459a648;p=friendica.git diff --git a/src/Protocol/Salmon.php b/src/Protocol/Salmon.php index f30488ce14..aecc35e9f9 100644 --- a/src/Protocol/Salmon.php +++ b/src/Protocol/Salmon.php @@ -1,16 +1,36 @@ . + * */ + namespace Friendica\Protocol; +use Friendica\Core\Logger; +use Friendica\DI; use Friendica\Network\Probe; use Friendica\Util\Crypto; -use Friendica\Util\Network; +use Friendica\Util\Strings; use Friendica\Util\XML; /** - * @brief Salmon Protocol class + * Salmon Protocol class + * * The Salmon Protocol is a message exchange protocol running over HTTP designed to decentralize commentary * and annotations made against newsfeed articles such as blog posts. */ @@ -20,12 +40,13 @@ class Salmon * @param string $uri Uniform Resource Identifier * @param string $keyhash encoded key * @return mixed + * @throws \Friendica\Network\HTTPException\InternalServerErrorException */ public static function getKey($uri, $keyhash) { $ret = []; - logger('Fetching salmon key for '.$uri); + Logger::info('Fetching salmon key for '.$uri); $arr = Probe::lrdd($uri); @@ -50,14 +71,14 @@ class Salmon } else { $ret[$x] = substr($ret[$x], 5); } - } elseif (normalise_link($ret[$x]) == 'http://') { - $ret[$x] = Network::fetchUrl($ret[$x]); + } elseif (Strings::normaliseLink($ret[$x]) == 'http://') { + $ret[$x] = DI::httpClient()->fetch($ret[$x]); } } } - logger('Key located: ' . print_r($ret, true)); + Logger::notice('Key located', ['ret' => $ret]); if (count($ret) == 1) { // We only found one one key so we don't care if the hash matches. @@ -69,7 +90,7 @@ class Salmon return $ret[0]; } else { foreach ($ret as $a) { - $hash = base64url_encode(hash('sha256', $a)); + $hash = Strings::base64UrlEncode(hash('sha256', $a)); if ($hash == $keyhash) { return $a; } @@ -84,41 +105,42 @@ class Salmon * @param string $url url * @param string $slap slap * @return integer + * @throws \Friendica\Network\HTTPException\InternalServerErrorException */ public static function slapper($owner, $url, $slap) { // does contact have a salmon endpoint? - if (! strlen($url)) { + if (!strlen($url)) { return; } - if (! $owner['sprvkey']) { - logger(sprintf("user '%s' (%d) does not have a salmon private key. Send failed.", - $owner['username'], $owner['uid'])); + if (!$owner['sprvkey']) { + Logger::notice(sprintf("user '%s' (%d) does not have a salmon private key. Send failed.", + $owner['name'], $owner['uid'])); return; } - logger('slapper called for '.$url.'. Data: ' . $slap); + Logger::info('slapper called for '.$url.'. Data: ' . $slap); // create a magic envelope - $data = base64url_encode($slap); + $data = Strings::base64UrlEncode($slap); $data_type = 'application/atom+xml'; $encoding = 'base64url'; $algorithm = 'RSA-SHA256'; - $keyhash = base64url_encode(hash('sha256', self::salmonKey($owner['spubkey'])), true); + $keyhash = Strings::base64UrlEncode(hash('sha256', self::salmonKey($owner['spubkey'])), true); - $precomputed = '.' . base64url_encode($data_type) . '.' . base64url_encode($encoding) . '.' . base64url_encode($algorithm); + $precomputed = '.' . Strings::base64UrlEncode($data_type) . '.' . Strings::base64UrlEncode($encoding) . '.' . Strings::base64UrlEncode($algorithm); // GNU Social format - $signature = base64url_encode(Crypto::rsaSign($data . $precomputed, $owner['sprvkey'])); + $signature = Strings::base64UrlEncode(Crypto::rsaSign($data . $precomputed, $owner['sprvkey'])); // Compliant format - $signature2 = base64url_encode(Crypto::rsaSign(str_replace('=', '', $data . $precomputed), $owner['sprvkey'])); + $signature2 = Strings::base64UrlEncode(Crypto::rsaSign(str_replace('=', '', $data . $precomputed), $owner['sprvkey'])); // Old Status.net format - $signature3 = base64url_encode(Crypto::rsaSign($data, $owner['sprvkey'])); + $signature3 = Strings::base64UrlEncode(Crypto::rsaSign($data, $owner['sprvkey'])); // At first try the non compliant method that works for GNU Social $xmldata = ["me:env" => ["me:data" => $data, @@ -133,18 +155,17 @@ class Salmon $salmon = XML::fromArray($xmldata, $xml, false, $namespaces); // slap them - Network::post($url, $salmon, [ - 'Content-type: application/magic-envelope+xml', - 'Content-length: ' . strlen($salmon) + $postResult = DI::httpClient()->post($url, $salmon, [ + 'Content-type' => 'application/magic-envelope+xml', + 'Content-length' => strlen($salmon), ]); - $a = get_app(); - $return_code = $a->get_curl_code(); + $return_code = $postResult->getReturnCode(); // check for success, e.g. 2xx if ($return_code > 299) { - logger('GNU Social salmon failed. Falling back to compliant mode'); + Logger::notice('GNU Social salmon failed. Falling back to compliant mode'); // Now try the compliant mode that normally isn't used for GNU Social $xmldata = ["me:env" => ["me:data" => $data, @@ -159,15 +180,15 @@ class Salmon $salmon = XML::fromArray($xmldata, $xml, false, $namespaces); // slap them - Network::post($url, $salmon, [ - 'Content-type: application/magic-envelope+xml', - 'Content-length: ' . strlen($salmon) + $postResult = DI::httpClient()->post($url, $salmon, [ + 'Content-type' => 'application/magic-envelope+xml', + 'Content-length' => strlen($salmon), ]); - $return_code = $a->get_curl_code(); + $return_code = $postResult->getReturnCode(); } if ($return_code > 299) { - logger('compliant salmon failed. Falling back to old status.net'); + Logger::notice('compliant salmon failed. Falling back to old status.net'); // Last try. This will most likely fail as well. $xmldata = ["me:env" => ["me:data" => $data, @@ -182,19 +203,19 @@ class Salmon $salmon = XML::fromArray($xmldata, $xml, false, $namespaces); // slap them - Network::post($url, $salmon, [ - 'Content-type: application/magic-envelope+xml', - 'Content-length: ' . strlen($salmon)]); - $return_code = $a->get_curl_code(); + $postResult = DI::httpClient()->post($url, $salmon, [ + 'Content-type' => 'application/magic-envelope+xml', + 'Content-length' => strlen($salmon)]); + $return_code = $postResult->getReturnCode(); } - logger('slapper for '.$url.' returned ' . $return_code); + Logger::info('slapper for '.$url.' returned ' . $return_code); if (! $return_code) { return -1; } - if (($return_code == 503) && (stristr($a->get_curl_headers(), 'retry-after'))) { + if (($return_code == 503) && $postResult->inHeader('retry-after')) { return -1; } @@ -204,10 +225,11 @@ class Salmon /** * @param string $pubkey public key * @return string + * @throws \Exception */ public static function salmonKey($pubkey) { - Crypto::pemToMe($pubkey, $m, $e); - return 'RSA' . '.' . base64url_encode($m, true) . '.' . base64url_encode($e, true); + Crypto::pemToMe($pubkey, $modulus, $exponent); + return 'RSA' . '.' . Strings::base64UrlEncode($modulus, true) . '.' . Strings::base64UrlEncode($exponent, true); } }