X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=src%2FWorker%2FDBClean.php;h=4fcef805ffeb10488fe3681bcd3523b168e7fde3;hb=24a82110fd45a8422efee0677b7acc214aa66e9a;hp=11e73c24a20790a8291122b67ca92d5f5cfc96c3;hpb=6c36fd9e01510a14fea9de766b4afe6760912a2e;p=friendica.git

diff --git a/src/Worker/DBClean.php b/src/Worker/DBClean.php
index 11e73c24a2..4fcef805ff 100644
--- a/src/Worker/DBClean.php
+++ b/src/Worker/DBClean.php
@@ -1,16 +1,34 @@
 <?php
 /**
- * @file src/Worker/DBClean.php
- * The script is called from time to time to clean the database entries and remove orphaned data.
+ * @copyright Copyright (C) 2020, Friendica
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
  */
 
 namespace Friendica\Worker;
 
-use Friendica\Core\Config;
 use Friendica\Core\Logger;
 use Friendica\Core\Worker;
 use Friendica\Database\DBA;
+use Friendica\DI;
 
+/**
+ * The script is called from time to time to clean the database entries and remove orphaned data.
+ */
 class DBClean {
 	public static function execute($stage = 0) {
 
@@ -53,7 +71,7 @@ class DBClean {
 	 *  3:    Orphaned data from thread table.
 	 *  4:    Orphaned data from notify table.
 	 *  5:    Orphaned data from notify-threads table.
-	 *  6:    Orphaned data from sign table.
+	 *  6:    Legacy functionality (removed)
 	 *  7:    Orphaned data from term table.
 	 *  8:    Expired threads.
 	 *  9:    Old global item entries from expired threads.
@@ -80,7 +98,7 @@ class DBClean {
 			$last_id = DI::config()->get('system', 'dbclean-last-id-1', 0);
 
 			Logger::log("Deleting old global item entries from item table without user copy. Last ID: ".$last_id);
-			$r = DBA::p("SELECT `id` FROM `item` WHERE `uid` = 0 AND
+			$r = DBA::p("SELECT `id`, `guid` FROM `item` WHERE `uid` = 0 AND
 						NOT EXISTS (SELECT `guid` FROM `item` AS `i` WHERE `item`.`guid` = `i`.`guid` AND `i`.`uid` != 0) AND
 						`received` < UTC_TIMESTAMP() - INTERVAL ? DAY AND `id` >= ?
 					ORDER BY `id` LIMIT ?", $days_unclaimed, $last_id, $limit);
@@ -89,6 +107,7 @@ class DBClean {
 				Logger::log("found global item orphans: ".$count);
 				while ($orphan = DBA::fetch($r)) {
 					$last_id = $orphan["id"];
+					Logger::info('Delete global orphan item', ['id' => $orphan['id'], 'guid' => $orphan['guid']]);
 					DBA::delete('item', ['id' => $orphan["id"]]);
 				}
 				Worker::add(PRIORITY_MEDIUM, 'DBClean', 1, $last_id);
@@ -98,12 +117,12 @@ class DBClean {
 			DBA::close($r);
 			Logger::log("Done deleting ".$count." old global item entries from item table without user copy. Last ID: ".$last_id);
 
-			Config::set('system', 'dbclean-last-id-1', $last_id);
+			DI::config()->set('system', 'dbclean-last-id-1', $last_id);
 		} elseif ($stage == 2) {
 			$last_id = DI::config()->get('system', 'dbclean-last-id-2', 0);
 
 			Logger::log("Deleting items without parents. Last ID: ".$last_id);
-			$r = DBA::p("SELECT `id` FROM `item`
+			$r = DBA::p("SELECT `id`, `guid` FROM `item`
 					WHERE NOT EXISTS (SELECT `id` FROM `item` AS `i` WHERE `item`.`parent` = `i`.`id`)
 					AND `id` >= ? ORDER BY `id` LIMIT ?", $last_id, $limit);
 			$count = DBA::numRows($r);
@@ -111,6 +130,7 @@ class DBClean {
 				Logger::log("found item orphans without parents: ".$count);
 				while ($orphan = DBA::fetch($r)) {
 					$last_id = $orphan["id"];
+					Logger::info('Delete orphan item', ['id' => $orphan['id'], 'guid' => $orphan['guid']]);
 					DBA::delete('item', ['id' => $orphan["id"]]);
 				}
 				Worker::add(PRIORITY_MEDIUM, 'DBClean', 2, $last_id);
@@ -120,10 +140,10 @@ class DBClean {
 			DBA::close($r);
 			Logger::log("Done deleting ".$count." items without parents. Last ID: ".$last_id);
 
-			Config::set('system', 'dbclean-last-id-2', $last_id);
+			DI::config()->set('system', 'dbclean-last-id-2', $last_id);
 
 			if ($count < $limit) {
-				Config::set('system', 'finished-dbclean-2', true);
+				DI::config()->set('system', 'finished-dbclean-2', true);
 			}
 		} elseif ($stage == 3) {
 			$last_id = DI::config()->get('system', 'dbclean-last-id-3', 0);
@@ -146,10 +166,10 @@ class DBClean {
 			DBA::close($r);
 			Logger::log("Done deleting ".$count." orphaned data from thread table. Last ID: ".$last_id);
 
-			Config::set('system', 'dbclean-last-id-3', $last_id);
+			DI::config()->set('system', 'dbclean-last-id-3', $last_id);
 
 			if ($count < $limit) {
-				Config::set('system', 'finished-dbclean-3', true);
+				DI::config()->set('system', 'finished-dbclean-3', true);
 			}
 		} elseif ($stage == 4) {
 			$last_id = DI::config()->get('system', 'dbclean-last-id-4', 0);
@@ -172,10 +192,10 @@ class DBClean {
 			DBA::close($r);
 			Logger::log("Done deleting ".$count." orphaned data from notify table. Last ID: ".$last_id);
 
-			Config::set('system', 'dbclean-last-id-4', $last_id);
+			DI::config()->set('system', 'dbclean-last-id-4', $last_id);
 
 			if ($count < $limit) {
-				Config::set('system', 'finished-dbclean-4', true);
+				DI::config()->set('system', 'finished-dbclean-4', true);
 			}
 		} elseif ($stage == 5) {
 			$last_id = DI::config()->get('system', 'dbclean-last-id-5', 0);
@@ -198,63 +218,17 @@ class DBClean {
 			DBA::close($r);
 			Logger::log("Done deleting ".$count." orphaned data from notify-threads table. Last ID: ".$last_id);
 
-			Config::set('system', 'dbclean-last-id-5', $last_id);
+			DI::config()->set('system', 'dbclean-last-id-5', $last_id);
 
 			if ($count < $limit) {
-				Config::set('system', 'finished-dbclean-5', true);
+				DI::config()->set('system', 'finished-dbclean-5', true);
 			}
 		} elseif ($stage == 6) {
-			$last_id = DI::config()->get('system', 'dbclean-last-id-6', 0);
-
-			Logger::log("Deleting orphaned data from sign table. Last ID: ".$last_id);
-			$r = DBA::p("SELECT `iid`, `id` FROM `sign`
-					WHERE NOT EXISTS (SELECT `id` FROM `item` WHERE `item`.`id` = `sign`.`iid`) AND `id` >= ?
-					ORDER BY `id` LIMIT ?", $last_id, $limit);
-			$count = DBA::numRows($r);
-			if ($count > 0) {
-				Logger::log("found sign orphans: ".$count);
-				while ($orphan = DBA::fetch($r)) {
-					$last_id = $orphan["id"];
-					DBA::delete('sign', ['iid' => $orphan["iid"]]);
-				}
-				Worker::add(PRIORITY_MEDIUM, 'DBClean', 6, $last_id);
-			} else {
-				Logger::log("No sign orphans found");
-			}
-			DBA::close($r);
-			Logger::log("Done deleting ".$count." orphaned data from sign table. Last ID: ".$last_id);
-
-			Config::set('system', 'dbclean-last-id-6', $last_id);
-
-			if ($count < $limit) {
-				Config::set('system', 'finished-dbclean-6', true);
-			}
+			// The legacy functionality had been removed
+			DI::config()->set('system', 'finished-dbclean-6', true);
 		} elseif ($stage == 7) {
-			$last_id = DI::config()->get('system', 'dbclean-last-id-7', 0);
-
-			Logger::log("Deleting orphaned data from term table. Last ID: ".$last_id);
-			$r = DBA::p("SELECT `oid`, `tid` FROM `term`
-					WHERE NOT EXISTS (SELECT `id` FROM `item` WHERE `item`.`id` = `term`.`oid`) AND `tid` >= ?
-					ORDER BY `tid` LIMIT ?", $last_id, $limit);
-			$count = DBA::numRows($r);
-			if ($count > 0) {
-				Logger::log("found term orphans: ".$count);
-				while ($orphan = DBA::fetch($r)) {
-					$last_id = $orphan["tid"];
-					DBA::delete('term', ['oid' => $orphan["oid"]]);
-				}
-				Worker::add(PRIORITY_MEDIUM, 'DBClean', 7, $last_id);
-			} else {
-				Logger::log("No term orphans found");
-			}
-			DBA::close($r);
-			Logger::log("Done deleting ".$count." orphaned data from term table. Last ID: ".$last_id);
-
-			Config::set('system', 'dbclean-last-id-7', $last_id);
-
-			if ($count < $limit) {
-				Config::set('system', 'finished-dbclean-7', true);
-			}
+			// The legacy functionality had been removed
+			DI::config()->set('system', 'finished-dbclean-7', true);
 		} elseif ($stage == 8) {
 			if ($days <= 0) {
 				return;
@@ -289,7 +263,7 @@ class DBClean {
 			DBA::close($r);
 			Logger::log("Done deleting ".$count." expired threads. Last ID: ".$last_id);
 
-			Config::set('system', 'dbclean-last-id-8', $last_id);
+			DI::config()->set('system', 'dbclean-last-id-8', $last_id);
 		} elseif ($stage == 9) {
 			if ($days <= 0) {
 				return;
@@ -299,7 +273,7 @@ class DBClean {
 			$till_id = DI::config()->get('system', 'dbclean-last-id-8', 0);
 
 			Logger::log("Deleting old global item entries from expired threads from ID ".$last_id." to ID ".$till_id);
-			$r = DBA::p("SELECT `id` FROM `item` WHERE `uid` = 0 AND
+			$r = DBA::p("SELECT `id`, `guid` FROM `item` WHERE `uid` = 0 AND
 						NOT EXISTS (SELECT `guid` FROM `item` AS `i` WHERE `item`.`guid` = `i`.`guid` AND `i`.`uid` != 0) AND
 						`received` < UTC_TIMESTAMP() - INTERVAL 90 DAY AND `id` >= ? AND `id` <= ?
 					ORDER BY `id` LIMIT ?", $last_id, $till_id, $limit);
@@ -308,6 +282,7 @@ class DBClean {
 				Logger::log("found global item entries from expired threads: ".$count);
 				while ($orphan = DBA::fetch($r)) {
 					$last_id = $orphan["id"];
+					Logger::info('Delete expired thread item', ['id' => $orphan['id'], 'guid' => $orphan['guid']]);
 					DBA::delete('item', ['id' => $orphan["id"]]);
 				}
 				Worker::add(PRIORITY_MEDIUM, 'DBClean', 9, $last_id);
@@ -317,7 +292,7 @@ class DBClean {
 			DBA::close($r);
 			Logger::log("Done deleting ".$count." old global item entries from expired threads. Last ID: ".$last_id);
 
-			Config::set('system', 'dbclean-last-id-9', $last_id);
+			DI::config()->set('system', 'dbclean-last-id-9', $last_id);
 		} elseif ($stage == 10) {
 			$last_id = DI::config()->get('system', 'dbclean-last-id-10', 0);
 			$days = intval(DI::config()->get('system', 'dbclean_expire_conversation', 90));
@@ -340,7 +315,7 @@ class DBClean {
 			DBA::close($r);
 			Logger::log("Done deleting ".$count." conversations. Last created: ".$last_id);
 
-			Config::set('system', 'dbclean-last-id-10', $last_id);
+			DI::config()->set('system', 'dbclean-last-id-10', $last_id);
 		}
 	}
 }